@aztec/p2p 0.0.1-commit.7cf39cb55 → 0.0.1-commit.7ffbba4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (286) hide show
  1. package/dest/client/factory.d.ts +7 -7
  2. package/dest/client/factory.d.ts.map +1 -1
  3. package/dest/client/factory.js +19 -28
  4. package/dest/client/interface.d.ts +10 -19
  5. package/dest/client/interface.d.ts.map +1 -1
  6. package/dest/client/p2p_client.d.ts +7 -18
  7. package/dest/client/p2p_client.d.ts.map +1 -1
  8. package/dest/client/p2p_client.js +41 -96
  9. package/dest/client/test/tx_proposal_collector/proposal_tx_collector_worker.js +6 -7
  10. package/dest/config.d.ts +22 -15
  11. package/dest/config.d.ts.map +1 -1
  12. package/dest/config.js +66 -37
  13. package/dest/errors/tx-pool.error.d.ts +8 -0
  14. package/dest/errors/tx-pool.error.d.ts.map +1 -0
  15. package/dest/errors/tx-pool.error.js +9 -0
  16. package/dest/mem_pools/attestation_pool/attestation_pool.d.ts +1 -1
  17. package/dest/mem_pools/attestation_pool/attestation_pool.d.ts.map +1 -1
  18. package/dest/mem_pools/attestation_pool/attestation_pool.js +5 -1
  19. package/dest/mem_pools/attestation_pool/mocks.d.ts +2 -2
  20. package/dest/mem_pools/attestation_pool/mocks.d.ts.map +1 -1
  21. package/dest/mem_pools/attestation_pool/mocks.js +2 -2
  22. package/dest/mem_pools/instrumentation.d.ts +4 -2
  23. package/dest/mem_pools/instrumentation.d.ts.map +1 -1
  24. package/dest/mem_pools/instrumentation.js +16 -14
  25. package/dest/mem_pools/tx_pool/eviction/invalid_txs_after_mining_rule.js +3 -3
  26. package/dest/mem_pools/tx_pool_v2/deleted_pool.d.ts +3 -1
  27. package/dest/mem_pools/tx_pool_v2/deleted_pool.d.ts.map +1 -1
  28. package/dest/mem_pools/tx_pool_v2/deleted_pool.js +9 -0
  29. package/dest/mem_pools/tx_pool_v2/eviction/eviction_manager.d.ts +3 -3
  30. package/dest/mem_pools/tx_pool_v2/eviction/eviction_manager.d.ts.map +1 -1
  31. package/dest/mem_pools/tx_pool_v2/eviction/eviction_manager.js +18 -9
  32. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.js +3 -3
  33. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.d.ts +3 -3
  34. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.d.ts.map +1 -1
  35. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.js +12 -4
  36. package/dest/mem_pools/tx_pool_v2/eviction/index.d.ts +2 -2
  37. package/dest/mem_pools/tx_pool_v2/eviction/index.d.ts.map +1 -1
  38. package/dest/mem_pools/tx_pool_v2/eviction/index.js +1 -1
  39. package/dest/mem_pools/tx_pool_v2/eviction/interfaces.d.ts +54 -5
  40. package/dest/mem_pools/tx_pool_v2/eviction/interfaces.d.ts.map +1 -1
  41. package/dest/mem_pools/tx_pool_v2/eviction/interfaces.js +8 -0
  42. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_mining_rule.js +4 -4
  43. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_reorg_rule.js +5 -5
  44. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.d.ts +2 -2
  45. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.d.ts.map +1 -1
  46. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.js +12 -6
  47. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.d.ts +4 -4
  48. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.d.ts.map +1 -1
  49. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.js +16 -4
  50. package/dest/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.d.ts +3 -3
  51. package/dest/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.d.ts.map +1 -1
  52. package/dest/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.js +3 -3
  53. package/dest/mem_pools/tx_pool_v2/index.d.ts +2 -2
  54. package/dest/mem_pools/tx_pool_v2/index.d.ts.map +1 -1
  55. package/dest/mem_pools/tx_pool_v2/index.js +1 -1
  56. package/dest/mem_pools/tx_pool_v2/instrumentation.d.ts +15 -0
  57. package/dest/mem_pools/tx_pool_v2/instrumentation.d.ts.map +1 -0
  58. package/dest/mem_pools/tx_pool_v2/instrumentation.js +43 -0
  59. package/dest/mem_pools/tx_pool_v2/interfaces.d.ts +18 -6
  60. package/dest/mem_pools/tx_pool_v2/interfaces.d.ts.map +1 -1
  61. package/dest/mem_pools/tx_pool_v2/interfaces.js +4 -1
  62. package/dest/mem_pools/tx_pool_v2/tx_metadata.d.ts +46 -14
  63. package/dest/mem_pools/tx_pool_v2/tx_metadata.d.ts.map +1 -1
  64. package/dest/mem_pools/tx_pool_v2/tx_metadata.js +99 -17
  65. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.d.ts +5 -2
  66. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.d.ts.map +1 -1
  67. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.js +38 -46
  68. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.d.ts +6 -3
  69. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.d.ts.map +1 -1
  70. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.js +9 -5
  71. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.d.ts +12 -5
  72. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.d.ts.map +1 -1
  73. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.js +277 -148
  74. package/dest/msg_validators/proposal_validator/block_proposal_validator.d.ts +6 -4
  75. package/dest/msg_validators/proposal_validator/block_proposal_validator.d.ts.map +1 -1
  76. package/dest/msg_validators/proposal_validator/block_proposal_validator.js +10 -2
  77. package/dest/msg_validators/proposal_validator/checkpoint_proposal_validator.d.ts +6 -4
  78. package/dest/msg_validators/proposal_validator/checkpoint_proposal_validator.d.ts.map +1 -1
  79. package/dest/msg_validators/proposal_validator/checkpoint_proposal_validator.js +16 -2
  80. package/dest/msg_validators/proposal_validator/proposal_validator.d.ts +13 -8
  81. package/dest/msg_validators/proposal_validator/proposal_validator.d.ts.map +1 -1
  82. package/dest/msg_validators/proposal_validator/proposal_validator.js +48 -36
  83. package/dest/msg_validators/tx_validator/aggregate_tx_validator.d.ts +2 -2
  84. package/dest/msg_validators/tx_validator/aggregate_tx_validator.d.ts.map +1 -1
  85. package/dest/msg_validators/tx_validator/aggregate_tx_validator.js +3 -3
  86. package/dest/msg_validators/tx_validator/allowed_public_setup.d.ts +2 -1
  87. package/dest/msg_validators/tx_validator/allowed_public_setup.d.ts.map +1 -1
  88. package/dest/msg_validators/tx_validator/allowed_public_setup.js +24 -20
  89. package/dest/msg_validators/tx_validator/allowed_setup_helpers.d.ts +17 -0
  90. package/dest/msg_validators/tx_validator/allowed_setup_helpers.d.ts.map +1 -0
  91. package/dest/msg_validators/tx_validator/allowed_setup_helpers.js +24 -0
  92. package/dest/msg_validators/tx_validator/factory.d.ts +114 -6
  93. package/dest/msg_validators/tx_validator/factory.d.ts.map +1 -1
  94. package/dest/msg_validators/tx_validator/factory.js +219 -58
  95. package/dest/msg_validators/tx_validator/fee_payer_balance.d.ts +1 -1
  96. package/dest/msg_validators/tx_validator/fee_payer_balance.d.ts.map +1 -1
  97. package/dest/msg_validators/tx_validator/fee_payer_balance.js +6 -2
  98. package/dest/msg_validators/tx_validator/gas_validator.d.ts +58 -3
  99. package/dest/msg_validators/tx_validator/gas_validator.d.ts.map +1 -1
  100. package/dest/msg_validators/tx_validator/gas_validator.js +73 -36
  101. package/dest/msg_validators/tx_validator/index.d.ts +3 -1
  102. package/dest/msg_validators/tx_validator/index.d.ts.map +1 -1
  103. package/dest/msg_validators/tx_validator/index.js +2 -0
  104. package/dest/msg_validators/tx_validator/metadata_validator.d.ts +1 -1
  105. package/dest/msg_validators/tx_validator/metadata_validator.d.ts.map +1 -1
  106. package/dest/msg_validators/tx_validator/metadata_validator.js +4 -4
  107. package/dest/msg_validators/tx_validator/nullifier_cache.d.ts +14 -0
  108. package/dest/msg_validators/tx_validator/nullifier_cache.d.ts.map +1 -0
  109. package/dest/msg_validators/tx_validator/nullifier_cache.js +24 -0
  110. package/dest/msg_validators/tx_validator/phases_validator.d.ts +2 -2
  111. package/dest/msg_validators/tx_validator/phases_validator.d.ts.map +1 -1
  112. package/dest/msg_validators/tx_validator/phases_validator.js +44 -23
  113. package/dest/msg_validators/tx_validator/timestamp_validator.d.ts +2 -2
  114. package/dest/msg_validators/tx_validator/timestamp_validator.d.ts.map +1 -1
  115. package/dest/msg_validators/tx_validator/timestamp_validator.js +6 -6
  116. package/dest/services/dummy_service.d.ts +4 -4
  117. package/dest/services/dummy_service.d.ts.map +1 -1
  118. package/dest/services/dummy_service.js +4 -4
  119. package/dest/services/encoding.d.ts +2 -2
  120. package/dest/services/encoding.d.ts.map +1 -1
  121. package/dest/services/encoding.js +9 -8
  122. package/dest/services/gossipsub/topic_score_params.d.ts +18 -6
  123. package/dest/services/gossipsub/topic_score_params.d.ts.map +1 -1
  124. package/dest/services/gossipsub/topic_score_params.js +32 -10
  125. package/dest/services/libp2p/libp2p_service.d.ts +16 -13
  126. package/dest/services/libp2p/libp2p_service.d.ts.map +1 -1
  127. package/dest/services/libp2p/libp2p_service.js +84 -90
  128. package/dest/services/peer-manager/metrics.d.ts +3 -1
  129. package/dest/services/peer-manager/metrics.d.ts.map +1 -1
  130. package/dest/services/peer-manager/metrics.js +6 -0
  131. package/dest/services/peer-manager/peer_manager.d.ts +1 -1
  132. package/dest/services/peer-manager/peer_manager.d.ts.map +1 -1
  133. package/dest/services/peer-manager/peer_manager.js +2 -1
  134. package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.d.ts +4 -3
  135. package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.d.ts.map +1 -1
  136. package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.js +19 -46
  137. package/dest/services/reqresp/batch-tx-requester/interface.d.ts +2 -6
  138. package/dest/services/reqresp/batch-tx-requester/interface.d.ts.map +1 -1
  139. package/dest/services/reqresp/batch-tx-requester/missing_txs.d.ts +10 -13
  140. package/dest/services/reqresp/batch-tx-requester/missing_txs.d.ts.map +1 -1
  141. package/dest/services/reqresp/batch-tx-requester/missing_txs.js +25 -46
  142. package/dest/services/reqresp/batch-tx-requester/peer_collection.d.ts +17 -11
  143. package/dest/services/reqresp/batch-tx-requester/peer_collection.d.ts.map +1 -1
  144. package/dest/services/reqresp/batch-tx-requester/peer_collection.js +49 -15
  145. package/dest/services/reqresp/batch-tx-requester/tx_validator.js +2 -2
  146. package/dest/services/reqresp/reqresp.d.ts +1 -1
  147. package/dest/services/reqresp/reqresp.d.ts.map +1 -1
  148. package/dest/services/reqresp/reqresp.js +2 -1
  149. package/dest/services/service.d.ts +5 -3
  150. package/dest/services/service.d.ts.map +1 -1
  151. package/dest/services/tx_collection/fast_tx_collection.d.ts +1 -1
  152. package/dest/services/tx_collection/fast_tx_collection.d.ts.map +1 -1
  153. package/dest/services/tx_collection/fast_tx_collection.js +39 -33
  154. package/dest/services/tx_collection/file_store_tx_collection.d.ts +1 -1
  155. package/dest/services/tx_collection/file_store_tx_collection.d.ts.map +1 -1
  156. package/dest/services/tx_collection/file_store_tx_collection.js +4 -2
  157. package/dest/services/tx_collection/file_store_tx_source.d.ts +15 -6
  158. package/dest/services/tx_collection/file_store_tx_source.d.ts.map +1 -1
  159. package/dest/services/tx_collection/file_store_tx_source.js +47 -16
  160. package/dest/services/tx_collection/instrumentation.d.ts +1 -1
  161. package/dest/services/tx_collection/instrumentation.d.ts.map +1 -1
  162. package/dest/services/tx_collection/instrumentation.js +2 -1
  163. package/dest/services/tx_collection/missing_txs_tracker.d.ts +32 -0
  164. package/dest/services/tx_collection/missing_txs_tracker.d.ts.map +1 -0
  165. package/dest/services/tx_collection/missing_txs_tracker.js +27 -0
  166. package/dest/services/tx_collection/proposal_tx_collector.d.ts +7 -6
  167. package/dest/services/tx_collection/proposal_tx_collector.d.ts.map +1 -1
  168. package/dest/services/tx_collection/proposal_tx_collector.js +5 -4
  169. package/dest/services/tx_collection/slow_tx_collection.d.ts +2 -2
  170. package/dest/services/tx_collection/slow_tx_collection.d.ts.map +1 -1
  171. package/dest/services/tx_collection/slow_tx_collection.js +10 -8
  172. package/dest/services/tx_collection/tx_collection.d.ts +5 -4
  173. package/dest/services/tx_collection/tx_collection.d.ts.map +1 -1
  174. package/dest/services/tx_collection/tx_collection_sink.d.ts +6 -5
  175. package/dest/services/tx_collection/tx_collection_sink.d.ts.map +1 -1
  176. package/dest/services/tx_collection/tx_collection_sink.js +13 -22
  177. package/dest/services/tx_collection/tx_source.d.ts +8 -3
  178. package/dest/services/tx_collection/tx_source.d.ts.map +1 -1
  179. package/dest/services/tx_collection/tx_source.js +19 -2
  180. package/dest/services/tx_file_store/tx_file_store.js +1 -1
  181. package/dest/services/tx_provider.d.ts +3 -3
  182. package/dest/services/tx_provider.d.ts.map +1 -1
  183. package/dest/services/tx_provider.js +4 -4
  184. package/dest/test-helpers/make-test-p2p-clients.d.ts +5 -6
  185. package/dest/test-helpers/make-test-p2p-clients.d.ts.map +1 -1
  186. package/dest/test-helpers/make-test-p2p-clients.js +1 -2
  187. package/dest/test-helpers/mock-pubsub.d.ts +4 -4
  188. package/dest/test-helpers/mock-pubsub.d.ts.map +1 -1
  189. package/dest/test-helpers/mock-pubsub.js +8 -2
  190. package/dest/test-helpers/reqresp-nodes.d.ts +2 -3
  191. package/dest/test-helpers/reqresp-nodes.d.ts.map +1 -1
  192. package/dest/test-helpers/reqresp-nodes.js +2 -2
  193. package/dest/test-helpers/testbench-utils.d.ts +6 -3
  194. package/dest/test-helpers/testbench-utils.d.ts.map +1 -1
  195. package/dest/test-helpers/testbench-utils.js +1 -1
  196. package/dest/testbench/p2p_client_testbench_worker.d.ts +2 -2
  197. package/dest/testbench/p2p_client_testbench_worker.d.ts.map +1 -1
  198. package/dest/testbench/p2p_client_testbench_worker.js +15 -14
  199. package/dest/testbench/worker_client_manager.d.ts +3 -1
  200. package/dest/testbench/worker_client_manager.d.ts.map +1 -1
  201. package/dest/testbench/worker_client_manager.js +6 -2
  202. package/dest/util.d.ts +3 -3
  203. package/dest/util.d.ts.map +1 -1
  204. package/package.json +14 -14
  205. package/src/client/factory.ts +29 -49
  206. package/src/client/interface.ts +11 -20
  207. package/src/client/p2p_client.ts +47 -126
  208. package/src/client/test/tx_proposal_collector/proposal_tx_collector_worker.ts +20 -11
  209. package/src/config.ts +92 -43
  210. package/src/errors/tx-pool.error.ts +12 -0
  211. package/src/mem_pools/attestation_pool/attestation_pool.ts +5 -4
  212. package/src/mem_pools/attestation_pool/mocks.ts +2 -1
  213. package/src/mem_pools/instrumentation.ts +17 -13
  214. package/src/mem_pools/tx_pool/README.md +1 -1
  215. package/src/mem_pools/tx_pool/eviction/invalid_txs_after_mining_rule.ts +3 -3
  216. package/src/mem_pools/tx_pool_v2/README.md +10 -2
  217. package/src/mem_pools/tx_pool_v2/deleted_pool.ts +11 -0
  218. package/src/mem_pools/tx_pool_v2/eviction/eviction_manager.ts +21 -8
  219. package/src/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.ts +3 -3
  220. package/src/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.ts +18 -4
  221. package/src/mem_pools/tx_pool_v2/eviction/index.ts +4 -0
  222. package/src/mem_pools/tx_pool_v2/eviction/interfaces.ts +59 -4
  223. package/src/mem_pools/tx_pool_v2/eviction/invalid_txs_after_mining_rule.ts +4 -4
  224. package/src/mem_pools/tx_pool_v2/eviction/invalid_txs_after_reorg_rule.ts +5 -5
  225. package/src/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.ts +12 -9
  226. package/src/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.ts +33 -6
  227. package/src/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.ts +4 -3
  228. package/src/mem_pools/tx_pool_v2/index.ts +1 -1
  229. package/src/mem_pools/tx_pool_v2/instrumentation.ts +69 -0
  230. package/src/mem_pools/tx_pool_v2/interfaces.ts +18 -6
  231. package/src/mem_pools/tx_pool_v2/tx_metadata.ts +141 -25
  232. package/src/mem_pools/tx_pool_v2/tx_pool_indices.ts +43 -46
  233. package/src/mem_pools/tx_pool_v2/tx_pool_v2.ts +15 -7
  234. package/src/mem_pools/tx_pool_v2/tx_pool_v2_impl.ts +310 -144
  235. package/src/msg_validators/proposal_validator/block_proposal_validator.ts +14 -4
  236. package/src/msg_validators/proposal_validator/checkpoint_proposal_validator.ts +20 -7
  237. package/src/msg_validators/proposal_validator/proposal_validator.ts +63 -40
  238. package/src/msg_validators/tx_validator/README.md +115 -0
  239. package/src/msg_validators/tx_validator/aggregate_tx_validator.ts +3 -3
  240. package/src/msg_validators/tx_validator/allowed_public_setup.ts +22 -27
  241. package/src/msg_validators/tx_validator/allowed_setup_helpers.ts +31 -0
  242. package/src/msg_validators/tx_validator/factory.ts +353 -77
  243. package/src/msg_validators/tx_validator/fee_payer_balance.ts +6 -2
  244. package/src/msg_validators/tx_validator/gas_validator.ts +90 -27
  245. package/src/msg_validators/tx_validator/index.ts +2 -0
  246. package/src/msg_validators/tx_validator/metadata_validator.ts +12 -4
  247. package/src/msg_validators/tx_validator/nullifier_cache.ts +30 -0
  248. package/src/msg_validators/tx_validator/phases_validator.ts +51 -26
  249. package/src/msg_validators/tx_validator/timestamp_validator.ts +7 -7
  250. package/src/services/dummy_service.ts +6 -6
  251. package/src/services/encoding.ts +7 -7
  252. package/src/services/gossipsub/README.md +29 -14
  253. package/src/services/gossipsub/topic_score_params.ts +49 -13
  254. package/src/services/libp2p/libp2p_service.ts +95 -96
  255. package/src/services/peer-manager/metrics.ts +7 -0
  256. package/src/services/peer-manager/peer_manager.ts +2 -1
  257. package/src/services/reqresp/batch-tx-requester/batch_tx_requester.ts +20 -48
  258. package/src/services/reqresp/batch-tx-requester/interface.ts +1 -5
  259. package/src/services/reqresp/batch-tx-requester/missing_txs.ts +23 -71
  260. package/src/services/reqresp/batch-tx-requester/peer_collection.ts +63 -24
  261. package/src/services/reqresp/batch-tx-requester/tx_validator.ts +2 -2
  262. package/src/services/reqresp/reqresp.ts +3 -1
  263. package/src/services/service.ts +11 -2
  264. package/src/services/tx_collection/fast_tx_collection.ts +51 -30
  265. package/src/services/tx_collection/file_store_tx_collection.ts +7 -3
  266. package/src/services/tx_collection/file_store_tx_source.ts +61 -17
  267. package/src/services/tx_collection/instrumentation.ts +7 -1
  268. package/src/services/tx_collection/missing_txs_tracker.ts +52 -0
  269. package/src/services/tx_collection/proposal_tx_collector.ts +8 -7
  270. package/src/services/tx_collection/slow_tx_collection.ts +8 -9
  271. package/src/services/tx_collection/tx_collection.ts +4 -3
  272. package/src/services/tx_collection/tx_collection_sink.ts +15 -29
  273. package/src/services/tx_collection/tx_source.ts +22 -3
  274. package/src/services/tx_file_store/tx_file_store.ts +1 -1
  275. package/src/services/tx_provider.ts +2 -2
  276. package/src/test-helpers/make-test-p2p-clients.ts +1 -3
  277. package/src/test-helpers/mock-pubsub.ts +13 -6
  278. package/src/test-helpers/reqresp-nodes.ts +3 -6
  279. package/src/test-helpers/testbench-utils.ts +3 -3
  280. package/src/testbench/p2p_client_testbench_worker.ts +24 -20
  281. package/src/testbench/worker_client_manager.ts +13 -5
  282. package/src/util.ts +8 -2
  283. package/dest/msg_validators/proposal_validator/proposal_validator_test_suite.d.ts +0 -23
  284. package/dest/msg_validators/proposal_validator/proposal_validator_test_suite.d.ts.map +0 -1
  285. package/dest/msg_validators/proposal_validator/proposal_validator_test_suite.js +0 -212
  286. package/src/msg_validators/proposal_validator/proposal_validator_test_suite.ts +0 -230
@@ -73,7 +73,7 @@ export class PoolInstrumentation<PoolObject extends Gossipable> {
73
73
  private defaultAttributes;
74
74
  private meter: Meter;
75
75
 
76
- private txAddedTimestamp: Map<bigint, number> = new Map<bigint, number>();
76
+ private mempoolItemAddedTimestamp: Map<bigint | string, number> = new Map<bigint | string, number>();
77
77
 
78
78
  constructor(
79
79
  telemetry: TelemetryClient,
@@ -114,22 +114,26 @@ export class PoolInstrumentation<PoolObject extends Gossipable> {
114
114
  }
115
115
 
116
116
  public transactionsAdded(transactions: Tx[]) {
117
- const timestamp = Date.now();
118
- for (const transaction of transactions) {
119
- this.txAddedTimestamp.set(transaction.txHash.toBigInt(), timestamp);
120
- }
117
+ transactions.forEach(tx => this.trackMempoolItemAdded(tx.txHash.toBigInt()));
121
118
  }
122
119
 
123
120
  public transactionsRemoved(hashes: Iterable<bigint> | Iterable<string>) {
124
- const timestamp = Date.now();
125
121
  for (const hash of hashes) {
126
- const key = BigInt(hash);
127
- const addedAt = this.txAddedTimestamp.get(key);
128
- if (addedAt !== undefined) {
129
- this.txAddedTimestamp.delete(key);
130
- if (addedAt < timestamp) {
131
- this.minedDelay.record(timestamp - addedAt);
132
- }
122
+ this.trackMempoolItemRemoved(BigInt(hash));
123
+ }
124
+ }
125
+
126
+ public trackMempoolItemAdded(key: bigint | string): void {
127
+ this.mempoolItemAddedTimestamp.set(key, Date.now());
128
+ }
129
+
130
+ public trackMempoolItemRemoved(key: bigint | string): void {
131
+ const timestamp = Date.now();
132
+ const addedAt = this.mempoolItemAddedTimestamp.get(key);
133
+ if (addedAt !== undefined) {
134
+ this.mempoolItemAddedTimestamp.delete(key);
135
+ if (addedAt < timestamp) {
136
+ this.minedDelay.record(timestamp - addedAt);
133
137
  }
134
138
  }
135
139
  }
@@ -213,7 +213,7 @@ The [`EvictionManager`](eviction/eviction_manager.ts) coordinates eviction by:
213
213
  Evicts transactions that become invalid after a block is mined:
214
214
 
215
215
  - Duplicate nullifiers: Txs with nullifiers already included in the mined block
216
- - Expired transactions: Txs with `includeByTimestamp` ≤ mined block timestamp
216
+ - Expired transactions: Txs with `expirationTimestamp` ≤ mined block timestamp
217
217
 
218
218
  #### 2. `InvalidTxsAfterReorgRule`
219
219
 
@@ -68,10 +68,10 @@ export class InvalidTxsAfterMiningRule implements EvictionRule {
68
68
  }
69
69
 
70
70
  // Evict pending txs with an expiration timestamp less than or equal to the mined block timestamp
71
- const includeByTimestamp = tx.data.includeByTimestamp;
72
- if (includeByTimestamp <= timestamp) {
71
+ const expirationTimestamp = tx.data.expirationTimestamp;
72
+ if (expirationTimestamp <= timestamp) {
73
73
  this.log.verbose(
74
- `Evicting tx ${txHash} from pool due to the tx being expired (includeByTimestamp: ${includeByTimestamp}, mined block timestamp: ${timestamp})`,
74
+ `Evicting tx ${txHash} from pool due to the tx being expired (expirationTimestamp: ${expirationTimestamp}, mined block timestamp: ${timestamp})`,
75
75
  );
76
76
  txsToEvict.push(txHash);
77
77
  continue;
@@ -79,7 +79,7 @@ Lightweight metadata stored alongside each transaction:
79
79
  - `claimAmount`: Fee payer's claim from bridging
80
80
  - `feeLimit`: Maximum fee the tx can pay
81
81
  - `nullifiers`: For conflict detection
82
- - `includeByTimestamp`: Expiration timestamp
82
+ - `expirationTimestamp`: Expiration timestamp
83
83
  - `minedL2BlockId`: Set when mined (undefined otherwise)
84
84
 
85
85
  State is derived by TxPoolIndices:
@@ -158,7 +158,7 @@ Checked before adding a transaction to the pending pool:
158
158
 
159
159
  | Rule | Purpose |
160
160
  |------|---------|
161
- | `NullifierConflictRule` | Handles transactions with conflicting nullifiers. Higher priority tx wins. |
161
+ | `NullifierConflictRule` | Handles transactions with conflicting nullifiers. Higher priority tx wins. For RPC submissions, a configurable price bump percentage is required. |
162
162
  | `FeePayerBalancePreAddRule` | Ensures fee payer has sufficient balance for all their pending txs. |
163
163
  | `LowPriorityPreAddRule` | Rejects txs when pool is full and new tx has lowest priority. |
164
164
 
@@ -233,6 +233,14 @@ await pool.updateConfig({
233
233
  });
234
234
  ```
235
235
 
236
+ ### Price Bump (RPC Transaction Replacement)
237
+
238
+ When a transaction is submitted via RPC and clashes on nullifiers with an existing pool transaction, the incoming tx must pay at least `priceBumpPercentage`% more in priority fee (i.e. `>= existingFee + existingFee * bump / 100`) to replace it. This prevents spam via small fee increments. The same bump applies when the pool is full and the incoming tx needs to evict the lowest-priority tx.
239
+
240
+ - **Env var**: `P2P_RPC_PRICE_BUMP_PERCENTAGE` (default: 10)
241
+ - **Scope**: RPC submissions only. P2P gossip uses `comparePriority` (fee + hash tiebreaker) with no bump.
242
+ - Even with a 0% bump, a replacement tx must pay at least 1 unit more than the existing fee.
243
+
236
244
  ## Return Values
237
245
 
238
246
  ### AddTxsResult
@@ -301,6 +301,17 @@ export class DeletedPool {
301
301
  return this.#state.size;
302
302
  }
303
303
 
304
+ /** Gets the count of soft-deleted transactions (both prune-based and slot-based). */
305
+ getSoftDeletedCount(): number {
306
+ let count = this.#slotDeletedTxs.size;
307
+ for (const state of this.#state.values()) {
308
+ if (state.softDeleted) {
309
+ count++;
310
+ }
311
+ }
312
+ return count;
313
+ }
314
+
304
315
  /**
305
316
  * Gets all transaction hashes from pruned blocks.
306
317
  */
@@ -9,9 +9,12 @@ import {
9
9
  EvictionEvent,
10
10
  type EvictionRule,
11
11
  type PoolOperations,
12
+ type PreAddContext,
12
13
  type PreAddPoolAccess,
13
14
  type PreAddResult,
14
15
  type PreAddRule,
16
+ type TaggedEviction,
17
+ TxPoolRejectionCode,
15
18
  } from './interfaces.js';
16
19
 
17
20
  /**
@@ -47,21 +50,27 @@ export class EvictionManager {
47
50
  * Runs all pre-add rules for an incoming transaction.
48
51
  * Returns combined result of all rules.
49
52
  */
50
- async runPreAddRules(incomingMeta: TxMetaData, poolAccess: PreAddPoolAccess): Promise<PreAddResult> {
51
- const allTxHashesToEvict: string[] = [];
53
+ async runPreAddRules(
54
+ incomingMeta: TxMetaData,
55
+ poolAccess: PreAddPoolAccess,
56
+ context?: PreAddContext,
57
+ ): Promise<PreAddResult> {
58
+ const evictions: TaggedEviction[] = [];
59
+ const seen = new Set<string>();
52
60
 
53
61
  for (const rule of this.preAddRules) {
54
62
  try {
55
- const result = await rule.check(incomingMeta, poolAccess);
63
+ const result = await rule.check(incomingMeta, poolAccess, context);
56
64
 
57
65
  if (result.shouldIgnore) {
58
66
  return result;
59
67
  }
60
68
 
61
- // Collect txs to evict from all rules
69
+ // Collect txs to evict from all rules, tagged with the rule name
62
70
  for (const txHash of result.txHashesToEvict) {
63
- if (!allTxHashesToEvict.includes(txHash)) {
64
- allTxHashesToEvict.push(txHash);
71
+ if (!seen.has(txHash)) {
72
+ seen.add(txHash);
73
+ evictions.push({ txHash, reason: rule.name });
65
74
  }
66
75
  }
67
76
  } catch (err) {
@@ -70,14 +79,18 @@ export class EvictionManager {
70
79
  return {
71
80
  shouldIgnore: true,
72
81
  txHashesToEvict: [],
73
- reason: `pre-add rule ${rule.name} error: ${err}`,
82
+ reason: {
83
+ code: TxPoolRejectionCode.INTERNAL_ERROR,
84
+ message: `Pre-add rule ${rule.name} error: ${err}`,
85
+ },
74
86
  };
75
87
  }
76
88
  }
77
89
 
78
90
  return {
79
91
  shouldIgnore: false,
80
- txHashesToEvict: allTxHashesToEvict,
92
+ txHashesToEvict: evictions.map(e => e.txHash),
93
+ evictions,
81
94
  };
82
95
  }
83
96
 
@@ -34,7 +34,7 @@ export class FeePayerBalanceEvictionRule implements EvictionRule {
34
34
  }
35
35
 
36
36
  if (context.event === EvictionEvent.CHAIN_PRUNED) {
37
- await this.worldState.syncImmediate(context.blockNumber);
37
+ await this.worldState.syncImmediate();
38
38
  const feePayers = pool.getPendingFeePayers();
39
39
  return await this.evictForFeePayers(feePayers, this.worldState.getSnapshot(context.blockNumber), pool);
40
40
  }
@@ -67,8 +67,8 @@ export class FeePayerBalanceEvictionRule implements EvictionRule {
67
67
  ).flat();
68
68
 
69
69
  if (txsToEvict.length > 0) {
70
- await pool.deleteTxs(txsToEvict);
71
- this.log.verbose(`Evicted ${txsToEvict.length} txs due to insufficient fee payer balance`, {
70
+ await pool.deleteTxs(txsToEvict, this.name);
71
+ this.log.debug(`Evicted ${txsToEvict.length} txs due to insufficient fee payer balance`, {
72
72
  txHashes: txsToEvict,
73
73
  });
74
74
  }
@@ -1,7 +1,13 @@
1
1
  import { createLogger } from '@aztec/foundation/log';
2
2
 
3
3
  import { type TxMetaData, comparePriority } from '../tx_metadata.js';
4
- import type { PreAddPoolAccess, PreAddResult, PreAddRule } from './interfaces.js';
4
+ import {
5
+ type PreAddContext,
6
+ type PreAddPoolAccess,
7
+ type PreAddResult,
8
+ type PreAddRule,
9
+ TxPoolRejectionCode,
10
+ } from './interfaces.js';
5
11
 
6
12
  /**
7
13
  * Pre-add rule that checks if a fee payer has sufficient balance to cover the incoming transaction.
@@ -19,7 +25,7 @@ export class FeePayerBalancePreAddRule implements PreAddRule {
19
25
 
20
26
  private log = createLogger('p2p:tx_pool_v2:fee_payer_balance_pre_add_rule');
21
27
 
22
- async check(incomingMeta: TxMetaData, poolAccess: PreAddPoolAccess): Promise<PreAddResult> {
28
+ async check(incomingMeta: TxMetaData, poolAccess: PreAddPoolAccess, _context?: PreAddContext): Promise<PreAddResult> {
23
29
  // Get fee payer's on-chain balance
24
30
  const initialBalance = await poolAccess.getFeePayerBalance(incomingMeta.feePayer);
25
31
 
@@ -29,6 +35,7 @@ export class FeePayerBalancePreAddRule implements PreAddRule {
29
35
  // Create combined list with incoming tx
30
36
  const allTxs: Array<{
31
37
  txHash: string;
38
+ txHashBigInt: bigint;
32
39
  priorityFee: bigint;
33
40
  feeLimit: bigint;
34
41
  claimAmount: bigint;
@@ -36,6 +43,7 @@ export class FeePayerBalancePreAddRule implements PreAddRule {
36
43
  }> = [
37
44
  ...existingTxs.map(t => ({
38
45
  txHash: t.txHash,
46
+ txHashBigInt: t.txHashBigInt,
39
47
  priorityFee: t.priorityFee,
40
48
  feeLimit: t.feeLimit,
41
49
  claimAmount: t.claimAmount,
@@ -43,6 +51,7 @@ export class FeePayerBalancePreAddRule implements PreAddRule {
43
51
  })),
44
52
  {
45
53
  txHash: incomingMeta.txHash,
54
+ txHashBigInt: incomingMeta.txHashBigInt,
46
55
  priorityFee: incomingMeta.priorityFee,
47
56
  feeLimit: incomingMeta.feeLimit,
48
57
  claimAmount: incomingMeta.claimAmount,
@@ -78,7 +87,13 @@ export class FeePayerBalancePreAddRule implements PreAddRule {
78
87
  return {
79
88
  shouldIgnore: true,
80
89
  txHashesToEvict: [],
81
- reason: `fee payer ${incomingMeta.feePayer} has insufficient balance`,
90
+ reason: {
91
+ code: TxPoolRejectionCode.INSUFFICIENT_FEE_PAYER_BALANCE,
92
+ message: `Fee payer ${incomingMeta.feePayer} has insufficient balance. Balance at transaction: ${available}, required: ${incomingMeta.feeLimit}`,
93
+ currentBalance: initialBalance,
94
+ availableBalance: available,
95
+ feeLimit: incomingMeta.feeLimit,
96
+ },
82
97
  };
83
98
  } else {
84
99
  // Existing tx cannot be covered after adding incoming - mark for eviction
@@ -93,7 +108,6 @@ export class FeePayerBalancePreAddRule implements PreAddRule {
93
108
  return {
94
109
  shouldIgnore: true,
95
110
  txHashesToEvict: [],
96
- reason: 'internal error: tx coverage not determined',
97
111
  };
98
112
  }
99
113
 
@@ -6,9 +6,13 @@ export {
6
6
  type EvictionResult,
7
7
  type EvictionRule,
8
8
  type PoolOperations,
9
+ type PreAddContext,
9
10
  type PreAddPoolAccess,
10
11
  type PreAddResult,
11
12
  type PreAddRule,
13
+ type TaggedEviction,
14
+ TxPoolRejectionCode,
15
+ type TxPoolRejectionError,
12
16
  } from './interfaces.js';
13
17
 
14
18
  // Pre-add rules
@@ -67,6 +67,50 @@ export interface PreAddPoolAccess {
67
67
  getLowestPriorityPendingTx(): TxMetaData | undefined;
68
68
  }
69
69
 
70
+ /** A single eviction tagged with the rule that caused it. */
71
+ export interface TaggedEviction {
72
+ readonly txHash: string;
73
+ readonly reason: string;
74
+ }
75
+
76
+ /**
77
+ * Machine-readable rejection codes for pre-add rule rejections.
78
+ */
79
+ export const TxPoolRejectionCode = {
80
+ LOW_PRIORITY_FEE: 'LOW_PRIORITY_FEE',
81
+ INSUFFICIENT_FEE_PAYER_BALANCE: 'INSUFFICIENT_FEE_PAYER_BALANCE',
82
+ NULLIFIER_CONFLICT: 'NULLIFIER_CONFLICT',
83
+ INTERNAL_ERROR: 'INTERNAL_ERROR',
84
+ } as const;
85
+
86
+ export type TxPoolRejectionCode = (typeof TxPoolRejectionCode)[keyof typeof TxPoolRejectionCode];
87
+
88
+ /** Structured rejection reason returned by pre-add rules. */
89
+ export type TxPoolRejectionError =
90
+ | {
91
+ code: typeof TxPoolRejectionCode.LOW_PRIORITY_FEE;
92
+ message: string;
93
+ minimumPriorityFee: bigint;
94
+ txPriorityFee: bigint;
95
+ }
96
+ | {
97
+ code: typeof TxPoolRejectionCode.INSUFFICIENT_FEE_PAYER_BALANCE;
98
+ message: string;
99
+ currentBalance: bigint;
100
+ availableBalance: bigint;
101
+ feeLimit: bigint;
102
+ }
103
+ | {
104
+ code: typeof TxPoolRejectionCode.NULLIFIER_CONFLICT;
105
+ message: string;
106
+ conflictingTxHash: string;
107
+ /** Minimum fee needed to replace the conflicting tx (only set when price bump applies). */
108
+ minimumPriceBumpFee?: bigint;
109
+ /** Incoming tx's priority fee. */
110
+ txPriorityFee?: bigint;
111
+ }
112
+ | { code: typeof TxPoolRejectionCode.INTERNAL_ERROR; message: string };
113
+
70
114
  /**
71
115
  * Result of a pre-add check for a single transaction.
72
116
  */
@@ -75,8 +119,18 @@ export interface PreAddResult {
75
119
  readonly shouldIgnore: boolean;
76
120
  /** Tx hashes (as strings) that should be evicted if this tx is added */
77
121
  readonly txHashesToEvict: string[];
122
+ /** Evictions tagged with the rule name that produced them. Populated by EvictionManager. */
123
+ readonly evictions?: TaggedEviction[];
78
124
  /** Optional reason for ignoring */
79
- readonly reason?: string;
125
+ readonly reason?: TxPoolRejectionError;
126
+ }
127
+
128
+ /** Context passed to pre-add rules from addPendingTxs. */
129
+ export interface PreAddContext {
130
+ /** If true, compare priority fee only (no tx hash tiebreaker). Used for RPC submissions. */
131
+ feeComparisonOnly?: boolean;
132
+ /** Percentage-based price bump required for tx replacement. Only set for RPC submissions. */
133
+ priceBumpPercentage?: bigint;
80
134
  }
81
135
 
82
136
  /**
@@ -90,9 +144,10 @@ export interface PreAddRule {
90
144
  * Check if incoming tx should be added and which existing txs to evict.
91
145
  * @param incomingMeta - Metadata for the incoming transaction
92
146
  * @param poolAccess - Read-only access to current pool state
147
+ * @param context - Optional context from addPendingTxs caller
93
148
  * @returns Result indicating whether to ignore and what to evict
94
149
  */
95
- check(incomingMeta: TxMetaData, poolAccess: PreAddPoolAccess): Promise<PreAddResult>;
150
+ check(incomingMeta: TxMetaData, poolAccess: PreAddPoolAccess, context?: PreAddContext): Promise<PreAddResult>;
96
151
 
97
152
  /**
98
153
  * Updates the configuration for this rule.
@@ -120,8 +175,8 @@ export interface PoolOperations {
120
175
  /** Get the N lowest priority pending tx hashes */
121
176
  getLowestPriorityPending(limit: number): string[];
122
177
 
123
- /** Delete transactions by hash */
124
- deleteTxs(txHashes: string[]): Promise<void>;
178
+ /** Delete transactions by hash, with an optional reason for metrics */
179
+ deleteTxs(txHashes: string[], reason?: string): Promise<void>;
125
180
  }
126
181
 
127
182
  /**
@@ -35,15 +35,14 @@ export class InvalidTxsAfterMiningRule implements EvictionRule {
35
35
  for (const meta of pendingTxs) {
36
36
  // Evict pending txs that share nullifiers with mined txs
37
37
  if (meta.nullifiers.some(nullifier => minedNullifiers.has(nullifier))) {
38
- this.log.verbose(`Evicting tx ${meta.txHash} from pool due to a duplicate nullifier with a mined tx`);
39
38
  txsToEvict.push(meta.txHash);
40
39
  continue;
41
40
  }
42
41
 
43
42
  // Evict pending txs with an expiration timestamp less than or equal to the mined block timestamp
44
- if (meta.includeByTimestamp <= timestamp) {
43
+ if (meta.expirationTimestamp <= timestamp) {
45
44
  this.log.verbose(
46
- `Evicting tx ${meta.txHash} from pool due to the tx being expired (includeByTimestamp: ${meta.includeByTimestamp}, mined block timestamp: ${timestamp})`,
45
+ `Evicting tx ${meta.txHash} from pool due to the tx being expired (expirationTimestamp: ${meta.expirationTimestamp}, mined block timestamp: ${timestamp})`,
47
46
  );
48
47
  txsToEvict.push(meta.txHash);
49
48
  continue;
@@ -51,7 +50,8 @@ export class InvalidTxsAfterMiningRule implements EvictionRule {
51
50
  }
52
51
 
53
52
  if (txsToEvict.length > 0) {
54
- await pool.deleteTxs(txsToEvict);
53
+ this.log.info(`Evicted ${txsToEvict.length} invalid txs after block mined`);
54
+ await pool.deleteTxs(txsToEvict, this.name);
55
55
  }
56
56
 
57
57
  this.log.debug(`Evicted ${txsToEvict.length} invalid txs after block mined`, { txHashes: txsToEvict });
@@ -45,8 +45,8 @@ export class InvalidTxsAfterReorgRule implements EvictionRule {
45
45
  txsByBlockHash.get(blockHashStr)!.push(meta.txHash);
46
46
  }
47
47
 
48
- // Ensure world state is synced to this block before accessing the snapshot
49
- await this.worldState.syncImmediate(context.blockNumber);
48
+ // Sync without a block number to ensure the world state processes the prune event.
49
+ await this.worldState.syncImmediate();
50
50
  const db = this.worldState.getSnapshot(context.blockNumber);
51
51
 
52
52
  // Check which blocks exist in the archive
@@ -72,8 +72,8 @@ export class InvalidTxsAfterReorgRule implements EvictionRule {
72
72
  }
73
73
 
74
74
  if (txsToEvict.length > 0) {
75
- this.log.verbose(`Evicting ${txsToEvict.length} txs from pool due to referencing pruned blocks`);
76
- await pool.deleteTxs(txsToEvict);
75
+ this.log.info(`Evicting ${txsToEvict.length} txs from pool due to referencing pruned blocks`);
76
+ await pool.deleteTxs(txsToEvict, this.name);
77
77
  }
78
78
 
79
79
  const keptCount = pendingTxs.length - txsToEvict.length;
@@ -81,7 +81,7 @@ export class InvalidTxsAfterReorgRule implements EvictionRule {
81
81
  this.log.verbose(`Kept ${keptCount} txs that did not reference pruned blocks`);
82
82
  }
83
83
 
84
- this.log.info(`Evicted ${txsToEvict.length} invalid txs after reorg`, { txHashes: txsToEvict });
84
+ this.log.debug(`Evicted ${txsToEvict.length} invalid txs after reorg`, { txHashes: txsToEvict });
85
85
 
86
86
  return {
87
87
  reason: 'reorg_invalid_txs',
@@ -5,7 +5,7 @@ import { EvictionEvent } from './interfaces.js';
5
5
 
6
6
  /**
7
7
  * Eviction rule that removes low-priority transactions when the pool exceeds configured limits.
8
- * Only triggers on TXS_ADDED events.
8
+ * Triggers on TXS_ADDED and CHAIN_PRUNED events.
9
9
  */
10
10
  export class LowPriorityEvictionRule implements EvictionRule {
11
11
  public readonly name = 'LowPriorityEviction';
@@ -18,7 +18,7 @@ export class LowPriorityEvictionRule implements EvictionRule {
18
18
  }
19
19
 
20
20
  async evict(context: EvictionContext, pool: PoolOperations): Promise<EvictionResult> {
21
- if (context.event !== EvictionEvent.TXS_ADDED) {
21
+ if (context.event !== EvictionEvent.TXS_ADDED && context.event !== EvictionEvent.CHAIN_PRUNED) {
22
22
  return {
23
23
  reason: 'low_priority',
24
24
  success: true,
@@ -48,19 +48,22 @@ export class LowPriorityEvictionRule implements EvictionRule {
48
48
  };
49
49
  }
50
50
 
51
- this.log.verbose(
52
- `Evicting low priority txs. Pending tx count above limit: ${currentTxCount} > ${this.maxPoolSize}`,
53
- );
51
+ this.log.info(`Evicting low priority txs. Pending tx count above limit: ${currentTxCount} > ${this.maxPoolSize}`);
54
52
  const numberToEvict = currentTxCount - this.maxPoolSize;
55
53
  const txsToEvict = pool.getLowestPriorityPending(numberToEvict);
56
54
 
57
55
  if (txsToEvict.length > 0) {
58
- await pool.deleteTxs(txsToEvict);
56
+ if (context.event === EvictionEvent.TXS_ADDED) {
57
+ const toEvictSet = new Set(txsToEvict);
58
+ const numNewTxsEvicted = context.newTxHashes.filter(newTxHash => toEvictSet.has(newTxHash)).length;
59
+ this.log.info(`Evicted ${txsToEvict.length} low priority txs, including ${numNewTxsEvicted} newly added txs`);
60
+ } else {
61
+ this.log.info(`Evicted ${txsToEvict.length} low priority txs after chain prune`);
62
+ }
63
+ await pool.deleteTxs(txsToEvict, this.name);
59
64
  }
60
65
 
61
- const numNewTxsEvicted = context.newTxHashes.filter(newTxHash => txsToEvict.includes(newTxHash)).length;
62
-
63
- this.log.verbose(`Evicted ${txsToEvict.length} low priority txs, including ${numNewTxsEvicted} newly added txs`, {
66
+ this.log.debug(`Evicted ${txsToEvict.length} low priority txs`, {
64
67
  txHashes: txsToEvict,
65
68
  });
66
69
 
@@ -1,7 +1,14 @@
1
1
  import { createLogger } from '@aztec/foundation/log';
2
2
 
3
- import type { TxMetaData } from '../tx_metadata.js';
4
- import type { EvictionConfig, PreAddPoolAccess, PreAddResult, PreAddRule } from './interfaces.js';
3
+ import { type TxMetaData, comparePriority, getMinimumPriceBumpFee } from '../tx_metadata.js';
4
+ import {
5
+ type EvictionConfig,
6
+ type PreAddContext,
7
+ type PreAddPoolAccess,
8
+ type PreAddResult,
9
+ type PreAddRule,
10
+ TxPoolRejectionCode,
11
+ } from './interfaces.js';
5
12
 
6
13
  /**
7
14
  * Pre-add rule that checks if the pool is at capacity and handles low-priority eviction.
@@ -20,7 +27,7 @@ export class LowPriorityPreAddRule implements PreAddRule {
20
27
  this.maxPoolSize = config.maxPoolSize;
21
28
  }
22
29
 
23
- check(incomingMeta: TxMetaData, poolAccess: PreAddPoolAccess): Promise<PreAddResult> {
30
+ check(incomingMeta: TxMetaData, poolAccess: PreAddPoolAccess, context?: PreAddContext): Promise<PreAddResult> {
24
31
  // Skip if max pool size is disabled (0 = unlimited)
25
32
  if (this.maxPoolSize === 0) {
26
33
  return Promise.resolve({ shouldIgnore: false, txHashesToEvict: [] });
@@ -40,8 +47,18 @@ export class LowPriorityPreAddRule implements PreAddRule {
40
47
  return Promise.resolve({ shouldIgnore: false, txHashesToEvict: [] });
41
48
  }
42
49
 
43
- // If incoming tx has strictly higher priority, evict the lowest priority tx
44
- if (incomingMeta.priorityFee > lowestPriorityMeta.priorityFee) {
50
+ // Compare incoming tx against lowest priority tx.
51
+ // feeOnly mode (RPC): use strict fee comparison only — avoids churn from hash ordering.
52
+ // When price bump is also set, require the bumped fee threshold.
53
+ // Default (gossip): use full comparePriority (fee + tx hash tiebreaker) for determinism.
54
+ const isHigherPriority = context?.feeComparisonOnly
55
+ ? context.priceBumpPercentage !== undefined
56
+ ? incomingMeta.priorityFee >=
57
+ getMinimumPriceBumpFee(lowestPriorityMeta.priorityFee, context.priceBumpPercentage)
58
+ : incomingMeta.priorityFee > lowestPriorityMeta.priorityFee
59
+ : comparePriority(incomingMeta, lowestPriorityMeta) > 0;
60
+
61
+ if (isHigherPriority) {
45
62
  this.log.debug(
46
63
  `Pool at capacity (${currentCount}/${this.maxPoolSize}), evicting ${lowestPriorityMeta.txHash} ` +
47
64
  `(priority ${lowestPriorityMeta.priorityFee}) for ${incomingMeta.txHash} (priority ${incomingMeta.priorityFee})`,
@@ -53,6 +70,11 @@ export class LowPriorityPreAddRule implements PreAddRule {
53
70
  }
54
71
 
55
72
  // Incoming tx has equal or lower priority - ignore it (it would be evicted anyway)
73
+ const minimumFee =
74
+ context?.feeComparisonOnly && context.priceBumpPercentage !== undefined
75
+ ? getMinimumPriceBumpFee(lowestPriorityMeta.priorityFee, context.priceBumpPercentage)
76
+ : lowestPriorityMeta.priorityFee + 1n;
77
+
56
78
  this.log.debug(
57
79
  `Pool at capacity (${currentCount}/${this.maxPoolSize}), ignoring ${incomingMeta.txHash} ` +
58
80
  `(priority ${incomingMeta.priorityFee}) - lower than existing minimum (priority ${lowestPriorityMeta.priorityFee})`,
@@ -60,7 +82,12 @@ export class LowPriorityPreAddRule implements PreAddRule {
60
82
  return Promise.resolve({
61
83
  shouldIgnore: true,
62
84
  txHashesToEvict: [],
63
- reason: `pool at capacity and tx has lower priority than existing transactions`,
85
+ reason: {
86
+ code: TxPoolRejectionCode.LOW_PRIORITY_FEE,
87
+ message: `Tx does not meet minimum priority fee. Required: ${minimumFee}, got: ${incomingMeta.priorityFee}`,
88
+ minimumPriorityFee: minimumFee,
89
+ txPriorityFee: incomingMeta.priorityFee,
90
+ },
64
91
  });
65
92
  }
66
93
 
@@ -1,7 +1,7 @@
1
1
  import { createLogger } from '@aztec/foundation/log';
2
2
 
3
3
  import { type TxMetaData, checkNullifierConflict } from '../tx_metadata.js';
4
- import type { PreAddPoolAccess, PreAddResult, PreAddRule } from './interfaces.js';
4
+ import type { PreAddContext, PreAddPoolAccess, PreAddResult, PreAddRule } from './interfaces.js';
5
5
 
6
6
  /**
7
7
  * Pre-add rule that checks for nullifier conflicts between incoming and existing transactions.
@@ -15,15 +15,16 @@ export class NullifierConflictRule implements PreAddRule {
15
15
 
16
16
  private log = createLogger('p2p:tx_pool_v2:nullifier_conflict_rule');
17
17
 
18
- check(incomingMeta: TxMetaData, poolAccess: PreAddPoolAccess): Promise<PreAddResult> {
18
+ check(incomingMeta: TxMetaData, poolAccess: PreAddPoolAccess, context?: PreAddContext): Promise<PreAddResult> {
19
19
  const result = checkNullifierConflict(
20
20
  incomingMeta,
21
21
  nullifier => poolAccess.getTxHashByNullifier(nullifier),
22
22
  txHash => poolAccess.getMetadata(txHash),
23
+ context?.priceBumpPercentage,
23
24
  );
24
25
 
25
26
  if (result.shouldIgnore) {
26
- this.log.debug(`Ignoring tx ${incomingMeta.txHash}: ${result.reason}`);
27
+ this.log.debug(`Ignoring tx ${incomingMeta.txHash}: ${result.reason?.message}`);
27
28
  }
28
29
 
29
30
  return Promise.resolve(result);
@@ -7,6 +7,6 @@ export {
7
7
  type PoolReadAccess,
8
8
  DEFAULT_TX_POOL_V2_CONFIG,
9
9
  } from './interfaces.js';
10
- export { type TxMetaData, type TxState, buildTxMetaData, comparePriority } from './tx_metadata.js';
10
+ export { type TxMetaData, type TxState, buildTxMetaData, comparePriority, stubTxMetaData } from './tx_metadata.js';
11
11
  export { TxArchive } from './archive/index.js';
12
12
  export { DeletedPool } from './deleted_pool.js';