@aztec/p2p 0.0.1-commit.6d63667d → 0.0.1-commit.858058eac

package/dest/services/libp2p/libp2p_service.js

@@ -370,9 +370,8 @@ function applyDecs2203RFactory() {
 function _apply_decs_2203_r(targetClass, memberDecs, classDecs, parentClass) {
     return (_apply_decs_2203_r = applyDecs2203RFactory())(targetClass, memberDecs, classDecs, parentClass);
 }
-var _dec, _dec1, _dec2, _dec3, _dec4, _dec5, _dec6, _dec7, _dec8, _initProto;
+var _dec, _dec1, _dec2, _dec3, _dec4, _dec5, _dec6, _dec7, _dec8, _dec9, _initProto;
 import { BlockNumber } from '@aztec/foundation/branded-types';
-import { randomInt } from '@aztec/foundation/crypto/random';
 import { createLibp2pComponentLogger, createLogger } from '@aztec/foundation/log';
 import { RunningPromise } from '@aztec/foundation/running-promise';
 import { Timer } from '@aztec/foundation/timer';
@@ -384,7 +383,7 @@ import { Tx } from '@aztec/stdlib/tx';
 import { compressComponentVersions } from '@aztec/stdlib/versioning';
 import { Attributes, OtelMetricsAdapter, SpanStatusCode, WithTracer, trackSpan } from '@aztec/telemetry-client';
 import { gossipsub } from '@chainsafe/libp2p-gossipsub';
-import { createPeerScoreParams, createTopicScoreParams } from '@chainsafe/libp2p-gossipsub/score';
+import { createPeerScoreParams } from '@chainsafe/libp2p-gossipsub/score';
 import { SignaturePolicy } from '@chainsafe/libp2p-gossipsub/types';
 import { noise } from '@chainsafe/libp2p-noise';
 import { yamux } from '@chainsafe/libp2p-yamux';
@@ -395,7 +394,6 @@ import { mplex } from '@libp2p/mplex';
 import { tcp } from '@libp2p/tcp';
 import { ENR } from '@nethermindeth/enr';
 import { createLibp2p } from 'libp2p';
-import { ProposalSlotCapExceededError } from '../../errors/attestation-pool.error.js';
 import { BlockProposalValidator, CheckpointAttestationValidator, CheckpointProposalValidator, DoubleSpendTxValidator, FishermanAttestationValidator, getDefaultAllowedSetupFunctions } from '../../msg_validators/index.js';
 import { MessageSeenValidator } from '../../msg_validators/msg_seen_validator/msg_seen_validator.js';
 import { createTxMessageValidators, createTxReqRespValidator } from '../../msg_validators/tx_validator/factory.js';
@@ -405,37 +403,41 @@ import { getVersions } from '../../versioning.js';
 import { AztecDatastore } from '../data_store.js';
 import { DiscV5Service } from '../discv5/discV5_service.js';
 import { SnappyTransform, fastMsgIdFn, getMsgIdFn, msgIdToStrFn } from '../encoding.js';
-import { gossipScoreThresholds } from '../gossipsub/scoring.js';
+import { APP_SPECIFIC_WEIGHT, gossipScoreThresholds } from '../gossipsub/scoring.js';
+import { createAllTopicScoreParams } from '../gossipsub/topic_score_params.js';
 import { PeerManager } from '../peer-manager/peer_manager.js';
 import { PeerScoring } from '../peer-manager/peer_scoring.js';
 import { DEFAULT_SUB_PROTOCOL_VALIDATORS, ReqRespSubProtocol, ValidationError } from '../reqresp/index.js';
 import { pingHandler, reqGoodbyeHandler, reqRespBlockHandler, reqRespBlockTxsHandler, reqRespStatusHandler, reqRespTxHandler } from '../reqresp/index.js';
 import { ReqResp } from '../reqresp/reqresp.js';
 import { P2PInstrumentation } from './instrumentation.js';
-_dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
+_dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId, attestation)=>({
+        [Attributes.SLOT_NUMBER]: attestation.payload.header.slotNumber.toString()
+    })), _dec1 = trackSpan('Libp2pService.validateAndStoreBlockProposal', (_peerId, block)=>({
+        [Attributes.BLOCK_NUMBER]: block.blockNumber.toString(),
+        [Attributes.SLOT_NUMBER]: block.slotNumber.toString()
+    })), _dec2 = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
         [Attributes.SLOT_NUMBER]: block.slotNumber,
         [Attributes.BLOCK_ARCHIVE]: block.archive.toString(),
         [Attributes.P2P_ID]: await block.p2pMessageLoggingIdentifier().then((i)=>i.toString())
-    })), _dec1 = trackSpan('Libp2pService.processValidCheckpointProposal', async (checkpoint)=>({
+    })), _dec3 = trackSpan('Libp2pService.validateAndStoreCheckpointProposal', (_peerId, checkpoint)=>({
+        [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString()
+    })), _dec4 = trackSpan('Libp2pService.processValidCheckpointProposal', async (checkpoint)=>({
         [Attributes.SLOT_NUMBER]: checkpoint.slotNumber,
         [Attributes.BLOCK_ARCHIVE]: checkpoint.archive.toString(),
         [Attributes.P2P_ID]: await checkpoint.p2pMessageLoggingIdentifier().then((i)=>i.toString())
-    })), _dec2 = trackSpan('Libp2pService.validateRequestedBlockTxs', (request)=>({
+    })), _dec5 = trackSpan('Libp2pService.validateRequestedBlockTxs', (request)=>({
         [Attributes.BLOCK_ARCHIVE]: request.archiveRoot.toString()
-    })), _dec3 = trackSpan('Libp2pService.validateRequestedTx', (requestedTxHash, _responseTx)=>({
+    })), _dec6 = trackSpan('Libp2pService.validateRequestedTx', (requestedTxHash, _responseTx)=>({
         [Attributes.TX_HASH]: requestedTxHash.toString()
-    })), _dec4 = trackSpan('Libp2pService.validateRequestedBlock', (requestedBlockNumber, _responseBlock)=>({
+    })), _dec7 = trackSpan('Libp2pService.validateRequestedBlock', (requestedBlockNumber, _responseBlock)=>({
         [Attributes.BLOCK_NUMBER]: requestedBlockNumber.toString()
-    })), _dec5 = trackSpan('Libp2pService.validatePropagatedTx', (tx)=>({
+    })), _dec8 = trackSpan('Libp2pService.validatePropagatedTx', (tx)=>({
         [Attributes.TX_HASH]: tx.getTxHash().toString()
-    })), _dec6 = trackSpan('Libp2pService.validateCheckpointAttestation', async (_, attestation)=>({
+    })), _dec9 = trackSpan('Libp2pService.validateCheckpointAttestation', async (_, attestation)=>({
         [Attributes.SLOT_NUMBER]: attestation.payload.header.slotNumber,
         [Attributes.BLOCK_ARCHIVE]: attestation.archive.toString(),
         [Attributes.P2P_ID]: await attestation.p2pMessageLoggingIdentifier().then((i)=>i.toString())
-    })), _dec7 = trackSpan('Libp2pService.validateBlockProposal', (_peerId, block)=>({
-        [Attributes.SLOT_NUMBER]: block.slotNumber.toString()
-    })), _dec8 = trackSpan('Libp2pService.validateCheckpointProposal', (_peerId, checkpoint)=>({
-        [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString()
     }));
 /**
  * Lib P2P implementation of the P2PService interface.
@@ -456,47 +458,52 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
             [
                 _dec,
                 2,
-                "processValidBlockProposal"
+                "validateAndStoreCheckpointAttestation"
             ],
             [
                 _dec1,
                 2,
-                "processValidCheckpointProposal"
+                "validateAndStoreBlockProposal"
             ],
             [
                 _dec2,
                 2,
-                "validateRequestedBlockTxs"
+                "processValidBlockProposal"
             ],
             [
                 _dec3,
                 2,
-                "validateRequestedTxs"
+                "validateAndStoreCheckpointProposal"
             ],
             [
                 _dec4,
                 2,
-                "validateRequestedBlock"
+                "processValidCheckpointProposal"
             ],
             [
                 _dec5,
                 2,
-                "validatePropagatedTx"
+                "validateRequestedBlockTxs"
             ],
             [
                 _dec6,
                 2,
-                "validateCheckpointAttestation"
+                "validateRequestedTxs"
             ],
             [
                 _dec7,
                 2,
-                "validateBlockProposal"
+                "validateRequestedBlock"
             ],
             [
                 _dec8,
                 2,
-                "validateCheckpointProposal"
+                "validatePropagatedTx"
+            ],
+            [
+                _dec9,
+                2,
+                "validateCheckpointAttestation"
             ]
         ], []));
     }
@@ -509,6 +516,8 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
     protocolVersion;
     topicStrings;
     feesCache;
+    /** Callback invoked when a duplicate proposal is detected (triggers slashing). */ duplicateProposalCallback;
+    /** Callback invoked when a duplicate attestation is detected (triggers slashing). */ duplicateAttestationCallback;
     /**
    * Callback for when a block is received from a peer.
    * @param block - The block received from the peer.
@@ -587,10 +596,6 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
         }
         const versions = getVersions(config);
         const protocolVersion = compressComponentVersions(versions);
-        const txTopic = createTopicString(TopicType.tx, protocolVersion);
-        const blockProposalTopic = createTopicString(TopicType.block_proposal, protocolVersion);
-        const checkpointProposalTopic = createTopicString(TopicType.checkpoint_proposal, protocolVersion);
-        const checkpointAttestationTopic = createTopicString(TopicType.checkpoint_attestation, protocolVersion);
         const preferredPeersEnrs = config.preferredPeers.map((enr)=>ENR.decodeTxt(enr));
         const directPeers = (await Promise.all(preferredPeersEnrs.map(async (enr)=>{
             const peerId = await enr.peerId();
@@ -608,6 +613,14 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
         const announceTcpMultiaddr = config.p2pIp ? [
             convertToMultiaddr(config.p2pIp, p2pPort, 'tcp')
         ] : [];
+        // Create dynamic topic score params based on network configuration
+        const l1Constants = epochCache.getL1Constants();
+        const topicScoreParams = createAllTopicScoreParams(protocolVersion, {
+            slotDurationMs: l1Constants.slotDuration * 1000,
+            heartbeatIntervalMs: config.gossipsubInterval,
+            targetCommitteeSize: l1Constants.targetCommitteeSize,
+            blockDurationMs: config.blockDurationMs
+        });
         const node = await createLibp2p({
             start: false,
             peerId,
@@ -708,28 +721,7 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
                     scoreParams: createPeerScoreParams({
                         // IPColocation factor can be disabled for local testing - default to -5
                         IPColocationFactorWeight: config.debugDisableColocationPenalty ? 0 : -5.0,
-                        topics: {
-                            [txTopic]: createTopicScoreParams({
-                                topicWeight: 1,
-                                invalidMessageDeliveriesWeight: -20,
-                                invalidMessageDeliveriesDecay: 0.5
-                            }),
-                            [blockProposalTopic]: createTopicScoreParams({
-                                topicWeight: 1,
-                                invalidMessageDeliveriesWeight: -20,
-                                invalidMessageDeliveriesDecay: 0.5
-                            }),
-                            [checkpointProposalTopic]: createTopicScoreParams({
-                                topicWeight: 1,
-                                invalidMessageDeliveriesWeight: -20,
-                                invalidMessageDeliveriesDecay: 0.5
-                            }),
-                            [checkpointAttestationTopic]: createTopicScoreParams({
-                                topicWeight: 1,
-                                invalidMessageDeliveriesWeight: -20,
-                                invalidMessageDeliveriesDecay: 0.5
-                            })
-                        }
+                        topics: topicScoreParams
                     })
                 }),
                 components: (components)=>({
@@ -741,8 +733,12 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
         const peerScoring = new PeerScoring(config, telemetry);
         const reqresp = new ReqResp(config, node, peerScoring, createLogger(`${logger.module}:reqresp`));
         const peerManager = new PeerManager(node, peerDiscoveryService, config, telemetry, createLogger(`${logger.module}:peer_manager`), peerScoring, reqresp, worldStateSynchronizer, protocolVersion, epochCache);
-        // Update gossipsub score params
-        node.services.pubsub.score.params.appSpecificWeight = 10;
+        // Configure application-specific scoring for gossipsub.
+        // The weight scales app score to align with gossipsub thresholds:
+        // - Disconnect (-50) × 10 = -500 = gossipThreshold (stops receiving gossip)
+        // - Ban (-100) × 10 = -1000 = publishThreshold (cannot publish)
+        // Note: positive topic scores can offset penalties, so alignment is best-effort.
+        node.services.pubsub.score.params.appSpecificWeight = APP_SPECIFIC_WEIGHT;
         node.services.pubsub.score.params.appSpecificScore = (peerId)=>peerManager.shouldDisableP2PGossip(peerId) ? -Infinity : peerManager.getPeerScore(peerId);
         return new LibP2PService(clientType, config, node, peerDiscoveryService, reqresp, peerManager, mempools, l2BlockSource, epochCache, proofVerifier, worldStateSynchronizer, telemetry, logger);
     }
@@ -872,6 +868,19 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
         this.checkpointReceivedCallback = callback;
     }
     /**
+   * Registers a callback to be invoked when a duplicate proposal is detected.
+   * This callback is triggered on the first duplicate (when count goes from 1 to 2).
+   */ registerDuplicateProposalCallback(callback) {
+        this.duplicateProposalCallback = callback;
+    }
+    /**
+   * Registers a callback to be invoked when a duplicate attestation is detected.
+   * A validator signing attestations for different proposals at the same slot.
+   * This callback is triggered on the first duplicate (when count goes from 1 to 2).
+   */ registerDuplicateAttestationCallback(callback) {
+        this.duplicateAttestationCallback = callback;
+    }
+    /**
    * Subscribes to a topic.
    * @param topic - The topic to subscribe to.
    */ subscribeToTopic(topic) {
@@ -1053,25 +1062,42 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
         const validationFunc = async ()=>{
             const tx = Tx.fromBuffer(payloadData);
             const isValid = await this.validatePropagatedTx(tx, source);
-            const exists = isValid && await this.mempools.txPool.hasTx(tx.getTxHash());
+            if (!isValid) {
+                this.logger.trace(`Rejecting invalid propagated tx`, {
+                    [Attributes.P2P_ID]: source.toString()
+                });
+                return {
+                    result: TopicValidatorResult.Reject
+                };
+            }
+            // Propagate only on pool acceptance
+            const txHash = tx.getTxHash();
+            const addResult = await this.mempools.txPool.addPendingTxs([
+                tx
+            ], {
+                source: 'gossip'
+            });
+            const wasAccepted = addResult.accepted.some((h)=>h.equals(txHash));
+            const wasIgnored = addResult.ignored.some((h)=>h.equals(txHash));
             this.logger.trace(`Validate propagated tx`, {
                 isValid,
-                exists,
+                wasAccepted,
+                wasIgnored,
                 [Attributes.P2P_ID]: source.toString()
             });
-            if (!isValid) {
+            if (wasAccepted) {
                 return {
-                    result: TopicValidatorResult.Reject
+                    result: TopicValidatorResult.Accept,
+                    obj: tx
                 };
-            } else if (exists) {
+            } else if (wasIgnored) {
                 return {
                     result: TopicValidatorResult.Ignore,
                     obj: tx
                 };
             } else {
                 return {
-                    result: TopicValidatorResult.Accept,
-                    obj: tx
+                    result: TopicValidatorResult.Reject
                 };
             }
         };
@@ -1079,133 +1105,190 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
         if (result !== TopicValidatorResult.Accept || !tx) {
             return;
         }
+        // Tx was accepted into pool and will be propagated - just log and record metrics
         const txHash = tx.getTxHash();
         const txHashString = txHash.toString();
         this.logger.verbose(`Received tx ${txHashString} from external peer ${source.toString()} via gossip`, {
             source: source.toString(),
             txHash: txHashString
         });
-        if (this.config.dropTransactions && randomInt(1000) < this.config.dropTransactionsProbability * 1000) {
-            this.logger.warn(`Intentionally dropping tx ${txHashString} (probability rule)`);
-            return;
-        }
         this.instrumentation.incrementTxReceived(1);
-        await this.mempools.txPool.addTxs([
-            tx
-        ]);
     }
     /**
    * Process a checkpoint attestation from a peer.
    * Validates the attestation and adds it to the pool.
    */ async processCheckpointAttestationFromPeer(payloadData, msgId, source) {
-        const validationFunc = async ()=>{
-            const attestation = CheckpointAttestation.fromBuffer(payloadData);
-            const pool = this.mempools.attestationPool;
-            const validationResult = await this.validateCheckpointAttestation(source, attestation);
-            const isValid = validationResult.result === 'accept';
-            const exists = isValid && await pool.hasCheckpointAttestation(attestation);
-            let canAdd = true;
-            if (isValid && !exists) {
-                const slot = attestation.payload.header.slotNumber;
-                const { committee } = await this.epochCache.getCommittee(slot);
-                const committeeSize = committee?.length ?? 0;
-                canAdd = await pool.canAddCheckpointAttestation(attestation, committeeSize);
-            }
-            this.logger.trace(`Validate propagated checkpoint attestation`, {
-                isValid,
-                exists,
-                canAdd,
-                [Attributes.SLOT_NUMBER]: attestation.payload.header.slotNumber.toString(),
-                [Attributes.P2P_ID]: source.toString()
-            });
-            if (validationResult.result === 'reject') {
-                return {
-                    result: TopicValidatorResult.Reject
-                };
-            } else if (validationResult.result === 'ignore' || exists) {
-                return {
-                    result: TopicValidatorResult.Ignore,
-                    obj: attestation
-                };
-            } else if (!canAdd) {
-                this.logger.warn(`Dropping checkpoint attestation due to per-(slot, proposalId) attestation cap`, {
-                    slot: attestation.payload.header.slotNumber.toString(),
-                    archive: attestation.archive.toString(),
-                    source: source.toString()
-                });
-                return {
-                    result: TopicValidatorResult.Ignore,
-                    obj: attestation
-                };
-            } else {
-                return {
-                    result: TopicValidatorResult.Accept,
-                    obj: attestation
-                };
-            }
-        };
-        const { result, obj: attestation } = await this.validateReceivedMessage(validationFunc, msgId, source, TopicType.checkpoint_attestation);
+        const { result, obj: attestation } = await this.validateReceivedMessage(()=>this.validateAndStoreCheckpointAttestation(source, CheckpointAttestation.fromBuffer(payloadData)), msgId, source, TopicType.checkpoint_attestation);
         if (result !== TopicValidatorResult.Accept || !attestation) {
             return;
         }
-        this.logger.debug(`Received checkpoint attestation for slot ${attestation.slotNumber} from external peer ${source.toString()}`, {
+        this.logger.verbose(`Received valid checkpoint attestation for slot ${attestation.slotNumber} from external peer ${source.toString()}`, {
             p2pMessageIdentifier: await attestation.p2pMessageLoggingIdentifier(),
             slot: attestation.slotNumber,
             archive: attestation.archive.toString(),
             source: source.toString()
         });
-        await this.mempools.attestationPool.addCheckpointAttestations([
-            attestation
-        ]);
     }
-    async processBlockFromPeer(payloadData, msgId, source) {
-        const validationFunc = async ()=>{
-            const block = BlockProposal.fromBuffer(payloadData);
-            const validationResult = await this.validateBlockProposal(source, block);
-            const isValid = validationResult.result === 'accept';
-            const pool = this.mempools.attestationPool;
-            const exists = isValid && await pool.hasBlockProposal(block);
-            const canAdd = isValid && await pool.canAddProposal(block);
-            this.logger.trace(`Validate propagated block proposal`, {
-                isValid,
-                exists,
-                canAdd,
-                [Attributes.SLOT_NUMBER]: block.slotNumber.toString(),
-                [Attributes.P2P_ID]: source.toString()
+    /** Validates a checkpoint attestation and adds it to the pool. Penalizes the peer if validation fails. */ async validateAndStoreCheckpointAttestation(peerId, attestation) {
+        const validationResult = await this.checkpointAttestationValidator.validate(attestation);
+        if (validationResult.result === 'reject') {
+            this.logger.warn(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
+            this.peerManager.penalizePeer(peerId, validationResult.severity);
+            return {
+                result: TopicValidatorResult.Reject
+            };
+        }
+        if (validationResult.result === 'ignore') {
+            return {
+                result: TopicValidatorResult.Ignore,
+                obj: attestation
+            };
+        }
+        // Try to add the attestation: this handles existence check, cap check, and adding in one call
+        // count is the number of attestations by this signer for this slot (for duplicate detection)
+        const slot = attestation.payload.header.slotNumber;
+        const { added, alreadyExists, count } = await this.mempools.attestationPool.tryAddCheckpointAttestation(attestation);
+        this.logger.trace(`Validate propagated checkpoint attestation`, {
+            added,
+            alreadyExists,
+            count,
+            [Attributes.SLOT_NUMBER]: slot.toString(),
+            [Attributes.P2P_ID]: peerId.toString()
+        });
+        // Exact same attestation received, no need to re-broadcast
+        if (alreadyExists) {
+            return {
+                result: TopicValidatorResult.Ignore,
+                obj: attestation
+            };
+        }
+        // Could not add (cap reached for signer), no need to re-broadcast
+        if (!added) {
+            this.logger.warn(`Dropping checkpoint attestation due to cap`, {
+                slot: slot.toString(),
+                archive: attestation.archive.toString(),
+                source: peerId.toString(),
+                attester: attestation.getSender()?.toString(),
+                count
             });
-            if (validationResult.result === 'reject') {
-                return {
-                    result: TopicValidatorResult.Reject
-                };
-            } else if (validationResult.result === 'ignore' || exists) {
-                return {
-                    result: TopicValidatorResult.Ignore,
-                    obj: block
-                };
-            } else if (!canAdd) {
-                this.peerManager.penalizePeer(source, PeerErrorSeverity.MidToleranceError);
-                this.logger.warn(`Penalizing peer for block proposal exceeding per-slot cap`, {
-                    slot: block.slotNumber.toString(),
-                    archive: block.archive.toString(),
-                    source: source.toString()
+            return {
+                result: TopicValidatorResult.Ignore,
+                obj: attestation
+            };
+        }
+        // Check if this is a duplicate attestation (signer attested to a different proposal at the same slot)
+        // count is the number of attestations by this signer for this slot
+        if (count === 2) {
+            const attester = attestation.getSender();
+            if (attester) {
+                this.logger.warn(`Detected duplicate attestation (equivocation) at slot ${slot}`, {
+                    slot: slot.toString(),
+                    archive: attestation.archive.toString(),
+                    source: peerId.toString(),
+                    attester: attester.toString()
+                });
+                this.duplicateAttestationCallback?.({
+                    slot,
+                    attester
                 });
-                return {
-                    result: TopicValidatorResult.Reject
-                };
-            } else {
-                return {
-                    result: TopicValidatorResult.Accept,
-                    obj: block
-                };
             }
+        }
+        // Attestation was added successfully - accept it so other nodes can also detect the equivocation
+        return {
+            result: TopicValidatorResult.Accept,
+            obj: attestation
         };
-        const { result, obj: block } = await this.validateReceivedMessage(validationFunc, msgId, source, TopicType.block_proposal);
-        if (!result || !block) {
+    }
+    async processBlockFromPeer(payloadData, msgId, source) {
+        const { result, obj: block, metadata: { isEquivocated } = {} } = await this.validateReceivedMessage(()=>this.validateAndStoreBlockProposal(source, BlockProposal.fromBuffer(payloadData)), msgId, source, TopicType.block_proposal);
+        // If not accepted or equivocated, return
+        if (result !== TopicValidatorResult.Accept || !block || isEquivocated) {
             return;
         }
         await this.processValidBlockProposal(block, source);
     }
-    // REVIEW: callback pattern https://github.com/AztecProtocol/aztec-packages/issues/7963
+    /** Validates a block proposal. Triggers a penalization to the peer that sent it if invalid. Adds to the mempool if valid. */ async validateAndStoreBlockProposal(peerId, block) {
+        const validationResult = await this.blockProposalValidator.validate(block);
+        if (validationResult.result === 'reject') {
+            this.logger.warn(`Penalizing peer ${peerId} for block proposal validation failure`);
+            this.peerManager.penalizePeer(peerId, validationResult.severity);
+            return {
+                result: TopicValidatorResult.Reject
+            };
+        }
+        if (validationResult.result === 'ignore') {
+            return {
+                result: TopicValidatorResult.Ignore,
+                obj: block
+            };
+        }
+        // Try to add the proposal: this handles existence check, cap check, and adding in one call
+        const { added, alreadyExists, count } = await this.mempools.attestationPool.tryAddBlockProposal(block);
+        const isEquivocated = count !== undefined && count > 1;
+        // Duplicate proposal received, no need to re-broadcast
+        if (alreadyExists) {
+            this.logger.debug(`Ignoring duplicate block proposal received`, {
+                ...block.toBlockInfo(),
+                indexWithinCheckpoint: block.indexWithinCheckpoint,
+                proposer: block.getSender()?.toString(),
+                source: peerId.toString()
+            });
+            return {
+                result: TopicValidatorResult.Ignore,
+                obj: block,
+                metadata: {
+                    isEquivocated
+                }
+            };
+        }
+        // Too many blocks received for this slot and index, penalize peer and do not re-broadcast
+        if (!added) {
+            this.peerManager.penalizePeer(peerId, PeerErrorSeverity.HighToleranceError);
+            this.logger.warn(`Penalizing peer for block proposal exceeding per-position cap`, {
+                ...block.toBlockInfo(),
+                indexWithinCheckpoint: block.indexWithinCheckpoint,
+                count,
+                proposer: block.getSender()?.toString(),
+                source: peerId.toString()
+            });
+            return {
+                result: TopicValidatorResult.Reject,
+                metadata: {
+                    isEquivocated
+                }
+            };
+        }
+        // If this was a duplicate proposal, do not process it, but do invoke the duplicate callback,
+        // and do re-broadcast it so other nodes in the network know to slash the proposer
+        if (isEquivocated) {
+            const proposer = block.getSender();
+            this.logger.warn(`Detected duplicate block proposal (equivocation) at slot ${block.slotNumber}`, {
+                ...block.toBlockInfo(),
+                source: peerId.toString(),
+                proposer: proposer?.toString()
+            });
+            // Invoke the duplicate callback on the first duplicate spotted only
+            if (proposer && count === 2) {
+                this.duplicateProposalCallback?.({
+                    slot: block.slotNumber,
+                    proposer,
+                    type: 'block'
+                });
+            }
+            return {
+                result: TopicValidatorResult.Accept,
+                obj: block,
+                metadata: {
+                    isEquivocated
+                }
+            };
+        }
+        // Otherwise, we're good to go!
+        return {
+            result: TopicValidatorResult.Accept,
+            obj: block
+        };
+    }
     // REFACTOR(palla): This method should be moved to the p2p_client or to a separate component,
     // should not be here as it does not deal with p2p networking.
     async processValidBlockProposal(block, sender) {
@@ -1215,23 +1298,8 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
             source: sender.toString(),
             ...block.toBlockInfo()
         });
-        // Attempt to add proposal
-        try {
-            await this.mempools.attestationPool.addBlockProposal(block);
-        } catch (err) {
-            // Drop proposals if we hit per-slot cap in the attestation pool; rethrow unknown errors
-            if (err instanceof ProposalSlotCapExceededError) {
-                this.logger.warn(`Dropping block proposal due to per-slot proposal cap`, {
-                    slot: String(slot),
-                    archive: block.archive.toString(),
-                    error: err.message
-                });
-                return;
-            }
-            throw err;
-        }
-        // Mark the txs in this proposal as non-evictable
-        await this.mempools.txPool.markTxsAsNonEvictable(block.txHashes);
+        // Mark the txs in this proposal as protected
+        await this.mempools.txPool.protectTxs(block.txHashes, block.blockHeader);
         // Call the block received callback to validate the proposal.
         // Note: Validators do NOT attest to individual blocks, only to checkpoint proposals.
         const isValid = await this.blockReceivedCallback(block, sender);
@@ -1243,57 +1311,135 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
    * Handle a gossiped checkpoint proposal.
    * Validates and processes the checkpoint proposal, then triggers the callback for attestation.
    */ async handleGossipedCheckpointProposal(payloadData, msgId, source) {
-        // TODO(palla/mbps): This pattern is repeated across multiple message handlers, consider abstracting it.
-        const validationFunc = async ()=>{
-            const checkpoint = CheckpointProposal.fromBuffer(payloadData);
-            const validationResult = await this.validateCheckpointProposal(source, checkpoint);
-            const isValid = validationResult.result === 'accept';
-            const pool = this.mempools.attestationPool;
-            const exists = isValid && await pool.hasCheckpointProposal(checkpoint);
-            const canAdd = isValid && await pool.canAddCheckpointProposal(checkpoint);
-            this.logger.trace(`Validate propagated checkpoint proposal`, {
-                isValid,
-                exists,
-                canAdd,
+        const { result, obj: checkpoint, metadata: { isEquivocated, processBlock } = {} } = await this.validateReceivedMessage(()=>this.validateAndStoreCheckpointProposal(source, CheckpointProposal.fromBuffer(payloadData)), msgId, source, TopicType.checkpoint_proposal);
+        // If the checkpoint contained a valid last block, we process it even if the checkpoint itself is to be rejected
+        // TODO(palla/mbps): Is this ok? Should we be considering a block from a checkpoint that was equivocated?
+        if (processBlock && checkpoint?.getBlockProposal()) {
+            await this.processValidBlockProposal(checkpoint.getBlockProposal(), source);
+        }
+        if (result !== TopicValidatorResult.Accept || !checkpoint || isEquivocated) {
+            return;
+        }
+        await this.processValidCheckpointProposal(checkpoint.toCore(), source);
+    }
+    /**
+   * Validates a checkpoint proposal. Penalizes peer if validation fails. Adds the checkpoint and
+   * its last block (if present) to the mempool if valid. Triggers equivocation detection on both.
+   */ async validateAndStoreCheckpointProposal(peerId, checkpoint) {
+        const validationResult = await this.checkpointProposalValidator.validate(checkpoint);
+        if (validationResult.result === 'reject') {
+            this.logger.warn(`Penalizing peer ${peerId} for checkpoint proposal validation failure`);
+            this.peerManager.penalizePeer(peerId, validationResult.severity);
+            return {
+                result: TopicValidatorResult.Reject
+            };
+        }
+        if (validationResult.result === 'ignore') {
+            return {
+                result: TopicValidatorResult.Ignore,
+                obj: checkpoint
+            };
+        }
+        // Extract and try to add the block proposal first if present
+        const blockProposal = checkpoint.getBlockProposal();
+        let processBlock = false;
+        if (blockProposal) {
+            this.logger.debug(`Validating block proposal from propagated checkpoint`, {
                 [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
-                [Attributes.P2P_ID]: source.toString()
+                [Attributes.P2P_ID]: peerId.toString()
             });
-            if (validationResult.result === 'reject') {
-                return {
-                    result: TopicValidatorResult.Reject
-                };
-            } else if (validationResult.result === 'ignore' || exists) {
-                return {
-                    result: TopicValidatorResult.Ignore,
-                    obj: checkpoint
-                };
-            } else if (!canAdd) {
-                this.peerManager.penalizePeer(source, PeerErrorSeverity.MidToleranceError);
-                this.logger.warn(`Penalizing peer for checkpoint proposal exceeding per-slot cap`, {
-                    slot: checkpoint.slotNumber.toString(),
-                    archive: checkpoint.archive.toString(),
-                    source: source.toString()
+            const { result, obj, metadata: { isEquivocated } = {} } = await this.validateAndStoreBlockProposal(peerId, blockProposal);
+            if (result === TopicValidatorResult.Reject || !obj || isEquivocated) {
+                this.logger.debug(`Rejecting checkpoint due to invalid last block proposal`, {
+                    [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
+                    [Attributes.P2P_ID]: peerId.toString(),
+                    isEquivocated,
+                    result
                 });
                 return {
                     result: TopicValidatorResult.Reject
                 };
-            } else {
-                return {
-                    result: TopicValidatorResult.Accept,
-                    obj: checkpoint
-                };
+            } else if (result === TopicValidatorResult.Accept && obj && !isEquivocated) {
+                processBlock = true;
             }
-        };
-        const { result, obj: checkpoint } = await this.validateReceivedMessage(validationFunc, msgId, source, TopicType.checkpoint_proposal);
-        if (result !== TopicValidatorResult.Accept || !checkpoint) {
-            return;
         }
-        await this.processValidCheckpointProposal(checkpoint, source);
+        // Try to add the checkpoint proposal core: this handles existence check, cap check, and adding in one call
+        const checkpointCore = checkpoint.toCore();
+        const tryAddResult = await this.mempools.attestationPool.tryAddCheckpointProposal(checkpointCore);
+        const { added, alreadyExists, count } = tryAddResult;
+        const isEquivocated = count !== undefined && count > 1;
+        // Duplicate proposal received, do not re-broadcast
+        if (alreadyExists) {
+            this.logger.debug(`Ignoring duplicate checkpoint proposal received`, {
+                ...checkpoint.toCheckpointInfo(),
+                source: peerId.toString()
+            });
+            return {
+                result: TopicValidatorResult.Ignore,
+                obj: checkpoint,
+                metadata: {
+                    isEquivocated,
+                    processBlock
+                }
+            };
+        }
+        // Too many checkpoint proposals received for this slot, penalize peer and do not re-broadcast
+        // Note: We still return the checkpoint obj so the lastBlock can be processed if valid
+        if (!added) {
+            this.peerManager.penalizePeer(peerId, PeerErrorSeverity.HighToleranceError);
+            this.logger.warn(`Penalizing peer for checkpoint proposal exceeding per-slot cap`, {
+                ...checkpoint.toCheckpointInfo(),
+                count,
+                source: peerId.toString()
+            });
+            return {
+                result: TopicValidatorResult.Reject,
+                obj: checkpoint,
+                metadata: {
+                    isEquivocated,
+                    processBlock
+                }
+            };
+        }
+        // If this was a duplicate proposal, do not process it, but do invoke the duplicate callback,
+        // and do re-broadcast it so other nodes in the network know to slash the proposer
+        if (isEquivocated) {
+            const proposer = checkpoint.getSender();
+            this.logger.warn(`Detected duplicate checkpoint proposal (equivocation) at slot ${checkpoint.slotNumber}`, {
+                ...checkpoint.toCheckpointInfo(),
+                source: peerId.toString(),
+                proposer: proposer?.toString()
+            });
+            // Invoke the duplicate callback on the first duplicate spotted only
+            if (proposer && count === 2) {
+                this.duplicateProposalCallback?.({
+                    slot: checkpoint.slotNumber,
+                    proposer,
+                    type: 'checkpoint'
+                });
+            }
+            return {
+                result: TopicValidatorResult.Accept,
+                obj: checkpoint,
+                metadata: {
+                    isEquivocated,
+                    processBlock
+                }
+            };
+        }
+        // Otherwise, we're good to go!
+        return {
+            result: TopicValidatorResult.Accept,
+            obj: checkpoint,
+            metadata: {
+                processBlock,
+                isEquivocated
+            }
+        };
     }
     /**
    * Process a validated checkpoint proposal.
-   * Extracts and processes the last block proposal (if present) first, then processes the checkpoint.
-   * The block callback is invoked before the checkpoint callback.
+   * Note: The proposal was already added to the pool by tryAddCheckpointProposal in handleGossipedCheckpointProposal.
    */ async processValidCheckpointProposal(checkpoint, sender) {
         const slot = checkpoint.slotNumber;
         this.logger.verbose(`Received checkpoint proposal for slot ${slot} from external peer ${sender.toString()}.`, {
@@ -1302,33 +1448,12 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
             archive: checkpoint.archive.toString(),
             source: sender.toString()
         });
-        // Extract block proposal before adding to pool (pool stores them separately)
-        const blockProposal = checkpoint.getBlockProposal();
-        // Add proposal to the pool (this extracts and stores block proposal separately)
-        await this.mempools.attestationPool.addCheckpointProposal(checkpoint);
-        // Mark txs as non-evictable if present (from the last block)
-        if (checkpoint.txHashes.length > 0) {
-            await this.mempools.txPool.markTxsAsNonEvictable(checkpoint.txHashes);
-        }
-        // If there was a last block proposal, invoke the block callback first for validation.
-        // Note: The block proposal is already stored in the pool by addCheckpointProposal.
-        if (blockProposal) {
-            const isValid = await this.blockReceivedCallback(blockProposal, sender);
-            if (!isValid) {
-                this.logger.warn(`Block proposal from checkpoint failed validation`, {
-                    slot: slot.toString(),
-                    archive: checkpoint.archive.toString(),
-                    blockNumber: blockProposal.blockNumber.toString()
-                });
-                return;
-            }
-        }
         // Call the checkpoint received callback with the core version (without lastBlock)
         // to validate and potentially generate attestations
-        const attestations = await this.checkpointReceivedCallback(checkpoint.toCore(), sender);
+        const attestations = await this.checkpointReceivedCallback(checkpoint, sender);
         if (attestations && attestations.length > 0) {
             // If the callback returned attestations, add them to the pool and propagate them
-            await this.mempools.attestationPool.addCheckpointAttestations(attestations);
+            await this.mempools.attestationPool.addOwnCheckpointAttestations(attestations);
             for (const attestation of attestations){
                 await this.propagate(attestation);
             }
@@ -1655,33 +1780,7 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
    */ async validateCheckpointAttestation(peerId, attestation) {
         const result = await this.checkpointAttestationValidator.validate(attestation);
         if (result.result === 'reject') {
-            this.logger.debug(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
-            this.peerManager.penalizePeer(peerId, result.severity);
-        }
-        return result;
-    }
-    /**
-   * Validate a block proposal.
-   *
-   * @param block - The block proposal to validate.
-   * @returns True if the block proposal is valid, false otherwise.
-   */ async validateBlockProposal(peerId, block) {
-        const result = await this.blockProposalValidator.validate(block);
-        if (result.result === 'reject') {
-            this.logger.debug(`Penalizing peer ${peerId} for block proposal validation failure`);
-            this.peerManager.penalizePeer(peerId, result.severity);
-        }
-        return result;
-    }
-    /**
-   * Validate a checkpoint proposal.
-   *
-   * @param checkpoint - The checkpoint proposal to validate.
-   * @returns True if the checkpoint proposal is valid, false otherwise.
-   */ async validateCheckpointProposal(peerId, checkpoint) {
-        const result = await this.checkpointProposalValidator.validate(checkpoint);
-        if (result.result === 'reject') {
-            this.logger.debug(`Penalizing peer ${peerId} for checkpoint proposal validation failure`);
+            this.logger.warn(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
             this.peerManager.penalizePeer(peerId, result.severity);
         }
         return result;