@aztec/p2p 0.0.1-commit.6d63667d → 0.0.1-commit.72dcdcda8

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (316) hide show
  1. package/dest/client/factory.d.ts +10 -10
  2. package/dest/client/factory.d.ts.map +1 -1
  3. package/dest/client/factory.js +39 -15
  4. package/dest/client/interface.d.ts +46 -33
  5. package/dest/client/interface.d.ts.map +1 -1
  6. package/dest/client/p2p_client.d.ts +39 -51
  7. package/dest/client/p2p_client.d.ts.map +1 -1
  8. package/dest/client/p2p_client.js +145 -200
  9. package/dest/client/test/tx_proposal_collector/proposal_tx_collector_worker.js +7 -8
  10. package/dest/config.d.ts +24 -8
  11. package/dest/config.d.ts.map +1 -1
  12. package/dest/config.js +16 -6
  13. package/dest/errors/tx-pool.error.d.ts +8 -0
  14. package/dest/errors/tx-pool.error.d.ts.map +1 -0
  15. package/dest/errors/tx-pool.error.js +9 -0
  16. package/dest/index.d.ts +2 -1
  17. package/dest/index.d.ts.map +1 -1
  18. package/dest/index.js +1 -0
  19. package/dest/mem_pools/attestation_pool/attestation_pool.d.ts +104 -88
  20. package/dest/mem_pools/attestation_pool/attestation_pool.d.ts.map +1 -1
  21. package/dest/mem_pools/attestation_pool/attestation_pool.js +441 -3
  22. package/dest/mem_pools/attestation_pool/attestation_pool_test_suite.d.ts +2 -2
  23. package/dest/mem_pools/attestation_pool/attestation_pool_test_suite.d.ts.map +1 -1
  24. package/dest/mem_pools/attestation_pool/attestation_pool_test_suite.js +353 -87
  25. package/dest/mem_pools/attestation_pool/index.d.ts +2 -3
  26. package/dest/mem_pools/attestation_pool/index.d.ts.map +1 -1
  27. package/dest/mem_pools/attestation_pool/index.js +1 -2
  28. package/dest/mem_pools/attestation_pool/mocks.d.ts +2 -2
  29. package/dest/mem_pools/attestation_pool/mocks.d.ts.map +1 -1
  30. package/dest/mem_pools/attestation_pool/mocks.js +2 -2
  31. package/dest/mem_pools/index.d.ts +3 -2
  32. package/dest/mem_pools/index.d.ts.map +1 -1
  33. package/dest/mem_pools/index.js +1 -1
  34. package/dest/mem_pools/interface.d.ts +5 -5
  35. package/dest/mem_pools/interface.d.ts.map +1 -1
  36. package/dest/mem_pools/tx_pool/eviction/invalid_txs_after_mining_rule.js +3 -3
  37. package/dest/mem_pools/tx_pool_v2/deleted_pool.d.ts +104 -0
  38. package/dest/mem_pools/tx_pool_v2/deleted_pool.d.ts.map +1 -0
  39. package/dest/mem_pools/tx_pool_v2/deleted_pool.js +251 -0
  40. package/dest/mem_pools/tx_pool_v2/eviction/eviction_manager.d.ts +3 -3
  41. package/dest/mem_pools/tx_pool_v2/eviction/eviction_manager.d.ts.map +1 -1
  42. package/dest/mem_pools/tx_pool_v2/eviction/eviction_manager.js +18 -9
  43. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.d.ts +1 -1
  44. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.d.ts.map +1 -1
  45. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.js +5 -2
  46. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.d.ts +3 -3
  47. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.d.ts.map +1 -1
  48. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.js +12 -4
  49. package/dest/mem_pools/tx_pool_v2/eviction/index.d.ts +2 -2
  50. package/dest/mem_pools/tx_pool_v2/eviction/index.d.ts.map +1 -1
  51. package/dest/mem_pools/tx_pool_v2/eviction/index.js +1 -1
  52. package/dest/mem_pools/tx_pool_v2/eviction/interfaces.d.ts +48 -5
  53. package/dest/mem_pools/tx_pool_v2/eviction/interfaces.d.ts.map +1 -1
  54. package/dest/mem_pools/tx_pool_v2/eviction/interfaces.js +8 -0
  55. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_mining_rule.js +7 -5
  56. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_reorg_rule.js +7 -5
  57. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.d.ts +2 -2
  58. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.d.ts.map +1 -1
  59. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.js +14 -6
  60. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.d.ts +4 -4
  61. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.d.ts.map +1 -1
  62. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.js +14 -4
  63. package/dest/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.d.ts +3 -3
  64. package/dest/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.d.ts.map +1 -1
  65. package/dest/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.js +2 -2
  66. package/dest/mem_pools/tx_pool_v2/index.d.ts +3 -2
  67. package/dest/mem_pools/tx_pool_v2/index.d.ts.map +1 -1
  68. package/dest/mem_pools/tx_pool_v2/index.js +2 -1
  69. package/dest/mem_pools/tx_pool_v2/instrumentation.d.ts +15 -0
  70. package/dest/mem_pools/tx_pool_v2/instrumentation.d.ts.map +1 -0
  71. package/dest/mem_pools/tx_pool_v2/instrumentation.js +43 -0
  72. package/dest/mem_pools/tx_pool_v2/interfaces.d.ts +22 -8
  73. package/dest/mem_pools/tx_pool_v2/interfaces.d.ts.map +1 -1
  74. package/dest/mem_pools/tx_pool_v2/interfaces.js +4 -1
  75. package/dest/mem_pools/tx_pool_v2/tx_metadata.d.ts +56 -8
  76. package/dest/mem_pools/tx_pool_v2/tx_metadata.d.ts.map +1 -1
  77. package/dest/mem_pools/tx_pool_v2/tx_metadata.js +108 -10
  78. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.d.ts +12 -3
  79. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.d.ts.map +1 -1
  80. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.js +36 -14
  81. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.d.ts +9 -4
  82. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.d.ts.map +1 -1
  83. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.js +11 -6
  84. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.d.ts +13 -5
  85. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.d.ts.map +1 -1
  86. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.js +342 -185
  87. package/dest/msg_validators/attestation_validator/fisherman_attestation_validator.d.ts +3 -3
  88. package/dest/msg_validators/attestation_validator/fisherman_attestation_validator.d.ts.map +1 -1
  89. package/dest/msg_validators/tx_validator/aggregate_tx_validator.d.ts +4 -4
  90. package/dest/msg_validators/tx_validator/aggregate_tx_validator.d.ts.map +1 -1
  91. package/dest/msg_validators/tx_validator/aggregate_tx_validator.js +3 -3
  92. package/dest/msg_validators/tx_validator/block_header_validator.d.ts +16 -3
  93. package/dest/msg_validators/tx_validator/block_header_validator.d.ts.map +1 -1
  94. package/dest/msg_validators/tx_validator/block_header_validator.js +1 -1
  95. package/dest/msg_validators/tx_validator/double_spend_validator.d.ts +13 -3
  96. package/dest/msg_validators/tx_validator/double_spend_validator.d.ts.map +1 -1
  97. package/dest/msg_validators/tx_validator/double_spend_validator.js +4 -4
  98. package/dest/msg_validators/tx_validator/factory.d.ts +114 -6
  99. package/dest/msg_validators/tx_validator/factory.d.ts.map +1 -1
  100. package/dest/msg_validators/tx_validator/factory.js +219 -58
  101. package/dest/msg_validators/tx_validator/gas_validator.d.ts +58 -3
  102. package/dest/msg_validators/tx_validator/gas_validator.d.ts.map +1 -1
  103. package/dest/msg_validators/tx_validator/gas_validator.js +73 -36
  104. package/dest/msg_validators/tx_validator/index.d.ts +2 -1
  105. package/dest/msg_validators/tx_validator/index.d.ts.map +1 -1
  106. package/dest/msg_validators/tx_validator/index.js +1 -0
  107. package/dest/msg_validators/tx_validator/nullifier_cache.d.ts +14 -0
  108. package/dest/msg_validators/tx_validator/nullifier_cache.d.ts.map +1 -0
  109. package/dest/msg_validators/tx_validator/nullifier_cache.js +24 -0
  110. package/dest/msg_validators/tx_validator/timestamp_validator.d.ts +20 -4
  111. package/dest/msg_validators/tx_validator/timestamp_validator.d.ts.map +1 -1
  112. package/dest/msg_validators/tx_validator/timestamp_validator.js +6 -6
  113. package/dest/services/dummy_service.d.ts +13 -5
  114. package/dest/services/dummy_service.d.ts.map +1 -1
  115. package/dest/services/dummy_service.js +10 -4
  116. package/dest/services/encoding.d.ts +3 -3
  117. package/dest/services/encoding.d.ts.map +1 -1
  118. package/dest/services/encoding.js +11 -10
  119. package/dest/services/gossipsub/index.d.ts +3 -0
  120. package/dest/services/gossipsub/index.d.ts.map +1 -0
  121. package/dest/services/gossipsub/index.js +2 -0
  122. package/dest/services/gossipsub/scoring.d.ts +21 -3
  123. package/dest/services/gossipsub/scoring.d.ts.map +1 -1
  124. package/dest/services/gossipsub/scoring.js +24 -7
  125. package/dest/services/gossipsub/topic_score_params.d.ts +173 -0
  126. package/dest/services/gossipsub/topic_score_params.d.ts.map +1 -0
  127. package/dest/services/gossipsub/topic_score_params.js +346 -0
  128. package/dest/services/libp2p/libp2p_service.d.ts +95 -43
  129. package/dest/services/libp2p/libp2p_service.d.ts.map +1 -1
  130. package/dest/services/libp2p/libp2p_service.js +418 -331
  131. package/dest/services/peer-manager/peer_scoring.d.ts +1 -1
  132. package/dest/services/peer-manager/peer_scoring.d.ts.map +1 -1
  133. package/dest/services/peer-manager/peer_scoring.js +25 -2
  134. package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.d.ts +4 -3
  135. package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.d.ts.map +1 -1
  136. package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.js +19 -46
  137. package/dest/services/reqresp/batch-tx-requester/interface.d.ts +2 -6
  138. package/dest/services/reqresp/batch-tx-requester/interface.d.ts.map +1 -1
  139. package/dest/services/reqresp/batch-tx-requester/missing_txs.d.ts +10 -13
  140. package/dest/services/reqresp/batch-tx-requester/missing_txs.d.ts.map +1 -1
  141. package/dest/services/reqresp/batch-tx-requester/missing_txs.js +25 -46
  142. package/dest/services/reqresp/batch-tx-requester/peer_collection.d.ts +17 -11
  143. package/dest/services/reqresp/batch-tx-requester/peer_collection.d.ts.map +1 -1
  144. package/dest/services/reqresp/batch-tx-requester/peer_collection.js +49 -15
  145. package/dest/services/reqresp/batch-tx-requester/tx_validator.js +2 -2
  146. package/dest/services/reqresp/interface.d.ts +10 -1
  147. package/dest/services/reqresp/interface.d.ts.map +1 -1
  148. package/dest/services/reqresp/interface.js +15 -1
  149. package/dest/services/reqresp/protocols/block_txs/block_txs_handler.d.ts +4 -3
  150. package/dest/services/reqresp/protocols/block_txs/block_txs_handler.d.ts.map +1 -1
  151. package/dest/services/reqresp/protocols/block_txs/block_txs_reqresp.d.ts +7 -1
  152. package/dest/services/reqresp/protocols/block_txs/block_txs_reqresp.d.ts.map +1 -1
  153. package/dest/services/reqresp/protocols/block_txs/block_txs_reqresp.js +15 -0
  154. package/dest/services/reqresp/protocols/tx.d.ts +7 -1
  155. package/dest/services/reqresp/protocols/tx.d.ts.map +1 -1
  156. package/dest/services/reqresp/protocols/tx.js +20 -0
  157. package/dest/services/reqresp/reqresp.d.ts +1 -1
  158. package/dest/services/reqresp/reqresp.d.ts.map +1 -1
  159. package/dest/services/reqresp/reqresp.js +13 -5
  160. package/dest/services/service.d.ts +39 -3
  161. package/dest/services/service.d.ts.map +1 -1
  162. package/dest/services/tx_collection/config.d.ts +19 -1
  163. package/dest/services/tx_collection/config.d.ts.map +1 -1
  164. package/dest/services/tx_collection/config.js +46 -0
  165. package/dest/services/tx_collection/fast_tx_collection.d.ts +3 -1
  166. package/dest/services/tx_collection/fast_tx_collection.d.ts.map +1 -1
  167. package/dest/services/tx_collection/fast_tx_collection.js +56 -36
  168. package/dest/services/tx_collection/file_store_tx_collection.d.ts +53 -0
  169. package/dest/services/tx_collection/file_store_tx_collection.d.ts.map +1 -0
  170. package/dest/services/tx_collection/file_store_tx_collection.js +167 -0
  171. package/dest/services/tx_collection/file_store_tx_source.d.ts +37 -0
  172. package/dest/services/tx_collection/file_store_tx_source.d.ts.map +1 -0
  173. package/dest/services/tx_collection/file_store_tx_source.js +90 -0
  174. package/dest/services/tx_collection/index.d.ts +2 -1
  175. package/dest/services/tx_collection/index.d.ts.map +1 -1
  176. package/dest/services/tx_collection/index.js +1 -0
  177. package/dest/services/tx_collection/instrumentation.d.ts +1 -1
  178. package/dest/services/tx_collection/instrumentation.d.ts.map +1 -1
  179. package/dest/services/tx_collection/instrumentation.js +2 -1
  180. package/dest/services/tx_collection/missing_txs_tracker.d.ts +32 -0
  181. package/dest/services/tx_collection/missing_txs_tracker.d.ts.map +1 -0
  182. package/dest/services/tx_collection/missing_txs_tracker.js +27 -0
  183. package/dest/services/tx_collection/proposal_tx_collector.d.ts +7 -6
  184. package/dest/services/tx_collection/proposal_tx_collector.d.ts.map +1 -1
  185. package/dest/services/tx_collection/proposal_tx_collector.js +5 -4
  186. package/dest/services/tx_collection/slow_tx_collection.d.ts +7 -3
  187. package/dest/services/tx_collection/slow_tx_collection.d.ts.map +1 -1
  188. package/dest/services/tx_collection/slow_tx_collection.js +60 -26
  189. package/dest/services/tx_collection/tx_collection.d.ts +23 -10
  190. package/dest/services/tx_collection/tx_collection.d.ts.map +1 -1
  191. package/dest/services/tx_collection/tx_collection.js +75 -3
  192. package/dest/services/tx_collection/tx_collection_sink.d.ts +18 -8
  193. package/dest/services/tx_collection/tx_collection_sink.d.ts.map +1 -1
  194. package/dest/services/tx_collection/tx_collection_sink.js +26 -29
  195. package/dest/services/tx_collection/tx_source.d.ts +8 -3
  196. package/dest/services/tx_collection/tx_source.d.ts.map +1 -1
  197. package/dest/services/tx_collection/tx_source.js +19 -2
  198. package/dest/services/tx_file_store/config.d.ts +1 -3
  199. package/dest/services/tx_file_store/config.d.ts.map +1 -1
  200. package/dest/services/tx_file_store/config.js +0 -4
  201. package/dest/services/tx_file_store/tx_file_store.d.ts +4 -3
  202. package/dest/services/tx_file_store/tx_file_store.d.ts.map +1 -1
  203. package/dest/services/tx_file_store/tx_file_store.js +9 -6
  204. package/dest/services/tx_provider.d.ts +4 -4
  205. package/dest/services/tx_provider.d.ts.map +1 -1
  206. package/dest/services/tx_provider.js +9 -8
  207. package/dest/test-helpers/make-test-p2p-clients.d.ts +7 -8
  208. package/dest/test-helpers/make-test-p2p-clients.d.ts.map +1 -1
  209. package/dest/test-helpers/make-test-p2p-clients.js +1 -2
  210. package/dest/test-helpers/mock-pubsub.d.ts +30 -4
  211. package/dest/test-helpers/mock-pubsub.d.ts.map +1 -1
  212. package/dest/test-helpers/mock-pubsub.js +105 -4
  213. package/dest/test-helpers/reqresp-nodes.d.ts +2 -3
  214. package/dest/test-helpers/reqresp-nodes.d.ts.map +1 -1
  215. package/dest/test-helpers/reqresp-nodes.js +4 -3
  216. package/dest/test-helpers/testbench-utils.d.ts +43 -38
  217. package/dest/test-helpers/testbench-utils.d.ts.map +1 -1
  218. package/dest/test-helpers/testbench-utils.js +128 -59
  219. package/dest/testbench/p2p_client_testbench_worker.d.ts +2 -2
  220. package/dest/testbench/p2p_client_testbench_worker.d.ts.map +1 -1
  221. package/dest/testbench/p2p_client_testbench_worker.js +15 -15
  222. package/dest/util.d.ts +2 -2
  223. package/dest/util.d.ts.map +1 -1
  224. package/package.json +14 -14
  225. package/src/client/factory.ts +74 -27
  226. package/src/client/interface.ts +56 -34
  227. package/src/client/p2p_client.ts +180 -247
  228. package/src/client/test/tx_proposal_collector/proposal_tx_collector_worker.ts +20 -11
  229. package/src/config.ts +35 -11
  230. package/src/errors/tx-pool.error.ts +12 -0
  231. package/src/index.ts +1 -0
  232. package/src/mem_pools/attestation_pool/attestation_pool.ts +496 -91
  233. package/src/mem_pools/attestation_pool/attestation_pool_test_suite.ts +442 -102
  234. package/src/mem_pools/attestation_pool/index.ts +9 -2
  235. package/src/mem_pools/attestation_pool/mocks.ts +2 -1
  236. package/src/mem_pools/index.ts +4 -1
  237. package/src/mem_pools/interface.ts +4 -4
  238. package/src/mem_pools/tx_pool/README.md +1 -1
  239. package/src/mem_pools/tx_pool/eviction/invalid_txs_after_mining_rule.ts +3 -3
  240. package/src/mem_pools/tx_pool_v2/README.md +76 -10
  241. package/src/mem_pools/tx_pool_v2/deleted_pool.ts +321 -0
  242. package/src/mem_pools/tx_pool_v2/eviction/eviction_manager.ts +21 -8
  243. package/src/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.ts +5 -2
  244. package/src/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.ts +18 -4
  245. package/src/mem_pools/tx_pool_v2/eviction/index.ts +4 -0
  246. package/src/mem_pools/tx_pool_v2/eviction/interfaces.ts +49 -4
  247. package/src/mem_pools/tx_pool_v2/eviction/invalid_txs_after_mining_rule.ts +5 -5
  248. package/src/mem_pools/tx_pool_v2/eviction/invalid_txs_after_reorg_rule.ts +5 -5
  249. package/src/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.ts +14 -9
  250. package/src/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.ts +24 -6
  251. package/src/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.ts +3 -3
  252. package/src/mem_pools/tx_pool_v2/index.ts +2 -1
  253. package/src/mem_pools/tx_pool_v2/instrumentation.ts +69 -0
  254. package/src/mem_pools/tx_pool_v2/interfaces.ts +23 -8
  255. package/src/mem_pools/tx_pool_v2/tx_metadata.ts +153 -17
  256. package/src/mem_pools/tx_pool_v2/tx_pool_indices.ts +43 -16
  257. package/src/mem_pools/tx_pool_v2/tx_pool_v2.ts +18 -7
  258. package/src/mem_pools/tx_pool_v2/tx_pool_v2_impl.ts +383 -182
  259. package/src/msg_validators/attestation_validator/fisherman_attestation_validator.ts +2 -2
  260. package/src/msg_validators/tx_validator/README.md +115 -0
  261. package/src/msg_validators/tx_validator/aggregate_tx_validator.ts +5 -5
  262. package/src/msg_validators/tx_validator/block_header_validator.ts +15 -3
  263. package/src/msg_validators/tx_validator/double_spend_validator.ts +11 -6
  264. package/src/msg_validators/tx_validator/factory.ts +353 -77
  265. package/src/msg_validators/tx_validator/gas_validator.ts +90 -27
  266. package/src/msg_validators/tx_validator/index.ts +1 -0
  267. package/src/msg_validators/tx_validator/nullifier_cache.ts +30 -0
  268. package/src/msg_validators/tx_validator/timestamp_validator.ts +23 -18
  269. package/src/services/dummy_service.ts +18 -6
  270. package/src/services/encoding.ts +9 -9
  271. package/src/services/gossipsub/README.md +641 -0
  272. package/src/services/gossipsub/index.ts +2 -0
  273. package/src/services/gossipsub/scoring.ts +29 -5
  274. package/src/services/gossipsub/topic_score_params.ts +487 -0
  275. package/src/services/libp2p/libp2p_service.ts +436 -355
  276. package/src/services/peer-manager/peer_scoring.ts +25 -0
  277. package/src/services/reqresp/batch-tx-requester/batch_tx_requester.ts +20 -48
  278. package/src/services/reqresp/batch-tx-requester/interface.ts +1 -5
  279. package/src/services/reqresp/batch-tx-requester/missing_txs.ts +23 -71
  280. package/src/services/reqresp/batch-tx-requester/peer_collection.ts +63 -24
  281. package/src/services/reqresp/batch-tx-requester/tx_validator.ts +2 -2
  282. package/src/services/reqresp/interface.ts +26 -1
  283. package/src/services/reqresp/protocols/block_txs/block_txs_handler.ts +4 -3
  284. package/src/services/reqresp/protocols/block_txs/block_txs_reqresp.ts +17 -0
  285. package/src/services/reqresp/protocols/tx.ts +22 -0
  286. package/src/services/reqresp/reqresp.ts +16 -4
  287. package/src/services/service.ts +51 -2
  288. package/src/services/tx_collection/config.ts +68 -0
  289. package/src/services/tx_collection/fast_tx_collection.ts +65 -32
  290. package/src/services/tx_collection/file_store_tx_collection.ts +202 -0
  291. package/src/services/tx_collection/file_store_tx_source.ts +117 -0
  292. package/src/services/tx_collection/index.ts +1 -0
  293. package/src/services/tx_collection/instrumentation.ts +7 -1
  294. package/src/services/tx_collection/missing_txs_tracker.ts +52 -0
  295. package/src/services/tx_collection/proposal_tx_collector.ts +8 -7
  296. package/src/services/tx_collection/slow_tx_collection.ts +66 -33
  297. package/src/services/tx_collection/tx_collection.ts +113 -16
  298. package/src/services/tx_collection/tx_collection_sink.ts +30 -34
  299. package/src/services/tx_collection/tx_source.ts +22 -3
  300. package/src/services/tx_file_store/config.ts +0 -6
  301. package/src/services/tx_file_store/tx_file_store.ts +10 -8
  302. package/src/services/tx_provider.ts +10 -9
  303. package/src/test-helpers/make-test-p2p-clients.ts +3 -5
  304. package/src/test-helpers/mock-pubsub.ts +146 -9
  305. package/src/test-helpers/reqresp-nodes.ts +4 -6
  306. package/src/test-helpers/testbench-utils.ts +127 -71
  307. package/src/testbench/p2p_client_testbench_worker.ts +24 -21
  308. package/src/util.ts +7 -1
  309. package/dest/mem_pools/attestation_pool/kv_attestation_pool.d.ts +0 -40
  310. package/dest/mem_pools/attestation_pool/kv_attestation_pool.d.ts.map +0 -1
  311. package/dest/mem_pools/attestation_pool/kv_attestation_pool.js +0 -218
  312. package/dest/mem_pools/attestation_pool/memory_attestation_pool.d.ts +0 -31
  313. package/dest/mem_pools/attestation_pool/memory_attestation_pool.d.ts.map +0 -1
  314. package/dest/mem_pools/attestation_pool/memory_attestation_pool.js +0 -180
  315. package/src/mem_pools/attestation_pool/kv_attestation_pool.ts +0 -320
  316. package/src/mem_pools/attestation_pool/memory_attestation_pool.ts +0 -264
@@ -1,6 +1,5 @@
1
1
  import type { EpochCacheInterface } from '@aztec/epoch-cache';
2
- import { BlockNumber } from '@aztec/foundation/branded-types';
3
- import { randomInt } from '@aztec/foundation/crypto/random';
2
+ import { BlockNumber, type SlotNumber } from '@aztec/foundation/branded-types';
4
3
  import { Fr } from '@aztec/foundation/curves/bn254';
5
4
  import { type Logger, createLibp2pComponentLogger, createLogger } from '@aztec/foundation/log';
6
5
  import { RunningPromise } from '@aztec/foundation/running-promise';
@@ -17,13 +16,12 @@ import {
17
16
  CheckpointProposal,
18
17
  type CheckpointProposalCore,
19
18
  type Gossipable,
20
- P2PClientType,
21
19
  P2PMessage,
22
20
  type ValidationResult as P2PValidationResult,
23
21
  PeerErrorSeverity,
24
22
  TopicType,
25
23
  createTopicString,
26
- getTopicsForClientAndConfig,
24
+ getTopicsForConfig,
27
25
  metricsTopicStrToLabels,
28
26
  } from '@aztec/stdlib/p2p';
29
27
  import { MerkleTreeId } from '@aztec/stdlib/trees';
@@ -45,7 +43,7 @@ import {
45
43
  type GossipsubMessage,
46
44
  gossipsub,
47
45
  } from '@chainsafe/libp2p-gossipsub';
48
- import { createPeerScoreParams, createTopicScoreParams } from '@chainsafe/libp2p-gossipsub/score';
46
+ import { createPeerScoreParams } from '@chainsafe/libp2p-gossipsub/score';
49
47
  import { SignaturePolicy } from '@chainsafe/libp2p-gossipsub/types';
50
48
  import { noise } from '@chainsafe/libp2p-noise';
51
49
  import { yamux } from '@chainsafe/libp2p-yamux';
@@ -59,8 +57,7 @@ import { ENR } from '@nethermindeth/enr';
59
57
  import { createLibp2p } from 'libp2p';
60
58
 
61
59
  import type { P2PConfig } from '../../config.js';
62
- import { ProposalSlotCapExceededError } from '../../errors/attestation-pool.error.js';
63
- import type { MemPools } from '../../mem_pools/index.js';
60
+ import type { MemPools } from '../../mem_pools/interface.js';
64
61
  import {
65
62
  BlockProposalValidator,
66
63
  CheckpointAttestationValidator,
@@ -71,9 +68,11 @@ import {
71
68
  } from '../../msg_validators/index.js';
72
69
  import { MessageSeenValidator } from '../../msg_validators/msg_seen_validator/msg_seen_validator.js';
73
70
  import {
74
- type MessageValidator,
75
- createTxMessageValidators,
76
- createTxReqRespValidator,
71
+ type TransactionValidator,
72
+ createFirstStageTxValidationsForGossipedTransactions,
73
+ createSecondStageTxValidationsForGossipedTransactions,
74
+ createTxValidatorForBlockProposalReceivedTxs,
75
+ createTxValidatorForReqResponseReceivedTxs,
77
76
  } from '../../msg_validators/tx_validator/factory.js';
78
77
  import { GossipSubEvent } from '../../types/index.js';
79
78
  import { type PubSubLibp2p, convertToMultiaddr } from '../../util.js';
@@ -81,13 +80,17 @@ import { getVersions } from '../../versioning.js';
81
80
  import { AztecDatastore } from '../data_store.js';
82
81
  import { DiscV5Service } from '../discv5/discV5_service.js';
83
82
  import { SnappyTransform, fastMsgIdFn, getMsgIdFn, msgIdToStrFn } from '../encoding.js';
84
- import { gossipScoreThresholds } from '../gossipsub/scoring.js';
83
+ import { APP_SPECIFIC_WEIGHT, gossipScoreThresholds } from '../gossipsub/scoring.js';
84
+ import { createAllTopicScoreParams } from '../gossipsub/topic_score_params.js';
85
85
  import type { PeerManagerInterface } from '../peer-manager/interface.js';
86
86
  import { PeerManager } from '../peer-manager/peer_manager.js';
87
87
  import { PeerScoring } from '../peer-manager/peer_scoring.js';
88
88
  import type { BatchTxRequesterLibP2PService } from '../reqresp/batch-tx-requester/interface.js';
89
89
  import type { P2PReqRespConfig } from '../reqresp/config.js';
90
90
  import {
91
+ AuthRequest,
92
+ BlockTxsRequest,
93
+ BlockTxsResponse,
91
94
  DEFAULT_SUB_PROTOCOL_VALIDATORS,
92
95
  type ReqRespInterface,
93
96
  type ReqRespResponse,
@@ -95,14 +98,9 @@ import {
95
98
  type ReqRespSubProtocolHandler,
96
99
  type ReqRespSubProtocolHandlers,
97
100
  type ReqRespSubProtocolValidators,
101
+ StatusMessage,
98
102
  type SubProtocolMap,
99
103
  ValidationError,
100
- } from '../reqresp/index.js';
101
- import {
102
- AuthRequest,
103
- BlockTxsRequest,
104
- BlockTxsResponse,
105
- StatusMessage,
106
104
  pingHandler,
107
105
  reqGoodbyeHandler,
108
106
  reqRespBlockHandler,
@@ -114,6 +112,7 @@ import { ReqResp } from '../reqresp/reqresp.js';
114
112
  import type {
115
113
  P2PBlockReceivedCallback,
116
114
  P2PCheckpointReceivedCallback,
115
+ P2PDuplicateAttestationCallback,
117
116
  P2PService,
118
117
  PeerDiscoveryService,
119
118
  } from '../service.js';
@@ -128,14 +127,14 @@ interface ValidationResult {
128
127
  type ValidationOutcome = { allPassed: true } | { allPassed: false; failure: ValidationResult };
129
128
 
130
129
  // REFACTOR: Unify with the type above
131
- type ReceivedMessageValidationResult<T> =
132
- | { obj: T; result: Exclude<TopicValidatorResult, TopicValidatorResult.Reject> }
133
- | { obj?: undefined; result: TopicValidatorResult.Reject };
130
+ type ReceivedMessageValidationResult<T, M = undefined> =
131
+ | { obj: T; result: Exclude<TopicValidatorResult, TopicValidatorResult.Reject>; metadata?: M }
132
+ | { obj?: T; result: TopicValidatorResult.Reject; metadata?: M };
134
133
 
135
134
  /**
136
135
  * Lib P2P implementation of the P2PService interface.
137
136
  */
138
- export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends WithTracer implements P2PService {
137
+ export class LibP2PService extends WithTracer implements P2PService {
139
138
  private discoveryRunningPromise?: RunningPromise;
140
139
  private msgIdSeenValidators: Record<TopicType, MessageSeenValidator> = {} as Record<TopicType, MessageSeenValidator>;
141
140
 
@@ -149,6 +148,16 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
149
148
 
150
149
  private feesCache: { blockNumber: BlockNumber; gasFees: GasFees } | undefined;
151
150
 
151
+ /** Callback invoked when a duplicate proposal is detected (triggers slashing). */
152
+ private duplicateProposalCallback?: (info: {
153
+ slot: SlotNumber;
154
+ proposer: EthAddress;
155
+ type: 'checkpoint' | 'block';
156
+ }) => void;
157
+
158
+ /** Callback invoked when a duplicate attestation is detected (triggers slashing). */
159
+ private duplicateAttestationCallback?: P2PDuplicateAttestationCallback;
160
+
152
161
  /**
153
162
  * Callback for when a block is received from a peer.
154
163
  * @param block - The block received from the peer.
@@ -172,14 +181,13 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
172
181
  protected logger: Logger;
173
182
 
174
183
  constructor(
175
- private clientType: T,
176
184
  private config: P2PConfig,
177
185
  protected node: PubSubLibp2p,
178
186
  private peerDiscoveryService: PeerDiscoveryService,
179
187
  private reqresp: ReqRespInterface,
180
- private peerManager: PeerManagerInterface,
188
+ protected peerManager: PeerManagerInterface,
181
189
  protected mempools: MemPools,
182
- private archiver: L2BlockSource & ContractDataSource,
190
+ protected archiver: L2BlockSource & ContractDataSource,
183
191
  private epochCache: EpochCacheInterface,
184
192
  private proofVerifier: ClientProtocolCircuitVerifier,
185
193
  private worldStateSynchronizer: WorldStateSynchronizer,
@@ -252,8 +260,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
252
260
  * @param txPool - The transaction pool to be accessed by the service.
253
261
  * @returns The new service.
254
262
  */
255
- public static async new<T extends P2PClientType>(
256
- clientType: T,
263
+ public static async new(
257
264
  config: P2PConfig,
258
265
  peerId: PeerId,
259
266
  deps: {
@@ -305,11 +312,6 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
305
312
  const versions = getVersions(config);
306
313
  const protocolVersion = compressComponentVersions(versions);
307
314
 
308
- const txTopic = createTopicString(TopicType.tx, protocolVersion);
309
- const blockProposalTopic = createTopicString(TopicType.block_proposal, protocolVersion);
310
- const checkpointProposalTopic = createTopicString(TopicType.checkpoint_proposal, protocolVersion);
311
- const checkpointAttestationTopic = createTopicString(TopicType.checkpoint_attestation, protocolVersion);
312
-
313
315
  const preferredPeersEnrs: ENR[] = config.preferredPeers.map(enr => ENR.decodeTxt(enr));
314
316
  const directPeers = (
315
317
  await Promise.all(
@@ -329,6 +331,16 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
329
331
 
330
332
  const announceTcpMultiaddr = config.p2pIp ? [convertToMultiaddr(config.p2pIp, p2pPort, 'tcp')] : [];
331
333
 
334
+ // Create dynamic topic score params based on network configuration
335
+ const l1Constants = epochCache.getL1Constants();
336
+ const topicScoreParams = createAllTopicScoreParams(protocolVersion, {
337
+ slotDurationMs: l1Constants.slotDuration * 1000,
338
+ heartbeatIntervalMs: config.gossipsubInterval,
339
+ targetCommitteeSize: l1Constants.targetCommitteeSize,
340
+ blockDurationMs: config.blockDurationMs,
341
+ expectedBlockProposalsPerSlot: config.expectedBlockProposalsPerSlot,
342
+ });
343
+
332
344
  const node = await createLibp2p({
333
345
  start: false,
334
346
  peerId,
@@ -424,28 +436,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
424
436
  scoreParams: createPeerScoreParams({
425
437
  // IPColocation factor can be disabled for local testing - default to -5
426
438
  IPColocationFactorWeight: config.debugDisableColocationPenalty ? 0 : -5.0,
427
- topics: {
428
- [txTopic]: createTopicScoreParams({
429
- topicWeight: 1,
430
- invalidMessageDeliveriesWeight: -20,
431
- invalidMessageDeliveriesDecay: 0.5,
432
- }),
433
- [blockProposalTopic]: createTopicScoreParams({
434
- topicWeight: 1,
435
- invalidMessageDeliveriesWeight: -20,
436
- invalidMessageDeliveriesDecay: 0.5,
437
- }),
438
- [checkpointProposalTopic]: createTopicScoreParams({
439
- topicWeight: 1,
440
- invalidMessageDeliveriesWeight: -20,
441
- invalidMessageDeliveriesDecay: 0.5,
442
- }),
443
- [checkpointAttestationTopic]: createTopicScoreParams({
444
- topicWeight: 1,
445
- invalidMessageDeliveriesWeight: -20,
446
- invalidMessageDeliveriesDecay: 0.5,
447
- }),
448
- },
439
+ topics: topicScoreParams,
449
440
  }),
450
441
  }) as (components: GossipSubComponents) => GossipSub,
451
442
  components: (components: { connectionManager: ConnectionManager }) => ({
@@ -471,13 +462,16 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
471
462
  epochCache,
472
463
  );
473
464
 
474
- // Update gossipsub score params
475
- node.services.pubsub.score.params.appSpecificWeight = 10;
465
+ // Configure application-specific scoring for gossipsub.
466
+ // The weight scales app score to align with gossipsub thresholds:
467
+ // - Disconnect (-50) × 10 = -500 = gossipThreshold (stops receiving gossip)
468
+ // - Ban (-100) × 10 = -1000 = publishThreshold (cannot publish)
469
+ // Note: positive topic scores can offset penalties, so alignment is best-effort.
470
+ node.services.pubsub.score.params.appSpecificWeight = APP_SPECIFIC_WEIGHT;
476
471
  node.services.pubsub.score.params.appSpecificScore = (peerId: string) =>
477
472
  peerManager.shouldDisableP2PGossip(peerId) ? -Infinity : peerManager.getPeerScore(peerId);
478
473
 
479
474
  return new LibP2PService(
480
- clientType,
481
475
  config,
482
476
  node,
483
477
  peerDiscoveryService,
@@ -551,7 +545,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
551
545
  await this.node.start();
552
546
 
553
547
  // Subscribe to standard GossipSub topics by default
554
- for (const topic of getTopicsForClientAndConfig(this.clientType, this.config.disableTransactions)) {
548
+ for (const topic of getTopicsForConfig(this.config.disableTransactions)) {
555
549
  this.subscribeToTopic(this.topicStrings[topic]);
556
550
  }
557
551
 
@@ -617,6 +611,10 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
617
611
  return this.peerManager.getPeers(includePending);
618
612
  }
619
613
 
614
+ public getGossipMeshPeerCount(topicType: TopicType): number {
615
+ return this.node.services.pubsub.getMeshPeers(this.topicStrings[topicType]).length;
616
+ }
617
+
620
618
  private handleGossipSubEvent(e: CustomEvent<GossipsubMessage>) {
621
619
  this.logger.trace(`Received PUBSUB message.`);
622
620
 
@@ -669,6 +667,25 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
669
667
  this.checkpointReceivedCallback = callback;
670
668
  }
671
669
 
670
+ /**
671
+ * Registers a callback to be invoked when a duplicate proposal is detected.
672
+ * This callback is triggered on the first duplicate (when count goes from 1 to 2).
673
+ */
674
+ public registerDuplicateProposalCallback(
675
+ callback: (info: { slot: SlotNumber; proposer: EthAddress; type: 'checkpoint' | 'block' }) => void,
676
+ ): void {
677
+ this.duplicateProposalCallback = callback;
678
+ }
679
+
680
+ /**
681
+ * Registers a callback to be invoked when a duplicate attestation is detected.
682
+ * A validator signing attestations for different proposals at the same slot.
683
+ * This callback is triggered on the first duplicate (when count goes from 1 to 2).
684
+ */
685
+ public registerDuplicateAttestationCallback(callback: P2PDuplicateAttestationCallback): void {
686
+ this.duplicateAttestationCallback = callback;
687
+ }
688
+
672
689
  /**
673
690
  * Subscribes to a topic.
674
691
  * @param topic - The topic to subscribe to.
@@ -797,9 +814,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
797
814
  if (msg.topic === this.topicStrings[TopicType.tx]) {
798
815
  await this.handleGossipedTx(p2pMessage.payload, msgId, source);
799
816
  } else if (msg.topic === this.topicStrings[TopicType.checkpoint_attestation]) {
800
- if (this.clientType === P2PClientType.Full) {
801
- await this.processCheckpointAttestationFromPeer(p2pMessage.payload, msgId, source);
802
- }
817
+ await this.processCheckpointAttestationFromPeer(p2pMessage.payload, msgId, source);
803
818
  } else if (msg.topic === this.topicStrings[TopicType.block_proposal]) {
804
819
  await this.processBlockFromPeer(p2pMessage.payload, msgId, source);
805
820
  } else if (msg.topic === this.topicStrings[TopicType.checkpoint_proposal]) {
@@ -855,13 +870,13 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
855
870
  return;
856
871
  }
857
872
 
858
- protected async validateReceivedMessage<T>(
859
- validationFunc: () => Promise<ReceivedMessageValidationResult<T>>,
873
+ protected async validateReceivedMessage<T, M = undefined>(
874
+ validationFunc: () => Promise<ReceivedMessageValidationResult<T, M>>,
860
875
  msgId: string,
861
876
  source: PeerId,
862
877
  topicType: TopicType,
863
- ): Promise<ReceivedMessageValidationResult<T>> {
864
- let resultAndObj: ReceivedMessageValidationResult<T> = { result: TopicValidatorResult.Reject };
878
+ ): Promise<ReceivedMessageValidationResult<T, M>> {
879
+ let resultAndObj: ReceivedMessageValidationResult<T, M> = { result: TopicValidatorResult.Reject };
865
880
  const timer = new Timer();
866
881
  try {
867
882
  resultAndObj = await validationFunc();
@@ -885,21 +900,63 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
885
900
  protected async handleGossipedTx(payloadData: Buffer, msgId: string, source: PeerId) {
886
901
  const validationFunc: () => Promise<ReceivedMessageValidationResult<Tx>> = async () => {
887
902
  const tx = Tx.fromBuffer(payloadData);
888
- const isValid = await this.validatePropagatedTx(tx, source);
889
- const exists = isValid && (await this.mempools.txPool.hasTx(tx.getTxHash()));
903
+
904
+ const currentBlockNumber = await this.archiver.getBlockNumber();
905
+ const { ts: nextSlotTimestamp } = this.epochCache.getEpochAndSlotInNextL1Slot();
906
+
907
+ // Stage 1: fast validators (metadata, data, timestamps, double-spend, gas, phases, block header)
908
+ const firstStageValidators = await this.createFirstStageMessageValidators(currentBlockNumber, nextSlotTimestamp);
909
+ const firstStageOutcome = await this.runValidations(tx, firstStageValidators);
910
+ if (!firstStageOutcome.allPassed) {
911
+ const { name } = firstStageOutcome.failure;
912
+ let { severity } = firstStageOutcome.failure;
913
+
914
+ // Double spend validator has a special case handler. We perform more detailed examination
915
+ // as to how recently the nullifier was entered into the tree and if the transaction should
916
+ // have 'known' the nullifier existed. This determines the severity of the penalty applied to the peer.
917
+ if (name === 'doubleSpendValidator') {
918
+ const txBlockNumber = BlockNumber(currentBlockNumber + 1);
919
+ severity = await this.handleDoubleSpendFailure(tx, txBlockNumber);
920
+ }
921
+
922
+ this.peerManager.penalizePeer(source, severity);
923
+ return { result: TopicValidatorResult.Reject };
924
+ }
925
+
926
+ // Pool pre-check: see if the pool would accept this tx before doing expensive proof verification
927
+ const canAdd = await this.mempools.txPool.canAddPendingTx(tx);
928
+ if (canAdd === 'ignored') {
929
+ return { result: TopicValidatorResult.Ignore, obj: tx };
930
+ }
931
+
932
+ // Stage 2: expensive proof verification
933
+ const secondStageValidators = this.createSecondStageMessageValidators();
934
+ const secondStageOutcome = await this.runValidations(tx, secondStageValidators);
935
+ if (!secondStageOutcome.allPassed) {
936
+ const { severity } = secondStageOutcome.failure;
937
+ this.peerManager.penalizePeer(source, severity);
938
+ return { result: TopicValidatorResult.Reject };
939
+ }
940
+
941
+ // Pool add: persist the tx
942
+ const txHash = tx.getTxHash();
943
+ const addResult = await this.mempools.txPool.addPendingTxs([tx], { source: 'gossip' });
944
+
945
+ const wasAccepted = addResult.accepted.some(h => h.equals(txHash));
946
+ const wasIgnored = addResult.ignored.some(h => h.equals(txHash));
890
947
 
891
948
  this.logger.trace(`Validate propagated tx`, {
892
- isValid,
893
- exists,
949
+ wasAccepted,
950
+ wasIgnored,
894
951
  [Attributes.P2P_ID]: source.toString(),
895
952
  });
896
953
 
897
- if (!isValid) {
898
- return { result: TopicValidatorResult.Reject };
899
- } else if (exists) {
954
+ if (wasAccepted) {
955
+ return { result: TopicValidatorResult.Accept, obj: tx };
956
+ } else if (wasIgnored) {
900
957
  return { result: TopicValidatorResult.Ignore, obj: tx };
901
958
  } else {
902
- return { result: TopicValidatorResult.Accept, obj: tx };
959
+ return { result: TopicValidatorResult.Reject };
903
960
  }
904
961
  };
905
962
 
@@ -908,6 +965,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
908
965
  return;
909
966
  }
910
967
 
968
+ // Tx was accepted into pool and will be propagated - just log and record metrics
911
969
  const txHash = tx.getTxHash();
912
970
  const txHashString = txHash.toString();
913
971
  this.logger.verbose(`Received tx ${txHashString} from external peer ${source.toString()} via gossip`, {
@@ -915,13 +973,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
915
973
  txHash: txHashString,
916
974
  });
917
975
 
918
- if (this.config.dropTransactions && randomInt(1000) < this.config.dropTransactionsProbability * 1000) {
919
- this.logger.warn(`Intentionally dropping tx ${txHashString} (probability rule)`);
920
- return;
921
- }
922
-
923
976
  this.instrumentation.incrementTxReceived(1);
924
- await this.mempools.txPool.addTxs([tx]);
925
977
  }
926
978
 
927
979
  /**
@@ -933,47 +985,8 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
933
985
  msgId: string,
934
986
  source: PeerId,
935
987
  ): Promise<void> {
936
- const validationFunc: () => Promise<ReceivedMessageValidationResult<CheckpointAttestation>> = async () => {
937
- const attestation = CheckpointAttestation.fromBuffer(payloadData);
938
- const pool = this.mempools.attestationPool;
939
- const validationResult = await this.validateCheckpointAttestation(source, attestation);
940
- const isValid = validationResult.result === 'accept';
941
- const exists = isValid && (await pool.hasCheckpointAttestation(attestation));
942
-
943
- let canAdd = true;
944
- if (isValid && !exists) {
945
- const slot = attestation.payload.header.slotNumber;
946
- const { committee } = await this.epochCache.getCommittee(slot);
947
- const committeeSize = committee?.length ?? 0;
948
- canAdd = await pool.canAddCheckpointAttestation(attestation, committeeSize);
949
- }
950
-
951
- this.logger.trace(`Validate propagated checkpoint attestation`, {
952
- isValid,
953
- exists,
954
- canAdd,
955
- [Attributes.SLOT_NUMBER]: attestation.payload.header.slotNumber.toString(),
956
- [Attributes.P2P_ID]: source.toString(),
957
- });
958
-
959
- if (validationResult.result === 'reject') {
960
- return { result: TopicValidatorResult.Reject };
961
- } else if (validationResult.result === 'ignore' || exists) {
962
- return { result: TopicValidatorResult.Ignore, obj: attestation };
963
- } else if (!canAdd) {
964
- this.logger.warn(`Dropping checkpoint attestation due to per-(slot, proposalId) attestation cap`, {
965
- slot: attestation.payload.header.slotNumber.toString(),
966
- archive: attestation.archive.toString(),
967
- source: source.toString(),
968
- });
969
- return { result: TopicValidatorResult.Ignore, obj: attestation };
970
- } else {
971
- return { result: TopicValidatorResult.Accept, obj: attestation };
972
- }
973
- };
974
-
975
988
  const { result, obj: attestation } = await this.validateReceivedMessage<CheckpointAttestation>(
976
- validationFunc,
989
+ () => this.validateAndStoreCheckpointAttestation(source, CheckpointAttestation.fromBuffer(payloadData)),
977
990
  msgId,
978
991
  source,
979
992
  TopicType.checkpoint_attestation,
@@ -983,8 +996,8 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
983
996
  return;
984
997
  }
985
998
 
986
- this.logger.debug(
987
- `Received checkpoint attestation for slot ${attestation.slotNumber} from external peer ${source.toString()}`,
999
+ this.logger.verbose(
1000
+ `Received valid checkpoint attestation for slot ${attestation.slotNumber} from external peer ${source.toString()}`,
988
1001
  {
989
1002
  p2pMessageIdentifier: await attestation.p2pMessageLoggingIdentifier(),
990
1003
  slot: attestation.slotNumber,
@@ -992,60 +1005,167 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
992
1005
  source: source.toString(),
993
1006
  },
994
1007
  );
995
-
996
- await this.mempools.attestationPool.addCheckpointAttestations([attestation]);
997
1008
  }
998
1009
 
999
- private async processBlockFromPeer(payloadData: Buffer, msgId: string, source: PeerId): Promise<void> {
1000
- const validationFunc: () => Promise<ReceivedMessageValidationResult<BlockProposal>> = async () => {
1001
- const block = BlockProposal.fromBuffer(payloadData);
1002
- const validationResult = await this.validateBlockProposal(source, block);
1003
- const isValid = validationResult.result === 'accept';
1004
- const pool = this.mempools.attestationPool;
1005
-
1006
- const exists = isValid && (await pool.hasBlockProposal(block));
1007
- const canAdd = isValid && (await pool.canAddProposal(block));
1008
-
1009
- this.logger.trace(`Validate propagated block proposal`, {
1010
- isValid,
1011
- exists,
1012
- canAdd,
1013
- [Attributes.SLOT_NUMBER]: block.slotNumber.toString(),
1014
- [Attributes.P2P_ID]: source.toString(),
1010
+ /** Validates a checkpoint attestation and adds it to the pool. Penalizes the peer if validation fails. */
1011
+ @trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId, attestation) => ({
1012
+ [Attributes.SLOT_NUMBER]: attestation.payload.header.slotNumber.toString(),
1013
+ }))
1014
+ protected async validateAndStoreCheckpointAttestation(
1015
+ peerId: PeerId,
1016
+ attestation: CheckpointAttestation,
1017
+ ): Promise<ReceivedMessageValidationResult<CheckpointAttestation>> {
1018
+ const validationResult = await this.checkpointAttestationValidator.validate(attestation);
1019
+
1020
+ if (validationResult.result === 'reject') {
1021
+ this.logger.warn(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
1022
+ this.peerManager.penalizePeer(peerId, validationResult.severity);
1023
+ return { result: TopicValidatorResult.Reject };
1024
+ }
1025
+
1026
+ if (validationResult.result === 'ignore') {
1027
+ return { result: TopicValidatorResult.Ignore, obj: attestation };
1028
+ }
1029
+
1030
+ // Try to add the attestation: this handles existence check, cap check, and adding in one call
1031
+ // count is the number of attestations by this signer for this slot (for duplicate detection)
1032
+ const slot = attestation.payload.header.slotNumber;
1033
+ const { added, alreadyExists, count } =
1034
+ await this.mempools.attestationPool.tryAddCheckpointAttestation(attestation);
1035
+
1036
+ this.logger.trace(`Validate propagated checkpoint attestation`, {
1037
+ added,
1038
+ alreadyExists,
1039
+ count,
1040
+ [Attributes.SLOT_NUMBER]: slot.toString(),
1041
+ [Attributes.P2P_ID]: peerId.toString(),
1042
+ });
1043
+
1044
+ // Exact same attestation received, no need to re-broadcast
1045
+ if (alreadyExists) {
1046
+ return { result: TopicValidatorResult.Ignore, obj: attestation };
1047
+ }
1048
+
1049
+ // Could not add (cap reached for signer), no need to re-broadcast
1050
+ if (!added) {
1051
+ this.logger.warn(`Dropping checkpoint attestation due to cap`, {
1052
+ slot: slot.toString(),
1053
+ archive: attestation.archive.toString(),
1054
+ source: peerId.toString(),
1055
+ attester: attestation.getSender()?.toString(),
1056
+ count,
1015
1057
  });
1058
+ return { result: TopicValidatorResult.Ignore, obj: attestation };
1059
+ }
1016
1060
 
1017
- if (validationResult.result === 'reject') {
1018
- return { result: TopicValidatorResult.Reject };
1019
- } else if (validationResult.result === 'ignore' || exists) {
1020
- return { result: TopicValidatorResult.Ignore, obj: block };
1021
- } else if (!canAdd) {
1022
- this.peerManager.penalizePeer(source, PeerErrorSeverity.MidToleranceError);
1023
- this.logger.warn(`Penalizing peer for block proposal exceeding per-slot cap`, {
1024
- slot: block.slotNumber.toString(),
1025
- archive: block.archive.toString(),
1026
- source: source.toString(),
1061
+ // Check if this is a duplicate attestation (signer attested to a different proposal at the same slot)
1062
+ // count is the number of attestations by this signer for this slot
1063
+ if (count === 2) {
1064
+ const attester = attestation.getSender();
1065
+ if (attester) {
1066
+ this.logger.warn(`Detected duplicate attestation (equivocation) at slot ${slot}`, {
1067
+ slot: slot.toString(),
1068
+ archive: attestation.archive.toString(),
1069
+ source: peerId.toString(),
1070
+ attester: attester.toString(),
1027
1071
  });
1028
- return { result: TopicValidatorResult.Reject };
1029
- } else {
1030
- return { result: TopicValidatorResult.Accept, obj: block };
1072
+ this.duplicateAttestationCallback?.({ slot, attester });
1031
1073
  }
1032
- };
1074
+ }
1033
1075
 
1034
- const { result, obj: block } = await this.validateReceivedMessage<BlockProposal>(
1035
- validationFunc,
1076
+ // Attestation was added successfully - accept it so other nodes can also detect the equivocation
1077
+ return { result: TopicValidatorResult.Accept, obj: attestation };
1078
+ }
1079
+
1080
+ protected async processBlockFromPeer(payloadData: Buffer, msgId: string, source: PeerId): Promise<void> {
1081
+ const {
1082
+ result,
1083
+ obj: block,
1084
+ metadata: { isEquivocated } = {},
1085
+ } = await this.validateReceivedMessage<BlockProposal, { isEquivocated: boolean }>(
1086
+ () => this.validateAndStoreBlockProposal(source, BlockProposal.fromBuffer(payloadData)),
1036
1087
  msgId,
1037
1088
  source,
1038
1089
  TopicType.block_proposal,
1039
1090
  );
1040
1091
 
1041
- if (!result || !block) {
1092
+ // If not accepted or equivocated, return
1093
+ if (result !== TopicValidatorResult.Accept || !block || isEquivocated) {
1042
1094
  return;
1043
1095
  }
1044
1096
 
1045
1097
  await this.processValidBlockProposal(block, source);
1046
1098
  }
1047
1099
 
1048
- // REVIEW: callback pattern https://github.com/AztecProtocol/aztec-packages/issues/7963
1100
+ /** Validates a block proposal. Triggers a penalization to the peer that sent it if invalid. Adds to the mempool if valid. */
1101
+ @trackSpan('Libp2pService.validateAndStoreBlockProposal', (_peerId, block) => ({
1102
+ [Attributes.BLOCK_NUMBER]: block.blockNumber.toString(),
1103
+ [Attributes.SLOT_NUMBER]: block.slotNumber.toString(),
1104
+ }))
1105
+ protected async validateAndStoreBlockProposal(
1106
+ peerId: PeerId,
1107
+ block: BlockProposal,
1108
+ ): Promise<ReceivedMessageValidationResult<BlockProposal, { isEquivocated: boolean }>> {
1109
+ const validationResult = await this.blockProposalValidator.validate(block);
1110
+
1111
+ if (validationResult.result === 'reject') {
1112
+ this.logger.warn(`Penalizing peer ${peerId} for block proposal validation failure`);
1113
+ this.peerManager.penalizePeer(peerId, validationResult.severity);
1114
+ return { result: TopicValidatorResult.Reject };
1115
+ }
1116
+
1117
+ if (validationResult.result === 'ignore') {
1118
+ return { result: TopicValidatorResult.Ignore, obj: block };
1119
+ }
1120
+
1121
+ // Try to add the proposal: this handles existence check, cap check, and adding in one call
1122
+ const { added, alreadyExists, count } = await this.mempools.attestationPool.tryAddBlockProposal(block);
1123
+ const isEquivocated = count !== undefined && count > 1;
1124
+
1125
+ // Duplicate proposal received, no need to re-broadcast
1126
+ if (alreadyExists) {
1127
+ this.logger.debug(`Ignoring duplicate block proposal received`, {
1128
+ ...block.toBlockInfo(),
1129
+ indexWithinCheckpoint: block.indexWithinCheckpoint,
1130
+ proposer: block.getSender()?.toString(),
1131
+ source: peerId.toString(),
1132
+ });
1133
+ return { result: TopicValidatorResult.Ignore, obj: block, metadata: { isEquivocated } };
1134
+ }
1135
+
1136
+ // Too many blocks received for this slot and index, penalize peer and do not re-broadcast
1137
+ if (!added) {
1138
+ this.peerManager.penalizePeer(peerId, PeerErrorSeverity.HighToleranceError);
1139
+ this.logger.warn(`Penalizing peer for block proposal exceeding per-position cap`, {
1140
+ ...block.toBlockInfo(),
1141
+ indexWithinCheckpoint: block.indexWithinCheckpoint,
1142
+ count,
1143
+ proposer: block.getSender()?.toString(),
1144
+ source: peerId.toString(),
1145
+ });
1146
+ return { result: TopicValidatorResult.Reject, metadata: { isEquivocated } };
1147
+ }
1148
+
1149
+ // If this was a duplicate proposal, do not process it, but do invoke the duplicate callback,
1150
+ // and do re-broadcast it so other nodes in the network know to slash the proposer
1151
+ if (isEquivocated) {
1152
+ const proposer = block.getSender();
1153
+ this.logger.warn(`Detected duplicate block proposal (equivocation) at slot ${block.slotNumber}`, {
1154
+ ...block.toBlockInfo(),
1155
+ source: peerId.toString(),
1156
+ proposer: proposer?.toString(),
1157
+ });
1158
+ // Invoke the duplicate callback on the first duplicate spotted only
1159
+ if (proposer && count === 2) {
1160
+ this.duplicateProposalCallback?.({ slot: block.slotNumber, proposer, type: 'block' });
1161
+ }
1162
+ return { result: TopicValidatorResult.Accept, obj: block, metadata: { isEquivocated } };
1163
+ }
1164
+
1165
+ // Otherwise, we're good to go!
1166
+ return { result: TopicValidatorResult.Accept, obj: block };
1167
+ }
1168
+
1049
1169
  // REFACTOR(palla): This method should be moved to the p2p_client or to a separate component,
1050
1170
  // should not be here as it does not deal with p2p networking.
1051
1171
  @trackSpan('Libp2pService.processValidBlockProposal', async block => ({
@@ -1053,7 +1173,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1053
1173
  [Attributes.BLOCK_ARCHIVE]: block.archive.toString(),
1054
1174
  [Attributes.P2P_ID]: await block.p2pMessageLoggingIdentifier().then(i => i.toString()),
1055
1175
  }))
1056
- private async processValidBlockProposal(block: BlockProposal, sender: PeerId) {
1176
+ protected async processValidBlockProposal(block: BlockProposal, sender: PeerId) {
1057
1177
  const slot = block.slotNumber;
1058
1178
  this.logger.verbose(`Received block proposal for slot ${slot} from external peer ${sender.toString()}.`, {
1059
1179
  p2pMessageIdentifier: await block.p2pMessageLoggingIdentifier(),
@@ -1061,24 +1181,8 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1061
1181
  ...block.toBlockInfo(),
1062
1182
  });
1063
1183
 
1064
- // Attempt to add proposal
1065
- try {
1066
- await this.mempools.attestationPool.addBlockProposal(block);
1067
- } catch (err: unknown) {
1068
- // Drop proposals if we hit per-slot cap in the attestation pool; rethrow unknown errors
1069
- if (err instanceof ProposalSlotCapExceededError) {
1070
- this.logger.warn(`Dropping block proposal due to per-slot proposal cap`, {
1071
- slot: String(slot),
1072
- archive: block.archive.toString(),
1073
- error: (err as Error).message,
1074
- });
1075
- return;
1076
- }
1077
- throw err;
1078
- }
1079
-
1080
- // Mark the txs in this proposal as non-evictable
1081
- await this.mempools.txPool.markTxsAsNonEvictable(block.txHashes);
1184
+ // Mark the txs in this proposal as protected
1185
+ await this.mempools.txPool.protectTxs(block.txHashes, block.blockHeader);
1082
1186
 
1083
1187
  // Call the block received callback to validate the proposal.
1084
1188
  // Note: Validators do NOT attest to individual blocks, only to checkpoint proposals.
@@ -1092,67 +1196,145 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1092
1196
  * Handle a gossiped checkpoint proposal.
1093
1197
  * Validates and processes the checkpoint proposal, then triggers the callback for attestation.
1094
1198
  */
1095
- private async handleGossipedCheckpointProposal(payloadData: Buffer, msgId: string, source: PeerId): Promise<void> {
1096
- // TODO(palla/mbps): This pattern is repeated across multiple message handlers, consider abstracting it.
1097
- const validationFunc: () => Promise<ReceivedMessageValidationResult<CheckpointProposal>> = async () => {
1098
- const checkpoint = CheckpointProposal.fromBuffer(payloadData);
1099
- const validationResult = await this.validateCheckpointProposal(source, checkpoint);
1100
- const isValid = validationResult.result === 'accept';
1101
- const pool = this.mempools.attestationPool;
1102
-
1103
- const exists = isValid && (await pool.hasCheckpointProposal(checkpoint));
1104
- const canAdd = isValid && (await pool.canAddCheckpointProposal(checkpoint));
1105
-
1106
- this.logger.trace(`Validate propagated checkpoint proposal`, {
1107
- isValid,
1108
- exists,
1109
- canAdd,
1199
+ protected async handleGossipedCheckpointProposal(payloadData: Buffer, msgId: string, source: PeerId): Promise<void> {
1200
+ const {
1201
+ result,
1202
+ obj: checkpoint,
1203
+ metadata: { isEquivocated, processBlock } = {},
1204
+ } = await this.validateReceivedMessage<CheckpointProposal, { isEquivocated: boolean; processBlock: boolean }>(
1205
+ () => this.validateAndStoreCheckpointProposal(source, CheckpointProposal.fromBuffer(payloadData)),
1206
+ msgId,
1207
+ source,
1208
+ TopicType.checkpoint_proposal,
1209
+ );
1210
+
1211
+ // If the checkpoint contained a valid last block, we process it even if the checkpoint itself is to be rejected
1212
+ // TODO(palla/mbps): Is this ok? Should we be considering a block from a checkpoint that was equivocated?
1213
+ if (processBlock && checkpoint?.getBlockProposal()) {
1214
+ await this.processValidBlockProposal(checkpoint.getBlockProposal()!, source);
1215
+ }
1216
+
1217
+ if (result !== TopicValidatorResult.Accept || !checkpoint || isEquivocated) {
1218
+ return;
1219
+ }
1220
+
1221
+ await this.processValidCheckpointProposal(checkpoint.toCore(), source);
1222
+ }
1223
+
1224
+ /**
1225
+ * Validates a checkpoint proposal. Penalizes peer if validation fails. Adds the checkpoint and
1226
+ * its last block (if present) to the mempool if valid. Triggers equivocation detection on both.
1227
+ */
1228
+ @trackSpan('Libp2pService.validateAndStoreCheckpointProposal', (_peerId, checkpoint) => ({
1229
+ [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
1230
+ }))
1231
+ protected async validateAndStoreCheckpointProposal(
1232
+ peerId: PeerId,
1233
+ checkpoint: CheckpointProposal,
1234
+ ): Promise<ReceivedMessageValidationResult<CheckpointProposal, { isEquivocated: boolean; processBlock: boolean }>> {
1235
+ const validationResult = await this.checkpointProposalValidator.validate(checkpoint);
1236
+
1237
+ if (validationResult.result === 'reject') {
1238
+ this.logger.warn(`Penalizing peer ${peerId} for checkpoint proposal validation failure`);
1239
+ this.peerManager.penalizePeer(peerId, validationResult.severity);
1240
+ return { result: TopicValidatorResult.Reject };
1241
+ }
1242
+
1243
+ if (validationResult.result === 'ignore') {
1244
+ return { result: TopicValidatorResult.Ignore, obj: checkpoint };
1245
+ }
1246
+
1247
+ // Extract and try to add the block proposal first if present
1248
+ const blockProposal = checkpoint.getBlockProposal();
1249
+ let processBlock = false;
1250
+ if (blockProposal) {
1251
+ this.logger.debug(`Validating block proposal from propagated checkpoint`, {
1110
1252
  [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
1111
- [Attributes.P2P_ID]: source.toString(),
1253
+ [Attributes.P2P_ID]: peerId.toString(),
1112
1254
  });
1113
-
1114
- if (validationResult.result === 'reject') {
1115
- return { result: TopicValidatorResult.Reject };
1116
- } else if (validationResult.result === 'ignore' || exists) {
1117
- return { result: TopicValidatorResult.Ignore, obj: checkpoint };
1118
- } else if (!canAdd) {
1119
- this.peerManager.penalizePeer(source, PeerErrorSeverity.MidToleranceError);
1120
- this.logger.warn(`Penalizing peer for checkpoint proposal exceeding per-slot cap`, {
1121
- slot: checkpoint.slotNumber.toString(),
1122
- archive: checkpoint.archive.toString(),
1123
- source: source.toString(),
1255
+ const {
1256
+ result,
1257
+ obj,
1258
+ metadata: { isEquivocated } = {},
1259
+ } = await this.validateAndStoreBlockProposal(peerId, blockProposal);
1260
+ if (result === TopicValidatorResult.Reject || !obj || isEquivocated) {
1261
+ this.logger.debug(`Rejecting checkpoint due to invalid last block proposal`, {
1262
+ [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
1263
+ [Attributes.P2P_ID]: peerId.toString(),
1264
+ isEquivocated,
1265
+ result,
1124
1266
  });
1125
1267
  return { result: TopicValidatorResult.Reject };
1126
- } else {
1127
- return { result: TopicValidatorResult.Accept, obj: checkpoint };
1268
+ } else if (result === TopicValidatorResult.Accept && obj && !isEquivocated) {
1269
+ processBlock = true;
1128
1270
  }
1129
- };
1271
+ }
1130
1272
 
1131
- const { result, obj: checkpoint } = await this.validateReceivedMessage<CheckpointProposal>(
1132
- validationFunc,
1133
- msgId,
1134
- source,
1135
- TopicType.checkpoint_proposal,
1136
- );
1273
+ // Try to add the checkpoint proposal core: this handles existence check, cap check, and adding in one call
1274
+ const checkpointCore = checkpoint.toCore();
1275
+ const tryAddResult = await this.mempools.attestationPool.tryAddCheckpointProposal(checkpointCore);
1276
+ const { added, alreadyExists, count } = tryAddResult;
1277
+ const isEquivocated = count !== undefined && count > 1;
1278
+
1279
+ // Duplicate proposal received, do not re-broadcast
1280
+ if (alreadyExists) {
1281
+ this.logger.debug(`Ignoring duplicate checkpoint proposal received`, {
1282
+ ...checkpoint.toCheckpointInfo(),
1283
+ source: peerId.toString(),
1284
+ });
1285
+ return {
1286
+ result: TopicValidatorResult.Ignore,
1287
+ obj: checkpoint,
1288
+ metadata: { isEquivocated, processBlock },
1289
+ };
1290
+ }
1137
1291
 
1138
- if (result !== TopicValidatorResult.Accept || !checkpoint) {
1139
- return;
1292
+ // Too many checkpoint proposals received for this slot, penalize peer and do not re-broadcast
1293
+ // Note: We still return the checkpoint obj so the lastBlock can be processed if valid
1294
+ if (!added) {
1295
+ this.peerManager.penalizePeer(peerId, PeerErrorSeverity.HighToleranceError);
1296
+ this.logger.warn(`Penalizing peer for checkpoint proposal exceeding per-slot cap`, {
1297
+ ...checkpoint.toCheckpointInfo(),
1298
+ count,
1299
+ source: peerId.toString(),
1300
+ });
1301
+ return { result: TopicValidatorResult.Reject, obj: checkpoint, metadata: { isEquivocated, processBlock } };
1302
+ }
1303
+
1304
+ // If this was a duplicate proposal, do not process it, but do invoke the duplicate callback,
1305
+ // and do re-broadcast it so other nodes in the network know to slash the proposer
1306
+ if (isEquivocated) {
1307
+ const proposer = checkpoint.getSender();
1308
+ this.logger.warn(`Detected duplicate checkpoint proposal (equivocation) at slot ${checkpoint.slotNumber}`, {
1309
+ ...checkpoint.toCheckpointInfo(),
1310
+ source: peerId.toString(),
1311
+ proposer: proposer?.toString(),
1312
+ });
1313
+ // Invoke the duplicate callback on the first duplicate spotted only
1314
+ if (proposer && count === 2) {
1315
+ this.duplicateProposalCallback?.({ slot: checkpoint.slotNumber, proposer, type: 'checkpoint' });
1316
+ }
1317
+ return {
1318
+ result: TopicValidatorResult.Accept,
1319
+ obj: checkpoint,
1320
+ metadata: { isEquivocated, processBlock },
1321
+ };
1140
1322
  }
1141
1323
 
1142
- await this.processValidCheckpointProposal(checkpoint, source);
1324
+ // Otherwise, we're good to go!
1325
+ return { result: TopicValidatorResult.Accept, obj: checkpoint, metadata: { processBlock, isEquivocated } };
1143
1326
  }
1144
1327
 
1145
1328
  /**
1146
1329
  * Process a validated checkpoint proposal.
1147
- * Extracts and processes the last block proposal (if present) first, then processes the checkpoint.
1148
- * The block callback is invoked before the checkpoint callback.
1330
+ * Note: The proposal was already added to the pool by tryAddCheckpointProposal in handleGossipedCheckpointProposal.
1149
1331
  */
1150
1332
  @trackSpan('Libp2pService.processValidCheckpointProposal', async checkpoint => ({
1151
1333
  [Attributes.SLOT_NUMBER]: checkpoint.slotNumber,
1152
1334
  [Attributes.BLOCK_ARCHIVE]: checkpoint.archive.toString(),
1153
1335
  [Attributes.P2P_ID]: await checkpoint.p2pMessageLoggingIdentifier().then(i => i.toString()),
1154
1336
  }))
1155
- private async processValidCheckpointProposal(checkpoint: CheckpointProposal, sender: PeerId) {
1337
+ protected async processValidCheckpointProposal(checkpoint: CheckpointProposalCore, sender: PeerId) {
1156
1338
  const slot = checkpoint.slotNumber;
1157
1339
  this.logger.verbose(`Received checkpoint proposal for slot ${slot} from external peer ${sender.toString()}.`, {
1158
1340
  p2pMessageIdentifier: await checkpoint.p2pMessageLoggingIdentifier(),
@@ -1161,37 +1343,12 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1161
1343
  source: sender.toString(),
1162
1344
  });
1163
1345
 
1164
- // Extract block proposal before adding to pool (pool stores them separately)
1165
- const blockProposal = checkpoint.getBlockProposal();
1166
-
1167
- // Add proposal to the pool (this extracts and stores block proposal separately)
1168
- await this.mempools.attestationPool.addCheckpointProposal(checkpoint);
1169
-
1170
- // Mark txs as non-evictable if present (from the last block)
1171
- if (checkpoint.txHashes.length > 0) {
1172
- await this.mempools.txPool.markTxsAsNonEvictable(checkpoint.txHashes);
1173
- }
1174
-
1175
- // If there was a last block proposal, invoke the block callback first for validation.
1176
- // Note: The block proposal is already stored in the pool by addCheckpointProposal.
1177
- if (blockProposal) {
1178
- const isValid = await this.blockReceivedCallback(blockProposal, sender);
1179
- if (!isValid) {
1180
- this.logger.warn(`Block proposal from checkpoint failed validation`, {
1181
- slot: slot.toString(),
1182
- archive: checkpoint.archive.toString(),
1183
- blockNumber: blockProposal.blockNumber.toString(),
1184
- });
1185
- return;
1186
- }
1187
- }
1188
-
1189
1346
  // Call the checkpoint received callback with the core version (without lastBlock)
1190
1347
  // to validate and potentially generate attestations
1191
- const attestations = await this.checkpointReceivedCallback(checkpoint.toCore(), sender);
1348
+ const attestations = await this.checkpointReceivedCallback(checkpoint, sender);
1192
1349
  if (attestations && attestations.length > 0) {
1193
1350
  // If the callback returned attestations, add them to the pool and propagate them
1194
- await this.mempools.attestationPool.addCheckpointAttestations(attestations);
1351
+ await this.mempools.attestationPool.addOwnCheckpointAttestations(attestations);
1195
1352
  for (const attestation of attestations) {
1196
1353
  await this.propagate(attestation);
1197
1354
  }
@@ -1220,7 +1377,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1220
1377
  @trackSpan('Libp2pService.validateRequestedBlockTxs', request => ({
1221
1378
  [Attributes.BLOCK_ARCHIVE]: request.archiveRoot.toString(),
1222
1379
  }))
1223
- private async validateRequestedBlockTxs(
1380
+ protected async validateRequestedBlockTxs(
1224
1381
  request: BlockTxsRequest,
1225
1382
  response: BlockTxsResponse,
1226
1383
  peerId: PeerId,
@@ -1350,7 +1507,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1350
1507
  @trackSpan('Libp2pService.validateRequestedBlock', (requestedBlockNumber, _responseBlock) => ({
1351
1508
  [Attributes.BLOCK_NUMBER]: requestedBlockNumber.toString(),
1352
1509
  }))
1353
- private async validateRequestedBlock(
1510
+ protected async validateRequestedBlock(
1354
1511
  requestedBlockNumber: Fr,
1355
1512
  responseBlock: L2Block,
1356
1513
  peerId: PeerId,
@@ -1383,7 +1540,12 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1383
1540
  }
1384
1541
  }
1385
1542
 
1386
- private async validateRequestedTx(tx: Tx, peerId: PeerId, txValidator: TxValidator, requested?: Set<`0x${string}`>) {
1543
+ protected async validateRequestedTx(
1544
+ tx: Tx,
1545
+ peerId: PeerId,
1546
+ txValidator: TxValidator,
1547
+ requested?: Set<`0x${string}`>,
1548
+ ) {
1387
1549
  const penalize = (severity: PeerErrorSeverity) => this.peerManager.penalizePeer(peerId, severity);
1388
1550
  if (requested && !requested.has(tx.getTxHash().toString())) {
1389
1551
  penalize(PeerErrorSeverity.MidToleranceError);
@@ -1397,44 +1559,13 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1397
1559
  }
1398
1560
  }
1399
1561
 
1400
- private createRequestedTxValidator(): TxValidator {
1401
- return createTxReqRespValidator(this.proofVerifier, {
1562
+ protected createRequestedTxValidator(): TxValidator {
1563
+ return createTxValidatorForReqResponseReceivedTxs(this.proofVerifier, {
1402
1564
  l1ChainId: this.config.l1ChainId,
1403
1565
  rollupVersion: this.config.rollupVersion,
1404
1566
  });
1405
1567
  }
1406
1568
 
1407
- @trackSpan('Libp2pService.validatePropagatedTx', tx => ({
1408
- [Attributes.TX_HASH]: tx.getTxHash().toString(),
1409
- }))
1410
- private async validatePropagatedTx(tx: Tx, peerId: PeerId): Promise<boolean> {
1411
- const currentBlockNumber = await this.archiver.getBlockNumber();
1412
-
1413
- // We accept transactions if they are not expired by the next slot (checked based on the IncludeByTimestamp field)
1414
- const { ts: nextSlotTimestamp } = this.epochCache.getEpochAndSlotInNextL1Slot();
1415
- const messageValidators = await this.createMessageValidators(currentBlockNumber, nextSlotTimestamp);
1416
-
1417
- for (const validator of messageValidators) {
1418
- const outcome = await this.runValidations(tx, validator);
1419
-
1420
- if (outcome.allPassed) {
1421
- continue;
1422
- }
1423
- const { name } = outcome.failure;
1424
- let { severity } = outcome.failure;
1425
-
1426
- // Double spend validator has a special case handler
1427
- if (name === 'doubleSpendValidator') {
1428
- const txBlockNumber = BlockNumber(currentBlockNumber + 1); // tx is expected to be in the next block
1429
- severity = await this.handleDoubleSpendFailure(tx, txBlockNumber);
1430
- }
1431
-
1432
- this.peerManager.penalizePeer(peerId, severity);
1433
- return false;
1434
- }
1435
- return true;
1436
- }
1437
-
1438
1569
  private async getGasFees(blockNumber: BlockNumber): Promise<GasFees> {
1439
1570
  if (blockNumber === this.feesCache?.blockNumber) {
1440
1571
  return this.feesCache.gasFees;
@@ -1462,60 +1593,53 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1462
1593
  };
1463
1594
  }
1464
1595
 
1465
- public async validate(txs: Tx[]): Promise<void> {
1466
- const currentBlockNumber = await this.archiver.getBlockNumber();
1467
-
1468
- // We accept transactions if they are not expired by the next slot (checked based on the IncludeByTimestamp field)
1469
- const { ts: nextSlotTimestamp } = this.epochCache.getEpochAndSlotInNextL1Slot();
1470
- const messageValidators = await this.createMessageValidators(currentBlockNumber, nextSlotTimestamp);
1596
+ public async validateTxsReceivedInBlockProposal(txs: Tx[]): Promise<void> {
1597
+ const validator = createTxValidatorForBlockProposalReceivedTxs(
1598
+ this.proofVerifier,
1599
+ { l1ChainId: this.config.l1ChainId, rollupVersion: this.config.rollupVersion },
1600
+ this.logger.getBindings(),
1601
+ );
1471
1602
 
1472
- await Promise.all(
1603
+ const results = await Promise.all(
1473
1604
  txs.map(async tx => {
1474
- for (const validator of messageValidators) {
1475
- const outcome = await this.runValidations(tx, validator);
1476
- if (!outcome.allPassed) {
1477
- throw new Error('Invalid tx detected', { cause: { outcome } });
1478
- }
1479
- }
1605
+ const result = await validator.validateTx(tx);
1606
+ return result.result !== 'invalid';
1480
1607
  }),
1481
1608
  );
1609
+ if (results.some(value => value === false)) {
1610
+ throw new Error('Invalid tx detected');
1611
+ }
1482
1612
  }
1483
1613
 
1484
- /**
1485
- * Create message validators for the given block number and timestamp.
1486
- *
1487
- * Each validator is a pair of a validator and a severity.
1488
- * If a validator fails, the peer is penalized with the severity of the validator.
1489
- *
1490
- * @param currentBlockNumber - The current synced block number.
1491
- * @param nextSlotTimestamp - The timestamp of the next slot (used to validate txs are not expired).
1492
- * @returns The message validators.
1493
- */
1494
- private async createMessageValidators(
1614
+ /** Creates the first stage (fast) validators for gossiped transactions. */
1615
+ protected async createFirstStageMessageValidators(
1495
1616
  currentBlockNumber: BlockNumber,
1496
1617
  nextSlotTimestamp: UInt64,
1497
- ): Promise<Record<string, MessageValidator>[]> {
1618
+ ): Promise<Record<string, TransactionValidator>> {
1498
1619
  const gasFees = await this.getGasFees(currentBlockNumber);
1499
1620
  const allowedInSetup = this.config.txPublicSetupAllowList ?? (await getDefaultAllowedSetupFunctions());
1621
+ const blockNumber = BlockNumber(currentBlockNumber + 1);
1500
1622
 
1501
- const blockNumberInWhichTheTxIsConsideredToBeIncluded = BlockNumber(currentBlockNumber + 1);
1502
-
1503
- return createTxMessageValidators(
1623
+ return createFirstStageTxValidationsForGossipedTransactions(
1504
1624
  nextSlotTimestamp,
1505
- blockNumberInWhichTheTxIsConsideredToBeIncluded,
1625
+ blockNumber,
1506
1626
  this.worldStateSynchronizer,
1507
1627
  gasFees,
1508
1628
  this.config.l1ChainId,
1509
1629
  this.config.rollupVersion,
1510
1630
  protocolContractsHash,
1511
1631
  this.archiver,
1512
- this.proofVerifier,
1513
1632
  !this.config.disableTransactions,
1514
1633
  allowedInSetup,
1515
1634
  this.logger.getBindings(),
1516
1635
  );
1517
1636
  }
1518
1637
 
1638
+ /** Creates the second stage (expensive proof verification) validators for gossiped transactions. */
1639
+ protected createSecondStageMessageValidators(): Record<string, TransactionValidator> {
1640
+ return createSecondStageTxValidationsForGossipedTransactions(this.proofVerifier, this.logger.getBindings());
1641
+ }
1642
+
1519
1643
  /**
1520
1644
  * Run validations on a tx.
1521
1645
  * @param tx - The tx to validate.
@@ -1524,7 +1648,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1524
1648
  */
1525
1649
  private async runValidations(
1526
1650
  tx: Tx,
1527
- messageValidators: Record<string, MessageValidator>,
1651
+ messageValidators: Record<string, TransactionValidator>,
1528
1652
  ): Promise<ValidationOutcome> {
1529
1653
  const validationPromises = Object.entries(messageValidators).map(async ([name, { validator, severity }]) => {
1530
1654
  const { result } = await validator.validateTx(tx);
@@ -1605,50 +1729,7 @@ export class LibP2PService<T extends P2PClientType = P2PClientType.Full> extends
1605
1729
  const result = await this.checkpointAttestationValidator.validate(attestation);
1606
1730
 
1607
1731
  if (result.result === 'reject') {
1608
- this.logger.debug(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
1609
- this.peerManager.penalizePeer(peerId, result.severity);
1610
- }
1611
-
1612
- return result;
1613
- }
1614
-
1615
- /**
1616
- * Validate a block proposal.
1617
- *
1618
- * @param block - The block proposal to validate.
1619
- * @returns True if the block proposal is valid, false otherwise.
1620
- */
1621
- @trackSpan('Libp2pService.validateBlockProposal', (_peerId, block) => ({
1622
- [Attributes.SLOT_NUMBER]: block.slotNumber.toString(),
1623
- }))
1624
- public async validateBlockProposal(peerId: PeerId, block: BlockProposal): Promise<P2PValidationResult> {
1625
- const result = await this.blockProposalValidator.validate(block);
1626
-
1627
- if (result.result === 'reject') {
1628
- this.logger.debug(`Penalizing peer ${peerId} for block proposal validation failure`);
1629
- this.peerManager.penalizePeer(peerId, result.severity);
1630
- }
1631
-
1632
- return result;
1633
- }
1634
-
1635
- /**
1636
- * Validate a checkpoint proposal.
1637
- *
1638
- * @param checkpoint - The checkpoint proposal to validate.
1639
- * @returns True if the checkpoint proposal is valid, false otherwise.
1640
- */
1641
- @trackSpan('Libp2pService.validateCheckpointProposal', (_peerId, checkpoint) => ({
1642
- [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
1643
- }))
1644
- public async validateCheckpointProposal(
1645
- peerId: PeerId,
1646
- checkpoint: CheckpointProposal,
1647
- ): Promise<P2PValidationResult> {
1648
- const result = await this.checkpointProposalValidator.validate(checkpoint);
1649
-
1650
- if (result.result === 'reject') {
1651
- this.logger.debug(`Penalizing peer ${peerId} for checkpoint proposal validation failure`);
1732
+ this.logger.warn(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
1652
1733
  this.peerManager.penalizePeer(peerId, result.severity);
1653
1734
  }
1654
1735