@aztec/p2p 0.0.1-commit.6d63667d → 0.0.1-commit.72dcdcda8

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (316) hide show
  1. package/dest/client/factory.d.ts +10 -10
  2. package/dest/client/factory.d.ts.map +1 -1
  3. package/dest/client/factory.js +39 -15
  4. package/dest/client/interface.d.ts +46 -33
  5. package/dest/client/interface.d.ts.map +1 -1
  6. package/dest/client/p2p_client.d.ts +39 -51
  7. package/dest/client/p2p_client.d.ts.map +1 -1
  8. package/dest/client/p2p_client.js +145 -200
  9. package/dest/client/test/tx_proposal_collector/proposal_tx_collector_worker.js +7 -8
  10. package/dest/config.d.ts +24 -8
  11. package/dest/config.d.ts.map +1 -1
  12. package/dest/config.js +16 -6
  13. package/dest/errors/tx-pool.error.d.ts +8 -0
  14. package/dest/errors/tx-pool.error.d.ts.map +1 -0
  15. package/dest/errors/tx-pool.error.js +9 -0
  16. package/dest/index.d.ts +2 -1
  17. package/dest/index.d.ts.map +1 -1
  18. package/dest/index.js +1 -0
  19. package/dest/mem_pools/attestation_pool/attestation_pool.d.ts +104 -88
  20. package/dest/mem_pools/attestation_pool/attestation_pool.d.ts.map +1 -1
  21. package/dest/mem_pools/attestation_pool/attestation_pool.js +441 -3
  22. package/dest/mem_pools/attestation_pool/attestation_pool_test_suite.d.ts +2 -2
  23. package/dest/mem_pools/attestation_pool/attestation_pool_test_suite.d.ts.map +1 -1
  24. package/dest/mem_pools/attestation_pool/attestation_pool_test_suite.js +353 -87
  25. package/dest/mem_pools/attestation_pool/index.d.ts +2 -3
  26. package/dest/mem_pools/attestation_pool/index.d.ts.map +1 -1
  27. package/dest/mem_pools/attestation_pool/index.js +1 -2
  28. package/dest/mem_pools/attestation_pool/mocks.d.ts +2 -2
  29. package/dest/mem_pools/attestation_pool/mocks.d.ts.map +1 -1
  30. package/dest/mem_pools/attestation_pool/mocks.js +2 -2
  31. package/dest/mem_pools/index.d.ts +3 -2
  32. package/dest/mem_pools/index.d.ts.map +1 -1
  33. package/dest/mem_pools/index.js +1 -1
  34. package/dest/mem_pools/interface.d.ts +5 -5
  35. package/dest/mem_pools/interface.d.ts.map +1 -1
  36. package/dest/mem_pools/tx_pool/eviction/invalid_txs_after_mining_rule.js +3 -3
  37. package/dest/mem_pools/tx_pool_v2/deleted_pool.d.ts +104 -0
  38. package/dest/mem_pools/tx_pool_v2/deleted_pool.d.ts.map +1 -0
  39. package/dest/mem_pools/tx_pool_v2/deleted_pool.js +251 -0
  40. package/dest/mem_pools/tx_pool_v2/eviction/eviction_manager.d.ts +3 -3
  41. package/dest/mem_pools/tx_pool_v2/eviction/eviction_manager.d.ts.map +1 -1
  42. package/dest/mem_pools/tx_pool_v2/eviction/eviction_manager.js +18 -9
  43. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.d.ts +1 -1
  44. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.d.ts.map +1 -1
  45. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.js +5 -2
  46. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.d.ts +3 -3
  47. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.d.ts.map +1 -1
  48. package/dest/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.js +12 -4
  49. package/dest/mem_pools/tx_pool_v2/eviction/index.d.ts +2 -2
  50. package/dest/mem_pools/tx_pool_v2/eviction/index.d.ts.map +1 -1
  51. package/dest/mem_pools/tx_pool_v2/eviction/index.js +1 -1
  52. package/dest/mem_pools/tx_pool_v2/eviction/interfaces.d.ts +48 -5
  53. package/dest/mem_pools/tx_pool_v2/eviction/interfaces.d.ts.map +1 -1
  54. package/dest/mem_pools/tx_pool_v2/eviction/interfaces.js +8 -0
  55. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_mining_rule.js +7 -5
  56. package/dest/mem_pools/tx_pool_v2/eviction/invalid_txs_after_reorg_rule.js +7 -5
  57. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.d.ts +2 -2
  58. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.d.ts.map +1 -1
  59. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.js +14 -6
  60. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.d.ts +4 -4
  61. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.d.ts.map +1 -1
  62. package/dest/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.js +14 -4
  63. package/dest/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.d.ts +3 -3
  64. package/dest/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.d.ts.map +1 -1
  65. package/dest/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.js +2 -2
  66. package/dest/mem_pools/tx_pool_v2/index.d.ts +3 -2
  67. package/dest/mem_pools/tx_pool_v2/index.d.ts.map +1 -1
  68. package/dest/mem_pools/tx_pool_v2/index.js +2 -1
  69. package/dest/mem_pools/tx_pool_v2/instrumentation.d.ts +15 -0
  70. package/dest/mem_pools/tx_pool_v2/instrumentation.d.ts.map +1 -0
  71. package/dest/mem_pools/tx_pool_v2/instrumentation.js +43 -0
  72. package/dest/mem_pools/tx_pool_v2/interfaces.d.ts +22 -8
  73. package/dest/mem_pools/tx_pool_v2/interfaces.d.ts.map +1 -1
  74. package/dest/mem_pools/tx_pool_v2/interfaces.js +4 -1
  75. package/dest/mem_pools/tx_pool_v2/tx_metadata.d.ts +56 -8
  76. package/dest/mem_pools/tx_pool_v2/tx_metadata.d.ts.map +1 -1
  77. package/dest/mem_pools/tx_pool_v2/tx_metadata.js +108 -10
  78. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.d.ts +12 -3
  79. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.d.ts.map +1 -1
  80. package/dest/mem_pools/tx_pool_v2/tx_pool_indices.js +36 -14
  81. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.d.ts +9 -4
  82. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.d.ts.map +1 -1
  83. package/dest/mem_pools/tx_pool_v2/tx_pool_v2.js +11 -6
  84. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.d.ts +13 -5
  85. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.d.ts.map +1 -1
  86. package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.js +342 -185
  87. package/dest/msg_validators/attestation_validator/fisherman_attestation_validator.d.ts +3 -3
  88. package/dest/msg_validators/attestation_validator/fisherman_attestation_validator.d.ts.map +1 -1
  89. package/dest/msg_validators/tx_validator/aggregate_tx_validator.d.ts +4 -4
  90. package/dest/msg_validators/tx_validator/aggregate_tx_validator.d.ts.map +1 -1
  91. package/dest/msg_validators/tx_validator/aggregate_tx_validator.js +3 -3
  92. package/dest/msg_validators/tx_validator/block_header_validator.d.ts +16 -3
  93. package/dest/msg_validators/tx_validator/block_header_validator.d.ts.map +1 -1
  94. package/dest/msg_validators/tx_validator/block_header_validator.js +1 -1
  95. package/dest/msg_validators/tx_validator/double_spend_validator.d.ts +13 -3
  96. package/dest/msg_validators/tx_validator/double_spend_validator.d.ts.map +1 -1
  97. package/dest/msg_validators/tx_validator/double_spend_validator.js +4 -4
  98. package/dest/msg_validators/tx_validator/factory.d.ts +114 -6
  99. package/dest/msg_validators/tx_validator/factory.d.ts.map +1 -1
  100. package/dest/msg_validators/tx_validator/factory.js +219 -58
  101. package/dest/msg_validators/tx_validator/gas_validator.d.ts +58 -3
  102. package/dest/msg_validators/tx_validator/gas_validator.d.ts.map +1 -1
  103. package/dest/msg_validators/tx_validator/gas_validator.js +73 -36
  104. package/dest/msg_validators/tx_validator/index.d.ts +2 -1
  105. package/dest/msg_validators/tx_validator/index.d.ts.map +1 -1
  106. package/dest/msg_validators/tx_validator/index.js +1 -0
  107. package/dest/msg_validators/tx_validator/nullifier_cache.d.ts +14 -0
  108. package/dest/msg_validators/tx_validator/nullifier_cache.d.ts.map +1 -0
  109. package/dest/msg_validators/tx_validator/nullifier_cache.js +24 -0
  110. package/dest/msg_validators/tx_validator/timestamp_validator.d.ts +20 -4
  111. package/dest/msg_validators/tx_validator/timestamp_validator.d.ts.map +1 -1
  112. package/dest/msg_validators/tx_validator/timestamp_validator.js +6 -6
  113. package/dest/services/dummy_service.d.ts +13 -5
  114. package/dest/services/dummy_service.d.ts.map +1 -1
  115. package/dest/services/dummy_service.js +10 -4
  116. package/dest/services/encoding.d.ts +3 -3
  117. package/dest/services/encoding.d.ts.map +1 -1
  118. package/dest/services/encoding.js +11 -10
  119. package/dest/services/gossipsub/index.d.ts +3 -0
  120. package/dest/services/gossipsub/index.d.ts.map +1 -0
  121. package/dest/services/gossipsub/index.js +2 -0
  122. package/dest/services/gossipsub/scoring.d.ts +21 -3
  123. package/dest/services/gossipsub/scoring.d.ts.map +1 -1
  124. package/dest/services/gossipsub/scoring.js +24 -7
  125. package/dest/services/gossipsub/topic_score_params.d.ts +173 -0
  126. package/dest/services/gossipsub/topic_score_params.d.ts.map +1 -0
  127. package/dest/services/gossipsub/topic_score_params.js +346 -0
  128. package/dest/services/libp2p/libp2p_service.d.ts +95 -43
  129. package/dest/services/libp2p/libp2p_service.d.ts.map +1 -1
  130. package/dest/services/libp2p/libp2p_service.js +418 -331
  131. package/dest/services/peer-manager/peer_scoring.d.ts +1 -1
  132. package/dest/services/peer-manager/peer_scoring.d.ts.map +1 -1
  133. package/dest/services/peer-manager/peer_scoring.js +25 -2
  134. package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.d.ts +4 -3
  135. package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.d.ts.map +1 -1
  136. package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.js +19 -46
  137. package/dest/services/reqresp/batch-tx-requester/interface.d.ts +2 -6
  138. package/dest/services/reqresp/batch-tx-requester/interface.d.ts.map +1 -1
  139. package/dest/services/reqresp/batch-tx-requester/missing_txs.d.ts +10 -13
  140. package/dest/services/reqresp/batch-tx-requester/missing_txs.d.ts.map +1 -1
  141. package/dest/services/reqresp/batch-tx-requester/missing_txs.js +25 -46
  142. package/dest/services/reqresp/batch-tx-requester/peer_collection.d.ts +17 -11
  143. package/dest/services/reqresp/batch-tx-requester/peer_collection.d.ts.map +1 -1
  144. package/dest/services/reqresp/batch-tx-requester/peer_collection.js +49 -15
  145. package/dest/services/reqresp/batch-tx-requester/tx_validator.js +2 -2
  146. package/dest/services/reqresp/interface.d.ts +10 -1
  147. package/dest/services/reqresp/interface.d.ts.map +1 -1
  148. package/dest/services/reqresp/interface.js +15 -1
  149. package/dest/services/reqresp/protocols/block_txs/block_txs_handler.d.ts +4 -3
  150. package/dest/services/reqresp/protocols/block_txs/block_txs_handler.d.ts.map +1 -1
  151. package/dest/services/reqresp/protocols/block_txs/block_txs_reqresp.d.ts +7 -1
  152. package/dest/services/reqresp/protocols/block_txs/block_txs_reqresp.d.ts.map +1 -1
  153. package/dest/services/reqresp/protocols/block_txs/block_txs_reqresp.js +15 -0
  154. package/dest/services/reqresp/protocols/tx.d.ts +7 -1
  155. package/dest/services/reqresp/protocols/tx.d.ts.map +1 -1
  156. package/dest/services/reqresp/protocols/tx.js +20 -0
  157. package/dest/services/reqresp/reqresp.d.ts +1 -1
  158. package/dest/services/reqresp/reqresp.d.ts.map +1 -1
  159. package/dest/services/reqresp/reqresp.js +13 -5
  160. package/dest/services/service.d.ts +39 -3
  161. package/dest/services/service.d.ts.map +1 -1
  162. package/dest/services/tx_collection/config.d.ts +19 -1
  163. package/dest/services/tx_collection/config.d.ts.map +1 -1
  164. package/dest/services/tx_collection/config.js +46 -0
  165. package/dest/services/tx_collection/fast_tx_collection.d.ts +3 -1
  166. package/dest/services/tx_collection/fast_tx_collection.d.ts.map +1 -1
  167. package/dest/services/tx_collection/fast_tx_collection.js +56 -36
  168. package/dest/services/tx_collection/file_store_tx_collection.d.ts +53 -0
  169. package/dest/services/tx_collection/file_store_tx_collection.d.ts.map +1 -0
  170. package/dest/services/tx_collection/file_store_tx_collection.js +167 -0
  171. package/dest/services/tx_collection/file_store_tx_source.d.ts +37 -0
  172. package/dest/services/tx_collection/file_store_tx_source.d.ts.map +1 -0
  173. package/dest/services/tx_collection/file_store_tx_source.js +90 -0
  174. package/dest/services/tx_collection/index.d.ts +2 -1
  175. package/dest/services/tx_collection/index.d.ts.map +1 -1
  176. package/dest/services/tx_collection/index.js +1 -0
  177. package/dest/services/tx_collection/instrumentation.d.ts +1 -1
  178. package/dest/services/tx_collection/instrumentation.d.ts.map +1 -1
  179. package/dest/services/tx_collection/instrumentation.js +2 -1
  180. package/dest/services/tx_collection/missing_txs_tracker.d.ts +32 -0
  181. package/dest/services/tx_collection/missing_txs_tracker.d.ts.map +1 -0
  182. package/dest/services/tx_collection/missing_txs_tracker.js +27 -0
  183. package/dest/services/tx_collection/proposal_tx_collector.d.ts +7 -6
  184. package/dest/services/tx_collection/proposal_tx_collector.d.ts.map +1 -1
  185. package/dest/services/tx_collection/proposal_tx_collector.js +5 -4
  186. package/dest/services/tx_collection/slow_tx_collection.d.ts +7 -3
  187. package/dest/services/tx_collection/slow_tx_collection.d.ts.map +1 -1
  188. package/dest/services/tx_collection/slow_tx_collection.js +60 -26
  189. package/dest/services/tx_collection/tx_collection.d.ts +23 -10
  190. package/dest/services/tx_collection/tx_collection.d.ts.map +1 -1
  191. package/dest/services/tx_collection/tx_collection.js +75 -3
  192. package/dest/services/tx_collection/tx_collection_sink.d.ts +18 -8
  193. package/dest/services/tx_collection/tx_collection_sink.d.ts.map +1 -1
  194. package/dest/services/tx_collection/tx_collection_sink.js +26 -29
  195. package/dest/services/tx_collection/tx_source.d.ts +8 -3
  196. package/dest/services/tx_collection/tx_source.d.ts.map +1 -1
  197. package/dest/services/tx_collection/tx_source.js +19 -2
  198. package/dest/services/tx_file_store/config.d.ts +1 -3
  199. package/dest/services/tx_file_store/config.d.ts.map +1 -1
  200. package/dest/services/tx_file_store/config.js +0 -4
  201. package/dest/services/tx_file_store/tx_file_store.d.ts +4 -3
  202. package/dest/services/tx_file_store/tx_file_store.d.ts.map +1 -1
  203. package/dest/services/tx_file_store/tx_file_store.js +9 -6
  204. package/dest/services/tx_provider.d.ts +4 -4
  205. package/dest/services/tx_provider.d.ts.map +1 -1
  206. package/dest/services/tx_provider.js +9 -8
  207. package/dest/test-helpers/make-test-p2p-clients.d.ts +7 -8
  208. package/dest/test-helpers/make-test-p2p-clients.d.ts.map +1 -1
  209. package/dest/test-helpers/make-test-p2p-clients.js +1 -2
  210. package/dest/test-helpers/mock-pubsub.d.ts +30 -4
  211. package/dest/test-helpers/mock-pubsub.d.ts.map +1 -1
  212. package/dest/test-helpers/mock-pubsub.js +105 -4
  213. package/dest/test-helpers/reqresp-nodes.d.ts +2 -3
  214. package/dest/test-helpers/reqresp-nodes.d.ts.map +1 -1
  215. package/dest/test-helpers/reqresp-nodes.js +4 -3
  216. package/dest/test-helpers/testbench-utils.d.ts +43 -38
  217. package/dest/test-helpers/testbench-utils.d.ts.map +1 -1
  218. package/dest/test-helpers/testbench-utils.js +128 -59
  219. package/dest/testbench/p2p_client_testbench_worker.d.ts +2 -2
  220. package/dest/testbench/p2p_client_testbench_worker.d.ts.map +1 -1
  221. package/dest/testbench/p2p_client_testbench_worker.js +15 -15
  222. package/dest/util.d.ts +2 -2
  223. package/dest/util.d.ts.map +1 -1
  224. package/package.json +14 -14
  225. package/src/client/factory.ts +74 -27
  226. package/src/client/interface.ts +56 -34
  227. package/src/client/p2p_client.ts +180 -247
  228. package/src/client/test/tx_proposal_collector/proposal_tx_collector_worker.ts +20 -11
  229. package/src/config.ts +35 -11
  230. package/src/errors/tx-pool.error.ts +12 -0
  231. package/src/index.ts +1 -0
  232. package/src/mem_pools/attestation_pool/attestation_pool.ts +496 -91
  233. package/src/mem_pools/attestation_pool/attestation_pool_test_suite.ts +442 -102
  234. package/src/mem_pools/attestation_pool/index.ts +9 -2
  235. package/src/mem_pools/attestation_pool/mocks.ts +2 -1
  236. package/src/mem_pools/index.ts +4 -1
  237. package/src/mem_pools/interface.ts +4 -4
  238. package/src/mem_pools/tx_pool/README.md +1 -1
  239. package/src/mem_pools/tx_pool/eviction/invalid_txs_after_mining_rule.ts +3 -3
  240. package/src/mem_pools/tx_pool_v2/README.md +76 -10
  241. package/src/mem_pools/tx_pool_v2/deleted_pool.ts +321 -0
  242. package/src/mem_pools/tx_pool_v2/eviction/eviction_manager.ts +21 -8
  243. package/src/mem_pools/tx_pool_v2/eviction/fee_payer_balance_eviction_rule.ts +5 -2
  244. package/src/mem_pools/tx_pool_v2/eviction/fee_payer_balance_pre_add_rule.ts +18 -4
  245. package/src/mem_pools/tx_pool_v2/eviction/index.ts +4 -0
  246. package/src/mem_pools/tx_pool_v2/eviction/interfaces.ts +49 -4
  247. package/src/mem_pools/tx_pool_v2/eviction/invalid_txs_after_mining_rule.ts +5 -5
  248. package/src/mem_pools/tx_pool_v2/eviction/invalid_txs_after_reorg_rule.ts +5 -5
  249. package/src/mem_pools/tx_pool_v2/eviction/low_priority_eviction_rule.ts +14 -9
  250. package/src/mem_pools/tx_pool_v2/eviction/low_priority_pre_add_rule.ts +24 -6
  251. package/src/mem_pools/tx_pool_v2/eviction/nullifier_conflict_rule.ts +3 -3
  252. package/src/mem_pools/tx_pool_v2/index.ts +2 -1
  253. package/src/mem_pools/tx_pool_v2/instrumentation.ts +69 -0
  254. package/src/mem_pools/tx_pool_v2/interfaces.ts +23 -8
  255. package/src/mem_pools/tx_pool_v2/tx_metadata.ts +153 -17
  256. package/src/mem_pools/tx_pool_v2/tx_pool_indices.ts +43 -16
  257. package/src/mem_pools/tx_pool_v2/tx_pool_v2.ts +18 -7
  258. package/src/mem_pools/tx_pool_v2/tx_pool_v2_impl.ts +383 -182
  259. package/src/msg_validators/attestation_validator/fisherman_attestation_validator.ts +2 -2
  260. package/src/msg_validators/tx_validator/README.md +115 -0
  261. package/src/msg_validators/tx_validator/aggregate_tx_validator.ts +5 -5
  262. package/src/msg_validators/tx_validator/block_header_validator.ts +15 -3
  263. package/src/msg_validators/tx_validator/double_spend_validator.ts +11 -6
  264. package/src/msg_validators/tx_validator/factory.ts +353 -77
  265. package/src/msg_validators/tx_validator/gas_validator.ts +90 -27
  266. package/src/msg_validators/tx_validator/index.ts +1 -0
  267. package/src/msg_validators/tx_validator/nullifier_cache.ts +30 -0
  268. package/src/msg_validators/tx_validator/timestamp_validator.ts +23 -18
  269. package/src/services/dummy_service.ts +18 -6
  270. package/src/services/encoding.ts +9 -9
  271. package/src/services/gossipsub/README.md +641 -0
  272. package/src/services/gossipsub/index.ts +2 -0
  273. package/src/services/gossipsub/scoring.ts +29 -5
  274. package/src/services/gossipsub/topic_score_params.ts +487 -0
  275. package/src/services/libp2p/libp2p_service.ts +436 -355
  276. package/src/services/peer-manager/peer_scoring.ts +25 -0
  277. package/src/services/reqresp/batch-tx-requester/batch_tx_requester.ts +20 -48
  278. package/src/services/reqresp/batch-tx-requester/interface.ts +1 -5
  279. package/src/services/reqresp/batch-tx-requester/missing_txs.ts +23 -71
  280. package/src/services/reqresp/batch-tx-requester/peer_collection.ts +63 -24
  281. package/src/services/reqresp/batch-tx-requester/tx_validator.ts +2 -2
  282. package/src/services/reqresp/interface.ts +26 -1
  283. package/src/services/reqresp/protocols/block_txs/block_txs_handler.ts +4 -3
  284. package/src/services/reqresp/protocols/block_txs/block_txs_reqresp.ts +17 -0
  285. package/src/services/reqresp/protocols/tx.ts +22 -0
  286. package/src/services/reqresp/reqresp.ts +16 -4
  287. package/src/services/service.ts +51 -2
  288. package/src/services/tx_collection/config.ts +68 -0
  289. package/src/services/tx_collection/fast_tx_collection.ts +65 -32
  290. package/src/services/tx_collection/file_store_tx_collection.ts +202 -0
  291. package/src/services/tx_collection/file_store_tx_source.ts +117 -0
  292. package/src/services/tx_collection/index.ts +1 -0
  293. package/src/services/tx_collection/instrumentation.ts +7 -1
  294. package/src/services/tx_collection/missing_txs_tracker.ts +52 -0
  295. package/src/services/tx_collection/proposal_tx_collector.ts +8 -7
  296. package/src/services/tx_collection/slow_tx_collection.ts +66 -33
  297. package/src/services/tx_collection/tx_collection.ts +113 -16
  298. package/src/services/tx_collection/tx_collection_sink.ts +30 -34
  299. package/src/services/tx_collection/tx_source.ts +22 -3
  300. package/src/services/tx_file_store/config.ts +0 -6
  301. package/src/services/tx_file_store/tx_file_store.ts +10 -8
  302. package/src/services/tx_provider.ts +10 -9
  303. package/src/test-helpers/make-test-p2p-clients.ts +3 -5
  304. package/src/test-helpers/mock-pubsub.ts +146 -9
  305. package/src/test-helpers/reqresp-nodes.ts +4 -6
  306. package/src/test-helpers/testbench-utils.ts +127 -71
  307. package/src/testbench/p2p_client_testbench_worker.ts +24 -21
  308. package/src/util.ts +7 -1
  309. package/dest/mem_pools/attestation_pool/kv_attestation_pool.d.ts +0 -40
  310. package/dest/mem_pools/attestation_pool/kv_attestation_pool.d.ts.map +0 -1
  311. package/dest/mem_pools/attestation_pool/kv_attestation_pool.js +0 -218
  312. package/dest/mem_pools/attestation_pool/memory_attestation_pool.d.ts +0 -31
  313. package/dest/mem_pools/attestation_pool/memory_attestation_pool.d.ts.map +0 -1
  314. package/dest/mem_pools/attestation_pool/memory_attestation_pool.js +0 -180
  315. package/src/mem_pools/attestation_pool/kv_attestation_pool.ts +0 -320
  316. package/src/mem_pools/attestation_pool/memory_attestation_pool.ts +0 -264
@@ -372,19 +372,18 @@ function _apply_decs_2203_r(targetClass, memberDecs, classDecs, parentClass) {
372
372
  }
373
373
  var _dec, _dec1, _dec2, _dec3, _dec4, _dec5, _dec6, _dec7, _dec8, _initProto;
374
374
  import { BlockNumber } from '@aztec/foundation/branded-types';
375
- import { randomInt } from '@aztec/foundation/crypto/random';
376
375
  import { createLibp2pComponentLogger, createLogger } from '@aztec/foundation/log';
377
376
  import { RunningPromise } from '@aztec/foundation/running-promise';
378
377
  import { Timer } from '@aztec/foundation/timer';
379
378
  import { protocolContractsHash } from '@aztec/protocol-contracts';
380
379
  import { GasFees } from '@aztec/stdlib/gas';
381
- import { BlockProposal, CheckpointAttestation, CheckpointProposal, P2PClientType, P2PMessage, PeerErrorSeverity, TopicType, createTopicString, getTopicsForClientAndConfig, metricsTopicStrToLabels } from '@aztec/stdlib/p2p';
380
+ import { BlockProposal, CheckpointAttestation, CheckpointProposal, P2PMessage, PeerErrorSeverity, TopicType, createTopicString, getTopicsForConfig, metricsTopicStrToLabels } from '@aztec/stdlib/p2p';
382
381
  import { MerkleTreeId } from '@aztec/stdlib/trees';
383
382
  import { Tx } from '@aztec/stdlib/tx';
384
383
  import { compressComponentVersions } from '@aztec/stdlib/versioning';
385
384
  import { Attributes, OtelMetricsAdapter, SpanStatusCode, WithTracer, trackSpan } from '@aztec/telemetry-client';
386
385
  import { gossipsub } from '@chainsafe/libp2p-gossipsub';
387
- import { createPeerScoreParams, createTopicScoreParams } from '@chainsafe/libp2p-gossipsub/score';
386
+ import { createPeerScoreParams } from '@chainsafe/libp2p-gossipsub/score';
388
387
  import { SignaturePolicy } from '@chainsafe/libp2p-gossipsub/types';
389
388
  import { noise } from '@chainsafe/libp2p-noise';
390
389
  import { yamux } from '@chainsafe/libp2p-yamux';
@@ -395,52 +394,51 @@ import { mplex } from '@libp2p/mplex';
395
394
  import { tcp } from '@libp2p/tcp';
396
395
  import { ENR } from '@nethermindeth/enr';
397
396
  import { createLibp2p } from 'libp2p';
398
- import { ProposalSlotCapExceededError } from '../../errors/attestation-pool.error.js';
399
397
  import { BlockProposalValidator, CheckpointAttestationValidator, CheckpointProposalValidator, DoubleSpendTxValidator, FishermanAttestationValidator, getDefaultAllowedSetupFunctions } from '../../msg_validators/index.js';
400
398
  import { MessageSeenValidator } from '../../msg_validators/msg_seen_validator/msg_seen_validator.js';
401
- import { createTxMessageValidators, createTxReqRespValidator } from '../../msg_validators/tx_validator/factory.js';
399
+ import { createFirstStageTxValidationsForGossipedTransactions, createSecondStageTxValidationsForGossipedTransactions, createTxValidatorForBlockProposalReceivedTxs, createTxValidatorForReqResponseReceivedTxs } from '../../msg_validators/tx_validator/factory.js';
402
400
  import { GossipSubEvent } from '../../types/index.js';
403
401
  import { convertToMultiaddr } from '../../util.js';
404
402
  import { getVersions } from '../../versioning.js';
405
403
  import { AztecDatastore } from '../data_store.js';
406
404
  import { DiscV5Service } from '../discv5/discV5_service.js';
407
405
  import { SnappyTransform, fastMsgIdFn, getMsgIdFn, msgIdToStrFn } from '../encoding.js';
408
- import { gossipScoreThresholds } from '../gossipsub/scoring.js';
406
+ import { APP_SPECIFIC_WEIGHT, gossipScoreThresholds } from '../gossipsub/scoring.js';
407
+ import { createAllTopicScoreParams } from '../gossipsub/topic_score_params.js';
409
408
  import { PeerManager } from '../peer-manager/peer_manager.js';
410
409
  import { PeerScoring } from '../peer-manager/peer_scoring.js';
411
- import { DEFAULT_SUB_PROTOCOL_VALIDATORS, ReqRespSubProtocol, ValidationError } from '../reqresp/index.js';
412
- import { pingHandler, reqGoodbyeHandler, reqRespBlockHandler, reqRespBlockTxsHandler, reqRespStatusHandler, reqRespTxHandler } from '../reqresp/index.js';
410
+ import { DEFAULT_SUB_PROTOCOL_VALIDATORS, ReqRespSubProtocol, ValidationError, pingHandler, reqGoodbyeHandler, reqRespBlockHandler, reqRespBlockTxsHandler, reqRespStatusHandler, reqRespTxHandler } from '../reqresp/index.js';
413
411
  import { ReqResp } from '../reqresp/reqresp.js';
414
412
  import { P2PInstrumentation } from './instrumentation.js';
415
- _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
413
+ _dec = trackSpan('Libp2pService.validateAndStoreCheckpointAttestation', (_peerId, attestation)=>({
414
+ [Attributes.SLOT_NUMBER]: attestation.payload.header.slotNumber.toString()
415
+ })), _dec1 = trackSpan('Libp2pService.validateAndStoreBlockProposal', (_peerId, block)=>({
416
+ [Attributes.BLOCK_NUMBER]: block.blockNumber.toString(),
417
+ [Attributes.SLOT_NUMBER]: block.slotNumber.toString()
418
+ })), _dec2 = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
416
419
  [Attributes.SLOT_NUMBER]: block.slotNumber,
417
420
  [Attributes.BLOCK_ARCHIVE]: block.archive.toString(),
418
421
  [Attributes.P2P_ID]: await block.p2pMessageLoggingIdentifier().then((i)=>i.toString())
419
- })), _dec1 = trackSpan('Libp2pService.processValidCheckpointProposal', async (checkpoint)=>({
422
+ })), _dec3 = trackSpan('Libp2pService.validateAndStoreCheckpointProposal', (_peerId, checkpoint)=>({
423
+ [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString()
424
+ })), _dec4 = trackSpan('Libp2pService.processValidCheckpointProposal', async (checkpoint)=>({
420
425
  [Attributes.SLOT_NUMBER]: checkpoint.slotNumber,
421
426
  [Attributes.BLOCK_ARCHIVE]: checkpoint.archive.toString(),
422
427
  [Attributes.P2P_ID]: await checkpoint.p2pMessageLoggingIdentifier().then((i)=>i.toString())
423
- })), _dec2 = trackSpan('Libp2pService.validateRequestedBlockTxs', (request)=>({
428
+ })), _dec5 = trackSpan('Libp2pService.validateRequestedBlockTxs', (request)=>({
424
429
  [Attributes.BLOCK_ARCHIVE]: request.archiveRoot.toString()
425
- })), _dec3 = trackSpan('Libp2pService.validateRequestedTx', (requestedTxHash, _responseTx)=>({
430
+ })), _dec6 = trackSpan('Libp2pService.validateRequestedTx', (requestedTxHash, _responseTx)=>({
426
431
  [Attributes.TX_HASH]: requestedTxHash.toString()
427
- })), _dec4 = trackSpan('Libp2pService.validateRequestedBlock', (requestedBlockNumber, _responseBlock)=>({
432
+ })), _dec7 = trackSpan('Libp2pService.validateRequestedBlock', (requestedBlockNumber, _responseBlock)=>({
428
433
  [Attributes.BLOCK_NUMBER]: requestedBlockNumber.toString()
429
- })), _dec5 = trackSpan('Libp2pService.validatePropagatedTx', (tx)=>({
430
- [Attributes.TX_HASH]: tx.getTxHash().toString()
431
- })), _dec6 = trackSpan('Libp2pService.validateCheckpointAttestation', async (_, attestation)=>({
434
+ })), _dec8 = trackSpan('Libp2pService.validateCheckpointAttestation', async (_, attestation)=>({
432
435
  [Attributes.SLOT_NUMBER]: attestation.payload.header.slotNumber,
433
436
  [Attributes.BLOCK_ARCHIVE]: attestation.archive.toString(),
434
437
  [Attributes.P2P_ID]: await attestation.p2pMessageLoggingIdentifier().then((i)=>i.toString())
435
- })), _dec7 = trackSpan('Libp2pService.validateBlockProposal', (_peerId, block)=>({
436
- [Attributes.SLOT_NUMBER]: block.slotNumber.toString()
437
- })), _dec8 = trackSpan('Libp2pService.validateCheckpointProposal', (_peerId, checkpoint)=>({
438
- [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString()
439
438
  }));
440
439
  /**
441
440
  * Lib P2P implementation of the P2PService interface.
442
441
  */ export class LibP2PService extends WithTracer {
443
- clientType;
444
442
  config;
445
443
  node;
446
444
  peerDiscoveryService;
@@ -456,47 +454,47 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
456
454
  [
457
455
  _dec,
458
456
  2,
459
- "processValidBlockProposal"
457
+ "validateAndStoreCheckpointAttestation"
460
458
  ],
461
459
  [
462
460
  _dec1,
463
461
  2,
464
- "processValidCheckpointProposal"
462
+ "validateAndStoreBlockProposal"
465
463
  ],
466
464
  [
467
465
  _dec2,
468
466
  2,
469
- "validateRequestedBlockTxs"
467
+ "processValidBlockProposal"
470
468
  ],
471
469
  [
472
470
  _dec3,
473
471
  2,
474
- "validateRequestedTxs"
472
+ "validateAndStoreCheckpointProposal"
475
473
  ],
476
474
  [
477
475
  _dec4,
478
476
  2,
479
- "validateRequestedBlock"
477
+ "processValidCheckpointProposal"
480
478
  ],
481
479
  [
482
480
  _dec5,
483
481
  2,
484
- "validatePropagatedTx"
482
+ "validateRequestedBlockTxs"
485
483
  ],
486
484
  [
487
485
  _dec6,
488
486
  2,
489
- "validateCheckpointAttestation"
487
+ "validateRequestedTxs"
490
488
  ],
491
489
  [
492
490
  _dec7,
493
491
  2,
494
- "validateBlockProposal"
492
+ "validateRequestedBlock"
495
493
  ],
496
494
  [
497
495
  _dec8,
498
496
  2,
499
- "validateCheckpointProposal"
497
+ "validateCheckpointAttestation"
500
498
  ]
501
499
  ], []));
502
500
  }
@@ -509,6 +507,8 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
509
507
  protocolVersion;
510
508
  topicStrings;
511
509
  feesCache;
510
+ /** Callback invoked when a duplicate proposal is detected (triggers slashing). */ duplicateProposalCallback;
511
+ /** Callback invoked when a duplicate attestation is detected (triggers slashing). */ duplicateAttestationCallback;
512
512
  /**
513
513
  * Callback for when a block is received from a peer.
514
514
  * @param block - The block received from the peer.
@@ -523,8 +523,8 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
523
523
  instrumentation;
524
524
  telemetry;
525
525
  logger;
526
- constructor(clientType, config, node, peerDiscoveryService, reqresp, peerManager, mempools, archiver, epochCache, proofVerifier, worldStateSynchronizer, telemetry, logger = createLogger('p2p:libp2p_service')){
527
- super(telemetry, 'LibP2PService'), this.clientType = clientType, this.config = config, this.node = node, this.peerDiscoveryService = peerDiscoveryService, this.reqresp = reqresp, this.peerManager = peerManager, this.mempools = mempools, this.archiver = archiver, this.epochCache = epochCache, this.proofVerifier = proofVerifier, this.worldStateSynchronizer = worldStateSynchronizer, this.msgIdSeenValidators = (_initProto(this), {}), this.protocolVersion = '', this.topicStrings = {};
526
+ constructor(config, node, peerDiscoveryService, reqresp, peerManager, mempools, archiver, epochCache, proofVerifier, worldStateSynchronizer, telemetry, logger = createLogger('p2p:libp2p_service')){
527
+ super(telemetry, 'LibP2PService'), this.config = config, this.node = node, this.peerDiscoveryService = peerDiscoveryService, this.reqresp = reqresp, this.peerManager = peerManager, this.mempools = mempools, this.archiver = archiver, this.epochCache = epochCache, this.proofVerifier = proofVerifier, this.worldStateSynchronizer = worldStateSynchronizer, this.msgIdSeenValidators = (_initProto(this), {}), this.protocolVersion = '', this.topicStrings = {};
528
528
  this.telemetry = telemetry;
529
529
  // Create child logger with fisherman prefix if in fisherman mode
530
530
  this.logger = config.fishermanMode ? logger.createChild('[FISHERMAN]') : logger;
@@ -567,7 +567,7 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
567
567
  * @param config - The configuration to use when creating the service.
568
568
  * @param txPool - The transaction pool to be accessed by the service.
569
569
  * @returns The new service.
570
- */ static async new(clientType, config, peerId, deps) {
570
+ */ static async new(config, peerId, deps) {
571
571
  const { worldStateSynchronizer, epochCache, l2BlockSource, mempools, proofVerifier, peerStore, telemetry, logger, packageVersion } = deps;
572
572
  const { p2pPort, maxPeerCount, listenAddress } = config;
573
573
  const bindAddrTcp = convertToMultiaddr(listenAddress, p2pPort, 'tcp');
@@ -587,10 +587,6 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
587
587
  }
588
588
  const versions = getVersions(config);
589
589
  const protocolVersion = compressComponentVersions(versions);
590
- const txTopic = createTopicString(TopicType.tx, protocolVersion);
591
- const blockProposalTopic = createTopicString(TopicType.block_proposal, protocolVersion);
592
- const checkpointProposalTopic = createTopicString(TopicType.checkpoint_proposal, protocolVersion);
593
- const checkpointAttestationTopic = createTopicString(TopicType.checkpoint_attestation, protocolVersion);
594
590
  const preferredPeersEnrs = config.preferredPeers.map((enr)=>ENR.decodeTxt(enr));
595
591
  const directPeers = (await Promise.all(preferredPeersEnrs.map(async (enr)=>{
596
592
  const peerId = await enr.peerId();
@@ -608,6 +604,15 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
608
604
  const announceTcpMultiaddr = config.p2pIp ? [
609
605
  convertToMultiaddr(config.p2pIp, p2pPort, 'tcp')
610
606
  ] : [];
607
+ // Create dynamic topic score params based on network configuration
608
+ const l1Constants = epochCache.getL1Constants();
609
+ const topicScoreParams = createAllTopicScoreParams(protocolVersion, {
610
+ slotDurationMs: l1Constants.slotDuration * 1000,
611
+ heartbeatIntervalMs: config.gossipsubInterval,
612
+ targetCommitteeSize: l1Constants.targetCommitteeSize,
613
+ blockDurationMs: config.blockDurationMs,
614
+ expectedBlockProposalsPerSlot: config.expectedBlockProposalsPerSlot
615
+ });
611
616
  const node = await createLibp2p({
612
617
  start: false,
613
618
  peerId,
@@ -708,28 +713,7 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
708
713
  scoreParams: createPeerScoreParams({
709
714
  // IPColocation factor can be disabled for local testing - default to -5
710
715
  IPColocationFactorWeight: config.debugDisableColocationPenalty ? 0 : -5.0,
711
- topics: {
712
- [txTopic]: createTopicScoreParams({
713
- topicWeight: 1,
714
- invalidMessageDeliveriesWeight: -20,
715
- invalidMessageDeliveriesDecay: 0.5
716
- }),
717
- [blockProposalTopic]: createTopicScoreParams({
718
- topicWeight: 1,
719
- invalidMessageDeliveriesWeight: -20,
720
- invalidMessageDeliveriesDecay: 0.5
721
- }),
722
- [checkpointProposalTopic]: createTopicScoreParams({
723
- topicWeight: 1,
724
- invalidMessageDeliveriesWeight: -20,
725
- invalidMessageDeliveriesDecay: 0.5
726
- }),
727
- [checkpointAttestationTopic]: createTopicScoreParams({
728
- topicWeight: 1,
729
- invalidMessageDeliveriesWeight: -20,
730
- invalidMessageDeliveriesDecay: 0.5
731
- })
732
- }
716
+ topics: topicScoreParams
733
717
  })
734
718
  }),
735
719
  components: (components)=>({
@@ -741,10 +725,14 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
741
725
  const peerScoring = new PeerScoring(config, telemetry);
742
726
  const reqresp = new ReqResp(config, node, peerScoring, createLogger(`${logger.module}:reqresp`));
743
727
  const peerManager = new PeerManager(node, peerDiscoveryService, config, telemetry, createLogger(`${logger.module}:peer_manager`), peerScoring, reqresp, worldStateSynchronizer, protocolVersion, epochCache);
744
- // Update gossipsub score params
745
- node.services.pubsub.score.params.appSpecificWeight = 10;
728
+ // Configure application-specific scoring for gossipsub.
729
+ // The weight scales app score to align with gossipsub thresholds:
730
+ // - Disconnect (-50) × 10 = -500 = gossipThreshold (stops receiving gossip)
731
+ // - Ban (-100) × 10 = -1000 = publishThreshold (cannot publish)
732
+ // Note: positive topic scores can offset penalties, so alignment is best-effort.
733
+ node.services.pubsub.score.params.appSpecificWeight = APP_SPECIFIC_WEIGHT;
746
734
  node.services.pubsub.score.params.appSpecificScore = (peerId)=>peerManager.shouldDisableP2PGossip(peerId) ? -Infinity : peerManager.getPeerScore(peerId);
747
- return new LibP2PService(clientType, config, node, peerDiscoveryService, reqresp, peerManager, mempools, l2BlockSource, epochCache, proofVerifier, worldStateSynchronizer, telemetry, logger);
735
+ return new LibP2PService(config, node, peerDiscoveryService, reqresp, peerManager, mempools, l2BlockSource, epochCache, proofVerifier, worldStateSynchronizer, telemetry, logger);
748
736
  }
749
737
  /**
750
738
  * Starts the LibP2P service.
@@ -789,7 +777,7 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
789
777
  await this.reqresp.start(requestResponseHandlers, reqrespSubProtocolValidators);
790
778
  await this.node.start();
791
779
  // Subscribe to standard GossipSub topics by default
792
- for (const topic of getTopicsForClientAndConfig(this.clientType, this.config.disableTransactions)){
780
+ for (const topic of getTopicsForConfig(this.config.disableTransactions)){
793
781
  this.subscribeToTopic(this.topicStrings[topic]);
794
782
  }
795
783
  // add GossipSub listener
@@ -837,6 +825,9 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
837
825
  getPeers(includePending) {
838
826
  return this.peerManager.getPeers(includePending);
839
827
  }
828
+ getGossipMeshPeerCount(topicType) {
829
+ return this.node.services.pubsub.getMeshPeers(this.topicStrings[topicType]).length;
830
+ }
840
831
  handleGossipSubEvent(e) {
841
832
  this.logger.trace(`Received PUBSUB message.`);
842
833
  const safeJob = async ()=>{
@@ -872,6 +863,19 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
872
863
  this.checkpointReceivedCallback = callback;
873
864
  }
874
865
  /**
866
+ * Registers a callback to be invoked when a duplicate proposal is detected.
867
+ * This callback is triggered on the first duplicate (when count goes from 1 to 2).
868
+ */ registerDuplicateProposalCallback(callback) {
869
+ this.duplicateProposalCallback = callback;
870
+ }
871
+ /**
872
+ * Registers a callback to be invoked when a duplicate attestation is detected.
873
+ * A validator signing attestations for different proposals at the same slot.
874
+ * This callback is triggered on the first duplicate (when count goes from 1 to 2).
875
+ */ registerDuplicateAttestationCallback(callback) {
876
+ this.duplicateAttestationCallback = callback;
877
+ }
878
+ /**
875
879
  * Subscribes to a topic.
876
880
  * @param topic - The topic to subscribe to.
877
881
  */ subscribeToTopic(topic) {
@@ -982,9 +986,7 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
982
986
  if (msg.topic === this.topicStrings[TopicType.tx]) {
983
987
  await this.handleGossipedTx(p2pMessage.payload, msgId, source);
984
988
  } else if (msg.topic === this.topicStrings[TopicType.checkpoint_attestation]) {
985
- if (this.clientType === P2PClientType.Full) {
986
- await this.processCheckpointAttestationFromPeer(p2pMessage.payload, msgId, source);
987
- }
989
+ await this.processCheckpointAttestationFromPeer(p2pMessage.payload, msgId, source);
988
990
  } else if (msg.topic === this.topicStrings[TopicType.block_proposal]) {
989
991
  await this.processBlockFromPeer(p2pMessage.payload, msgId, source);
990
992
  } else if (msg.topic === this.topicStrings[TopicType.checkpoint_proposal]) {
@@ -1052,26 +1054,71 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
1052
1054
  async handleGossipedTx(payloadData, msgId, source) {
1053
1055
  const validationFunc = async ()=>{
1054
1056
  const tx = Tx.fromBuffer(payloadData);
1055
- const isValid = await this.validatePropagatedTx(tx, source);
1056
- const exists = isValid && await this.mempools.txPool.hasTx(tx.getTxHash());
1057
+ const currentBlockNumber = await this.archiver.getBlockNumber();
1058
+ const { ts: nextSlotTimestamp } = this.epochCache.getEpochAndSlotInNextL1Slot();
1059
+ // Stage 1: fast validators (metadata, data, timestamps, double-spend, gas, phases, block header)
1060
+ const firstStageValidators = await this.createFirstStageMessageValidators(currentBlockNumber, nextSlotTimestamp);
1061
+ const firstStageOutcome = await this.runValidations(tx, firstStageValidators);
1062
+ if (!firstStageOutcome.allPassed) {
1063
+ const { name } = firstStageOutcome.failure;
1064
+ let { severity } = firstStageOutcome.failure;
1065
+ // Double spend validator has a special case handler. We perform more detailed examination
1066
+ // as to how recently the nullifier was entered into the tree and if the transaction should
1067
+ // have 'known' the nullifier existed. This determines the severity of the penalty applied to the peer.
1068
+ if (name === 'doubleSpendValidator') {
1069
+ const txBlockNumber = BlockNumber(currentBlockNumber + 1);
1070
+ severity = await this.handleDoubleSpendFailure(tx, txBlockNumber);
1071
+ }
1072
+ this.peerManager.penalizePeer(source, severity);
1073
+ return {
1074
+ result: TopicValidatorResult.Reject
1075
+ };
1076
+ }
1077
+ // Pool pre-check: see if the pool would accept this tx before doing expensive proof verification
1078
+ const canAdd = await this.mempools.txPool.canAddPendingTx(tx);
1079
+ if (canAdd === 'ignored') {
1080
+ return {
1081
+ result: TopicValidatorResult.Ignore,
1082
+ obj: tx
1083
+ };
1084
+ }
1085
+ // Stage 2: expensive proof verification
1086
+ const secondStageValidators = this.createSecondStageMessageValidators();
1087
+ const secondStageOutcome = await this.runValidations(tx, secondStageValidators);
1088
+ if (!secondStageOutcome.allPassed) {
1089
+ const { severity } = secondStageOutcome.failure;
1090
+ this.peerManager.penalizePeer(source, severity);
1091
+ return {
1092
+ result: TopicValidatorResult.Reject
1093
+ };
1094
+ }
1095
+ // Pool add: persist the tx
1096
+ const txHash = tx.getTxHash();
1097
+ const addResult = await this.mempools.txPool.addPendingTxs([
1098
+ tx
1099
+ ], {
1100
+ source: 'gossip'
1101
+ });
1102
+ const wasAccepted = addResult.accepted.some((h)=>h.equals(txHash));
1103
+ const wasIgnored = addResult.ignored.some((h)=>h.equals(txHash));
1057
1104
  this.logger.trace(`Validate propagated tx`, {
1058
- isValid,
1059
- exists,
1105
+ wasAccepted,
1106
+ wasIgnored,
1060
1107
  [Attributes.P2P_ID]: source.toString()
1061
1108
  });
1062
- if (!isValid) {
1109
+ if (wasAccepted) {
1063
1110
  return {
1064
- result: TopicValidatorResult.Reject
1111
+ result: TopicValidatorResult.Accept,
1112
+ obj: tx
1065
1113
  };
1066
- } else if (exists) {
1114
+ } else if (wasIgnored) {
1067
1115
  return {
1068
1116
  result: TopicValidatorResult.Ignore,
1069
1117
  obj: tx
1070
1118
  };
1071
1119
  } else {
1072
1120
  return {
1073
- result: TopicValidatorResult.Accept,
1074
- obj: tx
1121
+ result: TopicValidatorResult.Reject
1075
1122
  };
1076
1123
  }
1077
1124
  };
@@ -1079,133 +1126,190 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
1079
1126
  if (result !== TopicValidatorResult.Accept || !tx) {
1080
1127
  return;
1081
1128
  }
1129
+ // Tx was accepted into pool and will be propagated - just log and record metrics
1082
1130
  const txHash = tx.getTxHash();
1083
1131
  const txHashString = txHash.toString();
1084
1132
  this.logger.verbose(`Received tx ${txHashString} from external peer ${source.toString()} via gossip`, {
1085
1133
  source: source.toString(),
1086
1134
  txHash: txHashString
1087
1135
  });
1088
- if (this.config.dropTransactions && randomInt(1000) < this.config.dropTransactionsProbability * 1000) {
1089
- this.logger.warn(`Intentionally dropping tx ${txHashString} (probability rule)`);
1090
- return;
1091
- }
1092
1136
  this.instrumentation.incrementTxReceived(1);
1093
- await this.mempools.txPool.addTxs([
1094
- tx
1095
- ]);
1096
1137
  }
1097
1138
  /**
1098
1139
  * Process a checkpoint attestation from a peer.
1099
1140
  * Validates the attestation and adds it to the pool.
1100
1141
  */ async processCheckpointAttestationFromPeer(payloadData, msgId, source) {
1101
- const validationFunc = async ()=>{
1102
- const attestation = CheckpointAttestation.fromBuffer(payloadData);
1103
- const pool = this.mempools.attestationPool;
1104
- const validationResult = await this.validateCheckpointAttestation(source, attestation);
1105
- const isValid = validationResult.result === 'accept';
1106
- const exists = isValid && await pool.hasCheckpointAttestation(attestation);
1107
- let canAdd = true;
1108
- if (isValid && !exists) {
1109
- const slot = attestation.payload.header.slotNumber;
1110
- const { committee } = await this.epochCache.getCommittee(slot);
1111
- const committeeSize = committee?.length ?? 0;
1112
- canAdd = await pool.canAddCheckpointAttestation(attestation, committeeSize);
1113
- }
1114
- this.logger.trace(`Validate propagated checkpoint attestation`, {
1115
- isValid,
1116
- exists,
1117
- canAdd,
1118
- [Attributes.SLOT_NUMBER]: attestation.payload.header.slotNumber.toString(),
1119
- [Attributes.P2P_ID]: source.toString()
1120
- });
1121
- if (validationResult.result === 'reject') {
1122
- return {
1123
- result: TopicValidatorResult.Reject
1124
- };
1125
- } else if (validationResult.result === 'ignore' || exists) {
1126
- return {
1127
- result: TopicValidatorResult.Ignore,
1128
- obj: attestation
1129
- };
1130
- } else if (!canAdd) {
1131
- this.logger.warn(`Dropping checkpoint attestation due to per-(slot, proposalId) attestation cap`, {
1132
- slot: attestation.payload.header.slotNumber.toString(),
1133
- archive: attestation.archive.toString(),
1134
- source: source.toString()
1135
- });
1136
- return {
1137
- result: TopicValidatorResult.Ignore,
1138
- obj: attestation
1139
- };
1140
- } else {
1141
- return {
1142
- result: TopicValidatorResult.Accept,
1143
- obj: attestation
1144
- };
1145
- }
1146
- };
1147
- const { result, obj: attestation } = await this.validateReceivedMessage(validationFunc, msgId, source, TopicType.checkpoint_attestation);
1142
+ const { result, obj: attestation } = await this.validateReceivedMessage(()=>this.validateAndStoreCheckpointAttestation(source, CheckpointAttestation.fromBuffer(payloadData)), msgId, source, TopicType.checkpoint_attestation);
1148
1143
  if (result !== TopicValidatorResult.Accept || !attestation) {
1149
1144
  return;
1150
1145
  }
1151
- this.logger.debug(`Received checkpoint attestation for slot ${attestation.slotNumber} from external peer ${source.toString()}`, {
1146
+ this.logger.verbose(`Received valid checkpoint attestation for slot ${attestation.slotNumber} from external peer ${source.toString()}`, {
1152
1147
  p2pMessageIdentifier: await attestation.p2pMessageLoggingIdentifier(),
1153
1148
  slot: attestation.slotNumber,
1154
1149
  archive: attestation.archive.toString(),
1155
1150
  source: source.toString()
1156
1151
  });
1157
- await this.mempools.attestationPool.addCheckpointAttestations([
1158
- attestation
1159
- ]);
1160
1152
  }
1161
- async processBlockFromPeer(payloadData, msgId, source) {
1162
- const validationFunc = async ()=>{
1163
- const block = BlockProposal.fromBuffer(payloadData);
1164
- const validationResult = await this.validateBlockProposal(source, block);
1165
- const isValid = validationResult.result === 'accept';
1166
- const pool = this.mempools.attestationPool;
1167
- const exists = isValid && await pool.hasBlockProposal(block);
1168
- const canAdd = isValid && await pool.canAddProposal(block);
1169
- this.logger.trace(`Validate propagated block proposal`, {
1170
- isValid,
1171
- exists,
1172
- canAdd,
1173
- [Attributes.SLOT_NUMBER]: block.slotNumber.toString(),
1174
- [Attributes.P2P_ID]: source.toString()
1153
+ /** Validates a checkpoint attestation and adds it to the pool. Penalizes the peer if validation fails. */ async validateAndStoreCheckpointAttestation(peerId, attestation) {
1154
+ const validationResult = await this.checkpointAttestationValidator.validate(attestation);
1155
+ if (validationResult.result === 'reject') {
1156
+ this.logger.warn(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
1157
+ this.peerManager.penalizePeer(peerId, validationResult.severity);
1158
+ return {
1159
+ result: TopicValidatorResult.Reject
1160
+ };
1161
+ }
1162
+ if (validationResult.result === 'ignore') {
1163
+ return {
1164
+ result: TopicValidatorResult.Ignore,
1165
+ obj: attestation
1166
+ };
1167
+ }
1168
+ // Try to add the attestation: this handles existence check, cap check, and adding in one call
1169
+ // count is the number of attestations by this signer for this slot (for duplicate detection)
1170
+ const slot = attestation.payload.header.slotNumber;
1171
+ const { added, alreadyExists, count } = await this.mempools.attestationPool.tryAddCheckpointAttestation(attestation);
1172
+ this.logger.trace(`Validate propagated checkpoint attestation`, {
1173
+ added,
1174
+ alreadyExists,
1175
+ count,
1176
+ [Attributes.SLOT_NUMBER]: slot.toString(),
1177
+ [Attributes.P2P_ID]: peerId.toString()
1178
+ });
1179
+ // Exact same attestation received, no need to re-broadcast
1180
+ if (alreadyExists) {
1181
+ return {
1182
+ result: TopicValidatorResult.Ignore,
1183
+ obj: attestation
1184
+ };
1185
+ }
1186
+ // Could not add (cap reached for signer), no need to re-broadcast
1187
+ if (!added) {
1188
+ this.logger.warn(`Dropping checkpoint attestation due to cap`, {
1189
+ slot: slot.toString(),
1190
+ archive: attestation.archive.toString(),
1191
+ source: peerId.toString(),
1192
+ attester: attestation.getSender()?.toString(),
1193
+ count
1175
1194
  });
1176
- if (validationResult.result === 'reject') {
1177
- return {
1178
- result: TopicValidatorResult.Reject
1179
- };
1180
- } else if (validationResult.result === 'ignore' || exists) {
1181
- return {
1182
- result: TopicValidatorResult.Ignore,
1183
- obj: block
1184
- };
1185
- } else if (!canAdd) {
1186
- this.peerManager.penalizePeer(source, PeerErrorSeverity.MidToleranceError);
1187
- this.logger.warn(`Penalizing peer for block proposal exceeding per-slot cap`, {
1188
- slot: block.slotNumber.toString(),
1189
- archive: block.archive.toString(),
1190
- source: source.toString()
1195
+ return {
1196
+ result: TopicValidatorResult.Ignore,
1197
+ obj: attestation
1198
+ };
1199
+ }
1200
+ // Check if this is a duplicate attestation (signer attested to a different proposal at the same slot)
1201
+ // count is the number of attestations by this signer for this slot
1202
+ if (count === 2) {
1203
+ const attester = attestation.getSender();
1204
+ if (attester) {
1205
+ this.logger.warn(`Detected duplicate attestation (equivocation) at slot ${slot}`, {
1206
+ slot: slot.toString(),
1207
+ archive: attestation.archive.toString(),
1208
+ source: peerId.toString(),
1209
+ attester: attester.toString()
1210
+ });
1211
+ this.duplicateAttestationCallback?.({
1212
+ slot,
1213
+ attester
1191
1214
  });
1192
- return {
1193
- result: TopicValidatorResult.Reject
1194
- };
1195
- } else {
1196
- return {
1197
- result: TopicValidatorResult.Accept,
1198
- obj: block
1199
- };
1200
1215
  }
1216
+ }
1217
+ // Attestation was added successfully - accept it so other nodes can also detect the equivocation
1218
+ return {
1219
+ result: TopicValidatorResult.Accept,
1220
+ obj: attestation
1201
1221
  };
1202
- const { result, obj: block } = await this.validateReceivedMessage(validationFunc, msgId, source, TopicType.block_proposal);
1203
- if (!result || !block) {
1222
+ }
1223
+ async processBlockFromPeer(payloadData, msgId, source) {
1224
+ const { result, obj: block, metadata: { isEquivocated } = {} } = await this.validateReceivedMessage(()=>this.validateAndStoreBlockProposal(source, BlockProposal.fromBuffer(payloadData)), msgId, source, TopicType.block_proposal);
1225
+ // If not accepted or equivocated, return
1226
+ if (result !== TopicValidatorResult.Accept || !block || isEquivocated) {
1204
1227
  return;
1205
1228
  }
1206
1229
  await this.processValidBlockProposal(block, source);
1207
1230
  }
1208
- // REVIEW: callback pattern https://github.com/AztecProtocol/aztec-packages/issues/7963
1231
+ /** Validates a block proposal. Triggers a penalization to the peer that sent it if invalid. Adds to the mempool if valid. */ async validateAndStoreBlockProposal(peerId, block) {
1232
+ const validationResult = await this.blockProposalValidator.validate(block);
1233
+ if (validationResult.result === 'reject') {
1234
+ this.logger.warn(`Penalizing peer ${peerId} for block proposal validation failure`);
1235
+ this.peerManager.penalizePeer(peerId, validationResult.severity);
1236
+ return {
1237
+ result: TopicValidatorResult.Reject
1238
+ };
1239
+ }
1240
+ if (validationResult.result === 'ignore') {
1241
+ return {
1242
+ result: TopicValidatorResult.Ignore,
1243
+ obj: block
1244
+ };
1245
+ }
1246
+ // Try to add the proposal: this handles existence check, cap check, and adding in one call
1247
+ const { added, alreadyExists, count } = await this.mempools.attestationPool.tryAddBlockProposal(block);
1248
+ const isEquivocated = count !== undefined && count > 1;
1249
+ // Duplicate proposal received, no need to re-broadcast
1250
+ if (alreadyExists) {
1251
+ this.logger.debug(`Ignoring duplicate block proposal received`, {
1252
+ ...block.toBlockInfo(),
1253
+ indexWithinCheckpoint: block.indexWithinCheckpoint,
1254
+ proposer: block.getSender()?.toString(),
1255
+ source: peerId.toString()
1256
+ });
1257
+ return {
1258
+ result: TopicValidatorResult.Ignore,
1259
+ obj: block,
1260
+ metadata: {
1261
+ isEquivocated
1262
+ }
1263
+ };
1264
+ }
1265
+ // Too many blocks received for this slot and index, penalize peer and do not re-broadcast
1266
+ if (!added) {
1267
+ this.peerManager.penalizePeer(peerId, PeerErrorSeverity.HighToleranceError);
1268
+ this.logger.warn(`Penalizing peer for block proposal exceeding per-position cap`, {
1269
+ ...block.toBlockInfo(),
1270
+ indexWithinCheckpoint: block.indexWithinCheckpoint,
1271
+ count,
1272
+ proposer: block.getSender()?.toString(),
1273
+ source: peerId.toString()
1274
+ });
1275
+ return {
1276
+ result: TopicValidatorResult.Reject,
1277
+ metadata: {
1278
+ isEquivocated
1279
+ }
1280
+ };
1281
+ }
1282
+ // If this was a duplicate proposal, do not process it, but do invoke the duplicate callback,
1283
+ // and do re-broadcast it so other nodes in the network know to slash the proposer
1284
+ if (isEquivocated) {
1285
+ const proposer = block.getSender();
1286
+ this.logger.warn(`Detected duplicate block proposal (equivocation) at slot ${block.slotNumber}`, {
1287
+ ...block.toBlockInfo(),
1288
+ source: peerId.toString(),
1289
+ proposer: proposer?.toString()
1290
+ });
1291
+ // Invoke the duplicate callback on the first duplicate spotted only
1292
+ if (proposer && count === 2) {
1293
+ this.duplicateProposalCallback?.({
1294
+ slot: block.slotNumber,
1295
+ proposer,
1296
+ type: 'block'
1297
+ });
1298
+ }
1299
+ return {
1300
+ result: TopicValidatorResult.Accept,
1301
+ obj: block,
1302
+ metadata: {
1303
+ isEquivocated
1304
+ }
1305
+ };
1306
+ }
1307
+ // Otherwise, we're good to go!
1308
+ return {
1309
+ result: TopicValidatorResult.Accept,
1310
+ obj: block
1311
+ };
1312
+ }
1209
1313
  // REFACTOR(palla): This method should be moved to the p2p_client or to a separate component,
1210
1314
  // should not be here as it does not deal with p2p networking.
1211
1315
  async processValidBlockProposal(block, sender) {
@@ -1215,23 +1319,8 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
1215
1319
  source: sender.toString(),
1216
1320
  ...block.toBlockInfo()
1217
1321
  });
1218
- // Attempt to add proposal
1219
- try {
1220
- await this.mempools.attestationPool.addBlockProposal(block);
1221
- } catch (err) {
1222
- // Drop proposals if we hit per-slot cap in the attestation pool; rethrow unknown errors
1223
- if (err instanceof ProposalSlotCapExceededError) {
1224
- this.logger.warn(`Dropping block proposal due to per-slot proposal cap`, {
1225
- slot: String(slot),
1226
- archive: block.archive.toString(),
1227
- error: err.message
1228
- });
1229
- return;
1230
- }
1231
- throw err;
1232
- }
1233
- // Mark the txs in this proposal as non-evictable
1234
- await this.mempools.txPool.markTxsAsNonEvictable(block.txHashes);
1322
+ // Mark the txs in this proposal as protected
1323
+ await this.mempools.txPool.protectTxs(block.txHashes, block.blockHeader);
1235
1324
  // Call the block received callback to validate the proposal.
1236
1325
  // Note: Validators do NOT attest to individual blocks, only to checkpoint proposals.
1237
1326
  const isValid = await this.blockReceivedCallback(block, sender);
@@ -1243,57 +1332,135 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
1243
1332
  * Handle a gossiped checkpoint proposal.
1244
1333
  * Validates and processes the checkpoint proposal, then triggers the callback for attestation.
1245
1334
  */ async handleGossipedCheckpointProposal(payloadData, msgId, source) {
1246
- // TODO(palla/mbps): This pattern is repeated across multiple message handlers, consider abstracting it.
1247
- const validationFunc = async ()=>{
1248
- const checkpoint = CheckpointProposal.fromBuffer(payloadData);
1249
- const validationResult = await this.validateCheckpointProposal(source, checkpoint);
1250
- const isValid = validationResult.result === 'accept';
1251
- const pool = this.mempools.attestationPool;
1252
- const exists = isValid && await pool.hasCheckpointProposal(checkpoint);
1253
- const canAdd = isValid && await pool.canAddCheckpointProposal(checkpoint);
1254
- this.logger.trace(`Validate propagated checkpoint proposal`, {
1255
- isValid,
1256
- exists,
1257
- canAdd,
1335
+ const { result, obj: checkpoint, metadata: { isEquivocated, processBlock } = {} } = await this.validateReceivedMessage(()=>this.validateAndStoreCheckpointProposal(source, CheckpointProposal.fromBuffer(payloadData)), msgId, source, TopicType.checkpoint_proposal);
1336
+ // If the checkpoint contained a valid last block, we process it even if the checkpoint itself is to be rejected
1337
+ // TODO(palla/mbps): Is this ok? Should we be considering a block from a checkpoint that was equivocated?
1338
+ if (processBlock && checkpoint?.getBlockProposal()) {
1339
+ await this.processValidBlockProposal(checkpoint.getBlockProposal(), source);
1340
+ }
1341
+ if (result !== TopicValidatorResult.Accept || !checkpoint || isEquivocated) {
1342
+ return;
1343
+ }
1344
+ await this.processValidCheckpointProposal(checkpoint.toCore(), source);
1345
+ }
1346
+ /**
1347
+ * Validates a checkpoint proposal. Penalizes peer if validation fails. Adds the checkpoint and
1348
+ * its last block (if present) to the mempool if valid. Triggers equivocation detection on both.
1349
+ */ async validateAndStoreCheckpointProposal(peerId, checkpoint) {
1350
+ const validationResult = await this.checkpointProposalValidator.validate(checkpoint);
1351
+ if (validationResult.result === 'reject') {
1352
+ this.logger.warn(`Penalizing peer ${peerId} for checkpoint proposal validation failure`);
1353
+ this.peerManager.penalizePeer(peerId, validationResult.severity);
1354
+ return {
1355
+ result: TopicValidatorResult.Reject
1356
+ };
1357
+ }
1358
+ if (validationResult.result === 'ignore') {
1359
+ return {
1360
+ result: TopicValidatorResult.Ignore,
1361
+ obj: checkpoint
1362
+ };
1363
+ }
1364
+ // Extract and try to add the block proposal first if present
1365
+ const blockProposal = checkpoint.getBlockProposal();
1366
+ let processBlock = false;
1367
+ if (blockProposal) {
1368
+ this.logger.debug(`Validating block proposal from propagated checkpoint`, {
1258
1369
  [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
1259
- [Attributes.P2P_ID]: source.toString()
1370
+ [Attributes.P2P_ID]: peerId.toString()
1260
1371
  });
1261
- if (validationResult.result === 'reject') {
1262
- return {
1263
- result: TopicValidatorResult.Reject
1264
- };
1265
- } else if (validationResult.result === 'ignore' || exists) {
1266
- return {
1267
- result: TopicValidatorResult.Ignore,
1268
- obj: checkpoint
1269
- };
1270
- } else if (!canAdd) {
1271
- this.peerManager.penalizePeer(source, PeerErrorSeverity.MidToleranceError);
1272
- this.logger.warn(`Penalizing peer for checkpoint proposal exceeding per-slot cap`, {
1273
- slot: checkpoint.slotNumber.toString(),
1274
- archive: checkpoint.archive.toString(),
1275
- source: source.toString()
1372
+ const { result, obj, metadata: { isEquivocated } = {} } = await this.validateAndStoreBlockProposal(peerId, blockProposal);
1373
+ if (result === TopicValidatorResult.Reject || !obj || isEquivocated) {
1374
+ this.logger.debug(`Rejecting checkpoint due to invalid last block proposal`, {
1375
+ [Attributes.SLOT_NUMBER]: checkpoint.slotNumber.toString(),
1376
+ [Attributes.P2P_ID]: peerId.toString(),
1377
+ isEquivocated,
1378
+ result
1276
1379
  });
1277
1380
  return {
1278
1381
  result: TopicValidatorResult.Reject
1279
1382
  };
1280
- } else {
1281
- return {
1282
- result: TopicValidatorResult.Accept,
1283
- obj: checkpoint
1284
- };
1383
+ } else if (result === TopicValidatorResult.Accept && obj && !isEquivocated) {
1384
+ processBlock = true;
1285
1385
  }
1286
- };
1287
- const { result, obj: checkpoint } = await this.validateReceivedMessage(validationFunc, msgId, source, TopicType.checkpoint_proposal);
1288
- if (result !== TopicValidatorResult.Accept || !checkpoint) {
1289
- return;
1290
1386
  }
1291
- await this.processValidCheckpointProposal(checkpoint, source);
1387
+ // Try to add the checkpoint proposal core: this handles existence check, cap check, and adding in one call
1388
+ const checkpointCore = checkpoint.toCore();
1389
+ const tryAddResult = await this.mempools.attestationPool.tryAddCheckpointProposal(checkpointCore);
1390
+ const { added, alreadyExists, count } = tryAddResult;
1391
+ const isEquivocated = count !== undefined && count > 1;
1392
+ // Duplicate proposal received, do not re-broadcast
1393
+ if (alreadyExists) {
1394
+ this.logger.debug(`Ignoring duplicate checkpoint proposal received`, {
1395
+ ...checkpoint.toCheckpointInfo(),
1396
+ source: peerId.toString()
1397
+ });
1398
+ return {
1399
+ result: TopicValidatorResult.Ignore,
1400
+ obj: checkpoint,
1401
+ metadata: {
1402
+ isEquivocated,
1403
+ processBlock
1404
+ }
1405
+ };
1406
+ }
1407
+ // Too many checkpoint proposals received for this slot, penalize peer and do not re-broadcast
1408
+ // Note: We still return the checkpoint obj so the lastBlock can be processed if valid
1409
+ if (!added) {
1410
+ this.peerManager.penalizePeer(peerId, PeerErrorSeverity.HighToleranceError);
1411
+ this.logger.warn(`Penalizing peer for checkpoint proposal exceeding per-slot cap`, {
1412
+ ...checkpoint.toCheckpointInfo(),
1413
+ count,
1414
+ source: peerId.toString()
1415
+ });
1416
+ return {
1417
+ result: TopicValidatorResult.Reject,
1418
+ obj: checkpoint,
1419
+ metadata: {
1420
+ isEquivocated,
1421
+ processBlock
1422
+ }
1423
+ };
1424
+ }
1425
+ // If this was a duplicate proposal, do not process it, but do invoke the duplicate callback,
1426
+ // and do re-broadcast it so other nodes in the network know to slash the proposer
1427
+ if (isEquivocated) {
1428
+ const proposer = checkpoint.getSender();
1429
+ this.logger.warn(`Detected duplicate checkpoint proposal (equivocation) at slot ${checkpoint.slotNumber}`, {
1430
+ ...checkpoint.toCheckpointInfo(),
1431
+ source: peerId.toString(),
1432
+ proposer: proposer?.toString()
1433
+ });
1434
+ // Invoke the duplicate callback on the first duplicate spotted only
1435
+ if (proposer && count === 2) {
1436
+ this.duplicateProposalCallback?.({
1437
+ slot: checkpoint.slotNumber,
1438
+ proposer,
1439
+ type: 'checkpoint'
1440
+ });
1441
+ }
1442
+ return {
1443
+ result: TopicValidatorResult.Accept,
1444
+ obj: checkpoint,
1445
+ metadata: {
1446
+ isEquivocated,
1447
+ processBlock
1448
+ }
1449
+ };
1450
+ }
1451
+ // Otherwise, we're good to go!
1452
+ return {
1453
+ result: TopicValidatorResult.Accept,
1454
+ obj: checkpoint,
1455
+ metadata: {
1456
+ processBlock,
1457
+ isEquivocated
1458
+ }
1459
+ };
1292
1460
  }
1293
1461
  /**
1294
1462
  * Process a validated checkpoint proposal.
1295
- * Extracts and processes the last block proposal (if present) first, then processes the checkpoint.
1296
- * The block callback is invoked before the checkpoint callback.
1463
+ * Note: The proposal was already added to the pool by tryAddCheckpointProposal in handleGossipedCheckpointProposal.
1297
1464
  */ async processValidCheckpointProposal(checkpoint, sender) {
1298
1465
  const slot = checkpoint.slotNumber;
1299
1466
  this.logger.verbose(`Received checkpoint proposal for slot ${slot} from external peer ${sender.toString()}.`, {
@@ -1302,33 +1469,12 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
1302
1469
  archive: checkpoint.archive.toString(),
1303
1470
  source: sender.toString()
1304
1471
  });
1305
- // Extract block proposal before adding to pool (pool stores them separately)
1306
- const blockProposal = checkpoint.getBlockProposal();
1307
- // Add proposal to the pool (this extracts and stores block proposal separately)
1308
- await this.mempools.attestationPool.addCheckpointProposal(checkpoint);
1309
- // Mark txs as non-evictable if present (from the last block)
1310
- if (checkpoint.txHashes.length > 0) {
1311
- await this.mempools.txPool.markTxsAsNonEvictable(checkpoint.txHashes);
1312
- }
1313
- // If there was a last block proposal, invoke the block callback first for validation.
1314
- // Note: The block proposal is already stored in the pool by addCheckpointProposal.
1315
- if (blockProposal) {
1316
- const isValid = await this.blockReceivedCallback(blockProposal, sender);
1317
- if (!isValid) {
1318
- this.logger.warn(`Block proposal from checkpoint failed validation`, {
1319
- slot: slot.toString(),
1320
- archive: checkpoint.archive.toString(),
1321
- blockNumber: blockProposal.blockNumber.toString()
1322
- });
1323
- return;
1324
- }
1325
- }
1326
1472
  // Call the checkpoint received callback with the core version (without lastBlock)
1327
1473
  // to validate and potentially generate attestations
1328
- const attestations = await this.checkpointReceivedCallback(checkpoint.toCore(), sender);
1474
+ const attestations = await this.checkpointReceivedCallback(checkpoint, sender);
1329
1475
  if (attestations && attestations.length > 0) {
1330
1476
  // If the callback returned attestations, add them to the pool and propagate them
1331
- await this.mempools.attestationPool.addCheckpointAttestations(attestations);
1477
+ await this.mempools.attestationPool.addOwnCheckpointAttestations(attestations);
1332
1478
  for (const attestation of attestations){
1333
1479
  await this.propagate(attestation);
1334
1480
  }
@@ -1497,33 +1643,11 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
1497
1643
  }
1498
1644
  }
1499
1645
  createRequestedTxValidator() {
1500
- return createTxReqRespValidator(this.proofVerifier, {
1646
+ return createTxValidatorForReqResponseReceivedTxs(this.proofVerifier, {
1501
1647
  l1ChainId: this.config.l1ChainId,
1502
1648
  rollupVersion: this.config.rollupVersion
1503
1649
  });
1504
1650
  }
1505
- async validatePropagatedTx(tx, peerId) {
1506
- const currentBlockNumber = await this.archiver.getBlockNumber();
1507
- // We accept transactions if they are not expired by the next slot (checked based on the IncludeByTimestamp field)
1508
- const { ts: nextSlotTimestamp } = this.epochCache.getEpochAndSlotInNextL1Slot();
1509
- const messageValidators = await this.createMessageValidators(currentBlockNumber, nextSlotTimestamp);
1510
- for (const validator of messageValidators){
1511
- const outcome = await this.runValidations(tx, validator);
1512
- if (outcome.allPassed) {
1513
- continue;
1514
- }
1515
- const { name } = outcome.failure;
1516
- let { severity } = outcome.failure;
1517
- // Double spend validator has a special case handler
1518
- if (name === 'doubleSpendValidator') {
1519
- const txBlockNumber = BlockNumber(currentBlockNumber + 1); // tx is expected to be in the next block
1520
- severity = await this.handleDoubleSpendFailure(tx, txBlockNumber);
1521
- }
1522
- this.peerManager.penalizePeer(peerId, severity);
1523
- return false;
1524
- }
1525
- return true;
1526
- }
1527
1651
  async getGasFees(blockNumber) {
1528
1652
  if (blockNumber === this.feesCache?.blockNumber) {
1529
1653
  return this.feesCache.gasFees;
@@ -1550,38 +1674,27 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
1550
1674
  peerScoring: this.peerManager
1551
1675
  };
1552
1676
  }
1553
- async validate(txs) {
1554
- const currentBlockNumber = await this.archiver.getBlockNumber();
1555
- // We accept transactions if they are not expired by the next slot (checked based on the IncludeByTimestamp field)
1556
- const { ts: nextSlotTimestamp } = this.epochCache.getEpochAndSlotInNextL1Slot();
1557
- const messageValidators = await this.createMessageValidators(currentBlockNumber, nextSlotTimestamp);
1558
- await Promise.all(txs.map(async (tx)=>{
1559
- for (const validator of messageValidators){
1560
- const outcome = await this.runValidations(tx, validator);
1561
- if (!outcome.allPassed) {
1562
- throw new Error('Invalid tx detected', {
1563
- cause: {
1564
- outcome
1565
- }
1566
- });
1567
- }
1568
- }
1677
+ async validateTxsReceivedInBlockProposal(txs) {
1678
+ const validator = createTxValidatorForBlockProposalReceivedTxs(this.proofVerifier, {
1679
+ l1ChainId: this.config.l1ChainId,
1680
+ rollupVersion: this.config.rollupVersion
1681
+ }, this.logger.getBindings());
1682
+ const results = await Promise.all(txs.map(async (tx)=>{
1683
+ const result = await validator.validateTx(tx);
1684
+ return result.result !== 'invalid';
1569
1685
  }));
1686
+ if (results.some((value)=>value === false)) {
1687
+ throw new Error('Invalid tx detected');
1688
+ }
1570
1689
  }
1571
- /**
1572
- * Create message validators for the given block number and timestamp.
1573
- *
1574
- * Each validator is a pair of a validator and a severity.
1575
- * If a validator fails, the peer is penalized with the severity of the validator.
1576
- *
1577
- * @param currentBlockNumber - The current synced block number.
1578
- * @param nextSlotTimestamp - The timestamp of the next slot (used to validate txs are not expired).
1579
- * @returns The message validators.
1580
- */ async createMessageValidators(currentBlockNumber, nextSlotTimestamp) {
1690
+ /** Creates the first stage (fast) validators for gossiped transactions. */ async createFirstStageMessageValidators(currentBlockNumber, nextSlotTimestamp) {
1581
1691
  const gasFees = await this.getGasFees(currentBlockNumber);
1582
1692
  const allowedInSetup = this.config.txPublicSetupAllowList ?? await getDefaultAllowedSetupFunctions();
1583
- const blockNumberInWhichTheTxIsConsideredToBeIncluded = BlockNumber(currentBlockNumber + 1);
1584
- return createTxMessageValidators(nextSlotTimestamp, blockNumberInWhichTheTxIsConsideredToBeIncluded, this.worldStateSynchronizer, gasFees, this.config.l1ChainId, this.config.rollupVersion, protocolContractsHash, this.archiver, this.proofVerifier, !this.config.disableTransactions, allowedInSetup, this.logger.getBindings());
1693
+ const blockNumber = BlockNumber(currentBlockNumber + 1);
1694
+ return createFirstStageTxValidationsForGossipedTransactions(nextSlotTimestamp, blockNumber, this.worldStateSynchronizer, gasFees, this.config.l1ChainId, this.config.rollupVersion, protocolContractsHash, this.archiver, !this.config.disableTransactions, allowedInSetup, this.logger.getBindings());
1695
+ }
1696
+ /** Creates the second stage (expensive proof verification) validators for gossiped transactions. */ createSecondStageMessageValidators() {
1697
+ return createSecondStageTxValidationsForGossipedTransactions(this.proofVerifier, this.logger.getBindings());
1585
1698
  }
1586
1699
  /**
1587
1700
  * Run validations on a tx.
@@ -1655,33 +1768,7 @@ _dec = trackSpan('Libp2pService.processValidBlockProposal', async (block)=>({
1655
1768
  */ async validateCheckpointAttestation(peerId, attestation) {
1656
1769
  const result = await this.checkpointAttestationValidator.validate(attestation);
1657
1770
  if (result.result === 'reject') {
1658
- this.logger.debug(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
1659
- this.peerManager.penalizePeer(peerId, result.severity);
1660
- }
1661
- return result;
1662
- }
1663
- /**
1664
- * Validate a block proposal.
1665
- *
1666
- * @param block - The block proposal to validate.
1667
- * @returns True if the block proposal is valid, false otherwise.
1668
- */ async validateBlockProposal(peerId, block) {
1669
- const result = await this.blockProposalValidator.validate(block);
1670
- if (result.result === 'reject') {
1671
- this.logger.debug(`Penalizing peer ${peerId} for block proposal validation failure`);
1672
- this.peerManager.penalizePeer(peerId, result.severity);
1673
- }
1674
- return result;
1675
- }
1676
- /**
1677
- * Validate a checkpoint proposal.
1678
- *
1679
- * @param checkpoint - The checkpoint proposal to validate.
1680
- * @returns True if the checkpoint proposal is valid, false otherwise.
1681
- */ async validateCheckpointProposal(peerId, checkpoint) {
1682
- const result = await this.checkpointProposalValidator.validate(checkpoint);
1683
- if (result.result === 'reject') {
1684
- this.logger.debug(`Penalizing peer ${peerId} for checkpoint proposal validation failure`);
1771
+ this.logger.warn(`Penalizing peer ${peerId} for checkpoint attestation validation failure`);
1685
1772
  this.peerManager.penalizePeer(peerId, result.severity);
1686
1773
  }
1687
1774
  return result;