@aztec/archiver 0.0.1-commit.b1c78909e → 0.0.1-commit.b2a5d0dd1

package/dest/modules/l1_synchronizer.js

@@ -371,20 +371,25 @@ function _apply_decs_2203_r(targetClass, memberDecs, classDecs, parentClass) {
     return (_apply_decs_2203_r = applyDecs2203RFactory())(targetClass, memberDecs, classDecs, parentClass);
 }
 var _dec, _dec1, _dec2, _dec3, _initProto;
+import { getFinalizedL1Block } from '@aztec/ethereum/queries';
+import { asyncPool } from '@aztec/foundation/async-pool';
 import { maxBigint } from '@aztec/foundation/bigint';
 import { BlockNumber, CheckpointNumber } from '@aztec/foundation/branded-types';
-import { Buffer32 } from '@aztec/foundation/buffer';
-import { pick } from '@aztec/foundation/collection';
+import { Buffer16, Buffer32 } from '@aztec/foundation/buffer';
+import { partition, pick } from '@aztec/foundation/collection';
 import { createLogger } from '@aztec/foundation/log';
+import { retryTimes } from '@aztec/foundation/retry';
 import { count } from '@aztec/foundation/string';
 import { Timer, elapsed } from '@aztec/foundation/timer';
-import { isDefined } from '@aztec/foundation/types';
+import { isDefined, isErrorClass } from '@aztec/foundation/types';
 import { L2BlockSourceEvents } from '@aztec/stdlib/block';
+import { Checkpoint, PublishedCheckpoint } from '@aztec/stdlib/checkpoint';
 import { getEpochAtSlot, getSlotAtNextL1Block } from '@aztec/stdlib/epoch-helpers';
 import { computeInHashFromL1ToL2Messages } from '@aztec/stdlib/messaging';
 import { execInSpan, trackSpan } from '@aztec/telemetry-client';
 import { InitialCheckpointNumberNotSequentialError } from '../errors.js';
-import { retrieveCheckpointsFromRollup, retrieveL1ToL2Message, retrieveL1ToL2Messages, retrievedToPublishedCheckpoint } from '../l1/data_retrieval.js';
+import { getCheckpointBlobDataFromBlobs, retrieveCheckpointCalldataFromRollup, retrieveL1ToL2Message, retrieveL1ToL2Messages, retrievedToPublishedCheckpoint } from '../l1/data_retrieval.js';
+import { MessageStoreError } from '../store/message_store.js';
 import { ArchiverDataStoreUpdater } from './data_store_updater.js';
 import { validateCheckpointAttestations } from './validation.js';
 _dec = trackSpan('Archiver.syncFromL1'), _dec1 = trackSpan('Archiver.handleEpochPrune'), _dec2 = trackSpan('Archiver.handleL1ToL2Messages'), _dec3 = trackSpan('Archiver.handleCheckpoints');
@@ -477,12 +482,20 @@ _dec = trackSpan('Archiver.syncFromL1'), _dec1 = trackSpan('Archiver.handleEpoch
         }
     }
     async syncFromL1(initialSyncComplete) {
+        // In between the various calls to L1, the block number can move meaning some of the following
+        // calls will return data for blocks that were not present during earlier calls. To combat this
+        // we ensure that all data retrieval methods only retrieve data up to the currentBlockNumber
+        // captured at the top of this function.
         const currentL1Block = await this.publicClient.getBlock({
             includeTransactions: false
         });
         const currentL1BlockNumber = currentL1Block.number;
         const currentL1BlockHash = Buffer32.fromString(currentL1Block.hash);
         const currentL1Timestamp = currentL1Block.timestamp;
+        const currentL1BlockData = {
+            l1BlockNumber: currentL1BlockNumber,
+            l1BlockHash: currentL1BlockHash
+        };
         if (this.l1BlockHash && currentL1BlockHash.equals(this.l1BlockHash)) {
             this.log.trace(`No new L1 blocks since last sync at L1 block ${this.l1BlockNumber}`);
             return;
@@ -498,36 +511,16 @@ _dec = trackSpan('Archiver.syncFromL1'), _dec1 = trackSpan('Archiver.handleEpoch
                 maxAllowedDelay
             });
         }
-        // Load sync point for blocks and messages defaulting to start block
-        const { blocksSynchedTo = this.l1Constants.l1StartBlock, messagesSynchedTo = {
-            l1BlockNumber: this.l1Constants.l1StartBlock,
-            l1BlockHash: this.l1Constants.l1StartBlockHash
-        } } = await this.store.getSynchPoint();
+        // Load sync point for blocks defaulting to start block
+        const { blocksSynchedTo = this.l1Constants.l1StartBlock } = await this.store.getSynchPoint();
         this.log.debug(`Starting new archiver sync iteration`, {
             blocksSynchedTo,
-            messagesSynchedTo,
-            currentL1BlockNumber,
-            currentL1BlockHash
+            currentL1BlockData
         });
-        // ********** Ensuring Consistency of data pulled from L1 **********
-        /**
-     * There are a number of calls in this sync operation to L1 for retrieving
-     * events and transaction data. There are a couple of things we need to bear in mind
-     * to ensure that data is read exactly once.
-     *
-     * The first is the problem of eventually consistent ETH service providers like Infura.
-     * Each L1 read operation will query data from the last L1 block that it saw emit its kind of data.
-     * (so pending L1 to L2 messages will read from the last L1 block that emitted a message and so  on)
-     * This will mean the archiver will lag behind L1 and will only advance when there's L2-relevant activity on the chain.
-     *
-     * The second is that in between the various calls to L1, the block number can move meaning some
-     * of the following calls will return data for blocks that were not present during earlier calls.
-     * To combat this for the time being we simply ensure that all data retrieval methods only retrieve
-     * data up to the currentBlockNumber captured at the top of this function. We might want to improve on this
-     * in future but for the time being it should give us the guarantees that we need
-     */ // ********** Events that are processed per L1 block **********
-        await this.handleL1ToL2Messages(messagesSynchedTo, currentL1BlockNumber);
-        // ********** Events that are processed per checkpoint **********
+        // Sync L1 to L2 messages. We retry this a few times since there are error conditions that reset the sync point, requiring a new iteration.
+        // Note that we cannot just wait for the l1 synchronizer to loop again, since the synchronizer would report as synced up to the current L1
+        // block, when that wouldn't be the case, since L1 to L2 messages would need another iteration.
+        await retryTimes(()=>this.handleL1ToL2Messages(currentL1BlockData), 'Handling L1 to L2 messages', 3, 0.1);
         if (currentL1BlockNumber > blocksSynchedTo) {
             // First we retrieve new checkpoints and L2 blocks and store them in the DB. This will also update the
             // pending chain validation status, proven checkpoint number, and synched L1 block number.
@@ -572,10 +565,11 @@ _dec = trackSpan('Archiver.syncFromL1'), _dec1 = trackSpan('Archiver.handleEpoch
     }
     /** Query L1 for its finalized block and update the finalized checkpoint accordingly. */ async updateFinalizedCheckpoint() {
         try {
-            const finalizedL1Block = await this.publicClient.getBlock({
-                blockTag: 'finalized',
-                includeTransactions: false
-            });
+            const finalizedL1Block = await getFinalizedL1Block(this.publicClient);
+            if (!finalizedL1Block) {
+                this.log.trace(`Skipping finalized checkpoint update: L1 has no finalized block yet.`);
+                return;
+            }
             const finalizedL1BlockNumber = finalizedL1Block.number;
             const finalizedCheckpointNumber = await this.rollup.getProvenCheckpointNumber({
                 blockNumber: finalizedL1BlockNumber
@@ -589,7 +583,10 @@ _dec = trackSpan('Archiver.syncFromL1'), _dec1 = trackSpan('Archiver.handleEpoch
                 });
             }
         } catch (err) {
-            this.log.warn(`Failed to update finalized checkpoint: ${err}`);
+            // The rollup contract may not exist at the finalized L1 block right after deployment.
+            if (!err?.message?.includes('returned no data')) {
+                this.log.warn(`Failed to update finalized checkpoint: ${err}`);
+            }
         }
     }
     /** Prune all proposed local blocks that should have been checkpointed by now. */ async pruneUncheckpointedBlocks(currentL1Timestamp) {
@@ -602,26 +599,28 @@ _dec = trackSpan('Archiver.syncFromL1'), _dec1 = trackSpan('Archiver.handleEpoch
             this.log.trace(`No uncheckpointed blocks to prune.`);
             return;
         }
-        // What's the slot of the first uncheckpointed block?
+        // What's the slot at the next L1 block? All blocks for slots strictly before this one should've been checkpointed by now.
+        const slotAtNextL1Block = getSlotAtNextL1Block(currentL1Timestamp, this.l1Constants);
         const firstUncheckpointedBlockNumber = BlockNumber(lastCheckpointedBlockNumber + 1);
+        // What's the slot of the first uncheckpointed block?
         const [firstUncheckpointedBlockHeader] = await this.store.getBlockHeaders(firstUncheckpointedBlockNumber, 1);
         const firstUncheckpointedBlockSlot = firstUncheckpointedBlockHeader?.getSlot();
-        // What's the slot at the next L1 block? All blocks for slots strictly before this one should've been checkpointed by now.
-        const slotAtNextL1Block = getSlotAtNextL1Block(currentL1Timestamp, this.l1Constants);
-        // Prune provisional blocks from slots that have ended without being checkpointed
-        if (firstUncheckpointedBlockSlot !== undefined && firstUncheckpointedBlockSlot < slotAtNextL1Block) {
-            this.log.warn(`Pruning blocks after block ${lastCheckpointedBlockNumber} due to slot ${firstUncheckpointedBlockSlot} not being checkpointed`, {
-                firstUncheckpointedBlockHeader: firstUncheckpointedBlockHeader.toInspect(),
-                slotAtNextL1Block
+        if (firstUncheckpointedBlockSlot === undefined || firstUncheckpointedBlockSlot >= slotAtNextL1Block) {
+            return;
+        }
+        // Prune provisional blocks from slots that have ended without being checkpointed.
+        // This also clears any proposed checkpoint whose blocks are being pruned.
+        this.log.warn(`Pruning blocks after block ${lastCheckpointedBlockNumber} due to slot ${firstUncheckpointedBlockSlot} not being checkpointed`, {
+            firstUncheckpointedBlockHeader: firstUncheckpointedBlockHeader.toInspect(),
+            slotAtNextL1Block
+        });
+        const prunedBlocks = await this.updater.removeUncheckpointedBlocksAfter(lastCheckpointedBlockNumber);
+        if (prunedBlocks.length > 0) {
+            this.events.emit(L2BlockSourceEvents.L2PruneUncheckpointed, {
+                type: L2BlockSourceEvents.L2PruneUncheckpointed,
+                slotNumber: firstUncheckpointedBlockSlot,
+                blocks: prunedBlocks
             });
-            const prunedBlocks = await this.updater.removeUncheckpointedBlocksAfter(lastCheckpointedBlockNumber);
-            if (prunedBlocks.length > 0) {
-                this.events.emit(L2BlockSourceEvents.L2PruneUncheckpointed, {
-                    type: L2BlockSourceEvents.L2PruneUncheckpointed,
-                    slotNumber: firstUncheckpointedBlockSlot,
-                    blocks: prunedBlocks
-                });
-            }
         }
     }
     /** Queries the rollup contract on whether a prune can be executed on the immediate next L1 block. */ async canPrune(currentL1BlockNumber, currentL1Timestamp) {
@@ -652,12 +651,14 @@ _dec = trackSpan('Archiver.syncFromL1'), _dec1 = trackSpan('Archiver.handleEpoch
             const pruneFromSlotNumber = header.slotNumber;
             const pruneFromEpochNumber = getEpochAtSlot(pruneFromSlotNumber, this.l1Constants);
             const checkpointsToUnwind = localPendingCheckpointNumber - provenCheckpointNumber;
-            const checkpointPromises = Array.from({
+            // Fetch checkpoints and blocks in bounded batches to avoid unbounded concurrent
+            // promises when the gap between local pending and proven checkpoint numbers is large.
+            const BATCH_SIZE = 10;
+            const indices = Array.from({
                 length: checkpointsToUnwind
-            }).fill(0).map((_, i)=>this.store.getCheckpointData(CheckpointNumber(i + pruneFrom)));
-            const checkpoints = await Promise.all(checkpointPromises);
-            const blockPromises = await Promise.all(checkpoints.filter(isDefined).map((cp)=>this.store.getBlocksForCheckpoint(CheckpointNumber(cp.checkpointNumber))));
-            const newBlocks = blockPromises.filter(isDefined).flat();
+            }, (_, i)=>CheckpointNumber(i + pruneFrom));
+            const checkpoints = (await asyncPool(BATCH_SIZE, indices, (idx)=>this.store.getCheckpointData(idx))).filter(isDefined);
+            const newBlocks = (await asyncPool(BATCH_SIZE, checkpoints, (cp)=>this.store.getBlocksForCheckpoint(CheckpointNumber(cp.checkpointNumber)))).filter(isDefined).flat();
             // Emit an event for listening services to react to the chain prune
             this.events.emit(L2BlockSourceEvents.L2PruneUnproven, {
                 type: L2BlockSourceEvents.L2PruneUnproven,
@@ -691,55 +692,75 @@ _dec = trackSpan('Archiver.syncFromL1'), _dec1 = trackSpan('Archiver.handleEpoch
             nextEnd
         ];
     }
-    async handleL1ToL2Messages(messagesSyncPoint, currentL1BlockNumber) {
-        this.log.trace(`Handling L1 to L2 messages from ${messagesSyncPoint.l1BlockNumber} to ${currentL1BlockNumber}.`);
-        if (currentL1BlockNumber <= messagesSyncPoint.l1BlockNumber) {
-            return;
+    async handleL1ToL2Messages(currentL1Block) {
+        // Load the syncpoint, which may have been updated in a previous iteration
+        const { messagesSynchedTo = {
+            l1BlockNumber: this.l1Constants.l1StartBlock,
+            l1BlockHash: this.l1Constants.l1StartBlockHash
+        } } = await this.store.getSynchPoint();
+        // Nothing to do if L1 block number has not moved forward
+        const currentL1BlockNumber = currentL1Block.l1BlockNumber;
+        if (currentL1BlockNumber <= messagesSynchedTo.l1BlockNumber) {
+            return true;
         }
-        // Load remote and local inbox states.
-        const localMessagesInserted = await this.store.getTotalL1ToL2MessageCount();
-        const localLastMessage = await this.store.getLastL1ToL2Message();
+        // Compare local message store state with the remote. If they match, we just advance the match pointer.
         const remoteMessagesState = await this.inbox.getState({
             blockNumber: currentL1BlockNumber
         });
-        this.log.trace(`Retrieved remote inbox state at L1 block ${currentL1BlockNumber}.`, {
-            localMessagesInserted,
-            localLastMessage,
-            remoteMessagesState
-        });
-        // Compare message count and rolling hash. If they match, no need to retrieve anything.
-        if (remoteMessagesState.totalMessagesInserted === localMessagesInserted && remoteMessagesState.messagesRollingHash.equals(localLastMessage?.rollingHash ?? Buffer32.ZERO)) {
-            this.log.trace(`No L1 to L2 messages to query between L1 blocks ${messagesSyncPoint.l1BlockNumber} and ${currentL1BlockNumber}.`);
-            return;
+        const localLastMessage = await this.store.getLastL1ToL2Message();
+        if (await this.localStateMatches(localLastMessage, remoteMessagesState)) {
+            this.log.trace(`Local L1 to L2 messages are already in sync with remote at L1 block ${currentL1BlockNumber}`);
+            await this.store.setMessageSyncState(currentL1Block, remoteMessagesState.treeInProgress);
+            return true;
         }
-        // Check if our syncpoint is still valid. If not, there was an L1 reorg and we need to re-retrieve messages.
-        // Note that we need to fetch it from logs and not from inbox state at the syncpoint l1 block number, since it
-        // could be older than 128 blocks and non-archive nodes cannot resolve it.
-        if (localLastMessage) {
-            const remoteLastMessage = await this.retrieveL1ToL2Message(localLastMessage.leaf);
-            this.log.trace(`Retrieved remote message for local last`, {
-                remoteLastMessage,
-                localLastMessage
-            });
-            if (!remoteLastMessage || !remoteLastMessage.rollingHash.equals(localLastMessage.rollingHash)) {
-                this.log.warn(`Rolling back L1 to L2 messages due to hash mismatch or msg not found.`, {
-                    remoteLastMessage,
-                    messagesSyncPoint,
-                    localLastMessage
-                });
-                messagesSyncPoint = await this.rollbackL1ToL2Messages(localLastMessage, messagesSyncPoint);
-                this.log.debug(`Rolled back L1 to L2 messages to L1 block ${messagesSyncPoint.l1BlockNumber}.`, {
-                    messagesSyncPoint
+        // If not, then we are out of sync. Most likely there are new messages on the inbox, so we try retrieving them.
+        // However, it could also be the case that there was an L1 reorg and our syncpoint is no longer valid.
+        // If that's the case, we'd get an exception out of the message store since the rolling hash of the first message
+        // we try to insert would not match the one in the db, in which case we rollback to the last common message with L1.
+        try {
+            await this.retrieveAndStoreMessages(messagesSynchedTo.l1BlockNumber, currentL1BlockNumber);
+        } catch (error) {
+            if (isErrorClass(error, MessageStoreError)) {
+                this.log.warn(`Failed to store L1 to L2 messages retrieved from L1: ${error.message}. Rolling back syncpoint to retry.`, {
+                    inboxMessage: error.inboxMessage
                 });
+                await this.rollbackL1ToL2Messages(remoteMessagesState);
+                return false;
             }
+            throw error;
+        }
+        // Note that, if there are no new messages to insert, but there was an L1 reorg that pruned out last messages,
+        // we'd notice by comparing our local state with the remote one again, and seeing they don't match even after
+        // our sync attempt. In this case, we also rollback our syncpoint, and trigger a retry.
+        const localLastMessageAfterSync = await this.store.getLastL1ToL2Message();
+        if (!await this.localStateMatches(localLastMessageAfterSync, remoteMessagesState)) {
+            this.log.warn(`Local L1 to L2 messages state does not match remote after sync attempt. Rolling back syncpoint to retry.`, {
+                localLastMessageAfterSync,
+                remoteMessagesState
+            });
+            await this.rollbackL1ToL2Messages(remoteMessagesState);
+            return false;
         }
-        // Retrieve and save messages in batches. Each batch is estimated to acommodate up to L2 'blockBatchSize' blocks,
+        // Advance the syncpoint after a successful sync
+        await this.store.setMessageSyncState(currentL1Block, remoteMessagesState.treeInProgress);
+        return true;
+    }
+    /** Checks if the local rolling hash and message count matches the remote state */ async localStateMatches(localLastMessage, remoteState) {
+        const localMessageCount = await this.store.getTotalL1ToL2MessageCount();
+        this.log.trace(`Comparing local and remote inbox state`, {
+            localMessageCount,
+            localLastMessage,
+            remoteState
+        });
+        return remoteState.totalMessagesInserted === localMessageCount && remoteState.messagesRollingHash.equals(localLastMessage?.rollingHash ?? Buffer16.ZERO);
+    }
+    /** Retrieves L1 to L2 messages from L1 in batches and stores them. */ async retrieveAndStoreMessages(fromL1Block, toL1Block) {
         let searchStartBlock = 0n;
-        let searchEndBlock = messagesSyncPoint.l1BlockNumber;
+        let searchEndBlock = fromL1Block;
         let lastMessage;
         let messageCount = 0;
         do {
-            [searchStartBlock, searchEndBlock] = this.nextRange(searchEndBlock, currentL1BlockNumber);
+            [searchStartBlock, searchEndBlock] = this.nextRange(searchEndBlock, toL1Block);
             this.log.trace(`Retrieving L1 to L2 messages in L1 blocks ${searchStartBlock}-${searchEndBlock}`);
             const messages = await retrieveL1ToL2Messages(this.inbox, searchStartBlock, searchEndBlock);
             const timer = new Timer();
@@ -754,74 +775,81 @@ _dec = trackSpan('Archiver.syncFromL1'), _dec1 = trackSpan('Archiver.handleEpoch
                 lastMessage = msg;
                 messageCount++;
             }
-        }while (searchEndBlock < currentL1BlockNumber)
-        // Log stats for messages retrieved (if any).
+        }while (searchEndBlock < toL1Block)
         if (messageCount > 0) {
             this.log.info(`Retrieved ${messageCount} new L1 to L2 messages up to message with index ${lastMessage?.index} for checkpoint ${lastMessage?.checkpointNumber}`, {
                 lastMessage,
                 messageCount
             });
         }
-        // Warn if the resulting rolling hash does not match the remote state we had retrieved.
-        if (lastMessage && !lastMessage.rollingHash.equals(remoteMessagesState.messagesRollingHash)) {
-            this.log.warn(`Last message retrieved rolling hash does not match remote state.`, {
-                lastMessage,
-                remoteMessagesState
-            });
-        }
-    }
-    async retrieveL1ToL2Message(leaf) {
-        const currentL1BlockNumber = await this.publicClient.getBlockNumber();
-        let searchStartBlock = 0n;
-        let searchEndBlock = this.l1Constants.l1StartBlock - 1n;
-        do {
-            [searchStartBlock, searchEndBlock] = this.nextRange(searchEndBlock, currentL1BlockNumber);
-            const message = await retrieveL1ToL2Message(this.inbox, leaf, searchStartBlock, searchEndBlock);
-            if (message) {
-                return message;
-            }
-        }while (searchEndBlock < currentL1BlockNumber)
-        return undefined;
     }
-    async rollbackL1ToL2Messages(localLastMessage, messagesSyncPoint) {
-        // Slowly go back through our messages until we find the last common message.
-        // We could query the logs in batch as an optimization, but the depth of the reorg should not be deep, and this
-        // is a very rare case, so it's fine to query one log at a time.
+    /**
+   * Rolls back local L1 to L2 messages to the last common message with L1, and updates the syncpoint to the L1 block of that message.
+   * If no common message is found, rolls back all messages and sets the syncpoint to the start block.
+   */ async rollbackL1ToL2Messages(remoteMessagesState) {
+        const { treeInProgress: remoteTreeInProgress, messagesRollingHash: remoteRollingHash } = remoteMessagesState;
+        // Slowly go back through our messages until we find the last common message. We could query the logs in
+        // batch as an optimization, but the depth of the reorg should not be deep, and this is a very rare case,
+        // so it's fine to query one log at a time.
         let commonMsg;
-        this.log.verbose(`Searching most recent common L1 to L2 message at or before index ${localLastMessage.index}`);
-        for await (const msg of this.store.iterateL1ToL2Messages({
-            reverse: true,
-            end: localLastMessage.index
+        let messagesToDelete = 0;
+        this.log.verbose(`Searching most recent common L1 to L2 message`);
+        for await (const localMsg of this.store.iterateL1ToL2Messages({
+            reverse: true
         })){
-            const remoteMsg = await this.retrieveL1ToL2Message(msg.leaf);
             const logCtx = {
-                remoteMsg,
-                localMsg: msg
+                remoteMsg: undefined,
+                localMsg,
+                remoteMessagesState
             };
-            if (remoteMsg && remoteMsg.rollingHash.equals(msg.rollingHash)) {
-                this.log.verbose(`Found most recent common L1 to L2 message at index ${msg.index} on L1 block ${msg.l1BlockNumber}`, logCtx);
+            // First check if the local message rolling hash matches the current rolling hash of the inbox contract,
+            // which means we just need to rollback some local messages and we should be back in sync. This means there
+            // was an L1 reorg that removed some of the messages we had, but no new messages were added compared.
+            if (localMsg.rollingHash.equals(remoteRollingHash)) {
+                this.log.info(`Found common L1 to L2 message at index ${localMsg.index} on L1 block ${localMsg.l1BlockNumber} matching current remote state`, logCtx);
+                commonMsg = localMsg;
+                break;
+            }
+            // If there's no match with the current remote state, check if the message exists on the inbox contract at all
+            // by looking at the inbox events. If the L1 reorg *added* new messages in addition to deleting existing ones,
+            // then the current remote state's rolling hash will not match anything we have locally, so we need to check existence
+            // of individual messages via logs. Note we use logs and not historical queries so we don't have to depend on
+            // an archival rpc node, since the message could be from a long time ago if we're catching up with syncing.
+            const remoteMsg = await retrieveL1ToL2Message(this.inbox, localMsg);
+            logCtx.remoteMsg = remoteMsg;
+            if (remoteMsg && remoteMsg.rollingHash.equals(localMsg.rollingHash)) {
+                this.log.info(`Found most recent common L1 to L2 message at index ${localMsg.index} on L1 block ${localMsg.l1BlockNumber}`, logCtx);
                 commonMsg = remoteMsg;
                 break;
             } else if (remoteMsg) {
-                this.log.debug(`Local L1 to L2 message with index ${msg.index} has different rolling hash`, logCtx);
+                this.log.debug(`Local L1 to L2 message with index ${localMsg.index} has different rolling hash`, logCtx);
+                messagesToDelete++;
             } else {
-                this.log.debug(`Local L1 to L2 message with index ${msg.index} not found on L1`, logCtx);
+                this.log.debug(`Local L1 to L2 message with index ${localMsg.index} not found on L1`, logCtx);
+                messagesToDelete++;
             }
         }
-        // Delete everything after the common message we found.
-        const lastGoodIndex = commonMsg?.index;
-        this.log.warn(`Deleting all local L1 to L2 messages after index ${lastGoodIndex ?? 'undefined'}`);
-        await this.store.removeL1ToL2Messages(lastGoodIndex !== undefined ? lastGoodIndex + 1n : 0n);
+        // Delete everything after the common message we found, if anything needs to be deleted.
+        // Do not exit early if there are no messages to delete, we still want to update the syncpoint.
+        if (messagesToDelete > 0) {
+            const lastGoodIndex = commonMsg?.index;
+            this.log.warn(`Rolling back all local L1 to L2 messages after index ${lastGoodIndex ?? 'initial'}`);
+            await this.store.removeL1ToL2Messages(lastGoodIndex !== undefined ? lastGoodIndex + 1n : 0n);
+        }
         // Update the syncpoint so the loop below reprocesses the changed messages. We go to the block before
         // the last common one, so we force reprocessing it, in case new messages were added on that same L1 block
         // after the last common message.
         const syncPointL1BlockNumber = commonMsg ? commonMsg.l1BlockNumber - 1n : this.l1Constants.l1StartBlock;
         const syncPointL1BlockHash = await this.getL1BlockHash(syncPointL1BlockNumber);
-        messagesSyncPoint = {
+        const messagesSyncPoint = {
             l1BlockNumber: syncPointL1BlockNumber,
             l1BlockHash: syncPointL1BlockHash
         };
-        await this.store.setMessageSynchedL1Block(messagesSyncPoint);
+        await this.store.setMessageSyncState(messagesSyncPoint, remoteTreeInProgress);
+        this.log.verbose(`Updated messages syncpoint to L1 block ${syncPointL1BlockNumber}`, {
+            ...messagesSyncPoint,
+            remoteTreeInProgress
+        });
         return messagesSyncPoint;
     }
     async getL1BlockHash(l1BlockNumber) {
@@ -968,21 +996,37 @@ _dec = trackSpan('Archiver.syncFromL1'), _dec1 = trackSpan('Archiver.handleEpoch
         do {
             [searchStartBlock, searchEndBlock] = this.nextRange(searchEndBlock, currentL1BlockNumber);
             this.log.trace(`Retrieving checkpoints from L1 block ${searchStartBlock} to ${searchEndBlock}`);
-            // TODO(md): Retrieve from blob client then from consensus client, then from peers
-            const retrievedCheckpoints = await execInSpan(this.tracer, 'Archiver.retrieveCheckpointsFromRollup', ()=>retrieveCheckpointsFromRollup(this.rollup, this.publicClient, this.debugClient, this.blobClient, searchStartBlock, searchEndBlock, this.instrumentation, this.log, !initialSyncComplete));
-            if (retrievedCheckpoints.length === 0) {
+            // First fetch calldata only, no blobs yet, since we may be able to just get that data out of the proposed chain
+            const calldataCheckpoints = await execInSpan(this.tracer, 'Archiver.retrieveCheckpointCalldataFromRollup', ()=>retrieveCheckpointCalldataFromRollup(this.rollup, this.publicClient, this.debugClient, searchStartBlock, searchEndBlock, this.instrumentation, this.log));
+            if (calldataCheckpoints.length === 0) {
                 // We are not calling `setBlockSynchedL1BlockNumber` because it may cause sync issues if based off infura.
                 // See further details in earlier comments.
                 this.log.trace(`Retrieved no new checkpoints from L1 block ${searchStartBlock} to ${searchEndBlock}`);
                 continue;
             }
-            this.log.debug(`Retrieved ${retrievedCheckpoints.length} new checkpoints between L1 blocks ${searchStartBlock} and ${searchEndBlock}`, {
-                lastProcessedCheckpoint: retrievedCheckpoints[retrievedCheckpoints.length - 1].l1,
+            this.log.debug(`Retrieved ${calldataCheckpoints.length} new checkpoint calldata between L1 blocks ${searchStartBlock} and ${searchEndBlock}`, {
+                lastProcessedCheckpoint: calldataCheckpoints[calldataCheckpoints.length - 1].l1,
                 searchStartBlock,
                 searchEndBlock
             });
-            const publishedCheckpoints = await Promise.all(retrievedCheckpoints.map((b)=>retrievedToPublishedCheckpoint(b)));
+            // Check if the last checkpoint matches the proposed one (so we can skip blob fetch).
+            // We only check the last one because the proposed checkpoint is always the most recent one,
+            // and if it's in a multi-checkpoint batch it will always be last (sorted by L1 block number).
+            const lastCalldataCheckpoint = calldataCheckpoints[calldataCheckpoints.length - 1];
+            const checkpointToPromote = await this.tryBuildPublishedCheckpointFromProposed(lastCalldataCheckpoint);
+            // Then fetch blobs in parallel and build the full published checkpoints
+            const toFetchBlobs = checkpointToPromote ? calldataCheckpoints.slice(0, -1) : calldataCheckpoints;
+            const blobFetched = await asyncPool(10, toFetchBlobs, async (checkpoint)=>retrievedToPublishedCheckpoint({
+                    ...checkpoint,
+                    checkpointBlobData: await getCheckpointBlobDataFromBlobs(this.blobClient, checkpoint.l1.blockHash, checkpoint.blobHashes, checkpoint.checkpointNumber, this.log, !initialSyncComplete, checkpoint.parentBeaconBlockRoot, checkpoint.l1.timestamp)
+                }));
+            // And add the promoted checkpoint to the list of all checkpoints
+            const publishedCheckpoints = checkpointToPromote ? [
+                ...blobFetched,
+                checkpointToPromote
+            ] : blobFetched;
             const validCheckpoints = [];
+            // Now loop through all checkpoints and validate their attestations
             for (const published of publishedCheckpoints){
                 const validationResult = this.config.skipValidateCheckpointAttestations ? {
                     valid: true
@@ -1041,8 +1085,17 @@ _dec = trackSpan('Archiver.syncFromL1'), _dec1 = trackSpan('Archiver.handleEpoch
             }
             try {
                 const updatedValidationResult = rollupStatus.validationResult === initialValidationResult ? undefined : rollupStatus.validationResult;
-                const [processDuration, result] = await elapsed(()=>execInSpan(this.tracer, 'Archiver.addCheckpoints', ()=>this.updater.addCheckpoints(validCheckpoints, updatedValidationResult)));
-                this.instrumentation.processNewBlocks(processDuration / validCheckpoints.length, validCheckpoints.flatMap((c)=>c.checkpoint.blocks));
+                // Split valid checkpoints: the promoted one (if any) is persisted via the proposed-promotion path,
+                // the rest via addCheckpoints. Both paths run within the same store transaction for atomicity.
+                const [[maybeValidCheckpointToPromote], checkpointsToAdd] = partition(validCheckpoints, (c)=>c.checkpoint.number === checkpointToPromote?.checkpoint.number);
+                const [processDuration, result] = await elapsed(()=>execInSpan(this.tracer, 'Archiver.addCheckpoints', ()=>this.updater.addCheckpoints(checkpointsToAdd, updatedValidationResult, maybeValidCheckpointToPromote && {
+                            l1: lastCalldataCheckpoint.l1,
+                            attestations: lastCalldataCheckpoint.attestations,
+                            checkpoint: maybeValidCheckpointToPromote
+                        })));
+                if (checkpointsToAdd.length > 0) {
+                    this.instrumentation.processNewCheckpointedBlocks(processDuration / checkpointsToAdd.length, checkpointsToAdd.flatMap((c)=>c.checkpoint.blocks));
+                }
                 // If blocks were pruned due to conflict with L1 checkpoints, emit event
                 if (result.prunedBlocks && result.prunedBlocks.length > 0) {
                     const prunedCheckpointNumber = result.prunedBlocks[0].checkpointNumber;
@@ -1087,7 +1140,7 @@ _dec = trackSpan('Archiver.syncFromL1'), _dec1 = trackSpan('Archiver.handleEpoch
                 });
             }
             lastRetrievedCheckpoint = validCheckpoints.at(-1) ?? lastRetrievedCheckpoint;
-            lastL1BlockWithCheckpoint = retrievedCheckpoints.at(-1)?.l1.blockNumber ?? lastL1BlockWithCheckpoint;
+            lastL1BlockWithCheckpoint = calldataCheckpoints.at(-1)?.l1.blockNumber ?? lastL1BlockWithCheckpoint;
         }while (searchEndBlock < currentL1BlockNumber)
         // Important that we update AFTER inserting the blocks.
         await updateProvenCheckpoint();
@@ -1097,6 +1150,51 @@ _dec = trackSpan('Archiver.syncFromL1'), _dec1 = trackSpan('Archiver.handleEpoch
             lastL1BlockWithCheckpoint
         };
     }
+    /** Checks if this checkpoint matches the local proposed one, and if so, loads local data to build a synthetic published checkpoint. */ async tryBuildPublishedCheckpointFromProposed(calldataCheckpoint) {
+        const proposed = await this.store.getProposedCheckpointOnly();
+        if (this.config.skipPromoteProposedCheckpointDuringL1Sync || !proposed || !calldataCheckpoint || proposed.checkpointNumber !== calldataCheckpoint.checkpointNumber) {
+            return undefined;
+        }
+        if (!proposed.header.equals(calldataCheckpoint.header) || !proposed.archive.root.equals(calldataCheckpoint.archiveRoot)) {
+            this.log.warn(`Local proposed checkpoint ${proposed.checkpointNumber} does not match checkpoint retrieved from L1, overriding with L1 data`, {
+                proposedCheckpointNumber: proposed.checkpointNumber,
+                proposedHeader: proposed.header.toInspect(),
+                proposedArchiveRoot: proposed.archive.root.toString(),
+                calldataCheckpointNumber: calldataCheckpoint.checkpointNumber,
+                calldataHeader: calldataCheckpoint.header.toInspect(),
+                calldataArchiveRoot: calldataCheckpoint.archiveRoot.toString()
+            });
+            return undefined;
+        }
+        this.log.debug(`Building published checkpoint from proposed ${calldataCheckpoint.checkpointNumber} (skipping blob fetch)`, {
+            proposedHeader: proposed.header.toInspect(),
+            proposedArchiveRoot: proposed.archive.root.toString()
+        });
+        const blocks = await this.store.getBlocks(BlockNumber(proposed.startBlock), proposed.blockCount);
+        if (blocks.length !== proposed.blockCount) {
+            this.log.warn(`Local proposed checkpoint ${proposed.checkpointNumber} has wrong block count (expected ${proposed.blockCount} blocks starting at ${proposed.startBlock} but got ${blocks.length})`, {
+                proposedCheckpointNumber: proposed.checkpointNumber,
+                proposedStartBlock: proposed.startBlock,
+                proposedBlockCount: proposed.blockCount,
+                retrievedBlocks: blocks.map((b)=>b.number)
+            });
+            return undefined;
+        }
+        const checkpoint = Checkpoint.from({
+            archive: proposed.archive,
+            header: proposed.header,
+            blocks,
+            number: proposed.checkpointNumber,
+            feeAssetPriceModifier: proposed.feeAssetPriceModifier
+        });
+        const promotedCheckpoint = PublishedCheckpoint.from({
+            checkpoint,
+            l1: calldataCheckpoint.l1,
+            attestations: calldataCheckpoint.attestations
+        });
+        this.instrumentation.processCheckpointPromoted();
+        return promotedCheckpoint;
+    }
     async checkForNewCheckpointsBeforeL1SyncPoint(status, blocksSynchedTo, currentL1BlockNumber) {
         const { lastRetrievedCheckpoint, pendingCheckpointNumber } = status;
         // Compare the last checkpoint we have (either retrieved in this round or loaded from store) with what the

package/dest/modules/validation.d.ts

@@ -14,4 +14,4 @@ export declare function getAttestationInfoFromPublishedCheckpoint({ checkpoint,
  * Returns true if the attestations are valid and sufficient, false otherwise.
  */
 export declare function validateCheckpointAttestations(publishedCheckpoint: PublishedCheckpoint, epochCache: EpochCache, constants: Pick<L1RollupConstants, 'epochDuration'>, logger?: Logger): Promise<ValidateCheckpointResult>;
-//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoidmFsaWRhdGlvbi5kLnRzIiwic291cmNlUm9vdCI6IiIsInNvdXJjZXMiOlsiLi4vLi4vc3JjL21vZHVsZXMvdmFsaWRhdGlvbi50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFBQSxPQUFPLEtBQUssRUFBRSxVQUFVLEVBQUUsTUFBTSxvQkFBb0IsQ0FBQztBQUdyRCxPQUFPLEtBQUssRUFBRSxNQUFNLEVBQUUsTUFBTSx1QkFBdUIsQ0FBQztBQUNwRCxPQUFPLEVBQ0wsS0FBSyxlQUFlLEVBRXBCLEtBQUssd0JBQXdCLEVBRTlCLE1BQU0scUJBQXFCLENBQUM7QUFDN0IsT0FBTyxLQUFLLEVBQUUsbUJBQW1CLEVBQUUsTUFBTSwwQkFBMEIsQ0FBQztBQUNwRSxPQUFPLEVBQUUsS0FBSyxpQkFBaUIsRUFBa0IsTUFBTSw2QkFBNkIsQ0FBQztBQUdyRixZQUFZLEVBQUUsd0JBQXdCLEVBQUUsQ0FBQztBQUV6Qzs7O0dBR0c7QUFDSCx3QkFBZ0IseUNBQXlDLENBQUMsRUFDeEQsVUFBVSxFQUNWLFlBQVksRUFDYixFQUFFLG1CQUFtQixHQUFHLGVBQWUsRUFBRSxDQUd6QztBQUVEOzs7R0FHRztBQUNILHdCQUFzQiw4QkFBOEIsQ0FDbEQsbUJBQW1CLEVBQUUsbUJBQW1CLEVBQ3hDLFVBQVUsRUFBRSxVQUFVLEVBQ3RCLFNBQVMsRUFBRSxJQUFJLENBQUMsaUJBQWlCLEVBQUUsZUFBZSxDQUFDLEVBQ25ELE1BQU0sQ0FBQyxFQUFFLE1BQU0sR0FDZCxPQUFPLENBQUMsd0JBQXdCLENBQUMsQ0EyRm5DIn0=
+//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoidmFsaWRhdGlvbi5kLnRzIiwic291cmNlUm9vdCI6IiIsInNvdXJjZXMiOlsiLi4vLi4vc3JjL21vZHVsZXMvdmFsaWRhdGlvbi50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFBQSxPQUFPLEtBQUssRUFBRSxVQUFVLEVBQUUsTUFBTSxvQkFBb0IsQ0FBQztBQUdyRCxPQUFPLEtBQUssRUFBRSxNQUFNLEVBQUUsTUFBTSx1QkFBdUIsQ0FBQztBQUNwRCxPQUFPLEVBQ0wsS0FBSyxlQUFlLEVBRXBCLEtBQUssd0JBQXdCLEVBRTlCLE1BQU0scUJBQXFCLENBQUM7QUFDN0IsT0FBTyxLQUFLLEVBQUUsbUJBQW1CLEVBQUUsTUFBTSwwQkFBMEIsQ0FBQztBQUNwRSxPQUFPLEVBQUUsS0FBSyxpQkFBaUIsRUFBaUMsTUFBTSw2QkFBNkIsQ0FBQztBQUdwRyxZQUFZLEVBQUUsd0JBQXdCLEVBQUUsQ0FBQztBQUV6Qzs7O0dBR0c7QUFDSCx3QkFBZ0IseUNBQXlDLENBQUMsRUFDeEQsVUFBVSxFQUNWLFlBQVksRUFDYixFQUFFLG1CQUFtQixHQUFHLGVBQWUsRUFBRSxDQUd6QztBQUVEOzs7R0FHRztBQUNILHdCQUFzQiw4QkFBOEIsQ0FDbEQsbUJBQW1CLEVBQUUsbUJBQW1CLEVBQ3hDLFVBQVUsRUFBRSxVQUFVLEVBQ3RCLFNBQVMsRUFBRSxJQUFJLENBQUMsaUJBQWlCLEVBQUUsZUFBZSxDQUFDLEVBQ25ELE1BQU0sQ0FBQyxFQUFFLE1BQU0sR0FDZCxPQUFPLENBQUMsd0JBQXdCLENBQUMsQ0EyRm5DIn0=

package/dest/modules/validation.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"validation.d.ts","sourceRoot":"","sources":["../../src/modules/validation.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,oBAAoB,CAAC;AAGrD,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,uBAAuB,CAAC;AACpD,OAAO,EACL,KAAK,eAAe,EAEpB,KAAK,wBAAwB,EAE9B,MAAM,qBAAqB,CAAC;AAC7B,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,0BAA0B,CAAC;AACpE,OAAO,EAAE,KAAK,iBAAiB,EAAkB,MAAM,6BAA6B,CAAC;AAGrF,YAAY,EAAE,wBAAwB,EAAE,CAAC;AAEzC;;;GAGG;AACH,wBAAgB,yCAAyC,CAAC,EACxD,UAAU,EACV,YAAY,EACb,EAAE,mBAAmB,GAAG,eAAe,EAAE,CAGzC;AAED;;;GAGG;AACH,wBAAsB,8BAA8B,CAClD,mBAAmB,EAAE,mBAAmB,EACxC,UAAU,EAAE,UAAU,EACtB,SAAS,EAAE,IAAI,CAAC,iBAAiB,EAAE,eAAe,CAAC,EACnD,MAAM,CAAC,EAAE,MAAM,GACd,OAAO,CAAC,wBAAwB,CAAC,CA2FnC"}
+{"version":3,"file":"validation.d.ts","sourceRoot":"","sources":["../../src/modules/validation.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,oBAAoB,CAAC;AAGrD,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,uBAAuB,CAAC;AACpD,OAAO,EACL,KAAK,eAAe,EAEpB,KAAK,wBAAwB,EAE9B,MAAM,qBAAqB,CAAC;AAC7B,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,0BAA0B,CAAC;AACpE,OAAO,EAAE,KAAK,iBAAiB,EAAiC,MAAM,6BAA6B,CAAC;AAGpG,YAAY,EAAE,wBAAwB,EAAE,CAAC;AAEzC;;;GAGG;AACH,wBAAgB,yCAAyC,CAAC,EACxD,UAAU,EACV,YAAY,EACb,EAAE,mBAAmB,GAAG,eAAe,EAAE,CAGzC;AAED;;;GAGG;AACH,wBAAsB,8BAA8B,CAClD,mBAAmB,EAAE,mBAAmB,EACxC,UAAU,EAAE,UAAU,EACtB,SAAS,EAAE,IAAI,CAAC,iBAAiB,EAAE,eAAe,CAAC,EACnD,MAAM,CAAC,EAAE,MAAM,GACd,OAAO,CAAC,wBAAwB,CAAC,CA2FnC"}

package/dest/modules/validation.js

@@ -1,6 +1,6 @@
 import { compactArray } from '@aztec/foundation/collection';
 import { getAttestationInfoFromPayload } from '@aztec/stdlib/block';
-import { getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
+import { computeQuorum, getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
 import { ConsensusPayload } from '@aztec/stdlib/p2p';
 /**
  * Extracts attestation information from a published checkpoint.
@@ -46,7 +46,7 @@ import { ConsensusPayload } from '@aztec/stdlib/p2p';
             valid: true
         };
     }
-    const requiredAttestationCount = Math.floor(committee.length * 2 / 3) + 1;
+    const requiredAttestationCount = computeQuorum(committee.length);
     const failedValidationResult = (reason)=>({
             valid: false,
             reason,