@atlashub/smartstack-cli 1.11.0 → 1.13.1

package/templates/commands/gitflow/8-review.md

@@ -6,226 +6,100 @@ model: haiku
 
 # Phase 8: REVIEW - Review PR avec checklist
 
-Tu es expert code review .NET/EF Core. Analyse la PR et fournis feedback structure.
+**Argument:** `$ARGUMENTS` = numéro PR (requis)
 
-**Argument:** `$ARGUMENTS` = numero PR ou URL (requis)
-
----
-
-## Detection du provider
-
-```bash
-REMOTE_URL=$(git remote get-url origin 2>/dev/null || echo "")
-
-if [[ "$REMOTE_URL" == *"dev.azure.com"* ]] || [[ "$REMOTE_URL" == *"visualstudio.com"* ]]; then
-  GIT_PROVIDER="azuredevops"
-  if [[ "$REMOTE_URL" =~ dev\.azure\.com/([^/]+)/([^/]+)/_git/([^/]+) ]]; then
-    AZURE_ORG="${BASH_REMATCH[1]}"
-    AZURE_PROJECT="${BASH_REMATCH[2]}"
-    AZURE_REPO="${BASH_REMATCH[3]}"
-  fi
-elif [[ "$REMOTE_URL" == *"github.com"* ]]; then
-  GIT_PROVIDER="github"
-else
-  GIT_PROVIDER="unknown"
-fi
-```
+> **Ref:** Fonction `detect_git_provider()` dans [_shared.md](_shared.md)
 
 ---
 
 ## Chargement PR
 
 ```bash
-if [ "$GIT_PROVIDER" = "azuredevops" ]; then
-  # Recuperer infos PR Azure DevOps
-  az repos pr show --id {number} \
-    --organization "https://dev.azure.com/$AZURE_ORG" \
-    --project "$AZURE_PROJECT"
-
-  # Recuperer les fichiers changes
-  az repos pr diff --id {number} \
-    --organization "https://dev.azure.com/$AZURE_ORG" \
-    --project "$AZURE_PROJECT"
-else
-  # Recuperer infos PR GitHub
-  gh pr view {number} --json title,body,files,commits,reviews,checks
-
-  # Recuperer diff
-  gh pr diff {number}
-fi
+# GitHub
+gh pr view {number} --json title,body,files,commits,reviews,checks
+gh pr diff {number}
+
+# Azure DevOps
+az repos pr show --id {number} --organization "https://dev.azure.com/$AZURE_ORG" --project "$AZURE_PROJECT"
 ```
 
 ---
 
 ## Checklist Review
 
-### 1. Code Quality
+### Code Quality
 
-| Check | Critere | Poids |
+| Check | Critère | Poids |
 |-------|---------|-------|
-| Lisibilite | Noms clairs, structure logique | HIGH |
+| Lisibilité | Noms clairs, structure logique | HIGH |
 | DRY | Pas de duplication | MEDIUM |
-| SOLID | Principes respectes | MEDIUM |
-| Complexite | Methodes < 20 lignes, cyclomatic < 10 | LOW |
+| SOLID | Principes respectés | MEDIUM |
+| Complexité | Méthodes < 20 lignes | LOW |
 
-### 2. Patterns .NET
+### Patterns .NET
 
 | Check | Validation |
 |-------|------------|
 | Async/Await | Pas de `.Result` ou `.Wait()` |
-| Dependency Injection | Pas de `new Service()` |
-| Null handling | `?.` ou `??` ou `required` |
-| Exceptions | Specifiques, pas `catch (Exception)` |
-
-### 3. EF Core (si migrations)
-
-| Check | Validation | Severite |
-|-------|------------|----------|
-| 3 fichiers | Migration + Designer + ModelSnapshot | BLOQUANT |
-| Naming | Convention `{Date}_{Description}` | WARNING |
-| Down() | Methode Down implementee | WARNING |
-| Indexes | Sur colonnes FK et filtres frequents | INFO |
-| Data loss | Pas de DropColumn sans backup | BLOQUANT |
-
-### 4. Tests
-
-| Check | Critere |
-|-------|---------|
-| Coverage | Nouveau code couvert |
-| Naming | `{Method}_Should_{Behavior}_When_{Condition}` |
-| Arrange/Act/Assert | Structure claire |
-| Mocks | Pas de dependances reelles |
-
-### 5. Security
-
-| Check | Pattern a detecter | Severite |
-|-------|-------------------|----------|
-| Secrets | `password`, `apikey`, `secret` hardcodes | BLOQUANT |
-| SQL Injection | String concat dans queries | BLOQUANT |
-| XSS | `@Html.Raw()` sans sanitization | HIGH |
-| Auth | `[AllowAnonymous]` sur endpoints sensibles | HIGH |
+| DI | Pas de `new Service()` |
+| Null | `?.` ou `??` ou `required` |
+| Exceptions | Spécifiques, pas `catch (Exception)` |
 
----
+### EF Core (si migrations)
 
-## Analyse automatique
+| Check | Sévérité |
+|-------|----------|
+| 3 fichiers complets | BLOQUANT |
+| Naming convention | WARNING |
+| Down() implémenté | WARNING |
+| Pas de DropColumn sans backup | BLOQUANT |
 
-### Fichiers a examiner en priorite
+### Security
 
-| Priorite | Type | Raison |
-|----------|------|--------|
-| 1 | `*Migration*.cs` | Impact base de donnees |
-| 2 | `*Controller*.cs` | Surface d'attaque |
-| 3 | `*Service*.cs` | Logique metier |
-| 4 | `*.razor` | UI et securite XSS |
-| 5 | Tests | Qualite couverture |
+| Pattern | Sévérité |
+|---------|----------|
+| Secrets hardcodés | BLOQUANT |
+| SQL Injection | BLOQUANT |
+| `@Html.Raw()` sans sanitization | HIGH |
+| `[AllowAnonymous]` sur sensible | HIGH |
 
-### Metriques
+---
 
-```
-METRIQUES PR
-────────────────────────────────
-Fichiers:    {count} (+{added}/-{removed})
-Commits:     {count}
-Insertions:  +{lines}
-Deletions:   -{lines}
-
-Ratio tests: {test_files}/{total_files}
-────────────────────────────────
-```
+## Priorité fichiers
 
----
+1. `*Migration*.cs` - Impact DB
+2. `*Controller*.cs` - Surface d'attaque
+3. `*Service*.cs` - Logique métier
+4. Tests - Couverture
 
-## Output Review
+---
 
-### Format
+## Output
 
 ```
 CODE REVIEW - PR #{number}
-════════════════════════════════════════
-
-RESUME: {APPROVE | CHANGES_REQUESTED | COMMENT}
+RÉSUMÉ: {APPROVE | CHANGES_REQUESTED}
 
-BLOQUANTS ({count}):
+BLOQUANTS:
 🔴 [{file}:{line}] {description}
-   Suggestion: {fix}
 
-WARNINGS ({count}):
+WARNINGS:
 🟡 [{file}:{line}] {description}
-   Suggestion: {fix}
-
-SUGGESTIONS ({count}):
-🟢 [{file}:{line}] {description}
 
 POINTS POSITIFS:
-✨ {ce qui est bien fait}
-
-════════════════════════════════════════
-```
-
-### Soumission review
-
-#### GitHub
-
-```bash
-if [ "$GIT_PROVIDER" = "github" ]; then
-  # Approve
-  gh pr review {number} --approve --body "{comments}"
-
-  # Request changes
-  gh pr review {number} --request-changes --body "{comments}"
-
-  # Comment only
-  gh pr review {number} --comment --body "{comments}"
-fi
+✨ {ce qui est bien}
 ```
 
-#### Azure DevOps
+### Soumission
 
 ```bash
-if [ "$GIT_PROVIDER" = "azuredevops" ]; then
-  # Azure DevOps utilise un systeme de vote:
-  # 10 = Approved, 5 = Approved with suggestions, 0 = No vote, -5 = Waiting, -10 = Rejected
-
-  # Approve
-  az repos pr set-vote --id {number} --vote approve \
-    --organization "https://dev.azure.com/$AZURE_ORG" \
-    --project "$AZURE_PROJECT"
-
-  # Request changes (reject)
-  az repos pr set-vote --id {number} --vote reject \
-    --organization "https://dev.azure.com/$AZURE_ORG" \
-    --project "$AZURE_PROJECT"
-
-  # Ajouter commentaire
-  az repos pr comment create --id {number} \
-    --content "{comments}" \
-    --organization "https://dev.azure.com/$AZURE_ORG" \
-    --project "$AZURE_PROJECT"
-fi
-```
+# GitHub
+gh pr review {number} --approve --body "{comments}"
+gh pr review {number} --request-changes --body "{comments}"
 
-> **Note Azure DevOps:** Les votes possibles sont: `approve`, `approve-with-suggestions`, `reset`, `wait-for-author`, `reject`
-
----
-
-## Resume
-
-```
-REVIEW COMPLETE
-────────────────────────────────
-PR:       #{number}
-Status:   {APPROVED|CHANGES_REQUESTED|COMMENTED}
-
-Issues:
-  Bloquants:   {count}
-  Warnings:    {count}
-  Suggestions: {count}
-
-EF Core: {OK|ISSUES|N/A}
-Tests:   {COVERED|MISSING|N/A}
-Security: {OK|ISSUES}
-────────────────────────────────
-Prochain: /gitflow:9-merge #{number}
+# Azure DevOps
+az repos pr set-vote --id {number} --vote approve
+az repos pr set-vote --id {number} --vote reject
 ```
 
 ---
@@ -235,6 +109,5 @@ Prochain: /gitflow:9-merge #{number}
 | Commande | Action |
 |----------|--------|
 | `/gitflow:8-review 123` | Review PR #123 |
-| `/gitflow:8-review --security` | Focus securite |
-| `/gitflow:8-review --ef-core` | Focus migrations |
+| `/gitflow:8-review --security` | Focus sécurité |
 | `/gitflow:8-review --quick` | Checklist rapide |