@atlashub/smartstack-cli 1.11.0 → 1.13.1

package/templates/commands/efcore/squash.md

@@ -4,76 +4,86 @@ agent: efcore-squash
 model: sonnet
 ---
 
-# EF Core Squash - Consolidate Migrations
+# EF Core Squash
 
-Merges multiple migrations into a single consolidated migration using EF Core CLI only.
-
-**USAGE:** Before creating a release branch to clean up migration history.
-
-**WARNING:** This operation is **DESTRUCTIVE**. Migration history will be lost.
+> **Ref:** [_shared.md](_shared.md) - `determine_base_branch()`, `detect_efcore_project()`
+> **Usage:** Consolider migrations avant merge ou release
+> **WARNING:** DESTRUCTIF - historique migrations perdu
 
 ---
 
-## RÈGLES DE CONFORMITÉ (OBLIGATOIRE)
+## Conformité
 
-> **INTERDIT - Violations CLAUDE.md:**
-> - ❌ Génération de scripts SQL dans le repository (`./scripts/migrations/*.sql`)
-> - ❌ Fichiers .sql versionnés dans Git
-> - ❌ `migrationBuilder.Sql()` avec SQL brut
->
-> **OBLIGATOIRE - Méthodes autorisées:**
-> - ✅ `dotnet ef migrations add` pour créer la migration consolidée
-> - ✅ `dotnet ef migrations remove` pour supprimer les anciennes
-> - ✅ Backup des fichiers .cs dans `.claude/gitflow/backup/` (non versionné)
->
-> **Contact support:** support@atlshub.ch
+| INTERDIT | OBLIGATOIRE |
+|----------|-------------|
+| Scripts .sql dans repo | `dotnet ef migrations add` |
+| `migrationBuilder.Sql()` brut | `dotnet ef migrations remove` |
+| Squash sans récupérer snapshot parent | Backup dans `.claude/` (gitignored) |
 
 ---
 
-## STEP 1: Check prerequisites
+## STEP 0: Déterminer Branche Parente (CRITIQUE)
 
 ```bash
-# Check branch
-CURRENT_BRANCH=$(git branch --show-current)
-echo "Current branch: $CURRENT_BRANCH"
+determine_base_branch  # Voir _shared.md
 
-# Check clean state
-if [ -n "$(git status --porcelain)" ]; then
-  echo "ERROR: Working directory not clean"
-  exit 1
-fi
+# Résultat:
+# - BASE_BRANCH = branche parente (develop, main, etc.)
+# - BRANCH_TYPE = type de branche courante
+# - Exit si main/master (BLOQUÉ)
+```
 
-# Find EF Core projects
-STARTUP_PROJECT=$(find . -name "*.Api.csproj" -o -name "*Web.csproj" | head -1)
-INFRA_PROJECT=$(find . -name "*Infrastructure.csproj" | head -1)
+| Branche courante | BASE_BRANCH | Action |
+|------------------|-------------|--------|
+| `feature/*` | `develop` | Récupère snapshot develop |
+| `develop` | `main` | Récupère snapshot main |
+| `release/*` | `main` | Récupère snapshot main |
+| `hotfix/*` | `main` | Récupère snapshot main |
+| `main/master` | **BLOQUÉ** | Exit code 1 |
 
-if [ -z "$INFRA_PROJECT" ]; then
-  INFRA_PROJECT=$(find . -name "*.csproj" -exec grep -l "Microsoft.EntityFrameworkCore" {} \; | head -1)
-fi
+---
 
-PROJECT_DIR=$(dirname "$INFRA_PROJECT")
-MIGRATIONS_DIR="$PROJECT_DIR/Migrations"
+## STEP 1: Vérifier Prérequis
 
-# List migrations
-ALL_MIGRATIONS=$(find "$MIGRATIONS_DIR" -name "*.cs" 2>/dev/null | grep -v "Designer" | grep -v "Snapshot" | sort)
-MIGRATION_COUNT=$(echo "$ALL_MIGRATIONS" | grep -c "." || echo "0")
+```bash
+CURRENT_BRANCH=$(git branch --show-current)
+[ -n "$(git status --porcelain)" ] && { echo "Working directory non propre"; exit 1; }
+detect_efcore_project
+
+# Compter migrations LOCALES uniquement (pas celles héritées)
+git fetch origin "$BASE_BRANCH" --quiet
+BASE_MIGRATIONS=$(git ls-tree -r --name-only "origin/$BASE_BRANCH" -- "$MIGRATIONS_DIR" | grep "\.cs$" | grep -v "Designer\|Snapshot")
+LOCAL_MIGRATIONS=$(find "$MIGRATIONS_DIR" -name "*.cs" | grep -v "Designer\|Snapshot" | xargs -I{} basename {})
+
+# Migrations propres à cette branche
+BRANCH_ONLY_MIGRATIONS=()
+for mig in $LOCAL_MIGRATIONS; do
+  echo "$BASE_MIGRATIONS" | grep -q "$mig" || BRANCH_ONLY_MIGRATIONS+=("$mig")
+done
 
-echo "Migrations found: $MIGRATION_COUNT"
-echo "Project directory: $PROJECT_DIR"
+MIGRATION_COUNT=${#BRANCH_ONLY_MIGRATIONS[@]}
+echo "Migrations à consolider: $MIGRATION_COUNT (propres à $CURRENT_BRANCH)"
+echo "Branche parente: $BASE_BRANCH"
 ```
 
 ---
 
-## STEP 2: Request confirmation
+## STEP 2: Confirmation Utilisateur
 
 ```javascript
 AskUserQuestion({
   questions: [{
-    question: "You are about to merge " + MIGRATION_COUNT + " migrations into one. This operation is DESTRUCTIVE. Continue?",
+    question: `Squash ${MIGRATION_COUNT} migrations de ${CURRENT_BRANCH}?
+
+Le ModelSnapshot de ${BASE_BRANCH} sera récupéré comme base.
+Vos migrations seront consolidées en UNE seule.
+
+Cette opération est DESTRUCTIVE et IRRÉVERSIBLE (sauf backup).`,
     header: "Squash",
     options: [
-      { label: "Yes, squash all", description: "Merge all migrations into one" },
-      { label: "Cancel", description: "Do nothing" }
+      { label: "Oui, squash", description: `Consolider sur base de ${BASE_BRANCH}` },
+      { label: "Voir détails", description: "Afficher migrations concernées" },
+      { label: "Annuler", description: "Ne rien faire" }
     ],
     multiSelect: false
   }]
@@ -82,221 +92,115 @@ AskUserQuestion({
 
 ---
 
-## STEP 3: Full backup (local only - NOT in repository)
+## STEP 3: Backup Local
 
 ```bash
-# Create backup in .claude directory (gitignored)
 BACKUP_DIR=".claude/gitflow/backup/migrations/squash_$(date +%Y%m%d_%H%M%S)"
 mkdir -p "$BACKUP_DIR"
-
-echo "Backup to $BACKUP_DIR (local only, not in Git)"
-cp "$MIGRATIONS_DIR"/*.cs "$BACKUP_DIR/" 2>/dev/null
-echo "  $(ls -1 "$BACKUP_DIR" | wc -l) files backed up"
-
-# Keep ModelSnapshot for reference
-cp "$MIGRATIONS_DIR"/*ModelSnapshot.cs "$BACKUP_DIR/ModelSnapshot_backup.cs" 2>/dev/null
+cp "$MIGRATIONS_DIR"/*.cs "$BACKUP_DIR/"
+echo "Backup: $BACKUP_DIR"
 ```
 
 ---
 
-## STEP 4: Delete all migrations
+## STEP 4: Récupérer ModelSnapshot de la Branche Parente (CRUCIAL)
 
 ```bash
-echo "Deleting migrations..."
+# Sauvegarder snapshot actuel
+cp "$MIGRATIONS_DIR"/*ModelSnapshot.cs "$BACKUP_DIR/"
 
-# Delete all migration files (except ModelSnapshot)
-for file in $(find "$MIGRATIONS_DIR" -name "*.cs" -not -name "*ModelSnapshot.cs" 2>/dev/null); do
-  rm -f "$file"
-  echo "  - $(basename "$file")"
-done
+# Récupérer le snapshot de la branche parente
+git fetch origin "$BASE_BRANCH" --quiet
+git checkout "origin/$BASE_BRANCH" -- "$MIGRATIONS_DIR"/*ModelSnapshot.cs
 
-# Also delete Designer files
-for file in $(find "$MIGRATIONS_DIR" -name "*.Designer.cs" 2>/dev/null); do
-  rm -f "$file"
-  echo "  - $(basename "$file")"
-done
+echo "ModelSnapshot récupéré depuis: origin/$BASE_BRANCH"
 ```
 
+**Pourquoi c'est crucial:**
+- Le snapshot de `$BASE_BRANCH` contient l'état VALIDÉ et COMPLET
+- Les migrations parallèles sur d'autres branches sont incluses
+- Évite la perte d'information de schéma (cf. [Bokio best practices](https://www.bokio.se/engineering-blog/how-to-squash-ef-core-migrations/))
+
 ---
 
-## STEP 5: Create consolidated migration
+## STEP 5: Supprimer Migrations de la Branche (pas celles héritées)
 
 ```bash
-# Version
-VERSION=$(grep -oP '(?<=<Version>).*(?=</Version>)' "$INFRA_PROJECT" 2>/dev/null | head -1 || echo "1.0.0")
-VERSION_CLEAN=$(echo "$VERSION" | sed 's/\./_/g')
+# Supprimer UNIQUEMENT les migrations propres à cette branche
+for mig in "${BRANCH_ONLY_MIGRATIONS[@]}"; do
+  rm -f "$MIGRATIONS_DIR"/${mig%.cs}.cs
+  rm -f "$MIGRATIONS_DIR"/${mig%.cs}.Designer.cs
+done
+
+echo "Supprimé: ${#BRANCH_ONLY_MIGRATIONS[@]} migrations"
+```
+
+---
 
-# Migration name
-if [[ "$CURRENT_BRANCH" == release/* ]]; then
-  MIGRATION_NAME="Release_${VERSION_CLEAN}_Initial"
-else
-  MIGRATION_NAME="Consolidated_${VERSION_CLEAN}_AllMigrations"
-fi
+## STEP 6: Créer Migration Consolidée
 
-echo ""
-echo "Creating consolidated migration: $MIGRATION_NAME"
+```bash
+# Nommage selon contexte
+case "$BRANCH_TYPE" in
+  feature)
+    BRANCH_NAME=$(echo "$CURRENT_BRANCH" | sed 's|feature/||')
+    MIGRATION_NAME="Feature_${BRANCH_NAME}_Consolidated"
+    ;;
+  release)
+    VERSION=$(echo "$CURRENT_BRANCH" | sed 's|release/||' | tr '.' '_')
+    MIGRATION_NAME="Release_${VERSION}_Initial"
+    ;;
+  hotfix)
+    VERSION=$(echo "$CURRENT_BRANCH" | sed 's|hotfix/||' | tr '.' '_')
+    MIGRATION_NAME="Hotfix_${VERSION}_Fix"
+    ;;
+  develop)
+    MIGRATION_NAME="Develop_Consolidated_$(date +%Y%m%d)"
+    ;;
+  *)
+    MIGRATION_NAME="Consolidated_$(date +%Y%m%d_%H%M%S)"
+    ;;
+esac
 
 dotnet ef migrations add "$MIGRATION_NAME" \
   --project "$INFRA_PROJECT" \
   --startup-project "$STARTUP_PROJECT" \
   --verbose
-
-if [ $? -eq 0 ]; then
-  echo "  Migration created successfully"
-else
-  echo "  ERROR - restoring backup"
-  cp "$BACKUP_DIR"/*.cs "$MIGRATIONS_DIR/"
-  exit 1
-fi
 ```
 
 ---
 
-## STEP 6: Validation (NO SQL script generation)
+## STEP 7: Validation
 
 ```bash
-echo ""
-echo "Validation..."
-
 # Build
 dotnet build --no-restore
-if [ $? -ne 0 ]; then
-  echo "  ERROR: Build failed"
-  echo "  Restoring backup..."
-  cp "$BACKUP_DIR"/*.cs "$MIGRATIONS_DIR/"
-  exit 1
-fi
-echo "  Build OK"
-
-# Verify migration can be listed
-dotnet ef migrations list \
-  --project "$INFRA_PROJECT" \
-  --startup-project "$STARTUP_PROJECT" \
-  --no-build 2>/dev/null
-
-if [ $? -ne 0 ]; then
-  echo "  ERROR: Migration list failed"
-  exit 1
-fi
-echo "  Migration list OK"
-```
-
----
-
-## STEP 7: Resume
+[ $? -ne 0 ] && { echo "Build FAILED - restauration backup"; cp "$BACKUP_DIR"/*.cs "$MIGRATIONS_DIR/"; exit 1; }
 
-**Afficher un resume apres le squash:**
+# Liste migrations
+dotnet ef migrations list --no-build
 
+# Générer script (validation)
+dotnet ef migrations script --no-build --idempotent > /dev/null
+[ $? -ne 0 ] && { echo "Script generation FAILED"; exit 1; }
 ```
-===============================================================================
-                         MIGRATIONS CONSOLIDÉES
-===============================================================================
 
-DÉTAILS
--------------------------------------------------------------------------------
-  • Branche:      {current_branch}
-  • Backup:       {backup_dir} (local uniquement)
-
-AVANT LE SQUASH
--------------------------------------------------------------------------------
-  • Migrations:   {old_count} fichiers
-
-APRÈS LE SQUASH
--------------------------------------------------------------------------------
-  • Migration:    {migration_name}
-
-VALIDATIONS
--------------------------------------------------------------------------------
-  ✓ Migrations fusionnées avec succès
-  ✓ Build vérifié
-  ✓ Liste des migrations valide
-
-CONFORMITÉ
--------------------------------------------------------------------------------
-  ✓ EF Core CLI uniquement
-  ✓ Pas de scripts SQL dans le repository
-
-===============================================================================
-                    DÉPLOIEMENT EN PRODUCTION
-===============================================================================
-
-OPTION 1 - EF Core CLI (Recommandé):
--------------------------------------------------------------------------------
-dotnet ef database update {migration_name} \
-  --project "{INFRA_PROJECT}" \
-  --startup-project "{STARTUP_PROJECT}" \
-  --connection "Server=...;Database=...;..."
-
-OPTION 2 - Si les migrations sont déjà appliquées:
--------------------------------------------------------------------------------
-Insérer manuellement dans __EFMigrationsHistory via SSMS/Azure:
-
-INSERT INTO __EFMigrationsHistory (MigrationId, ProductVersion)
-VALUES ('{migration_name}', '10.0.0')
-
-⚠️  NE PAS générer de scripts SQL dans le repository!
-
-===============================================================================
-                         PROCHAINES ÉTAPES
-===============================================================================
-
-1. Vérifier le contenu de la migration consolidée:
-   Ouvrir Migrations/{migration_name}.cs
-
-2. Tester sur la base de développement:
-   /efcore:db-reset
-   /efcore:db-deploy
-
-3. Committer les changements:
-   /gitflow:3-commit
-
-===============================================================================
-                         RESTAURATION (si nécessaire)
-===============================================================================
-
-Si le squash a causé des problèmes, restaurez le backup:
+---
 
-   cp {backup_dir}/*.cs {migrations_dir}/
+## Résumé
 
-===============================================================================
 ```
-
-**Si le squash échoue:**
-
+SQUASH - {CURRENT_BRANCH}
+  Base:       {BASE_BRANCH} (snapshot récupéré)
+  Backup:     {BACKUP_DIR}
+  Avant:      {MIGRATION_COUNT} migrations
+  Apres:      1 migration ({MIGRATION_NAME})
+  Conformite: EF Core CLI, Pas de .sql, Snapshot parent
+
+Prochains: /efcore:db-reset, /efcore:db-deploy, /gitflow:3-commit
 ```
-===============================================================================
-                    ÉCHEC DU SQUASH
-===============================================================================
-
-ERREUR
--------------------------------------------------------------------------------
-  ✗ {error_message}
-
-DÉTAILS
--------------------------------------------------------------------------------
-  • Branche:      {current_branch}
-  • Backup:       {backup_dir}
-
-RESTAURATION AUTOMATIQUE
--------------------------------------------------------------------------------
-  ✓ Backup restauré automatiquement
-  ✓ Migrations originales récupérées
-
-===============================================================================
-                         ACTIONS SUGGÉRÉES
-===============================================================================
-
-1. Vérifier les erreurs de build:
-   dotnet build
 
-2. Vérifier le ModelSnapshot:
-   /efcore:conflicts
-
-3. Si problème persistant:
-   support@atlshub.ch
-
-===============================================================================
-```
+**Si échec:** Restaurer avec `cp $BACKUP_DIR/*.cs $MIGRATIONS_DIR/`
 
 ---
 
@@ -304,51 +208,54 @@ RESTAURATION AUTOMATIQUE
 
 | Option | Description |
 |--------|-------------|
-| `--no-backup` | Don't create backup (dangerous) |
-| `--name <name>` | Force a migration name |
-| `--keep-snapshot` | Keep current ModelSnapshot |
-| `--dry-run` | Show without executing |
+| `--no-backup` | Sans backup (dangereux) |
+| `--name <name>` | Forcer nom migration |
+| `--dry-run` | Afficher sans exécuter |
+| `--include-inherited` | Inclure migrations héritées (rare) |
 
 ---
 
-## When to use Squash
+## Matrice d'Utilisation
 
-| Situation | Use Squash? |
-|-----------|-------------|
-| Before release | YES - clean up history |
-| After merging multiple features | YES - consolidate |
-| In production | NO - use EF Core CLI directly |
-| Feature branch in progress | CAUTION - prefer rebase-snapshot |
+| Situation | Utiliser squash? | Alternative |
+|-----------|------------------|-------------|
+| Feature avec plusieurs migrations | OUI | `/efcore:rebase-snapshot` |
+| Avant merge feature vers develop | OUI (recommandé) | - |
+| Sur develop avant release | Créer release d'abord | `/gitflow:10-start release` |
+| Sur release avant tag | OUI (idéal) | - |
+| Hotfix urgent | OUI | - |
+| Sur main/master | **JAMAIS** | BLOQUÉ automatiquement |
 
 ---
 
-## Forbidden Patterns
+## Workflow Complet Recommandé
 
 ```
-❌ INTERDIT - Ne jamais faire:
-────────────────────────────────────────────────────────────────────────────────
-# Génération de script SQL dans le repo
-dotnet ef migrations script -o ./scripts/migrations/*.sql
-
-# Stockage de fichiers .sql versionnés
-./scripts/migrations/Release_1_0_0.sql
-./scripts/seed.sql
-────────────────────────────────────────────────────────────────────────────────
-
-✅ CORRECT - Toujours utiliser:
-────────────────────────────────────────────────────────────────────────────────
-# EF Core CLI pour déploiement
-dotnet ef database update
-
-# Backup local uniquement (gitignored)
-.claude/gitflow/backup/migrations/
-────────────────────────────────────────────────────────────────────────────────
+1. feature/* : développement avec N migrations
+
+2. Avant merge sur develop:
+   /efcore:squash
+   → Récupère snapshot develop
+   → Consolide en 1 migration
+
+3. Merge sur develop:
+   /gitflow:7-pull-request
+   /gitflow:9-merge
+
+4. Avant release:
+   /gitflow:10-start release vX.Y.Z
+   /efcore:squash (sur release/*)
+   → Récupère snapshot main
+   → Consolide TOUT en Release_X_Y_Z_Initial
+
+5. Finaliser:
+   /gitflow:11-finish
 ```
 
 ---
 
-## Support
+## Sources Best Practices
 
-> **Questions ou problèmes avec le squash EF Core?**
->
-> 📧 **support@atlshub.ch**
+- [Microsoft - Managing Migrations](https://learn.microsoft.com/en-us/ef/core/managing-schemas/migrations/managing)
+- [Bokio - How to squash EF Core migrations](https://www.bokio.se/engineering-blog/how-to-squash-ef-core-migrations/)
+- [Mitchel Sellers - Squashing EF Core Migrations Safely](https://www.mitchelsellers.com/blog/article/squashing-ef-core-migrations-safely)