@asterxsk/kiln 0.3.0 → 0.4.2

package/agent/extensions/todo/todo.ts

@@ -1,155 +1,155 @@
-/**
- * todo tool + /todos command — thin registration shell.
- *
- * Tool/command identity, schema, types, reducer, store, replay, response
- * envelope, selectors, and view formatters live in the layered modules under
- * `tool/`, `state/`, and `view/`. This file is the package-root registration
- * surface — it mirrors `packages/rpiv-ask-user-question/ask-user-question.ts`
- * which keeps the tool registration at the package root.
- *
- * Public re-exports below preserve the pre-refactor import surface so that
- * `index.ts`, `todo-overlay.ts`, and the global `test/setup.ts` `beforeEach`
- * continue to import from `./todo.js`.
- */
-
-import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
-import { Text } from "@earendil-works/pi-tui";
-import { loadConfig, validateGuidanceFields } from "./config.js";
-import { formatStatusLabel, t } from "./state/i18n-bridge.js";
-import { replayFromBranch } from "./state/replay.js";
-import { selectTasksByStatus, selectTodoCounts, selectVisibleTasks } from "./state/selectors.js";
-import { applyTaskMutation } from "./state/state-reducer.js";
-import { commitState, getState, replaceState } from "./state/store.js";
-import { buildToolResult } from "./tool/response-envelope.js";
-import {
-	COMMAND_NAME,
-	ERR_REQUIRES_INTERACTIVE,
-	MSG_NO_TODOS,
-	type TaskMutationParams,
-	TOOL_LABEL,
-	TOOL_NAME,
-	TodoParamsSchema,
-} from "./tool/types.js";
-import { formatCommandTaskLine, renderTodoCall, renderTodoResult } from "./view/format.js";
-
-// English fallbacks for localized /todos section headers — the box-drawing
-// decoration is part of the localized string so translators can adjust spacing.
-const SECTION_PENDING = "── Pending ──";
-const SECTION_IN_PROGRESS = "── In Progress ──";
-const SECTION_COMPLETED = "── Completed ──";
-
-// ---------------------------------------------------------------------------
-// Public re-exports — pre-refactor consumers (overlay, tests, index.ts) keep
-// importing from `./todo.js`. New code may opt into deeper imports.
-// ---------------------------------------------------------------------------
-
-export { isTransitionValid } from "./state/invariants.js";
-export { applyTaskMutation } from "./state/state-reducer.js";
-export { __resetState, getNextId, getTodos } from "./state/store.js";
-
-/** Resolve the session id that scopes todo state for this ctx. */
-export function sessionIdOf(ctx: { sessionManager: { getSessionId(): string } }): string {
-	return ctx.sessionManager.getSessionId();
-}
-export { deriveBlocks, detectCycle } from "./state/task-graph.js";
-export type { Task, TaskAction, TaskDetails, TaskStatus } from "./tool/types.js";
-export { TOOL_NAME } from "./tool/types.js";
-
-/**
- * Backward-compat replay shim. Pre-refactor `reconstructTodoState(ctx)`
- * mutated module state directly; the new replay seam (`state/replay.ts`)
- * returns a `TaskState` and the caller commits via `replaceState`.
- */
-export function reconstructTodoState(
-	ctx: Parameters<typeof replayFromBranch>[0] & { sessionManager: { getSessionId(): string } },
-): void {
-	replaceState(sessionIdOf(ctx), replayFromBranch(ctx));
-}
-
-// ---------------------------------------------------------------------------
-// Tool registration
-// ---------------------------------------------------------------------------
-
-export const DEFAULT_PROMPT_SNIPPET = "Manage a task list to track multi-step progress";
-export const DEFAULT_PROMPT_GUIDELINES: string[] = [
-	"Use `todo` for multi-step work (3+ steps), a user task list, or right after new instructions. Skip for trivial/single tasks and chit-chat.",
-	"Mark in_progress BEFORE work; mark completed IMMEDIATELY when done (never batch). Exactly one in_progress at a time. Never complete if tests fail or work is partial — keep in_progress and add a blocker task. Status: pending→in_progress→completed (+deleted tombstone); pass activeForm when in_progress.",
-	"Use blockedBy for dependencies; on update use addBlockedBy/removeBlockedBy (additive merge, don't resend the full array). Cycles rejected.",
-	"Subject short + imperative; description = long-form detail; activeForm = present-continuous label. list hides deleted by default (includeDeleted:true to show); pass status to filter.",
-	"batch = multiple create/update/delete/clear ops in one call, applied in order; if any fails, all abort. No list/get inside batch.",
-];
-
-export function registerTodoTool(pi: ExtensionAPI): void {
-	const guidance = validateGuidanceFields(loadConfig().guidance);
-	pi.registerTool({
-		name: TOOL_NAME,
-		label: TOOL_LABEL,
-		description:
-			"Manage a task list for multi-step work. Actions: create, update, list, get, delete (tombstone), clear, batch (atomic multi-op). Status: pending→in_progress→completed (+deleted tombstone).",
-		promptSnippet: guidance.promptSnippet ?? DEFAULT_PROMPT_SNIPPET,
-		promptGuidelines: guidance.promptGuidelines ?? DEFAULT_PROMPT_GUIDELINES,
-		parameters: TodoParamsSchema,
-
-		async execute(_toolCallId, params, _signal, _onUpdate, ctx) {
-			const sessionId = sessionIdOf(ctx);
-			const result = applyTaskMutation(getState(sessionId), params.action, params as TaskMutationParams);
-			commitState(sessionId, result.state);
-			return buildToolResult(params.action, params as TaskMutationParams, result.state, result.op);
-		},
-
-		renderShell: "self",
-
-		renderCall() {
-			return new Text("", 0, 0);
-		},
-
-		renderResult() {
-			return new Text("", 0, 0);
-		},
-	});
-}
-
-// ---------------------------------------------------------------------------
-// /todos slash command
-// ---------------------------------------------------------------------------
-
-export function registerTodosCommand(pi: ExtensionAPI): void {
-	pi.registerCommand(COMMAND_NAME, {
-		description: "Show all todos on the current branch, grouped by status",
-		handler: async (_args, ctx) => {
-			if (!ctx.hasUI) {
-				ctx.ui.notify(t("command.requires_interactive", ERR_REQUIRES_INTERACTIVE), "error");
-				return;
-			}
-			const state = getState(ctx.sessionManager.getSessionId());
-			const visible = selectVisibleTasks(state);
-			if (visible.length === 0) {
-				ctx.ui.notify(t("command.no_todos", MSG_NO_TODOS), "info");
-				return;
-			}
-			const groups = selectTasksByStatus(state);
-			const counts = selectTodoCounts(state);
-
-			const header: string[] = [];
-			if (counts.completed > 0) header.push(`${counts.completed}/${counts.total} ${formatStatusLabel("completed")}`);
-			if (counts.inProgress > 0) header.push(`${counts.inProgress} ${formatStatusLabel("in_progress")}`);
-			if (counts.pending > 0) header.push(`${counts.pending} ${formatStatusLabel("pending")}`);
-
-			const lines: string[] = [header.join(" · ")];
-			if (groups.pending.length > 0) {
-				lines.push(t("command.section.pending", SECTION_PENDING));
-				for (const task of groups.pending) lines.push(formatCommandTaskLine(task, "○"));
-			}
-			if (groups.inProgress.length > 0) {
-				lines.push(t("command.section.in_progress", SECTION_IN_PROGRESS));
-				for (const task of groups.inProgress) lines.push(formatCommandTaskLine(task, "◐"));
-			}
-			if (groups.completed.length > 0) {
-				lines.push(t("command.section.completed", SECTION_COMPLETED));
-				for (const task of groups.completed) lines.push(formatCommandTaskLine(task, "✓"));
-			}
-
-			ctx.ui.notify(lines.join("\n"), "info");
-		},
-	});
-}
+/**
+ * todo tool + /todos command — thin registration shell.
+ *
+ * Tool/command identity, schema, types, reducer, store, replay, response
+ * envelope, selectors, and view formatters live in the layered modules under
+ * `tool/`, `state/`, and `view/`. This file is the package-root registration
+ * surface — it mirrors `packages/rpiv-ask-user-question/ask-user-question.ts`
+ * which keeps the tool registration at the package root.
+ *
+ * Public re-exports below preserve the pre-refactor import surface so that
+ * `index.ts`, `todo-overlay.ts`, and the global `test/setup.ts` `beforeEach`
+ * continue to import from `./todo.js`.
+ */
+
+import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
+import { Text } from "@earendil-works/pi-tui";
+import { loadConfig, validateGuidanceFields } from "./config.js";
+import { formatStatusLabel, t } from "./state/i18n-bridge.js";
+import { replayFromBranch } from "./state/replay.js";
+import { selectTasksByStatus, selectTodoCounts, selectVisibleTasks } from "./state/selectors.js";
+import { applyTaskMutation } from "./state/state-reducer.js";
+import { commitState, getState, replaceState } from "./state/store.js";
+import { buildToolResult } from "./tool/response-envelope.js";
+import {
+	COMMAND_NAME,
+	ERR_REQUIRES_INTERACTIVE,
+	MSG_NO_TODOS,
+	type TaskMutationParams,
+	TOOL_LABEL,
+	TOOL_NAME,
+	TodoParamsSchema,
+} from "./tool/types.js";
+import { formatCommandTaskLine, renderTodoCall, renderTodoResult } from "./view/format.js";
+
+// English fallbacks for localized /todos section headers — the box-drawing
+// decoration is part of the localized string so translators can adjust spacing.
+const SECTION_PENDING = "── Pending ──";
+const SECTION_IN_PROGRESS = "── In Progress ──";
+const SECTION_COMPLETED = "── Completed ──";
+
+// ---------------------------------------------------------------------------
+// Public re-exports — pre-refactor consumers (overlay, tests, index.ts) keep
+// importing from `./todo.js`. New code may opt into deeper imports.
+// ---------------------------------------------------------------------------
+
+export { isTransitionValid } from "./state/invariants.js";
+export { applyTaskMutation } from "./state/state-reducer.js";
+export { __resetState, getNextId, getTodos } from "./state/store.js";
+
+/** Resolve the session id that scopes todo state for this ctx. */
+export function sessionIdOf(ctx: { sessionManager: { getSessionId(): string } }): string {
+	return ctx.sessionManager.getSessionId();
+}
+export { deriveBlocks, detectCycle } from "./state/task-graph.js";
+export type { Task, TaskAction, TaskDetails, TaskStatus } from "./tool/types.js";
+export { TOOL_NAME } from "./tool/types.js";
+
+/**
+ * Backward-compat replay shim. Pre-refactor `reconstructTodoState(ctx)`
+ * mutated module state directly; the new replay seam (`state/replay.ts`)
+ * returns a `TaskState` and the caller commits via `replaceState`.
+ */
+export function reconstructTodoState(
+	ctx: Parameters<typeof replayFromBranch>[0] & { sessionManager: { getSessionId(): string } },
+): void {
+	replaceState(sessionIdOf(ctx), replayFromBranch(ctx));
+}
+
+// ---------------------------------------------------------------------------
+// Tool registration
+// ---------------------------------------------------------------------------
+
+export const DEFAULT_PROMPT_SNIPPET = "Manage a task list to track multi-step progress";
+export const DEFAULT_PROMPT_GUIDELINES: string[] = [
+	"Use `todo` for multi-step work (3+ steps), a user task list, or right after new instructions. Skip for trivial/single tasks and chit-chat.",
+	"Mark in_progress BEFORE work; mark completed IMMEDIATELY when done (never batch). Exactly one in_progress at a time. Never complete if tests fail or work is partial — keep in_progress and add a blocker task. Status: pending→in_progress→completed (+deleted tombstone); pass activeForm when in_progress.",
+	"Use blockedBy for dependencies; on update use addBlockedBy/removeBlockedBy (additive merge, don't resend the full array). Cycles rejected.",
+	"Subject short + imperative; description = long-form detail; activeForm = present-continuous label. list hides deleted by default (includeDeleted:true to show); pass status to filter.",
+	"batch = multiple create/update/delete/clear ops in one call, applied in order; if any fails, all abort. No list/get inside batch.",
+];
+
+export function registerTodoTool(pi: ExtensionAPI): void {
+	const guidance = validateGuidanceFields(loadConfig().guidance);
+	pi.registerTool({
+		name: TOOL_NAME,
+		label: TOOL_LABEL,
+		description:
+			"Manage a task list for multi-step work. Actions: create, update, list, get, delete (tombstone), clear, batch (atomic multi-op). Status: pending→in_progress→completed (+deleted tombstone).",
+		promptSnippet: guidance.promptSnippet ?? DEFAULT_PROMPT_SNIPPET,
+		promptGuidelines: guidance.promptGuidelines ?? DEFAULT_PROMPT_GUIDELINES,
+		parameters: TodoParamsSchema,
+
+		async execute(_toolCallId, params, _signal, _onUpdate, ctx) {
+			const sessionId = sessionIdOf(ctx);
+			const result = applyTaskMutation(getState(sessionId), params.action, params as TaskMutationParams);
+			commitState(sessionId, result.state);
+			return buildToolResult(params.action, params as TaskMutationParams, result.state, result.op);
+		},
+
+		renderShell: "self",
+
+		renderCall() {
+			return new Text("", 0, 0);
+		},
+
+		renderResult() {
+			return new Text("", 0, 0);
+		},
+	});
+}
+
+// ---------------------------------------------------------------------------
+// /todos slash command
+// ---------------------------------------------------------------------------
+
+export function registerTodosCommand(pi: ExtensionAPI): void {
+	pi.registerCommand(COMMAND_NAME, {
+		description: "Show all todos on the current branch, grouped by status",
+		handler: async (_args, ctx) => {
+			if (!ctx.hasUI) {
+				ctx.ui.notify(t("command.requires_interactive", ERR_REQUIRES_INTERACTIVE), "error");
+				return;
+			}
+			const state = getState(ctx.sessionManager.getSessionId());
+			const visible = selectVisibleTasks(state);
+			if (visible.length === 0) {
+				ctx.ui.notify(t("command.no_todos", MSG_NO_TODOS), "info");
+				return;
+			}
+			const groups = selectTasksByStatus(state);
+			const counts = selectTodoCounts(state);
+
+			const header: string[] = [];
+			if (counts.completed > 0) header.push(`${counts.completed}/${counts.total} ${formatStatusLabel("completed")}`);
+			if (counts.inProgress > 0) header.push(`${counts.inProgress} ${formatStatusLabel("in_progress")}`);
+			if (counts.pending > 0) header.push(`${counts.pending} ${formatStatusLabel("pending")}`);
+
+			const lines: string[] = [header.join(" · ")];
+			if (groups.pending.length > 0) {
+				lines.push(t("command.section.pending", SECTION_PENDING));
+				for (const task of groups.pending) lines.push(formatCommandTaskLine(task, "○"));
+			}
+			if (groups.inProgress.length > 0) {
+				lines.push(t("command.section.in_progress", SECTION_IN_PROGRESS));
+				for (const task of groups.inProgress) lines.push(formatCommandTaskLine(task, "◐"));
+			}
+			if (groups.completed.length > 0) {
+				lines.push(t("command.section.completed", SECTION_COMPLETED));
+				for (const task of groups.completed) lines.push(formatCommandTaskLine(task, "✓"));
+			}
+
+			ctx.ui.notify(lines.join("\n"), "info");
+		},
+	});
+}

package/agent/extensions/todo/tool/response-envelope.ts

@@ -1,109 +1,109 @@
-import type { TaskState } from "../state/state.js";
-import type { Op } from "../state/state-reducer.js";
-import { deriveBlocks } from "../state/task-graph.js";
-import type { Task, TaskAction, TaskDetails, TaskMutationParams } from "./types.js";
-
-/**
- * Format a single task as a `[status] #id subject [(activeForm)] [⛓ #dep,…]`
- * line. Used by the `list` content branch only — the overlay and `/todos`
- * formatting paths use `view/format.ts` for richer presentations.
- */
-function formatListLine(t: Task): string {
-	const block = t.blockedBy?.length ? ` ⛓ ${t.blockedBy.map((id) => `#${id}`).join(",")}` : "";
-	const form = t.status === "in_progress" && t.activeForm ? ` (${t.activeForm})` : "";
-	return `[${t.status}] #${t.id} ${t.subject}${form}${block}`;
-}
-
-/**
- * Multi-line presentation for the `get` action. Order of rows is pinned by
- * pre-refactor `todo.ts:354-376` — description, activeForm, blockedBy, blocks,
- * owner — so envelope-level snapshot tests stay byte-equivalent.
- */
-function formatGetLines(task: Task, state: TaskState): string {
-	const blocks = deriveBlocks(state.tasks).get(task.id) ?? [];
-	const lines = [`#${task.id} [${task.status}] ${task.subject}`];
-	if (task.description) lines.push(`  description: ${task.description}`);
-	if (task.activeForm) lines.push(`  activeForm: ${task.activeForm}`);
-	if (task.blockedBy?.length) {
-		lines.push(`  blockedBy: ${task.blockedBy.map((id) => `#${id}`).join(", ")}`);
-	}
-	if (blocks.length) {
-		lines.push(`  blocks: ${blocks.map((id) => `#${id}`).join(", ")}`);
-	}
-	if (task.owner) lines.push(`  owner: ${task.owner}`);
-	return lines.join("\n");
-}
-
-/**
- * Pure formatter: `(op, state) → string`. Closed switch on `op.kind` —
- * adding a new `Op` variant fails to compile here until a branch is added.
- * The strings on each branch are byte-equivalent to pre-refactor `todo.ts`
- * reducer output.
- */
-export function formatContent(op: Op, state: TaskState): string {
-	switch (op.kind) {
-		case "create": {
-			const names = op.ids
-				.map((id) => {
-					const t = state.tasks.find((x) => x.id === id);
-					return t ? `#${t.id}: ${t.subject} (pending)` : `#${id}`;
-				})
-				.join(", ");
-			return `Created ${names}`;
-		}
-		case "update": {
-			return op.results
-				.map((r) => {
-					const transition = r.fromStatus !== r.toStatus ? ` (${r.fromStatus} → ${r.toStatus})` : "";
-					return `Updated #${r.id}${transition}`;
-				})
-				.join("\n");
-		}
-		case "delete":
-			return op.items.map((d) => `Deleted #${d.id}: ${d.subject}`).join("\n");
-		case "clear":
-			return `Cleared ${op.count} tasks`;
-		case "list": {
-			let view = state.tasks;
-			if (!op.includeDeleted) view = view.filter((t) => t.status !== "deleted");
-			if (op.statusFilter) view = view.filter((t) => t.status === op.statusFilter);
-			return view.length === 0 ? "No tasks" : view.map(formatListLine).join("\n");
-		}
-		case "get":
-			return op.tasks.map((t) => formatGetLines(t, state)).join("\n");
-		case "batch": {
-			if (op.results.length === 0) return "Batch: 0 operations";
-			const lines = [`Batch: ${op.results.length} operation${op.results.length !== 1 ? "s" : ""}:`];
-			for (const { index, op: sub } of op.results) {
-				lines.push(`  [${index}] ${formatContent(sub, state)}`);
-			}
-			return lines.join("\n");
-		}
-		case "error":
-			return `Error: ${op.message}`;
-	}
-}
-
-/**
- * Build the LLM-facing tool envelope after the store has committed the
- * reducer's new state. `details` is the persistence + replay snapshot —
- * `state/replay.ts` consumes this exact shape on session lifecycle events.
- *
- * Mirrors `packages/rpiv-ask-user-question/tool/response-envelope.ts:13-47`.
- */
-export function buildToolResult(
-	action: TaskAction,
-	params: TaskMutationParams,
-	state: TaskState,
-	op: Op,
-): { content: Array<{ type: "text"; text: string }>; details: TaskDetails } {
-	const text = formatContent(op, state);
-	const details: TaskDetails = {
-		action,
-		params: params as Record<string, unknown>,
-		tasks: state.tasks,
-		nextId: state.nextId,
-		...(op.kind === "error" ? { error: op.message } : {}),
-	};
-	return { content: [{ type: "text", text }], details };
-}
+import type { TaskState } from "../state/state.js";
+import type { Op } from "../state/state-reducer.js";
+import { deriveBlocks } from "../state/task-graph.js";
+import type { Task, TaskAction, TaskDetails, TaskMutationParams } from "./types.js";
+
+/**
+ * Format a single task as a `[status] #id subject [(activeForm)] [⛓ #dep,…]`
+ * line. Used by the `list` content branch only — the overlay and `/todos`
+ * formatting paths use `view/format.ts` for richer presentations.
+ */
+function formatListLine(t: Task): string {
+	const block = t.blockedBy?.length ? ` ⛓ ${t.blockedBy.map((id) => `#${id}`).join(",")}` : "";
+	const form = t.status === "in_progress" && t.activeForm ? ` (${t.activeForm})` : "";
+	return `[${t.status}] #${t.id} ${t.subject}${form}${block}`;
+}
+
+/**
+ * Multi-line presentation for the `get` action. Order of rows is pinned by
+ * pre-refactor `todo.ts:354-376` — description, activeForm, blockedBy, blocks,
+ * owner — so envelope-level snapshot tests stay byte-equivalent.
+ */
+function formatGetLines(task: Task, state: TaskState): string {
+	const blocks = deriveBlocks(state.tasks).get(task.id) ?? [];
+	const lines = [`#${task.id} [${task.status}] ${task.subject}`];
+	if (task.description) lines.push(`  description: ${task.description}`);
+	if (task.activeForm) lines.push(`  activeForm: ${task.activeForm}`);
+	if (task.blockedBy?.length) {
+		lines.push(`  blockedBy: ${task.blockedBy.map((id) => `#${id}`).join(", ")}`);
+	}
+	if (blocks.length) {
+		lines.push(`  blocks: ${blocks.map((id) => `#${id}`).join(", ")}`);
+	}
+	if (task.owner) lines.push(`  owner: ${task.owner}`);
+	return lines.join("\n");
+}
+
+/**
+ * Pure formatter: `(op, state) → string`. Closed switch on `op.kind` —
+ * adding a new `Op` variant fails to compile here until a branch is added.
+ * The strings on each branch are byte-equivalent to pre-refactor `todo.ts`
+ * reducer output.
+ */
+export function formatContent(op: Op, state: TaskState): string {
+	switch (op.kind) {
+		case "create": {
+			const names = op.ids
+				.map((id) => {
+					const t = state.tasks.find((x) => x.id === id);
+					return t ? `#${t.id}: ${t.subject} (pending)` : `#${id}`;
+				})
+				.join(", ");
+			return `Created ${names}`;
+		}
+		case "update": {
+			return op.results
+				.map((r) => {
+					const transition = r.fromStatus !== r.toStatus ? ` (${r.fromStatus} → ${r.toStatus})` : "";
+					return `Updated #${r.id}${transition}`;
+				})
+				.join("\n");
+		}
+		case "delete":
+			return op.items.map((d) => `Deleted #${d.id}: ${d.subject}`).join("\n");
+		case "clear":
+			return `Cleared ${op.count} tasks`;
+		case "list": {
+			let view = state.tasks;
+			if (!op.includeDeleted) view = view.filter((t) => t.status !== "deleted");
+			if (op.statusFilter) view = view.filter((t) => t.status === op.statusFilter);
+			return view.length === 0 ? "No tasks" : view.map(formatListLine).join("\n");
+		}
+		case "get":
+			return op.tasks.map((t) => formatGetLines(t, state)).join("\n");
+		case "batch": {
+			if (op.results.length === 0) return "Batch: 0 operations";
+			const lines = [`Batch: ${op.results.length} operation${op.results.length !== 1 ? "s" : ""}:`];
+			for (const { index, op: sub } of op.results) {
+				lines.push(`  [${index}] ${formatContent(sub, state)}`);
+			}
+			return lines.join("\n");
+		}
+		case "error":
+			return `Error: ${op.message}`;
+	}
+}
+
+/**
+ * Build the LLM-facing tool envelope after the store has committed the
+ * reducer's new state. `details` is the persistence + replay snapshot —
+ * `state/replay.ts` consumes this exact shape on session lifecycle events.
+ *
+ * Mirrors `packages/rpiv-ask-user-question/tool/response-envelope.ts:13-47`.
+ */
+export function buildToolResult(
+	action: TaskAction,
+	params: TaskMutationParams,
+	state: TaskState,
+	op: Op,
+): { content: Array<{ type: "text"; text: string }>; details: TaskDetails } {
+	const text = formatContent(op, state);
+	const details: TaskDetails = {
+		action,
+		params: params as Record<string, unknown>,
+		tasks: state.tasks,
+		nextId: state.nextId,
+		...(op.kind === "error" ? { error: op.message } : {}),
+	};
+	return { content: [{ type: "text", text }], details };
+}