@app-connect/core 1.7.8 → 1.7.10

package/test/lib/util.test.js

@@ -0,0 +1,282 @@
+jest.mock('tz-lookup');
+jest.mock('country-state-city');
+
+const tzlookup = require('tz-lookup');
+const { State } = require('country-state-city');
+const {
+  getTimeZone,
+  getHashValue,
+  secondsToHoursMinutesSeconds,
+  getMostRecentDate,
+  getMediaReaderLinkByPlatformMediaLink
+} = require('../../lib/util');
+
+describe('Utility Functions', () => {
+  describe('getTimeZone', () => {
+    beforeEach(() => {
+      jest.clearAllMocks();
+    });
+
+    test('should return timezone for valid state and country', () => {
+      // Arrange
+      State.getStateByCodeAndCountry = jest.fn().mockReturnValue({
+        name: 'California',
+        latitude: '36.778259',
+        longitude: '-119.417931'
+      });
+      tzlookup.mockReturnValue('America/Los_Angeles');
+
+      // Act
+      const result = getTimeZone('US', 'CA');
+
+      // Assert
+      expect(State.getStateByCodeAndCountry).toHaveBeenCalledWith('CA', 'US');
+      expect(tzlookup).toHaveBeenCalledWith('36.778259', '-119.417931');
+      expect(result).toBe('America/Los_Angeles');
+    });
+
+    test('should return "Unknown timezone" when state not found', () => {
+      // Arrange
+      State.getStateByCodeAndCountry = jest.fn().mockReturnValue(null);
+
+      // Act
+      const result = getTimeZone('XX', 'YY');
+
+      // Assert
+      expect(result).toBe('Unknown timezone');
+      expect(tzlookup).not.toHaveBeenCalled();
+    });
+
+    test('should handle different country/state combinations', () => {
+      // Arrange
+      State.getStateByCodeAndCountry = jest.fn().mockReturnValue({
+        name: 'Tokyo',
+        latitude: '35.6762',
+        longitude: '139.6503'
+      });
+      tzlookup.mockReturnValue('Asia/Tokyo');
+
+      // Act
+      const result = getTimeZone('JP', 'TK');
+
+      // Assert
+      expect(result).toBe('Asia/Tokyo');
+    });
+
+    test('should handle European timezone', () => {
+      // Arrange
+      State.getStateByCodeAndCountry = jest.fn().mockReturnValue({
+        name: 'Bavaria',
+        latitude: '48.7904',
+        longitude: '11.4979'
+      });
+      tzlookup.mockReturnValue('Europe/Berlin');
+
+      // Act
+      const result = getTimeZone('DE', 'BY');
+
+      // Assert
+      expect(result).toBe('Europe/Berlin');
+    });
+  });
+
+  describe('getHashValue', () => {
+    test('should generate consistent hash for same input', () => {
+      const hash1 = getHashValue('test-string', 'secret-key');
+      const hash2 = getHashValue('test-string', 'secret-key');
+
+      expect(hash1).toBe(hash2);
+    });
+
+    test('should generate different hashes for different strings', () => {
+      const hash1 = getHashValue('string-1', 'secret-key');
+      const hash2 = getHashValue('string-2', 'secret-key');
+
+      expect(hash1).not.toBe(hash2);
+    });
+
+    test('should generate different hashes for different keys', () => {
+      const hash1 = getHashValue('test-string', 'key-1');
+      const hash2 = getHashValue('test-string', 'key-2');
+
+      expect(hash1).not.toBe(hash2);
+    });
+
+    test('should return a 64-character hex string (SHA-256)', () => {
+      const hash = getHashValue('test', 'key');
+
+      expect(hash).toHaveLength(64);
+      expect(hash).toMatch(/^[0-9a-f]{64}$/);
+    });
+
+    test('should handle empty string', () => {
+      const hash = getHashValue('', 'secret-key');
+
+      expect(hash).toHaveLength(64);
+      expect(hash).toMatch(/^[0-9a-f]{64}$/);
+    });
+
+    test('should handle special characters', () => {
+      const hash = getHashValue('test@#$%^&*()', 'key!@#');
+
+      expect(hash).toHaveLength(64);
+      expect(hash).toMatch(/^[0-9a-f]{64}$/);
+    });
+  });
+
+  describe('secondsToHoursMinutesSeconds', () => {
+    test('should return "0 seconds" for 0', () => {
+      expect(secondsToHoursMinutesSeconds(0)).toBe('0 seconds');
+    });
+
+    test('should return singular "second" for 1 second', () => {
+      expect(secondsToHoursMinutesSeconds(1)).toBe('1 second');
+    });
+
+    test('should return plural "seconds" for multiple seconds', () => {
+      expect(secondsToHoursMinutesSeconds(30)).toBe('30 seconds');
+    });
+
+    test('should return singular "minute" for 60 seconds', () => {
+      expect(secondsToHoursMinutesSeconds(60)).toBe('1 minute');
+    });
+
+    test('should return plural "minutes" for multiple minutes', () => {
+      expect(secondsToHoursMinutesSeconds(120)).toBe('2 minutes');
+    });
+
+    test('should return minutes and seconds combined', () => {
+      expect(secondsToHoursMinutesSeconds(90)).toBe('1 minute, 30 seconds');
+    });
+
+    test('should return singular "hour" for 3600 seconds', () => {
+      expect(secondsToHoursMinutesSeconds(3600)).toBe('1 hour');
+    });
+
+    test('should return plural "hours" for multiple hours', () => {
+      expect(secondsToHoursMinutesSeconds(7200)).toBe('2 hours');
+    });
+
+    test('should return hours, minutes, and seconds combined', () => {
+      expect(secondsToHoursMinutesSeconds(3661)).toBe('1 hour, 1 minute, 1 second');
+    });
+
+    test('should return hours and minutes combined (no seconds)', () => {
+      expect(secondsToHoursMinutesSeconds(3660)).toBe('1 hour, 1 minute');
+    });
+
+    test('should return hours and seconds combined (no minutes)', () => {
+      expect(secondsToHoursMinutesSeconds(3601)).toBe('1 hour, 1 second');
+    });
+
+    test('should handle large values', () => {
+      // 2 hours, 30 minutes, 45 seconds
+      expect(secondsToHoursMinutesSeconds(9045)).toBe('2 hours, 30 minutes, 45 seconds');
+    });
+
+    test('should return input directly if not a number', () => {
+      expect(secondsToHoursMinutesSeconds('not a number')).toBe('not a number');
+      expect(secondsToHoursMinutesSeconds(undefined)).toBe(undefined);
+      // Note: null coerces to 0 via isNaN(null) === false, so returns "0 seconds"
+      expect(secondsToHoursMinutesSeconds(null)).toBe('0 seconds');
+    });
+
+    test('should handle NaN', () => {
+      expect(secondsToHoursMinutesSeconds(NaN)).toBe(NaN);
+    });
+  });
+
+  describe('getMostRecentDate', () => {
+    test('should return 0 for empty array', () => {
+      expect(getMostRecentDate({ allDateValues: [] })).toBe(0);
+    });
+
+    test('should return the single date from single-element array', () => {
+      const date = new Date('2024-01-15').getTime();
+      expect(getMostRecentDate({ allDateValues: [date] })).toBe(date);
+    });
+
+    test('should return the most recent date from multiple dates', () => {
+      const date1 = new Date('2024-01-01').getTime();
+      const date2 = new Date('2024-06-15').getTime();
+      const date3 = new Date('2024-03-10').getTime();
+
+      expect(getMostRecentDate({ allDateValues: [date1, date2, date3] })).toBe(date2);
+    });
+
+    test('should handle numeric timestamps', () => {
+      const timestamps = [1000, 5000, 3000, 2000];
+      expect(getMostRecentDate({ allDateValues: timestamps })).toBe(5000);
+    });
+
+    test('should skip null values', () => {
+      const date1 = new Date('2024-01-01').getTime();
+      const date2 = new Date('2024-06-15').getTime();
+
+      expect(getMostRecentDate({ allDateValues: [date1, null, date2, null] })).toBe(date2);
+    });
+
+    test('should skip undefined values', () => {
+      const date1 = new Date('2024-01-01').getTime();
+      const date2 = new Date('2024-06-15').getTime();
+
+      expect(getMostRecentDate({ allDateValues: [date1, undefined, date2] })).toBe(date2);
+    });
+
+    test('should return 0 for array with only null/undefined values', () => {
+      expect(getMostRecentDate({ allDateValues: [null, undefined, null] })).toBe(0);
+    });
+
+    test('should handle all same dates', () => {
+      const sameDate = new Date('2024-05-01').getTime();
+      expect(getMostRecentDate({ allDateValues: [sameDate, sameDate, sameDate] })).toBe(sameDate);
+    });
+  });
+
+  describe('getMediaReaderLinkByPlatformMediaLink', () => {
+    test('should return null for null input', () => {
+      expect(getMediaReaderLinkByPlatformMediaLink(null)).toBeNull();
+    });
+
+    test('should return null for undefined input', () => {
+      expect(getMediaReaderLinkByPlatformMediaLink(undefined)).toBeNull();
+    });
+
+    test('should return null for empty string', () => {
+      expect(getMediaReaderLinkByPlatformMediaLink('')).toBeNull();
+    });
+
+    test('should return media reader link for valid platform media link', () => {
+      const platformLink = 'https://media.ringcentral.com/restapi/v1.0/account/123/extension/456/message-store/789/content/abc';
+      const result = getMediaReaderLinkByPlatformMediaLink(platformLink);
+
+      expect(result).toBe(`https://ringcentral.github.io/ringcentral-media-reader/?media=${encodeURIComponent(platformLink)}`);
+    });
+
+    test('should properly encode special characters in URL', () => {
+      const platformLink = 'https://media.ringcentral.com/test?param=value&other=123';
+      const result = getMediaReaderLinkByPlatformMediaLink(platformLink);
+
+      expect(result).toContain('https://ringcentral.github.io/ringcentral-media-reader/?media=');
+      expect(result).toContain(encodeURIComponent(platformLink));
+    });
+
+    test('should handle simple URL', () => {
+      const platformLink = 'https://example.com/media.mp3';
+      const result = getMediaReaderLinkByPlatformMediaLink(platformLink);
+
+      expect(result).toBe(`https://ringcentral.github.io/ringcentral-media-reader/?media=${encodeURIComponent(platformLink)}`);
+    });
+
+    test('should handle URL with query parameters', () => {
+      const platformLink = 'https://media.ringcentral.com/file?id=123&type=audio';
+      const result = getMediaReaderLinkByPlatformMediaLink(platformLink);
+
+      expect(result).toContain('ringcentral-media-reader');
+      // Verify the URL is properly encoded
+      expect(result).not.toContain('&type=');
+      expect(result).toContain('%26type%3D');
+    });
+  });
+});
+

package/test/models/accountDataModel.test.js

@@ -0,0 +1,98 @@
+// Use in-memory SQLite for isolated model tests
+jest.mock('../../models/sequelize', () => {
+  const { Sequelize } = require('sequelize');
+  return {
+    sequelize: new Sequelize({
+      dialect: 'sqlite',
+      storage: ':memory:',
+      logging: false,
+    }),
+  };
+});
+
+const { AccountDataModel, getOrRefreshAccountData } = require('../../models/accountDataModel');
+const { sequelize } = require('../../models/sequelize');
+
+describe('getOrRefreshAccountData', () => {
+  beforeAll(async () => {
+    await AccountDataModel.sync({ force: true });
+  });
+
+  afterEach(async () => {
+    await AccountDataModel.destroy({ where: {} });
+  });
+
+  afterAll(async () => {
+    await sequelize.close();
+  });
+
+  test('returns cached data when record exists and refresh not forced', async () => {
+    await AccountDataModel.create({
+      rcAccountId: 'acc-1',
+      platformName: 'test-platform',
+      dataKey: 'key-1',
+      data: { cached: true },
+    });
+
+    const fetchFn = jest.fn().mockResolvedValue({ cached: false });
+
+    const out = await getOrRefreshAccountData({
+      rcAccountId: 'acc-1',
+      platformName: 'test-platform',
+      dataKey: 'key-1',
+      forceRefresh: false,
+      fetchFn,
+    });
+
+    expect(out).toEqual({ cached: true });
+    expect(fetchFn).not.toHaveBeenCalled();
+  });
+
+  test('creates new record when none exists', async () => {
+    const fetchFn = jest.fn().mockResolvedValue({ fresh: 'data' });
+
+    const out = await getOrRefreshAccountData({
+      rcAccountId: 'acc-2',
+      platformName: 'test-platform',
+      dataKey: 'key-2',
+      fetchFn,
+    });
+
+    expect(out).toEqual({ fresh: 'data' });
+    expect(fetchFn).toHaveBeenCalledTimes(1);
+
+    const stored = await AccountDataModel.findOne({
+      where: { rcAccountId: 'acc-2', platformName: 'test-platform', dataKey: 'key-2' },
+    });
+    expect(stored).not.toBeNull();
+    expect(stored.data).toEqual({ fresh: 'data' });
+  });
+
+  test('refreshes existing record when forceRefresh is true', async () => {
+    await AccountDataModel.create({
+      rcAccountId: 'acc-3',
+      platformName: 'test-platform',
+      dataKey: 'key-3',
+      data: { cached: true },
+    });
+
+    const fetchFn = jest.fn().mockResolvedValue({ cached: false, updated: true });
+
+    const out = await getOrRefreshAccountData({
+      rcAccountId: 'acc-3',
+      platformName: 'test-platform',
+      dataKey: 'key-3',
+      forceRefresh: true,
+      fetchFn,
+    });
+
+    expect(fetchFn).toHaveBeenCalledTimes(1);
+    expect(out).toEqual({ cached: false, updated: true });
+
+    const refreshed = await AccountDataModel.findOne({
+      where: { rcAccountId: 'acc-3', platformName: 'test-platform', dataKey: 'key-3' },
+    });
+    expect(refreshed.data).toEqual({ cached: false, updated: true });
+  });
+});
+

package/test/models/dynamo/connectorSchema.test.js

@@ -0,0 +1,189 @@
+// Mock dynamoose before requiring the module
+jest.mock('dynamoose', () => {
+  const mockModel = {
+    query: jest.fn().mockReturnThis(),
+    eq: jest.fn().mockReturnThis(),
+    using: jest.fn().mockReturnThis(),
+    exec: jest.fn()
+  };
+
+  return {
+    Schema: jest.fn().mockReturnValue({}),
+    model: jest.fn().mockReturnValue(mockModel)
+  };
+});
+
+describe('Connector Schema', () => {
+  const originalEnv = process.env.DEVELOPER_APP_SERVER_SECRET_KEY;
+
+  beforeEach(() => {
+    jest.clearAllMocks();
+    jest.resetModules();
+    process.env.DEVELOPER_APP_SERVER_SECRET_KEY = 'test-secret-key-12345678901234';
+  });
+
+  afterEach(() => {
+    if (originalEnv) {
+      process.env.DEVELOPER_APP_SERVER_SECRET_KEY = originalEnv;
+    } else {
+      delete process.env.DEVELOPER_APP_SERVER_SECRET_KEY;
+    }
+  });
+
+  describe('getProxyConfig', () => {
+    test('should return proxy config when connector found', async () => {
+      const mockProxyConfig = {
+        operations: {
+          createCallLog: { method: 'POST', url: '/api/logs' },
+          findContact: { method: 'GET', url: '/api/contacts' }
+        }
+      };
+
+      const mockConnector = {
+        proxyConfig: mockProxyConfig,
+        encodedSecretKey: null
+      };
+
+      // Import fresh module
+      const { Connector } = require('../../../models/dynamo/connectorSchema');
+
+      // Mock the query chain
+      Connector.query = jest.fn().mockReturnThis();
+      Connector.eq = jest.fn().mockReturnThis();
+      Connector.using = jest.fn().mockReturnThis();
+      Connector.exec = jest.fn().mockResolvedValue([mockConnector]);
+
+      const result = await Connector.getProxyConfig('proxy-123');
+
+      expect(Connector.query).toHaveBeenCalledWith('proxyId');
+      expect(Connector.eq).toHaveBeenCalledWith('proxy-123');
+      expect(Connector.using).toHaveBeenCalledWith('proxyIdIndex');
+      expect(result).toEqual(mockProxyConfig);
+    });
+
+    test('should return null when no connector found', async () => {
+      const { Connector } = require('../../../models/dynamo/connectorSchema');
+
+      Connector.query = jest.fn().mockReturnThis();
+      Connector.eq = jest.fn().mockReturnThis();
+      Connector.using = jest.fn().mockReturnThis();
+      Connector.exec = jest.fn().mockResolvedValue([]);
+
+      const result = await Connector.getProxyConfig('non-existent-proxy');
+
+      expect(result).toBeNull();
+    });
+
+    test('should handle proxy config without encoded secret key', async () => {
+      const mockProxyConfig = {
+        operations: {
+          findContact: { method: 'GET', url: '/api/contacts' }
+        }
+      };
+
+      const mockConnector = {
+        proxyConfig: mockProxyConfig,
+        encodedSecretKey: ''
+      };
+
+      const { Connector } = require('../../../models/dynamo/connectorSchema');
+
+      Connector.query = jest.fn().mockReturnThis();
+      Connector.eq = jest.fn().mockReturnThis();
+      Connector.using = jest.fn().mockReturnThis();
+      Connector.exec = jest.fn().mockResolvedValue([mockConnector]);
+
+      const result = await Connector.getProxyConfig('proxy-no-secret');
+
+      expect(result).toEqual(mockProxyConfig);
+      expect(result.secretKey).toBeUndefined();
+    });
+
+    test('should handle undefined encoded secret key', async () => {
+      const mockProxyConfig = {
+        operations: {
+          createCallLog: { method: 'POST', url: '/api/logs' }
+        }
+      };
+
+      const mockConnector = {
+        proxyConfig: mockProxyConfig,
+        encodedSecretKey: undefined
+      };
+
+      const { Connector } = require('../../../models/dynamo/connectorSchema');
+
+      Connector.query = jest.fn().mockReturnThis();
+      Connector.eq = jest.fn().mockReturnThis();
+      Connector.using = jest.fn().mockReturnThis();
+      Connector.exec = jest.fn().mockResolvedValue([mockConnector]);
+
+      const result = await Connector.getProxyConfig('proxy-undefined-secret');
+
+      expect(result).toEqual(mockProxyConfig);
+      expect(result.secretKey).toBeUndefined();
+    });
+  });
+
+  describe('CONNECTOR_STATUS constants', () => {
+    test('should have correct status values in schema enum', () => {
+      // The status values are defined in the schema
+      const expectedStatuses = ['private', 'under_review', 'approved', 'rejected'];
+      
+      // Import the module to verify it loads without error
+      const { Connector } = require('../../../models/dynamo/connectorSchema');
+      
+      // The module exports Connector which means schema was created successfully
+      expect(Connector).toBeDefined();
+      expect(typeof Connector.getProxyConfig).toBe('function');
+    });
+  });
+
+  describe('Module Structure', () => {
+    test('should export Connector model', () => {
+      const connectorModule = require('../../../models/dynamo/connectorSchema');
+      
+      expect(connectorModule.Connector).toBeDefined();
+    });
+
+    test('should have getProxyConfig static method', () => {
+      const { Connector } = require('../../../models/dynamo/connectorSchema');
+      
+      expect(typeof Connector.getProxyConfig).toBe('function');
+    });
+  });
+
+  describe('getDeveloperCipherKey behavior', () => {
+    // These tests verify the cipher key handling indirectly through the module
+    
+    test('should handle secret key of exactly 32 characters', async () => {
+      process.env.DEVELOPER_APP_SERVER_SECRET_KEY = '12345678901234567890123456789012'; // exactly 32 chars
+      
+      jest.resetModules();
+      
+      const { Connector } = require('../../../models/dynamo/connectorSchema');
+      
+      // If the key is exactly 32 chars, no padding/truncation needed
+      expect(Connector).toBeDefined();
+    });
+
+    test('should throw error when DEVELOPER_APP_SERVER_SECRET_KEY is not set and decode is called', async () => {
+      delete process.env.DEVELOPER_APP_SERVER_SECRET_KEY;
+      
+      jest.resetModules();
+      
+      const { Connector } = require('../../../models/dynamo/connectorSchema');
+      
+      Connector.query = jest.fn().mockReturnThis();
+      Connector.eq = jest.fn().mockReturnThis();
+      Connector.using = jest.fn().mockReturnThis();
+      Connector.exec = jest.fn().mockResolvedValue([{
+        proxyConfig: { test: true },
+        encodedSecretKey: 'some-encrypted-value'
+      }]);
+
+      // The decode function will be called which requires the secret key
+      await expect(Connector.getProxyConfig('test')).rejects.toThrow('DEVELOPER_APP_SERVER_SECRET_KEY is not defined');
+    });
+  });
+});