@app-connect/core 1.7.25 → 1.7.27

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (138) hide show
  1. package/.env.test +5 -5
  2. package/README.md +441 -441
  3. package/connector/developerPortal.js +31 -31
  4. package/connector/mock.js +84 -77
  5. package/connector/proxy/engine.js +164 -164
  6. package/connector/proxy/index.js +500 -500
  7. package/connector/registry.js +252 -252
  8. package/docs/README.md +50 -50
  9. package/docs/architecture.md +93 -93
  10. package/docs/connectors.md +116 -116
  11. package/docs/handlers.md +125 -125
  12. package/docs/libraries.md +101 -101
  13. package/docs/models.md +144 -144
  14. package/docs/routes.md +115 -115
  15. package/docs/tests.md +73 -73
  16. package/handlers/admin.js +523 -523
  17. package/handlers/appointment.js +193 -0
  18. package/handlers/auth.js +320 -296
  19. package/handlers/calldown.js +99 -99
  20. package/handlers/contact.js +280 -280
  21. package/handlers/disposition.js +82 -80
  22. package/handlers/log.js +990 -973
  23. package/handlers/managedAuth.js +446 -446
  24. package/handlers/managedOAuth.js +247 -0
  25. package/handlers/plugin.js +208 -208
  26. package/handlers/user.js +142 -142
  27. package/index.js +3162 -2652
  28. package/jest.config.js +56 -56
  29. package/lib/analytics.js +54 -54
  30. package/lib/authSession.js +109 -109
  31. package/lib/cacheCleanup.js +21 -0
  32. package/lib/callLogComposer.js +898 -898
  33. package/lib/callLogLookup.js +34 -0
  34. package/lib/constants.js +8 -8
  35. package/lib/debugTracer.js +177 -177
  36. package/lib/encode.js +30 -30
  37. package/lib/errorHandler.js +218 -206
  38. package/lib/generalErrorMessage.js +41 -41
  39. package/lib/jwt.js +18 -18
  40. package/lib/logger.js +190 -190
  41. package/lib/migrateCallLogsSchema.js +116 -0
  42. package/lib/ringcentral.js +266 -266
  43. package/lib/s3ErrorLogReport.js +65 -65
  44. package/lib/sharedSMSComposer.js +471 -471
  45. package/lib/util.js +67 -67
  46. package/mcp/README.md +412 -395
  47. package/mcp/lib/validator.js +91 -91
  48. package/mcp/mcpHandler.js +425 -425
  49. package/mcp/tools/cancelAppointment.js +101 -0
  50. package/mcp/tools/checkAuthStatus.js +105 -105
  51. package/mcp/tools/confirmAppointment.js +101 -0
  52. package/mcp/tools/createAppointment.js +157 -0
  53. package/mcp/tools/createCallLog.js +327 -316
  54. package/mcp/tools/createContact.js +117 -117
  55. package/mcp/tools/createMessageLog.js +287 -287
  56. package/mcp/tools/doAuth.js +60 -60
  57. package/mcp/tools/findContactByName.js +93 -93
  58. package/mcp/tools/findContactByPhone.js +101 -101
  59. package/mcp/tools/getCallLog.js +111 -102
  60. package/mcp/tools/getGoogleFilePicker.js +99 -99
  61. package/mcp/tools/getHelp.js +43 -43
  62. package/mcp/tools/getPublicConnectors.js +94 -94
  63. package/mcp/tools/getSessionInfo.js +90 -90
  64. package/mcp/tools/index.js +51 -41
  65. package/mcp/tools/listAppointments.js +163 -0
  66. package/mcp/tools/logout.js +99 -96
  67. package/mcp/tools/rcGetCallLogs.js +65 -65
  68. package/mcp/tools/updateAppointment.js +154 -0
  69. package/mcp/tools/updateCallLog.js +130 -126
  70. package/mcp/ui/App/App.tsx +358 -358
  71. package/mcp/ui/App/components/AuthInfoForm.tsx +113 -113
  72. package/mcp/ui/App/components/AuthSuccess.tsx +22 -22
  73. package/mcp/ui/App/components/ConnectorList.tsx +82 -82
  74. package/mcp/ui/App/components/DebugPanel.tsx +43 -43
  75. package/mcp/ui/App/components/OAuthConnect.tsx +270 -270
  76. package/mcp/ui/App/lib/callTool.ts +130 -130
  77. package/mcp/ui/App/lib/debugLog.ts +41 -41
  78. package/mcp/ui/App/lib/developerPortal.ts +111 -111
  79. package/mcp/ui/App/main.css +5 -5
  80. package/mcp/ui/App/root.tsx +13 -13
  81. package/mcp/ui/index.html +13 -13
  82. package/mcp/ui/package-lock.json +6356 -6356
  83. package/mcp/ui/package.json +25 -25
  84. package/mcp/ui/tsconfig.json +26 -26
  85. package/mcp/ui/vite.config.ts +16 -16
  86. package/models/accountDataModel.js +33 -33
  87. package/models/adminConfigModel.js +35 -35
  88. package/models/cacheModel.js +30 -26
  89. package/models/callDownListModel.js +34 -34
  90. package/models/callLogModel.js +33 -27
  91. package/models/dynamo/connectorSchema.js +146 -146
  92. package/models/dynamo/lockSchema.js +24 -24
  93. package/models/dynamo/noteCacheSchema.js +29 -29
  94. package/models/llmSessionModel.js +17 -17
  95. package/models/messageLogModel.js +25 -25
  96. package/models/sequelize.js +16 -16
  97. package/models/userModel.js +45 -45
  98. package/package.json +1 -1
  99. package/releaseNotes.json +1101 -1081
  100. package/test/connector/proxy/engine.test.js +126 -126
  101. package/test/connector/proxy/index.test.js +279 -279
  102. package/test/connector/proxy/sample.json +161 -161
  103. package/test/connector/registry.test.js +415 -415
  104. package/test/handlers/admin.test.js +616 -616
  105. package/test/handlers/auth.test.js +1092 -1018
  106. package/test/handlers/contact.test.js +1014 -1014
  107. package/test/handlers/log.test.js +1298 -1160
  108. package/test/handlers/managedAuth.test.js +457 -457
  109. package/test/handlers/plugin.test.js +380 -380
  110. package/test/index.test.js +105 -105
  111. package/test/lib/cacheCleanup.test.js +42 -0
  112. package/test/lib/callLogComposer.test.js +1231 -1231
  113. package/test/lib/debugTracer.test.js +328 -328
  114. package/test/lib/jwt.test.js +176 -176
  115. package/test/lib/logger.test.js +206 -206
  116. package/test/lib/oauth.test.js +359 -359
  117. package/test/lib/ringcentral.test.js +467 -467
  118. package/test/lib/sharedSMSComposer.test.js +1084 -1084
  119. package/test/lib/util.test.js +329 -329
  120. package/test/mcp/tools/checkAuthStatus.test.js +83 -83
  121. package/test/mcp/tools/createCallLog.test.js +436 -436
  122. package/test/mcp/tools/createContact.test.js +58 -58
  123. package/test/mcp/tools/createMessageLog.test.js +595 -595
  124. package/test/mcp/tools/doAuth.test.js +113 -113
  125. package/test/mcp/tools/findContactByName.test.js +275 -275
  126. package/test/mcp/tools/findContactByPhone.test.js +296 -296
  127. package/test/mcp/tools/getCallLog.test.js +298 -298
  128. package/test/mcp/tools/getGoogleFilePicker.test.js +281 -281
  129. package/test/mcp/tools/getPublicConnectors.test.js +107 -107
  130. package/test/mcp/tools/getSessionInfo.test.js +127 -127
  131. package/test/mcp/tools/logout.test.js +233 -233
  132. package/test/mcp/tools/rcGetCallLogs.test.js +56 -56
  133. package/test/mcp/tools/updateCallLog.test.js +360 -360
  134. package/test/models/accountDataModel.test.js +98 -98
  135. package/test/models/dynamo/connectorSchema.test.js +189 -189
  136. package/test/models/models.test.js +568 -539
  137. package/test/routes/managedAuthRoutes.test.js +235 -104
  138. package/test/setup.js +178 -178
@@ -1,416 +1,416 @@
1
- const connectorRegistry = require('../../connector/registry');
2
-
3
- describe('ConnectorRegistry Interface Registration with Composition', () => {
4
- beforeEach(() => {
5
- // Clear the registry before each test
6
- connectorRegistry.connectors.clear();
7
- connectorRegistry.manifests.clear();
8
- connectorRegistry.platformInterfaces.clear();
9
- });
10
-
11
- test('should register interface functions for a platform', () => {
12
- const mockFunction = jest.fn();
13
-
14
- connectorRegistry.registerConnectorInterface('testPlatform', 'testInterface', mockFunction);
15
-
16
- expect(connectorRegistry.hasPlatformInterface('testPlatform', 'testInterface')).toBe(true);
17
- expect(connectorRegistry.getPlatformInterfaces('testPlatform').get('testInterface')).toBe(mockFunction);
18
- });
19
-
20
- test('should throw error when registering non-function as interface', () => {
21
- expect(() => {
22
- connectorRegistry.registerConnectorInterface('testPlatform', 'testInterface', 'not a function');
23
- }).toThrow('Interface function must be a function, got: string');
24
- });
25
-
26
- test('should return original connector when no interfaces are registered', () => {
27
- const mockConnector = {
28
- getAuthType: () => 'apiKey',
29
- createCallLog: jest.fn(),
30
- updateCallLog: jest.fn()
31
- };
32
-
33
- connectorRegistry.registerConnector('testPlatform', mockConnector);
34
-
35
- const retrievedConnector = connectorRegistry.getConnector('testPlatform');
36
- expect(retrievedConnector).toBe(mockConnector);
37
- });
38
-
39
- test('should return composed connector with interface functions when interfaces are registered', () => {
40
- const mockInterface = jest.fn();
41
- const mockConnector = {
42
- getAuthType: () => 'apiKey',
43
- createCallLog: jest.fn(),
44
- updateCallLog: jest.fn()
45
- };
46
-
47
- // Register interface function first
48
- connectorRegistry.registerConnectorInterface('testPlatform', 'customMethod', mockInterface);
49
-
50
- // Register connector
51
- connectorRegistry.registerConnector('testPlatform', mockConnector);
52
-
53
- // Get composed connector
54
- const composedConnector = connectorRegistry.getConnector('testPlatform');
55
-
56
- // Should be a different object (composed)
57
- expect(composedConnector).not.toBe(mockConnector);
58
-
59
- // Should have the interface function
60
- expect(composedConnector.customMethod).toBe(mockInterface);
61
-
62
- // Should still have original methods
63
- expect(composedConnector.getAuthType).toBe(mockConnector.getAuthType);
64
- expect(composedConnector.createCallLog).toBe(mockConnector.createCallLog);
65
- });
66
-
67
- test('should not override existing connector methods when composing interfaces', () => {
68
- const existingMethod = jest.fn();
69
- const mockConnector = {
70
- getAuthType: () => 'apiKey',
71
- createCallLog: jest.fn(),
72
- updateCallLog: jest.fn(),
73
- existingMethod: existingMethod
74
- };
75
-
76
- // Register connector first
77
- connectorRegistry.registerConnector('testPlatform', mockConnector);
78
-
79
- // Try to register interface with same name as existing method
80
- const newMethod = jest.fn();
81
- connectorRegistry.registerConnectorInterface('testPlatform', 'existingMethod', newMethod);
82
-
83
- // Get composed connector
84
- const composedConnector = connectorRegistry.getConnector('testPlatform');
85
-
86
- // Should not override the existing method
87
- expect(composedConnector.existingMethod).toBe(existingMethod);
88
- expect(composedConnector.existingMethod).not.toBe(newMethod);
89
- });
90
-
91
- test('should preserve original connector when composing interfaces', () => {
92
- const mockInterface = jest.fn();
93
- const mockConnector = {
94
- getAuthType: () => 'apiKey',
95
- createCallLog: jest.fn(),
96
- updateCallLog: jest.fn()
97
- };
98
-
99
- connectorRegistry.registerConnectorInterface('testPlatform', 'customMethod', mockInterface);
100
- connectorRegistry.registerConnector('testPlatform', mockConnector);
101
-
102
- // Get original connector
103
- const originalConnector = connectorRegistry.getOriginalConnector('testPlatform');
104
-
105
- // Original connector should be unchanged
106
- expect(originalConnector).toBe(mockConnector);
107
- expect(originalConnector.customMethod).toBeUndefined();
108
-
109
- // Composed connector should have the interface
110
- const composedConnector = connectorRegistry.getConnector('testPlatform');
111
- expect(composedConnector.customMethod).toBe(mockInterface);
112
- });
113
-
114
- test('should unregister interface functions', () => {
115
- const mockFunction = jest.fn();
116
-
117
- connectorRegistry.registerConnectorInterface('testPlatform', 'testInterface', mockFunction);
118
- expect(connectorRegistry.hasPlatformInterface('testPlatform', 'testInterface')).toBe(true);
119
-
120
- connectorRegistry.unregisterConnectorInterface('testPlatform', 'testInterface');
121
- expect(connectorRegistry.hasPlatformInterface('testPlatform', 'testInterface')).toBe(false);
122
- });
123
-
124
- test('should return empty map for non-existent platform interfaces', () => {
125
- const interfaces = connectorRegistry.getPlatformInterfaces('nonExistentPlatform');
126
- expect(interfaces).toBeInstanceOf(Map);
127
- expect(interfaces.size).toBe(0);
128
- });
129
-
130
- test('should return false for non-existent platform interface', () => {
131
- expect(connectorRegistry.hasPlatformInterface('nonExistentPlatform', 'anyInterface')).toBe(false);
132
- });
133
-
134
- test('should handle multiple interface functions for same platform', () => {
135
- const mockFunction1 = jest.fn();
136
- const mockFunction2 = jest.fn();
137
- const mockConnector = {
138
- getAuthType: () => 'apiKey',
139
- createCallLog: jest.fn(),
140
- updateCallLog: jest.fn()
141
- };
142
-
143
- connectorRegistry.registerConnectorInterface('testPlatform', 'interface1', mockFunction1);
144
- connectorRegistry.registerConnectorInterface('testPlatform', 'interface2', mockFunction2);
145
- connectorRegistry.registerConnector('testPlatform', mockConnector);
146
-
147
- const platformInterfaces = connectorRegistry.getPlatformInterfaces('testPlatform');
148
- expect(platformInterfaces.size).toBe(2);
149
- expect(platformInterfaces.get('interface1')).toBe(mockFunction1);
150
- expect(platformInterfaces.get('interface2')).toBe(mockFunction2);
151
-
152
- // Check composed connector has both interfaces
153
- const composedConnector = connectorRegistry.getConnector('testPlatform');
154
- expect(composedConnector.interface1).toBe(mockFunction1);
155
- expect(composedConnector.interface2).toBe(mockFunction2);
156
- });
157
-
158
- test('should clean up platform interfaces when unregistering connector', () => {
159
- const mockFunction = jest.fn();
160
- const mockConnector = {
161
- getAuthType: () => 'apiKey',
162
- createCallLog: jest.fn(),
163
- updateCallLog: jest.fn()
164
- };
165
-
166
- connectorRegistry.registerConnectorInterface('testPlatform', 'testInterface', mockFunction);
167
- connectorRegistry.registerConnector('testPlatform', mockConnector);
168
-
169
- expect(connectorRegistry.hasPlatformInterface('testPlatform', 'testInterface')).toBe(true);
170
-
171
- connectorRegistry.unregisterConnector('testPlatform');
172
-
173
- expect(connectorRegistry.hasPlatformInterface('testPlatform', 'testInterface')).toBe(false);
174
- });
175
-
176
- test('should get connector capabilities correctly', async () => {
177
- const mockInterface = jest.fn();
178
- const mockConnector = {
179
- getAuthType: () => 'apiKey',
180
- createCallLog: jest.fn(),
181
- updateCallLog: jest.fn()
182
- };
183
-
184
- connectorRegistry.registerConnectorInterface('testPlatform', 'customMethod', mockInterface);
185
- connectorRegistry.registerConnector('testPlatform', mockConnector);
186
-
187
- const capabilities = await connectorRegistry.getConnectorCapabilities('testPlatform');
188
-
189
- expect(capabilities.platform).toBe('testPlatform');
190
- expect(capabilities.originalMethods).toContain('getAuthType');
191
- expect(capabilities.originalMethods).toContain('createCallLog');
192
- expect(capabilities.originalMethods).toContain('updateCallLog');
193
- expect(capabilities.composedMethods).toContain('customMethod');
194
- expect(capabilities.registeredInterfaces).toContain('customMethod');
195
- expect(capabilities.authType).toBe('apiKey');
196
- });
197
-
198
- test('should handle interface registration after connector registration', () => {
199
- const mockConnector = {
200
- getAuthType: () => 'apiKey',
201
- createCallLog: jest.fn(),
202
- updateCallLog: jest.fn()
203
- };
204
-
205
- // Register connector first
206
- connectorRegistry.registerConnector('testPlatform', mockConnector);
207
-
208
- // Register interface function after
209
- const mockInterface = jest.fn();
210
- connectorRegistry.registerConnectorInterface('testPlatform', 'customMethod', mockInterface);
211
-
212
- // Get composed connector
213
- const composedConnector = connectorRegistry.getConnector('testPlatform');
214
-
215
- // Should have the interface function
216
- expect(composedConnector.customMethod).toBe(mockInterface);
217
-
218
- // Original connector should be unchanged
219
- const originalConnector = connectorRegistry.getOriginalConnector('testPlatform');
220
- expect(originalConnector.customMethod).toBeUndefined();
221
- });
222
-
223
- test('should return interface-only connector when no base connector is registered', () => {
224
- const mockInterface1 = jest.fn();
225
- const mockInterface2 = jest.fn();
226
-
227
- // Register only interface functions, no base connector
228
- connectorRegistry.registerConnectorInterface('interfaceOnlyPlatform', 'method1', mockInterface1);
229
- connectorRegistry.registerConnectorInterface('interfaceOnlyPlatform', 'method2', mockInterface2);
230
-
231
- // Get connector - should return interface-only object
232
- const interfaceOnlyConnector = connectorRegistry.getConnector('interfaceOnlyPlatform');
233
-
234
- // Should have interface functions
235
- expect(interfaceOnlyConnector.method1).toBe(mockInterface1);
236
- expect(interfaceOnlyConnector.method2).toBe(mockInterface2);
237
-
238
- // Should not have base connector methods
239
- expect(interfaceOnlyConnector.getAuthType).toBeUndefined();
240
-
241
- // Should be a plain object, not inherited from any connector
242
- expect(Object.getPrototypeOf(interfaceOnlyConnector)).toBe(Object.prototype);
243
- });
244
-
245
- test('should throw error when no connector and no interfaces are registered', () => {
246
- expect(() => {
247
- connectorRegistry.getConnector('nonExistentPlatform');
248
- }).toThrow('Connector not found for platform: nonExistentPlatform');
249
- });
250
-
251
- test('should handle mixed scenarios correctly', async () => {
252
- // Scenario 1: Only interfaces, no connector
253
- connectorRegistry.registerConnectorInterface('mixedPlatform', 'interfaceMethod', jest.fn());
254
- const interfaceOnly = connectorRegistry.getConnector('mixedPlatform');
255
- expect(interfaceOnly.interfaceMethod).toBeDefined();
256
- expect(interfaceOnly.getAuthType).toBeUndefined();
257
-
258
- // Scenario 2: Add connector later
259
- const mockConnector = {
260
- getAuthType: () => 'apiKey',
261
- createCallLog: jest.fn(),
262
- updateCallLog: jest.fn()
263
- };
264
- connectorRegistry.registerConnector('mixedPlatform', mockConnector);
265
-
266
- const composedConnector = connectorRegistry.getConnector('mixedPlatform');
267
- expect(composedConnector.interfaceMethod).toBeDefined();
268
- expect(composedConnector.getAuthType).toBeDefined();
269
- expect(await composedConnector.getAuthType()).toBe('apiKey');
270
- });
271
-
272
- test('should set and get default manifest', () => {
273
- const defaultManifest = {
274
- name: 'Default CRM',
275
- version: '1.0.0',
276
- features: ['call_logging', 'contact_sync']
277
- };
278
-
279
- connectorRegistry.setDefaultManifest(defaultManifest);
280
-
281
- // Get manifest with fallback should return default
282
- const manifest = connectorRegistry.getManifest('nonExistentPlatform', true);
283
- expect(manifest).toEqual(defaultManifest);
284
- });
285
-
286
- test('should throw error when getting manifest without fallback and platform not found', () => {
287
- expect(() => {
288
- connectorRegistry.getManifest('nonExistentPlatform', false);
289
- }).toThrow('Manifest not found for platform: nonExistentPlatform');
290
- });
291
-
292
- test('should throw error when getting manifest with fallback but no default set', () => {
293
- connectorRegistry.manifests.clear();
294
- expect(() => {
295
- connectorRegistry.getManifest('nonExistentPlatform', true);
296
- }).toThrow('Manifest not found for platform: nonExistentPlatform');
297
- });
298
-
299
- test('should register connector with manifest', () => {
300
- const mockConnector = {
301
- getAuthType: () => 'apiKey',
302
- createCallLog: jest.fn(),
303
- updateCallLog: jest.fn()
304
- };
305
- const manifest = {
306
- name: 'Test CRM',
307
- version: '2.0.0',
308
- authType: 'oauth'
309
- };
310
-
311
- connectorRegistry.registerConnector('testPlatformWithManifest', mockConnector, manifest);
312
-
313
- const retrievedManifest = connectorRegistry.getManifest('testPlatformWithManifest');
314
- expect(retrievedManifest).toEqual(manifest);
315
- });
316
-
317
- test('should set and get release notes', () => {
318
- const releaseNotes = {
319
- version: '1.5.0',
320
- date: '2024-01-15',
321
- changes: ['Bug fixes', 'New features']
322
- };
323
-
324
- connectorRegistry.setReleaseNotes(releaseNotes);
325
-
326
- // getReleaseNotes currently returns the same object regardless of platform
327
- const notes = connectorRegistry.getReleaseNotes('anyPlatform');
328
- expect(notes).toEqual(releaseNotes);
329
- });
330
-
331
- test('should get registered platforms', () => {
332
- const connector1 = {
333
- getAuthType: () => 'apiKey',
334
- createCallLog: jest.fn(),
335
- updateCallLog: jest.fn()
336
- };
337
- const connector2 = {
338
- getAuthType: () => 'oauth',
339
- createCallLog: jest.fn(),
340
- updateCallLog: jest.fn()
341
- };
342
-
343
- connectorRegistry.registerConnector('platform1', connector1);
344
- connectorRegistry.registerConnector('platform2', connector2);
345
-
346
- const platforms = connectorRegistry.getRegisteredPlatforms();
347
- expect(platforms).toContain('platform1');
348
- expect(platforms).toContain('platform2');
349
- expect(platforms).toHaveLength(2);
350
- });
351
-
352
- test('should check if platform is registered', () => {
353
- const mockConnector = {
354
- getAuthType: () => 'apiKey',
355
- createCallLog: jest.fn(),
356
- updateCallLog: jest.fn()
357
- };
358
-
359
- connectorRegistry.registerConnector('registeredPlatform', mockConnector);
360
-
361
- expect(connectorRegistry.isRegistered('registeredPlatform')).toBe(true);
362
- expect(connectorRegistry.isRegistered('unregisteredPlatform')).toBe(false);
363
- });
364
-
365
- test('should throw error for original connector when not found', () => {
366
- expect(() => {
367
- connectorRegistry.getOriginalConnector('nonExistentPlatform');
368
- }).toThrow('Connector not found for platform: nonExistentPlatform');
369
- });
370
-
371
- test('should validate connector interface with missing required methods', () => {
372
- const incompleteConnector = {
373
- getAuthType: () => 'apiKey',
374
- createCallLog: jest.fn()
375
- // Missing updateCallLog
376
- };
377
-
378
- expect(() => {
379
- connectorRegistry.registerConnector('incompletePlatform', incompleteConnector);
380
- }).toThrow('Connector incompletePlatform missing required method: updateCallLog');
381
- });
382
-
383
- test('should return proxy connector when platform not found but proxy exists', () => {
384
- const proxyConnector = {
385
- getAuthType: () => 'proxy',
386
- createCallLog: jest.fn(),
387
- updateCallLog: jest.fn(),
388
- proxy: true
389
- };
390
-
391
- connectorRegistry.registerConnector('proxy', proxyConnector);
392
-
393
- const connector = connectorRegistry.getConnector('unknownPlatformWithProxy');
394
- expect(connector).toBe(proxyConnector);
395
- expect(connector.proxy).toBe(true);
396
- });
397
-
398
- test('should handle getAuthType error in getConnectorCapabilities', async () => {
399
- const mockConnector = {
400
- getAuthType: jest.fn().mockRejectedValue(new Error('Auth type error')),
401
- createCallLog: jest.fn(),
402
- updateCallLog: jest.fn()
403
- };
404
-
405
- connectorRegistry.registerConnector('errorPlatform', mockConnector);
406
-
407
- const capabilities = await connectorRegistry.getConnectorCapabilities('errorPlatform');
408
- expect(capabilities.authType).toBe('unknown');
409
- });
410
-
411
- test('should handle unregistering non-existent interface gracefully', () => {
412
- // This should not throw
413
- connectorRegistry.unregisterConnectorInterface('nonExistentPlatform', 'nonExistentInterface');
414
- expect(connectorRegistry.hasPlatformInterface('nonExistentPlatform', 'nonExistentInterface')).toBe(false);
415
- });
1
+ const connectorRegistry = require('../../connector/registry');
2
+
3
+ describe('ConnectorRegistry Interface Registration with Composition', () => {
4
+ beforeEach(() => {
5
+ // Clear the registry before each test
6
+ connectorRegistry.connectors.clear();
7
+ connectorRegistry.manifests.clear();
8
+ connectorRegistry.platformInterfaces.clear();
9
+ });
10
+
11
+ test('should register interface functions for a platform', () => {
12
+ const mockFunction = jest.fn();
13
+
14
+ connectorRegistry.registerConnectorInterface('testPlatform', 'testInterface', mockFunction);
15
+
16
+ expect(connectorRegistry.hasPlatformInterface('testPlatform', 'testInterface')).toBe(true);
17
+ expect(connectorRegistry.getPlatformInterfaces('testPlatform').get('testInterface')).toBe(mockFunction);
18
+ });
19
+
20
+ test('should throw error when registering non-function as interface', () => {
21
+ expect(() => {
22
+ connectorRegistry.registerConnectorInterface('testPlatform', 'testInterface', 'not a function');
23
+ }).toThrow('Interface function must be a function, got: string');
24
+ });
25
+
26
+ test('should return original connector when no interfaces are registered', () => {
27
+ const mockConnector = {
28
+ getAuthType: () => 'apiKey',
29
+ createCallLog: jest.fn(),
30
+ updateCallLog: jest.fn()
31
+ };
32
+
33
+ connectorRegistry.registerConnector('testPlatform', mockConnector);
34
+
35
+ const retrievedConnector = connectorRegistry.getConnector('testPlatform');
36
+ expect(retrievedConnector).toBe(mockConnector);
37
+ });
38
+
39
+ test('should return composed connector with interface functions when interfaces are registered', () => {
40
+ const mockInterface = jest.fn();
41
+ const mockConnector = {
42
+ getAuthType: () => 'apiKey',
43
+ createCallLog: jest.fn(),
44
+ updateCallLog: jest.fn()
45
+ };
46
+
47
+ // Register interface function first
48
+ connectorRegistry.registerConnectorInterface('testPlatform', 'customMethod', mockInterface);
49
+
50
+ // Register connector
51
+ connectorRegistry.registerConnector('testPlatform', mockConnector);
52
+
53
+ // Get composed connector
54
+ const composedConnector = connectorRegistry.getConnector('testPlatform');
55
+
56
+ // Should be a different object (composed)
57
+ expect(composedConnector).not.toBe(mockConnector);
58
+
59
+ // Should have the interface function
60
+ expect(composedConnector.customMethod).toBe(mockInterface);
61
+
62
+ // Should still have original methods
63
+ expect(composedConnector.getAuthType).toBe(mockConnector.getAuthType);
64
+ expect(composedConnector.createCallLog).toBe(mockConnector.createCallLog);
65
+ });
66
+
67
+ test('should not override existing connector methods when composing interfaces', () => {
68
+ const existingMethod = jest.fn();
69
+ const mockConnector = {
70
+ getAuthType: () => 'apiKey',
71
+ createCallLog: jest.fn(),
72
+ updateCallLog: jest.fn(),
73
+ existingMethod: existingMethod
74
+ };
75
+
76
+ // Register connector first
77
+ connectorRegistry.registerConnector('testPlatform', mockConnector);
78
+
79
+ // Try to register interface with same name as existing method
80
+ const newMethod = jest.fn();
81
+ connectorRegistry.registerConnectorInterface('testPlatform', 'existingMethod', newMethod);
82
+
83
+ // Get composed connector
84
+ const composedConnector = connectorRegistry.getConnector('testPlatform');
85
+
86
+ // Should not override the existing method
87
+ expect(composedConnector.existingMethod).toBe(existingMethod);
88
+ expect(composedConnector.existingMethod).not.toBe(newMethod);
89
+ });
90
+
91
+ test('should preserve original connector when composing interfaces', () => {
92
+ const mockInterface = jest.fn();
93
+ const mockConnector = {
94
+ getAuthType: () => 'apiKey',
95
+ createCallLog: jest.fn(),
96
+ updateCallLog: jest.fn()
97
+ };
98
+
99
+ connectorRegistry.registerConnectorInterface('testPlatform', 'customMethod', mockInterface);
100
+ connectorRegistry.registerConnector('testPlatform', mockConnector);
101
+
102
+ // Get original connector
103
+ const originalConnector = connectorRegistry.getOriginalConnector('testPlatform');
104
+
105
+ // Original connector should be unchanged
106
+ expect(originalConnector).toBe(mockConnector);
107
+ expect(originalConnector.customMethod).toBeUndefined();
108
+
109
+ // Composed connector should have the interface
110
+ const composedConnector = connectorRegistry.getConnector('testPlatform');
111
+ expect(composedConnector.customMethod).toBe(mockInterface);
112
+ });
113
+
114
+ test('should unregister interface functions', () => {
115
+ const mockFunction = jest.fn();
116
+
117
+ connectorRegistry.registerConnectorInterface('testPlatform', 'testInterface', mockFunction);
118
+ expect(connectorRegistry.hasPlatformInterface('testPlatform', 'testInterface')).toBe(true);
119
+
120
+ connectorRegistry.unregisterConnectorInterface('testPlatform', 'testInterface');
121
+ expect(connectorRegistry.hasPlatformInterface('testPlatform', 'testInterface')).toBe(false);
122
+ });
123
+
124
+ test('should return empty map for non-existent platform interfaces', () => {
125
+ const interfaces = connectorRegistry.getPlatformInterfaces('nonExistentPlatform');
126
+ expect(interfaces).toBeInstanceOf(Map);
127
+ expect(interfaces.size).toBe(0);
128
+ });
129
+
130
+ test('should return false for non-existent platform interface', () => {
131
+ expect(connectorRegistry.hasPlatformInterface('nonExistentPlatform', 'anyInterface')).toBe(false);
132
+ });
133
+
134
+ test('should handle multiple interface functions for same platform', () => {
135
+ const mockFunction1 = jest.fn();
136
+ const mockFunction2 = jest.fn();
137
+ const mockConnector = {
138
+ getAuthType: () => 'apiKey',
139
+ createCallLog: jest.fn(),
140
+ updateCallLog: jest.fn()
141
+ };
142
+
143
+ connectorRegistry.registerConnectorInterface('testPlatform', 'interface1', mockFunction1);
144
+ connectorRegistry.registerConnectorInterface('testPlatform', 'interface2', mockFunction2);
145
+ connectorRegistry.registerConnector('testPlatform', mockConnector);
146
+
147
+ const platformInterfaces = connectorRegistry.getPlatformInterfaces('testPlatform');
148
+ expect(platformInterfaces.size).toBe(2);
149
+ expect(platformInterfaces.get('interface1')).toBe(mockFunction1);
150
+ expect(platformInterfaces.get('interface2')).toBe(mockFunction2);
151
+
152
+ // Check composed connector has both interfaces
153
+ const composedConnector = connectorRegistry.getConnector('testPlatform');
154
+ expect(composedConnector.interface1).toBe(mockFunction1);
155
+ expect(composedConnector.interface2).toBe(mockFunction2);
156
+ });
157
+
158
+ test('should clean up platform interfaces when unregistering connector', () => {
159
+ const mockFunction = jest.fn();
160
+ const mockConnector = {
161
+ getAuthType: () => 'apiKey',
162
+ createCallLog: jest.fn(),
163
+ updateCallLog: jest.fn()
164
+ };
165
+
166
+ connectorRegistry.registerConnectorInterface('testPlatform', 'testInterface', mockFunction);
167
+ connectorRegistry.registerConnector('testPlatform', mockConnector);
168
+
169
+ expect(connectorRegistry.hasPlatformInterface('testPlatform', 'testInterface')).toBe(true);
170
+
171
+ connectorRegistry.unregisterConnector('testPlatform');
172
+
173
+ expect(connectorRegistry.hasPlatformInterface('testPlatform', 'testInterface')).toBe(false);
174
+ });
175
+
176
+ test('should get connector capabilities correctly', async () => {
177
+ const mockInterface = jest.fn();
178
+ const mockConnector = {
179
+ getAuthType: () => 'apiKey',
180
+ createCallLog: jest.fn(),
181
+ updateCallLog: jest.fn()
182
+ };
183
+
184
+ connectorRegistry.registerConnectorInterface('testPlatform', 'customMethod', mockInterface);
185
+ connectorRegistry.registerConnector('testPlatform', mockConnector);
186
+
187
+ const capabilities = await connectorRegistry.getConnectorCapabilities('testPlatform');
188
+
189
+ expect(capabilities.platform).toBe('testPlatform');
190
+ expect(capabilities.originalMethods).toContain('getAuthType');
191
+ expect(capabilities.originalMethods).toContain('createCallLog');
192
+ expect(capabilities.originalMethods).toContain('updateCallLog');
193
+ expect(capabilities.composedMethods).toContain('customMethod');
194
+ expect(capabilities.registeredInterfaces).toContain('customMethod');
195
+ expect(capabilities.authType).toBe('apiKey');
196
+ });
197
+
198
+ test('should handle interface registration after connector registration', () => {
199
+ const mockConnector = {
200
+ getAuthType: () => 'apiKey',
201
+ createCallLog: jest.fn(),
202
+ updateCallLog: jest.fn()
203
+ };
204
+
205
+ // Register connector first
206
+ connectorRegistry.registerConnector('testPlatform', mockConnector);
207
+
208
+ // Register interface function after
209
+ const mockInterface = jest.fn();
210
+ connectorRegistry.registerConnectorInterface('testPlatform', 'customMethod', mockInterface);
211
+
212
+ // Get composed connector
213
+ const composedConnector = connectorRegistry.getConnector('testPlatform');
214
+
215
+ // Should have the interface function
216
+ expect(composedConnector.customMethod).toBe(mockInterface);
217
+
218
+ // Original connector should be unchanged
219
+ const originalConnector = connectorRegistry.getOriginalConnector('testPlatform');
220
+ expect(originalConnector.customMethod).toBeUndefined();
221
+ });
222
+
223
+ test('should return interface-only connector when no base connector is registered', () => {
224
+ const mockInterface1 = jest.fn();
225
+ const mockInterface2 = jest.fn();
226
+
227
+ // Register only interface functions, no base connector
228
+ connectorRegistry.registerConnectorInterface('interfaceOnlyPlatform', 'method1', mockInterface1);
229
+ connectorRegistry.registerConnectorInterface('interfaceOnlyPlatform', 'method2', mockInterface2);
230
+
231
+ // Get connector - should return interface-only object
232
+ const interfaceOnlyConnector = connectorRegistry.getConnector('interfaceOnlyPlatform');
233
+
234
+ // Should have interface functions
235
+ expect(interfaceOnlyConnector.method1).toBe(mockInterface1);
236
+ expect(interfaceOnlyConnector.method2).toBe(mockInterface2);
237
+
238
+ // Should not have base connector methods
239
+ expect(interfaceOnlyConnector.getAuthType).toBeUndefined();
240
+
241
+ // Should be a plain object, not inherited from any connector
242
+ expect(Object.getPrototypeOf(interfaceOnlyConnector)).toBe(Object.prototype);
243
+ });
244
+
245
+ test('should throw error when no connector and no interfaces are registered', () => {
246
+ expect(() => {
247
+ connectorRegistry.getConnector('nonExistentPlatform');
248
+ }).toThrow('Connector not found for platform: nonExistentPlatform');
249
+ });
250
+
251
+ test('should handle mixed scenarios correctly', async () => {
252
+ // Scenario 1: Only interfaces, no connector
253
+ connectorRegistry.registerConnectorInterface('mixedPlatform', 'interfaceMethod', jest.fn());
254
+ const interfaceOnly = connectorRegistry.getConnector('mixedPlatform');
255
+ expect(interfaceOnly.interfaceMethod).toBeDefined();
256
+ expect(interfaceOnly.getAuthType).toBeUndefined();
257
+
258
+ // Scenario 2: Add connector later
259
+ const mockConnector = {
260
+ getAuthType: () => 'apiKey',
261
+ createCallLog: jest.fn(),
262
+ updateCallLog: jest.fn()
263
+ };
264
+ connectorRegistry.registerConnector('mixedPlatform', mockConnector);
265
+
266
+ const composedConnector = connectorRegistry.getConnector('mixedPlatform');
267
+ expect(composedConnector.interfaceMethod).toBeDefined();
268
+ expect(composedConnector.getAuthType).toBeDefined();
269
+ expect(await composedConnector.getAuthType()).toBe('apiKey');
270
+ });
271
+
272
+ test('should set and get default manifest', () => {
273
+ const defaultManifest = {
274
+ name: 'Default CRM',
275
+ version: '1.0.0',
276
+ features: ['call_logging', 'contact_sync']
277
+ };
278
+
279
+ connectorRegistry.setDefaultManifest(defaultManifest);
280
+
281
+ // Get manifest with fallback should return default
282
+ const manifest = connectorRegistry.getManifest('nonExistentPlatform', true);
283
+ expect(manifest).toEqual(defaultManifest);
284
+ });
285
+
286
+ test('should throw error when getting manifest without fallback and platform not found', () => {
287
+ expect(() => {
288
+ connectorRegistry.getManifest('nonExistentPlatform', false);
289
+ }).toThrow('Manifest not found for platform: nonExistentPlatform');
290
+ });
291
+
292
+ test('should throw error when getting manifest with fallback but no default set', () => {
293
+ connectorRegistry.manifests.clear();
294
+ expect(() => {
295
+ connectorRegistry.getManifest('nonExistentPlatform', true);
296
+ }).toThrow('Manifest not found for platform: nonExistentPlatform');
297
+ });
298
+
299
+ test('should register connector with manifest', () => {
300
+ const mockConnector = {
301
+ getAuthType: () => 'apiKey',
302
+ createCallLog: jest.fn(),
303
+ updateCallLog: jest.fn()
304
+ };
305
+ const manifest = {
306
+ name: 'Test CRM',
307
+ version: '2.0.0',
308
+ authType: 'oauth'
309
+ };
310
+
311
+ connectorRegistry.registerConnector('testPlatformWithManifest', mockConnector, manifest);
312
+
313
+ const retrievedManifest = connectorRegistry.getManifest('testPlatformWithManifest');
314
+ expect(retrievedManifest).toEqual(manifest);
315
+ });
316
+
317
+ test('should set and get release notes', () => {
318
+ const releaseNotes = {
319
+ version: '1.5.0',
320
+ date: '2024-01-15',
321
+ changes: ['Bug fixes', 'New features']
322
+ };
323
+
324
+ connectorRegistry.setReleaseNotes(releaseNotes);
325
+
326
+ // getReleaseNotes currently returns the same object regardless of platform
327
+ const notes = connectorRegistry.getReleaseNotes('anyPlatform');
328
+ expect(notes).toEqual(releaseNotes);
329
+ });
330
+
331
+ test('should get registered platforms', () => {
332
+ const connector1 = {
333
+ getAuthType: () => 'apiKey',
334
+ createCallLog: jest.fn(),
335
+ updateCallLog: jest.fn()
336
+ };
337
+ const connector2 = {
338
+ getAuthType: () => 'oauth',
339
+ createCallLog: jest.fn(),
340
+ updateCallLog: jest.fn()
341
+ };
342
+
343
+ connectorRegistry.registerConnector('platform1', connector1);
344
+ connectorRegistry.registerConnector('platform2', connector2);
345
+
346
+ const platforms = connectorRegistry.getRegisteredPlatforms();
347
+ expect(platforms).toContain('platform1');
348
+ expect(platforms).toContain('platform2');
349
+ expect(platforms).toHaveLength(2);
350
+ });
351
+
352
+ test('should check if platform is registered', () => {
353
+ const mockConnector = {
354
+ getAuthType: () => 'apiKey',
355
+ createCallLog: jest.fn(),
356
+ updateCallLog: jest.fn()
357
+ };
358
+
359
+ connectorRegistry.registerConnector('registeredPlatform', mockConnector);
360
+
361
+ expect(connectorRegistry.isRegistered('registeredPlatform')).toBe(true);
362
+ expect(connectorRegistry.isRegistered('unregisteredPlatform')).toBe(false);
363
+ });
364
+
365
+ test('should throw error for original connector when not found', () => {
366
+ expect(() => {
367
+ connectorRegistry.getOriginalConnector('nonExistentPlatform');
368
+ }).toThrow('Connector not found for platform: nonExistentPlatform');
369
+ });
370
+
371
+ test('should validate connector interface with missing required methods', () => {
372
+ const incompleteConnector = {
373
+ getAuthType: () => 'apiKey',
374
+ createCallLog: jest.fn()
375
+ // Missing updateCallLog
376
+ };
377
+
378
+ expect(() => {
379
+ connectorRegistry.registerConnector('incompletePlatform', incompleteConnector);
380
+ }).toThrow('Connector incompletePlatform missing required method: updateCallLog');
381
+ });
382
+
383
+ test('should return proxy connector when platform not found but proxy exists', () => {
384
+ const proxyConnector = {
385
+ getAuthType: () => 'proxy',
386
+ createCallLog: jest.fn(),
387
+ updateCallLog: jest.fn(),
388
+ proxy: true
389
+ };
390
+
391
+ connectorRegistry.registerConnector('proxy', proxyConnector);
392
+
393
+ const connector = connectorRegistry.getConnector('unknownPlatformWithProxy');
394
+ expect(connector).toBe(proxyConnector);
395
+ expect(connector.proxy).toBe(true);
396
+ });
397
+
398
+ test('should handle getAuthType error in getConnectorCapabilities', async () => {
399
+ const mockConnector = {
400
+ getAuthType: jest.fn().mockRejectedValue(new Error('Auth type error')),
401
+ createCallLog: jest.fn(),
402
+ updateCallLog: jest.fn()
403
+ };
404
+
405
+ connectorRegistry.registerConnector('errorPlatform', mockConnector);
406
+
407
+ const capabilities = await connectorRegistry.getConnectorCapabilities('errorPlatform');
408
+ expect(capabilities.authType).toBe('unknown');
409
+ });
410
+
411
+ test('should handle unregistering non-existent interface gracefully', () => {
412
+ // This should not throw
413
+ connectorRegistry.unregisterConnectorInterface('nonExistentPlatform', 'nonExistentInterface');
414
+ expect(connectorRegistry.hasPlatformInterface('nonExistentPlatform', 'nonExistentInterface')).toBe(false);
415
+ });
416
416
  });