@aperant/framework 0.6.2

package/dist/cli/gate/gates/r-persona-alignment.mjs

@@ -0,0 +1,322 @@
+/**
+ * @internal
+ * G10 r-persona-alignment — persona-aware planning gate (C50).
+ *
+ * Checks that a planned task's `declared_persona_tier` (from
+ * `implementation_plan.json`) aligns with its milestone's `focus_tier` list
+ * (from `.aperant/roadmap/{scope}/milestones.json`). Fires at stage=execute
+ * AND stage=ship (mirrors consistency-check placement — see C50 D-09: gate
+ * runs AFTER plan-mode approval, alongside the other consistency rules).
+ *
+ * Skip cases (C50 locked decisions):
+ *   - D-06: `.aperant/personas.json` is absent → skip with hint pointing at
+ *           /apt:personas. No enforcement until personas exist.
+ *   - D-07: `implementation_plan.json` has no `declared_persona_tier` →
+ *           skip as "pre-C50 task". Backward-compat for plans built before
+ *           C50 shipped.
+ *   - Task has no `milestone_id` (unlinked task) → skip; no milestone to
+ *           resolve focus_tier against.
+ *   - Milestone cannot be found in the linked scope → skip (roadmap drift
+ *           is a separate concern, handled by `roadmap validate-refs`).
+ *   - Milestone has no `focus_tier` field set → skip; the milestone has
+ *           opted out of gating (D-01 backward-compat: absence = no gating).
+ *
+ * Fail / warn cases:
+ *   - declared_persona_tier ∉ milestone.focus_tier → mismatch. Severity is
+ *     resolved per D-05:
+ *       - `focus_tier_enforcement === "blocking"` on the milestone → fail.
+ *       - otherwise (absent or `"warn"`) → warn.
+ *
+ * Multi-persona handling (D-04): when the plan declares multiple tiers via
+ * `declared_persona_tiers: string[]` (plural), the effective tier is the
+ * MINIMUM tier covered (primary > secondary > tertiary). As long as one of
+ * the declared tiers appears in `focus_tier`, the task is in-scope. This
+ * matches how teams reason about work that spans tiers ("this helps primary
+ * AND while we're here, helps tertiary").
+ *
+ * Rejection evidence carries the structured 4-option picker keys per D-08
+ * (`[D]efer`, `[R]eassign`, `[P]romote`, `[F]orce`) so the apt-plan SKILL.md
+ * UX layer can render the picker without re-deriving options — the gate
+ * encodes the menu, the skill surfaces it.
+ */
+import { existsSync, readFileSync } from 'node:fs';
+import { join } from 'node:path';
+import { loadRoadmapForScope } from '../../roadmap/io.mjs';
+import { roadmapScopePaths } from '../../roadmap/paths.mjs';
+import { registerGate } from '../registry.mjs';
+const TIER_PRIORITY = { primary: 0, secondary: 1, tertiary: 2 };
+const gate = {
+    id: 'r-persona-alignment',
+    description: 'Task persona tier aligns with milestone focus_tier (C50). Skipped when personas.json is absent or the task predates C50.',
+    // Registered as 'blocking' so that milestones that opt into enforcement
+    // (focus_tier_enforcement: "blocking") can actually block the skill. The
+    // DEFAULT verdict for a mismatch is 'warn' per D-05; the gate escalates
+    // to 'fail' only when the milestone promoted itself. A 'warn' verdict
+    // from any gate never blocks the CLI (see commands/gate.mjs line ~185),
+    // so warn-severity-by-default is preserved at the effect level even
+    // though the registration slot is 'blocking'.
+    severity: 'blocking',
+    skills: ['execute', 'ship'],
+    async check(ctx) {
+        const personasPath = join(ctx.sharedRoot, '.aperant', 'personas.json');
+        const planPath = join(ctx.taskDir, 'implementation_plan.json');
+        // inputs starts with the two task-level files. The roadmap path is
+        // appended below once the scope is resolved — this ensures the gate
+        // cache hash covers all three files and a roadmap change invalidates
+        // a cached pass/fail result (PRF-001).
+        const inputs = [personasPath, planPath];
+        // D-06: personas.json absent → skip with hint.
+        if (!existsSync(personasPath)) {
+            return {
+                status: 'skip',
+                reason: 'personas.json not present — run /apt:personas first to enable persona-aware planning',
+                inputs,
+            };
+        }
+        if (!existsSync(planPath)) {
+            return {
+                status: 'skip',
+                reason: 'implementation_plan.json not present — nothing to align',
+                inputs,
+            };
+        }
+        let plan;
+        try {
+            plan = JSON.parse(readFileSync(planPath, 'utf-8'));
+        }
+        catch (err) {
+            return {
+                status: 'skip',
+                reason: `implementation_plan.json does not parse (${err.message}) — r-persona-alignment defers to plan-exists`,
+                inputs,
+            };
+        }
+        // D-07: pre-C50 task (no declared_persona_tier / declared_persona_tiers).
+        const declaredTiers = normalizeDeclaredTiers(plan);
+        if (declaredTiers.length === 0) {
+            return {
+                status: 'skip',
+                reason: 'pre-C50 task: no declared_persona_tier — gate does not apply',
+                inputs,
+            };
+        }
+        const taskRecord = ctx.taskRecord ?? null;
+        const milestoneId = taskRecord?.milestone_id ?? null;
+        if (!milestoneId) {
+            return {
+                status: 'skip',
+                reason: 'task has no milestone_id — no focus_tier boundary to check',
+                inputs,
+            };
+        }
+        const scope = taskRecord?.scope || 'project';
+        // Add roadmap path to inputs so the gate cache is invalidated when
+        // the roadmap changes (PRF-001 fix). We use the legacy milestones.json
+        // path — the phases/ layout is covered transitively because
+        // loadRoadmapForScope re-reads from disk on every cache miss.
+        const { jsonPath: roadmapJsonPath } = roadmapScopePaths(ctx.sharedRoot, scope);
+        inputs.push(roadmapJsonPath);
+        const roadmap = loadRoadmapForScope(ctx.sharedRoot, scope);
+        if (!roadmap) {
+            return {
+                status: 'skip',
+                reason: `no roadmap for scope "${scope}" — cannot resolve milestone focus_tier`,
+                inputs,
+            };
+        }
+        const milestone = (roadmap.milestones || []).find((m) => m?.id === milestoneId);
+        if (!milestone) {
+            return {
+                status: 'skip',
+                reason: `milestone "${milestoneId}" not found in scope "${scope}" — roadmap drift is outside the gate's concern`,
+                inputs,
+            };
+        }
+        // D-01: absent focus_tier = legacy behavior (no gating).
+        const focusTier = Array.isArray(milestone.focus_tier) ? milestone.focus_tier : null;
+        if (!focusTier || focusTier.length === 0) {
+            return {
+                status: 'skip',
+                reason: `milestone "${milestoneId}" has no focus_tier — opted out of persona gating`,
+                inputs,
+            };
+        }
+        // D-04: multi-persona → effective tier is the minimum (strongest) tier
+        // covered. If any declared tier is in focus_tier, the task is in-scope.
+        const focusSet = new Set(focusTier);
+        const matched = declaredTiers.find((t) => focusSet.has(t));
+        const effectiveTier = minimumTier(declaredTiers);
+        // SEC-004: cross-reference declared_personas[] IDs against the enrolled
+        // persona roster in personas.json. Phantom IDs (declared but not enrolled)
+        // are surfaced in evidence so the skill layer can warn the user; they do
+        // not change the tier-match result but pair with the consistency rule
+        // (r7-persona-alignment.mjs) which covers the same gap at plan stage.
+        const phantomPersonas = collectPhantomPersonas(plan, personasPath);
+        if (matched) {
+            return {
+                status: 'pass',
+                // Cite `matched` (the tier actually found in focus_tier), not
+                // `effectiveTier` (the minimum/strongest declared tier). When
+                // declaredTiers = ["primary", "tertiary"] and focusTier = ["tertiary"],
+                // matched = "tertiary" and effectiveTier = "primary" — the reason
+                // must reflect which tier satisfied the focus constraint. (LOG-002)
+                reason: `declared tier "${matched}" is in milestone "${milestoneId}" focus_tier [${focusTier.join(', ')}]`,
+                evidence: {
+                    milestone_id: milestoneId,
+                    scope,
+                    focus_tier: focusTier,
+                    declared_tiers: declaredTiers,
+                    effective_tier: effectiveTier,
+                    matched_tier: matched,
+                    ...(phantomPersonas.length > 0 ? { phantom_personas: phantomPersonas } : {}),
+                },
+                inputs,
+            };
+        }
+        // D-05: severity resolution. Per-milestone promotion via
+        // focus_tier_enforcement; default is warn.
+        const enforcement = milestone.focus_tier_enforcement === 'blocking' ? 'blocking' : 'warn';
+        const status = enforcement === 'blocking' ? 'fail' : 'warn';
+        // D-08: structured 4-option picker carried in evidence. The apt-plan
+        // SKILL.md layer reads `rejection_options[]` to render the picker.
+        const rejectionOptions = [
+            {
+                key: 'D',
+                label: 'Defer to later milestone',
+                description: 'Park this task until a milestone with matching focus_tier is active.',
+            },
+            {
+                key: 'R',
+                label: 'Reassign to persona-aligned milestone',
+                description: `Move the task to a milestone whose focus_tier includes "${effectiveTier}".`,
+            },
+            {
+                key: 'P',
+                label: `Promote "${effectiveTier}" into milestone focus_tier`,
+                description: `Edit milestone "${milestoneId}" to add "${effectiveTier}" to focus_tier (expands scope).`,
+            },
+            {
+                key: 'F',
+                label: 'Force-accept (logs override to events)',
+                description: 'Proceed anyway — records an override entry in .aperant/events/{date}.jsonl with reason.',
+            },
+        ];
+        return {
+            status,
+            reason: `declared tier "${effectiveTier}" is not in milestone "${milestoneId}" focus_tier [${focusTier.join(', ')}] (enforcement: ${enforcement})`,
+            evidence: {
+                milestone_id: milestoneId,
+                scope,
+                focus_tier: focusTier,
+                declared_tiers: declaredTiers,
+                effective_tier: effectiveTier,
+                enforcement,
+                rejection_options: rejectionOptions,
+                ...(phantomPersonas.length > 0 ? { phantom_personas: phantomPersonas } : {}),
+            },
+            inputs,
+        };
+    },
+};
+/**
+ * Pull declared tiers from implementation_plan.json. Accepts both:
+ *   - `declared_persona_tier: "primary"` (single-tier, the common case)
+ *   - `declared_persona_tiers: ["primary", "tertiary"]` (multi-persona task)
+ * Filters out anything that isn't one of the three known tier strings.
+ */
+function normalizeDeclaredTiers(plan) {
+    if (!plan || typeof plan !== 'object')
+        return [];
+    const out = [];
+    if (Array.isArray(plan.declared_persona_tiers)) {
+        for (const t of plan.declared_persona_tiers) {
+            if (typeof t === 'string' && t in TIER_PRIORITY)
+                out.push(t);
+        }
+    }
+    if (typeof plan.declared_persona_tier === 'string' &&
+        plan.declared_persona_tier in TIER_PRIORITY) {
+        out.push(plan.declared_persona_tier);
+    }
+    // Dedupe while preserving first occurrence order (primary-first if present).
+    const seen = new Set();
+    return out.filter((t) => {
+        if (seen.has(t))
+            return false;
+        seen.add(t);
+        return true;
+    });
+}
+/**
+ * SEC-004: cross-reference `plan.declared_personas[]` against the enrolled
+ * persona roster in `personas.json`. Returns the subset of declared persona
+ * IDs/names that do NOT appear in the roster — "phantom" references.
+ *
+ * Accepts three persona identity surfaces (mirrors the consistency rule):
+ *   - `persona.id` (top-level field)
+ *   - `persona.ui_json.id` (app-canonical identity)
+ *   - `persona.ui_json.name` (display name)
+ *
+ * @param {unknown} plan
+ * @param {string} personasPath
+ * @returns {string[]}
+ */
+function collectPhantomPersonas(plan, personasPath) {
+    if (!plan || typeof plan !== 'object')
+        return [];
+    const declared = Array.isArray(plan.declared_personas)
+        ? plan.declared_personas.filter((p) => typeof p === 'string' && p.length > 0)
+        : [];
+    if (declared.length === 0)
+        return [];
+    let personasEnv;
+    try {
+        personasEnv = JSON.parse(readFileSync(personasPath, 'utf-8'));
+    }
+    catch {
+        return [];
+    }
+    const known = new Set();
+    const personas = Array.isArray(personasEnv?.personas) ? personasEnv.personas : [];
+    for (const p of personas) {
+        if (!p || typeof p !== 'object')
+            continue;
+        if (typeof p.id === 'string' && p.id.length > 0)
+            known.add(p.id.toLowerCase());
+        if (typeof p.ui_json === 'string' && p.ui_json.length > 0) {
+            try {
+                const ui = JSON.parse(p.ui_json);
+                if (ui && typeof ui === 'object') {
+                    if (typeof ui.id === 'string' && ui.id.length > 0)
+                        known.add(ui.id.toLowerCase());
+                    if (typeof ui.name === 'string' && ui.name.length > 0)
+                        known.add(ui.name.toLowerCase());
+                }
+            }
+            catch {
+                /* ui_json may not be valid JSON — skip */
+            }
+        }
+    }
+    return declared.filter((id) => !known.has(id.toLowerCase()));
+}
+/**
+ * D-04 helper: minimum (strongest) tier covered. primary < secondary < tertiary.
+ */
+function minimumTier(tiers) {
+    let best = null;
+    let bestRank = Infinity;
+    for (const t of tiers) {
+        const rank = TIER_PRIORITY[t];
+        if (rank === undefined)
+            continue;
+        if (rank < bestRank) {
+            best = t;
+            bestRank = rank;
+        }
+    }
+    return best;
+}
+registerGate(gate);
+export default gate;
+//# sourceMappingURL=r-persona-alignment.mjs.map

package/dist/cli/gate/gates/r-persona-alignment.mjs.map

@@ -0,0 +1 @@
+{"version":3,"file":"r-persona-alignment.mjs","sourceRoot":"","sources":["../../../../src/cli/gate/gates/r-persona-alignment.mjs"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAwCG;AAEH,OAAO,EAAE,UAAU,EAAE,YAAY,EAAE,MAAM,SAAS,CAAA;AAClD,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAA;AAChC,OAAO,EAAE,mBAAmB,EAAE,MAAM,sBAAsB,CAAA;AAC1D,OAAO,EAAE,iBAAiB,EAAE,MAAM,yBAAyB,CAAA;AAC3D,OAAO,EAAE,YAAY,EAAE,MAAM,iBAAiB,CAAA;AAE9C,MAAM,aAAa,GAAG,EAAE,OAAO,EAAE,CAAC,EAAE,SAAS,EAAE,CAAC,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAA;AAE/D,MAAM,IAAI,GAAG;IACZ,EAAE,EAAE,qBAAqB;IACzB,WAAW,EACV,0HAA0H;IAC3H,wEAAwE;IACxE,yEAAyE;IACzE,wEAAwE;IACxE,sEAAsE;IACtE,wEAAwE;IACxE,oEAAoE;IACpE,8CAA8C;IAC9C,QAAQ,EAAE,UAAU;IACpB,MAAM,EAAE,CAAC,SAAS,EAAE,MAAM,CAAC;IAC3B,KAAK,CAAC,KAAK,CAAC,GAAG;QACd,MAAM,YAAY,GAAG,IAAI,CAAC,GAAG,CAAC,UAAU,EAAE,UAAU,EAAE,eAAe,CAAC,CAAA;QACtE,MAAM,QAAQ,GAAG,IAAI,CAAC,GAAG,CAAC,OAAO,EAAE,0BAA0B,CAAC,CAAA;QAC9D,mEAAmE;QACnE,oEAAoE;QACpE,qEAAqE;QACrE,uCAAuC;QACvC,MAAM,MAAM,GAAG,CAAC,YAAY,EAAE,QAAQ,CAAC,CAAA;QAEvC,+CAA+C;QAC/C,IAAI,CAAC,UAAU,CAAC,YAAY,CAAC,EAAE,CAAC;YAC/B,OAAO;gBACN,MAAM,EAAE,MAAM;gBACd,MAAM,EACL,sFAAsF;gBACvF,MAAM;aACN,CAAA;QACF,CAAC;QAED,IAAI,CAAC,UAAU,CAAC,QAAQ,CAAC,EAAE,CAAC;YAC3B,OAAO;gBACN,MAAM,EAAE,MAAM;gBACd,MAAM,EAAE,yDAAyD;gBACjE,MAAM;aACN,CAAA;QACF,CAAC;QAED,IAAI,IAAI,CAAA;QACR,IAAI,CAAC;YACJ,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC,CAAA;QACnD,CAAC;QAAC,OAAO,GAAG,EAAE,CAAC;YACd,OAAO;gBACN,MAAM,EAAE,MAAM;gBACd,MAAM,EAAE,4CAA4C,GAAG,CAAC,OAAO,+CAA+C;gBAC9G,MAAM;aACN,CAAA;QACF,CAAC;QAED,0EAA0E;QAC1E,MAAM,aAAa,GAAG,sBAAsB,CAAC,IAAI,CAAC,CAAA;QAClD,IAAI,aAAa,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAChC,OAAO;gBACN,MAAM,EAAE,MAAM;gBACd,MAAM,EAAE,8DAA8D;gBACtE,MAAM;aACN,CAAA;QACF,CAAC;QAED,MAAM,UAAU,GAAG,GAAG,CAAC,UAAU,IAAI,IAAI,CAAA;QACzC,MAAM,WAAW,GAAG,UAAU,EAAE,YAAY,IAAI,IAAI,CAAA;QACpD,IAAI,CAAC,WAAW,EAAE,CAAC;YAClB,OAAO;gBACN,MAAM,EAAE,MAAM;gBACd,MAAM,EAAE,4DAA4D;gBACpE,MAAM;aACN,CAAA;QACF,CAAC;QAED,MAAM,KAAK,GAAG,UAAU,EAAE,KAAK,IAAI,SAAS,CAAA;QAC5C,mEAAmE;QACnE,uEAAuE;QACvE,4DAA4D;QAC5D,8DAA8D;QAC9D,MAAM,EAAE,QAAQ,EAAE,eAAe,EAAE,GAAG,iBAAiB,CAAC,GAAG,CAAC,UAAU,EAAE,KAAK,CAAC,CAAA;QAC9E,MAAM,CAAC,IAAI,CAAC,eAAe,CAAC,CAAA;QAC5B,MAAM,OAAO,GAAG,mBAAmB,CAAC,GAAG,CAAC,UAAU,EAAE,KAAK,CAAC,CAAA;QAC1D,IAAI,CAAC,OAAO,EAAE,CAAC;YACd,OAAO;gBACN,MAAM,EAAE,MAAM;gBACd,MAAM,EAAE,yBAAyB,KAAK,yCAAyC;gBAC/E,MAAM;aACN,CAAA;QACF,CAAC;QAED,MAAM,SAAS,GAAG,CAAC,OAAO,CAAC,UAAU,IAAI,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,EAAE,KAAK,WAAW,CAAC,CAAA;QAC/E,IAAI,CAAC,SAAS,EAAE,CAAC;YAChB,OAAO;gBACN,MAAM,EAAE,MAAM;gBACd,MAAM,EAAE,cAAc,WAAW,yBAAyB,KAAK,iDAAiD;gBAChH,MAAM;aACN,CAAA;QACF,CAAC;QAED,yDAAyD;QACzD,MAAM,SAAS,GAAG,KAAK,CAAC,OAAO,CAAC,SAAS,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,UAAU,CAAC,CAAC,CAAC,IAAI,CAAA;QACnF,IAAI,CAAC,SAAS,IAAI,SAAS,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC1C,OAAO;gBACN,MAAM,EAAE,MAAM;gBACd,MAAM,EAAE,cAAc,WAAW,mDAAmD;gBACpF,MAAM;aACN,CAAA;QACF,CAAC;QAED,uEAAuE;QACvE,wEAAwE;QACxE,MAAM,QAAQ,GAAG,IAAI,GAAG,CAAC,SAAS,CAAC,CAAA;QACnC,MAAM,OAAO,GAAG,aAAa,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAA;QAC1D,MAAM,aAAa,GAAG,WAAW,CAAC,aAAa,CAAC,CAAA;QAEhD,wEAAwE;QACxE,2EAA2E;QAC3E,yEAAyE;QACzE,sEAAsE;QACtE,sEAAsE;QACtE,MAAM,eAAe,GAAG,sBAAsB,CAAC,IAAI,EAAE,YAAY,CAAC,CAAA;QAElE,IAAI,OAAO,EAAE,CAAC;YACb,OAAO;gBACN,MAAM,EAAE,MAAM;gBACd,8DAA8D;gBAC9D,8DAA8D;gBAC9D,wEAAwE;gBACxE,kEAAkE;gBAClE,oEAAoE;gBACpE,MAAM,EAAE,kBAAkB,OAAO,sBAAsB,WAAW,iBAAiB,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG;gBAC1G,QAAQ,EAAE;oBACT,YAAY,EAAE,WAAW;oBACzB,KAAK;oBACL,UAAU,EAAE,SAAS;oBACrB,cAAc,EAAE,aAAa;oBAC7B,cAAc,EAAE,aAAa;oBAC7B,YAAY,EAAE,OAAO;oBACrB,GAAG,CAAC,eAAe,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,EAAE,gBAAgB,EAAE,eAAe,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;iBAC5E;gBACD,MAAM;aACN,CAAA;QACF,CAAC;QAED,yDAAyD;QACzD,2CAA2C;QAC3C,MAAM,WAAW,GAAG,SAAS,CAAC,sBAAsB,KAAK,UAAU,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,MAAM,CAAA;QACzF,MAAM,MAAM,GAAG,WAAW,KAAK,UAAU,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,MAAM,CAAA;QAE3D,qEAAqE;QACrE,mEAAmE;QACnE,MAAM,gBAAgB,GAAG;YACxB;gBACC,GAAG,EAAE,GAAG;gBACR,KAAK,EAAE,0BAA0B;gBACjC,WAAW,EAAE,sEAAsE;aACnF;YACD;gBACC,GAAG,EAAE,GAAG;gBACR,KAAK,EAAE,uCAAuC;gBAC9C,WAAW,EAAE,2DAA2D,aAAa,IAAI;aACzF;YACD;gBACC,GAAG,EAAE,GAAG;gBACR,KAAK,EAAE,YAAY,aAAa,6BAA6B;gBAC7D,WAAW,EAAE,mBAAmB,WAAW,aAAa,aAAa,kCAAkC;aACvG;YACD;gBACC,GAAG,EAAE,GAAG;gBACR,KAAK,EAAE,wCAAwC;gBAC/C,WAAW,EACV,yFAAyF;aAC1F;SACD,CAAA;QAED,OAAO;YACN,MAAM;YACN,MAAM,EAAE,kBAAkB,aAAa,0BAA0B,WAAW,iBAAiB,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC,mBAAmB,WAAW,GAAG;YAClJ,QAAQ,EAAE;gBACT,YAAY,EAAE,WAAW;gBACzB,KAAK;gBACL,UAAU,EAAE,SAAS;gBACrB,cAAc,EAAE,aAAa;gBAC7B,cAAc,EAAE,aAAa;gBAC7B,WAAW;gBACX,iBAAiB,EAAE,gBAAgB;gBACnC,GAAG,CAAC,eAAe,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,EAAE,gBAAgB,EAAE,eAAe,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;aAC5E;YACD,MAAM;SACN,CAAA;IACF,CAAC;CACD,CAAA;AAED;;;;;GAKG;AACH,SAAS,sBAAsB,CAAC,IAAI;IACnC,IAAI,CAAC,IAAI,IAAI,OAAO,IAAI,KAAK,QAAQ;QAAE,OAAO,EAAE,CAAA;IAChD,MAAM,GAAG,GAAG,EAAE,CAAA;IACd,IAAI,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,sBAAsB,CAAC,EAAE,CAAC;QAChD,KAAK,MAAM,CAAC,IAAI,IAAI,CAAC,sBAAsB,EAAE,CAAC;YAC7C,IAAI,OAAO,CAAC,KAAK,QAAQ,IAAI,CAAC,IAAI,aAAa;gBAAE,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAC7D,CAAC;IACF,CAAC;IACD,IACC,OAAO,IAAI,CAAC,qBAAqB,KAAK,QAAQ;QAC9C,IAAI,CAAC,qBAAqB,IAAI,aAAa,EAC1C,CAAC;QACF,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,qBAAqB,CAAC,CAAA;IACrC,CAAC;IACD,6EAA6E;IAC7E,MAAM,IAAI,GAAG,IAAI,GAAG,EAAE,CAAA;IACtB,OAAO,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE;QACvB,IAAI,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC;YAAE,OAAO,KAAK,CAAA;QAC7B,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,CAAA;QACX,OAAO,IAAI,CAAA;IACZ,CAAC,CAAC,CAAA;AACH,CAAC;AAED;;;;;;;;;;;;;GAaG;AACH,SAAS,sBAAsB,CAAC,IAAI,EAAE,YAAY;IACjD,IAAI,CAAC,IAAI,IAAI,OAAO,IAAI,KAAK,QAAQ;QAAE,OAAO,EAAE,CAAA;IAChD,MAAM,QAAQ,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,iBAAiB,CAAC;QACrD,CAAC,CAAC,IAAI,CAAC,iBAAiB,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,OAAO,CAAC,KAAK,QAAQ,IAAI,CAAC,CAAC,MAAM,GAAG,CAAC,CAAC;QAC7E,CAAC,CAAC,EAAE,CAAA;IACL,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,EAAE,CAAA;IAEpC,IAAI,WAAW,CAAA;IACf,IAAI,CAAC;QACJ,WAAW,GAAG,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,YAAY,EAAE,OAAO,CAAC,CAAC,CAAA;IAC9D,CAAC;IAAC,MAAM,CAAC;QACR,OAAO,EAAE,CAAA;IACV,CAAC;IACD,MAAM,KAAK,GAAG,IAAI,GAAG,EAAE,CAAA;IACvB,MAAM,QAAQ,GAAG,KAAK,CAAC,OAAO,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAC,CAAC,CAAC,WAAW,CAAC,QAAQ,CAAC,CAAC,CAAC,EAAE,CAAA;IACjF,KAAK,MAAM,CAAC,IAAI,QAAQ,EAAE,CAAC;QAC1B,IAAI,CAAC,CAAC,IAAI,OAAO,CAAC,KAAK,QAAQ;YAAE,SAAQ;QACzC,IAAI,OAAO,CAAC,CAAC,EAAE,KAAK,QAAQ,IAAI,CAAC,CAAC,EAAE,CAAC,MAAM,GAAG,CAAC;YAAE,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,WAAW,EAAE,CAAC,CAAA;QAC9E,IAAI,OAAO,CAAC,CAAC,OAAO,KAAK,QAAQ,IAAI,CAAC,CAAC,OAAO,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAC3D,IAAI,CAAC;gBACJ,MAAM,EAAE,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,CAAA;gBAChC,IAAI,EAAE,IAAI,OAAO,EAAE,KAAK,QAAQ,EAAE,CAAC;oBAClC,IAAI,OAAO,EAAE,CAAC,EAAE,KAAK,QAAQ,IAAI,EAAE,CAAC,EAAE,CAAC,MAAM,GAAG,CAAC;wBAAE,KAAK,CAAC,GAAG,CAAC,EAAE,CAAC,EAAE,CAAC,WAAW,EAAE,CAAC,CAAA;oBACjF,IAAI,OAAO,EAAE,CAAC,IAAI,KAAK,QAAQ,IAAI,EAAE,CAAC,IAAI,CAAC,MAAM,GAAG,CAAC;wBAAE,KAAK,CAAC,GAAG,CAAC,EAAE,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC,CAAA;gBACxF,CAAC;YACF,CAAC;YAAC,MAAM,CAAC;gBACR,0CAA0C;YAC3C,CAAC;QACF,CAAC;IACF,CAAC;IACD,OAAO,QAAQ,CAAC,MAAM,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,EAAE,CAAC,WAAW,EAAE,CAAC,CAAC,CAAA;AAC7D,CAAC;AAED;;GAEG;AACH,SAAS,WAAW,CAAC,KAAK;IACzB,IAAI,IAAI,GAAG,IAAI,CAAA;IACf,IAAI,QAAQ,GAAG,QAAQ,CAAA;IACvB,KAAK,MAAM,CAAC,IAAI,KAAK,EAAE,CAAC;QACvB,MAAM,IAAI,GAAG,aAAa,CAAC,CAAC,CAAC,CAAA;QAC7B,IAAI,IAAI,KAAK,SAAS;YAAE,SAAQ;QAChC,IAAI,IAAI,GAAG,QAAQ,EAAE,CAAC;YACrB,IAAI,GAAG,CAAC,CAAA;YACR,QAAQ,GAAG,IAAI,CAAA;QAChB,CAAC;IACF,CAAC;IACD,OAAO,IAAI,CAAA;AACZ,CAAC;AAED,YAAY,CAAC,IAAI,CAAC,CAAA;AAClB,eAAe,IAAI,CAAA"}

package/dist/cli/gate/gates/review-clean.d.mts

@@ -0,0 +1,21 @@
+export default gate;
+declare namespace gate {
+    let id: string;
+    let description: string;
+    let severity: string;
+    let skills: string[];
+    function check(ctx: any): Promise<{
+        status: string;
+        reason: string;
+        inputs: string[];
+        evidence?: undefined;
+    } | {
+        status: string;
+        reason: string;
+        evidence: {
+            unresolved: any;
+        };
+        inputs: string[];
+    }>;
+}
+//# sourceMappingURL=review-clean.d.mts.map

package/dist/cli/gate/gates/review-clean.d.mts.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-clean.d.mts","sourceRoot":"","sources":["../../../../src/cli/gate/gates/review-clean.mjs"],"names":[],"mappings":";;;;;;IAuBC;;;;;;;;;;;;OA+CC"}

package/dist/cli/gate/gates/review-clean.mjs

@@ -0,0 +1,71 @@
+/**
+ * @internal
+ * G5 review-clean — blocking gate for `apt:ship`.
+ *
+ * Skipped when {task_dir}/review.json is absent (review is optional for some
+ * tracks). When it is present, fails if any finding has
+ * severity ∈ {"critical", "warning"} AND resolved !== true.
+ *
+ * The findings array may be under `findings` or `issues` depending on the
+ * reviewer format — we accept either.
+ */
+import { existsSync, readFileSync } from 'node:fs';
+import { join } from 'node:path';
+import { registerGate } from '../registry.mjs';
+const BLOCKING_SEVERITIES = new Set(['critical', 'warning']);
+const gate = {
+    id: 'review-clean',
+    description: 'review.json has no unresolved critical/warning findings (skipped if absent)',
+    severity: 'blocking',
+    skills: ['ship'],
+    async check(ctx) {
+        const path = join(ctx.taskDir, 'review.json');
+        const inputs = [path];
+        if (!existsSync(path)) {
+            return {
+                status: 'skip',
+                reason: 'review.json not present — skipping review-clean',
+                inputs,
+            };
+        }
+        let doc;
+        try {
+            doc = JSON.parse(readFileSync(path, 'utf-8'));
+        }
+        catch (err) {
+            return {
+                status: 'fail',
+                reason: `review.json does not parse: ${err.message}`,
+                inputs,
+            };
+        }
+        const findings = Array.isArray(doc.findings)
+            ? doc.findings
+            : Array.isArray(doc.issues)
+                ? doc.issues
+                : [];
+        const unresolved = findings.filter((f) => BLOCKING_SEVERITIES.has(f?.severity) && f?.resolved !== true);
+        if (unresolved.length > 0) {
+            return {
+                status: 'fail',
+                reason: `${unresolved.length} unresolved critical/warning finding(s) in review.json`,
+                evidence: {
+                    unresolved: unresolved.map((f) => ({
+                        severity: f.severity,
+                        id: f.id ?? null,
+                        title: f.title ?? f.message ?? null,
+                    })),
+                },
+                inputs,
+            };
+        }
+        return {
+            status: 'pass',
+            reason: `review.json has no unresolved critical/warning findings (${findings.length} total)`,
+            inputs,
+        };
+    },
+};
+registerGate(gate);
+export default gate;
+//# sourceMappingURL=review-clean.mjs.map

package/dist/cli/gate/gates/review-clean.mjs.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-clean.mjs","sourceRoot":"","sources":["../../../../src/cli/gate/gates/review-clean.mjs"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG;AAEH,OAAO,EAAE,UAAU,EAAE,YAAY,EAAE,MAAM,SAAS,CAAA;AAClD,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAA;AAChC,OAAO,EAAE,YAAY,EAAE,MAAM,iBAAiB,CAAA;AAE9C,MAAM,mBAAmB,GAAG,IAAI,GAAG,CAAC,CAAC,UAAU,EAAE,SAAS,CAAC,CAAC,CAAA;AAE5D,MAAM,IAAI,GAAG;IACZ,EAAE,EAAE,cAAc;IAClB,WAAW,EAAE,6EAA6E;IAC1F,QAAQ,EAAE,UAAU;IACpB,MAAM,EAAE,CAAC,MAAM,CAAC;IAChB,KAAK,CAAC,KAAK,CAAC,GAAG;QACd,MAAM,IAAI,GAAG,IAAI,CAAC,GAAG,CAAC,OAAO,EAAE,aAAa,CAAC,CAAA;QAC7C,MAAM,MAAM,GAAG,CAAC,IAAI,CAAC,CAAA;QACrB,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,EAAE,CAAC;YACvB,OAAO;gBACN,MAAM,EAAE,MAAM;gBACd,MAAM,EAAE,iDAAiD;gBACzD,MAAM;aACN,CAAA;QACF,CAAC;QACD,IAAI,GAAG,CAAA;QACP,IAAI,CAAC;YACJ,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC,CAAA;QAC9C,CAAC;QAAC,OAAO,GAAG,EAAE,CAAC;YACd,OAAO;gBACN,MAAM,EAAE,MAAM;gBACd,MAAM,EAAE,+BAA+B,GAAG,CAAC,OAAO,EAAE;gBACpD,MAAM;aACN,CAAA;QACF,CAAC;QACD,MAAM,QAAQ,GAAG,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,QAAQ,CAAC;YAC3C,CAAC,CAAC,GAAG,CAAC,QAAQ;YACd,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,MAAM,CAAC;gBAC1B,CAAC,CAAC,GAAG,CAAC,MAAM;gBACZ,CAAC,CAAC,EAAE,CAAA;QACN,MAAM,UAAU,GAAG,QAAQ,CAAC,MAAM,CACjC,CAAC,CAAC,EAAE,EAAE,CAAC,mBAAmB,CAAC,GAAG,CAAC,CAAC,EAAE,QAAQ,CAAC,IAAI,CAAC,EAAE,QAAQ,KAAK,IAAI,CACnE,CAAA;QACD,IAAI,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAC3B,OAAO;gBACN,MAAM,EAAE,MAAM;gBACd,MAAM,EAAE,GAAG,UAAU,CAAC,MAAM,wDAAwD;gBACpF,QAAQ,EAAE;oBACT,UAAU,EAAE,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;wBAClC,QAAQ,EAAE,CAAC,CAAC,QAAQ;wBACpB,EAAE,EAAE,CAAC,CAAC,EAAE,IAAI,IAAI;wBAChB,KAAK,EAAE,CAAC,CAAC,KAAK,IAAI,CAAC,CAAC,OAAO,IAAI,IAAI;qBACnC,CAAC,CAAC;iBACH;gBACD,MAAM;aACN,CAAA;QACF,CAAC;QACD,OAAO;YACN,MAAM,EAAE,MAAM;YACd,MAAM,EAAE,4DAA4D,QAAQ,CAAC,MAAM,SAAS;YAC5F,MAAM;SACN,CAAA;IACF,CAAC;CACD,CAAA;AAED,YAAY,CAAC,IAAI,CAAC,CAAA;AAClB,eAAe,IAAI,CAAA"}

package/dist/cli/gate/gates/tdd-iron-law.d.mts

@@ -0,0 +1,25 @@
+export default gate;
+declare namespace gate {
+    let id: string;
+    let description: string;
+    let severity: string;
+    let skills: string[];
+    function check(ctx: any): Promise<{
+        status: string;
+        reason: string;
+        inputs: string[];
+        evidence?: undefined;
+    } | {
+        status: string;
+        reason: string;
+        evidence: {
+            results: {
+                status: string;
+                reason: string;
+                subtaskId: any;
+            }[];
+        };
+        inputs: string[];
+    }>;
+}
+//# sourceMappingURL=tdd-iron-law.d.mts.map

package/dist/cli/gate/gates/tdd-iron-law.d.mts.map

@@ -0,0 +1 @@
+{"version":3,"file":"tdd-iron-law.d.mts","sourceRoot":"","sources":["../../../../src/cli/gate/gates/tdd-iron-law.mjs"],"names":[],"mappings":";;;;;;IA0KC;;;;;;;;;;;;;;;;OA2EC"}