@anhth2/spec-driven-dev-plugin 0.7.0 → 0.9.0

package/steps/context-loader.md

@@ -42,6 +42,7 @@ Read `.agent/project-context.yaml`. Extract and store:
 - `paths.core_entities` → path to core-entities.md
 - `paths.tech_docs_dir` → technical documentation root
 - `paths.trace_dir` → trace state directory
+- `paths.design_spec_dir` → Design Spec documents root (FE/App only)
 
 If `paths` section is absent, use these defaults:
 - `specs_dir` = `specs/bdd`
@@ -53,11 +54,75 @@ If `paths` section is absent, use these defaults:
 - `core_entities` = `specs/domain-knowledge/core-entities.md`
 - `tech_docs_dir` = `specs/tech-docs`
 - `trace_dir` = `.trace`
+- `design_spec_dir` = `specs/design-spec`
 
 If `tech_stack.module` is set, also load `.agent/modules/{module}/stack-profile.yaml` if it exists.
 
 ---
 
+## Step 1.5 — [SERVICE ROUTING] Resolve service paths (umbrella mode)
+
+*Skip this step entirely if `setup.mode` is not `"umbrella"` and `services` section is absent from project-context.yaml.*
+
+If `services` section is present:
+
+**1. Detect active domain** (in priority order):
+- Read `@trace.domain` from target file frontmatter (if Gate loaded a target file)
+- Extract from target file path: segment immediately after `prd_dir` base path  
+  *(e.g., `specs/prd/user/FEAT-01.md` → domain = `user`)*
+- If `$ARGUMENTS` contains a path, extract the segment after `prd_dir`
+
+**2. Route to service** — if active domain matches a key in `services`:
+- Override `paths.specs_dir` → `services.{domain}.specs_dir`
+- Override `paths.tech_docs_dir` → `services.{domain}.tech_docs_dir`
+- Store `active_service` = `services.{domain}.path`
+- Store `active_service_module` = `services.{domain}.module`
+- If service has its own `module` → use it as `active_module` (overrides `tech_stack.module`)
+
+**3. Fallback** — if domain not detected or no matching service key:
+- Keep default paths from Step 1
+- Set `active_service = unresolved`
+
+**4. Spec source auto-override** — if `setup.spec_source` is set AND the corresponding path was not already explicitly set in `paths:`:
+- Override `paths.prd_dir` → `{spec_source}/specs/prd`
+- Override `paths.design_spec_dir` → `{spec_source}/specs/design-spec`
+- Override `paths.domain_knowledge_dir` → `{spec_source}/specs/domain-knowledge`
+- Override `paths.business_dictionary` → `{spec_source}/specs/domain-knowledge/business-dictionary.md`
+- Override `paths.core_entities` → `{spec_source}/specs/domain-knowledge/core-entities.md`
+- Override `paths.bug_reports_dir` → `{spec_source}/feedback/bug-reports`
+- Override `paths.bdd_proposals_dir` → `{spec_source}/feedback/bdd-proposals`
+
+> **Why under `spec_source`:** tester feedback (`/report-bug`, `/propose-scenario`) must land in the **shared spec repo** so PO/Dev see it when they `/sync`. In single-service mode (no `spec_source`), these default to `feedback/bug-reports` and `feedback/bdd-proposals` at repo root — still shared, same repo.
+
+---
+
+## Step 1.6 — [SERVICE CONVENTIONS] Load service-specific conventions (umbrella mode)
+
+*Skip this step entirely if `active_service` is `"unresolved"` or context is single-service mode.*
+
+When `active_service` has been resolved to a real path in Step 1.5 (e.g., `user-service/`):
+
+**1. Locate service config** — try in priority order:
+- `{active_service}/.agent/project-context.yaml`
+- `{active_service}/project-context.yaml`
+
+**2. If found, override with service-specific values:**
+
+| Variable | Source |
+|----------|--------|
+| `conventions.test_command` | service's `conventions.test_command` |
+| `conventions.build_command` | service's `conventions.build_command` |
+| `paths.trace_dir` | `{active_service}/{service paths.trace_dir}` — default: `{active_service}/.trace` |
+| `paths.specs_dir` | `{active_service}/{service paths.specs_dir}` (if set in service config, else keep Step 1.5 override) |
+
+**3. Store** `service_root = {active_service}` as the working directory anchor for all downstream commands:
+- Shell commands (`/run-tests`, `/generate-tests`) run **from within** `service_root`
+- File write operations (test files, trace TSVs) use paths **relative to** `service_root`
+
+**4. If service config not found** — keep umbrella defaults, still set `service_root = {active_service}` (path anchor is always needed even without a config override).
+
+---
+
 ## Step 2 — [PROJECT-CONFIG] Load module stack profile (conditional)
 
 If `tech_stack.module` is set, read `.agent/modules/{module}/stack-profile.yaml`.
@@ -148,6 +213,25 @@ These two variables (`active_module`, `platform_type`) are the canonical source
 
 ---
 
+## Step 6.7 — [GUARDRAILS] Load Project Lessons (conditional)
+
+*Accumulated mistakes the AI must not repeat in this project. These are added over time via `/learn`
+or accepted during `/review-code`, `/fix-bug`, `/debug`.*
+
+Resolve the lessons file path:
+- Use `paths.lessons_file` if set (may be service-overridden in umbrella mode, Step 1.6)
+- Else default `specs/domain-knowledge/lessons-learned.md`
+- In umbrella/service mode (when `service_root` is set), if `paths.lessons_file` is unset, default to `{service_root}/.agent/project-lessons.md`
+
+If the file exists, read it and store ALL lessons as **ACTIVE GUARDRAILS** for the session:
+- Treat each lesson's **Rule** as a hard constraint — same priority as CLAUDE.md coding standards (Step 3).
+- Before generating or modifying any artifact (PRD, BDD, tech-doc, code, test), check the output against every lesson whose `category` matches the current command AND whose `scope` matches the target (domain / file).
+- If a generated output would violate a lesson → correct it **before** presenting, and note which lesson (`L-NNN`) was applied.
+
+If the file does not exist → skip silently (no lessons captured yet).
+
+---
+
 ## Step 7 — [RECAP] Working Memory Recap (anti-lost-in-middle)
 
 After loading all context, synthesize and output a compact summary block.
@@ -163,6 +247,9 @@ Layers    : {layer order from CLAUDE.md §2, e.g., Controller → Facade → Ser
 Ticket    : {ticket_prefix}-
 Dict      : {loaded — N canonical terms, M banned terms | missing}
 Entities  : {loaded — EntityA, EntityB, EntityC | missing}
+Lessons   : {loaded — N guardrails | none yet}
+Service   : {active_service} ({active_service_module}) | single-service
+Svc Root  : {service_root} — conventions + trace_dir loaded from service config | —
 Status    : {FULL | PARTIAL — missing: CLAUDE.md / business-dict / core-entities | MINIMAL}
 ```
 

package/steps/report-footer.md

@@ -30,7 +30,8 @@ Suggest the logical next command based on workflow phase:
 | /define-product         | `/generate-prd {product-definition-file}`     |
 | /generate-prd           | `/refine-prd {prd-file}` then `/review-context {prd-file}` |
 | /refine-prd             | Open Review Board → update PRD → `/review-context {prd-file}` |
-| /review-context (PRD)   | `/generate-bdd {prd-file}` if APPROVED; fix PRD if NEEDS_FIX |
+| /review-context (PRD)   | FE/App: `/generate-design-spec {prd-file}` (then BDD after sign-off); BE: `/generate-bdd {prd-file}` directly; fix PRD if NEEDS_FIX |
+| /generate-design-spec   | Designer review → Figma links confirmed → PO + Designer sign-off → `/generate-bdd {prd-file}` |
 | /generate-bdd           | `/review-context {feature-file}` to verify coverage |
 | /review-context (BDD)   | `/generate-tech-docs {UC-ID}` if APPROVED; regenerate if NEEDS_FIX |
 | /generate-tech-docs     | `/review-tech-docs {tech-design-file}`        |
@@ -44,6 +45,11 @@ Suggest the logical next command based on workflow phase:
 | /validate-traces        | DRIFT/UNTRACKED → `/generate-code {UC-ID}`; GAP → `/generate-tests {UC-ID}`; all OK → create PR |
 | /fix-bug                | Create PR and link to ticket                  |
 | /debug                  | `/fix-bug {ticket-id}` if fix needed          |
+| /report-bug             | Send to dev (`/fix-bug {BUG-ID}`); if coverage gap → `/propose-scenario {UC-ID}` |
+| /propose-scenario       | Notify PO/Dev to review the proposal in `feedback/bdd-proposals/` |
+| /learn                  | Continue working — lesson applies on next command |
+| /sync                   | `/validate-traces` for full coverage; act on any `📥 tester feedback` surfaced |
+| /update-framework       | Review `git diff .agent/`, commit; `/sync` for project content |
 
 Format the footer as:
 ```

package/templates/design-spec.template.md

@@ -0,0 +1,209 @@
+# {TICKET-ID} {Feature Name} — Design Spec [{Platform}]
+
+<!--
+  Template này được sử dụng bởi /generate-design-spec.
+  Platform = web | app | app-ios | app-android
+
+  PLATFORM SECTIONS:
+  - Section 3A + 4A: chỉ dành cho web (react/nextjs/vue/angular). Xóa C khi dùng cho web.
+  - Section 3C + 4B: chỉ dành cho app (flutter/react-native/ios/android). Xóa A+B khi dùng cho app.
+
+  COMPONENT MAPPING (bắt buộc):
+  - Mọi component trong Component Inventory PHẢI được map với figma-components/{module}.md
+  - ✅ Matched     → dùng Code Component và Import Path từ catalog
+  - ⚠️ TODO        → đánh dấu [TODO — chưa implement]
+  - ❌ Chưa có     → đánh dấu [NEW — cần confirm với designer]
+
+  SCREEN STATES (bắt buộc mỗi màn):
+  - Tối thiểu: default, loading, error
+  - Thêm "empty" nếu màn có thể hiển thị trạng thái không có dữ liệu
+  - Thêm "success" nếu action tạo ra trạng thái xác nhận riêng biệt
+-->
+
+---
+
+## Metadata
+
+| Field              | Value                                                         |
+|--------------------|---------------------------------------------------------------|
+| **Spec ID**        | {TICKET-ID}-DS-{platform}                                     |
+| **Version**        | 1.0                                                           |
+| **Status**         | draft / approved                                              |
+| **Platform**       | {web \| app \| app-ios \| app-android}                        |
+| **Module**         | {active_module}                                               |
+| **Service**        | {active_service}                                              |
+| **Domain**         | {domain}                                                      |
+| **Business PRD**   | [{TICKET-ID}](./{TICKET-ID}-slug.md)                          |
+| **Figma**          | {figma_url or TBD}                                            |
+| **Author**         | {PO name or "AI-assisted"}                                    |
+| **Created**        | {YYYY-MM-DD}                                                  |
+| **Updated**        | {YYYY-MM-DD}                                                  |
+
+---
+
+# 1. Screen Inventory
+
+| # | Screen Name | Entry Point | Figma Frame | Notes |
+|---|-------------|-------------|-------------|-------|
+| 1 | {Screen 1}  | {how user arrives} | [Frame]({figma_url}) | |
+| 2 | {Screen 2}  | {entry point} | [Frame]({figma_url}) | |
+
+---
+
+# 2. Screen Specs
+
+## Screen 1: {Screen Name}
+
+**Figma**: [{Frame name}]({figma_frame_url})
+
+### Layout
+
+{Grid / max-width / padding / spacing — reference design tokens where applicable}
+
+### Component Inventory
+
+| Component (Figma)      | Code Component | Import Path            | States                          | Notes   |
+|------------------------|----------------|------------------------|---------------------------------|---------|
+| {Figma/Button/Primary} | Button         | @/components/ui/Button | default, loading, disabled      |         |
+| {Figma/Input/Text}     | TextInput      | @/components/ui/Input  | default, focus, error, disabled |         |
+
+### Screen States
+
+| State     | Trigger                          | UI Behavior                                              |
+|-----------|----------------------------------|----------------------------------------------------------|
+| default   | Screen loaded, data available    | {Describe full rendered appearance}                      |
+| loading   | API call in flight               | {Skeleton / spinner position and style}                  |
+| error     | API failure / validation error   | {Toast / inline error / error screen + recovery CTA}     |
+| empty     | No data returned                 | {Illustration + CTA — e.g., "No items yet. Add one →"}   |
+| success   | Action completed (if applicable) | {Confirmation toast / navigation / visual change}        |
+
+### Actions & Navigation
+
+| Action          | Trigger                   | Result                                            |
+|-----------------|---------------------------|---------------------------------------------------|
+| {Action name}   | Tap/click {element}       | Navigate to {Screen N} / Open {Modal name}        |
+| {Back/Cancel}   | Back gesture / button     | Return to {previous screen} without saving        |
+
+---
+
+<!--  Repeat ## Screen N for each additional screen  -->
+
+---
+
+# 3. Interaction Patterns
+
+<!-- === WEB ONLY — delete this section for app === -->
+
+## A. Responsive Behavior  *(web)*
+
+| Breakpoint | Width      | Layout Changes                              |
+|------------|------------|---------------------------------------------|
+| Mobile     | < 768px    | {Single column, bottom nav, full-width CTA} |
+| Tablet     | 768–1279px | {2-col grid, sidebar collapsed}             |
+| Desktop    | ≥ 1280px   | {Full layout, max-width 1440px}             |
+
+## B. Hover / Focus / Keyboard  *(web)*
+
+| Element        | Hover                         | Focus                           | Keyboard      |
+|----------------|-------------------------------|---------------------------------|---------------|
+| Primary button | Background → {color.hover}    | Outline 2px {color.focus}       | Enter / Space |
+| Text input     | Border → {color.border.hover} | Border → {color.primary}        | Tab to focus  |
+
+<!-- === APP ONLY — delete sections A+B for app === -->
+
+## C. Gestures & Navigation  *(app)*
+
+| Gesture              | Screen / Element    | Behavior                                    |
+|----------------------|---------------------|---------------------------------------------|
+| Back gesture         | All screens         | {Return / show "Discard changes?" dialog}   |
+| Pull-to-refresh      | {Screen names}      | Refresh data, spinner at top                |
+| Swipe left on row    | {List item}         | Reveal {Delete / Archive} action            |
+
+### Navigation Stack  *(app)*
+
+```
+{e.g., BottomTab(Home) → ListPage → DetailPage → EditPage}
+```
+
+### Platform Conventions  *(app)*
+
+| Aspect           | iOS                                       | Android                             |
+|------------------|-------------------------------------------|-------------------------------------|
+| Navigation bar   | Back button top-left, title centered      | Up arrow, title left-aligned        |
+| Bottom sheet     | UISheetPresentation, grabber visible      | BottomSheet, drag handle            |
+| Dialog           | Actions right-aligned                     | Actions left-aligned                |
+
+---
+
+# 4. Platform Considerations
+
+<!-- === WEB ONLY === -->
+
+## A. Accessibility  *(web)*
+
+- [ ] All interactive elements reachable by Tab key — no keyboard traps
+- [ ] Focus trap inside modals
+- [ ] Icon-only buttons have `aria-label`
+- [ ] Dynamic content announces via `aria-live`
+- [ ] WCAG AA contrast: text ≥ 4.5:1, large text ≥ 3:1
+- [ ] Form inputs have visible labels (not placeholder-only)
+
+<!-- === APP ONLY === -->
+
+## B. Device & OS  *(app)*
+
+- [ ] Safe area insets applied (top + bottom) on all screens
+- [ ] Minimum touch target: 44×44pt (iOS) / 48×48dp (Android)
+- [ ] Tested on 375pt (iPhone SE) and 360dp (small Android)
+- [ ] Deep link: `{scheme}://{host}/{path}` → {screen name}
+- [ ] Permissions: {Camera / Location / Notification} — rationale copy TBD
+- [ ] Offline: {screen name} shows cached data + banner; {action} disabled with tooltip
+- [ ] Dark mode tested — no hardcoded colors
+
+---
+
+# 5. AC-UI — Design Acceptance Criteria
+
+> Reviewed and signed off by **PO + Designer** before BDD generation.
+> Complements business-level AC in [Business PRD](./{TICKET-ID}-slug.md).
+
+| ID     | Acceptance Criterion                                                     | Verified by     |
+|--------|--------------------------------------------------------------------------|-----------------|
+| AC-UI1 | All screens match approved Figma frames within design-system tolerances  | Designer        |
+| AC-UI2 | Loading state appears within 200ms of any API call initiation            | QA              |
+| AC-UI3 | All error messages are visible, descriptive, and include a recovery CTA  | PO              |
+| AC-UI4 | Empty states include illustration and call-to-action                     | PO + Designer   |
+| AC-UI5 | {Platform-specific criterion}                                            | QA              |
+
+---
+
+# Appendix
+
+## Figma Summary
+
+| Screen     | Figma Frame          | Status                         |
+|------------|----------------------|--------------------------------|
+| {Screen 1} | [Link]({url})        | ✅ Ready / ⏳ WIP / ❌ Missing  |
+
+## Design Tokens Referenced
+
+| Token             | Value    | Used in                    |
+|-------------------|----------|----------------------------|
+| `color.primary`   | {#hex}   | Buttons, links             |
+| `spacing.md`      | {16px}   | Standard vertical gap      |
+
+## References
+
+- [{TICKET-ID}](./{TICKET-ID}-slug.md) — Business PRD
+
+## AI Assumptions
+
+- {Assumption — [AI DRAFT]}
+
+---
+
+## Changelog
+
+| Version | Date         | Changes         |
+|---------|--------------|-----------------|
+| 1.0     | {YYYY-MM-DD} | Initial version |

package/templates/project-context.yaml

@@ -45,12 +45,26 @@ paths:
   business_dictionary: "specs/domain-knowledge/business-dictionary.md"
   core_entities: "specs/domain-knowledge/core-entities.md"
 
+  # Project Lessons (guardrails accumulated via /learn — loaded by context-loader Step 6.7)
+  # Single-service default below. In umbrella/service mode, set this in each service's
+  # .agent/project-context.yaml to ".agent/project-lessons.md" (resolved per service_root).
+  lessons_file: "specs/domain-knowledge/lessons-learned.md"
+
   # Tech Docs
   tech_docs_dir: "tech-docs"
 
+  # Design Specs (FE/App platforms only — web, app)
+  design_spec_dir: "specs/design-spec"
+
   # Trace
   trace_dir: ".trace"
 
+  # Tester feedback (written by /report-bug and /propose-scenario).
+  # These live in the SHARED spec repo so PO/Dev see them on their next /sync.
+  # In umbrella mode, context-loader auto-resolves them under {spec_source}/feedback/.
+  bug_reports_dir: "feedback/bug-reports"
+  bdd_proposals_dir: "feedback/bdd-proposals"
+
 tech_stack:
   language: "{{LANGUAGE}}"              # e.g., Java 17 / TypeScript / C# / Go
   framework: "{{FRAMEWORK}}"           # e.g., Spring Boot 3.2 / Angular 17 / .NET 8
@@ -69,6 +83,32 @@ domains:
   - "{{DOMAIN_1}}"
   # - "{{DOMAIN_2}}"
 
+# ----- Multi-Service / Umbrella Setup -----
+# Fill this section ONLY if this is an UMBRELLA repo that contains multiple
+# service submodules. Leave commented out for single-service projects.
+#
+# setup:
+#   mode: umbrella                            # "umbrella" | "single" (default: single)
+#   spec_source: "{{SPEC_SUBMODULE_PATH}}"   # path to PO spec submodule, e.g. "free-trial-specs"
+#
+# When spec_source is set, context-loader auto-derives:
+#   prd_dir              → {spec_source}/specs/prd
+#   design_spec_dir      → {spec_source}/specs/design-spec
+#   domain_knowledge_dir → {spec_source}/specs/domain-knowledge
+# (You can still override these manually in paths: section below.)
+#
+# services:                                   # domain → service submodule routing
+#   {{DOMAIN_1}}:                             # must match @trace.domain in PRD files
+#     path: "{{SERVICE_SUBMODULE_DIR}}"       # relative path to service submodule
+#     module: "{{STACK_MODULE}}"              # e.g., java-spring, nextjs, flutter
+#     specs_dir: "{{SERVICE_SUBMODULE_DIR}}/specs/bdd"
+#     tech_docs_dir: "{{SERVICE_SUBMODULE_DIR}}/specs/tech-docs"
+#   {{DOMAIN_2}}:
+#     path: "{{SERVICE_2_DIR}}"
+#     module: "{{STACK_MODULE}}"
+#     specs_dir: "{{SERVICE_2_DIR}}/specs/bdd"
+#     tech_docs_dir: "{{SERVICE_2_DIR}}/specs/tech-docs"
+
 # ----- Architecture -----
 architecture:
   style: "{{ARCH_STYLE}}"              # e.g., Layered / Clean / Hexagonal