@anhth2/spec-driven-dev-plugin 0.7.0 → 0.9.0

package/commands/fix-bug.md

@@ -131,6 +131,7 @@ Read `.agent/project-context.yaml`. Extract and store:
 - `paths.core_entities` → path to core-entities.md
 - `paths.tech_docs_dir` → technical documentation root
 - `paths.trace_dir` → trace state directory
+- `paths.design_spec_dir` → Design Spec documents root (FE/App only)
 
 If `paths` section is absent, use these defaults:
 - `specs_dir` = `specs/bdd`
@@ -142,11 +143,75 @@ If `paths` section is absent, use these defaults:
 - `core_entities` = `specs/domain-knowledge/core-entities.md`
 - `tech_docs_dir` = `specs/tech-docs`
 - `trace_dir` = `.trace`
+- `design_spec_dir` = `specs/design-spec`
 
 If `tech_stack.module` is set, also load `.agent/modules/{module}/stack-profile.yaml` if it exists.
 
 ---
 
+## Step 1.5 — [SERVICE ROUTING] Resolve service paths (umbrella mode)
+
+*Skip this step entirely if `setup.mode` is not `"umbrella"` and `services` section is absent from project-context.yaml.*
+
+If `services` section is present:
+
+**1. Detect active domain** (in priority order):
+- Read `@trace.domain` from target file frontmatter (if Gate loaded a target file)
+- Extract from target file path: segment immediately after `prd_dir` base path  
+  *(e.g., `specs/prd/user/FEAT-01.md` → domain = `user`)*
+- If `$ARGUMENTS` contains a path, extract the segment after `prd_dir`
+
+**2. Route to service** — if active domain matches a key in `services`:
+- Override `paths.specs_dir` → `services.{domain}.specs_dir`
+- Override `paths.tech_docs_dir` → `services.{domain}.tech_docs_dir`
+- Store `active_service` = `services.{domain}.path`
+- Store `active_service_module` = `services.{domain}.module`
+- If service has its own `module` → use it as `active_module` (overrides `tech_stack.module`)
+
+**3. Fallback** — if domain not detected or no matching service key:
+- Keep default paths from Step 1
+- Set `active_service = unresolved`
+
+**4. Spec source auto-override** — if `setup.spec_source` is set AND the corresponding path was not already explicitly set in `paths:`:
+- Override `paths.prd_dir` → `{spec_source}/specs/prd`
+- Override `paths.design_spec_dir` → `{spec_source}/specs/design-spec`
+- Override `paths.domain_knowledge_dir` → `{spec_source}/specs/domain-knowledge`
+- Override `paths.business_dictionary` → `{spec_source}/specs/domain-knowledge/business-dictionary.md`
+- Override `paths.core_entities` → `{spec_source}/specs/domain-knowledge/core-entities.md`
+- Override `paths.bug_reports_dir` → `{spec_source}/feedback/bug-reports`
+- Override `paths.bdd_proposals_dir` → `{spec_source}/feedback/bdd-proposals`
+
+> **Why under `spec_source`:** tester feedback (`/report-bug`, `/propose-scenario`) must land in the **shared spec repo** so PO/Dev see it when they `/sync`. In single-service mode (no `spec_source`), these default to `feedback/bug-reports` and `feedback/bdd-proposals` at repo root — still shared, same repo.
+
+---
+
+## Step 1.6 — [SERVICE CONVENTIONS] Load service-specific conventions (umbrella mode)
+
+*Skip this step entirely if `active_service` is `"unresolved"` or context is single-service mode.*
+
+When `active_service` has been resolved to a real path in Step 1.5 (e.g., `user-service/`):
+
+**1. Locate service config** — try in priority order:
+- `{active_service}/.agent/project-context.yaml`
+- `{active_service}/project-context.yaml`
+
+**2. If found, override with service-specific values:**
+
+| Variable | Source |
+|----------|--------|
+| `conventions.test_command` | service's `conventions.test_command` |
+| `conventions.build_command` | service's `conventions.build_command` |
+| `paths.trace_dir` | `{active_service}/{service paths.trace_dir}` — default: `{active_service}/.trace` |
+| `paths.specs_dir` | `{active_service}/{service paths.specs_dir}` (if set in service config, else keep Step 1.5 override) |
+
+**3. Store** `service_root = {active_service}` as the working directory anchor for all downstream commands:
+- Shell commands (`/run-tests`, `/generate-tests`) run **from within** `service_root`
+- File write operations (test files, trace TSVs) use paths **relative to** `service_root`
+
+**4. If service config not found** — keep umbrella defaults, still set `service_root = {active_service}` (path anchor is always needed even without a config override).
+
+---
+
 ## Step 2 — [PROJECT-CONFIG] Load module stack profile (conditional)
 
 If `tech_stack.module` is set, read `.agent/modules/{module}/stack-profile.yaml`.
@@ -237,6 +302,25 @@ These two variables (`active_module`, `platform_type`) are the canonical source
 
 ---
 
+## Step 6.7 — [GUARDRAILS] Load Project Lessons (conditional)
+
+*Accumulated mistakes the AI must not repeat in this project. These are added over time via `/learn`
+or accepted during `/review-code`, `/fix-bug`, `/debug`.*
+
+Resolve the lessons file path:
+- Use `paths.lessons_file` if set (may be service-overridden in umbrella mode, Step 1.6)
+- Else default `specs/domain-knowledge/lessons-learned.md`
+- In umbrella/service mode (when `service_root` is set), if `paths.lessons_file` is unset, default to `{service_root}/.agent/project-lessons.md`
+
+If the file exists, read it and store ALL lessons as **ACTIVE GUARDRAILS** for the session:
+- Treat each lesson's **Rule** as a hard constraint — same priority as CLAUDE.md coding standards (Step 3).
+- Before generating or modifying any artifact (PRD, BDD, tech-doc, code, test), check the output against every lesson whose `category` matches the current command AND whose `scope` matches the target (domain / file).
+- If a generated output would violate a lesson → correct it **before** presenting, and note which lesson (`L-NNN`) was applied.
+
+If the file does not exist → skip silently (no lessons captured yet).
+
+---
+
 ## Step 7 — [RECAP] Working Memory Recap (anti-lost-in-middle)
 
 After loading all context, synthesize and output a compact summary block.
@@ -252,6 +336,9 @@ Layers    : {layer order from CLAUDE.md §2, e.g., Controller → Facade → Ser
 Ticket    : {ticket_prefix}-
 Dict      : {loaded — N canonical terms, M banned terms | missing}
 Entities  : {loaded — EntityA, EntityB, EntityC | missing}
+Lessons   : {loaded — N guardrails | none yet}
+Service   : {active_service} ({active_service_module}) | single-service
+Svc Root  : {service_root} — conventions + trace_dir loaded from service config | —
 Status    : {FULL | PARTIAL — missing: CLAUDE.md / business-dict / core-entities | MINIMAL}
 ```
 
@@ -375,6 +462,101 @@ git commit -m "fix({TICKET_ID}): {description}"
 git push -u origin fix/{TICKET_ID}-{slug}
 ```
 
+## Phase 6 — Offer to Record a Lesson (optional)
+
+If the root cause was a **mistake the AI made during generation and could repeat**
+(e.g. it generated code that skipped a layer, missed a null guard, used a wrong pattern —
+NOT an external cause like a third-party outage or bad input data), ask:
+
+```
+This root cause looks like a repeatable AI mistake.
+Record it as a project lesson so it isn't generated again? (Y/N)
+```
+
+If `Y` → run the capture procedure below with `source=/fix-bug {TICKET_ID}`, an appropriate
+`category` (usually `code-gen`), and `scope` = the affected domain or file glob.
+
+# Capture Lesson — Record a Recurring Mistake as a Guardrail
+
+Reusable procedure to persist a "lesson" so the AI does not repeat a mistake in this project.
+Used by `/learn` (manual) and offered by `/review-code`, `/fix-bug`, `/debug` (auto).
+
+> **Project memory, not model training.** A lesson is plain text injected into context at the
+> start of every command (context-loader Step 6.7). Functionally this stops the repeat — the AI
+> sees the guardrail before it generates. No model weights change.
+
+## L1 — Resolve the lessons file
+
+Resolve `lessons_path` in this order:
+1. `paths.lessons_file` from loaded context (may be service-overridden in umbrella mode, Step 1.6)
+2. Default `specs/domain-knowledge/lessons-learned.md` (single-service)
+3. In umbrella/service mode (when `service_root` is set) default `{service_root}/.agent/project-lessons.md`
+
+## L2 — Build the lesson
+
+Gather these fields — from `$ARGUMENTS` (for `/learn`) or from the calling command's findings
+(for `/review-code`, `/fix-bug`, `/debug`):
+
+| Field | Meaning |
+|-------|---------|
+| `category` | one of: `code-gen` \| `bdd` \| `tech-docs` \| `tests` \| `prd` \| `general` |
+| `title` | short phrase naming the mistake |
+| `mistake` | concretely, what the AI did wrong |
+| `rule` | imperative correction — "Always …" / "Never …" — testable, not vague |
+| `scope` | where it applies: a domain, a file glob (e.g. `*Controller.*`), or `all` |
+| `source` | how captured: `/learn` \| `/review-code {UC-ID}` \| `/fix-bug {TICKET}` \| `/debug` |
+
+If `rule` is vague (e.g. "be careful"), rewrite it into a concrete, checkable instruction before saving.
+
+## L3 — De-duplicate
+
+Read existing lessons in `lessons_path`. If one already covers the same mistake:
+- **Refine** that entry (tighten the Rule, widen/narrow Scope, bump Date, append the new Source) — do NOT add a duplicate.
+
+Otherwise assign the next id `L-{NNN}` = (highest existing number + 1), zero-padded to 3 digits.
+
+## L4 — Write
+
+If `lessons_path` does not exist, create it with this header first:
+
+```markdown
+# Project Lessons — Learned Guardrails
+
+> Mistakes the AI must NOT repeat in this project. Loaded by context-loader at the start of
+> every command and treated as hard constraints (same priority as CLAUDE.md coding standards).
+> Add with /learn, or accept the prompt during /review-code, /fix-bug, /debug.
+> Commit this file so the whole team shares the guardrails.
+
+| Category | Applies to |
+|----------|-----------|
+| code-gen | /generate-code output |
+| bdd | /generate-bdd output |
+| tech-docs | /generate-tech-docs output |
+| tests | /generate-tests output |
+| prd | /generate-prd, /refine-prd output |
+| general | every command |
+
+---
+```
+
+Insert the new lesson directly under the `---` separator (**newest first**), in this exact shape:
+
+```markdown
+### L-{NNN} — [{category}] {title}
+- **Date**: {today YYYY-MM-DD}
+- **Scope**: {scope}
+- **Mistake**: {mistake}
+- **Rule**: {rule}
+- **Source**: {source}
+
+```
+
+## L5 — Confirm
+
+Print: `📝 Lesson {id} recorded → {lessons_path}  ([{category}] {title})`
+Then remind: `Commit {lessons_path} so the team shares this guardrail.`
+
+
 ## Output
 
 # Report Footer — Standard Command Output Format
@@ -409,7 +591,8 @@ Suggest the logical next command based on workflow phase:
 | /define-product         | `/generate-prd {product-definition-file}`     |
 | /generate-prd           | `/refine-prd {prd-file}` then `/review-context {prd-file}` |
 | /refine-prd             | Open Review Board → update PRD → `/review-context {prd-file}` |
-| /review-context (PRD)   | `/generate-bdd {prd-file}` if APPROVED; fix PRD if NEEDS_FIX |
+| /review-context (PRD)   | FE/App: `/generate-design-spec {prd-file}` (then BDD after sign-off); BE: `/generate-bdd {prd-file}` directly; fix PRD if NEEDS_FIX |
+| /generate-design-spec   | Designer review → Figma links confirmed → PO + Designer sign-off → `/generate-bdd {prd-file}` |
 | /generate-bdd           | `/review-context {feature-file}` to verify coverage |
 | /review-context (BDD)   | `/generate-tech-docs {UC-ID}` if APPROVED; regenerate if NEEDS_FIX |
 | /generate-tech-docs     | `/review-tech-docs {tech-design-file}`        |
@@ -423,6 +606,11 @@ Suggest the logical next command based on workflow phase:
 | /validate-traces        | DRIFT/UNTRACKED → `/generate-code {UC-ID}`; GAP → `/generate-tests {UC-ID}`; all OK → create PR |
 | /fix-bug                | Create PR and link to ticket                  |
 | /debug                  | `/fix-bug {ticket-id}` if fix needed          |
+| /report-bug             | Send to dev (`/fix-bug {BUG-ID}`); if coverage gap → `/propose-scenario {UC-ID}` |
+| /propose-scenario       | Notify PO/Dev to review the proposal in `feedback/bdd-proposals/` |
+| /learn                  | Continue working — lesson applies on next command |
+| /sync                   | `/validate-traces` for full coverage; act on any `📥 tester feedback` surfaced |
+| /update-framework       | Review `git diff .agent/`, commit; `/sync` for project content |
 
 Format the footer as:
 ```
@@ -438,6 +626,7 @@ Next   : {suggested command with example arguments}
 Root Cause: {analysis}
 Changes: {list}
 ✅ Regression test added | ✅ Build: SUCCESS
+{📝 Lesson L-NNN recorded (if captured)}
 Branch: fix/{TICKET_ID}-{slug}
 Next: Create PR and link to ticket.
 ```

package/commands/fix-bug.tmpl

@@ -110,6 +110,22 @@ git commit -m "fix({TICKET_ID}): {description}"
 git push -u origin fix/{TICKET_ID}-{slug}
 ```
 
+## Phase 6 — Offer to Record a Lesson (optional)
+
+If the root cause was a **mistake the AI made during generation and could repeat**
+(e.g. it generated code that skipped a layer, missed a null guard, used a wrong pattern —
+NOT an external cause like a third-party outage or bad input data), ask:
+
+```
+This root cause looks like a repeatable AI mistake.
+Record it as a project lesson so it isn't generated again? (Y/N)
+```
+
+If `Y` → run the capture procedure below with `source=/fix-bug {TICKET_ID}`, an appropriate
+`category` (usually `code-gen`), and `scope` = the affected domain or file glob.
+
+{{include:steps/capture-lesson.md}}
+
 ## Output
 
 {{include:steps/report-footer.md}}
@@ -119,6 +135,7 @@ git push -u origin fix/{TICKET_ID}-{slug}
 Root Cause: {analysis}
 Changes: {list}
 ✅ Regression test added | ✅ Build: SUCCESS
+{📝 Lesson L-NNN recorded (if captured)}
 Branch: fix/{TICKET_ID}-{slug}
 Next: Create PR and link to ticket.
 ```