@agent-native/core 0.155.0 → 0.157.0

package/corpus/templates/assets/app/components/asset/AssetPreviewDialog.tsx

@@ -159,7 +159,9 @@ export function AssetPreviewDialog({
                   onClick={() => setShowDetails((value) => !value)}
                 >
                   <IconInfoCircle className="h-4 w-4" />
-                  {t("library.viewDetails")}
+                  {showDetails
+                    ? t("library.hideDetails")
+                    : t("library.viewDetails")}
                 </Button>
                 <DialogClose
                   aria-label={t("library.closePreview")}

package/corpus/templates/assets/app/i18n-data.ts

@@ -844,10 +844,11 @@ const enUS = {
     checking: "Checking",
     checkingUpload: "Checking upload",
     clearAll: "Clear all",
+    clearAllWithCount: "Clear all candidates ({{count}})",
     clearCandidates: "Clear candidates",
     clearCandidatesTitle: "Clear {{count}} candidates?",
     clearCandidatesDescription:
-      "Clears the live stage and deletes unsaved draft candidates.",
+      "Clears the live stage and deletes every unsaved draft candidate. Saved library assets stay untouched.",
     clearGeneratedCandidatesTitle: "Clear generated candidates?",
     clearGeneratedCandidatesDescription:
       "This removes every unsaved candidate from the thread and deletes the generated asset rows behind them. Saved library assets are not touched.",
@@ -986,6 +987,7 @@ const enUS = {
     open: "Open",
     openAssets: "Open Assets",
     openChat: "Open chat",
+    hideDetails: "Hide details",
     openDetails: "Open details",
     preparing: "Preparing...",
     previousImage: "Previous image",
@@ -3728,7 +3730,9 @@ export const messagesByLocale = {
       checkingUpload: "正在检查上传",
       clear: "清除",
       clearAll: "全部清除",
+      clearAllWithCount: "清除所有候选项（{{count}}）",
       clearCandidates: "清除候选项",
+      hideDetails: "隐藏详情",
       clearCandidatesDescription: "清除实时阶段并删除未保存的草稿候选项。",
       clearCandidatesTitle: "清除 {{count}} 个候选项？",
       clearGeneratedCandidatesDescription:
@@ -4552,7 +4556,9 @@ export const messagesByLocale = {
       checkingImageLibraries: "Comprobando bibliotecas de imágenes...",
       checkingUpload: "Comprobando carga",
       clearAll: "Borrar todo",
+      clearAllWithCount: "Borrar todos los candidatos ({{count}})",
       clearCandidates: "Limpiar candidatos",
+      hideDetails: "Ocultar detalles",
       clearCandidatesDescription:
         "Limpia la etapa en vivo y elimina los candidatos de borrador no guardados.",
       clearGeneratedCandidatesDescription:
@@ -5026,7 +5032,9 @@ export const messagesByLocale = {
       checkingImageLibraries: "Vérification des bibliothèques d'images...",
       checkingUpload: "Vérification du téléchargement",
       clearAll: "Tout effacer",
+      clearAllWithCount: "Effacer tous les candidats ({{count}})",
       clearCandidates: "Effacer les candidats",
+      hideDetails: "Masquer les détails",
       clearCandidatesDescription:
         "Efface l'étape en direct et supprime les candidats de brouillon non enregistrés.",
       clearGeneratedCandidatesDescription:
@@ -5479,7 +5487,9 @@ export const messagesByLocale = {
       checkingImageLibraries: "Bildbibliotheken werden geprüft...",
       checkingUpload: "Upload wird überprüft",
       clearAll: "Alles löschen",
+      clearAllWithCount: "Alle Kandidaten löschen ({{count}})",
       clearCandidates: "Kandidaten löschen",
+      hideDetails: "Details ausblenden",
       clearCandidatesDescription:
         "Löscht die Live-Phase und entfernt nicht gespeicherte Entwurfskandidaten.",
       clearGeneratedCandidatesDescription:
@@ -5837,7 +5847,9 @@ export const messagesByLocale = {
       checkingImageLibraries: "画像ライブラリを確認中...",
       checkingUpload: "アップロードを確認しています",
       clearAll: "すべてクリア",
+      clearAllWithCount: "候補をすべてクリア（{{count}}）",
       clearCandidates: "候補をクリアする",
+      hideDetails: "詳細を非表示",
       clearCandidatesDescription:
         "ライブ ステージをクリアし、保存されていないドラフト候補を削除します。",
       clearGeneratedCandidatesDescription:
@@ -6186,7 +6198,9 @@ export const messagesByLocale = {
       checkingImageLibraries: "이미지 라이브러리 확인 중...",
       checkingUpload: "업로드 확인 중",
       clearAll: "모두 지우기",
+      clearAllWithCount: "후보 모두 지우기({{count}})",
       clearCandidates: "후보 제거",
+      hideDetails: "세부정보 숨기기",
       clearCandidatesDescription:
         "라이브 단계를 지우고 저장되지 않은 초안 후보를 삭제합니다.",
       clearGeneratedCandidatesDescription:
@@ -6534,7 +6548,9 @@ export const messagesByLocale = {
       checkingImageLibraries: "Verificando bibliotecas de imagens...",
       checkingUpload: "Verificando upload",
       clearAll: "Limpar tudo",
+      clearAllWithCount: "Limpar todos os candidatos ({{count}})",
       clearCandidates: "Limpar candidatos",
+      hideDetails: "Ocultar detalhes",
       clearCandidatesDescription:
         "Limpa o estágio ao vivo e exclui candidatos de rascunho não salvos.",
       clearGeneratedCandidatesDescription:
@@ -6985,7 +7001,9 @@ export const messagesByLocale = {
       checkingImageLibraries: "Image libraries जांची जा रही हैं...",
       checkingUpload: "अपलोड की जाँच की जा रही है",
       clearAll: "सभी साफ करें",
+      clearAllWithCount: "सभी उम्मीदवार साफ करें ({{count}})",
       clearCandidates: "उम्मीदवारों को साफ करें",
+      hideDetails: "विवरण छिपाएं",
       clearCandidatesDescription:
         "लाइव चरण को साफ करता है और अ सहेजे गए ड्राफ्ट उम्मीदवारों को हटाता है।",
       clearGeneratedCandidatesDescription:
@@ -7331,7 +7349,9 @@ export const messagesByLocale = {
       checkingImageLibraries: "جارٍ فحص مكتبات الصور...",
       checkingUpload: "التحقق من التحميل",
       clearAll: "مسح الكل",
+      clearAllWithCount: "مسح كل المرشحين ({{count}})",
       clearCandidates: "امسح المرشحين",
+      hideDetails: "إخفاء التفاصيل",
       clearCandidatesDescription:
         "مسح مرحلة المرشح وحذف المرشحين الذين تم إنشاؤهم غير المحفوظة. أصول المكتبة المحفوظة تبقى دون تغيير.",
       clearGeneratedCandidatesDescription:

package/corpus/templates/assets/app/routes/brand-kits.$id.tsx

@@ -4533,7 +4533,9 @@ function LiveCandidatesActions({
   const hasFailed = failedCount > 0;
   const isClearing = dismissSlots.isPending || deleteAssets.isPending;
   const actionLabel =
-    pending === "failed" ? t("library.dismissFailed") : t("library.clearAll");
+    pending === "failed"
+      ? t("library.dismissFailed")
+      : t("library.clearAllWithCount", { count: totalCount });
   const busyLabel =
     pending === "failed" ? t("library.dismissing") : t("library.clearing");
 
@@ -4645,26 +4647,28 @@ function LiveCandidatesActions({
           </Button>
         </DropdownMenuTrigger>
         <DropdownMenuContent align="end">
-          <DropdownMenuItem
-            disabled={!hasFailed || isClearing}
-            onSelect={(event) => {
-              event.preventDefault();
-              setPending("failed");
-            }}
-          >
-            <IconTrash className="mr-2 h-4 w-4 shrink-0" />
-            {t("library.dismissFailedWithCount", { count: failedCount })}
-          </DropdownMenuItem>
+          {hasFailed ? (
+            <DropdownMenuItem
+              disabled={isClearing}
+              onSelect={(event) => {
+                event.preventDefault();
+                setPending("failed");
+              }}
+            >
+              <IconTrash className="mr-2 h-4 w-4 shrink-0" />
+              {t("library.dismissFailedWithCount", { count: failedCount })}
+            </DropdownMenuItem>
+          ) : null}
           <DropdownMenuItem
             className="text-destructive focus:bg-destructive/10 focus:text-destructive"
-            disabled={isClearing}
+            disabled={isClearing || totalCount === 0}
             onSelect={(event) => {
               event.preventDefault();
               setPending("all");
             }}
           >
             <IconTrash className="mr-2 h-4 w-4 shrink-0" />
-            {t("library.clearAll")}
+            {t("library.clearAllWithCount", { count: totalCount })}
           </DropdownMenuItem>
         </DropdownMenuContent>
       </DropdownMenu>

package/corpus/templates/clips/app/components/player/share-dialog.tsx

@@ -72,6 +72,13 @@ export interface ShareRecordingPopoverProps {
   animatedThumbnailUrl?: string | null;
   isLoomRecording?: boolean;
   hasPassword?: boolean;
+  /**
+   * Restricts the dialog to a bare copy-link control for viewers who can
+   * reshare a public/org clip's link but have no edit access: it skips
+   * `list-resource-shares` (which returns every individually-shared
+   * principal's email to any reader) and hides the Invite tab entirely.
+   */
+  viewerReshareOnly?: boolean;
   /** Trigger element rendered as the popover anchor (usually the Share button). */
   children: ReactNode;
   open?: boolean;
@@ -103,6 +110,7 @@ export function ShareRecordingPopover({
   animatedThumbnailUrl,
   isLoomRecording = false,
   hasPassword,
+  viewerReshareOnly = false,
   children,
   open,
   onOpenChange,
@@ -125,6 +133,7 @@ export function ShareRecordingPopover({
           animatedThumbnailUrl={animatedThumbnailUrl}
           isLoomRecording={isLoomRecording}
           hasPassword={hasPassword}
+          viewerReshareOnly={viewerReshareOnly}
         />
       </PopoverContent>
     </Popover>
@@ -148,6 +157,7 @@ export function ShareRecordingDialog({
   open,
   onOpenChange,
   hasPassword,
+  viewerReshareOnly = false,
 }: ShareRecordingDialogProps) {
   const t = useT();
   return (
@@ -168,6 +178,7 @@ export function ShareRecordingDialog({
           animatedThumbnailUrl={animatedThumbnailUrl}
           isLoomRecording={isLoomRecording}
           hasPassword={hasPassword}
+          viewerReshareOnly={viewerReshareOnly}
           reserveCloseButton
         />
       </DialogContent>
@@ -186,6 +197,7 @@ function ShareRecordingContent({
   isLoomRecording = false,
   reserveCloseButton = false,
   hasPassword,
+  viewerReshareOnly = false,
 }: {
   recordingId: string;
   recordingTitle?: string;
@@ -197,20 +209,34 @@ function ShareRecordingContent({
   isLoomRecording?: boolean;
   reserveCloseButton?: boolean;
   hasPassword?: boolean;
+  viewerReshareOnly?: boolean;
 }) {
   const t = useT();
-  const sharesQuery = useActionQuery<SharesResponse>("list-resource-shares", {
-    resourceType: "recording",
-    resourceId: recordingId,
-  });
+  const sharesQuery = useActionQuery<SharesResponse>(
+    "list-resource-shares",
+    { resourceType: "recording", resourceId: recordingId },
+    { enabled: !viewerReshareOnly },
+  );
 
-  const data = sharesQuery.data;
+  const data = viewerReshareOnly ? undefined : sharesQuery.data;
   const role = data?.role ?? initialRole;
   const canManage = role === "owner" || role === "admin";
+  // Editors could always see (read-only) who a clip is shared with; only
+  // gate the Invite tab's mutation controls behind canManage. Commenters are
+  // grouped with plain viewers here -- neither can manage shares.
+  const canViewShares =
+    role === "owner" || role === "admin" || role === "editor";
   const visibility =
     (data?.visibility as Visibility | null | undefined) ??
     initialVisibility ??
     null;
+  // A plain viewer/commenter can't produce a working embed for a non-public
+  // clip (they have no way to make it public), so don't dangle the tab in
+  // front of them only to show an "ask the owner" dead end. Owner/admin/
+  // editor keep it regardless of visibility since they can flip to public
+  // from inside it.
+  const canEmbed = canViewShares || visibility === "public";
+  const tabCount = 1 + (canViewShares ? 1 : 0) + (canEmbed ? 1 : 0);
 
   // Attribution `via` must be a stable non-PII id, never an email. The only
   // owner id available client-side is the *current* session's userId, which is
@@ -234,20 +260,28 @@ function ShareRecordingContent({
         defaultValue="link"
         className={cn("min-w-0 px-4 py-3", reserveCloseButton && "pe-12")}
       >
-        <TabsList className="grid w-full grid-cols-3">
-          <TabsTrigger value="link" className="gap-1.5">
-            <IconLink size={14} />
-            {t("shareDialog.link")}
-          </TabsTrigger>
-          <TabsTrigger value="invite" className="gap-1.5">
-            <IconMail size={14} />
-            {t("shareDialog.invite")}
-          </TabsTrigger>
-          <TabsTrigger value="embed" className="gap-1.5">
-            <IconCode size={14} />
-            {t("shareDialog.embed")}
-          </TabsTrigger>
-        </TabsList>
+        {tabCount > 1 ? (
+          <TabsList
+            className={`grid w-full ${tabCount === 3 ? "grid-cols-3" : "grid-cols-2"}`}
+          >
+            <TabsTrigger value="link" className="gap-1.5">
+              <IconLink size={14} />
+              {t("shareDialog.link")}
+            </TabsTrigger>
+            {canViewShares ? (
+              <TabsTrigger value="invite" className="gap-1.5">
+                <IconMail size={14} />
+                {t("shareDialog.invite")}
+              </TabsTrigger>
+            ) : null}
+            {canEmbed ? (
+              <TabsTrigger value="embed" className="gap-1.5">
+                <IconCode size={14} />
+                {t("shareDialog.embed")}
+              </TabsTrigger>
+            ) : null}
+          </TabsList>
+        ) : null}
 
         <TabsContent value="link" className="mt-3">
           <LinkTab
@@ -262,34 +296,39 @@ function ShareRecordingContent({
             animatedThumbnailUrl={animatedThumbnailUrl}
             isLoomRecording={isLoomRecording}
             hasPassword={hasPassword}
+            canViewShares={canViewShares}
           />
         </TabsContent>
 
-        <TabsContent value="invite" className="mt-3">
-          <SharePeopleTab
-            resourceType="recording"
-            resourceId={recordingId}
-            resourceUrl={absoluteAppUrl(`/r/${recordingId}`)}
-            sharesQuery={sharesQuery}
-            canManage={canManage}
-            roleCopy={{
-              commenter: {
-                label: t("shareUi.recordingCommenter.label"),
-                description: t("shareUi.recordingCommenter.description"),
-              },
-            }}
-          />
-        </TabsContent>
-
-        <TabsContent value="embed" className="mt-3">
-          <ClipsEmbedConfigurator
-            recordingId={recordingId}
-            sharesQuery={sharesQuery}
-            visibility={visibility}
-            canManage={canManage}
-            ownerViaId={ownerViaId}
-          />
-        </TabsContent>
+        {canViewShares ? (
+          <TabsContent value="invite" className="mt-3">
+            <SharePeopleTab
+              resourceType="recording"
+              resourceId={recordingId}
+              resourceUrl={absoluteAppUrl(`/r/${recordingId}`)}
+              sharesQuery={sharesQuery}
+              canManage={canManage}
+              roleCopy={{
+                commenter: {
+                  label: t("shareUi.recordingCommenter.label"),
+                  description: t("shareUi.recordingCommenter.description"),
+                },
+              }}
+            />
+          </TabsContent>
+        ) : null}
+
+        {canEmbed ? (
+          <TabsContent value="embed" className="mt-3">
+            <ClipsEmbedConfigurator
+              recordingId={recordingId}
+              sharesQuery={sharesQuery}
+              visibility={visibility}
+              canManage={canManage}
+              ownerViaId={ownerViaId}
+            />
+          </TabsContent>
+        ) : null}
       </Tabs>
     </>
   );
@@ -311,6 +350,7 @@ function LinkTab({
   animatedThumbnailUrl,
   isLoomRecording: isLoomRecordingProp,
   hasPassword,
+  canViewShares,
 }: {
   recordingId: string;
   recordingTitle?: string;
@@ -323,6 +363,7 @@ function LinkTab({
   animatedThumbnailUrl?: string | null;
   isLoomRecording?: boolean;
   hasPassword?: boolean;
+  canViewShares: boolean;
 }) {
   const t = useT();
   const { setResourceVisibility, isPending } = useResourceVisibilityMutation(
@@ -460,21 +501,23 @@ function LinkTab({
 
   return (
     <div className="space-y-4">
-      {visibility ? (
-        <GeneralAccessSelect
-          visibility={visibility}
-          canManage={canManage}
-          isPending={visibilityPending}
-          onChange={(next) => setResourceVisibility(next)}
-          publicDescription={t("shareDialog.publicDescription")}
-          showDescription={false}
-        />
-      ) : (
-        <div className="space-y-2" aria-hidden>
-          <div className="h-3 w-24 animate-pulse rounded bg-muted" />
-          <div className="h-12 w-full animate-pulse rounded bg-muted" />
-        </div>
-      )}
+      {canViewShares ? (
+        visibility ? (
+          <GeneralAccessSelect
+            visibility={visibility}
+            canManage={canManage}
+            isPending={visibilityPending}
+            onChange={(next) => setResourceVisibility(next)}
+            publicDescription={t("shareDialog.publicDescription")}
+            showDescription={false}
+          />
+        ) : (
+          <div className="space-y-2" aria-hidden>
+            <div className="h-3 w-24 animate-pulse rounded bg-muted" />
+            <div className="h-12 w-full animate-pulse rounded bg-muted" />
+          </div>
+        )
+      ) : null}
 
       <CopyField
         label={

package/corpus/templates/clips/app/routes/r.$recordingId.tsx

@@ -529,6 +529,18 @@ export default function RecordingPage() {
   const canDownloadRecording = Boolean(
     recording?.enableDownloads && recording.videoUrl && !isLoomEmbedBacked,
   );
+  // Mirrors the /share/:shareId reshare restriction (same public/org scope):
+  // a plain viewer of a public or org clip must not trigger
+  // `list-resource-shares` (any read access is enough to call it, and its
+  // response includes every individually-shared principal's email) or see a
+  // raw video download/open action independent of `enableDownloads`.
+  const viewerReshareOnly =
+    (role === "viewer" || role === "commenter") &&
+    (recording?.visibility === "public" || recording?.visibility === "org");
+  const shareVideoUrl =
+    canDownloadRecording || isLoomEmbedBacked
+      ? (recording?.videoUrl ?? null)
+      : null;
   const downloadRecording = useCallback(async () => {
     if (!recording?.videoUrl) return;
     setDownloading(true);
@@ -988,6 +1000,7 @@ export default function RecordingPage() {
               initialVisibility={recording.visibility}
               initialRole={role}
               hasPassword={Boolean(recording.hasPassword)}
+              viewerReshareOnly={viewerReshareOnly}
             >
               <Button className="shrink-0 gap-1.5" size="sm">
                 {recording.visibility !== "public" ? (
@@ -1550,11 +1563,12 @@ export default function RecordingPage() {
               recordingTitle={recording.title}
               initialVisibility={recording.visibility}
               initialRole={role}
-              videoUrl={recording.videoUrl}
+              videoUrl={shareVideoUrl}
               thumbnailUrl={recording.thumbnailUrl}
               animatedThumbnailUrl={recording.animatedThumbnailUrl}
               isLoomRecording={isLoomEmbedBacked}
               hasPassword={Boolean(recording.hasPassword)}
+              viewerReshareOnly={viewerReshareOnly}
             >
               <Button
                 className="shrink-0 gap-1.5 bg-primary text-primary-foreground hover:bg-primary/90"

package/corpus/templates/clips/app/routes/share.$shareId.tsx

@@ -537,6 +537,15 @@ export default function ShareRoute() {
     viewerRole === "editor" ||
     viewerRole === "commenter";
   const viewerIsOwner = Boolean(dataQ.data?.data?.viewer?.isOwner);
+  const canReshareLink =
+    (viewerRole === "viewer" || viewerRole === "commenter") &&
+    (recording?.visibility === "public" || recording?.visibility === "org");
+  // A plain viewer only gets a copy-link control: it must not trigger
+  // `list-resource-shares` (any read access is enough to call it, and its
+  // response includes every individually-shared principal's email) and must
+  // not surface the raw video download/open action independent of
+  // `enableDownloads`.
+  const viewerReshareOnly = canReshareLink && !viewerCanEdit;
   const viewerCanOpenDashboard = Boolean(
     dataQ.data?.data?.viewer?.canOpenDashboard,
   );
@@ -899,6 +908,10 @@ export default function ShareRoute() {
   const canDownloadRecording = Boolean(
     recording.enableDownloads && recording.videoUrl && !isLoomEmbedBacked,
   );
+  // Loom-backed clips only ever get an "open player" link (not a raw
+  // download), so they're exempt from the enableDownloads gate here.
+  const shareVideoUrl =
+    canDownloadRecording || isLoomEmbedBacked ? recording.videoUrl : null;
 
   return (
     <div className="flex min-h-screen max-w-full flex-col overflow-x-hidden bg-background text-foreground lg:h-screen lg:flex-row lg:overflow-hidden">
@@ -995,17 +1008,18 @@ export default function ShareRoute() {
                 onDeleted={() => navigate("/library", { replace: true })}
               />
             ) : null}
-            {viewerCanEdit ? (
+            {viewerCanEdit || canReshareLink ? (
               <ShareRecordingPopover
                 recordingId={recording.id}
                 recordingTitle={recording.title}
                 initialVisibility={recording.visibility}
                 initialRole={viewerIsOwner ? "owner" : undefined}
-                videoUrl={recording.videoUrl}
+                videoUrl={shareVideoUrl}
                 thumbnailUrl={recording.thumbnailUrl}
                 animatedThumbnailUrl={recording.animatedThumbnailUrl}
                 isLoomRecording={isLoomEmbedBacked}
                 hasPassword={Boolean(recording.hasPassword)}
+                viewerReshareOnly={viewerReshareOnly}
               >
                 <Button size="sm" className="shrink-0 gap-1.5">
                   {recording.visibility !== "public" ? (