@adaptabletools/adaptable 23.0.4-canary.0 → 23.0.5-canary.0

package/src/agGrid/AgGridExportAdapter.js

@@ -10,10 +10,6 @@ import { convertCSSAbsoluteFontSizeToPt, getVariableColor, sanitizeStyle, } from
 import { waitForTimeout } from '../Utilities/waitForTimeout';
 export class AgGridExportAdapter {
     _adaptableInstance;
-    /**
-     * !!!
-     * do NOT mutate this array reference, this is passed only initially to AG Grid and we can only change it's internal state
-     */
     DANGER_excelStyles = [];
     originalExcelStyles = [];
     excelStylesCache = {};
@@ -69,8 +65,6 @@ export class AgGridExportAdapter {
                 this.adaptableApi.userInterfaceApi.showProgressIndicator({
                     text: `Exporting ${report.Name}...`,
                 });
-                // waitForTimeout required to give the ProgressIndicator rendering a head-start (see rAF in ProgressIndicator implementation)
-                // see #raf_progress_indicator
                 await waitForTimeout(16);
             }
             this.adaptableApi.exportApi.internalApi.setExportInProgress(config.report.Name, config.format, config.destination);
@@ -78,19 +72,12 @@ export class AgGridExportAdapter {
             const { exportContext, exportParams } = exportProcessData;
             if (this.adaptableApi.layoutApi.isCurrentLayoutPivot() &&
                 config.report.ReportRowScope === 'AllRows') {
-                // if in pivot mode but the user wants to export all rows (aka the table row data), we cannot use AG Grids row model
-                // we have to use an intermediary transient AG Grid instance
                 return this.adaptableApi.exportApi.internalApi.exportAllDataInPivotMode(exportProcessData);
             }
             if (exportContext.isVisualExcelReport) {
-                // FIXME AFL patch styles only for exported columns!
-                // or even better, only cells
                 this.patchExcelStyles(exportContext);
                 excelStylesWerePatched = true;
             }
-            // see #export_data_synchronously
-            // 1. easiest case, we download the file using AG Grid
-            // these methods will automatically handle the file download
             if (exportContext.destination === 'Download' && exportContext.isExcelReport) {
                 this.agGridApi.exportDataAsExcel(exportParams);
                 return;
@@ -99,8 +86,6 @@ export class AgGridExportAdapter {
                 this.agGridApi.exportDataAsCsv(exportParams);
                 return;
             }
-            // 2. we have to handle the export ourselves
-            // we get the report data and return it, so that the caller can handle it
             if (exportContext.isExcelReport) {
                 return {
                     type: 'excel',
@@ -114,7 +99,6 @@ export class AgGridExportAdapter {
                     data: csvReportData,
                 };
             }
-            // convert the CSV data to JSON
             const jsonReportData = this.mapCsvToJson(csvReportData, exportContext);
             return {
                 type: 'json',
@@ -125,9 +109,6 @@ export class AgGridExportAdapter {
             this.logger.consoleError(`Export failed: report="${report.Name}", format="${format}", destination="${config.destination}".`, error.stack);
         }
         finally {
-            /**
-             * Cleanup export process
-             */
             this.adaptableApi.exportApi.internalApi.setExportComplete();
             if (excelStylesWerePatched) {
                 this.resetExcelStyles();
@@ -137,9 +118,6 @@ export class AgGridExportAdapter {
             }
         }
     }
-    /**
-     * Creates export context and parameters for a given export configuration
-     */
     buildExportProcessData(config) {
         const exportContext = this.buildExportProcessContext(config);
         let exportParams = this.buildExportParams(exportContext);
@@ -163,25 +141,21 @@ export class AgGridExportAdapter {
             excelExportParams.sheetName = sheetName;
             return excelExportParams;
         }
-        // for everything else we use the CSV export
         const csvExportParams = baseExportParams;
         csvExportParams.columnSeparator = this.getCsvSeparator(exportContext);
         return csvExportParams;
     }
     buildBaseExportParams(exportContext) {
-        // TODO AFL: get custom info from user/ExportOptions for ExcelExportParams?
         const params = {};
         const { columnKeys, exportedRows, shouldRowBeSkipped, skipRowGroups, rowGroupExpandState } = this.getReportColsAndRows(exportContext);
         params.columnKeys = columnKeys;
         params.exportedRows = exportedRows;
         params.shouldRowBeSkipped = shouldRowBeSkipped;
         params.skipRowGroups = skipRowGroups;
-        // only Excel supports expanded state configuration, but setting it for all formats won't hurt, it will just be ignored
         params.rowGroupExpandState = rowGroupExpandState;
         params.fileName = this.adaptableApi.exportApi.internalApi.getReportFileName(exportContext.report.Name, exportContext.format, exportContext.destination);
         params.skipColumnHeaders = this.computeSkipColumnHeaders(exportContext);
         if (!exportContext.isExcelReport && exportContext.format !== 'CSV') {
-            // if we map CSV to JSON, we don't want to skip the column headers
             params.skipColumnHeaders = false;
         }
         params.getCustomContentBelowRow = this.computeGetCustomContentBelowRow(exportContext);
@@ -191,8 +165,6 @@ export class AgGridExportAdapter {
     }
     computeProcessRowGroupCallback(exportContext) {
         return (params) => {
-            // recreating the standard AG Grid styling for row groups: 'Parent -> Child'
-            // additionally the values are formatted
             let rowGroupNode = params.node;
             const agColumn = params.column;
             const rowGroupSummary = [
@@ -217,18 +189,13 @@ export class AgGridExportAdapter {
             const { node, column, value } = params;
             const colId = column.getColId();
             if (exportContext.report.ReportRowScope === 'SelectedRows') {
-                // handle case when this cell(column) is not selected
-                if (
-                // see #isCellPartOfSelection
-                !exportContext.isCellPartOfSelection(params.node.id, colId))
+                if (!exportContext.isCellPartOfSelection(params.node.id, colId))
                     return '';
             }
             const columnId = column.getColId();
             if (node?.group &&
                 (this.adaptableApi.columnApi.isAutoRowGroupColumn(columnId) ||
-                    // we would still need to process the cell if this is a group row with an aggregated value
                     node?.aggData?.[columnId] == undefined)) {
-                // skip processing of row groups, this was already handled in processRowGroupCallback()
                 return value;
             }
             return this.processCellForExcelExport(node, columnId, exportContext);
@@ -236,33 +203,19 @@ export class AgGridExportAdapter {
     }
     getReportColsAndRows(exportContext) {
         const { report, exportedColumnIds, isExportingVisibleColumnToJSON } = exportContext;
-        /**
-         *        1. columnKeys
-         */
         const columnKeys = exportedColumnIds;
-        /**
-         *        2. exportedRows
-         */
-        let exportedRows = 'all'; // 'AllRows' or 'ExpressionRows'
+        let exportedRows = 'all';
         if (report.ReportRowScope === 'VisibleRows' || report.ReportRowScope === 'SelectedRows') {
             exportedRows = 'filteredAndSorted';
         }
-        /**
-         *        3. shouldRowBeSkipped
-         */
         let shouldRowBeSkipped;
-        // 'AllRows' or 'VisibleRows': no need to skip rows as we are exporting all rows
         if (report.ReportRowScope === 'SelectedRows') {
-            // mapping of row ids to column ids which contain selected cells
-            // or true if the whole row is selected
             const selectedRowColumnMapping = new Map();
-            // ids of selected rows
             this.adaptableApi.gridApi.getSelectedRowInfo().gridRows?.forEach((row) => {
                 if (row?.rowNode?.id) {
                     selectedRowColumnMapping.set(row.rowNode.id, true);
                 }
             });
-            // ids of rows which contain selected cells
             this.adaptableApi.gridApi.getSelectedCellInfo().gridCells?.map((gridCell) => {
                 if (gridCell.rowNode?.id) {
                     const selectedColumns = selectedRowColumnMapping.get(gridCell.rowNode.id);
@@ -272,13 +225,11 @@ export class AgGridExportAdapter {
                     else if (selectedColumns instanceof Set) {
                         selectedColumns.add(gridCell.column.columnId);
                     }
-                    // else no nothing, the entire row is selected
                 }
             });
             shouldRowBeSkipped = (params) => {
                 return !selectedRowColumnMapping.has(params.node.id);
             };
-            // #isCellPartOfSelection
             exportContext.isCellPartOfSelection = (rowId, columnId) => {
                 const selectedRow = selectedRowColumnMapping.get(rowId);
                 if (selectedRow === true) {
@@ -298,21 +249,13 @@ export class AgGridExportAdapter {
                 return !rowNodeMatchesExpression;
             };
         }
-        /**
-         *        4. skipRowGroups
-         */
         let skipRowGroups;
         if (report.ReportRowScope === 'AllRows' || isExportingVisibleColumnToJSON) {
-            // we want to return the entire data, without the groups
             skipRowGroups = true;
         }
         if (this.isTreeDataGrid()) {
-            // we need the group rows for TreeData
             skipRowGroups = false;
         }
-        /**
-         *        5. rowGroupExpandState
-         */
         let rowGroupExpandState = 'expanded';
         if (report.ReportRowScope === 'VisibleRows') {
             rowGroupExpandState = 'match';
@@ -334,7 +277,6 @@ export class AgGridExportAdapter {
             .getExportableColumns()
             .map((col) => col.columnId);
         const exportableColumnIdsSet = new Set(exportableColumnIds);
-        // we compute the exported column keys early, as we need them for other parts of the export process
         const onlyExportableColumnIds = (columnId) => exportableColumnIdsSet.has(columnId);
         const getVisibleColumnIds = () => {
             return this.adaptableApi.layoutApi.isCurrentLayoutPivot()
@@ -355,8 +297,6 @@ export class AgGridExportAdapter {
             case 'VisibleColumns':
                 exportedColumnIds = getVisibleColumnIds();
                 if (isExportingVisibleColumnToJSON) {
-                    // for JSON we will export CSV and then convert to JSON
-                    // in this case we have to map the auto-group columns to the real keys
                     exportedColumnIds = [
                         ...groupColumnIds,
                         ...exportedColumnIds.filter((columnId) => this.isTreeDataGrid() ||
@@ -368,16 +308,13 @@ export class AgGridExportAdapter {
             case 'SelectedColumns':
                 const selectedRowInfo = this.adaptableApi.gridApi.getSelectedRowInfo();
                 if (selectedRowInfo?.gridRows?.length) {
-                    // if there is at least one selected row, we have to export all visible columns
                     exportedColumnIds = getVisibleColumnIds();
                 }
                 else {
-                    // otherwise, we can export only columns which contain selected cells
                     const selectedColumnIds = this.adaptableApi.gridApi
                         .getSelectedCellInfo()
                         .columns?.map((column) => column.columnId);
                     const selectedColumnIdsSet = new Set(selectedColumnIds.filter(onlyExportableColumnIds));
-                    // ensure that column order is preserved
                     exportedColumnIds = getVisibleColumnIds().filter((colId) => selectedColumnIdsSet.has(colId));
                 }
                 break;
@@ -394,7 +331,6 @@ export class AgGridExportAdapter {
                 break;
             default:
                 this.adaptableApi.logError('Invalid ReportColumnScope: ', report.ReportColumnScope);
-                // fallback to all columns
                 exportedColumnIds = exportableColumnIds;
         }
         return {
@@ -403,7 +339,6 @@ export class AgGridExportAdapter {
             isExcelReport: config.format === 'Excel' || config.format === 'VisualExcel',
             isVisualExcelReport: config.format === 'VisualExcel',
             isExportingVisibleColumnToJSON,
-            // will be overriden later, see #isCellPartOfSelection
             isCellPartOfSelection: () => false,
             getCurrent: () => {
                 return {
@@ -419,7 +354,6 @@ export class AgGridExportAdapter {
             const cellKey = AgGridExportAdapter.getExcelClassNameForCell(columnId, this.adaptableApi.gridApi.getPrimaryKeyValueForRowNode(rowNode));
             const isoFormattedDate = this.getExcelStyleWithFormattedDate(cellKey);
             if (isoFormattedDate) {
-                // this is a Date cell which will be formatted by Excel
                 return isoFormattedDate;
             }
         }
@@ -449,12 +383,9 @@ export class AgGridExportAdapter {
         const columnDataType = this.adaptableApi.columnApi.getColumnDataTypeForColumnId(columnId);
         if (columnDataType === 'date' &&
             typeof rawValue === 'string' &&
-            // rawValue is composed only of digits
             /^\d+$/.test(rawValue)) {
-            // AG-Grid converts the value to string, we have to reconvert it back
             const dateRawValue = parseInt(rawValue);
             if (dateRawValue != undefined) {
-                // @ts-ignore
                 rawValue = dateRawValue;
             }
         }
@@ -462,21 +393,16 @@ export class AgGridExportAdapter {
     }
     patchExcelStyles(exportContext) {
         const exportExcelStyles = this.buildExcelStyles(exportContext);
-        // Concatenate exportExcelStyles to DANGER_excelStyles without changing the array reference
         this.DANGER_excelStyles.push(...exportExcelStyles);
     }
     resetExcelStyles() {
-        // Revert to original state without changing the array reference
         this.DANGER_excelStyles.splice(0, this.DANGER_excelStyles.length, ...this.originalExcelStyles);
         this.excelStylesCache = {};
         this.cellOrHeaderClassKey2ExcelStyleIdMap = {};
         this.excelStylesWithFormattedDate = {};
     }
     buildExcelStyles(exportContext) {
-        // we make sure that we start with a clean slate
-        // theoretically this should have happened at the end of the export process, but just in case
         this.resetExcelStyles();
-        // we memoize as much as possible, as this is called quite A LOT
         const adaptableColumnMemo = {};
         const getAdaptableColumnWithColumnId = (columnId) => {
             const memoizedColumn = adaptableColumnMemo[columnId];
@@ -506,7 +432,6 @@ export class AgGridExportAdapter {
         });
         const forAllVisibleRowNodesDoConfig = { includeGroupRows: true };
         const userExcelStyles = this.DANGER_excelStyles;
-        // 1. Header Styles
         agGridDisplayedColumns.forEach((column, columnIndex) => {
             const colDef = colDefs[columnIndex];
             const columnId = column.getId();
@@ -524,7 +449,6 @@ export class AgGridExportAdapter {
             };
             const headerStyle = typeof colDef.headerStyle === 'function' ? colDef.headerStyle(headerClassParams) : {};
             const excelHeaderStyles = [];
-            // add user defined excel styles
             let userColDefHeaderClass = this._adaptableInstance.agGridColumnAdapter.getUserColDefProperty(column.getColId(), 'headerClass');
             const userDefinedHeaderClass = typeof userColDefHeaderClass === 'function'
                 ? userColDefHeaderClass(headerClassParams)
@@ -538,7 +462,6 @@ export class AgGridExportAdapter {
             if (userDefinedExcelHeaderStyle) {
                 excelHeaderStyles.push(userDefinedExcelHeaderStyle);
             }
-            // add adaptable derived styles (format column etc.)
             const adaptableHeaderStyle = {
                 ...Object.keys(headerStyle).reduce((result, key) => {
                     if (headerStyle[key] !== null) {
@@ -551,7 +474,6 @@ export class AgGridExportAdapter {
             if (Object.values(sanitizedAdaptableHeaderStyle).some((style) => style != null)) {
                 excelHeaderStyles.push(this.convertCSSToExcelStyle(sanitizedAdaptableHeaderStyle));
             }
-            // don't add the header style if it has no adaptable custom styles
             if (!excelHeaderStyles.length) {
                 return;
             }
@@ -559,7 +481,6 @@ export class AgGridExportAdapter {
             const finalHeaderExcelStyle = Object.assign({}, ...excelHeaderStyles);
             this.registerExcelStyle(finalHeaderExcelStyle, headerClassId);
         });
-        // 2. Cell Styles
         this.adaptableApi.internalApi.forAllVisibleRowNodesDo((node, rowIndex) => {
             const rowParams = {
                 node,
@@ -597,7 +518,6 @@ export class AgGridExportAdapter {
                 };
                 const cellStyle = typeof colDef.cellStyle === 'function' ? colDef.cellStyle(getLazyCellClassParams()) : {};
                 const excelCellStyles = [];
-                // add user defined excel styles
                 let userColDefCellClass = this._adaptableInstance.agGridColumnAdapter.getUserColDefProperty(column.getColId(), 'cellClass');
                 const userDefinedCellClass = typeof userColDefCellClass === 'function'
                     ? userColDefCellClass(getLazyCellClassParams())
@@ -611,7 +531,6 @@ export class AgGridExportAdapter {
                 if (userDefinedExcelStyle) {
                     excelCellStyles.push(userDefinedExcelStyle);
                 }
-                // add adaptable derived styles (format column etc.)
                 const adaptableCellStyle = {
                     ...rowStyle,
                     ...Object.keys(cellStyle).reduce((result, key) => {
@@ -627,9 +546,7 @@ export class AgGridExportAdapter {
                 }
                 const excelDataType = this.getExcelDataType(adaptableColumn.dataType);
                 const rawValue = this.adaptableApi.gridApi.getRawValueFromRowNode(node, column.getId());
-                // don't add the cell style if it has no adaptable custom styles
                 if (!excelCellStyles.length &&
-                    // if this is a formatted Date value, we still need to add the AG GRID specific type & numberFormat below
                     !(excelDataType === 'DateTime' && isDateCellExportedAsFormattedValue)) {
                     return;
                 }
@@ -654,18 +571,13 @@ export class AgGridExportAdapter {
                             : dateFormatPattern;
                         const normalisedValue = this._adaptableInstance.getNormalisedValueFromRawValue(rawValue, abColumn);
                         if (normalisedValue) {
-                            // we have to pass the date in the ISO format to Excel
-                            // see https://www.ag-grid.com/javascript-data-grid/excel-export-data-types/#dates
-                            // we can NOT use Date.toISOString() because we don't want the timezone corrections to kick in
                             const isoFormattedValue = DateFormatter(normalisedValue, {
                                 Pattern: `yyyy-MM-dd'T'HH:mm:ss.SSS`,
                             });
                             if (isoFormattedValue) {
                                 finalCellExcelStyle.dataType = 'DateTime';
                                 finalCellExcelStyle.numberFormat = { format: customDateFormatPattern };
-                                // create a new cell key to ensure any user provided className does not interfere
                                 const cellKey = AgGridExportAdapter.getExcelClassNameForCell(column.getColId(), this.adaptableApi.gridApi.getPrimaryKeyValueForRowNode(node));
-                                // we need to register so that later the cellProcessor will put the isoFormattedValue through (thus giving the formatting responsability to Excel)
                                 this.registerExcelStyleWithFormattedDate(cellKey, isoFormattedValue);
                             }
                         }
@@ -691,7 +603,6 @@ export class AgGridExportAdapter {
     }
     isDateCellExportedAsFormattedValue(abColumn, exportContext) {
         return (!!this.exportOptions.exportDateFormat ||
-            // FIXME AFL move this method here
             this.getCellExportFormatType(abColumn, 'date', exportContext) === 'formattedValue');
     }
     convertCSSToExcelStyle(style) {
@@ -795,12 +706,10 @@ export class AgGridExportAdapter {
                 reportData.pivotColumnIds = exportContext.getCurrent().pivotColumnIds;
             }
         }
-        // map Row Data
         const schema = inferSchema(csvReportData, {
             col: this.getCsvSeparator(exportContext),
             header: (rows) => {
                 const headerRow = rows[0];
-                // replace headerNames with columnIds
                 headerRow.forEach((headerName, index) => {
                     const column = columns.find((col) => col.friendlyName === headerName);
                     if (column) {
@@ -858,7 +767,6 @@ export class AgGridExportAdapter {
                 createCellHeader: (cellContent) => {
                     return {
                         ...this.adaptableApi.exportApi.internalApi.createCellHeader(cellContent),
-                        // see #masterDetailHeader
                         styleId: '_masterDetailHeader',
                     };
                 },
@@ -887,12 +795,10 @@ export class AgGridExportAdapter {
         }
         const column = this.adaptableApi.columnApi.getColumnWithColumnId(columnId);
         const columnDataType = column.dataType;
-        // 1. if it is a VisualExcel report format, we always ONLY send the formatted value and ignore all other properties
         if (exportContext.isVisualExcelReport) {
             return this.getCellExportValueFromRawValueByType(rowNode, cellRawValue, columnId, 'formattedValue');
         }
         const isDateColumn = columnDataType === 'date';
-        // 2. if this is a date column and there is a custom export date format provided, that will next take precedence
         if (isDateColumn) {
             const customExportDateFormat = this.getCustomExportDateFormat(column, exportContext);
             if (!!customExportDateFormat) {
@@ -901,7 +807,6 @@ export class AgGridExportAdapter {
                 });
             }
         }
-        // 3. in all other cases check the general export format types
         const cellExportFormat = this.getCellExportFormatType(column, columnDataType, exportContext);
         return this.getCellExportValueFromRawValueByType(rowNode, cellRawValue, columnId, cellExportFormat);
     }
@@ -914,17 +819,14 @@ export class AgGridExportAdapter {
             })
             : exportDateFormatOption;
     }
-    getCellExportValueFromRawValueByType(rowNode, cellRawValue, columnId, 
-    // default to rawValue if, for some reason, the configs provide invalid values
-    type = 'rawValue') {
+    getCellExportValueFromRawValueByType(rowNode, cellRawValue, columnId, type = 'rawValue') {
         return type === 'rawValue'
             ? cellRawValue
-            : // type === formattedValue
+            :
                 this.adaptableApi.gridApi.getDisplayValueFromRawValue(rowNode, columnId, cellRawValue);
     }
     getCellExportFormatType(column, columnDataType, exportContext) {
         const exportDataFormat = this.exportOptions.exportDataFormat;
-        // First check if a function was provided and return the result
         if (exportDataFormat != null && typeof exportDataFormat === 'function') {
             const context = {
                 ...this.adaptableApi.exportApi.internalApi.buildBaseExportContext(exportContext.report.Name, exportContext.format, exportContext.destination),
@@ -932,17 +834,14 @@ export class AgGridExportAdapter {
             };
             return exportDataFormat(context);
         }
-        // Next Check if a "hard-coded" value has been provided and return that
         if (exportDataFormat === 'rawValue') {
             return 'rawValue';
         }
         if (exportDataFormat === 'formattedValue') {
             return 'formattedValue';
         }
-        // Finally test if a DataType object has been provided and return the relevant property
         const dataFormatDataType = exportDataFormat;
         if (dataFormatDataType) {
-            // format is customized based on column data type
             switch (columnDataType) {
                 case 'text':
                     return dataFormatDataType.text;
@@ -951,7 +850,6 @@ export class AgGridExportAdapter {
                 case 'date':
                     return dataFormatDataType.date;
                 default:
-                    // default to rawValue for all other column types
                     return 'rawValue';
             }
         }

package/src/agGrid/AgGridFilterAdapter.js

@@ -3,11 +3,9 @@ import { AdaptableColumnFilter } from '../View/Components/ColumnFilter/Adaptable
 import { renderWithAdaptableContext } from '../View/renderWithAdaptableContext';
 export const AgGridFilterAdapterFactory = (adaptable) => {
     function isFilterActive(colId) {
-        // we need this here
         if (adaptable.isDestroyed) {
             return false;
         }
-        //make the small filter icon to appear when there is a filter
         return adaptable.api.filterApi.columnFilterApi.isColumnFilterActiveForColumn(colId);
     }
     function getContainerId(colId) {
@@ -28,12 +26,9 @@ export const AgGridFilterAdapterFactory = (adaptable) => {
             return this.filterContainer;
         }
         refresh(newParams) {
-            // always reuse the current instance
-            // the filter is refreshed in the underlying React component
             return true;
         }
         afterGuiAttached(params) {
-            //we always unmount first so the autofocus from the form works... in other grids we unmount when hidden
             this.unmountReactRoot?.();
             const columnId = this.column.getColId();
             let column = adaptable.api.columnApi.getColumnWithColumnId(columnId);

package/src/agGrid/AgGridFloatingFilterAdapter.js

@@ -27,7 +27,6 @@ export const AgGridFloatingFilterAdapterFactory = (adaptable) => {
     function findParentWithClass(element, className, stopClasses, applyToAll) {
         let current = element.parentElement;
         while (current) {
-            // Stop traversing if we hit any of the stop classes
             if (stopClasses.some((stopClass) => current.classList.contains(stopClass))) {
                 return null;
             }
@@ -44,14 +43,12 @@ export const AgGridFloatingFilterAdapterFactory = (adaptable) => {
             return;
         }
         const stopClasses = ['ag-header-row', 'ag-header-row-column-filter'];
-        // Find and update floating filter body
         const filterBody = findParentWithClass(filterContainer, 'ag-floating-filter-full-body', stopClasses, (currentElem) => {
             currentElem.style.height = '100%';
         });
         if (filterBody) {
             filterBody.style.overflow = 'visible';
         }
-        // Find and update header cell
         const headerCell = findParentWithClass(filterContainer, 'ag-header-cell', stopClasses);
         if (headerCell?.classList.contains('ag-floating-filter')) {
             headerCell.style.padding = 'var(--ab-base-space)';
@@ -67,7 +64,6 @@ export const AgGridFloatingFilterAdapterFactory = (adaptable) => {
             this.filterContainer = document.createElement('div');
             this.filterContainer.id = getContainerId(colId);
             Object.keys(filterContainerStyle).forEach((key) => {
-                //@ts-ignore
                 this.filterContainer.style[key] = filterContainerStyle[key];
             });
             const column = adaptableApi.columnApi.getColumnWithColumnId(colId);
@@ -79,8 +75,6 @@ export const AgGridFloatingFilterAdapterFactory = (adaptable) => {
             }
         }
         onParentModelChanged(parentModel, filterChangedEvent) {
-            // AFL: this should NOT be required, but AG Grid calls this method
-            // most likely is a bug and will be removed in future versions
         }
         afterGuiAttached() {
             patchParentElement(this.filterContainer);
@@ -89,13 +83,9 @@ export const AgGridFloatingFilterAdapterFactory = (adaptable) => {
             return this.filterContainer;
         }
         refresh(params) {
-            // always reuse the current instance
-            // the filter is refreshed in the underlying React component
             return true;
         }
         destroy() {
-            // Use setTimeout to defer unmounting to next event loop tick
-            // This ensures we're not unmounting during React's rendering phase
             if (this.unmountReactRoot) {
                 const unmount = this.unmountReactRoot;
                 setTimeout(() => {