@adaptabletools/adaptable 23.0.4-canary.0 → 23.0.5-canary.0

package/src/Strategy/StyledColumnModule.js

@@ -24,8 +24,7 @@ import { StyledColumnSparklinePreview } from '../View/StyledColumn/Wizard/Styled
 import { getObjectTagsViewItems } from '../Utilities/getObjectTagsViewItems';
 export class StyledColumnModule extends AdaptableModuleBase {
     constructor(api) {
-        super(ModuleConstants.StyledColumnModuleId, ModuleConstants.StyledColumnFriendlyName, 'brush', 'StyledColumnPopup', // to change
-        'Create a Special Column Style e.g Gradient, Percent Bar or Badge', api);
+        super(ModuleConstants.StyledColumnModuleId, ModuleConstants.StyledColumnFriendlyName, 'brush', 'StyledColumnPopup', 'Create a Special Column Style e.g Gradient, Percent Bar or Badge', api);
     }
     getModuleAdaptableObjects(config) {
         return this.api.styledColumnApi.getStyledColumns(config);
@@ -38,17 +37,13 @@ export class StyledColumnModule extends AdaptableModuleBase {
     }
     createColumnMenuItems(column) {
         let returnColumnMenuItems = [];
-        // Need a Column and an editable Module
         if (column && this.isModuleEditable() && !column.isTreeColumn) {
             let styledColumn = this.api.styledColumnApi.getStyledColumnForColumnId(column.columnId);
-            // First look at Sparkline Columns - needs to be editable array type
             if (this.api.columnApi.hasNumericArrayDataType(column.columnId) &&
                 column.IsReadOnly !== true &&
                 this.api.styledColumnApi.canDisplaySparklines()) {
                 let sparklineColumnExists = column.isSparkline && Boolean(styledColumn);
                 if (column.isSparkline && !sparklineColumnExists) {
-                    // do nothing as we only want to continue if there is no sparkline column or if its in state
-                    // because if just one then it was created in AG Grid and we dont want to edit it
                 }
                 else {
                     const hasSparklineStyle = styledColumn != null && styledColumn.SparklineStyle != null;
@@ -68,17 +63,13 @@ export class StyledColumnModule extends AdaptableModuleBase {
                         source: 'ColumnMenu',
                         value: styledColumn,
                         config: {
-                            // New Styled Columns must land on the Settings step so the user
-                            // can enter the (mandatory) Name. Edit jumps straight to Style.
                             defaultCurrentSectionName: hasSparklineStyle ? 'Style' : 'Settings',
                         },
                     };
                     returnColumnMenuItems.push(this.createMenuItemShowPopup(name, label + 'Sparkline Column', this.moduleInfo.Popup, this.getGlyphForStyledColumn(styledColumn), popupParam));
                 }
             }
-            // Next do non sparkline
             else if (!column.isSparkline) {
-                // Edit is common
                 if (styledColumn) {
                     if (!styledColumn.IsReadOnly) {
                         const defaultCurrentSectionName = getStyledColumnEditDefaultSectionName(styledColumn);
@@ -121,8 +112,6 @@ export class StyledColumnModule extends AdaptableModuleBase {
                             defaultCurrentSectionName: 'Settings',
                         },
                     });
-                    // Icon Style resolves one key → glyph per cell; array columns are
-                    // unsupported (use Badge for per-element visuals).
                     const newIconButton = this.createMenuItemShowPopup('styled-column-icon-add', 'Create Icon Column', this.moduleInfo.Popup, 'icon-style', {
                         ...popupParam,
                         value: {
@@ -136,8 +125,6 @@ export class StyledColumnModule extends AdaptableModuleBase {
                         },
                     });
                     switch (column.dataType) {
-                        // Number
-                        // Create Styled Column - Gradient | Percent Bar | Badge
                         case 'number':
                             const emptyRanges = this.api.columnScopeApi.createCellColorRangesForScope({
                                 ColumnIds: [column.columnId],
@@ -192,8 +179,6 @@ export class StyledColumnModule extends AdaptableModuleBase {
                                 ...popupParam,
                                 value: {
                                     ...newStyledColumn,
-                                    // Seed with column-wide bounds so the Style step opens
-                                    // with a valid (renderable) configuration.
                                     RangeBarStyle: {
                                         Min: 'Col-Min',
                                         Max: 'Col-Max',

package/src/Strategy/TeamSharingModule.js

@@ -26,7 +26,6 @@ export class TeamSharingModule extends AdaptableModuleBase {
     }
     onAdaptableReady() {
         if (this.api.teamSharingApi.isTeamSharingAvailable()) {
-            // make sure there is no zombie import process remaining (in case a previous import crashed)
             this.api.internalApi.dispatchReduxAction(TeamSharingRedux.TeamSharingCommitImport());
             this.api.teamSharingApi.refreshTeamSharing();
         }
@@ -45,25 +44,20 @@ export class TeamSharingModule extends AdaptableModuleBase {
         return 1000;
     }
     handleStateChanged(adaptableStateChangedInfo) {
-        // check if TeamSharing is activated
         if (!this.api.teamSharingApi.isTeamSharingAvailable()) {
             return;
         }
-        // skip all teamsharing actions, otherwise we could get in an infinite loop
         if (this.SKIP_TEAMSHARING_UPDATE_ACTIONS.includes(adaptableStateChangedInfo.action.type)) {
             return;
         }
-        // check if there is any changed adaptable object
         const changedAdaptableObject = this.extractAdaptableObjectFromAction(adaptableStateChangedInfo.action);
         if (!changedAdaptableObject) {
             return;
         }
-        // check if the changed adaptable object is active in TeamSharing
         const activeSharedEntity = this.api.internalApi.getState().TeamSharing.ActiveSharedEntityMap[changedAdaptableObject.Uuid];
         if (!activeSharedEntity) {
             return;
         }
-        // handle special case of LAYOUT_SAVE which might be called redundantly without actually changing the state
         const isLayoutStateUnchanged = adaptableStateChangedInfo.action.type === LAYOUT_SAVE &&
             isEqual(adaptableStateChangedInfo.oldState.Layout, adaptableStateChangedInfo.newState.Layout);
         if (isLayoutStateUnchanged) {
@@ -72,8 +66,6 @@ export class TeamSharingModule extends AdaptableModuleBase {
         this.api.internalApi.dispatchReduxAction(TeamSharingUpdateItem(changedAdaptableObject, adaptableStateChangedInfo.userName));
     }
     extractAdaptableObjectFromAction(action) {
-        // this implementation is based on the assumption that any action which mutates an AdaptableObject has
-        // at most one(1) property which has an 'Uuid:TypeUuid' defined (and that is the AdaptableObject, of course)
         if (!action) {
             return;
         }
@@ -157,7 +149,6 @@ export class TeamSharingModule extends AdaptableModuleBase {
     }
     toViewAll() {
         return ((this.api.teamSharingApi.getLoadedAdaptableSharedEntities() ?? [])
-            // only top level
             .filter((sharedEntity) => !this.isSharedEntityADependency(sharedEntity))
             .map((item) => this.toView(item)));
     }

package/src/Strategy/Utilities/Layout/columnsSummaryHelpers.js

@@ -92,12 +92,7 @@ export function getTableColumnsSizingSummaryValues(layout, api) {
 export function getTableColumnsSortingSummaryValues(layout, api) {
     return (layout.ColumnSorts ?? []).map((sort) => `[${api.columnApi.getFriendlyNameForColumnId(sort.ColumnId, layout)}: ${sort.SortOrder}]`);
 }
-/** Matches legacy Layout settings panel behaviour (`layoutViewOptions.maxColumnsToDisplay`). */
 export const DEFAULT_LAYOUT_VIEW_MAX_COLUMNS = 10;
-/**
- * Collapse a long column list for compact views (e.g. Layout settings panel).
- * Keeps all items when the overflow is only 1 column; otherwise shows `+N more`.
- */
 export function truncateColumnSummaryValues(values, maxToDisplay = DEFAULT_LAYOUT_VIEW_MAX_COLUMNS) {
     if (maxToDisplay <= 0 || values.length <= maxToDisplay + 1) {
         return values;

package/src/Utilities/Constants/DocumentationLinkConstants.js

@@ -1,6 +1,5 @@
 export const HOST_URL_ROOT = 'https://www.adaptabletools.com';
 export const HOST_URL_DOCS = `${HOST_URL_ROOT}/docs`;
-//export const HOST_URL_DOCS = 'http://localhost:3000';
 export const ExpressionEditorDocsLink = `${HOST_URL_DOCS}/ui-expression-editor`;
 export const BooleanQueryDocsLink = `${HOST_URL_DOCS}/adaptable-ql-expression-standard`;
 export const ScalarQueryDocsLink = `${HOST_URL_DOCS}/adaptable-ql-expression-standard`;

package/src/Utilities/Constants/GeneralConstants.js

@@ -13,7 +13,6 @@ export const ADAPTABLE = 'AdapTable';
 export const ADAPTABLE_ID = 'adaptable_id';
 export const ADAPTABLE_TOOLPANEL_ID = 'adaptable';
 export const ADAPTABLE_TOOLPANEL_COMPONENT = 'AdaptableToolPanel';
-// from https://www.ag-grid.com/javascript-data-grid/side-bar/#string-configuration
 export const AGGRID_TOOLPANEL_FILTERS = 'filters';
 export const AGGRID_TOOLPANEL_COLUMNS = 'columns';
 export const READ_ONLY_STYLE = 'ab_readonly';
@@ -29,7 +28,6 @@ export const AG_GRID_PIVOT_GRAND_TOTAL_COLUMN = 'PivotRowTotal_pivot_';
 export const AG_GRID_CHART_WINDOW = 'AG Grid Window';
 export const AG_GRID_GRAND_TOTAL_ROW_ID = 'rowGroupFooter_ROOT_NODE_ID';
 export const ADAPTABLE_FDC3_ACTION_COLUMN_FRIENDLY_NAME = '(FDC3ActionColumn)';
-// FIXME AFL - load this from DateInputOptions
 export const DEFAULT_DATE_FORMAT_PATTERN = 'dd-MM-yyyy';
 export const DEFAULT_DATE_FORMAT_PATTERN_WITH_TIME = 'dd-MM-yyyy HH:mm:ss';
 export const DEFAULT_STRING_DISPLAY_VALUE = 'Hello World';
@@ -37,12 +35,9 @@ export const DEFAULT_INTEGER_DISPLAY_VALUE = 12345;
 export const DEFAULT_DOUBLE_DISPLAY_VALUE = 12345.6789;
 export const QUICK_SEARCH_DEBOUNCE_TIME = 350;
 export const MENU_SEPARATOR = '-';
-// Live Report Throttle Time (used in OpenFin, IPushPull etc.)
 export const DEFAULT_LIVE_REPORT_THROTTLE_TIME = 2000;
-// Validation
 export const SERVER_VALIDATION_HEADER = 'Server Validation Message';
 export const SERVER_VALIDATION_MESSAGE_TYPE = 'Info';
-// System Report Name Constants
 export const ALL_DATA_REPORT = 'All Data';
 export const CURRENT_LAYOUT_REPORT = 'Current Layout';
 export const SELECTED_DATA_REPORT = 'Selected Data';
@@ -51,7 +46,6 @@ export const SYSTEM_REPORT_NAMES = [
     ALL_DATA_REPORT,
     SELECTED_DATA_REPORT,
 ];
-// Systen Report Format Constants
 export const EXCEL_FORMAT_REPORT = 'Excel';
 export const VISUAL_EXCEL_FORMAT_REPORT = 'VisualExcel';
 export const CSV_FORMAT_REPORT = 'CSV';
@@ -70,9 +64,7 @@ export const SYSTEM_EXPORT_DESTINATIONS = [
     DOWNLOAD_EXPORT_DESTINATION,
     CLIPBOARD_EXPORT_DESTINATION,
 ];
-// Theme Constants
 export const THEME_STYLE = `ab--theme-`;
-// Layout UI Constants
 export const LAYOUT_NEW_TABLE_TOOLTIP = 'Create a new Table Layout';
 export const LAYOUT_NEW_PIVOT_TOOLTIP = 'Create a new Pivot Layout';
 export const LAYOUT_NEW_TABLE_OR_PIVOT_TOOLTIP = 'Create a new Layout';
@@ -80,7 +72,6 @@ export const LAYOUT_SAVE_TOOLTIP = 'Save Changes to Current Layout';
 export const LAYOUT_EDIT_TOOLTIP = 'Edit Layout';
 export const LAYOUT_CLONE_TOOLTIP = 'Clone Layout';
 export const LAYOUT_DELETE_TOOLTIP = 'Delete Layout';
-// Standalone Popups
 export const STANDALONE_MODULE_POPUPS = [
     'BulkUpdate',
     'SmartEdit',
@@ -88,7 +79,6 @@ export const STANDALONE_MODULE_POPUPS = [
 ];
 export const OBSERVABLE_EXPRESSION_ROW_ADDED = 'ROW_ADDED';
 export const OBSERVABLE_EXPRESSION_ROW_REMOVED = 'ROW_REMOVED';
-// Entitlement Access Level Constants
 export const ACCESS_LEVEL_FULL = 'Full';
 export const ACCESS_LEVEL_READ_ONLY = 'ReadOnly';
 export const ACCESS_LEVEL_HIDDEN = 'Hidden';

package/src/Utilities/Constants/ObjectDefaultConstants.js

@@ -1,6 +1,3 @@
-/**
- * Object Factory
- */
 export const PLUS_MINUS_DEFAULT_NUDGE_VALUE = 1;
 export const ALERT_DEFAULT_MESSAGE_TYPE = 'Error';
 export const ALERT_DEFAULT_SHOW_POPUP = true;

package/src/Utilities/Constants/ReduxConstants.js

@@ -1,14 +1,10 @@
 import { SummaryOperation } from '../../AdaptableState/Common/Enums';
 import { getSwatchColorVar } from '../../View/UIHelper';
 import { LIGHT_THEME, DARK_THEME, OS_THEME } from './GeneralConstants';
-// Cells Summary
 export const CELL_SUMMARY_DEFAULT_OPERATION = SummaryOperation.Sum;
-// Quick Search — text match uses a stronger yellow; cell background uses a lighter shade
-export const QUICK_SEARCH_DEFAULT_TEXT_BACK_COLOR = getSwatchColorVar(9); // #ffff00
-export const QUICK_SEARCH_DEFAULT_CELL_BACK_COLOR = getSwatchColorVar(10); // #ffffe0
-export const QUICK_SEARCH_DEFAULT_FORE_COLOR = getSwatchColorVar(1); // black
-export const QUICK_SEARCH_DEFAULT_CURRENT_BACK_COLOR = getSwatchColorVar(20); // orange
-// theme
-// consts for Themes
+export const QUICK_SEARCH_DEFAULT_TEXT_BACK_COLOR = getSwatchColorVar(9);
+export const QUICK_SEARCH_DEFAULT_CELL_BACK_COLOR = getSwatchColorVar(10);
+export const QUICK_SEARCH_DEFAULT_FORE_COLOR = getSwatchColorVar(1);
+export const QUICK_SEARCH_DEFAULT_CURRENT_BACK_COLOR = getSwatchColorVar(20);
 export const SYSTEM_THEMES = [LIGHT_THEME, DARK_THEME, OS_THEME];
 export const THEME_DEFAULT_CURRENT_THEME = LIGHT_THEME;

package/src/Utilities/Emitter.js

@@ -1,9 +1,7 @@
-/** based on emittery npm package, which is MIT */
 const anyMap = new WeakMap();
 const eventsMap = new WeakMap();
 const triggeredMap = new WeakMap();
 const resolvedPromise = Promise.resolve();
-//type EmitterCallback = (data?: any) => any;
 function assertEventName(eventName) {
     if (typeof eventName !== 'string') {
         throw new TypeError('eventName must be a string');
@@ -17,8 +15,6 @@ function assertListener(listener) {
 function getListeners(instance, eventName) {
     const events = eventsMap.get(instance);
     if (!events) {
-        // we're hitting this case only when calling `off` after the instance has been destroyed (so extremely rarely)
-        // so we want to return an empty set in order not to make the code throw an error
         return new Set();
     }
     if (!events.has(eventName)) {
@@ -85,9 +81,6 @@ class Emittery {
     }
     destroy() {
         this.clearListeners();
-        // should not be needed, since those maps are weak
-        // but let's do it anyway - some of our users suggested this Emitter class
-        // could be a source of memory leaks, so let's clean this up
         anyMap.delete(this);
         eventsMap.delete(this);
         triggeredMap.delete(this);
@@ -178,7 +171,6 @@ class Emittery {
         const staticListeners = [...listeners];
         const staticAnyListeners = [...anyListeners];
         await resolvedPromise;
-        /* eslint-disable no-await-in-loop */
         for (const listener of staticListeners) {
             if (listeners.has(listener)) {
                 await listener(eventData);
@@ -189,7 +181,6 @@ class Emittery {
                 await listener(eventName, eventData);
             }
         }
-        /* eslint-enable no-await-in-loop */
     }
     onAny(listener) {
         assertListener(listener);

package/src/Utilities/ExpressionFunctions/aggregatedBooleanExpressionFunctions.js

@@ -17,9 +17,6 @@ const aggregationScalarOperandMap = {
     AVG: ['string', 'number'],
     COUNT: ['string', 'number'],
 };
-// 0. optional non-capturing block of empty spaces
-// 1. block containing a numeric value (any digits) (required)
-// 2. block containing a single 'K', 'M' or 'B' letter (optional) (case insensitive)
 const CRITERIA_REGEX = /^(?:\s*)(\d+)(K|M|B)?$/i;
 export const aggregatedBooleanExpressionFunctions = {
     WHERE: {
@@ -141,9 +138,7 @@ export const aggregatedBooleanExpressionFunctions = {
     },
 };
 const buildBooleanAggregationParameter = (args, context, comparisonOperator, conditionFn) => {
-    // LHS
     const aggregationOperand = extractScalarAggregationOperand(comparisonOperator, args[0]);
-    // RHS
     const scalarOperand = extractScalarOperand(comparisonOperator, args[1], aggregationScalarOperandMap[aggregationOperand.name]);
     return {
         type: 'aggregationBoolean',
@@ -169,7 +164,6 @@ const extractScalarOperand = (consumingFunctionName, value, allowedTypes) => {
     if (typeof value === 'number') {
         return value;
     }
-    // assertion is safe, we checked in the IF above
     const stringValue = value;
     const matchingResult = stringValue.match(CRITERIA_REGEX);
     const numericString = matchingResult?.[1];
@@ -177,14 +171,12 @@ const extractScalarOperand = (consumingFunctionName, value, allowedTypes) => {
     if (!numericString) {
         throw new ExpressionEvaluationError('Numeric abbreviation', `"${stringValue}" is invalid, expecting a number with a suffix for thousands(K), millions(M) or billions(B)"`);
     }
-    // unit -> number
     const numberUnitRatios = {
         number: 1,
         k: 1000,
         m: 1000000,
         b: 1000000000,
     };
-    // numeric value
     return parseInt(numericString) * numberUnitRatios[largeNumberUnit.toLowerCase()];
 };
 export const aggregatedBooleanExpressionFunctionNames = getTypedKeys(aggregatedBooleanExpressionFunctions);

package/src/Utilities/ExpressionFunctions/aggregatedScalarExpressionFunctions.js

@@ -61,8 +61,6 @@ export const aggregatedScalarExpressionFunctions = {
                 isOptional: true,
             });
             if (!!groupByParameter) {
-                // ensure the GROUP_BY is NOT on the CUMUL function
-                // it should be on the AGGREGATION function
                 throw new ExpressionEvaluationError('GROUP_BY', `should be passed as an argument to the '${aggregationParameter.name}' aggregation function!`);
             }
             const cumulationExpressionEvaluation = mapAggregationToCumulation(aggregationParameter, overColumnParameter, context);
@@ -224,7 +222,6 @@ export const aggregatedScalarExpressionFunctions = {
                                 }
                                 const numericRowValue = getNumericValue(rowValue);
                                 if (weightParameter) {
-                                    // weighted average
                                     const weightValue = getNumericValue(context.adaptableApi.gridApi.getRawValueFromRowNode(rowNode, weightParameter.value)) ?? 0;
                                     aggregatedValue.sumOfValues =
                                         aggregatedValue.sumOfValues + numericRowValue * weightValue;
@@ -514,7 +511,6 @@ export const aggregatedScalarExpressionFunctions = {
                             field: columnName,
                             initialValue: { sumOfValues: 0, values: [] },
                             reducer: (aggregatedValue, rowValue, rowNode) => {
-                                // TODO: getNumericValue; allow numeric strings
                                 if (typeof rowValue !== 'number' || isNaN(rowValue)) {
                                     return aggregatedValue;
                                 }
@@ -584,7 +580,6 @@ export const aggregatedScalarExpressionFunctions = {
                                     return numericRowValue < minValue ? numericRowValue : minValue;
                                 }
                                 else {
-                                    // Date
                                     return isAfter(parseDateValue(rowValue), parseDateValue(minValue))
                                         ? minValue
                                         : rowValue;
@@ -648,7 +643,6 @@ export const aggregatedScalarExpressionFunctions = {
                                     return numericRowValue > maxValue ? numericRowValue : maxValue;
                                 }
                                 else {
-                                    // Date
                                     return isAfter(parseDateValue(rowValue), parseDateValue(maxValue))
                                         ? rowValue
                                         : maxValue;
@@ -701,7 +695,6 @@ export const aggregatedScalarExpressionFunctions = {
             const groupByColumnNames = groupByOperand?.value;
             let quantReducer;
             if (groupByColumnNames?.length) {
-                // do the heavy-lifting in done()
                 quantReducer = {
                     initialValue: {},
                     reducer: (nodeValueMap, rowValue, rowNode, rowIndex) => {
@@ -744,7 +737,6 @@ export const aggregatedScalarExpressionFunctions = {
                 };
             }
             else {
-                // in case of non-grouped quantiles, we are able to calculate the buckets beforehand (which is the most efficient)
                 const populationSize = context.adaptableApi.gridApi.getAllRowNodes()?.filter((rowNode) => {
                     const rowValue = context.adaptableApi.gridApi.getRawValueFromRowNode(rowNode, quantileColumnName);
                     return isDefinedValue(rowValue);
@@ -1159,8 +1151,6 @@ export const aggregatedScalarExpressionFunctions = {
                 isOptional: true,
             });
             if (!!groupByParameter) {
-                // ensure the GROUP_BY is NOT on the ABSOLUTE_DIFF function
-                // it should be on the AGGREGATION function
                 throw new ExpressionEvaluationError('GROUP_BY', `should be passed as an argument to the '${relativeValueParameter.name}' aggregation function!`);
             }
             const absoluteDiffExpressionEvaluation = mapWrappedAggregationToDiff(context, 'ABSOLUTE_DIFF', relativeValueParameter, absoluteDiffColumnName, columnType);
@@ -1189,8 +1179,6 @@ export const aggregatedScalarExpressionFunctions = {
                 isOptional: true,
             });
             if (!!groupByParameter) {
-                // ensure the GROUP_BY is NOT on the ABSOLUTE_DIFF function
-                // it should be on the AGGREGATION function
                 throw new ExpressionEvaluationError('GROUP_BY', `should be passed as an argument to the '${relativeValueParameter.name}' aggregation function!`);
             }
             const percentDiffExpressionEvaluation = mapWrappedAggregationToDiff(context, 'PERCENT_DIFF', relativeValueParameter, percentDiffColumnName, columnType);
@@ -1293,7 +1281,6 @@ const mapAggregationToCumulation = (aggregationParameter, overColumnParameter, c
                         reducer: (cumulationBag, rowValue, rowNode) => {
                             if (isDefinedValue(rowValue)) {
                                 if (aggregationEvaluation.context?.weightParam) {
-                                    // weighted average
                                     const weightValue = context.adaptableApi.gridApi.getRawValueFromRowNode(rowNode, aggregationEvaluation.context.weightParam.value) ?? 0;
                                     cumulationBag.currentValue =
                                         cumulationBag.currentValue + rowValue * weightValue;
@@ -1391,7 +1378,6 @@ const mapWrappedAggregationToDiff = (context, diffWrapperFunction, aggregationPa
             if (diffWrapperFunction === 'PERCENT_DIFF') {
                 return ((cellValue - aggregatedValue) / aggregatedValue) * 100;
             }
-            // should never happen
             return null;
         },
         rowFilterFn: aggregationEvaluation.rowFilterFn,
@@ -1403,7 +1389,6 @@ const mapWrappedAggregationToDiff = (context, diffWrapperFunction, aggregationPa
     return absoluteDiffExpressionEvaluation;
 };
 export const aggregatedScalarExpressionFunctionNames = getTypedKeys(aggregatedScalarExpressionFunctions);
-// !! mutates expressionEvaluation
 export const addGroupByParams = (groupByColumnNames, expressionEvaluation) => {
     if (groupByColumnNames?.length) {
         expressionEvaluation.aggregationParams.groupBy = groupByColumnNames.map((columnName) => ({

package/src/Utilities/ExpressionFunctions/booleanExpressionFunctions.js

@@ -242,8 +242,6 @@ export const booleanExpressionFunctions = {
         returnType: 'boolean',
         inputs: [
             ['number', 'number[]'],
-            // Date is currently not supported in select
-            // ['date', 'date[]'],
             ['text', 'text[]'],
         ],
     },
@@ -312,7 +310,6 @@ export const booleanExpressionFunctions = {
     },
     REGEX: {
         handler(args) {
-            // dont need context as here we always want case insenstivity in the Regex
             const firstInput = String(args[0]);
             const regex = String(args[1]);
             return RegExp(regex).test(firstInput);

package/src/Utilities/ExpressionFunctions/deepMap.js

@@ -22,9 +22,6 @@ export class DeepMap {
         let currentMap = this.map;
         if (!keys.length) {
             throw `Cannot set given keys - please provide a non-empty keys array.`;
-            // currentMap.set((EMPTY_KEY as unknown) as K, { value });
-            // this.length++;
-            // return this;
         }
         for (let i = 0, len = keys.length; i < len; i++) {
             const key = keys[i];
@@ -51,7 +48,6 @@ export class DeepMap {
         let currentMap = this.map;
         if (!keys.length) {
             throw `Cannot get given keys - please provide a non-empty keys array.`;
-            // return currentMap.get((EMPTY_KEY as unknown) as K)?.value;
         }
         for (let i = 0, len = keys.length; i < len; i++) {
             const key = keys[i];
@@ -91,10 +87,6 @@ export class DeepMap {
         let currentMap = this.map;
         if (!keys.length) {
             throw `Cannot delete given keys - please provide a non-empty keys array.`;
-            // if (currentMap.has(EMPTY_KEY as unknown as K)) {
-            //   this.length--;
-            // }
-            // return currentMap.delete((EMPTY_KEY as unknown) as K);
         }
         let maps = [currentMap];
         let result = false;
@@ -114,7 +106,6 @@ export class DeepMap {
                         delete pair.map;
                     }
                     if (!pair.map) {
-                        // pair is empty, so we can remove it altogether
                         currentMap.delete(key);
                     }
                 }
@@ -137,10 +128,8 @@ export class DeepMap {
                 let parentMap = maps[maps.length - 1];
                 let pair = parentMap?.get(key);
                 if (pair) {
-                    // pair.map === map ; which can be deleted
                     delete pair.map;
                     if (!pair.hasOwnProperty('value')) {
-                        // whole pair can be successfully deleted from parentMap
                         parentMap.delete(key);
                     }
                 }
@@ -152,10 +141,6 @@ export class DeepMap {
         let currentMap = this.map;
         if (!keys.length) {
             throw `Cannot find existing given keys - please provide a non-empty keys array.`;
-            // return (
-            //   currentMap.has((EMPTY_KEY as unknown) as K) &&
-            //   currentMap.get((EMPTY_KEY as unknown) as K)?.value !== undefined
-            // );
         }
         for (let i = 0, len = keys.length; i < len; i++) {
             const key = keys[i];
@@ -191,7 +176,6 @@ export class DeepMap {
         if (pair.hasOwnProperty('value')) {
             fn(pair, keys, next);
         }
-        // if it was called by fn, it won't be called again, as it's once-d
         next();
     }
     visit = (fn) => {

package/src/Utilities/ExpressionFunctions/expressionFunctionUtils.js

@@ -3,8 +3,6 @@ import StringExtensions from '../Extensions/StringExtensions';
 import { filter } from 'rxjs/operators';
 import { toNumber } from '../Extensions/NumberExtensions';
 import { evaluateNode } from '../../parser/src/evaluator';
-// string functions may be case (in)sensitive, see internalApi.isTextComparisonCaseSensitive()
-// if case is insensitive, we convert ALL involved strings to lower case
 export const getStringValues = (context, ...stringArguments) => {
     return isTextSearchCaseInsensitive(context)
         ? stringArguments.map((string) => string.toLowerCase())
@@ -14,13 +12,9 @@ export const getStringValue = (context, stringArgument) => {
     return isTextSearchCaseInsensitive(context) ? stringArgument.toLowerCase() : stringArgument;
 };
 export const isTextSearchCaseInsensitive = (context) => !context.adaptableApi.expressionApi.useCaseSensitivity();
-// returns an observable which filters the source$ emissions and emits only if the CellDataChangedInfo relates to the given column
-// optionally, if a filter function (where clause) is provided, it is also evaluated
 export const getDataChangeLog$ = (context, columnNameFilter) => {
     let dataChangeLog$ = context.adaptableApi.internalApi.getDataService().cellDataChangeLog$;
-    // filter only the given column changes
     dataChangeLog$ = dataChangeLog$.pipe(filter((dataChangeLog) => dataChangeLog.column.columnId === columnNameFilter));
-    // filter based on the WHERE clause
     if (context.filterFn) {
         dataChangeLog$ = dataChangeLog$.pipe(filter((value) => {
             return context.filterFn(value.rowNode);
@@ -31,7 +25,6 @@ export const getDataChangeLog$ = (context, columnNameFilter) => {
 export const getGridChangeLog$ = (context, rowChangeType) => {
     const gridChangeLog$ = context.adaptableApi.internalApi.getDataService().rowDataChangeLog$;
     let gridChangeStream$ = gridChangeLog$.pipe(filter((rowDataChangedInfo) => rowDataChangedInfo.rowTrigger === rowChangeType));
-    // filter based on the WHERE clause
     if (context.filterFn) {
         gridChangeStream$ = gridChangeStream$.pipe(filter((value) => value.rowNodes.some((node) => context.filterFn(node))));
     }
@@ -41,7 +34,6 @@ export const handleWhereFunction = (args, context) => {
     const reactiveExpressionNode = args[0];
     const whereClauseExpressionNode = args[1];
     const filterFn = (rowNode) => {
-        // whereClauseResult
         return evaluateNode(whereClauseExpressionNode, {
             node: rowNode,
             functions: context.whereClauseFunctions,
@@ -49,7 +41,6 @@ export const handleWhereFunction = (args, context) => {
             ...context.adaptableApi.internalApi.buildBaseContext(),
         });
     };
-    // observableExpressionResult
     return evaluateExpressionNode(reactiveExpressionNode, context, filterFn);
 };
 export const evaluateExpressionNode = (expressionNode, context, filterFn = context.filterFn) => {

package/src/Utilities/ExpressionFunctions/groupingMap.js

@@ -62,15 +62,6 @@ function initReducers(reducers) {
         }
     return result;
 }
-/**
- *
- * This fn mutates the reducerResults array!!!
- *
- * @param data data item
- * @param reducers an array of reducers
- * @param reducerResults the results on which to operate
- *
- */
 function computeReducersFor(data, reducers, reducerResults) {
     if (!reducers || !Object.keys(reducers).length) {
         return;