@adaptabletools/adaptable-cjs 23.0.4 → 23.0.5-canary.1

package/src/Api/Implementation/LayoutApiImpl.js

@@ -101,7 +101,6 @@ class LayoutApiImpl extends ApiBase_1.ApiBase {
         const config = {
             includeLayoutNotExtendedObjects: true,
         };
-        // Alerts
         const alertExtensions = extendedLayoutInfo.Extensions.filter((e) => {
             return e.Module == 'Alert';
         });
@@ -112,7 +111,6 @@ class LayoutApiImpl extends ApiBase_1.ApiBase {
                 this.getAlertApi().addAlertDefinition(alertDefinition);
             }
         });
-        // Custom Sorts
         const customSortExtensions = extendedLayoutInfo.Extensions.filter((e) => {
             return e.Module == 'CustomSort';
         });
@@ -123,7 +121,6 @@ class LayoutApiImpl extends ApiBase_1.ApiBase {
                 this.getCustomSortApi().addCustomSort(customSort);
             }
         });
-        // Flashing Cells
         const flashingCellExtensions = extendedLayoutInfo.Extensions.filter((e) => {
             return e.Module == 'FlashingCell';
         });
@@ -134,7 +131,6 @@ class LayoutApiImpl extends ApiBase_1.ApiBase {
                 this.getFlashingCellApi().addFlashingCellDefinition(flashingCellDefinition);
             }
         });
-        // FormatColumns
         const formatColumnExtensions = extendedLayoutInfo.Extensions.filter((e) => {
             return e.Module == 'FormatColumn';
         });
@@ -145,7 +141,6 @@ class LayoutApiImpl extends ApiBase_1.ApiBase {
                 this.getFormatColumnApi().addFormatColumn(formatColumn);
             }
         });
-        // Plus Minus
         const plusMinusExtensions = extendedLayoutInfo.Extensions.filter((e) => {
             return e.Module == 'PlusMinus';
         });
@@ -156,7 +151,6 @@ class LayoutApiImpl extends ApiBase_1.ApiBase {
                 this.getPlusMinusApi().addPlusMinusNudge(plusMinusNudge);
             }
         });
-        // Schedule
         const exportExtensions = extendedLayoutInfo.Extensions.filter((e) => e.Module === 'Export');
         exportExtensions.forEach((le) => {
             const raw = le.Object;
@@ -168,7 +162,6 @@ class LayoutApiImpl extends ApiBase_1.ApiBase {
                 this.getExportApi().addScheduledReport(schedule);
             }
         });
-        // StyledColumn
         const styledColumnExtensions = extendedLayoutInfo.Extensions.filter((e) => {
             return e.Module == 'StyledColumn';
         });
@@ -190,7 +183,6 @@ class LayoutApiImpl extends ApiBase_1.ApiBase {
             includeLayoutNotExtendedObjects: false,
             extendedLayoutName: layoutName,
         };
-        // cannot see a better way than to go through this module by module...
         let extensions = [];
         this.getAlertApi()
             .getAlertDefinitions(config)
@@ -233,19 +225,16 @@ class LayoutApiImpl extends ApiBase_1.ApiBase {
         };
     }
     cloneExtendedLayout(extendedLayoutToClone, layoutName) {
-        // first clone the underlying Layout
         const clonedLayout = this.cloneLayout(extendedLayoutToClone.Layout, layoutName);
         if (clonedLayout == false) {
             return false;
         }
-        // Alerts
         const alertExtensions = extendedLayoutToClone.Extensions.filter((e) => e.Module == 'Alert');
         alertExtensions.forEach((le) => {
             const alertDef = le.Object;
             alertDef.Tags?.push(layoutName);
             this.getAlertApi().editAlertDefinition(alertDef);
         });
-        // Custom Sorts
         const customSortExtensions = extendedLayoutToClone.Extensions.filter((e) => {
             return e.Module == 'CustomSort';
         });
@@ -254,7 +243,6 @@ class LayoutApiImpl extends ApiBase_1.ApiBase {
             customSort.Tags?.push(layoutName);
             this.getCustomSortApi().editCustomSort(customSort);
         });
-        // Flashing Cells
         const flashingCellExtensions = extendedLayoutToClone.Extensions.filter((e) => {
             return e.Module == 'FlashingCell';
         });
@@ -263,14 +251,12 @@ class LayoutApiImpl extends ApiBase_1.ApiBase {
             flashingCellDef.Tags?.push(layoutName);
             this.getFlashingCellApi().editFlashingCellDefinition(flashingCellDef);
         });
-        // FormatColumns
         const formatColumnExtensions = extendedLayoutToClone.Extensions.filter((e) => e.Module == 'FormatColumn');
         formatColumnExtensions.forEach((le) => {
             const formatCol = le.Object;
             formatCol.Tags?.push(layoutName);
             this.getFormatColumnApi().editFormatColumn(formatCol);
         });
-        // Plus Minus
         const plusMinusExtensions = extendedLayoutToClone.Extensions.filter((e) => {
             return e.Module == 'PlusMinus';
         });
@@ -279,7 +265,6 @@ class LayoutApiImpl extends ApiBase_1.ApiBase {
             plusMinusNudge.Tags?.push(layoutName);
             this.getPlusMinusApi().editPlusMinusNudge(plusMinusNudge);
         });
-        // Export
         const exportCloneExtensions = extendedLayoutToClone.Extensions.filter((e) => e.Module === 'Export');
         exportCloneExtensions.forEach((le) => {
             const raw = le.Object;
@@ -289,7 +274,6 @@ class LayoutApiImpl extends ApiBase_1.ApiBase {
             schedule.Tags?.push(layoutName);
             this.getExportApi().editScheduledReport(schedule);
         });
-        // Shortcut
         const shortCutExtensions = extendedLayoutToClone.Extensions.filter((e) => {
             return e.Module == 'Shortcut';
         });
@@ -298,7 +282,6 @@ class LayoutApiImpl extends ApiBase_1.ApiBase {
             shortcut.Tags?.push(layoutName);
             this.getShortcutApi().editShortcut(shortcut);
         });
-        // StyledColumn
         const styledColumnExtensions = extendedLayoutToClone.Extensions.filter((e) => {
             return e.Module == 'StyledColumn';
         });
@@ -307,7 +290,6 @@ class LayoutApiImpl extends ApiBase_1.ApiBase {
             styledColumn.Tags?.push(layoutName);
             this.getStyledColumnApi().editStyledColumn(styledColumn);
         });
-        // now create the new Extended Layout with the same extensions
         const extendedLayout = {
             Layout: clonedLayout,
             Extensions: extendedLayoutToClone.Extensions,

package/src/Api/Implementation/LayoutHelpers.js

@@ -35,12 +35,9 @@ function cleanupAdaptableObjectPrimitives(layout) {
     const l = layout;
     for (const key in l) {
         if (key === 'ColumnFilters') {
-            // we don't want to cleanup ColumnFilters
-            // as we rely on the Uuids for identifying the filters
             if (Array.isArray(l[key])) {
                 l[key].forEach((item) => {
                     if (typeof item === 'object') {
-                        // but we do want to cleanup further down - eg: predicates in the filter
                         for (const k in item) {
                             if (typeof item[k] === 'object') {
                                 (0, AdaptableHelper_1.removeAdaptableObjectPrimitivesInlineDeep)(item[k]);
@@ -56,11 +53,6 @@ function cleanupAdaptableObjectPrimitives(layout) {
         }
     }
 }
-/**
- * Compares 2 Layouts for equality
- * @param layout1 First Layout
- * @param layout2 Second Layout
- */
 const areLayoutsEqual = (layout1, layout2) => {
     if (!layout1 && !layout2) {
         return true;
@@ -93,7 +85,6 @@ const normalizePivotLayout = (pivotLayout) => {
 };
 exports.normalizePivotLayout = normalizePivotLayout;
 const errorOnceMessages = new Map();
-/** Clears module-scoped dedupe state when a new Adaptable instance starts (e.g. Playwright retries). */
 const resetLayoutHelperErrorOnceMessages = () => {
     errorOnceMessages.clear();
 };
@@ -187,7 +178,6 @@ const checkForDuplicateColumns = (layout) => {
             layout.TableColumns.reduce((acc, col) => {
                 acc[col] = (acc[col] || 0) + 1;
                 if (acc[col] > 1) {
-                    // if you change this message, make sure you also update the associated test error-on-duplicate-column.spec.ts
                     errorOnce(`Duplicate column "${col}" in layout "${layout.Name}"!`);
                 }
                 return acc;
@@ -409,9 +399,7 @@ const tableLayoutModelToTableLayout = (layoutModel) => {
     if (layoutModel.Ignore_OpenCharts) {
         tableLayout.OpenCharts = layoutModel.Ignore_OpenCharts;
     }
-    // if (layoutModel.RowGroupDisplayType) {
     tableLayout.RowGroupDisplayType = layoutModel.RowGroupDisplayType ?? 'single';
-    // }
     if (layoutModel.RowGroupedColumns) {
         tableLayout.RowGroupedColumns = layoutModel.RowGroupedColumns;
     }
@@ -437,7 +425,6 @@ const tableLayoutModelToTableLayout = (layoutModel) => {
         if ((layoutModel.ColumnGroupValues.ColumnGroupDisplay === 'collapsed' ||
             layoutModel.ColumnGroupValues.ColumnGroupDisplay === 'expanded') &&
             layoutModel.ColumnGroupValues.Values) {
-            // @ts-ignore
             tableLayout.ColumnGroupValues.ExceptionGroupKeys = layoutModel.ColumnGroupValues.Values;
         }
     }
@@ -574,13 +561,10 @@ const pivotLayoutModelToPivotLayout = (layoutModel) => {
         if ((layoutModel.ColumnGroupValues.ColumnGroupDisplay === 'collapsed' ||
             layoutModel.ColumnGroupValues.ColumnGroupDisplay === 'expanded') &&
             layoutModel.ColumnGroupValues.Values) {
-            // @ts-ignore
             pivotLayout.ColumnGroupValues.ExceptionGroupKeys = layoutModel.ColumnGroupValues.Values;
         }
     }
-    // if (layoutModel.RowGroupDisplayType) {
     pivotLayout.RowGroupDisplayType = layoutModel.RowGroupDisplayType ?? 'single';
-    // }
     if (layoutModel.RowSelection != null) {
         pivotLayout.RowSelection = layoutModel.RowSelection;
     }

package/src/Api/Implementation/NamedQueryApiImpl.js

@@ -32,7 +32,6 @@ class NamedQueryApiImpl extends ApiBase_1.ApiBase {
         if ((0, StringExtensions_1.IsNullOrEmptyOrWhiteSpace)(namedQuery?.Name)) {
             return { valid: false, message: 'A name is required for the Named Query.' };
         }
-        // check that there is no other existing named query with the same name
         const duplicate = this.getNamedQueries().find((q) => q.Name === namedQuery.Name && q.Uuid !== namedQuery.Uuid);
         if (duplicate) {
             return {

package/src/Api/Implementation/PredicateApiImpl.js

@@ -112,7 +112,6 @@ class PredicateApiImpl extends ApiBase_1.ApiBase {
         if (!adaptablePredicateDef) {
             return false;
         }
-        // not perfect but if there are no inputs - and there should be some - we treat the filter as invalid
         if (adaptablePredicateDef.inputs) {
             if (ArrayExtensions_1.default.IsNullOrEmpty(predicate.Inputs) ||
                 StringExtensions_1.default.IsNullOrEmpty(predicate.Inputs[0])) {
@@ -132,7 +131,6 @@ class PredicateApiImpl extends ApiBase_1.ApiBase {
         const paramsForColumn = {
             ...context,
             column: this.getColumnApi().getColumnWithColumnId(predicate.ColumnId),
-            // value: params?.node?.data?.[predicate.ColumnId],
             value: this.getGridApi().getRawValueFromRowNode(context.node, predicate.ColumnId),
         };
         if ('oldValue' in paramsForColumn) {
@@ -147,9 +145,6 @@ class PredicateApiImpl extends ApiBase_1.ApiBase {
         if (!predicate) {
             return defaultReturn;
         }
-        // memoization to avoid repeated lookups
-        // during filtering of large datasets
-        // see #column_filter_predicates_evaluation
         let predicateDef = predicateDefMap_MEMO.get(predicate.PredicateId);
         if (predicateDef === undefined) {
             predicateDef = this.getPredicateDefById(predicate.PredicateId);

package/src/Api/Implementation/RowFormApiImpl.js

@@ -20,7 +20,6 @@ class RowFormApiImpl extends ApiBase_1.ApiBase {
         this.dispatchAction((0, PopupRedux_1.PopupShowForm)({
             Id: 'edit_row_form',
             Form: editForm,
-            // formProps are added to the formContext
             FormProps: {
                 rowNode,
             },
@@ -43,7 +42,6 @@ class RowFormApiImpl extends ApiBase_1.ApiBase {
         this.dispatchAction((0, PopupRedux_1.PopupShowForm)({
             Id: 'create_row_form',
             Form: createForm,
-            // formProps are added to the formContext
             FormProps: {
                 clonedRowNode: rowNode,
             },

package/src/Api/Implementation/StateApiImpl.js

@@ -46,9 +46,7 @@ class StateApiImpl extends ApiBase_1.ApiBase {
         Helper_1.default.copyToClipboard(stringifiedState);
     }
     copyUserStateToClipboard() {
-        // This doesnt currently work...
         let state = this.getAdaptableState();
-        //  let userState = state
         let stringifiedState = JSON.stringify(state);
         Helper_1.default.copyToClipboard(stringifiedState);
     }
@@ -115,8 +113,6 @@ class StateApiImpl extends ApiBase_1.ApiBase {
         return new Promise((resolve, reject) => {
             this.getAdaptableInternalApi().executeWithProgressIndicator(config?.progressIndicatorLabel ?? `Initialising...`, () => {
                 const flushCurrentState = !config || config.flushCurrentState !== false;
-                // make sure we persist any "pending" changes to state - since stateOptions.debounceStateDelay can cause
-                // the state to be persisted with a delay, which we dont want in this case
                 const flushStatePromise = flushCurrentState
                     ? this.getAdaptableStore().saveStateNow(this._adaptable)
                     : Promise.resolve(true);
@@ -145,10 +141,8 @@ class StateApiImpl extends ApiBase_1.ApiBase {
                         this._adaptable.refreshLayout();
                     })
                         .then(() => {
-                        // resolve main(result) promise
                         resolve();
                     }, (error) => {
-                        // reject main(result) promise
                         reject(error);
                     })
                         .catch((e) => {
@@ -251,7 +245,6 @@ class StateApiImpl extends ApiBase_1.ApiBase {
         else {
             state.Revision.Key += 1;
         }
-        // need to save it...
     }
     getAlertState(returnJson = false) {
         return this.getUserStateByStateKey('Alert', returnJson);

package/src/Api/Implementation/SystemStatusApiImpl.js

@@ -22,7 +22,6 @@ class SystemStatusApiImpl extends ApiBase_1.ApiBase {
     setSystemStatus(statusMessage, messageType, statusFurtherInformation) {
         let systemStatusMessageInfo = ObjectFactory_1.default.CreateSystemStatusMessageInfo(statusMessage, messageType, statusFurtherInformation ? statusFurtherInformation : '');
         this.internalApi.addSystemStatusMessageInfo(systemStatusMessageInfo);
-        // publish the event
         this.getEventApi().internalApi.fireSystemStatusMessageDisplayedEvent(systemStatusMessageInfo);
         if (this.getNotificationsOptions().showSystemStatusMessageNotifications) {
             const alertApi = this.getAlertApi();
@@ -48,7 +47,6 @@ class SystemStatusApiImpl extends ApiBase_1.ApiBase {
         if (this.getContainerOptions().systemStatusContainer != null) {
             this.displayMessageInDiv(statusMessage, statusFurtherInformation, messageType);
         }
-        // doesnt do anything but useful for Audit
         this.dispatchAction(SystemStatusRedux.SystemStatusSetMesage(systemStatusMessageInfo));
     }
     displayMessageInDiv(statusMessage, statusFurtherInformation, messageType) {

package/src/Api/Implementation/TeamSharingApiImpl.js

@@ -22,12 +22,9 @@ class TeamSharingApiImpl extends ApiBase_1.ApiBase {
         const teamSharingOptions = this.getTeamSharingOptions();
         const sharedEntitiesContext = this.getAdaptableInternalApi().buildBaseContext();
         let loadedSharedEntities = await teamSharingOptions.loadSharedEntities(sharedEntitiesContext);
-        // with v15 we introduced 2 types of SharedEntity: AdaptableSharedEntity (basically the old one) and the new CustomSharedEntity
-        // for backwards compatibility, we add default the 'EntityType' property to 'adaptableEntity'
         loadedSharedEntities = loadedSharedEntities.map((sharedEntity) => {
             if (sharedEntity.EntityType !== 'adaptableEntity' &&
                 sharedEntity.EntityType !== 'customEntity') {
-                // @ts-ignore
                 sharedEntity.EntityType = 'adaptableEntity';
             }
             return sharedEntity;

package/src/Api/Implementation/UserInterfaceApiImpl.js

@@ -34,7 +34,6 @@ class UserInterfaceApiImpl extends ApiBase_1.ApiBase {
     getCustomIcons() {
         let customIconsProp = this.getUserInterfaceOptions().customIcons;
         if (customIconsProp != null) {
-            // first do the function then get hardcoded items
             return typeof customIconsProp === 'function'
                 ? customIconsProp()
                 : customIconsProp;

package/src/Api/Internal/ActionColumnInternalApi.js

@@ -50,7 +50,6 @@ class ActionColumnInternalApi extends ApiBase_1.ApiBase {
     }
     getActionColumnsAndButtons(colDef) {
         let actionColumn;
-        // this should probably be in FDC3 api...
         if (!actionColumn && this.getFdc3Api().internalApi.isFdc3MainActionColumn(colDef.colId)) {
             const actionButtons = this.getFdc3Api().internalApi.getButtonsForFdc3MainActionColumn();
             const actionColumnDefaultConfiguration = this.getFdc3Options().actionColumnDefaultConfiguration;

package/src/Api/Internal/AdaptableInternalApi.d.ts

@@ -19,7 +19,6 @@ import { ITeamSharingService } from '../../Utilities/Services/Interface/ITeamSha
 import { ButtonStyle } from '../../AdaptableState/Common/ButtonStyle';
 import { AdaptableButton } from '../../AdaptableState/Common/AdaptableButton';
 import { AdaptableFrameworkComponent } from '../../agGrid/AdaptableFrameworkComponent';
-import { IMetamodelService } from '../../Utilities/Services/Interface/IMetamodelService';
 import { IModuleCollection } from '../../Strategy/Interface/IModule';
 import { AdaptableObjectTag, AdaptableObjectWithScope } from '../../AdaptableState/Common/AdaptableObject';
 import { AdaptableForm, CellSummmaryInfo, FormContext, RowDataChangeTrigger, RowDataChangedInfo, AdaptableColumn, AdaptableColumnContext } from '../../../types';
@@ -73,7 +72,6 @@ export declare class AdaptableInternalApi extends ApiBase {
     getQueryLanguageService(): IQueryLanguageService;
     getAlertService(): IAlertService;
     getTeamSharingService(): ITeamSharingService;
-    getMetamodelService(): IMetamodelService;
     getRowFormService(): RowFormService;
     getFdc3Service(): Fdc3Service;
     getFlashingCellService(): FlashingCellService;

package/src/Api/Internal/AdaptableInternalApi.js

@@ -17,7 +17,6 @@ class AdaptableInternalApi extends ApiBase_1.ApiBase {
     getAdaptableJSXElement() {
         return this._adaptable._PRIVATE_adaptableJSXElement ?? null;
     }
-    // Popup Redux Actions
     showPopupConfirmation(confirmation) {
         this.dispatchAction(PopupRedux.PopupShowConfirmation(confirmation));
     }
@@ -110,9 +109,6 @@ class AdaptableInternalApi extends ApiBase_1.ApiBase {
     getTeamSharingService() {
         return this._adaptable.TeamSharingService;
     }
-    getMetamodelService() {
-        return this._adaptable.MetamodelService;
-    }
     getRowFormService() {
         return this._adaptable.RowFormService;
     }
@@ -192,21 +188,18 @@ class AdaptableInternalApi extends ApiBase_1.ApiBase {
     isDocumentationLinksDisplayed() {
         return this.getUserInterfaceOptions().showDocumentationLinks;
     }
-    // the row data which is used to preview the expression evaluation (usually the first row data)
     getQueryPreviewData() {
         const firstRowNode = this.getGridApi().getFirstRowNode();
         if (firstRowNode == undefined) {
             return {};
         }
         const firstRowData = firstRowNode?.data ? { ...firstRowNode?.data } : {};
-        // handle CalcCols which are not persisted in the rowModel
         this.getCalculatedColumnApi()
             .getCalculatedColumns()
             .forEach((calculatedColumn) => {
             const columnRawValue = this._adaptable.api.gridApi.getRawValueFromRowNode(firstRowNode, calculatedColumn.ColumnId);
             firstRowData[calculatedColumn.ColumnId] = columnRawValue;
         });
-        // handle FreeTextCols which are not persisted in the rowModel
         this.getFreeTextColumnApi()
             .getFreeTextColumns()
             .forEach((freeTextColumn) => {
@@ -216,9 +209,7 @@ class AdaptableInternalApi extends ApiBase_1.ApiBase {
         return firstRowData;
     }
     createFrameworkComponent(containerDomNode, frameworkComponent, componentType) {
-        const createComponentFn = () => 
-        // delegate the logic to framework wrapper
-        this._adaptable._emitSync('FrameworkComponentChange', {
+        const createComponentFn = () => this._adaptable._emitSync('FrameworkComponentChange', {
             command: 'create',
             containerDomNode,
             frameworkComponent,
@@ -228,8 +219,6 @@ class AdaptableInternalApi extends ApiBase_1.ApiBase {
             createComponentFn();
         }
         else {
-            // adaptable may not be initialized yet if the framework component is part of the initial render
-            // AFL 2021.10.14 - not really sure if this is necessary anymore?! (see the other changes in this commit)
             (0, waitForCondition_1.waitForCondition)(() => this.isAdapTableReady()).then(() => {
                 createComponentFn();
             });
@@ -253,7 +242,6 @@ class AdaptableInternalApi extends ApiBase_1.ApiBase {
     }
     executeWithProgressIndicator(label, executeFn, errorHandlingFn) {
         this.getUserInterfaceApi().showProgressIndicator({ text: label, delay: 300 });
-        // setTimeout required to give the ProgressIndicator rendering a head-start (see RAF in ProgressIndicator implementation)
         setTimeout(() => {
             try {
                 executeFn();
@@ -293,7 +281,6 @@ class AdaptableInternalApi extends ApiBase_1.ApiBase {
             return userInterfaceOptions.objectTags;
         }
         if (typeof userInterfaceOptions.objectTags === 'function') {
-            // sanitize the provided tags, just to be sure that the user does NOT break the UI
             return userInterfaceOptions
                 .objectTags(this.buildBaseContext())
                 .filter((tag) => typeof tag === 'string');
@@ -318,24 +305,19 @@ class AdaptableInternalApi extends ApiBase_1.ApiBase {
                 ...this.buildBaseContext(),
             };
             const customGeneratedTags = layoutOptions.layoutTagOptions.autoGenerateTagsForLayouts(autoGenerateTagsForLayoutsContext);
-            // sanitize the provided tags, just to be sure that the user does NOT break the UI
             return customGeneratedTags.filter((tag) => typeof tag === 'string');
         }
     }
-    // General way to get to store from inside Adaptable...
     dispatchReduxAction(action) {
         this.dispatchAction(action);
     }
-    // doing it this way to avoid having to expose Module Params which is internal
     showSettingsPanel(module, moduleParams) {
         this.showModulePopup(module, moduleParams);
     }
     getLabelForTag(adaptableObjectTag) {
-        // not very interesting right now, but useful later when tag is not only a plain string
         return adaptableObjectTag;
     }
     getValueForTag(adaptableObjectTag) {
-        // not very interesting right now, but useful later when tag is not only a plain string
         return adaptableObjectTag;
     }
     getAdaptableQueryExpressionText(query) {
@@ -347,21 +329,14 @@ class AdaptableInternalApi extends ApiBase_1.ApiBase {
             ? this.getExpressionApi().getAdaptableQueryExpressionWithColumnFriendlyNames(query)
             : this.getExpressionApi().getAdaptableQueryExpression(query);
     }
-    /**
-     * Gets a value from a rowData object using a field name.
-     * Supports deep values (e.g. fieldName = 'address.street')
-     */
-    // "borrowed" from https://github.com/ag-grid/ag-grid/blob/v28.2.1/community-modules/core/src/ts/utils/object.ts#L205
     getValueUsingField(rowData, fieldName) {
         if (!rowData || !fieldName?.length) {
             return;
         }
         const isColumnValueKeyNested = fieldName?.includes('.');
-        // if no '.', then it's not a deep value
         if (!isColumnValueKeyNested) {
             return rowData[fieldName];
         }
-        // otherwise it is a deep value, so need to dig for it
         const fields = fieldName.split('.');
         let currentObject = rowData;
         for (let i = 0; i < fields.length; i++) {
@@ -372,11 +347,6 @@ class AdaptableInternalApi extends ApiBase_1.ApiBase {
         }
         return currentObject;
     }
-    /**
-     * Sets a value in a rowData object using a field name.
-     * Supports deep values (e.g. fieldName = 'address.street')
-     */
-    // "borrowed" from https://github.com/ag-grid/ag-grid/blob/v28.2.1/community-modules/core/src/ts/valueService/valueService.ts#L236
     setValueUsingField(rowData, fieldName, newValue) {
         if (!rowData || !fieldName?.length) {
             return;
@@ -384,27 +354,23 @@ class AdaptableInternalApi extends ApiBase_1.ApiBase {
         const isColumnValueKeyContainsDots = fieldName?.includes('.');
         let valuesAreSame = false;
         if (!isColumnValueKeyContainsDots) {
-            // soft comparison to match strings and numbers
             valuesAreSame = rowData[fieldName] == newValue;
             if (!valuesAreSame) {
                 rowData[fieldName] = newValue;
             }
         }
         else {
-            // otherwise it is a deep value, so need to dig for it
             const fieldPieces = fieldName.split('.');
             let currentObject = rowData;
             while (fieldPieces.length > 0 && currentObject) {
                 const fieldPiece = fieldPieces.shift();
                 if (fieldPieces.length === 0) {
-                    // soft comparison to match strings and numbers
                     valuesAreSame = currentObject[fieldPiece] == newValue;
                     if (!valuesAreSame) {
                         currentObject[fieldPiece] = newValue;
                     }
                 }
                 else {
-                    // NOTE AFL: this was NOT in the original AG Grid code, but we need it to handle inserting deep values (the original implementation only handled updating)
                     if (currentObject[fieldPiece] == null) {
                         currentObject[fieldPiece] = {};
                     }
@@ -419,15 +385,12 @@ class AdaptableInternalApi extends ApiBase_1.ApiBase {
             return [];
         }
         let locatedAdaptableObjects = [...specificAdaptableObjects];
-        // IDs are the most specific locators
         if (ids?.length) {
             locatedAdaptableObjects = locatedAdaptableObjects.filter((adaptableObject) => ids.includes(adaptableObject.Uuid));
         }
-        // secondly filter by Tags
         if (tag) {
             locatedAdaptableObjects = locatedAdaptableObjects.filter((adaptableObject) => adaptableObject.Tags?.includes(tag));
         }
-        // lastly filter by scope
         if (scope) {
             locatedAdaptableObjects = locatedAdaptableObjects.filter((adaptableObject) => this.getColumnScopeApi().isScopeInScope(adaptableObject.Scope, scope));
         }
@@ -456,7 +419,6 @@ class AdaptableInternalApi extends ApiBase_1.ApiBase {
     parseDateValue(dateValue) {
         const dateFormat = this.getUserInterfaceOptions().dateInputOptions.dateFormat;
         if (dateFormat === 'yyyy-MM-dd') {
-            // if the format is ISO, we don't pass it so that we use the date-fns `parseISO` which is more robust
             return (0, DateHelper_1.parseDateValue)(dateValue);
         }
         return (0, DateHelper_1.parseDateValue)(dateValue, dateFormat);