@adaptabletools/adaptable-cjs 23.0.4 → 23.0.5-canary.1

package/src/Utilities/Services/ThemeService.js

@@ -10,7 +10,6 @@ class ThemeService {
         this.subscribe();
         if (!this.styleSheetObject) {
             this.styleSheetObject = new CSSStyleSheet();
-            // ts does not know about adoptedStyleSheets
             document.adoptedStyleSheets = [
                 ...(document.adoptedStyleSheets ?? []),
                 this.styleSheetObject,
@@ -34,8 +33,6 @@ class ThemeService {
         let currentTheme = this.api.themeApi.getCurrentThemeObject();
         currentTheme = this.mapOsTheme(currentTheme);
         this.applyNewThemeVariables(currentTheme);
-        // this needs to be called after variables are set
-        // as it may show the warning for a custom/runtime theme
         this.showMissingThemeFiles(currentTheme);
     };
     applyNewThemeVariables(theme) {
@@ -55,8 +52,6 @@ class ThemeService {
         this.styleSheetObject.replaceSync(str);
     }
     showMissingThemeFiles(theme) {
-        // run time defined theme
-        // because it may be an empty theme
         if (theme.Source === 'User') {
             return;
         }
@@ -80,7 +75,6 @@ class ThemeService {
             logger.consoleWarn(`Theme "${themeName}" does not appear to be loaded. Ensure the CSS file is imported, e.g.: import "@adaptabletools/adaptable/themes/${themeName}.css".`);
         }
     }
-    // prefers-color-scheme
     getDOMPrefferedColorScheme() {
         return window.matchMedia('(prefers-color-scheme: dark)').matches ? 'dark' : 'light';
     }
@@ -94,7 +88,6 @@ class ThemeService {
     }
     attachPrefferedColorSchemeListener() {
         const handlePrefferedColorSchemeChange = () => {
-            // we need to reapply the theme
             const currentTheme = this.api.themeApi.getCurrentThemeObject();
             if (currentTheme.Name === 'os') {
                 this.api.themeApi.applyCurrentTheme();

package/src/Utilities/Services/ValidationService.js

@@ -13,9 +13,7 @@ class ValidationService {
         this.adaptableApi = adaptableApi;
         this.adaptableApi = adaptableApi;
     }
-    // Not sure where to put this: was in the Module but might be better here until I can work out a way of having an event with a callback...
     getValidationRulesForDataChange(cellDataChangedInfo) {
-        // if the new value is the same as the old value then we can get out as we dont see it as an edit?
         if (cellDataChangedInfo.oldValue == cellDataChangedInfo.newValue) {
             return [];
         }
@@ -64,21 +62,6 @@ class ValidationService {
                 cellDataChangedInfo: cellDataChangedInfo,
             };
             this.adaptableApi.eventApi.internalApi.fireAlertFiredEvent(alert);
-            // This is not needed because the change event is triggered regardless
-            // if the edit is succesful. This is because (I think) Adaptable uses a non-standard way ot detecting data changes.
-            // https://github.com/AdaptableTools/adaptable/issues/2197
-            // failedRules.forEach((alertDefinition) => {
-            //   const alert: AdaptableAlert = ObjectFactory.CreateCellChangedAlert(
-            //     cellDataChangedInfo.column.friendlyName,
-            //     this.adaptableApi.alertApi.internalApi.getAlertDescription(
-            //       alertDefinition,
-            //       cellDataChangedInfo
-            //     ),
-            //     alertDefinition,
-            //     cellDataChangedInfo
-            //   );
-            //   this.adaptableApi.alertApi.showAdaptableAlert(alert);
-            // });
             return false;
         }
         return true;
@@ -112,11 +95,8 @@ class ValidationService {
                 if (validationResult.newCellValue === undefined) {
                     validationResult.newCellValue = cellDataChangedInfo.newValue;
                 }
-                // If they have changed the return value then we should update the grid, log the function change
-                // otherwise the value will persist
                 if (validationResult.newCellValue !== cellDataChangedInfo.newValue) {
                     cellDataChangedInfo.newValue = validationResult.newCellValue;
-                    // this.adaptable.setValue(cellDataChangedInfo, false);
                     const row = cellDataChangedInfo.rowNode?.data;
                     if (!row) {
                         return;
@@ -155,7 +135,6 @@ class ValidationService {
         return returnMessage;
     }
     destroy() {
-        // TO DO
     }
 }
 exports.ValidationService = ValidationService;

package/src/Utilities/createAgStatusPanelComponent.js

@@ -15,9 +15,6 @@ const createAgStatusPanelComponent = (component, adaptable, context) => {
             }), adaptable);
             return ((0, jsx_runtime_1.jsx)("div", { className: "ab-StatusBar", ref: (node) => {
                     if (node) {
-                        // in React rendering, AG Grid renders an additional extra div
-                        // around the status panel container, with className of 'ag-react-container'
-                        // which needs to be stretched in order to fill the status panel
                         node.parentElement.style.display = 'flex';
                     }
                 }, children: children }));

package/src/Utilities/getExpressionViewItems.js

@@ -5,10 +5,8 @@ const jsx_runtime_1 = require("react/jsx-runtime");
 const ExpressionPreview_1 = require("../components/ExpressionEditor/ExpressionPreview");
 const Tag_1 = require("../components/Tag");
 const getExpressionViewItems = (query, api) => {
-    // const expressionText = api.internalApi.getAdaptableQueryExpressionText(query);
     return {
         name: 'Expression',
-        // values: [],
         view: ((0, jsx_runtime_1.jsx)(Tag_1.Tag, { children: (0, jsx_runtime_1.jsx)(ExpressionPreview_1.ExpressionPreview, { query: query }) })),
     };
 };

package/src/Utilities/getObjectTagsViewItems.js

@@ -21,7 +21,6 @@ const getObjectTagsViewItems = (object, api) => {
             const handleToggleTag = react_1.default.useCallback(() => {
                 let tags = props.data.Tags ?? [];
                 if (hasCurrentLayoutAsTag) {
-                    // remove layout
                     tags = tags.filter((tag) => tag !== currentLayoutName);
                 }
                 else {

package/src/Utilities/getScrollbarSize.js

@@ -17,7 +17,6 @@ exports.default = () => {
         elStyle.height = '200px';
         elStyle.top = '-99999px';
         elStyle.overflow = 'scroll';
-        //@ts-ignore
         elStyle.MsOverflowStyle = 'scrollbar';
         document.body.appendChild(div);
         result = div.offsetWidth - div.clientWidth;

package/src/Utilities/logDeprecation.js

@@ -2,9 +2,6 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.logDeprecationInternal = exports.logDeprecationExternal = exports.logDeprecation = void 0;
 const doOnceFlags = {};
-/**
- * If the key was passed before, then do NOT execute the func
- */
 const doOnce = (func, key) => {
     if (doOnceFlags[key]) {
         return;

package/src/Utilities/resolveContainerElement.js

@@ -1,37 +1,17 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.resolveContainerElement = resolveContainerElement;
-/**
- * Resolves a container option value to an `HTMLElement`.
- *
- * Resolution order:
- * 1. If `container` is `null`/`undefined`, returns `null`.
- * 2. If `container` is a function, it is called with the provided `context` and the result is resolved.
- * 3. If the value is an `HTMLElement`, it is returned directly.
- * 4. If the value is an `AdaptableCSSSelector` (`{ selector: string }`), `document.querySelectorAll` is used.
- *    If multiple elements match, the first is returned and a console warning is logged.
- * 5. If the value is a `string`, it is treated as an element ID and `document.getElementById` is used.
- *
- * @param container - The container reference to resolve.
- * @param context - Optional context passed to the function form of the container.
- * @param doc - The document to query against (defaults to `globalThis.document`).
- * @returns The resolved `HTMLElement`, or `null` if not found.
- */
 function resolveContainerElement(container, context, doc = globalThis.document) {
     if (container == null) {
         return null;
     }
-    // Unwrap function form — pass context if the container is a function
     const value = typeof container === 'function' ? container(context) : container;
-    // Guard against null/undefined returned by a callback (e.g. document.getElementById(...))
     if (value == null) {
         return null;
     }
-    // Direct HTMLElement reference
     if (value instanceof HTMLElement) {
         return value;
     }
-    // CSS Selector object
     if (typeof value === 'object' && 'selector' in value) {
         const matches = doc.querySelectorAll(value.selector);
         if (matches.length > 1) {
@@ -39,7 +19,6 @@ function resolveContainerElement(container, context, doc = globalThis.document)
         }
         return matches[0] ?? null;
     }
-    // String element ID
     if (typeof value === 'string') {
         return doc.getElementById(value);
     }

package/src/Utilities/runIfNotResolvedIn.js

@@ -1,13 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.runIfNotResolvedIn = void 0;
-/**
- * Calls the callback if the promise does not resolve in a amount of time.
- *
- * @param promise
- * @param callback Called if promise does not resolve in the time defined by 'delay'
- * @param delay Time after which if the promise was not resolved the callback (fn) is called.
- */
 const runIfNotResolvedIn = async (promise, callback, delay = 100) => {
     let isFulfilled = false;
     promise?.then(() => {

package/src/Utilities/sortColumnStateForVisibleColumns.js

@@ -8,26 +8,18 @@ function insertAtCorrectIndex(result, colState, visibleColumnsIndexes, offset =
         return;
     }
     if (prevColState.hide) {
-        insertAtCorrectIndex(result, colState, visibleColumnsIndexes, offset + 1, 
-        /* do not advance this as, as we've encountered a hidden column*/ lastVisibleOffset);
+        insertAtCorrectIndex(result, colState, visibleColumnsIndexes, offset + 1, lastVisibleOffset);
         return;
     }
     const prevCol_visibilityIndex = visibleColumnsIndexes[prevColState.colId];
     const currentCol_visibilityIndex = visibleColumnsIndexes[colState.colId];
     if (currentCol_visibilityIndex < prevCol_visibilityIndex) {
-        insertAtCorrectIndex(result, colState, visibleColumnsIndexes, offset + 1, 
-        /*make sure we sync with the normal offset, as we've hit a visible col*/ offset + 1);
+        insertAtCorrectIndex(result, colState, visibleColumnsIndexes, offset + 1, offset + 1);
     }
     else {
         result.splice(result.length - lastVisibleOffset, 0, colState);
     }
 }
-/**
- * This method takes a column state and the list of visible columns
- * and returns a new column state that respects the order of the visible columns
- * while trying to keep the hidden columns in their original order.
- *
- */
 function sortColumnStateForVisibleColumns(columnState, visibleColumns) {
     const visibleColumnsIndexes = visibleColumns.reduce((acc, colId, index) => {
         acc[colId] = index;
@@ -38,8 +30,6 @@ function sortColumnStateForVisibleColumns(columnState, visibleColumns) {
         const colState = columnState[i];
         const colVisible = visibleColumnsIndexes[colState.colId] != null;
         if (!colVisible) {
-            // for cols not present in this layout, we keep them
-            // where they are
             result.push(colState);
             continue;
         }

package/src/Utilities/waitForTimeout.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.waitForTimeout = waitForTimeout;
-// waits for the given ms milliseconds
 function waitForTimeout(ms) {
     return new Promise((resolve) => {
         setTimeout(() => {

package/src/Utilities/wizardSelection.js

@@ -2,9 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.wizardSelectionSimpleButtonProps = exports.wizardSelectionButtonClassName = exports.getCollapsibleWizardCardExpandedClasses = exports.getCollapsibleWizardCardCollapsedClasses = exports.WIZARD_SELECTION_INACTIVE_CLASSES = exports.WIZARD_SELECTION_ACTIVE_CLASSES = void 0;
 const utils_1 = require("../lib/utils");
-/** Selected wizard option — Tailwind overrides SimpleButton outlined defaults. */
 exports.WIZARD_SELECTION_ACTIVE_CLASSES = (0, utils_1.cn)('ab-WizardSelection--active', 'twa:!border-[var(--ab-cmp-wizard-selection__border)]', 'twa:!bg-[var(--ab-cmp-wizard-selection__background)]', 'twa:!text-accent', 'twa:font-medium');
-/** Unselected wizard option — muted so the active choice reads immediately. */
 exports.WIZARD_SELECTION_INACTIVE_CLASSES = (0, utils_1.cn)('twa:!border-[color-mix(in_srgb,var(--ab-color-primarydark)_40%,transparent)]', 'twa:!text-[color-mix(in_srgb,var(--ab-color-foreground)_55%,transparent)]');
 const getCollapsibleWizardCardCollapsedClasses = (surface = 'popup') => (0, utils_1.cn)(surface === 'panel'
     ? 'twa:border-[var(--ab-cmp-collapsible-wizard-card__collapsed-border)] twa:bg-card'

package/src/View/AdaptablePopover/index.js

@@ -19,7 +19,7 @@ class AdaptablePopover extends React.Component {
         const title = StringExtensions_1.StringExtensions.IsNotNullOrEmpty(this.props.headerText)
             ? this.props.headerText
             : '';
-        const icon = 'info'; // - think this is wrong - UIHelper.getGlyphByMessageType(messageType);
+        const icon = 'info';
         const color = UIHelper_1.UIHelper.getColorByMessageType(messageType);
         const iconStyle = {
             color,

package/src/View/AdaptableView.js

@@ -24,11 +24,7 @@ class AdaptableView extends React.Component {
         const adaptableOptions = this.props.AdaptableApi.optionsApi.getAdaptableOptions();
         return ((0, jsx_runtime_1.jsxs)("div", { children: [(0, jsx_runtime_1.jsx)(GridCellPopup_1.GridCellPopup, {}), (0, jsx_runtime_1.jsx)(FloatingQuickSearch_1.QuickSearchDrawer, {}), this.props.AdaptableApi.internalApi
                     .getModuleService()
-                    .isAdapTableModulePresent('Dashboard') && (0, jsx_runtime_1.jsx)(Dashboard_1.Dashboard, { api: this.props.AdaptableApi }), this.props.PopupState.PromptPopup.ShowPromptPopup && ((0, jsx_runtime_1.jsx)(AdaptablePopupPrompt_1.AdaptablePopupPrompt, { message: this.props.PopupState.PromptPopup.Message, header: this.props.PopupState.PromptPopup.Header, onClose: this.props.onClosePromptPopup, onConfirm: this.props.onConfirmPromptPopup, onConfirmActionCreator: this.props.PopupState.PromptPopup.ConfirmActionCreator, defaultValue: this.props.PopupState.PromptPopup.DefaultValue })), Boolean(this.props.PopupState.ConfirmationPopup.ShowConfirmationPopup) && ((0, jsx_runtime_1.jsx)(AdaptablePopupConfirmation_1.AdaptablePopupConfirmation, { header: this.props.PopupState.ConfirmationPopup.Header, messsage: this.props.PopupState.ConfirmationPopup.Msg, showPopup: this.props.PopupState.ConfirmationPopup.ShowConfirmationPopup, cancelButtonText: this.props.PopupState.ConfirmationPopup.CancelButtonText, confirmButtonText: this.props.PopupState.ConfirmationPopup.ConfirmButtonText, onCancel: this.props.onCancelConfirmationPopup, onConfirm: this.props.onConfirmConfirmationPopup, showInputBox: this.props.PopupState.ConfirmationPopup.ShowInputBox, messageType: this.props.PopupState.ConfirmationPopup.MessageType, api: this.props.AdaptableApi })), Boolean(this.props.PopupState.ScreenPopup.ShowScreenPopup) && ((0, jsx_runtime_1.jsx)(AdaptablePopup_1.AdaptablePopup, { componentName: this.props.PopupState.ScreenPopup.ComponentName, componentModule: this.props.PopupState.ScreenPopup.ComponentModule, onHide: this.props.onCloseScreenPopup, api: this.props.AdaptableApi, onClearParams: () => this.props.onClearPopupParams(), moduleParams: this.props.PopupState.ScreenPopup.Params, moduleProps: this.props.PopupState.ScreenPopup.PopupProps })), (0, jsx_runtime_1.jsx)(Toastify_1.ToastContainer
-                // Ensure to set containerId to avoid memory leaks when Adaptable instance is destroyed and re-created many times
-                , { 
-                    // Ensure to set containerId to avoid memory leaks when Adaptable instance is destroyed and re-created many times
-                    containerId: `Toastify-${adaptableOptions.adaptableId}`, limit: adaptableOptions.notificationsOptions.maxNotifications, closeButton: false, icon: false, theme: "colored" }), watermark?.show && (0, jsx_runtime_1.jsx)(License_1.LicenseWatermark, { children: watermark?.text }), (0, jsx_runtime_1.jsx)(WindowPopups_1.WindowPopups, {}), (0, jsx_runtime_1.jsx)(FormPopups_1.FormPopups, {}), (0, jsx_runtime_1.jsx)(ProgressIndicator_1.ProgressIndicator, {})] }));
+                    .isAdapTableModulePresent('Dashboard') && (0, jsx_runtime_1.jsx)(Dashboard_1.Dashboard, { api: this.props.AdaptableApi }), this.props.PopupState.PromptPopup.ShowPromptPopup && ((0, jsx_runtime_1.jsx)(AdaptablePopupPrompt_1.AdaptablePopupPrompt, { message: this.props.PopupState.PromptPopup.Message, header: this.props.PopupState.PromptPopup.Header, onClose: this.props.onClosePromptPopup, onConfirm: this.props.onConfirmPromptPopup, onConfirmActionCreator: this.props.PopupState.PromptPopup.ConfirmActionCreator, defaultValue: this.props.PopupState.PromptPopup.DefaultValue })), Boolean(this.props.PopupState.ConfirmationPopup.ShowConfirmationPopup) && ((0, jsx_runtime_1.jsx)(AdaptablePopupConfirmation_1.AdaptablePopupConfirmation, { header: this.props.PopupState.ConfirmationPopup.Header, messsage: this.props.PopupState.ConfirmationPopup.Msg, showPopup: this.props.PopupState.ConfirmationPopup.ShowConfirmationPopup, cancelButtonText: this.props.PopupState.ConfirmationPopup.CancelButtonText, confirmButtonText: this.props.PopupState.ConfirmationPopup.ConfirmButtonText, onCancel: this.props.onCancelConfirmationPopup, onConfirm: this.props.onConfirmConfirmationPopup, showInputBox: this.props.PopupState.ConfirmationPopup.ShowInputBox, messageType: this.props.PopupState.ConfirmationPopup.MessageType, api: this.props.AdaptableApi })), Boolean(this.props.PopupState.ScreenPopup.ShowScreenPopup) && ((0, jsx_runtime_1.jsx)(AdaptablePopup_1.AdaptablePopup, { componentName: this.props.PopupState.ScreenPopup.ComponentName, componentModule: this.props.PopupState.ScreenPopup.ComponentModule, onHide: this.props.onCloseScreenPopup, api: this.props.AdaptableApi, onClearParams: () => this.props.onClearPopupParams(), moduleParams: this.props.PopupState.ScreenPopup.Params, moduleProps: this.props.PopupState.ScreenPopup.PopupProps })), (0, jsx_runtime_1.jsx)(Toastify_1.ToastContainer, { containerId: `Toastify-${adaptableOptions.adaptableId}`, limit: adaptableOptions.notificationsOptions.maxNotifications, closeButton: false, icon: false, theme: "colored" }), watermark?.show && (0, jsx_runtime_1.jsx)(License_1.LicenseWatermark, { children: watermark?.text }), (0, jsx_runtime_1.jsx)(WindowPopups_1.WindowPopups, {}), (0, jsx_runtime_1.jsx)(FormPopups_1.FormPopups, {}), (0, jsx_runtime_1.jsx)(ProgressIndicator_1.ProgressIndicator, {})] }));
     }
 }
 function mapStateToProps(state, ownProps) {

package/src/View/AdaptableWizardView/AdaptableConfigurationDialog/ColumnsList.js

@@ -335,10 +335,6 @@ const ColumnsList = ({ columns: cols, handle, onValidityChange, onChange, onSele
                 }, domProps: tableDOMProps, columns: columnsMap }) }) }));
 };
 function areEqual() {
-    /**
-     * Make the ColumnList not render on subsequent prop changes
-     * in order to boost performance
-     */
     return true;
 }
 exports.default = React.memo(ColumnsList, areEqual);

package/src/View/AdaptableWizardView/AdaptableConfigurationDialog/ConfigurationWizard.js

@@ -11,7 +11,6 @@ const ConfigurationWizardColumnsStep_1 = require("./ConfigurationWizardColumnsSt
 const GridOptionsForm_1 = tslib_1.__importDefault(require("./GridOptionsForm"));
 const EntitlementsForm_1 = tslib_1.__importDefault(require("./EntitlementsForm"));
 const UiOptionsForm_1 = require("./UIOptions/UiOptionsForm");
-const AdaptableOptionsForm_1 = require("./AdaptableOptionsForm");
 const DefaultAdaptableOptions_1 = require("../../../AdaptableOptions/DefaultAdaptableOptions");
 const ConfigurationWizard = (props) => {
     const [isPrimaryKeySelected, setIsValid] = React.useState(true);
@@ -48,7 +47,6 @@ const ConfigurationWizard = (props) => {
                 return newColumn;
             });
             const columnDefs = adaptableConfig.gridOptions.columnDefs;
-            // handle the layout creation
             let Layouts = newAdaptableOptions.initialState?.Layout?.Layouts || [];
             const NewLayout = {
                 TableColumns: columnDefs.map((col) => col.colId ?? col.field),
@@ -57,7 +55,6 @@ const ConfigurationWizard = (props) => {
             let currentLayoutName = NewLayout.Name;
             let found = false;
             if (!Layouts.length) {
-                // no layouts, make this the only one
                 Layouts = [NewLayout];
             }
             else {
@@ -66,10 +63,7 @@ const ConfigurationWizard = (props) => {
                         return layout;
                     }
                     if (layout.TableColumns?.length === 0) {
-                        // when finding the first empty layout
-                        // set its column to be those of the new layout
                         found = true;
-                        // and grab the name so we can put it in the Layout.CurrentLayout state
                         currentLayoutName = layout.Name;
                         layout = { ...layout };
                         layout.TableColumns = NewLayout.TableColumns;
@@ -137,12 +131,6 @@ const ConfigurationWizard = (props) => {
             },
             render: () => ((0, jsx_runtime_1.jsx)(ConfigurationWizardColumnsStep_1.ConfigurationWizardColumnsStep, { adaptableConfig: adaptableConfig, setPrimaryKeyIsNotSelected: handlePrimaryKeyColumnIsNotSelected, onChange: setAdaptableConfig, selectedColumns: selectedColumns, onSelectionChange: handleColumnSelectionChange, onColumnChange: handleColumnsChange, columnsHandle: columnsHandle })),
         },
-        {
-            title: 'AdapTable Options',
-            details: 'Configure Adaptable Options',
-            isValid: () => adaptableConfig.adaptableOptions.adaptableId ? true : 'Adaptable ID is required',
-            render: () => ((0, jsx_runtime_1.jsx)(AdaptableOptionsForm_1.AdaptableOptionsForm, { adaptableOptions: adaptableConfig.adaptableOptions, onChangedAdaptableOptions: handleAdaptableOptionsChange })),
-        },
         {
             title: 'AG Grid Options',
             details: 'Configure AG Grid Options',
@@ -158,17 +146,6 @@ const ConfigurationWizard = (props) => {
             details: 'Configure Entitlements',
             render: () => ((0, jsx_runtime_1.jsx)(EntitlementsForm_1.default, { adaptableOptions: adaptableConfig.adaptableOptions, onChangedAptableOptions: handleAdaptableOptionsChange })),
         },
-        /**
-        financePlugin && {
-          title: 'Finance',
-          details: 'Finance Options',
-          render: () => (
-            <FinanceForm
-              adaptableConfig={adaptableConfig}
-              onChangedAdaptableConfig={setAdaptableConfig}
-            />
-          ),
-        },  */
     ].filter(Boolean);
     if (props.startSections) {
         sections = [

package/src/View/AdaptableWizardView/AdaptableConfigurationDialog/EntitlementsForm.js

@@ -43,7 +43,6 @@ const EntitlementsListForm = (props) => {
     }, [abOptions?.entitlementOptions]);
     const handleOnChange = React.useCallback((module, accessLevel) => {
         let newEntitlements = entitlements;
-        // change
         if (entitlementsMap[module]) {
             newEntitlements = newEntitlements.map((entitlement) => {
                 if (entitlement.adaptableModule === module) {
@@ -53,7 +52,6 @@ const EntitlementsListForm = (props) => {
             });
         }
         else {
-            // new
             newEntitlements = [
                 ...newEntitlements,
                 { adaptableModule: module, accessLevel: accessLevel },

package/src/View/AdaptableWizardView/Wizard.js

@@ -39,16 +39,6 @@ const reducer = (state, action) => {
     return state;
 };
 exports.reducer = reducer;
-/**
- * The wizard in a few modes:
- *
- * 1. Based on data:
- * 1.1 Drag and drop a file
- * 1.2 Fetch data from a url
- *
- * 2. Based on configuration:
- * Provide a schema, on how the data looks like.
- */
 const Wizard = (props) => {
     const [state, dispatch] = (0, react_1.useReducer)(exports.reducer, {
         ...exports.initialState,
@@ -91,8 +81,6 @@ const Wizard = (props) => {
                 adaptableOptions: state.adaptableOptions,
                 gridOptions: state.gridOptions,
             }, onCancel: () => {
-                // change the file droppable component key
-                // so it's remounted and it's in the initial state
                 setDroppableKey(Date.now());
                 dispatch({
                     type: 'CANCEL',

package/src/View/AdaptableWizardView/helper.js

@@ -1,16 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.prepareGridOptions = exports.getColTypeFromValue = exports.prepareDataSource = void 0;
-/**
- * There are two ways in which the datasource can be dropped in the wizard:
- *
- * 1. array of objects - eg: [{"lastName":"John","firstName":"Bobson"},{"lastName":"Mike","firstName":"Richardson"},...]
- * 2. array of arrays - eg: [["lastName","firstName"],["John","Bobson"],["Mike","Richardson"],...]
- *
- * Although the second one is more compact, the first one is what we need for the datasource of the grid,
- * so if we receive v2, we transform it to 1
- * @param json
- */
 const prepareDataSource = (json, _file) => {
     if (!Array.isArray(json) || !json.length) {
         return {
@@ -23,7 +13,6 @@ const prepareDataSource = (json, _file) => {
     let data = [];
     let primaryKey;
     if (Array.isArray(json[0])) {
-        // we are in v2, as described above, so this is the list of columns
         columns = json[0];
         for (let i = 1, len = json.length; i < len; i++) {
             const it = json[i];

package/src/View/Alert/ActiveAlertsPanel.js

@@ -11,11 +11,9 @@ const ActiveAlertsPanel = () => {
     const adaptable = (0, AdaptableContext_1.useAdaptable)();
     const filterModule = adaptable.ModuleService.getModuleById(ModuleConstants.AlertModuleId);
     const alerts = (0, react_redux_1.useSelector)((state) => state.Internal.AdaptableAlerts);
-    // map the suspended property from the underlying AlertDefinitions
     alerts.forEach((alert) => {
         const liveAlertDef = adaptable.api.alertApi.getAlertDefinitionById(alert.alertDefinition.Uuid);
         if (liveAlertDef) {
-            // @ts-ignore theoretically AdaptableAlert is not Suspendable; practically <AdaptableObjectCompactList> expects it
             alert.IsSuspended = liveAlertDef.IsSuspended;
         }
     });

package/src/View/Alert/AlertStatusSubPanel.js

@@ -18,13 +18,9 @@ const AlertStatusPanel = () => {
         .getModuleService()
         .getModuleById(ModuleConstants.AlertModuleId);
     const statusbarHighlightDuration = adaptableApi.optionsApi.getAlertOptions().statusbarHighlightDuration;
-    /**
-     * Using a selector to so the component updates each time an alert is triggered.
-     */
     const alerts = (0, react_redux_1.useSelector)((state) => state.Internal.AdaptableAlerts);
     const text = alerts.length == 0 ? '0 Alerts' : alerts.length == 1 ? '1 Alert' : alerts.length + ' Alerts';
     const handleAction = React.useCallback(() => adaptableApi.alertApi.openAlertSettingsPanel(), []);
-    // blinking logic
     const previousAlerts = React.useRef(alerts);
     const timeoutId = React.useRef(null);
     React.useEffect(() => {
@@ -42,10 +38,6 @@ const AlertStatusPanel = () => {
             clearTimeout(timeoutId.current);
             timeoutId.current = null;
         }
-        /**
-         * Cannot clear timeout in the useEffect cleanup function, because this logic is not
-         * called for each case. e.g. it is skipped for when alerts are not added.
-         */
         timeoutId.current = setTimeout(() => {
             setStyle(initialStyle);
         }, statusbarHighlightDuration);

package/src/View/Alert/Utilities/getAlertType.js

@@ -12,12 +12,6 @@ var AlertType;
     AlertType["Observable"] = "Observable";
     AlertType["Scheduled"] = "Scheduled";
 })(AlertType || (exports.AlertType = AlertType = {}));
-/**
- * Based on alert shape the type is derived.
- * In the future the alert will get a type property.
- *
- * @param alert
- */
 const getAlertType = (alert) => {
     if ((0, ScheduledAlertHelper_1.isScheduledAlertDefinition)(alert)) {
         return AlertType.Scheduled;
@@ -42,7 +36,6 @@ const getAlertType = (alert) => {
     if (predicates) {
         return (0, ScheduledAlertHelper_1.getRuleAlertProperties)(alert)?.PreventEdit ? AlertType.Validation : AlertType.DataChange;
     }
-    // the object is not a valid alert
     return null;
 };
 exports.getAlertType = getAlertType;

package/src/View/Alert/Utilities/getDefaultAlertDefinition.js

@@ -5,16 +5,11 @@ const tslib_1 = require("tslib");
 const ObjectFactory_1 = tslib_1.__importDefault(require("../../../Utilities/ObjectFactory"));
 const ScheduledAlertHelper_1 = require("../../../Utilities/Helpers/Scheduling/ScheduledAlertHelper");
 const getAlertType_1 = require("./getAlertType");
-/**
- * This logic should be moved into Object factory once we have types on alert definitions
- * @param type AlertType
- */
 const getDefaultAlertDefinition = (alertDefinition, type) => {
     const newAlert = {
         ...ObjectFactory_1.default.CreateEmptyAlertDefinition(),
         Uuid: alertDefinition.Uuid,
     };
-    // can only be all
     if (type === getAlertType_1.AlertType.Observable ||
         type === getAlertType_1.AlertType.Aggregation ||
         type === getAlertType_1.AlertType.RowChange) {

package/src/View/Alert/Utilities/mapAlertDefinition.js

@@ -15,8 +15,6 @@ const mapAlertDefinition = (api, alertDefinition) => {
             return alertCommand;
         }
     };
-    // the only case needed is when changing from AddedRow to RemovedRow
-    // map FormButton Actions
     if (alertDefinition.AlertForm && typeof alertDefinition.AlertForm !== 'string') {
         const alertButtons = alertDefinition.AlertForm?.Buttons;
         alertButtons?.forEach((alertButton) => {
@@ -31,7 +29,6 @@ const mapAlertDefinition = (api, alertDefinition) => {
             }
         });
     }
-    // behaviours
     if (isRemovedRowChangeAlert) {
         delete alertDefinition.AlertProperties.HighlightRow;
         delete alertDefinition.AlertProperties.JumpToRow;

package/src/View/Alert/Wizard/AlertWizard.js

@@ -61,8 +61,6 @@ const AlertWizard = (props) => {
     const setAlertDefinition = (0, react_1.useCallback)((data) => {
         doSetAlertDefinition(data);
     }, []);
-    // Alert type is based initialy on data, but can be changed by the user
-    // the default objects do not neccesary have enough information to determine the type
     const [alertType, setAlertType] = (0, react_1.useState)(() => {
         return (0, getAlertType_1.getAlertType)(alertDefinition) ?? getAlertType_1.AlertType.DataChange;
     });

package/src/View/Alert/Wizard/isValidAlertRules.js

@@ -17,7 +17,6 @@ const isValidAlertRules = (alert, api, context) => {
     if (typeof isRuleValid === 'string') {
         return isRuleValid;
     }
-    // boolean expressions may also be saved as named queries
     if (context.namedQuery != false) {
         const isValidName = api.namedQueryApi.isValidNamedQuery(context.namedQuery);
         if (!isValidName.valid) {

package/src/View/BulkUpdate/BulkUpdatePopup.js

@@ -30,7 +30,6 @@ class BulkUpdatePopupComponent extends React.Component {
         let hasDataTypeError = false;
         let dataTypeErrorMessage = '';
         if (col && StringExtensions_1.StringExtensions.IsNotNullOrEmpty(this.props.BulkUpdateValue)) {
-            // check that the update value is a number for a numeric column.  not issue for dates as we dont allow free text
             if (col.dataType == 'number') {
                 if (isNaN(Number(this.props.BulkUpdateValue))) {
                     hasDataTypeError = true;

package/src/View/CalculatedColumn/Wizard/CalculatedColumnSettingsWizardSection.js

@@ -70,8 +70,6 @@ const CalculatedColumnSettingsWizardSection = (props) => {
     ];
     return ((0, jsx_runtime_1.jsx)(Flex_1.Box, { "data-name": 'calculated-column-settings', children: (0, jsx_runtime_1.jsxs)(Flex_1.Flex, { flexDirection: "column", className: "twa:gap-3 twa:p-3", children: [(0, jsx_runtime_1.jsxs)(Card_1.Card, { shadow: false, children: [(0, jsx_runtime_1.jsxs)(Card_1.Card.Title, { children: [(0, jsx_runtime_1.jsx)(Flex_1.Box, { className: "twa:font-medium", children: "Data Type" }), (0, jsx_runtime_1.jsx)(Flex_1.Box, { className: "twa:text-xs twa:opacity-70 twa:font-normal twa:max-w-[520px]", children: "Choose the data type for the Calculated Column values" })] }), (0, jsx_runtime_1.jsxs)(Card_1.Card.Body, { className: "twa:p-1 twa:gap-1", children: [(0, jsx_runtime_1.jsx)(NewSelect_1.SingleSelect, { "data-name": "column-type", placeholder: "Select Data Type", items: options, value: dataType, onValueChange: (value) => handleDataTypeChange(value), className: "twa:max-w-[300px]" }), ErrorMessage ? ((0, jsx_runtime_1.jsx)(Flex_1.Box, { className: "twa:text-2 twa:text-destructive", children: ErrorMessage })) : null] })] }), (0, jsx_runtime_1.jsxs)(Card_1.Card, { shadow: false, children: [(0, jsx_runtime_1.jsxs)(Card_1.Card.Title, { children: [(0, jsx_runtime_1.jsx)(Flex_1.Box, { className: "twa:font-medium", children: "Width" }), (0, jsx_runtime_1.jsx)(Flex_1.Box, { className: "twa:text-xs twa:opacity-70 twa:font-normal twa:max-w-[520px]", children: "Optional Column Width in pixels" })] }), (0, jsx_runtime_1.jsx)(Card_1.Card.Body, { className: "twa:p-1", children: (0, jsx_runtime_1.jsx)(Input_1.default, { "data-name": "column-width", type: "number", className: "twa:max-w-[300px]", value: Width || '', onChange: (e) => handleSpecialColumnSettingsChange({
                                     Width: Number(e.target.value),
-                                }) }) })] }), (0, jsx_runtime_1.jsx)(SpecialColumnSettingsWizardStep_1.SpecialColumnSettingsWizardStep, { isEditable: false, 
-                    // @ts-ignore CalculatedColumn has a broader DataType
-                    settings: data.CalculatedColumnSettings, onChange: handleSpecialColumnSettingsChange })] }) }));
+                                }) }) })] }), (0, jsx_runtime_1.jsx)(SpecialColumnSettingsWizardStep_1.SpecialColumnSettingsWizardStep, { isEditable: false, settings: data.CalculatedColumnSettings, onChange: handleSpecialColumnSettingsChange })] }) }));
 };
 exports.CalculatedColumnSettingsWizardSection = CalculatedColumnSettingsWizardSection;

package/src/View/CalculatedColumn/Wizard/CalculatedColumnWizard.js

@@ -59,7 +59,6 @@ const CalculatedColumnWizard = (props) => {
             });
         }
         else {
-            // Aggregated, Cumulative & Quantile are all AggregatedScalarExpression
             setCalculatedColumn({
                 ...calculatedColumn,
                 Query: {

package/src/View/CalculatedColumn/utils.d.ts

@@ -1,2 +1,2 @@
 import { AdaptableApi, CalculatedColumn } from '../../types';
-export declare const getExpressionType: (calculatedColumn: CalculatedColumn, api: AdaptableApi) => "AggregatedScalarExpression" | "ScalarExpression" | "CumulativeAggregatedExpression" | "QuantileAggregatedExpression";
+export declare const getExpressionType: (calculatedColumn: CalculatedColumn, api: AdaptableApi) => "ScalarExpression" | "AggregatedScalarExpression" | "CumulativeAggregatedExpression" | "QuantileAggregatedExpression";

package/src/View/CellSummary/CellSummaryPopup.js

@@ -11,10 +11,7 @@ const PanelWithButton_1 = require("../Components/Panels/PanelWithButton");
 class CellSummaryPopupComponent extends React.Component {
     componentDidMount() {
         if (this.props.popupParams?.source === 'ColumnMenu' && this.props.popupParams?.column) {
-            // if the summary was requested from the column menu, we need to select the entire column
-            // afterwards, we will go on with the cell summary logic, as that will evaluate the current(column) cell selection
             this.props.api.columnApi.selectColumn(this.props.popupParams?.column.columnId);
-            // we also need to update the internal state of the selected cells
             this.props.api.internalApi.getAdaptableInstance().refreshSelectedCellsState();
         }
         this.props.onCreateCellSummary();

package/src/View/CellSummary/CellSummaryStatusBarSubPanelPopover.js

@@ -7,12 +7,6 @@ const react_redux_1 = require("react-redux");
 const CellSummaryStatusBarSubPanelPopover = () => {
     const cellSummary = (0, react_redux_1.useSelector)((state) => state.Internal.CellSummary.CellSummaryInfo);
     const summary = (0, jsx_runtime_1.jsx)(CellSummaryDetails_1.CellSummaryDetails, { CellSummary: cellSummary });
-    return cellSummary && cellSummary.Count ? (summary) : (
-    // the extra wrapper is added because the empty text is rendered
-    // inside a  EmptyContent, hat has position absolute
-    ((0, jsx_runtime_1.jsx)(
-        "div",
-        { style: { position: 'relative', width: '100%', height: 80 }, children: summary }
-    )));
+    return cellSummary && cellSummary.Count ? (summary) : ((0, jsx_runtime_1.jsx)("div", { style: { position: 'relative', width: '100%', height: 80 }, children: summary }));
 };
 exports.CellSummaryStatusBarSubPanelPopover = CellSummaryStatusBarSubPanelPopover;