@adaptabletools/adaptable-cjs 23.0.4 → 23.0.5-canary.0

package/src/Api/Internal/ColumnFilterInternalApi.js

@@ -10,20 +10,11 @@ const windowFactory_1 = require("../../View/Components/Popups/WindowPopups/windo
 const ApiBase_1 = require("../Implementation/ApiBase");
 const AdaptableFilterHandler_1 = require("../../agGrid/AdaptableFilterHandler");
 class ColumnFilterInternalApi extends ApiBase_1.ApiBase {
-    /**
-     * Returns Predicate Definition for given Column and Quick Filter shortcut
-     * @param shortcut Quick Filter shortcut to lookup
-     * @param column AdapTable Column being Filtered
-     */
     findPredicateDefByShortcut(shortcut, column) {
         return this.getColumnFilterApi()
             .getFilterPredicateDefsForColumn(column)
             .find((predicateDef) => this.getPredicateDefShortcuts(predicateDef)?.includes(shortcut));
     }
-    /**
-     * Creates an Equality Filter based on given Grid Cells
-     * @param gridCells cells to create Filter for
-     */
     createValuesColumnFilterForCells(gridCells) {
         if (!gridCells) {
             return null;
@@ -40,10 +31,6 @@ class ColumnFilterInternalApi extends ApiBase_1.ApiBase {
         const [savedFilter] = this.getColumnFilterApi().setColumnFilters([filter]) || [null];
         return savedFilter;
     }
-    /**
-     *  Creates an Equality Filter based on given Grid Cell
-     * @param gridCell cell to create Filter for
-     */
     createEqualityColumnFilterForCell(gridCell) {
         if (!gridCell) {
             return null;
@@ -61,11 +48,6 @@ class ColumnFilterInternalApi extends ApiBase_1.ApiBase {
         const [savedFilter] = this.getColumnFilterApi().setColumnFilters([filter]) || [null];
         return savedFilter;
     }
-    /**
-     * Calls AdapTableQL to evaluate Filter for given Row
-     * @param columnFilter Column Filter to use
-     * @param node Row Node to evaluate
-     */
     evaluateColumnFilter(columnFilter, node) {
         if (!columnFilter.Predicates.length) {
             return true;
@@ -101,24 +83,9 @@ class ColumnFilterInternalApi extends ApiBase_1.ApiBase {
             predicatesOperator: columnFilter.PredicatesOperator,
             ...this.getAdaptableInternalApi().buildBaseContext(),
         };
-        //  #column_filter_predicates_evaluation
         return this.getPredicateApi().handlePredicates(columnFilter.Predicates, predicateDefHandlerContext, true);
     }
-    /**
-     * Checks if the filter action should trigger Column Filtering
-     *
-     * @param action Filtering Action
-     */
     shouldNewColumnFilterTriggerColumnFiltering(action) {
-        // trigger filter change only:
-        // - new -> new filter is active
-        // - clear -> previous filters was active
-        // - clearAll -> a filter was active
-        // - edit -> same => input change
-        // - edit -> different & new is active
-        // - edit -> different & old was active
-        // - set -> new filter is active
-        // filter -> suspend changes
         const isNewAndActive = action.type === LayoutRedux.LAYOUT_COLUMN_FILTER_ADD &&
             this.getColumnFilterApi().isColumnFilterActive(action.columnFilter);
         const isClearAndPreviousWasActive = action.type === LayoutRedux.LAYOUT_COLUMN_FILTER_CLEAR &&
@@ -131,19 +98,15 @@ class ColumnFilterInternalApi extends ApiBase_1.ApiBase {
         if (action.type === LayoutRedux.LAYOUT_COLUMN_FILTER_EDIT) {
             const newFilter = action.columnFilter;
             const previous = this.getColumnFilterApi().getColumnFilterForColumn(newFilter.ColumnId);
-            // same filter edit, so always trigger
             if (previous &&
                 newFilter &&
-                // same predicates
                 (0, ArrayExtensions_1.areArraysEqual)(previous.Predicates.map((p) => p.PredicateId), newFilter.Predicates.map((p) => p.PredicateId))) {
                 isEditTrigger = true;
-                // new filter is active
             }
             else if (this.getColumnFilterApi().isColumnFilterActive(newFilter)) {
                 isEditTrigger = true;
             }
             else if (this.getColumnFilterApi().isColumnFilterActive(previous)) {
-                // previous filter was active
                 isEditTrigger = true;
             }
         }
@@ -162,17 +125,11 @@ class ColumnFilterInternalApi extends ApiBase_1.ApiBase {
             isSetAndActive ||
             isSuspendChanged);
     }
-    /**
-     * Compares to sets of Column Filters to see if they are identical
-     * @param filters1
-     * @param filters2
-     */
     areColumnFiltersDifferent(oldFilters, newFilters) {
         if (ArrayExtensions_1.default.IsNullOrEmpty(oldFilters) && ArrayExtensions_1.default.IsNullOrEmpty(newFilters)) {
             return false;
         }
         return !ArrayExtensions_1.default.areArraysEqualWithCustomComparator(oldFilters, newFilters, (filter1, filter2) => {
-            // Compare basic properties
             if (filter1.ColumnId !== filter2.ColumnId) {
                 return false;
             }
@@ -182,12 +139,10 @@ class ColumnFilterInternalApi extends ApiBase_1.ApiBase {
             if ((filter1.IsSuspended || false) !== (filter2.IsSuspended || false)) {
                 return false;
             }
-            // Compare predicates (regardless of order)
             return ArrayExtensions_1.default.areArraysEqualWithCustomComparator(filter1.Predicates, filter2.Predicates, (pred1, pred2) => {
                 if (pred1.PredicateId !== pred2.PredicateId) {
                     return false;
                 }
-                // Compare inputs array (might be primitives or objects)
                 return ArrayExtensions_1.default.areArraysEqualWithCustomComparator(pred1.Inputs, pred2.Inputs, (input1, input2) => {
                     if (input1 === input2) {
                         return true;
@@ -195,7 +150,6 @@ class ColumnFilterInternalApi extends ApiBase_1.ApiBase {
                     if (typeof input1 !== typeof input2) {
                         return false;
                     }
-                    // For object inputs, use JSON comparison
                     if (typeof input1 === 'object' && input1 !== null && input2 !== null) {
                         return JSON.stringify(input1) === JSON.stringify(input2);
                     }
@@ -241,16 +195,11 @@ class ColumnFilterInternalApi extends ApiBase_1.ApiBase {
             },
         });
     }
-    /**
-     * First we try to get the cached values from the FilterHandler
-     * Only if the FilterHandler is not available we fallback to the GridApi method
-     */
     async getColumnFilterValues(options) {
         const filterOptions = this.getOptionsApi().getFilterOptions();
         const newOptions = {
             columnId: options.columnId,
             get currentSearchValue() {
-                // we need this in order to keep it lazy
                 return options.currentSearchValue;
             },
             previousResult: undefined,
@@ -282,7 +231,6 @@ class ColumnFilterInternalApi extends ApiBase_1.ApiBase {
             };
             return manuallyApplyColumnFilterOpt(context);
         }
-        // fallback, should never happen
         return false;
     }
     getAdaptableFilterHandler(columnId) {

package/src/Api/Internal/ColumnInternalApi.js

@@ -16,13 +16,6 @@ function getAutoRowGroupColumnIdFor(columnId) {
     return `${GeneralConstants_1.AG_GRID_GROUPED_COLUMN}-${columnId}`;
 }
 class ColumnInternalApi extends ApiBase_1.ApiBase {
-    /**
-     * Retrieves 'ColumnType' property for a given Column
-     *   isCumulativeAggregate(input: string): boolean {
-     *     return !!this.getNodesFromExpression(input, 'CUMUL')?.length;
-     *   }
-     * @param columnId Column to use
-     */
     getAgGridColumnType(columnId) {
         return this._adaptable.getAgGridColumnType(columnId);
     }
@@ -41,9 +34,6 @@ class ColumnInternalApi extends ApiBase_1.ApiBase {
         });
         return (0, ArrayExtensions_1.uniq)(colTypes).filter((c) => StringExtensions_1.default.IsNotNullOrEmptyOrWhiteSpace(c));
     }
-    /**
-     * Retrieves a list providing the Friendly Name / Caption for all columns
-     */
     getAllColumnFriendlyNames() {
         return this.getColumnApi()
             .getColumns()
@@ -54,18 +44,10 @@ class ColumnInternalApi extends ApiBase_1.ApiBase {
     getAutoRowGroupColumnIdFor(columnId) {
         return getAutoRowGroupColumnIdFor(columnId);
     }
-    /**
-     * Retrieves AG Grid's field property for the column
-     * @param columnId columnId to look up
-     */
     getAgGridColumnFieldForAdaptableColumn(columnId) {
         const agGridColumn = this.getAgGridColumnForAdaptableColumn(columnId);
         return agGridColumn.getColDef().field || '';
     }
-    /**
-     * Retrieves AG Grid's column for an Adaptable column
-     * @param columnId columnId to look up
-     */
     getAgGridColumnForAdaptableColumn(columnId) {
         return this._adaptable.getAgGridColumnForColumnId(columnId);
     }
@@ -80,7 +62,6 @@ class ColumnInternalApi extends ApiBase_1.ApiBase {
                 this.getColumnApi().isFdc3Column(columnId));
     }
     getColumnHeaderName(params) {
-        // this is the same object, but casting it makes it easier to work with
         const isColumn = !params.columnGroup;
         const columnParams = params;
         const isColumnGroup = !!params.columnGroup;
@@ -88,16 +69,13 @@ class ColumnInternalApi extends ApiBase_1.ApiBase {
         const defaultHeaderName = params.colDef?.headerName ??
             (isColumn ? StringExtensions_1.default.CamelCaseToHumanText(columnParams.colDef?.field) : '') ??
             '';
-        // for now we override ONLY the header names
         if (params.location !== 'header') {
             return defaultHeaderName;
         }
-        // 1. Layout specific header has the highest priority
         const layoutSpecificCustomHeader = this.getLayoutApi().getCurrentLayout().ColumnHeaders?.[isColumn ? columnParams.column.getColId() : columnGroupParams.columnGroup.getGroupId()];
         if (layoutSpecificCustomHeader) {
             return layoutSpecificCustomHeader;
         }
-        // 2. check for custom ColumnOptions.columnHeader
         if (typeof this.getColumnOptions().columnHeader === 'function') {
             const columnHeaderContext = this.buildColumnHeaderContext(params, defaultHeaderName);
             if (columnHeaderContext === 'skip') {
@@ -106,7 +84,6 @@ class ColumnInternalApi extends ApiBase_1.ApiBase {
             const customHeader = this.getColumnOptions().columnHeader(columnHeaderContext);
             return customHeader;
         }
-        // 3. fallback to default header name
         return defaultHeaderName;
     }
     buildColumnHeaderContext(params, defaultHeaderName) {
@@ -119,7 +96,6 @@ class ColumnInternalApi extends ApiBase_1.ApiBase {
             currentLayoutName: currentLayout.Name,
             currentLayoutType: currentLayoutType,
         };
-        // makes it easier to work with
         const currentTableLayout = currentLayout;
         const currentPivotLayout = currentLayout;
         if (params.column?.getColId() === GeneralConstants_1.AG_GRID_GROUPED_COLUMN) {
@@ -136,7 +112,6 @@ class ColumnInternalApi extends ApiBase_1.ApiBase {
         if (params.column?.getColId().startsWith(`${GeneralConstants_1.AG_GRID_GROUPED_COLUMN}-`)) {
             const columnType = 'rowGroupColumn';
             const columnId = params.column.getColId();
-            // remove `${AG_GRID_GROUPED_COLUMN}-` from beginning of columnId
             const groupColumnId = columnId.substring(`${GeneralConstants_1.AG_GRID_GROUPED_COLUMN}-`.length);
             return {
                 ...baseContext,
@@ -149,8 +124,6 @@ class ColumnInternalApi extends ApiBase_1.ApiBase {
             if (params.columnGroup) {
                 const columnType = 'tableColumnGroup';
                 if (!params.colDef?.children) {
-                    // AG Grid created virtual column groups for all columns
-                    // we want to skip those
                     return 'skip';
                 }
                 return {
@@ -183,7 +156,6 @@ class ColumnInternalApi extends ApiBase_1.ApiBase {
         if (baseContext.currentLayoutType === 'pivot') {
             if (params.columnGroup) {
                 if (!params.colDef?.pivotKeys) {
-                    // we might have user defined colGroups, but we are not interested in them in pivot mode
                     return 'skip';
                 }
                 const columnType = 'pivotColumnGroup';
@@ -205,7 +177,6 @@ class ColumnInternalApi extends ApiBase_1.ApiBase {
                     const aggregatedColumnId = pivotValueCol?.getColId();
                     const currentLayoutAggCols = currentPivotLayout.PivotAggregationColumns?.map((col) => col.ColumnId);
                     if (!currentLayoutAggCols?.includes(aggregatedColumnId)) {
-                        // this column is not an aggregation column
                         return 'skip';
                     }
                     return {
@@ -259,7 +230,6 @@ class ColumnInternalApi extends ApiBase_1.ApiBase {
                     const aggregatedColumnId = pivotValueCol?.getColId();
                     const currentLayoutAggCols = currentPivotLayout.PivotAggregationColumns?.map((col) => col.ColumnId);
                     if (!currentLayoutAggCols?.includes(aggregatedColumnId)) {
-                        // this column is not an aggregation column
                         return 'skip';
                     }
                     return {
@@ -273,7 +243,6 @@ class ColumnInternalApi extends ApiBase_1.ApiBase {
                 }
             }
         }
-        // if nothing matched, we skip this column[group]
         return 'skip';
     }
     hasArrayDataType(column) {
@@ -290,7 +259,6 @@ class ColumnInternalApi extends ApiBase_1.ApiBase {
         return this.getColumnApi().hasColumnType(columnIdentifier, AdaptableColumn_1.HIDDEN_COLUMN_TYPE);
     }
     getColumnDateTypes() {
-        // this is required because Adaptable uses 'date' type for all AG Grid date types: 'date', 'dateString'
         return ['date'];
     }
 }

package/src/Api/Internal/CustomSortInternalApi.js

@@ -21,7 +21,6 @@ class CustomSortInternalApi extends ApiBase_1.ApiBase {
         return `${value}`;
     }
     getDefaultCustomSortComparer(columnId, columnValues) {
-        // have to return a function that may not have access to this
         const gridApi = this.getGridApi();
         const columnDataType = this.getColumnApi().getColumnDataTypeForColumnId(columnId);
         const _this = this;
@@ -34,22 +33,18 @@ class CustomSortInternalApi extends ApiBase_1.ApiBase {
             let containsFirstElement = indexFirstElement >= 0;
             let indexSecondElement = columnValues.indexOf(secondCustomSortValue);
             let containsSecondElement = indexSecondElement >= 0;
-            //if none of the element are in the list we jsut return normal compare
             if (!containsFirstElement && !containsSecondElement) {
                 if (valueA == valueB) {
                     return 0;
                 }
                 return valueA < valueB ? -1 : 1;
             }
-            //if first item not in the list make sure we put it after the second item
             if (!containsFirstElement) {
                 return 1;
             }
-            //if second item not in the list make sure we put it after the first item
             if (!containsSecondElement) {
                 return -1;
             }
-            //return the comparison from the list if the two items are in the list
             return indexFirstElement - indexSecondElement;
         };
     }

package/src/Api/Internal/DashboardInternalApi.js

@@ -4,38 +4,15 @@ exports.DashboardInternalApi = void 0;
 const Types_1 = require("../../AdaptableState/Common/Types");
 const ApiBase_1 = require("../Implementation/ApiBase");
 class DashboardInternalApi extends ApiBase_1.ApiBase {
-    /**
-     * Registry of reset-callbacks keyed by Custom-Toolbar name. Each
-     * `CustomToolbarCmp` registers itself on mount so the public
-     * {@link DashboardApi.resetCustomToolbarFormData} method can ask
-     * a specific instance to roll its `toolbarForm` data back to its
-     * declared `defaultValue`s without re-mounting the component.
-     */
     customToolbarFormResetters = new Map();
-    /**
-     * Register a reset callback for a Custom Toolbar. Idempotent: a second
-     * registration for the same name overwrites the previous entry, so a
-     * remount of the same toolbar always wins.
-     */
     registerCustomToolbarFormResetter(toolbarName, resetter) {
         this.customToolbarFormResetters.set(toolbarName, resetter);
     }
-    /**
-     * Tear down a previously-registered reset callback, but only if it's
-     * still the active one. Guards against a stale unmount clobbering a
-     * registration made by a fresh mount of the same toolbar.
-     */
     unregisterCustomToolbarFormResetter(toolbarName, resetter) {
         if (this.customToolbarFormResetters.get(toolbarName) === resetter) {
             this.customToolbarFormResetters.delete(toolbarName);
         }
     }
-    /**
-     * Invokes the registered reset callback for the given toolbar (or all
-     * registered toolbars when `toolbarName` is omitted). Silently no-ops
-     * if no toolbar is registered under the given name - this is benign
-     * (e.g. the toolbar has not yet mounted, or it has no `toolbarForm`).
-     */
     resetCustomToolbarFormData(toolbarName) {
         if (toolbarName) {
             const fn = this.customToolbarFormResetters.get(toolbarName);

package/src/Api/Internal/DataImportInternalApi.js

@@ -60,7 +60,6 @@ class DataImportInternalApi extends ApiBase_1.ApiBase {
         };
         this.getAlertApi().displayAdaptableAlert(alert);
         const dataImportedInfo = this.getEventApi().internalApi.fireDataImportedEvent(importData, addedRows, updatedRows);
-        // Dispatch action (purely so it will be in Audit Log)
         this.getAdaptableInternalApi().dispatchReduxAction(InternalRedux.DataImportCompleted(dataImportedInfo));
     }
 }

package/src/Api/Internal/EventInternalApi.js

@@ -39,7 +39,6 @@ class EventInternalApi extends ApiBase_1.ApiBase {
             const visibleInNewState = this.getDashboardApi().internalApi.isToolbarInActiveTab(toolbarName, newDashboardState);
             const visibleInOldState = this.getDashboardApi().internalApi.isToolbarInActiveTab(toolbarName, oldDashboardState);
             if (visibleInNewState && visibleInOldState) {
-                // check for dashboard collapse/expand/hidden changes
                 return ((oldDashboardState.IsCollapsed && !newDashboardState.IsCollapsed) ||
                     (oldDashboardState.IsHidden && !newDashboardState.IsHidden));
             }
@@ -49,7 +48,6 @@ class EventInternalApi extends ApiBase_1.ApiBase {
             const visibleInNewState = this.getDashboardApi().internalApi.isToolbarInActiveTab(toolbarName, newDashboardState);
             const visibleInOldState = this.getDashboardApi().internalApi.isToolbarInActiveTab(toolbarName, oldDashboardState);
             if (visibleInNewState && visibleInOldState) {
-                // check for dashboard collapse/expand/hidden changes
                 return ((!oldDashboardState.IsCollapsed && newDashboardState.IsCollapsed) ||
                     (!oldDashboardState.IsHidden && newDashboardState.IsHidden));
             }

package/src/Api/Internal/ExportInternalApi.js

@@ -12,26 +12,19 @@ const Helper_1 = tslib_1.__importDefault(require("../../Utilities/Helpers/Helper
 const PopupRedux = tslib_1.__importStar(require("../../Redux/ActionsReducers/PopupRedux"));
 const InternalRedux_1 = require("../../Redux/ActionsReducers/InternalRedux");
 class ExportInternalApi extends ApiBase_1.ApiBase {
-    /**
-     * Value Items for Report Name Selection
-     */
     getAllAvailableReportNames() {
         return this.getExportApi()
             .getAllReports()
             .map((report) => report.Name);
     }
     isDataChangeInReport(cellDataChangedInfo, report) {
-        // for All Data Report any data change is true so get out asap
         if (report.Name == 'All Data') {
             return true;
         }
-        // Start with the DataChanged Column and go through all possibilities
         switch (report.ReportColumnScope) {
             case 'AllColumns':
-                // has to be relevant so continue to rows
                 break;
             case 'ScopeColumns':
-                // use the Scope object which will tell us if the Column is relevant
                 if (!this.getAdaptableApi().columnScopeApi.isColumnInScopeColumns(cellDataChangedInfo.column, report.Scope)) {
                     return false;
                 }
@@ -45,27 +38,23 @@ class ExportInternalApi extends ApiBase_1.ApiBase {
                 }
                 break;
             case 'VisibleColumns':
-                //  hope that visible column property is updated whenever the layout changes... (need to check!)
                 if (!cellDataChangedInfo.column.visible) {
                     return false;
                 }
                 break;
         }
-        // now do rows
         switch (report.ReportRowScope) {
             case 'AllRows':
                 return true;
             case 'ExpressionRows':
-                return true; // TODO this is the only difficult one - do we check AdapTableQL?  if we can then that is good as we can then do a delta after all...
+                return true;
             case 'SelectedRows':
-                // CellSelection
                 let selectedCellInfo = this.getAdaptableApi().gridApi.getSelectedCellInfo();
                 if (selectedCellInfo && selectedCellInfo.gridCells) {
                     if (selectedCellInfo.gridCells.find((gc) => gc.primaryKeyValue == cellDataChangedInfo.primaryKeyValue)) {
                         return true;
                     }
                 }
-                // Row Selection
                 let selectedRowInfo = this.getAdaptableApi().gridApi.getSelectedRowInfo();
                 if (selectedRowInfo && selectedRowInfo.gridRows) {
                     if (selectedRowInfo.gridRows.find((gr) => gr.primaryKeyValue == cellDataChangedInfo.primaryKeyValue)) {
@@ -247,8 +236,6 @@ class ExportInternalApi extends ApiBase_1.ApiBase {
                 Id: 'export-destination-form',
                 Form: customDestination?.form,
                 prepareContext: (context) => {
-                    // we want to give the current popup time to close
-                    // and we reopen with a delay in case this button action causes another popup
                     return new Promise((resolve) => {
                         setTimeout(() => {
                             const preparedContext = {
@@ -346,8 +333,6 @@ class ExportInternalApi extends ApiBase_1.ApiBase {
                 type: 'csv',
             };
         }
-        // theoretically 'VisualExcel' is not a valid export format for this function and should be suppressed from UI
-        // but just in case, we handle it here and return a "raw", unstyled Excel file
         if (exportFormat === 'Excel' || exportFormat === 'VisualExcel') {
             const excelExportConverter = this.buildExcelConverter(exportContext.report.Name, exportFormat, exportContext.destination);
             const excelData = excelExportConverter(reportData);

package/src/Api/Internal/ExpressionInternalApi.js

@@ -5,11 +5,6 @@ const tslib_1 = require("tslib");
 const ApiBase_1 = require("../Implementation/ApiBase");
 const ArrayExtensions_1 = tslib_1.__importDefault(require("../../Utilities/Extensions/ArrayExtensions"));
 class ExpressionInternalApi extends ApiBase_1.ApiBase {
-    /**
-     * Checks if a column is referenced in a given Expression
-     * @param columnId Column to Check
-     * @param expression Expression to Lookup
-     */
     isColumnReferencedInExpression(columnId, expression) {
         const colIds = this.getExpressionApi().getColumnsFromExpression(expression);
         return colIds.some((c) => c === columnId);
@@ -48,9 +43,6 @@ class ExpressionInternalApi extends ApiBase_1.ApiBase {
         }
         if (predicates) {
             context.predicates = predicates;
-            // need to find a way to get the columns in the predicates
-            // cand do later
-            //        this.getAdaptableApi().columnScopeApi.getColumnsInScope();
         }
         return !evaluateExpressionExternallyFn(context);
     }
@@ -71,21 +63,6 @@ class ExpressionInternalApi extends ApiBase_1.ApiBase {
             ...field,
             label: field.label || field.name,
         }));
-        // const existingFields = new Set<string>();
-        // Exclude fields already in options
-        // optionFields.forEach((field) => existingFields.add(field.value));
-        // const queriableColumns = this.getColumnApi().getQueryableColumns();
-        // Exclude queriable columns
-        // queriableColumns.forEach((column) => existingFields.add(column.field));
-        // const dataFields = this.getFieldsFromData(data).reduce<AdaptableField[]>((acc, field) => {
-        //   if (!existingFields.has(field)) {
-        //     acc.push({
-        //       label: field,
-        //       value: field,
-        //     });
-        //   }
-        //   return acc;
-        // }, []);
         return optionFields;
     }
     getFieldType(field) {

package/src/Api/Internal/Fdc3InternalApi.js

@@ -162,14 +162,12 @@ class Fdc3InternalApi extends ApiBase_1.ApiBase {
     handleIntentResolution(intentResolution, context, raisedIntent, app) {
         const relevantRaiseIntentConfig = this.getAllRaiseIntentConfigs().find((config) => config.intentType === raisedIntent && config.contextType === context.type);
         if (typeof relevantRaiseIntentConfig?.handleIntentResolution === 'function') {
-            // call intent specific resolution handler
             relevantRaiseIntentConfig.handleIntentResolution({
                 ...this.getAdaptableInternalApi().buildBaseContext(),
                 intentResolution,
             });
         }
         else {
-            // call global resolution handler (if any)
             this.getFdc3Options().intents?.handleIntentResolution?.({
                 ...this.getAdaptableInternalApi().buildBaseContext(),
                 intentResolution,
@@ -225,7 +223,6 @@ class Fdc3InternalApi extends ApiBase_1.ApiBase {
         const defaultConfig = this.getAdaptableInternalApi()
             .getFdc3Service()
             .getUiControlsDefaultConfiguration();
-        // @ts-ignore
         const intentIcon = defaultConfig?.intents[intentType]?.icon ?? {
             name: 'fdc3',
         };
@@ -235,14 +232,12 @@ class Fdc3InternalApi extends ApiBase_1.ApiBase {
         const defaultConfig = this.getAdaptableInternalApi()
             .getFdc3Service()
             .getUiControlsDefaultConfiguration();
-        // @ts-ignore
         const contextIcon = defaultConfig?.contexts[contextType]?.icon ?? {
             name: 'fdc3',
         };
         return contextIcon;
     }
     mapRowValueToContextData(rowNode, contextMapping = {}) {
-        // recursively map the row node values to the context data
         const mapContext = (obj) => {
             return Object.keys(obj).reduce((mappedData, contextKey) => {
                 const valueReference = obj[contextKey];
@@ -253,20 +248,16 @@ class Fdc3InternalApi extends ApiBase_1.ApiBase {
                     mappedData[contextKey] = mapContext(valueReference);
                 }
                 else {
-                    // map value from row node
-                    // first validate refs
                     if (typeof valueReference !== 'string' ||
                         (!valueReference.startsWith(Fdc3Options_1.ColumnRefTypePrefix) &&
                             !valueReference.startsWith(Fdc3Options_1.FieldRefTypePrefix))) {
                         this.logError(`Invalid FDC3 value reference for '${contextKey}': ${valueReference}`);
                         return mappedData;
                     }
-                    // '_coldId.columnId'
                     if (valueReference.startsWith(Fdc3Options_1.ColumnRefTypePrefix)) {
                         const columnId = valueReference.replace(Fdc3Options_1.ColumnRefTypePrefix, '');
                         mappedData[contextKey] = this.getGridApi().getRawValueFromRowNode(rowNode, columnId);
                     }
-                    // '_field.fieldName'
                     if (valueReference.startsWith(Fdc3Options_1.FieldRefTypePrefix)) {
                         const fieldId = valueReference.replace(Fdc3Options_1.FieldRefTypePrefix, '');
                         mappedData[contextKey] = this.getAdaptableInternalApi().getValueUsingField(rowNode.data, fieldId);

package/src/Api/Internal/FlashingCellInternalApi.js

@@ -7,16 +7,11 @@ const Helper_1 = require("../../Utilities/Helpers/Helper");
 const AlertRedux = tslib_1.__importStar(require("../../Redux/ActionsReducers/AlertRedux"));
 const FlashingCellService_1 = require("../../Utilities/Services/FlashingCellService");
 class FlashingCellInternalApi extends ApiBase_1.ApiBase {
-    /**
-     * Merges a Flashing Cell Definition with default values
-     * @param flashingCellDefinition Flashing Cell Definition to Merge
-     */
     mergeFlashingCellDefinitionWithDefaults(flashingCellDefinition) {
         let flashingDefaults = this.getFlashingCellOptions();
         if (!flashingDefaults) {
             return flashingCellDefinition;
         }
-        // deep clone it, otherwise we will mutate&share(!!) the global flashingCellOptions object
         flashingDefaults = (0, Helper_1.cloneObject)(flashingDefaults);
         if (!flashingCellDefinition.DownChangeStyle && flashingDefaults.defaultDownChangeStyle) {
             flashingCellDefinition.DownChangeStyle = flashingDefaults.defaultDownChangeStyle;