@adaptabletools/adaptable-cjs 23.0.4 → 23.0.5-canary.0

package/src/Utilities/Services/AlertService.js

@@ -25,7 +25,6 @@ class AlertService {
         return this.emitter.on('ReactiveAlertTriggered', callback);
     };
     createReactiveAlert(alertDefinition) {
-        // if there is already a reactive alert for this definition, delete it (possible in case of editing definitions),
         this.deleteReactiveAlert(alertDefinition);
         if (!('Rule' in alertDefinition)) {
             return;

package/src/Utilities/Services/AnnotationsService.js

@@ -4,10 +4,6 @@ exports.AnnotationsService = void 0;
 const tslib_1 = require("tslib");
 const InternalRedux = tslib_1.__importStar(require("../../Redux/ActionsReducers/InternalRedux"));
 const ArrayExtensions_1 = tslib_1.__importDefault(require("../Extensions/ArrayExtensions"));
-/**
- * This service controls the interaction between Notes & Comments
- * If there are active Notes or Comments it listens to Cell Selection and Mouse Enter events
- */
 class AnnotationsService {
     api;
     adaptable;
@@ -32,7 +28,6 @@ class AnnotationsService {
         if (a?.ColumnId === b?.ColumnId && a?.PrimaryKeyValue === b?.PrimaryKeyValue) {
             return true;
         }
-        // Primary keys retrieved from the grid dom are always strings, so we must also consider them strings
         if ((typeof a.PrimaryKeyValue === 'number' && typeof b.PrimaryKeyValue === 'string') ||
             (typeof b.PrimaryKeyValue === 'string' && typeof a.PrimaryKeyValue === 'number')) {
             return (a.PrimaryKeyValue.toString() === b.PrimaryKeyValue.toString() && a.ColumnId === b.ColumnId);
@@ -46,7 +41,6 @@ class AnnotationsService {
         }
     }
     shouldListenToEvents() {
-        // Listen to events if we either have Notes in state or if Comments have been set up
         return (ArrayExtensions_1.default.IsNotNullOrEmpty(this.api.noteApi.getAllNotes()) ||
             this.api.internalApi.getModuleService().isAdapTableModulePresent('Comment'));
     }
@@ -85,28 +79,19 @@ class AnnotationsService {
     handleMouseEnter(event) {
         const editMode = this.getEditMode();
         if (editMode) {
-            // ignore
             return;
         }
         const cellPosition = this.getCellPositionFromEvent(event);
         const openCellAddress = this.getOpenCellAddress();
-        // Hovering over something that is not a cell and there is no open note
         if (!cellPosition && openCellAddress) {
-            // need to close if the new cell does not have a note
             this.hidePopup();
             return;
         }
-        // call only if cell address is different
         if (AnnotationsService.isSameAddress(openCellAddress, cellPosition)) {
             return;
         }
         const cellNote = this.api.noteApi.getNoteForCell(cellPosition);
         const cellComments = this.api.commentApi.getCommentThreadForCell(cellPosition);
-        // Notes / Comments only open on hover when explicitly opted in via
-        // `noteOptions.openNote = 'hover'` / `commentOptions.showComment =
-        // 'hover'` (the defaults). When either is set to 'menu' the popup is
-        // only opened via the Cell Menu, so we ignore that side of the
-        // annotation when deciding whether to show the popup here.
         const openNoteMode = this.api.optionsApi.getNoteOptions()?.showNoteAction ?? 'hover';
         const showCommentMode = this.api.optionsApi.getCommentOptions()?.showCommentAction ?? 'hover';
         const shouldOpenForNote = !!cellNote && openNoteMode === 'hover';
@@ -117,26 +102,19 @@ class AnnotationsService {
         this.showPopup(cellPosition, false);
     }
     handleCellSelected(cellAddress) {
-        // if already opened - do nothing
         const openCellAddress = this.getOpenCellAddress();
         if (AnnotationsService.isSameAddress(openCellAddress, cellAddress)) {
             return;
         }
-        // if open but this has no note, close
         const cellNote = this.api.noteApi.getNoteForCell(cellAddress);
         const cellComments = this.api.commentApi.getCommentThreadForCell(cellAddress);
         const hasNotesOrComments = cellNote || cellComments;
         if (openCellAddress && !hasNotesOrComments) {
-            // hide only if in edit mode
-            // because if you select a cell and move the mouse fast over another cell
-            // with a note, you do not want to close that note
-            // the selection is debounced, so the moment goes over the new cell this event is triggered
             if (this.getEditMode()) {
                 this.hidePopup();
             }
             return;
         }
-        // if open but the new selection has a note open that one in edit mode (because of click)
         if (openCellAddress && hasNotesOrComments) {
             this.showPopup(cellAddress, true);
             return;

package/src/Utilities/Services/CalculatedColumnExpressionService.js

@@ -53,9 +53,6 @@ class CalculatedColumnExpressionService {
     getCalculatedColumnDataType(calculatedColumnQuery) {
         try {
             if (calculatedColumnQuery.AggregatedScalarExpression) {
-                // currently AggregatedScalarExpression support only numerical values
-                // TODO AFL try to derive the type from the aggregatedColumn?
-                // we definitely don't want to aggregate everything only to get the data type
                 return 'number';
             }
             let firstRowNode = this.adaptableApi.gridApi.getFirstRowNode();
@@ -86,7 +83,6 @@ class CalculatedColumnExpressionService {
     isCalculatedColumnQueryValid(calculatedColumnQuery) {
         if (calculatedColumnQuery.ScalarExpression) {
             try {
-                // TODO AFL add a cached validation for ScalarExpression, just like for all the other types
                 let firstRowNode = this.adaptableApi.gridApi.getFirstRowNode();
                 this.adaptableApi.internalApi
                     .getQueryLanguageService()
@@ -94,7 +90,6 @@ class CalculatedColumnExpressionService {
                 return true;
             }
             catch (e) {
-                // no logging as this method is used only in the UI
                 return false;
             }
         }
@@ -102,7 +97,6 @@ class CalculatedColumnExpressionService {
             const validationResult = this.adaptableApi.expressionApi.isValidAggregatedScalarExpression(calculatedColumnQuery.AggregatedScalarExpression, ModuleConstants_1.CalculatedColumnModuleId);
             return validationResult;
         }
-        // if query has neither a ScalarExpression nor an AggregatedScalarExpression => it can only be false
         return false;
     }
     evaluateCalculatedColumnQuery(calculatedColumn, rowNode) {
@@ -110,7 +104,6 @@ class CalculatedColumnExpressionService {
             if (this.adaptableApi.gridApi.isGroupRowNode(rowNode)) {
                 return undefined;
             }
-            // no validation here, this function has to be as performant as possible
             if (calculatedColumn?.Query?.ScalarExpression) {
                 return this.adaptableApi.internalApi
                     .getQueryLanguageService()
@@ -128,7 +121,6 @@ class CalculatedColumnExpressionService {
         }
     }
     createAggregatedScalarLiveValue(calculatedColumn) {
-        // if there is already an aggregated scalar, delete it (possible when editing)
         this.destroyAggregatedScalarLiveValue(calculatedColumn);
         if (calculatedColumn.Query?.AggregatedScalarExpression) {
             try {

package/src/Utilities/Services/ChartingService.js

@@ -17,7 +17,6 @@ class ChartingService {
             case 'chartCreated':
                 const createParams = params;
                 if (allChartDefinitions.some((chartDefinition) => chartDefinition.Model?.chartId === createParams.chartId)) {
-                    // chart already exists
                 }
                 else {
                     const chartModel = models.find((model) => model?.chartId === createParams.chartId);
@@ -27,7 +26,6 @@ class ChartingService {
             case 'chartOptionsChanged':
             case 'chartRangeSelectionChanged':
                 if (!currentChartDefinition) {
-                    // editing a non-saved chart
                     break;
                 }
                 const updatedChartDefinition = {
@@ -40,13 +38,6 @@ class ChartingService {
         this.api.internalApi.dispatchReduxAction(InternalRedux.ChartingSetCurrentChartModels(models));
         this.emitAdaptableChartDefinitonChange();
     }
-    /**
-     * Emit events only for adaptable charting definition changes
-     * - an adaptable chart opens
-     * - an adaptable chart closes
-     * - an adaptable chart is created
-     * - an adaptable chart is deleted
-     */
     emitAdaptableChartDefinitonChange() {
         const chartingOpenState = this.api.chartingApi.getChartingOpenState();
         const chartChangedInfo = {

package/src/Utilities/Services/DataService.js

@@ -5,7 +5,6 @@ const tslib_1 = require("tslib");
 const Emitter_1 = tslib_1.__importDefault(require("../../Utilities/Emitter"));
 const rxjs_1 = require("rxjs");
 const Helper_1 = tslib_1.__importDefault(require("../Helpers/Helper"));
-// ~ 8 hours
 const MAX_TIMEFRAME_SIZE = 86400000;
 class DataService {
     adaptable;
@@ -62,16 +61,10 @@ class DataService {
         this.adaptable.api.eventApi.internalApi.fireRowChangedEvent(rowDataChangedInfo);
         this.rowDataChangeLogSubject$.next(rowDataChangedInfo);
     }
-    // we need this temporary "shared memory" because the value change and the AG Grid cellChanged event are asynchronous
-    // in the first phase we keep the undone change
     logUndoChange(change) {
         const { primaryKeyValue, column, oldValue, newValue } = change;
         const undoChangeKey = this.getUndoChangeKey(primaryKeyValue, column.columnId, oldValue, newValue);
         this.undoChangeLog.set(undoChangeKey, change);
-        // normally the extractUndoChange() should be executed right after this method
-        // just to be sure that no 'zombie' undo change remains here (if something goes wrong with the undo value change)
-        // we manually extract the change after a 2 seconds
-        // why 2 and not 3 or 1? no good reason, only seems like a reasonable waiting time :)
         const UNDO_WAIT = 2000;
         const timeoutId = setTimeout(() => {
             this.adaptable.logger.warn(`Undo change was not handled within timeout: column="${change.column}", primaryKey="${change.primaryKeyValue}", from=${change.newValue} to=${change.oldValue}.`);
@@ -79,10 +72,8 @@ class DataService {
         }, UNDO_WAIT);
         this.undoChangeTimers.set(undoChangeKey, timeoutId);
     }
-    // in the second phase, when AG-Grid triggers the cellChange event, we check if it corresponds to an undone change
     extractUndoChange(change) {
         const { primaryKeyValue, column, oldValue, newValue } = change;
-        // this is post-undo, so we have to swap the new & old values
         const undoChangeKey = this.getUndoChangeKey(primaryKeyValue, column.columnId, newValue, oldValue);
         const result = this.undoChangeLog.get(undoChangeKey);
         this.undoChangeLog.delete(undoChangeKey);
@@ -101,11 +92,9 @@ class DataService {
         });
     }
     extractDataChangeLogEntry(cellDataChangedInfo) {
-        // create rowData snapshot
         const rowData = cellDataChangedInfo.rowData
             ? Helper_1.default.cloneObject(cellDataChangedInfo.rowData)
             : null;
-        // strip down rowNode properties as it is pretty "heavy" on the memory
         const rowNode = rowData ? { data: rowData } : null;
         return {
             ...cellDataChangedInfo,

package/src/Utilities/Services/Fdc3Service.js

@@ -11,7 +11,6 @@ class Fdc3Service {
     uiControlsDefaultConfiguration;
     constructor(adaptableApi) {
         this.adaptableApi = adaptableApi;
-        // 1. Subscribe to FDC3 events
         const adaptableHandleIntentFn = this.getFdc3Options().intents?.handleIntent;
         const listenForIntents = this.getFdc3Options().intents?.listensFor ?? [];
         if (listenForIntents.length) {
@@ -72,7 +71,6 @@ class Fdc3Service {
                     .then((listener) => this.contextHandlerSubscriptions.push(listener));
             });
         }
-        // 2. Init UI Controls default configuration
         this.uiControlsDefaultConfiguration = this.buildUiControlsDefaultConfiguration();
     }
     getUiControlsDefaultConfiguration() {
@@ -193,7 +191,6 @@ class Fdc3Service {
             };
             return intentsMapping;
         }, {});
-        // merge adaptable defaults with (optional) user provided configuration
         return {
             contexts: {
                 ...adaptableDefaultContextIcons,

package/src/Utilities/Services/FlashingCellService.js

@@ -2,14 +2,9 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.FlashingCellService = exports.FLASHING_CELL_ROW_KEY = void 0;
 exports.FLASHING_CELL_ROW_KEY = '__ROW';
-/**
- * This service manages Flashing Cells
- */
 class FlashingCellService {
     api;
-    // map of rowPrimaryKey -> ColIdOrRowId -> FlashingCellUuid
     gridCellsCurrentlyFlashing;
-    // map of FlashingCellUuid -> FlashingCell
     flashingCellsMapping;
     constructor(api) {
         this.api = api;
@@ -40,7 +35,6 @@ class FlashingCellService {
         if (flashingCell.flashTarget === 'row' || flashingCell.flashTarget.includes('row')) {
             columnIds.push(exports.FLASHING_CELL_ROW_KEY);
         }
-        // for high frequency rates, we might have multiple flashes for the same cell
         if (this.gridCellsCurrentlyFlashing[rowPrimaryKey]) {
             columnIds.forEach((colId) => {
                 if (this.gridCellsCurrentlyFlashing[rowPrimaryKey][colId] === flashingCell.Uuid) {

package/src/Utilities/Services/ModuleService.js

@@ -25,11 +25,8 @@ class ModuleService {
         return module.isModuleEditable();
     }
     logMissingAgGridDepsInfos() {
-        // log missing core (required) AG Grid dependencies
         const agGridModulesAdapter = this.adaptableApi.internalApi.getAgGridModulesAdapter();
         if (agGridModulesAdapter.isAgGridModuleRegistered('AllEnterpriseModule')) {
-            // no need to check further if AllEnterprise is registered
-            // it may even trigger false positives (e.g. when using SSRM)
             return;
         }
         const mandatoryAgGridModuleNames = agGridModulesAdapter.getMandatoryAgGridModuleNames();
@@ -38,7 +35,6 @@ class ModuleService {
         if (missingAgGridModuleNames.length) {
             this.adaptableApi.consoleError(`Adaptable requires these AG Grid modules: ${missingAgGridModuleNames.join(', ')}. Please register them. See: ${DocumentationLinkConstants_1.AgGridRequiredModulesDocsLink}`);
         }
-        // log optional missing AG Grid dependencies for all modules
         this.getModuleCollection().forEach((adaptableModule) => {
             adaptableModule.logMissingAgGridDepsInfos();
         });
@@ -60,7 +56,6 @@ class ModuleService {
                 }
             }
         });
-        // store Settings Panel items in Internal State as they never change and we often re-use
         this.adaptableApi.internalApi.setSettingsPanelItems(settingsPanelItems);
     }
     createModuleButtonsForDashboardAndToolPanel() {
@@ -73,7 +68,6 @@ class ModuleService {
                 }
             }
         });
-        // store Dashboard Buttons in Internal State as they never change l
         this.adaptableApi.internalApi.setDashboardModuleButtons(moduleButtons);
     }
     getTeamSharingAction(adaptableModule) {
@@ -84,7 +78,6 @@ class ModuleService {
         return module.getTeamSharingAction();
     }
     getModuleById(adaptableModule) {
-        // @ts-ignore TODO: make modules generic
         return this.getModuleCollection().get(adaptableModule);
     }
     getModuleInfoByModule(adaptableModule) {
@@ -188,7 +181,6 @@ class ModuleService {
         }
     }
     destroy() {
-        // TO DO
     }
 }
 exports.ModuleService = ModuleService;

package/src/Utilities/Services/QueryLanguageService.js

@@ -24,7 +24,6 @@ class QueryLanguageService {
     }
     evaluateBooleanExpression(expression, module, rowNode, evalContext) {
         if (expression == undefined) {
-            // should never happen, but just in case
             this.adaptableApi.logError('QueryLanguageService.evaluateBooleanExpression was called with an undefined expression');
             return false;
         }
@@ -41,13 +40,12 @@ class QueryLanguageService {
         });
     }
     evaluateScalarExpression(expression, module, rowNode) {
-        // currently scalar and boolean expressions are evaluated the same
         return this.evaluateBooleanExpression(expression, module, rowNode);
     }
     evaluateAggregatedScalarExpression(expression, module, getRowNodes) {
         const aggregatedScalarFunctions = this.getModuleExpressionFunctionsMap(module).aggregatedScalarFunctions;
         return parser.evaluate(expression, {
-            node: null, // no node as this is an aggregation query
+            node: null,
             functions: aggregatedScalarFunctions,
             evaluateCustomQueryVariable: this.evaluateCustomQueryVariable,
             getRowNodes,
@@ -94,7 +92,6 @@ class QueryLanguageService {
                 return result;
             }
             const force = config?.force ?? false;
-            // see if validation should be performed
             if (!this.adaptableApi.optionsApi.getExpressionOptions().performExpressionValidation &&
                 !force) {
                 const result = { isValid: true, errorMessage: '' };
@@ -196,7 +193,6 @@ class QueryLanguageService {
                 this.cacheAggregatedBooleanValidation.set(cacheKey, result);
                 return result;
             }
-            // no exception,so everything seems to be fine
             const result = { isValid: true, errorMessage: '' };
             this.cacheAggregatedBooleanValidation.set(cacheKey, result);
             return result;
@@ -234,7 +230,6 @@ class QueryLanguageService {
                 this.cacheAggregatedScalarValidation.set(cacheKey, result);
                 return result;
             }
-            // no exception,so everything seems to be fine
             const result = { isValid: true, errorMessage: '' };
             this.cacheAggregatedScalarValidation.set(cacheKey, result);
             return result;
@@ -272,12 +267,9 @@ class QueryLanguageService {
             const columnFriendlyName = this.adaptableApi.columnApi.getFriendlyNameForColumnId(columnId);
             result = result.split(columnId).join(columnFriendlyName);
         });
-        // replace $SCOPE() with friendly name as well
         result = result.split(`$SCOPE()`).join(`$Column_Scope`);
         return result;
     }
-    // Returns the ExpressionFunctions available for the given Module as specified in the `QueryLanguageOptions.moduleExpressionFunctions`
-    // if there are no specific functions defined, it falls back to the default values
     getModuleExpressionFunctionsMap(module) {
         const expressionOptions = this.adaptableApi.optionsApi.getExpressionOptions();
         if (module) {
@@ -289,10 +281,7 @@ class QueryLanguageService {
         const generalBooleanExpressionFunctions = this.extractMappedExpressionFunctions(booleanExpressionFunctions_1.booleanExpressionFunctions, expressionOptions.systemBooleanFunctions, expressionOptions.customBooleanFunctions);
         const generalScalarExpressionFunctions = this.extractMappedExpressionFunctions(scalarExpressionFunctions_1.scalarExpressionFunctions, expressionOptions.systemScalarFunctions, expressionOptions.customScalarFunctions);
         const generalObservableExpressionFunctions = this.extractMappedExpressionFunctions(observableExpressionFunctions_1.observableExpressionFunctions, expressionOptions.systemObservableFunctions);
-        const generalAggregatedBooleanExpressionFunctions = this.extractMappedExpressionFunctions(aggregatedBooleanExpressionFunctions_1.aggregatedBooleanExpressionFunctions, expressionOptions.systemAggregatedBooleanFunctions, 
-        // right now the custom aggregated scalar functions are used in the aggregated boolean functions as well
-        // hopefully we'll simplify this in the future
-        this.getCustomAggregatedScalarFunctions());
+        const generalAggregatedBooleanExpressionFunctions = this.extractMappedExpressionFunctions(aggregatedBooleanExpressionFunctions_1.aggregatedBooleanExpressionFunctions, expressionOptions.systemAggregatedBooleanFunctions, this.getCustomAggregatedScalarFunctions());
         const generalAggregatedScalarExpressionFunctions = this.extractMappedExpressionFunctions(aggregatedScalarExpressionFunctions_1.aggregatedScalarExpressionFunctions, expressionOptions.systemAggregatedScalarFunctions, this.getCustomAggregatedScalarFunctions());
         if (!module) {
             this.adaptableApi.logWarn(`QueryLanguageService.getModuleExpressionFunctions() was called with an undefined 'module' param, this should never happen`);
@@ -358,11 +347,9 @@ class QueryLanguageService {
                     const groupByColumnIds = groupByParameter?.value;
                     const contextArgs = args.filter((arg) => {
                         if (typeof arg === 'object' && arg.name === 'COL') {
-                            // filter out aggregation column
                             return arg.value !== aggColumnId;
                         }
                         if (typeof arg === 'object' && arg.name === 'GROUP_BY') {
-                            // filter out groupBy column
                             return false;
                         }
                         return true;
@@ -381,7 +368,6 @@ class QueryLanguageService {
                                             index: dataIndex,
                                             rowNode,
                                             args: contextArgs.map((arg) => {
-                                                // if col, replace with value
                                                 if (typeof arg === 'object' && arg.name === 'COL') {
                                                     return getValueForColId(arg.value, rowNode);
                                                 }
@@ -418,7 +404,6 @@ class QueryLanguageService {
                                     aggregatedValue: aggregationValue,
                                     ...this.adaptableApi.internalApi.buildBaseContext(),
                                     args: contextArgs.map((arg) => {
-                                        // if col, replace with value
                                         if (typeof arg === 'object' && arg.name === 'COL') {
                                             return getValueForColId(arg.value, rowNode);
                                         }
@@ -438,7 +423,6 @@ class QueryLanguageService {
                                     rowNode,
                                     ...this.adaptableApi.internalApi.buildBaseContext(),
                                     args: contextArgs.map((arg) => {
-                                        // if col, replace with value
                                         if (typeof arg === 'object' && arg.name === 'COL') {
                                             return getValueForColId(arg.value, rowNode);
                                         }
@@ -477,16 +461,13 @@ class QueryLanguageService {
             })
             : systemFunctions;
         let generalExpressionFunctions = {};
-        // add system functions
         if (Array.isArray(systemFunctionNames)) {
-            // add only system functions specified by user
             systemFunctionNames.forEach((systemFunctionName) => {
                 generalExpressionFunctions[systemFunctionName] =
                     availableExpressionFunctions[systemFunctionName];
             });
         }
         else {
-            // add ALL system functions
             generalExpressionFunctions = { ...availableExpressionFunctions };
         }
         const customFunctionDefinitions = typeof customFunctions === 'function'
@@ -522,7 +503,6 @@ class QueryLanguageService {
     getNodesFromExpression(input, nodeType) {
         try {
             const resultSet = new Set();
-            // @ts-ignore
             const walk = (node) => {
                 if (typeof node !== 'object') {
                     return false;
@@ -551,9 +531,6 @@ class QueryLanguageService {
         if (!queryNodes.length) {
             return;
         }
-        // circular QUERY references can only be detected by actually evaluating the expression
-        // we just evaluate against the first row, as we don't care about the result, just about
-        // whether an exception is thrown
         const firstRowNode = this.adaptableApi.gridApi.getFirstRowNode();
         queryNodes.forEach((queryNode) => {
             this.evaluateBooleanExpression(`QUERY("${queryNode}")`, module, firstRowNode);

package/src/Utilities/Services/RowFormService.js

@@ -44,7 +44,6 @@ class RowFormService {
         }
     }
     destroy() {
-        // nothing yet
     }
 }
 exports.RowFormService = RowFormService;

package/src/Utilities/Services/RowSummaryService.js

@@ -10,9 +10,6 @@ const AggregatedScalarLiveValue_1 = require("./AggregatedScalarLiveValue");
 const ObjectExtensions_1 = require("../Extensions/ObjectExtensions");
 const TimingHelper_1 = require("../Helpers/TimingHelper");
 const ObjectExtensions_2 = require("../Extensions/ObjectExtensions");
-/**
- * The logic is extracted here to make it easier to follow
- */
 class RowSummaryService {
     api;
     cachedCellSummary = new Map();
@@ -25,11 +22,9 @@ class RowSummaryService {
         this.rowSummariesSubscriptions();
     }
     rowSummariesSubscriptions() {
-        // return;
         if (this.api.isDestroyed()) {
             return;
         }
-        // Currently not available for serverside model
         if (!this.api.layoutApi.internalApi.getLayoutSupportedFeatures().RowSummaries) {
             return;
         }
@@ -49,18 +44,15 @@ class RowSummaryService {
             });
         });
         this.api.eventApi.on('LayoutChanged', (event) => {
-            // exclude filter events, those are handled in another event
             if (event.actionName.includes('FILTER')) {
                 return;
             }
             setTimeout(() => {
-                // the timeout is added so the grid has time to repond to the layout changed
                 this.throttledEvaluateRowSummary();
             }, 16);
         });
         const adaptable = this.api.internalApi.getAdaptableInstance();
         adaptable._on('AdapTableFiltersApplied', () => {
-            // we need to use this instead of layout changed so the rows have time to update
             this.throttledEvaluateRowSummary();
         });
         adaptable._on('FirstDataRendered', () => {
@@ -74,10 +66,6 @@ class RowSummaryService {
         }
         this._throttledEvaluateRowSummary(reason);
     }
-    /**
-     *
-     * @param colId optional to evaluate only one column
-     */
     _throttledEvaluateRowSummary = (0, TimingHelper_1.throttle)(this.evaluateRowSummary, 300);
     evaluateRowSummary(reason) {
         if (this._throttleAcumulatedColumnsThatChanged.size > 0) {
@@ -92,11 +80,7 @@ class RowSummaryService {
         }
         const currentLayout = this.api.layoutApi.getCurrentLayout();
         let previousLayout = this.previousLayout;
-        // it is added here to be sure it is saved
         this.previousLayout = currentLayout;
-        /**
-         * If the previous & current layout does not have row summaries, it is safe to exit
-         */
         if ((0, ObjectExtensions_1.isObjectEmpty)(currentLayout?.RowSummaries) && (0, ObjectExtensions_1.isObjectEmpty)(previousLayout?.RowSummaries)) {
             return;
         }
@@ -108,9 +92,7 @@ class RowSummaryService {
         const rowSummariesResults = rowSummaries
             .filter((rowSummary) => !rowSummary.IsSuspended)
             .map((rowSummary, index) => {
-            const { ColumnsMap, Position, 
-            // it defaults to true
-            IncludeOnlyFilteredRows = true, } = rowSummary;
+            const { ColumnsMap, Position, IncludeOnlyFilteredRows = true, } = rowSummary;
             return {
                 Position,
                 RowData: Object.entries(ColumnsMap ?? {}).reduce((acc, [columnId, expression]) => {
@@ -121,7 +103,6 @@ class RowSummaryService {
                     let expressionLiveValue = this.cachedCellSummary.get(key);
                     if (expressionLiveValue) {
                         if (!reason) {
-                            // refresh all of them
                             expressionLiveValue.refresh();
                         }
                         else if ('columnIds' in reason && reason.columnIds.includes(columnId)) {

package/src/Utilities/Services/TeamSharingService.js

@@ -12,7 +12,6 @@ class TeamSharingService {
         this.adaptableApi = adaptableApi;
         const teamSharingOptions = adaptableApi.optionsApi.getTeamSharingOptions();
         if (teamSharingOptions.updateInterval > 0) {
-            // convert minutes to millis
             const updateInterval = teamSharingOptions.updateInterval * 60000;
             this.updateCheckTimerId = setInterval(() => {
                 this.adaptableApi.teamSharingApi.checkForUpdates();
@@ -48,7 +47,6 @@ class TeamSharingService {
     updateActiveSharedEntity(changedAdaptableObject, userName, sharedEntities) {
         let activeSharedEntity = sharedEntities.find((sharedEntity) => sharedEntity.Type === 'Active' && sharedEntity.Entity.Uuid === changedAdaptableObject.Uuid);
         if (!activeSharedEntity) {
-            // shared entity may have been removed in the meantime
             return [sharedEntities, []];
         }
         activeSharedEntity = {
@@ -58,16 +56,13 @@ class TeamSharingService {
             ChangedBy: userName,
             Revision: activeSharedEntity.Revision + 1,
         };
-        // update EntityDependencyIds (references may have been removed or new ones added)
         const updatedEntityDependencyIds = [];
         const currentEntityDependencies = this.getSharedEntityDependencies(activeSharedEntity, sharedEntities);
         const newTeamSharingReferences = this.getTeamSharingReferences(changedAdaptableObject, activeSharedEntity.Module);
         const newReferenceAdaptableObjectIds = newTeamSharingReferences.map((reference) => reference.Reference.Uuid);
-        // 1. add all the existing dependencies which are still referenced
         updatedEntityDependencyIds.push(...currentEntityDependencies
             .filter((entityDependency) => newReferenceAdaptableObjectIds.includes(entityDependency.Entity.Uuid))
             .map((entity) => entity.Uuid));
-        // 2. check if there are new references which are not yet shared
         const freshReferences = newTeamSharingReferences.filter((reference) => !currentEntityDependencies
             .map((entityDependency) => entityDependency.Entity.Uuid)
             .includes(reference.Reference.Uuid));
@@ -87,7 +82,6 @@ class TeamSharingService {
     }
     buildSharedEntityImportActions(importedSharedEntity) {
         let configOverwriteNeedsConfirmation = false;
-        // either ADD or EDIT(in which case the user will need to confirm the overwrite)
         const getSharedEntityImportAction = (sharedEntity) => {
             const { Module, Entity } = sharedEntity;
             const importInfo = this.adaptableApi.internalApi
@@ -213,7 +207,6 @@ class TeamSharingService {
         clearTimeout(this.updateCheckTimerId);
     }
     createSharedEntity(adaptableObject, module, configuration, sharingUserName, sharingTimestamp, createdSharedEntities) {
-        // create main shared entity
         const mainSharedEntity = {
             EntityType: 'adaptableEntity',
             Uuid: (0, Uuid_1.createUuid)(),
@@ -228,29 +221,21 @@ class TeamSharingService {
             Revision: 1,
             Type: configuration.type,
         };
-        // load all dependencies (special cols, shared queries etc)
         const teamSharingDependencies = this.getTeamSharingReferences(adaptableObject, module);
-        // for every dependency, create recursively the corresponding shared entities
         teamSharingDependencies.forEach((teamSharingDependency) => {
             const sharedEntityDependency = this.createSharedEntity(teamSharingDependency.Reference, teamSharingDependency.Module, configuration, sharingUserName, sharingTimestamp, createdSharedEntities);
-            // update dependency IDs for the main shared entity
             mainSharedEntity.EntityDependencyIds.push(sharedEntityDependency.Uuid);
         });
-        // add main shared entity to the accumulator
         createdSharedEntities.push(mainSharedEntity);
         return mainSharedEntity;
     }
-    // returns the given rootSharedEntity with all its unique dependencies in their dependency order
     getSharedEntityDependencyTree(rootSharedEntity, allSharedEntities) {
-        // using a map to handle the case where a SharedEntity occurs multiple times in the dependency tree
         const result = new Map();
         result.set(rootSharedEntity.Uuid, rootSharedEntity);
         rootSharedEntity.EntityDependencyIds.forEach((dependencyId) => {
             const dependencySharedEntity = allSharedEntities.find((sharedEntity) => sharedEntity.Uuid === dependencyId);
-            // check for zombie dependencies (possible if state is inconsistent due to dirty reads)
             if (dependencySharedEntity) {
                 this.getSharedEntityDependencyTree(dependencySharedEntity, allSharedEntities).forEach((childDependency) => {
-                    // check if this dependency is not already present in the dependency tree
                     if (!result.has(childDependency.Uuid)) {
                         result.set(childDependency.Uuid, childDependency);
                     }