@7365admin1/module-hygiene 4.29.0 → 4.30.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@7365admin1/module-hygiene",
   "license": "MIT",
-  "version": "4.29.0",
+  "version": "4.30.0",
   "author": "7365admin1",
   "main": "dist/index.js",
   "module": "dist/index.mjs",

package/test/require-photo-on-completion.test.mjs

@@ -0,0 +1,160 @@
+/*
+ * A PHOTO IS REQUIRED TO COMPLETE A TASK.
+ *
+ * Owner requirement, 2026-09-10: "once task was completed they required to take
+ * photo before completing the task ... all the services that has this module
+ * must be the same process."
+ *
+ * This endpoint is where every service and every client meets. The five field
+ * apps — M&E, Cleaning, Landscape, Pest, Pool — all PATCH
+ * `/api/hygiene-area-checklist/id/:id/set/:set/units/:unit/:decision` with a
+ * `serviceType`, and the web checklist posts here too. Enforcing it here is what
+ * makes "the same process" true, rather than five client guards that drift.
+ *
+ * The rule is exercised against the SHIPPED Joi schema, lifted out of the
+ * controller — not a re-typed copy, so a change to the real validation fails
+ * this file.
+ */
+import test from "node:test";
+import assert from "node:assert/strict";
+import { readFileSync } from "node:fs";
+import Joi from "joi";
+
+const SRC = readFileSync(
+  new URL("../src/controllers/hygiene-area-checklist.controller.ts", import.meta.url),
+  "utf8",
+);
+
+/** The validation object from `updateAreaChecklistUnits`, evaluated for real. */
+function schema() {
+  const fn = SRC.slice(SRC.indexOf("async function updateAreaChecklistUnits("));
+  const start = fn.indexOf("const validation = Joi.object({");
+  assert.notEqual(start, -1, "the validation block is gone");
+
+  // Walk braces from the opening `{` of Joi.object( ... ) to its match.
+  const open = fn.indexOf("{", start + "const validation = Joi.object(".length);
+  let depth = 0;
+  let end = -1;
+  for (let i = open; i < fn.length; i++) {
+    if (fn[i] === "{") depth++;
+    else if (fn[i] === "}") {
+      depth--;
+      if (depth === 0) {
+        end = i;
+        break;
+      }
+    }
+  }
+  assert.notEqual(end, -1, "could not read the validation block");
+
+  const body = fn
+    .slice(open, end + 1)
+    .replace(/\/\*[\s\S]*?\*\//g, "")
+    .replace(/\/\/[^\n]*/g, "");
+  return new Function("Joi", `return Joi.object(${body});`)(Joi);
+}
+
+const base = {
+  id: "6923d6664150ca6a69b9f2b2",
+  set: 1,
+  unit: "69251faf8c8936c9e6ebf095",
+  completedBy: "6925a31630abdbb211ecd9a8",
+  remarks: "done",
+};
+
+const validate = (payload) => schema().validate(payload);
+
+/* ── completing requires evidence ──────────────────────────────────────── */
+
+test("approving WITHOUT a photo is refused", () => {
+  const { error } = validate({ ...base, decision: "approve", approve: true });
+  assert.ok(error, "a task was completed with no photo");
+  assert.match(error.message, /photo is required/i);
+});
+
+test("an EMPTY attachment array is refused too", () => {
+  // This is the shape a client sends when its uploader failed — it satisfies
+  // `.optional()` while carrying no evidence at all.
+  const { error } = validate({
+    ...base,
+    decision: "approve",
+    approve: true,
+    attachment: [],
+  });
+  assert.ok(error, "an empty attachment list was accepted as evidence");
+  assert.match(error.message, /photo is required/i);
+});
+
+test("a BLANK id is not a photo", () => {
+  const { error } = validate({
+    ...base,
+    decision: "approve",
+    approve: true,
+    attachment: [""],
+  });
+  assert.ok(error, "a blank attachment id counted as a photo");
+});
+
+test("approving WITH a photo is accepted", () => {
+  const { error } = validate({
+    ...base,
+    decision: "approve",
+    approve: true,
+    attachment: ["68f05fbe0c11062938dadad9"],
+  });
+  assert.equal(error, undefined, error?.message);
+});
+
+test("MULTIPLE photos are accepted — that is the point", () => {
+  const { error } = validate({
+    ...base,
+    decision: "approve",
+    approve: true,
+    attachment: ["a1", "b2", "c3", "d4"],
+  });
+  assert.equal(error, undefined, error?.message);
+});
+
+/* ── rejecting must NOT be blocked ─────────────────────────────────────── */
+
+test("REJECTING without a photo is still allowed", () => {
+  /*
+   * A reject is the technician reporting a problem. Demanding a photograph
+   * before somebody can report one would stop them reporting it.
+   */
+  const { error } = validate({ ...base, decision: "reject", reject: true });
+  assert.equal(error, undefined, error?.message);
+});
+
+test("rejecting WITH photos is still allowed", () => {
+  const { error } = validate({
+    ...base,
+    decision: "reject",
+    reject: true,
+    attachment: ["a1", "b2"],
+  });
+  assert.equal(error, undefined, error?.message);
+});
+
+/* ── controls ──────────────────────────────────────────────────────────── */
+
+test("CONTROL: the other required fields still are", () => {
+  // Without this, the assertions above could pass against a schema that
+  // validates nothing.
+  for (const missing of ["id", "unit", "completedBy"]) {
+    const payload = {
+      ...base,
+      decision: "approve",
+      approve: true,
+      attachment: ["a1"],
+    };
+    delete payload[missing];
+    assert.ok(validate(payload).error, `${missing} is no longer required`);
+  }
+});
+
+test("CONTROL: the message names the action a person must take", () => {
+  // "Invalid payload" tells a technician standing in a plant room nothing.
+  const { error } = validate({ ...base, decision: "approve", approve: true });
+  assert.match(error.message, /take or upload at least one photo/i);
+});