@7365admin1/module-hygiene 4.29.0 → 4.30.0

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @7365admin1/module-hygiene
 
+## 4.30.0
+
+### Minor Changes
+
+- dea5edb: Require a photo to complete a checklist task.
+
+  `attachment` is now required, with at least one non-blank id, when the decision
+  is `approve`. This endpoint is where every service and every client meets — the
+  five field apps and the web checklist all post here — so enforcing it here is
+  what makes the rule the same for all of them.
+
+  Rejecting is deliberately unaffected: a reject is a technician reporting a
+  problem, and demanding a photograph first would stop them reporting it.
+
 ## 4.29.0
 
 ### Minor Changes

package/dist/index.js

@@ -5074,7 +5074,37 @@ function useAreaChecklistController() {
       approve: import_joi9.default.boolean().optional(),
       reject: import_joi9.default.boolean().optional(),
       remarks: import_joi9.default.string().optional().allow("", null),
-      attachment: import_joi9.default.array().items(import_joi9.default.string()).optional(),
+      /*
+       * A PHOTO IS REQUIRED TO COMPLETE A TASK.
+       *
+       * Owner requirement, 2026-09-10: *"once task was completed they required
+       * to take photo before completing the task ... all the services that has
+       * this module must be the same process."*
+       *
+       * This endpoint is the one place every service and every client meets:
+       * the five field apps (M&E, Cleaning, Landscape, Pest, Pool) all PATCH
+       * `/api/hygiene-area-checklist/...` with a `serviceType`, and the web
+       * checklist (`layer-common ManageChecklistMain`) posts here too. Requiring
+       * it here is what makes "the same process" true rather than five client
+       * guards that can drift apart — and a client guard alone is a suggestion.
+       *
+       * ONLY ON APPROVE. Completing a unit is the act the evidence is for.
+       * A REJECT is the technician reporting a problem, and demanding a
+       * photograph before somebody can report one would stop them reporting it.
+       * `decision` carries which is which.
+       *
+       * At least one entry, and each must be a real id — an empty array or a
+       * blank string would satisfy `.optional()` while carrying no evidence at
+       * all, which is the shape a client sends when its uploader failed.
+       */
+      attachment: import_joi9.default.array().items(import_joi9.default.string().trim().min(1)).when("decision", {
+        is: "approve",
+        then: import_joi9.default.array().min(1).required().messages({
+          "array.min": "A photo is required to complete this task. Take or upload at least one photo before marking it complete.",
+          "any.required": "A photo is required to complete this task. Take or upload at least one photo before marking it complete."
+        }),
+        otherwise: import_joi9.default.array().optional()
+      }),
       completedBy: import_joi9.default.string().hex().required()
     });
     const { error } = validation.validate(payload);