@1agh/maude 1.0.9 → 1.2.0

package/apps/studio/test/artboard-guides-overlay.test.tsx

@@ -1,152 +0,0 @@
-// artboard-guides-overlay — feature-1-artboard-kinds-foundation, T4.
-// Registry contract + generic guides rendering. Pure renderToStaticMarkup —
-// this component has no hooks/context, so (unlike DCArtboard's own overlays)
-// it renders fully outside a live DesignCanvas.
-
-import { afterEach, describe, expect, test } from 'bun:test';
-
-import { renderToStaticMarkup } from 'react-dom/server';
-
-import {
-  __resetKindOverlayRegistryForTests,
-  ArtboardGuidesOverlay,
-  registerKindOverlay,
-} from '../artboard-guides-overlay.tsx';
-
-const RECT = { x: 10, y: 20, w: 400, h: 200 };
-
-afterEach(() => {
-  __resetKindOverlayRegistryForTests();
-});
-
-describe('ArtboardGuidesOverlay — generic guides', () => {
-  test('renders nothing with no guides and no registered kind content', () => {
-    const html = renderToStaticMarkup(
-      <ArtboardGuidesOverlay rect={RECT} kind="digital" visibility={{}} />
-    );
-    expect(html).toBe('');
-  });
-
-  test('positions the overlay at the artboard world rect', () => {
-    const html = renderToStaticMarkup(
-      <ArtboardGuidesOverlay
-        rect={RECT}
-        kind="print"
-        guides={{ grid: { size: 40 } }}
-        visibility={{ guides: true }}
-      />
-    );
-    expect(html).toMatch(/left:\s*10px/);
-    expect(html).toMatch(/top:\s*20px/);
-    expect(html).toMatch(/width:\s*400px/);
-    expect(html).toMatch(/height:\s*200px/);
-    expect(html).toContain('aria-hidden="true"');
-    expect(html).toContain('pointer-events:none');
-  });
-
-  test('visibility.guides === false suppresses the generic guides', () => {
-    const html = renderToStaticMarkup(
-      <ArtboardGuidesOverlay
-        rect={RECT}
-        kind="print"
-        guides={{ grid: { size: 40 } }}
-        visibility={{ guides: false }}
-      />
-    );
-    expect(html).toBe('');
-  });
-
-  test('columns render as one band per column, respecting margin/gutter', () => {
-    const html = renderToStaticMarkup(
-      <ArtboardGuidesOverlay
-        rect={RECT}
-        kind="web"
-        guides={{ columns: { count: 4, gutter: 10, margin: 20 } }}
-        visibility={{ guides: true }}
-      />
-    );
-    // usable = 400 - 2*20 = 360; (360 - 3*10) / 4 = 82.5px per column, 4 bands.
-    const bandCount = (html.match(/width:82\.5px/g) || []).length;
-    expect(bandCount).toBe(4);
-  });
-
-  // Security review (defender + adversarial pass, /flow:done on 0e001da7) —
-  // columns/rows `count` had no cap, unlike the grid path: a malicious/
-  // poisoned canvas (guides is an authored JSX prop, part of the DDR-054
-  // untrusted-canvas surface) could set `columns.count` to a huge number and
-  // mount one <div> per band, freezing the viewer's tab. Regression-tests the
-  // MAX_BANDS_PER_AXIS clamp both independent reviews confirmed as the fix.
-  test('a pathologically large column count is clamped, never a runaway render', () => {
-    const html = renderToStaticMarkup(
-      <ArtboardGuidesOverlay
-        rect={RECT}
-        kind="web"
-        guides={{ columns: { count: 1_000_000_000, gutter: 0, margin: 0 } }}
-        visibility={{ guides: true }}
-      />
-    );
-    const bandCount = (html.match(/position:absolute/g) || []).length - 1; // minus the wrapper div
-    expect(bandCount).toBeLessThanOrEqual(64);
-    expect(bandCount).toBeGreaterThan(0);
-  });
-
-  test('a pathologically large row count is clamped the same way', () => {
-    const html = renderToStaticMarkup(
-      <ArtboardGuidesOverlay
-        rect={RECT}
-        kind="web"
-        guides={{ rows: { count: 999_999_999, gutter: 0, margin: 0 } }}
-        visibility={{ guides: true }}
-      />
-    );
-    const bandCount = (html.match(/position:absolute/g) || []).length - 1;
-    expect(bandCount).toBeLessThanOrEqual(64);
-    expect(bandCount).toBeGreaterThan(0);
-  });
-
-  test('grid lines are capped, never runaway for a degenerate small size', () => {
-    const html = renderToStaticMarkup(
-      <ArtboardGuidesOverlay
-        rect={{ x: 0, y: 0, w: 5000, h: 5000 }}
-        kind="digital"
-        guides={{ grid: { size: 2 } }}
-        visibility={{ guides: true }}
-      />
-    );
-    const lineCount = (html.match(/width:1px/g) || []).length;
-    expect(lineCount).toBeLessThanOrEqual(400);
-  });
-});
-
-describe('ArtboardGuidesOverlay — per-kind registry', () => {
-  test('registered kind renderer is invoked with rect/kind/guides/visibility', () => {
-    let seen: unknown;
-    registerKindOverlay('print', (props) => {
-      seen = props;
-      return <div data-testid="print-bleed" />;
-    });
-    const html = renderToStaticMarkup(
-      <ArtboardGuidesOverlay rect={RECT} kind="print" visibility={{ bleed: true }} />
-    );
-    expect(html).toContain('data-testid="print-bleed"');
-    expect(seen).toMatchObject({ rect: RECT, kind: 'print', visibility: { bleed: true } });
-  });
-
-  test('a renderer registered for one kind does not fire for another', () => {
-    registerKindOverlay('web', () => <div data-testid="breakpoint-band" />);
-    const html = renderToStaticMarkup(
-      <ArtboardGuidesOverlay rect={RECT} kind="print" visibility={{}} />
-    );
-    expect(html).not.toContain('breakpoint-band');
-  });
-
-  test('re-registering the same kind replaces the previous renderer (HMR-safe)', () => {
-    registerKindOverlay('print', () => <div data-testid="v1" />);
-    registerKindOverlay('print', () => <div data-testid="v2" />);
-    const html = renderToStaticMarkup(
-      <ArtboardGuidesOverlay rect={RECT} kind="print" visibility={{}} />
-    );
-    expect(html).not.toContain('v1');
-    expect(html).toContain('v2');
-  });
-});

package/apps/studio/test/artboard-hug-commit.test.ts

@@ -1,36 +0,0 @@
-// artboard-hug-commit.ts — issue #79. The Artboard Inspector's Height
-// NumberField silently dropped a typed value whenever the artboard was in
-// Hug mode (fixed=false, the default per DDR-027 Design Decision 1) — Width
-// always worked because it has no such mode. Typing a height should instead
-// promote the artboard to Fixed at that height, same as the Hug/Fixed
-// toggle's own freeze-current-height write.
-
-import { describe, expect, test } from 'bun:test';
-
-import { resolveHeightCommit } from '../artboard-hug-commit.ts';
-
-describe('artboard-hug-commit / resolveHeightCommit', () => {
-  test('fixed=true → plain resize (Width-field parity)', () => {
-    expect(resolveHeightCommit(true, 480)).toEqual({ kind: 'resize', height: 480 });
-  });
-
-  test('fixed=false (Hug, the default) → promotes to Fixed at the typed height', () => {
-    // Before the fix this typed value was dropped entirely (no action) —
-    // reproducing "when I want to set height... manually from inspector
-    // panel, nothing happened. Width works."
-    expect(resolveHeightCommit(false, 480)).toEqual({ kind: 'promote-to-fixed', height: 480 });
-  });
-
-  test('rounds a fractional typed value', () => {
-    expect(resolveHeightCommit(true, 480.6)).toEqual({ kind: 'resize', height: 481 });
-    expect(resolveHeightCommit(false, 480.6)).toEqual({ kind: 'promote-to-fixed', height: 481 });
-  });
-
-  test('non-finite or non-positive input → noop, in either mode', () => {
-    expect(resolveHeightCommit(true, Number.NaN)).toEqual({ kind: 'noop' });
-    expect(resolveHeightCommit(true, 0)).toEqual({ kind: 'noop' });
-    expect(resolveHeightCommit(true, -10)).toEqual({ kind: 'noop' });
-    expect(resolveHeightCommit(false, Number.NaN)).toEqual({ kind: 'noop' });
-    expect(resolveHeightCommit(false, 0)).toEqual({ kind: 'noop' });
-  });
-});

package/apps/studio/test/artboard-kinds.test.tsx

@@ -1,83 +0,0 @@
-// artboard-kinds — feature-1-artboard-kinds-foundation, T1/T2.
-//
-// DCArtboard rendered OUTSIDE a DesignCanvas (no WorldContext, no rect) takes
-// the specimen/legacy early-return branch — it still computes + emits the
-// resolved `data-dc-kind` attribute (readBackAttrs is built before the
-// `!ctx || !rect` check), so that resolution logic is testable via
-// renderToStaticMarkup without a live DOM/layout pass. The label-strip kind
-// chip (T3) only renders in the full DesignCanvas layout path (like the
-// video corner badge it sits beside) — covered by /design:smoke, not here
-// (see use-canvas-activity.test.tsx's header comment for the same split).
-
-import { describe, expect, test } from 'bun:test';
-
-import { renderToStaticMarkup } from 'react-dom/server';
-
-import { DCArtboard } from '../canvas-lib.tsx';
-
-// Minimal displayName-only stand-in for VideoComp — subtreeHasVideoComp
-// identity-matches OR falls back to `displayName === 'VideoComp'` (the same
-// fallback minified builds rely on), so this exercises the fallback path
-// without pulling in the real VideoComp's rendering/registration machinery.
-function FakeVideoComp() {
-  return null;
-}
-FakeVideoComp.displayName = 'VideoComp';
-
-describe('DCArtboard kind resolution (data-dc-kind readback)', () => {
-  test('absent kind, no video subtree ⇒ digital', () => {
-    const html = renderToStaticMarkup(
-      <DCArtboard id="a" label="A" width={100} height={100}>
-        hi
-      </DCArtboard>
-    );
-    expect(html).toContain('data-dc-kind="digital"');
-  });
-
-  test('explicit kind="print" is emitted verbatim', () => {
-    const html = renderToStaticMarkup(
-      <DCArtboard id="a" label="A" width={100} height={100} kind="print">
-        hi
-      </DCArtboard>
-    );
-    expect(html).toContain('data-dc-kind="print"');
-  });
-
-  test('explicit kind="web" is emitted verbatim', () => {
-    const html = renderToStaticMarkup(
-      <DCArtboard id="a" label="A" width={100} height={100} kind="web">
-        hi
-      </DCArtboard>
-    );
-    expect(html).toContain('data-dc-kind="web"');
-  });
-
-  test('absent kind + VideoComp subtree ⇒ video fallback (Design Decision 1)', () => {
-    const html = renderToStaticMarkup(
-      <DCArtboard id="a" label="A" width={100} height={100}>
-        <FakeVideoComp />
-      </DCArtboard>
-    );
-    expect(html).toContain('data-dc-kind="video"');
-  });
-
-  test('explicit kind="digital" supersedes a VideoComp subtree', () => {
-    const html = renderToStaticMarkup(
-      <DCArtboard id="a" label="A" width={100} height={100} kind="digital">
-        <FakeVideoComp />
-      </DCArtboard>
-    );
-    expect(html).toContain('data-dc-kind="digital"');
-  });
-
-  test('digital kind (default) carries no other resolved-kind attribute value', () => {
-    const html = renderToStaticMarkup(
-      <DCArtboard id="a" label="A" width={100} height={100}>
-        hi
-      </DCArtboard>
-    );
-    expect(html).not.toContain('data-dc-kind="print"');
-    expect(html).not.toContain('data-dc-kind="web"');
-    expect(html).not.toContain('data-dc-kind="video"');
-  });
-});

package/apps/studio/test/artboard-selection-attrs.test.ts

@@ -1,69 +0,0 @@
-// Dogfood follow-up (print artboards) — whole-ARTBOARD selections must carry
-// the DCArtboard readBack attrs (`data-dc-kind`, `data-dc-print`, `data-dc-
-// fixed`, `data-dc-bg`, …) in `Selection.attrs`, because the Inspector's
-// ArtboardKnobs panel pre-fills its Kind picker / paper preset / Hug toggle /
-// Style fields from exactly these. ATTR_SKIP deliberately hides `data-dc-*`
-// from the generic custom-attributes surface on ORDINARY elements — the bug
-// was that the blanket skip also applied to the artboard element itself, so
-// every readback silently fell back to its default ('digital', screen
-// presets, Hug, empty Bg) no matter what the artboard actually was.
-//
-// Same happy-dom + hoverTargetToSelection harness as knob-props-authored.
-
-import { afterAll, beforeAll, describe, expect, test } from 'bun:test';
-import { GlobalRegistrator } from '@happy-dom/global-registrator';
-
-beforeAll(() => {
-  GlobalRegistrator.register();
-});
-afterAll(() => {
-  GlobalRegistrator.unregister();
-});
-
-import { hoverTargetToSelection } from '../dom-selection.ts';
-import type { HoverTarget } from '../input-router.tsx';
-
-function artboardSelection(attrsHtml: string) {
-  document.body.innerHTML = `<article class="dc-artboard" data-dc-screen="ab-1" ${attrsHtml}><div>content</div></article>`;
-  const el = document.querySelector('[data-dc-screen]') as HTMLElement;
-  const target: HoverTarget = { el, cdId: null, artboardId: 'ab-1' };
-  return hoverTargetToSelection(target);
-}
-
-describe('whole-artboard selection — data-dc-* readback attrs', () => {
-  test('data-dc-kind + data-dc-print reach Selection.attrs (the ArtboardKnobs payload)', () => {
-    const sel = artboardSelection(
-      'data-dc-kind="print" data-dc-print=\'{"paper":"a4","bleedMm":3}\''
-    );
-    expect(sel.attrs?.['data-dc-kind']).toBe('print');
-    expect(sel.attrs?.['data-dc-print']).toBe('{"paper":"a4","bleedMm":3}');
-  });
-
-  test('the other readback attrs come through too (fixed/bg/padding/layout/gap)', () => {
-    const sel = artboardSelection(
-      'data-dc-kind="digital" data-dc-fixed="true" data-dc-bg="var(--bg-1)" data-dc-padding="16" data-dc-layout="flex-col" data-dc-gap="8"'
-    );
-    expect(sel.attrs?.['data-dc-fixed']).toBe('true');
-    expect(sel.attrs?.['data-dc-bg']).toBe('var(--bg-1)');
-    expect(sel.attrs?.['data-dc-padding']).toBe('16');
-    expect(sel.attrs?.['data-dc-layout']).toBe('flex-col');
-    expect(sel.attrs?.['data-dc-gap']).toBe('8');
-  });
-
-  test('an ORDINARY element (no data-dc-screen) keeps the data-dc-* filter', () => {
-    document.body.innerHTML =
-      '<div data-cd-id="bbbbbbbb" data-dc-kind="print" data-custom="yes">x</div>';
-    const el = document.querySelector('[data-cd-id]') as HTMLElement;
-    const target: HoverTarget = { el, cdId: 'bbbbbbbb', artboardId: null };
-    const sel = hoverTargetToSelection(target);
-    // Engine plumbing stays hidden from the generic custom-attributes panel…
-    expect(sel.attrs?.['data-dc-kind']).toBeUndefined();
-    // …while genuinely custom attributes still surface.
-    expect(sel.attrs?.['data-custom']).toBe('yes');
-  });
-
-  test('data-dc-screen itself is included for the artboard (harmless, self-describing)', () => {
-    const sel = artboardSelection('data-dc-kind="print"');
-    expect(sel.attrs?.['data-dc-screen']).toBe('ab-1');
-  });
-});

package/apps/studio/test/asset-api.test.ts

@@ -1,149 +0,0 @@
-// POST /_api/asset — Phase 23 content-addressed image upload (Task 5).
-//
-// Two layers:
-//   (1) the pure magic-byte sniff (`sniffImageType`) — the ONE gate that decides
-//       the stored type; a header lie / SVG is caught here;
-//   (2) the POST endpoint round-trip (boots a real server against a sandbox) —
-//       happy path for all four types, header-lie, oversize, SVG-reject,
-//       content-addressed dedupe, method gate.
-
-import { describe, expect, test } from 'bun:test';
-import { existsSync, readdirSync } from 'node:fs';
-import { join } from 'node:path';
-
-import { ASSET_MAX_BYTES, sniffImageType } from '../api.ts';
-import { bootServer, killProc, makeSandbox, nextPort } from './_helpers.ts';
-
-// ── Minimal valid magic-byte headers (padded so length checks pass). ──────────
-const pad = (header: number[], len = 64): Uint8Array => {
-  const out = new Uint8Array(len);
-  out.set(header, 0);
-  return out;
-};
-const PNG = pad([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a]);
-const JPEG = pad([0xff, 0xd8, 0xff, 0xe0]);
-const GIF = pad([0x47, 0x49, 0x46, 0x38, 0x39, 0x61]); // "GIF89a"
-const WEBP = pad([0x52, 0x49, 0x46, 0x46, 0, 0, 0, 0, 0x57, 0x45, 0x42, 0x50]); // RIFF????WEBP
-const SVG = new TextEncoder().encode('<svg xmlns="http://www.w3.org/2000/svg"><script/></svg>');
-
-describe('asset-api / sniffImageType (the type gate)', () => {
-  test('recognizes each supported raster type by magic bytes', () => {
-    expect(sniffImageType(PNG)).toBe('png');
-    expect(sniffImageType(JPEG)).toBe('jpg');
-    expect(sniffImageType(GIF)).toBe('gif');
-    expect(sniffImageType(WEBP)).toBe('webp');
-  });
-
-  test('rejects SVG / text / empty / truncated headers', () => {
-    expect(sniffImageType(SVG)).toBeNull();
-    expect(sniffImageType(new TextEncoder().encode('not an image'))).toBeNull();
-    expect(sniffImageType(new Uint8Array(0))).toBeNull();
-    // Truncated PNG signature (only 4 of 8 bytes) must NOT match.
-    expect(sniffImageType(new Uint8Array([0x89, 0x50, 0x4e, 0x47]))).toBeNull();
-    // RIFF without the WEBP fourcc (e.g. a WAV) must NOT match.
-    expect(
-      sniffImageType(pad([0x52, 0x49, 0x46, 0x46, 0, 0, 0, 0, 0x57, 0x41, 0x56, 0x45]))
-    ).toBeNull();
-  });
-
-  test('content addresses the stored ext (a .png NAME with GIF bytes sniffs gif)', () => {
-    // The route names the file from sniffImageType(bytes), never the upload name.
-    expect(sniffImageType(GIF)).toBe('gif');
-  });
-});
-
-describe('asset-api / POST /_api/asset (endpoint round-trip)', () => {
-  async function withServer(
-    fn: (port: number, designRoot: string) => Promise<void>,
-    extraEnv?: Record<string, string>
-  ) {
-    const sandbox = makeSandbox();
-    const port = nextPort();
-    const proc = await bootServer(sandbox.root, port, extraEnv);
-    try {
-      await fn(port, sandbox.designRoot);
-    } finally {
-      await killProc(proc);
-    }
-  }
-
-  const postAsset = (port: number, body: Uint8Array, contentType = 'application/octet-stream') =>
-    fetch(`http://localhost:${port}/_api/asset`, {
-      method: 'POST',
-      headers: { 'Content-Type': contentType },
-      body,
-    });
-
-  test('writes a valid PNG/JPEG/WEBP/GIF and returns its assets path', async () => {
-    await withServer(async (port, designRoot) => {
-      for (const [bytes, ext] of [
-        [PNG, 'png'],
-        [JPEG, 'jpg'],
-        [WEBP, 'webp'],
-        [GIF, 'gif'],
-      ] as const) {
-        const res = await postAsset(port, bytes);
-        expect(res.status).toBe(201);
-        const json = (await res.json()) as { path: string };
-        expect(json.path).toMatch(new RegExp(`^assets/[0-9a-f]{8}\\.${ext}$`));
-        expect(existsSync(join(designRoot, json.path))).toBe(true);
-      }
-    });
-  });
-
-  test('a header-lie (declared image/png, GIF bytes) is stored as .gif (sniff wins)', async () => {
-    await withServer(async (port) => {
-      const res = await postAsset(port, GIF, 'image/png');
-      expect(res.status).toBe(201);
-      const json = (await res.json()) as { path: string };
-      expect(json.path.endsWith('.gif')).toBe(true);
-    });
-  });
-
-  test('rejects an SVG upload (no script-bearing vector) with 415', async () => {
-    await withServer(async (port) => {
-      const res = await postAsset(port, SVG, 'image/svg+xml');
-      expect(res.status).toBe(415);
-    });
-  });
-
-  test('rejects an oversize body (> ASSET_MAX_BYTES) with 413', async () => {
-    await withServer(async (port) => {
-      const big = new Uint8Array(ASSET_MAX_BYTES + 1);
-      big.set([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a], 0); // valid PNG header
-      const res = await postAsset(port, big);
-      expect(res.status).toBe(413);
-    });
-  });
-
-  test('identical bytes dedupe to ONE file (content-addressed; disk-fill guard)', async () => {
-    await withServer(async (port, designRoot) => {
-      const a = await (await postAsset(port, PNG)).json();
-      const b = await (await postAsset(port, PNG)).json();
-      expect(a.path).toBe(b.path);
-      const files = readdirSync(join(designRoot, 'assets'));
-      expect(files.length).toBe(1);
-    });
-  });
-
-  test('GET /_api/asset is method-not-allowed (write-only)', async () => {
-    await withServer(async (port) => {
-      const res = await fetch(`http://localhost:${port}/_api/asset`);
-      expect(res.status).toBe(405);
-    });
-  });
-
-  test('enforces the aggregate session write budget (disk-fill guard → 429)', async () => {
-    // Budget = 100 bytes; each padded magic-byte image is 64 bytes. The first
-    // DISTINCT write fits (64); a second distinct image (64) would total 128 >
-    // 100 → rejected. A dedupe hit (same bytes) is free and must NOT count.
-    await withServer(
-      async (port) => {
-        expect((await postAsset(port, PNG)).status).toBe(201); // 64 written
-        expect((await postAsset(port, PNG)).status).toBe(201); // dedupe — free
-        expect((await postAsset(port, JPEG)).status).toBe(429); // 64+64 > 100
-      },
-      { MAUDE_ASSET_SESSION_BUDGET: '100' }
-    );
-  });
-});