@1agh/maude 1.0.9 → 1.2.0

package/apps/studio/test/acp-session-allowed-tools.test.ts

@@ -1,235 +0,0 @@
-// DDR-184 (+ DDR-185, hardened per its security addendum) — the curated tool
-// allow-list the bridge auto-approves so the design workflow never stalls on
-// a per-edit / per-`maude` permission prompt (the "Manual mode blocks every
-// edit" complaint). Three things under test:
-//
-//   (1) WIRE contract — the list lands on `_meta.claudeCode.options.allowedTools`
-//       (SDK `allowedTools`, sdk.d.ts:1331), coexisting with the DDR-144
-//       `settingSources` narrowing and the DDR-143 `plugins` carrier. Same
-//       adapter/SDK-INTERNAL `_meta` path as acp-session-plugins.test.ts — a
-//       bump that stops forwarding it must fail HERE, not silently re-prompt.
-//   (2) SOURCE-OF-TRUTH guard — the Bash rules are EXACTLY `Bash(maude:*)`
-//       plus a closed read-only fs verb set (DDR-185) — nothing else. A
-//       security fan-out found the ORIGINAL DDR-185 cut's `Bash(agent-browser:*)`
-//       entry was a zero-confirmation session-hijack primitive (agent-browser's
-//       own bundled skill recommends a persistent, real-login Chrome profile)
-//       and `Bash(find:*)` was unrestricted command execution via `-exec`, not
-//       "mutation" as first characterized — both are cut, not patched, because
-//       neither residual is fixable via prefix-matching. `agent-browser` is
-//       now reached ONLY through the hardened `agent-browser-safe` verb
-//       (`Bash(maude:*)` covers it — no separate allow-list entry). If any of
-//       this drifts, this test fails loudly.
-//   (3) `WebSearch`/`WebFetch` (DDR-185) are present as bare native tool names
-//       — no prefix-matching involved, so no source-of-truth guard needed the
-//       way the Bash rules need one.
-//   (4) NO WRITE TOOL is on this list (feature-acp-write-path-scope). This
-//       file used to assert the exact opposite — that Edit/Write/NotebookEdit
-//       WERE present — so read the test's own comment before "restoring" it.
-//       Write auto-approval moved into the bridge's path gate, which is the
-//       only place a per-call target path exists; see acp-write-scope.test.ts.
-
-import { describe, expect, test } from 'bun:test';
-import { existsSync, readFileSync, realpathSync } from 'node:fs';
-import { dirname, join } from 'node:path';
-
-import { MAUDE_DEFAULT_ALLOWED_TOOLS, newSessionParams } from '../acp/bridge.ts';
-import type { SdkPluginConfig } from '../acp/plugin-bootstrap.ts';
-import { WRITE_TOOL_NAMES } from '../acp/write-scope.ts';
-
-type Meta = {
-  systemPrompt?: { append?: string };
-  claudeCode?: {
-    options?: {
-      allowedTools?: string[];
-      plugins?: SdkPluginConfig[];
-      settingSources?: string[];
-    };
-  };
-};
-
-const PLUGINS: SdkPluginConfig[] = [
-  { type: 'local', path: '/bundle/plugins/design', skipMcpDiscovery: true },
-];
-
-describe('newSessionParams — allowedTools carrier shape (DDR-184)', () => {
-  test('the allow-list rides _meta.claudeCode.options.allowedTools', () => {
-    const opts = (newSessionParams('/repo', undefined)._meta as Meta).claudeCode?.options;
-    expect(opts?.allowedTools).toEqual([...MAUDE_DEFAULT_ALLOWED_TOOLS]);
-  });
-
-  test('allowedTools is a COPY, not the shared module constant (no accidental mutation)', () => {
-    const opts = (newSessionParams('/repo')._meta as Meta).claudeCode?.options;
-    expect(opts?.allowedTools).not.toBe(MAUDE_DEFAULT_ALLOWED_TOOLS);
-  });
-
-  test('coexists with settingSources (DDR-144) and plugins (DDR-143) under one options', () => {
-    const opts = (newSessionParams('/repo', 'BRIEF', PLUGINS)._meta as Meta).claudeCode?.options;
-    expect(opts?.settingSources).toEqual(['user']);
-    expect(opts?.plugins).toEqual(PLUGINS);
-    expect(opts?.allowedTools).toEqual([...MAUDE_DEFAULT_ALLOWED_TOOLS]);
-  });
-
-  test('present even with no plugins (npm / web / power-user path)', () => {
-    const opts = (newSessionParams('/repo', 'BRIEF', [])._meta as Meta).claudeCode?.options;
-    expect(opts?.plugins).toBeUndefined();
-    expect(opts?.allowedTools).toEqual([...MAUDE_DEFAULT_ALLOWED_TOOLS]);
-  });
-});
-
-describe('MAUDE_DEFAULT_ALLOWED_TOOLS — source-of-truth guard (DDR-184 / DDR-062)', () => {
-  const bashRules = MAUDE_DEFAULT_ALLOWED_TOOLS.filter((t) => t.startsWith('Bash'));
-
-  test('the READ-ONLY file tools are present', () => {
-    for (const t of ['Read', 'Glob', 'Grep']) {
-      expect(MAUDE_DEFAULT_ALLOWED_TOOLS).toContain(t);
-    }
-  });
-
-  test('NO write tool is name-allowed — they are path-gated instead (feature-acp-write-path-scope)', () => {
-    // This assertion is the whole point of the change, so it is worth being
-    // explicit about WHY it inverts what this file used to assert.
-    //
-    // A bare tool name on this list means the CLI approves the call itself and
-    // `requestPermission` is NEVER invoked — so a path condition cannot be
-    // attached to an entry here, at all. Auto-approving a write therefore had
-    // to be moved into the bridge's own gate (`classifyWrite` →
-    // `writeTargetsInsideProject`), where a per-call path exists. DDR-184's
-    // no-prompt-per-edit outcome is fully preserved for in-project writes; what
-    // changed is that a write to `~/.zshenv` now prompts instead of landing
-    // silently with no rollback.
-    //
-    // If someone "fixes" a re-prompting regression by putting Write back on this
-    // list, this test is what tells them they just reopened the hole.
-    for (const t of [...WRITE_TOOL_NAMES]) {
-      expect(MAUDE_DEFAULT_ALLOWED_TOOLS).not.toContain(t);
-    }
-    // Guard the shape too — an `Edit(...)`-style scoped entry would also bypass
-    // the bridge gate, and `not.toContain` on the bare name would miss it.
-    for (const t of MAUDE_DEFAULT_ALLOWED_TOOLS) {
-      const bare = t.replace(/\(.*$/, '');
-      expect(WRITE_TOOL_NAMES.has(bare)).toBe(false);
-    }
-  });
-
-  test('WebSearch and WebFetch are present (DDR-185)', () => {
-    for (const t of ['WebSearch', 'WebFetch']) {
-      expect(MAUDE_DEFAULT_ALLOWED_TOOLS).toContain(t);
-    }
-  });
-
-  test('the Bash rules are EXACTLY this closed set — never a bare/un-scoped Bash', () => {
-    // A bare `Bash` (or `Bash(*)`) would auto-approve arbitrary command execution
-    // — exactly the blanket surface DDR-179 kept behind the prompt. Guard against
-    // anyone widening it: the list may auto-approve `maude` and the closed
-    // read-only fs verb set (DDR-185) — nothing else. In particular:
-    //   - `Bash(curl:*)` must NEVER appear — curl is routed through the
-    //     `curl-local` verb (covered by `Bash(maude:*)`) instead.
-    //   - `Bash(agent-browser:*)` must NEVER appear — a security fan-out found
-    //     it was a zero-confirmation session-hijack primitive; agent-browser is
-    //     routed through the `agent-browser-safe` verb instead.
-    //   - `Bash(find:*)` must NEVER appear — `find -exec` is unrestricted
-    //     command execution, not "mutation"; there is no verb substitute, it
-    //     is simply cut.
-    //   - the read-only fs verb group must NEVER appear — every one of them
-    //     accepts `>`, making the rule an arbitrary-write grant. See the
-    //     dedicated test below.
-    expect(bashRules).toEqual(['Bash(maude:*)']);
-  });
-
-  test('NO redirect-capable bare-command Bash rule — `cat > file` is an arbitrary write (F1)', () => {
-    // SECURITY (security-auditor F1, PoC'd live against claude 2.1.220). The
-    // read-only fs group (ls/cat/pwd/head/tail/wc/tree/file/stat) USED to be on
-    // this list, justified as adding no incremental READ capability. True, and
-    // beside the point: Claude Code's `Bash(<cmd>:*)` prefix rule does not
-    // reject shell redirection, so `cat > ~/.zshenv <<'EOF' … EOF` matched
-    // `Bash(cat:*)`, was self-approved by the CLI, never reached
-    // `requestPermission`, and wrote model-authored arbitrary content to an
-    // arbitrary path — with no write tool involved at all. That is the A2
-    // primitive the write-path gate exists to close, reachable by a CHEAPER
-    // route than the write tools themselves.
-    //
-    // Cut rather than patched (same call DDR-185 made for `find` and
-    // `agent-browser`): a prefix rule cannot inspect what follows the command
-    // name, so there is nothing to patch. If they come back, they must come
-    // back as a hardened `maude design` wrapper verb, which CAN reject `>`.
-    //
-    // This test is what makes re-adding any of them a loud failure rather than
-    // a silent reopening of the hole.
-    for (const verb of ['ls', 'cat', 'pwd', 'head', 'tail', 'wc', 'tree', 'file', 'stat']) {
-      expect(MAUDE_DEFAULT_ALLOWED_TOOLS).not.toContain(`Bash(${verb}:*)`);
-    }
-  });
-
-  test('the `maude` Bash rule is load-bearing on DDR-062: every design helper is a `maude design <verb>`', () => {
-    // Resolve cli/commands/design.mjs relative to this test file's real path
-    // (mirrors acp-session-plugins.test.ts's realpath dance for compiled roots).
-    const here = dirname(realpathSync(import.meta.url.replace('file://', '')));
-    const designCli = join(here, '..', '..', '..', 'cli', 'commands', 'design.mjs');
-    expect(existsSync(designCli)).toBe(true);
-    const src = readFileSync(designCli, 'utf8');
-    // The dispatch table the `Bash(maude:*)` scope rests on — helpers reached via
-    // `maude design <verb>`, not raw `bash <path>.sh` (DDR-062). If this marker
-    // disappears, the one-rule assumption needs re-checking.
-    expect(src).toContain('BIN_VERBS');
-    expect(src).toMatch(/maude design <verb>/);
-  });
-
-  test('the `curl-local` verb exists and is reached via `maude design <verb>` (DDR-185)', () => {
-    // The mechanism the `Bash(agent-browser:*)`/fs-list comment in bridge.ts
-    // promises for curl: real host enforcement via a first-party verb, not a
-    // Bash prefix rule. If this verb disappears from BIN_VERBS, the DDR-185
-    // curl story (and the bootstrap-brief nudge pointing at it) goes stale.
-    const here = dirname(realpathSync(import.meta.url.replace('file://', '')));
-    const designCli = join(here, '..', '..', '..', 'cli', 'commands', 'design.mjs');
-    const src = readFileSync(designCli, 'utf8');
-    expect(src).toMatch(/'curl-local'/);
-  });
-
-  test('the `agent-browser-safe` verb exists and is reached via `maude design <verb>` (DDR-185 security addendum)', () => {
-    // The replacement for the reverted `Bash(agent-browser:*)` entry — real
-    // subcommand/flag enforcement via a first-party verb, not a Bash prefix
-    // rule. If this verb disappears from BIN_VERBS, motion-critic.md/edit.md's
-    // documented raw agent-browser calls go back to prompting (not silently
-    // insecure — but the friction-reduction this DDR promises goes stale).
-    const here = dirname(realpathSync(import.meta.url.replace('file://', '')));
-    const designCli = join(here, '..', '..', '..', 'cli', 'commands', 'design.mjs');
-    const src = readFileSync(designCli, 'utf8');
-    expect(src).toMatch(/'agent-browser-safe'/);
-  });
-
-  test('plugin markdown no longer documents a RAW agent-browser SCREENSHOT/OPEN/NAVIGATE call (DDR-185 security addendum)', () => {
-    // motion-critic.md and edit.md are the two files that originally justified
-    // `Bash(agent-browser:*)` (raw calls not reached via `maude design <verb>`).
-    // screenshot/open/navigate now go through the hardened wrapper — a
-    // regression here means either those calls silently went back to
-    // prompting every time, or (worse) someone re-introduced a raw call the
-    // allow-list no longer covers. `eval` is the deliberate exception (round
-    // 3: removed from the wrapper's own allow-list entirely — arbitrary JS
-    // execution can't be argv-constrained — so it's EXPECTED to stay a raw,
-    // prompting `agent-browser eval` call; see both files' own comments).
-    const here = dirname(realpathSync(import.meta.url.replace('file://', '')));
-    const pluginsDir = join(here, '..', '..', '..', 'plugins', 'design');
-    for (const rel of ['agents/motion-critic.md', 'commands/edit.md']) {
-      const src = readFileSync(join(pluginsDir, rel), 'utf8');
-      expect(src).not.toMatch(/(?<!maude design )agent-browser (screenshot|open|navigate)\b/);
-      expect(src).toContain('agent-browser eval'); // deliberately raw — see comment above
-    }
-    // Only motion-critic.md actually calls the wrapper (for `screenshot`) —
-    // edit.md's sole agent-browser use was `eval`, which reverted fully to
-    // raw, so it has no `agent-browser-safe` invocation left at all.
-    const motionCritic = readFileSync(join(pluginsDir, 'agents/motion-critic.md'), 'utf8');
-    expect(motionCritic).toContain('maude design agent-browser-safe');
-  });
-
-  test('agent-browser-safe does NOT support eval (DDR-185 round-3 security addendum)', () => {
-    // A future accidental re-add of eval to the wrapper's own allow-list
-    // would silently reopen the zero-click session-hijack chain (ethical-
-    // hacker Finding 1: eval's fetch()/window.location defeat
-    // --allowed-domains entirely, and no argv check can constrain arbitrary
-    // JS execution). Source-of-truth guard against bridge.ts's own wrapper.
-    const here = dirname(realpathSync(import.meta.url.replace('file://', '')));
-    const wrapperPath = join(here, '..', 'bin', '_agent-browser-safe.mjs');
-    const src = readFileSync(wrapperPath, 'utf8');
-    expect(src).not.toMatch(/^\s*eval:\s*\[/m);
-  });
-});

package/apps/studio/test/acp-session-plugins.test.ts

@@ -1,209 +0,0 @@
-// DDR-143 — session-scoped plugin auto-bootstrap: the WIRE contract.
-//
-// Two layers: (1) the newSession params carrier — the resolved plugin configs
-// must land on `_meta.claudeCode.options.plugins`, coexisting with the studio
-// brief's `_meta.systemPrompt.append`; (2) the UPGRADE GUARD — that `_meta` path
-// is adapter/SDK-INTERNAL and undocumented, so a dependency bump that stops
-// forwarding `_meta.claudeCode.options` (adapter) or drops `plugins` (SDK) must
-// fail HERE, loudly, instead of silently shipping a desktop app whose chat
-// resolves no `/design:*` on a pristine machine.
-
-import { describe, expect, test } from 'bun:test';
-import { existsSync, readFileSync, realpathSync } from 'node:fs';
-import { dirname, join } from 'node:path';
-
-import { newSessionParams } from '../acp/bridge.ts';
-import type { SdkPluginConfig } from '../acp/plugin-bootstrap.ts';
-
-const PLUGINS: SdkPluginConfig[] = [
-  { type: 'local', path: '/bundle/plugins/design', skipMcpDiscovery: true },
-  { type: 'local', path: '/bundle/plugins/flow', skipMcpDiscovery: true },
-];
-
-type Meta = {
-  systemPrompt?: { append?: string };
-  claudeCode?: {
-    options?: {
-      plugins?: SdkPluginConfig[];
-      settingSources?: string[];
-      settings?: { enabledPlugins?: Record<string, boolean> };
-    };
-  };
-};
-
-describe('newSessionParams — plugin carrier shape', () => {
-  test('with plugins: they ride _meta.claudeCode.options.plugins', () => {
-    const p = newSessionParams('/repo', undefined, PLUGINS);
-    expect(p.cwd).toBe('/repo');
-    expect((p._meta as Meta).claudeCode?.options?.plugins).toEqual(PLUGINS);
-  });
-
-  test('empty plugins: claudeCode carries settingSources but NO plugins (power-user / web no-op)', () => {
-    const p = newSessionParams('/repo', 'BRIEF', []);
-    const opts = (p._meta as Meta).claudeCode?.options;
-    expect(opts?.plugins).toBeUndefined();
-    expect(opts?.settingSources).toEqual(['user']); // security narrowing always present
-  });
-
-  test('undefined plugins: claudeCode carries settingSources, no plugins', () => {
-    const p = newSessionParams('/repo', 'BRIEF');
-    const opts = (p._meta as Meta).claudeCode?.options;
-    expect(opts?.plugins).toBeUndefined();
-    expect(opts?.settingSources).toEqual(['user']);
-  });
-
-  test('brief + plugins coexist under one _meta (both siblings intact)', () => {
-    const p = newSessionParams('/repo', 'BRIEF', PLUGINS);
-    const meta = p._meta as Meta;
-    expect(meta.systemPrompt?.append).toBe('BRIEF');
-    expect(meta.claudeCode?.options?.plugins).toEqual(PLUGINS);
-  });
-
-  test('plugins only, no brief: still no systemPrompt, but claudeCode present', () => {
-    const p = newSessionParams('/repo', undefined, PLUGINS);
-    const meta = p._meta as Meta;
-    expect(meta.systemPrompt).toBeUndefined();
-    expect(meta.claudeCode?.options?.plugins).toEqual(PLUGINS);
-  });
-
-  test('nothing injected: _meta still carries the settingSources security narrowing', () => {
-    const p = newSessionParams('/repo', undefined, []);
-    const meta = p._meta as Meta;
-    expect(meta.systemPrompt).toBeUndefined();
-    expect(meta.claudeCode?.options?.plugins).toBeUndefined();
-    // Every Maude bridge session is auto-approving → settingSources is ALWAYS narrowed.
-    expect(meta.claudeCode?.options?.settingSources).toEqual(['user']);
-  });
-
-  test('settingSources is narrowed to user-only on EVERY session (DDR-144 F2)', () => {
-    for (const p of [
-      newSessionParams('/repo'),
-      newSessionParams('/repo', 'BRIEF'),
-      newSessionParams('/repo', 'BRIEF', PLUGINS),
-      newSessionParams('/repo', undefined, PLUGINS),
-    ]) {
-      expect((p._meta as Meta).claudeCode?.options?.settingSources).toEqual(['user']);
-    }
-  });
-
-  // DDR-168 — the structural double-registration guard: a non-empty `plugins`
-  // must also force off any natively-loaded user-level copy of the same id via
-  // the SDK's "flag" settings layer, so the bundled copy is the ONLY one that
-  // ever loads.
-  test('with plugins: forces design@maude off via options.settings.enabledPlugins (double-registration guard)', () => {
-    const p = newSessionParams('/repo', undefined, PLUGINS);
-    expect((p._meta as Meta).claudeCode?.options?.settings?.enabledPlugins).toEqual({
-      'design@maude': false,
-      // kgai (third-party, injected by the desktop bundle for autonomous capture —
-      // feature-kgai-ecosystem-integration Phase 8). Suppressing a user-installed
-      // copy matters MORE here than for our own plugins: it would run its own
-      // SessionStart install.sh and point at a different engine version than the
-      // pinned, signed sidecar we ship.
-      kgai: false,
-    });
-  });
-
-  test('empty plugins: options.settings is entirely absent (web/npm path unaffected)', () => {
-    const p = newSessionParams('/repo', 'BRIEF', []);
-    expect((p._meta as Meta).claudeCode?.options?.settings).toBeUndefined();
-  });
-
-  test('undefined plugins: options.settings is entirely absent', () => {
-    const p = newSessionParams('/repo', 'BRIEF');
-    expect((p._meta as Meta).claudeCode?.options?.settings).toBeUndefined();
-  });
-});
-
-describe('upgrade guard — installed adapter + SDK still honor the plugins contract', () => {
-  const adapterEntry = join(
-    import.meta.dir,
-    '..',
-    'node_modules',
-    '@agentclientprotocol',
-    'claude-agent-acp',
-    'dist',
-    'acp-agent.js'
-  );
-
-  test('adapter newSession reads _meta.claudeCode.options and forwards it to query()', () => {
-    expect(existsSync(adapterEntry)).toBe(true);
-    const src = readFileSync(adapterEntry, 'utf8');
-    // Verified at claude-agent-acp@0.49.0 (acp-agent.js newSession):
-    //   const userProvidedOptions = sessionMeta?.claudeCode?.options;   (:2302)
-    //   const options = { …, ...userProvidedOptions, … };               (:2333)
-    //   const q = query({ prompt: input, options });                    (:2455)
-    // `plugins` is not in the override list after the spread, so it survives into
-    // query(). A bump that renames/drops any link in this chain must fail here —
-    // then adapt, or fall back to settings.enabledPlugins + a local marketplace
-    // (plan Task 1 fallback).
-    expect(src).toMatch(/claudeCode\s*(\?\.|\.)\s*options/);
-    expect(src).toContain('userProvidedOptions');
-    expect(src).toMatch(/\.\.\.userProvidedOptions/);
-    expect(src).toMatch(/query\(\{[\s\S]{0,80}options[\s\S]{0,40}\}\)/);
-  });
-
-  test('SDK Options declares plugins?: SdkPluginConfig[] (the accepted field)', () => {
-    // Resolve the transitive @anthropic-ai/claude-agent-sdk. Resolve from the
-    // adapter's REAL dir (pnpm store), where the SDK is a peer sibling — the
-    // apps/studio symlink alone doesn't expose the pnpm peer node_modules.
-    let sdkPkg: string | null = null;
-    try {
-      const realAdapterDir = dirname(realpathSync(adapterEntry));
-      sdkPkg = Bun.resolveSync('@anthropic-ai/claude-agent-sdk/package.json', realAdapterDir);
-    } catch {
-      sdkPkg = null;
-    }
-    expect(sdkPkg).not.toBeNull();
-    const dts = join(dirname(sdkPkg as string), 'sdk.d.ts');
-    expect(existsSync(dts)).toBe(true);
-    const src = readFileSync(dts, 'utf8');
-    // sdk.d.ts:1683 `plugins?: SdkPluginConfig[];` + :3766 the { type:'local'; path } shape.
-    expect(src).toMatch(/plugins\?\s*:\s*SdkPluginConfig\[\]/);
-    expect(src).toMatch(/SdkPluginConfig\s*=\s*\{/);
-    expect(src).toMatch(/type:\s*'local'/);
-  });
-
-  // DDR-168 — the same style of guard, for the `options.settings` mechanism the
-  // double-registration fix depends on: `settings` must NOT be among the fields
-  // the adapter overrides after the `...userProvidedOptions` spread (else our
-  // `enabledPlugins: false` override would be silently discarded), and the SDK
-  // must still declare `Settings.enabledPlugins` as an accepted field.
-  test('adapter forwards `settings` from userProvidedOptions and only ever overrides it conditionally when the caller left it unset', () => {
-    expect(existsSync(adapterEntry)).toBe(true);
-    const src = readFileSync(adapterEntry, 'utf8');
-    // Locate the `...userProvidedOptions` spread and inspect what follows it up
-    // to the `query({ options })` call. Verified live at claude-agent-acp@0.57.0:
-    // the object DOES contain a later `settings:` assignment (a
-    // CLAUDE_MODEL_CONFIG env-var fallback) — but it's gated behind
-    // `!userProvidedOptions?.settings && …`, i.e. it only fires when the caller
-    // did NOT already provide a settings object. A caller-provided `settings`
-    // (ours, carrying `enabledPlugins`) always wins. A bump that drops that
-    // guard — making the fallback unconditional — must fail here, since it
-    // would silently clobber DDR-168's double-registration override.
-    const spreadIdx = src.indexOf('...userProvidedOptions');
-    expect(spreadIdx).toBeGreaterThan(-1);
-    const queryIdx = src.indexOf('query(', spreadIdx);
-    expect(queryIdx).toBeGreaterThan(spreadIdx);
-    const window = src.slice(spreadIdx, queryIdx);
-    expect(window).toMatch(/!userProvidedOptions\?\.settings\s*&&/);
-  });
-
-  test("SDK Options declares settings (Settings.enabledPlugins is the field DDR-168's guard relies on)", () => {
-    let sdkPkg: string | null = null;
-    try {
-      const realAdapterDir = dirname(realpathSync(adapterEntry));
-      sdkPkg = Bun.resolveSync('@anthropic-ai/claude-agent-sdk/package.json', realAdapterDir);
-    } catch {
-      sdkPkg = null;
-    }
-    expect(sdkPkg).not.toBeNull();
-    const dts = join(dirname(sdkPkg as string), 'sdk.d.ts');
-    expect(existsSync(dts)).toBe(true);
-    const src = readFileSync(dts, 'utf8');
-    // sdk.d.ts:1831 `settings?: Settings;` (or similarly named field on Options) +
-    // :5193 `Settings.enabledPlugins` — a bump that renames/drops either must
-    // fail here, then adapt, rather than silently reopening double-registration.
-    expect(src).toMatch(/settings\?\s*:/);
-    expect(src).toMatch(/enabledPlugins\??\s*:/);
-  });
-});

package/apps/studio/test/acp-toolgroup.test.ts

@@ -1,76 +0,0 @@
-// Pure unit tests for client/panels/ToolGroup.jsx's grouping/summary helpers
-// (Task C1 — collapsed consecutive-tool-call groups).
-
-import { describe, expect, test } from 'bun:test';
-
-import { groupToolCalls, summarizeGroup } from '../client/panels/ToolGroup.jsx';
-
-describe('groupToolCalls', () => {
-  test('a lone tool-call stays a single item, not a group', () => {
-    const parts = [{ type: 'tool-call', toolCallId: '1', toolName: 'Read file' }];
-    expect(groupToolCalls(parts)).toEqual([{ type: 'single', part: parts[0] }]);
-  });
-
-  test('2+ CONSECUTIVE tool-calls fold into one group', () => {
-    const parts = [
-      { type: 'tool-call', toolCallId: '1', toolName: 'Read file' },
-      { type: 'tool-call', toolCallId: '2', toolName: 'Run command' },
-      { type: 'tool-call', toolCallId: '3', toolName: 'Write file' },
-    ];
-    const grouped = groupToolCalls(parts);
-    expect(grouped).toEqual([{ type: 'tool-group', parts }]);
-  });
-
-  test('text/reasoning parts break a run into separate groups', () => {
-    const parts = [
-      { type: 'tool-call', toolCallId: '1', toolName: 'Read file' },
-      { type: 'tool-call', toolCallId: '2', toolName: 'Write file' },
-      { type: 'text', text: 'done reading and writing' },
-      { type: 'tool-call', toolCallId: '3', toolName: 'Run command' },
-    ];
-    const grouped = groupToolCalls(parts);
-    expect(grouped).toEqual([
-      { type: 'tool-group', parts: [parts[0], parts[1]] },
-      { type: 'single', part: parts[2] },
-      { type: 'single', part: parts[3] }, // lone tool-call after the break — not a group
-    ]);
-  });
-
-  test('a mix of text and reasoning parts each stay single, in order', () => {
-    const parts = [
-      { type: 'text', text: 'thinking about it' },
-      { type: 'reasoning', text: '...' },
-      { type: 'text', text: 'here is my answer' },
-    ];
-    expect(groupToolCalls(parts)).toEqual(parts.map((part) => ({ type: 'single', part })));
-  });
-
-  test('tolerates an empty/missing parts array', () => {
-    expect(groupToolCalls([])).toEqual([]);
-    expect(groupToolCalls(undefined)).toEqual([]);
-    expect(groupToolCalls(null)).toEqual([]);
-  });
-});
-
-describe('summarizeGroup', () => {
-  test('all entries sharing one title collapse to "Ran N × <title>"', () => {
-    const parts = [{ toolName: 'Read file' }, { toolName: 'Read file' }, { toolName: 'Read file' }];
-    expect(summarizeGroup(parts)).toBe('Ran 3 × Read file');
-  });
-
-  test('mixed titles list the distinct ones, capped at 3 with an ellipsis', () => {
-    const parts = [
-      { toolName: 'Read file' },
-      { toolName: 'Run command' },
-      { toolName: 'Web search' },
-      { toolName: 'Write file' },
-      { toolName: 'Read file' }, // duplicate — must not inflate the unique count
-    ];
-    const summary = summarizeGroup(parts);
-    expect(summary).toBe('Ran 5 tools — Read file, Run command, Web search…');
-  });
-
-  test('a missing toolName falls back to the generic label, not undefined', () => {
-    expect(summarizeGroup([{}, {}])).toBe('Ran 2 × tool');
-  });
-});

package/apps/studio/test/acp-transcript-view.test.ts

@@ -1,71 +0,0 @@
-// Pure unit tests for client/panels/transcript-view.js (Task C4).
-
-import { describe, expect, test } from 'bun:test';
-
-import {
-  DEFAULT_TRANSCRIPT_VIEW,
-  filterTranscriptParts,
-  TRANSCRIPT_VIEWS,
-  transcriptForcesExpand,
-} from '../client/panels/transcript-view.js';
-
-const PARTS = [
-  { type: 'reasoning', text: 'let me think' },
-  { type: 'tool-call', toolCallId: '1', toolName: 'Read file' },
-  { type: 'text', text: 'first answer' },
-  { type: 'reasoning', text: 'more thinking' },
-  { type: 'text', text: 'final answer' },
-];
-
-describe('filterTranscriptParts', () => {
-  test('normal hides reasoning, keeps text + tool-calls in order', () => {
-    const result = filterTranscriptParts(PARTS, 'normal');
-    expect(result.map((p) => p.type)).toEqual(['tool-call', 'text', 'text']);
-  });
-
-  test('thinking keeps everything, including reasoning', () => {
-    expect(filterTranscriptParts(PARTS, 'thinking')).toEqual(PARTS);
-  });
-
-  test('verbose also keeps everything (the extra verbosity is a render-detail toggle)', () => {
-    expect(filterTranscriptParts(PARTS, 'verbose')).toEqual(PARTS);
-  });
-
-  test('summary keeps ONLY the last text part', () => {
-    const result = filterTranscriptParts(PARTS, 'summary');
-    expect(result).toEqual([{ type: 'text', text: 'final answer' }]);
-  });
-
-  test('summary with no text parts at all returns empty, not a crash', () => {
-    expect(filterTranscriptParts([{ type: 'tool-call', toolCallId: '1' }], 'summary')).toEqual([]);
-  });
-
-  test('an unrecognized mode fails toward normal (less noise), not everything', () => {
-    expect(filterTranscriptParts(PARTS, 'nonsense')).toEqual(
-      filterTranscriptParts(PARTS, 'normal')
-    );
-  });
-
-  test('tolerates missing/empty input', () => {
-    expect(filterTranscriptParts(undefined, 'normal')).toEqual([]);
-    expect(filterTranscriptParts(null, 'thinking')).toEqual([]);
-    expect(filterTranscriptParts([], 'summary')).toEqual([]);
-  });
-});
-
-describe('transcriptForcesExpand', () => {
-  test('only verbose forces expansion', () => {
-    expect(transcriptForcesExpand('verbose')).toBe(true);
-    expect(transcriptForcesExpand('normal')).toBe(false);
-    expect(transcriptForcesExpand('thinking')).toBe(false);
-    expect(transcriptForcesExpand('summary')).toBe(false);
-    expect(transcriptForcesExpand(undefined)).toBe(false);
-  });
-});
-
-describe('constants', () => {
-  test('the view list + default are stable and consistent', () => {
-    expect(TRANSCRIPT_VIEWS).toEqual(['normal', 'thinking', 'verbose', 'summary']);
-    expect(TRANSCRIPT_VIEWS).toContain(DEFAULT_TRANSCRIPT_VIEW);
-  });
-});