zuck 1.0.0 → 2.0.0

data/spec/lib/zuck_spec.rb

@@ -8,9 +8,10 @@ describe Zuck::FbObject do
 
   let(:graph)   { Zuck.graph                                                  }
   let(:account) { Zuck::AdAccount.new(graph,  {id: "act_10150585630710217"})  }
-  let(:campaign){ Zuck::AdCampaign.new(graph, {id: "6010889111951"}, account) }
+  let(:campaign){ Zuck::AdCampaign.new(graph, {id: "6021499361751"}, account) }
   let(:group)   { Zuck::AdGroup.new(graph,    {id: "6010889169151"}, campaign)}
-  let(:creative){ Zuck::AdCreative.new(graph, {id: "6010888561951"}, group)   }
+  let(:creative){ Zuck::AdCreative.new(graph, {id: "6021396606151"}, group)   }
+  let(:set)     { Zuck::AdSet.new(graph,      {id: "6021525283751"}, account)   }
 
 
   describe "read only objects" do
@@ -38,19 +39,19 @@ describe Zuck::FbObject do
 
       it "a list of ad accounts" do
         VCR.use_cassette('list_of_ad_accounts') do
-          Zuck::AdAccount.all.should have(1).item
+          Zuck::AdAccount.all.should have(2).items
         end
       end
 
       it "a list of ad campaigns" do
         VCR.use_cassette('list_of_ad_campaigns') do
-          account.ad_campaigns.should have(8).items
+          account.ad_campaigns.should have(24).items
         end
       end
 
       it "a list of ad groups" do
         VCR.use_cassette('list_of_ad_groups') do
-          campaign.ad_groups.should have(9).item
+          campaign.ad_groups.should have(4).item
         end
       end
 
@@ -64,7 +65,7 @@ describe Zuck::FbObject do
         g = graph
         Zuck::AdAccount.should_receive(:all).and_return([account])
         VCR.use_cassette('list_of_all_ad_creatives_of_account') do
-          Zuck::AdCreative.all(g).should have(9).items
+          Zuck::AdCreative.all(g).should have(13).items
         end
       end
 
@@ -72,7 +73,7 @@ describe Zuck::FbObject do
 
         it "campaign with the correct type" do
           VCR.use_cassette('a_single_campaign') do
-            c = Zuck::AdCampaign.find(6005950787751, graph)
+            c = Zuck::AdCampaign.find(6021496142951, graph)
           end
         end
 
@@ -92,7 +93,7 @@ describe Zuck::FbObject do
 
         it "and saving it" do
           VCR.use_cassette('find_a_single_group_and_update_it') do
-            group = Zuck::AdGroup.find(6010889169151, graph)
+            group = Zuck::AdGroup.find(6021525861551, graph)
             group.name = "My old name"
             group.save
             group.name.should == "My old name"
@@ -109,9 +110,23 @@ describe Zuck::FbObject do
 
 
     context "creating" do
+      it "an ad set" do
+        VCR.use_cassette('create_ad_set') do
+          o = {
+            name: 'test ad set',
+            campaign_status: 'PAUSED',
+            daily_budget: 100,
+            targeting: "{'geo_locations':{'countries':['US','GB']}}",
+            campaign_group_id: campaign.id
+          }
+          ad_set = Zuck::AdSet.create(graph, o, account)
+          ad_set.name.should == 'test ad set'
+        end
+      end
+
       it "an ad campaign" do
         VCR.use_cassette('create_ad_campaign') do
-          o = {daily_budget: 1000, name: "bloody" }
+          o = {objective: 'NONE', name: "bloody", campaign_group_status: 'PAUSED' }
           campaign = Zuck::AdCampaign.create(graph, o, account)
           campaign.name.should == "bloody"
         end
@@ -125,23 +140,19 @@ describe Zuck::FbObject do
         end
       end
 
-      it "an ad group" do
-        VCR.use_cassette('create_ad_group') do
-          o = {bid_type: 'CPC', max_bid: 1, name: "Rap like me", targeting: '{"countries":["US"]}',
-               creative: '{"type":25,"action_spec":{"action.type":"like", "post":10150420410887685}}'}
-          group = Zuck::AdGroup.create(graph, o, campaign)
-          group.name.should == "Rap like me"
-        end
-      end
-
       it "an ad group via an existing ad campaign" do
         VCR.use_cassette('create_ad_group') do
-          o = {bid_type: 'CPC', max_bid: 1, name: "Rap like me", targeting: '{"countries":["US"]}',
-               creative: '{"type":25,"action_spec":{"action.type":"like", "post":10150420410887685}}'}
-          group = campaign.create_ad_group(o)
+          o = {
+            bid_type: 'CPC',
+            bid_info: '{"CLICKS": 1}',
+            name: "Rap like me",
+            targeting: '{"geo_locations": {"countries":["US"]}}',
+            objective: 'WEBSITE_CLICKS',
+            creative: '{"creative_id": "6021396606151"}'
+          }
+          group = set.create_ad_group(o)
           group.name.should == "Rap like me"
-          # Until Oct 2013 Facebook will return the magic ints, and then the enums
-          group.bid_type.should == 1
+          group.bid_type.should == 'CPC'
         end
       end
     end

data/spec/spec_helper.rb

@@ -3,6 +3,7 @@ require 'simplecov'
 SimpleCov.start
 require 'bundler'
 Bundler.require
+require 'pry'
 
 # This file is copied to spec/ when you run 'rails generate rspec:install'
 ENV["RAILS_ENV"] ||= 'test'
@@ -39,12 +40,8 @@ module TestResponseExtensions
   end
 end
 
-def expect_id_and_return(id, ret_val)
-  lambda { |id| id.to_s.should == id.to_s; ret_val }
-end
-
 def test_access_token
-  'CAAEvJ5vzhl8BAH8aCPOx0Ft9uNB147TF8weJ8hK0g7YVDRWU4eEih7tEKdJgmfk0vABZClZACJbEzyhSMbiShL6RpsfkZASfX1C9nv1AlFvjJajflqkyYZAlpE2edT0FJHjdh4NFg0ZCt0sBgq0kZABtKsjuU18aMURLE7rjKHR4X8NkXBUafg1T4uZARRNqboZD'
+  @test_access_token ||= File.read("test_access_token")
 end
 
 require File.expand_path("../../lib/zuck", __FILE__)

data/test_access_token

@@ -0,0 +1 @@
+CAAEvJ5vzhl8BAICOwypV5nYnYWXhBq1eskHA7rKyrz9fXcAvKRXDWVZAaG7FpQ21qTXeCtGZCR7iu1dtZCqZCZBZCQbefKrMOnZAibDZAiQKiX0s22PgtKuCoQK4LDVimREnqkGdoLMyB4zgT3A6ZAU7pn6wc2mTzZBWVbkr71bZBJKjhyeb4V58TkMsUbN9SQer3ZCRRtWTxqNFTUwHuv51RoVsI7LNw0mCr5gZD

data/zuck.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: zuck 1.0.0 ruby lib
+# stub: zuck 2.0.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "zuck"
-  s.version = "1.0.0"
+  s.version = "2.0.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Jannis Hermanns"]
-  s.date = "2014-04-23"
+  s.date = "2015-01-09"
   s.description = "This gem allows to easily access facebook's ads api in ruby. See https://developers.facebook.com/docs/reference/ads-api/"
   s.email = "jannis@gmail.com"
   s.extra_rdoc_files = [
@@ -37,6 +37,7 @@ Gem::Specification.new do |s|
     "lib/zuck/facebook/ad_creative.rb",
     "lib/zuck/facebook/ad_group.rb",
     "lib/zuck/facebook/ad_interest.rb",
+    "lib/zuck/facebook/ad_set.rb",
     "lib/zuck/facebook/targeting_spec.rb",
     "lib/zuck/fb_object.rb",
     "lib/zuck/fb_object/dsl.rb",
@@ -56,6 +57,7 @@ Gem::Specification.new do |s|
     "spec/fixtures/ad_interest_search_nonexistant.yml",
     "spec/fixtures/create_ad_campaign.yml",
     "spec/fixtures/create_ad_group.yml",
+    "spec/fixtures/create_ad_set.yml",
     "spec/fixtures/delete_ad_group.yml",
     "spec/fixtures/find_a_single_group_and_update_it.yml",
     "spec/fixtures/list_of_ad_accounts.yml",
@@ -76,6 +78,7 @@ Gem::Specification.new do |s|
     "spec/lib/zuck_spec.rb",
     "spec/spec_helper.rb",
     "spec/vcr_setup.rb",
+    "test_access_token",
     "zuck.gemspec"
   ]
   s.homepage = "http://github.com/jayniz/zuck"
@@ -89,7 +92,7 @@ Gem::Specification.new do |s|
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_runtime_dependency(%q<rvm>, [">= 0"])
       s.add_runtime_dependency(%q<bundler>, [">= 0"])
-      s.add_runtime_dependency(%q<koala>, ["~> 1.6.0"])
+      s.add_runtime_dependency(%q<koala>, [">= 0"])
       s.add_runtime_dependency(%q<activesupport>, [">= 0"])
       s.add_development_dependency(%q<shoulda>, ["~> 3.3.2"])
       s.add_development_dependency(%q<rdoc>, ["~> 3.12"])
@@ -98,7 +101,8 @@ Gem::Specification.new do |s|
       s.add_development_dependency(%q<webmock>, ["~> 1.8.0"])
       s.add_development_dependency(%q<rspec>, [">= 0"])
       s.add_development_dependency(%q<vcr>, [">= 0"])
-      s.add_development_dependency(%q<guard>, [">= 0"])
+      s.add_development_dependency(%q<pry>, [">= 0"])
+      s.add_development_dependency(%q<guard-ctags-bundler>, [">= 0"])
       s.add_development_dependency(%q<guard-rspec>, [">= 0"])
       s.add_development_dependency(%q<guard-bundler>, [">= 0"])
       s.add_development_dependency(%q<guard-yard>, [">= 0"])
@@ -108,7 +112,7 @@ Gem::Specification.new do |s|
     else
       s.add_dependency(%q<rvm>, [">= 0"])
       s.add_dependency(%q<bundler>, [">= 0"])
-      s.add_dependency(%q<koala>, ["~> 1.6.0"])
+      s.add_dependency(%q<koala>, [">= 0"])
       s.add_dependency(%q<activesupport>, [">= 0"])
       s.add_dependency(%q<shoulda>, ["~> 3.3.2"])
       s.add_dependency(%q<rdoc>, ["~> 3.12"])
@@ -117,7 +121,8 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<webmock>, ["~> 1.8.0"])
       s.add_dependency(%q<rspec>, [">= 0"])
       s.add_dependency(%q<vcr>, [">= 0"])
-      s.add_dependency(%q<guard>, [">= 0"])
+      s.add_dependency(%q<pry>, [">= 0"])
+      s.add_dependency(%q<guard-ctags-bundler>, [">= 0"])
       s.add_dependency(%q<guard-rspec>, [">= 0"])
       s.add_dependency(%q<guard-bundler>, [">= 0"])
       s.add_dependency(%q<guard-yard>, [">= 0"])
@@ -128,7 +133,7 @@ Gem::Specification.new do |s|
   else
     s.add_dependency(%q<rvm>, [">= 0"])
     s.add_dependency(%q<bundler>, [">= 0"])
-    s.add_dependency(%q<koala>, ["~> 1.6.0"])
+    s.add_dependency(%q<koala>, [">= 0"])
     s.add_dependency(%q<activesupport>, [">= 0"])
     s.add_dependency(%q<shoulda>, ["~> 3.3.2"])
     s.add_dependency(%q<rdoc>, ["~> 3.12"])
@@ -137,7 +142,8 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<webmock>, ["~> 1.8.0"])
     s.add_dependency(%q<rspec>, [">= 0"])
     s.add_dependency(%q<vcr>, [">= 0"])
-    s.add_dependency(%q<guard>, [">= 0"])
+    s.add_dependency(%q<pry>, [">= 0"])
+    s.add_dependency(%q<guard-ctags-bundler>, [">= 0"])
     s.add_dependency(%q<guard-rspec>, [">= 0"])
     s.add_dependency(%q<guard-bundler>, [">= 0"])
     s.add_dependency(%q<guard-yard>, [">= 0"])

metadata

@@ -1,265 +1,279 @@
 --- !ruby/object:Gem::Specification
 name: zuck
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Jannis Hermanns
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-23 00:00:00.000000000 Z
+date: 2015-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rvm
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: koala
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: shoulda
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.3.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.3.2
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.12'
 - !ruby/object:Gem::Dependency
   name: jeweler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.0.1
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.7.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.7.1
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.8.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.8.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: guard
+  name: guard-ctags-bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: growl
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: redcarpet
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rb-fsevent
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: This gem allows to easily access facebook's ads api in ruby. See https://developers.facebook.com/docs/reference/ads-api/
@@ -270,9 +284,9 @@ extra_rdoc_files:
 - LICENSE.txt
 - README.markdown
 files:
-- .rvmrc
-- .travis.yml
-- .yardopts
+- ".rvmrc"
+- ".travis.yml"
+- ".yardopts"
 - CHANGELOG.markdown
 - Gemfile
 - Gemfile.lock
@@ -288,6 +302,7 @@ files:
 - lib/zuck/facebook/ad_creative.rb
 - lib/zuck/facebook/ad_group.rb
 - lib/zuck/facebook/ad_interest.rb
+- lib/zuck/facebook/ad_set.rb
 - lib/zuck/facebook/targeting_spec.rb
 - lib/zuck/fb_object.rb
 - lib/zuck/fb_object/dsl.rb
@@ -307,6 +322,7 @@ files:
 - spec/fixtures/ad_interest_search_nonexistant.yml
 - spec/fixtures/create_ad_campaign.yml
 - spec/fixtures/create_ad_group.yml
+- spec/fixtures/create_ad_set.yml
 - spec/fixtures/delete_ad_group.yml
 - spec/fixtures/find_a_single_group_and_update_it.yml
 - spec/fixtures/list_of_ad_accounts.yml
@@ -327,6 +343,7 @@ files:
 - spec/lib/zuck_spec.rb
 - spec/spec_helper.rb
 - spec/vcr_setup.rb
+- test_access_token
 - zuck.gemspec
 homepage: http://github.com/jayniz/zuck
 licenses:
@@ -338,12 +355,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []