zuck 1.0.0 → 2.0.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    MGYzNGI4MTQ0ZjJmNzgxZjQwY2JlNTg3YTgyMTc2NzlhYTE2NWNkZA==
-  data.tar.gz: !binary |-
-    ZjllZWZjNTgxYzdhYmRiNjQ1YmE2OTY5NTI5MmMyNmFjY2M2NDgyYQ==
+SHA1:
+  metadata.gz: 40becd6a7fffa32053f38e6e550c76ba84480044
+  data.tar.gz: 9ad567305d626e899c9b3bc1563297df9f49164b
 SHA512:
-  metadata.gz: !binary |-
-    NDU3YjViNWY4NWZiNGMzYTAwZTZmZmZmMWZmODVmNWQ2NjEyMzM3Nzc0OWFi
-    MWM5OWYwYTAyNmM1ODA4MTM1MmExYzI0MWM4YjM1N2MxNzc4NGFmMGYzMDc5
-    ODMwNzkwNTEzMThhYzgzYTE4ZWEyMWQ3NDM4NTdmMmZlMmY5Nzk=
-  data.tar.gz: !binary |-
-    NTZkMDQ0NzZlYzQyMGVmMmJiNjcwZmU2NmYzOTgwZTM1OWY2MGEwNjJhODQ3
-    YjcxMThmNzkxNDllOWYxMDhkMzhmMTBkNDk2ODg1ODFjY2RmYzBiODRjZDY2
-    MWMzZjkxNjhkNThmYjJkN2UxYTM3ZjM3ODE4Njg2ZGU1NDBlM2I=
+  metadata.gz: 5fc4c51ef900b5b8d4084500aa339ee2d0e3320d2c89baa9ccf1ce044ee965eb379e91c22010d79e68c47281c7f1988d0622f42ca1d296d6d0b3904def9fe5e0
+  data.tar.gz: 42e866685f4fefc664e59871b98db3428a0407144a7b4ce015fc68fc358fbc4e313318b8f27a73fd8ec187292555be917ce9152ac849591e2ecbd05a42b7f592

data/CHANGELOG.markdown

@@ -1,5 +1,35 @@
+2.0.0
+=====
+
+- update Koala to 1.10.1
+- use the `/search?type=adinterestq=interest` endpoint to validate ad interests
+  instead of `/search?type=adinterestvalid&interest_list=['interest']`
+- use json objects instead of string values for ad interests
+- don't escape commas with %2C when passing searches on to koala
+- update ad account properties
+- fix consecutive `#save`s without a `#reload` in between 
+
+Breaking changes:
+----------------
+
+If you upgrade from 1.x, make sure you read the following:
+
+- `Zuck::AdInterest.search` results use the `audience_size` key in order to use
+  the same names as the facebook api. In zuck 1.x it was `audience`
+- `Zuck::TargetingSpec`
+  - `initialize` does not take string interests anymore,
+    but expects `{id: '123', name: 'foo'} objects, see
+    "[Specifying values for interests as a string will be sunset in favor of a JSON object of id and name](https://developers.facebook.com/docs/apps/migrations/ads-api-changes-2014-04-09)"
+  - in your targeting spec, don't specify `{countries: ['US']}`, but
+    `{geo_locations: { countries: ['US']}}`
+- `Zuck::AdInterest.best_guess` returns an ad interest object, what was
+  formerly the `:interest` key is now called `:name`
+- Ad Campaigns are now called Ad Sets, and Ad Sets can be grouped
+  together in Ad Campaigns [see docs](https://developers.facebook.com/docs/reference/ads-api/adcampaign/v2.2)
+
+
 1.0.0
------
+=====
 - Implement Facebook's April 9 breaking changes, which also change this
   gem
 - AdKeyword/keywords are gone, welcome AdInterest/interests
@@ -10,16 +40,16 @@ docs](https://developers.facebook.com/docs/reference/ads-api/interest-targeting)
 docs](https://developers.facebook.com/docs/reference/ads-api/targeting-specs))
 
 0.2.0
------
+=====
 - implement Facebook's [Oct 2013 breaking changes](https://developers.facebook.com/roadmap/#q4_2013)
 
 0.0.9
------
+=====
 - add Zuck::TargetingSpec.valid_countries? method to allow for country
   validation from the outside
 
 0.0.8
------
+=====
 - validate the countries before fetching a reach estimate
 
 0.0.7
@@ -28,5 +58,5 @@ docs](https://developers.facebook.com/docs/reference/ads-api/targeting-specs))
   with a # as a prefix
 
 0.0.4
------
+=====
 - integrated targeting spec to fetch reach estimates

data/Gemfile

@@ -2,7 +2,7 @@ source 'http://rubygems.org'
 
 gem 'rvm'
 gem 'bundler'
-gem 'koala', '~>1.6.0'
+gem 'koala'
 gem 'activesupport'
 
 group :development do
@@ -16,11 +16,12 @@ group :development, :test do
   gem 'webmock', '~>1.8.0'
   gem 'rspec'
   gem 'vcr'
+  gem 'pry'
 end
 
 platform :ruby do
   group :development do
-    gem 'guard'
+    gem 'guard-ctags-bundler'
     gem 'guard-rspec'
     gem 'guard-bundler'
     gem 'guard-yard'

data/Gemfile.lock

@@ -4,15 +4,15 @@ GEM
     activesupport (3.2.9)
       i18n (~> 0.6)
       multi_json (~> 1.0)
-    addressable (2.3.3)
+    addressable (2.3.6)
     bourne (1.1.2)
       mocha (= 0.10.5)
     builder (3.2.2)
     coderay (1.0.8)
     crack (0.3.1)
     diff-lcs (1.1.3)
-    faraday (0.8.7)
-      multipart-post (~> 1.1)
+    faraday (0.8.9)
+      multipart-post (~> 1.2.0)
     git (1.2.6)
     github_api (0.10.2)
       addressable
@@ -30,6 +30,8 @@ GEM
     guard-bundler (1.0.0)
       bundler (~> 1.0)
       guard (~> 1.1)
+    guard-ctags-bundler (0.2.0)
+      guard (>= 1.1)
     guard-rspec (2.3.3)
       guard (>= 1.1)
       rspec (~> 2.11)
@@ -52,10 +54,10 @@ GEM
     json (1.8.1-java)
     jwt (0.1.11)
       multi_json (>= 1.5)
-    koala (1.6.0)
-      addressable (~> 2.2)
-      faraday (~> 0.8)
-      multi_json (~> 1.3)
+    koala (1.10.1)
+      addressable
+      faraday
+      multi_json
     listen (0.6.0)
     lumberjack (1.0.2)
     metaclass (0.0.1)
@@ -63,7 +65,7 @@ GEM
     mini_portile (0.5.3)
     mocha (0.10.5)
       metaclass (~> 0.0.1)
-    multi_json (1.7.2)
+    multi_json (1.10.1)
     multi_xml (0.5.5)
     multipart-post (1.2.0)
     nokogiri (1.6.1)
@@ -122,12 +124,13 @@ DEPENDENCIES
   activesupport
   bundler
   growl
-  guard
   guard-bundler
+  guard-ctags-bundler
   guard-rspec
   guard-yard
   jeweler (~> 2.0.1)
-  koala (~> 1.6.0)
+  koala
+  pry
   rb-fsevent
   rdoc (~> 3.12)
   redcarpet

data/README.markdown

@@ -3,7 +3,7 @@
 Zuck; use facebook's advertisement API with ruby
 ================
 
-This is a little gem that makes access to facebook's 
+This is a little gem that makes access to facebook's
 ads API a little easier. Check out facebook's
 [documentation](https://developers.facebook.com/docs/reference/ads-api/)
 for a nice diagram that explains how things work.
@@ -28,16 +28,12 @@ accounts = Zuck::AdAccount.all
 
 # Let's look at an account
 my_account = accounts.first
-=> #<Zuck::AdAccount id: "act_10150585630710217", account_id: "10150585630710217", name: "", account_status: 1, currency: "USD", timezone_id: 47, timezone_name: "Europe/Berlin", timezone_offset_hours_utc: 2, is_personal: 0, business_name: "Big Mike Alright UG (haftungsbeschr\u00e4nkt)", business_street: "Big Mike Alright UG (haftungsbeschr\u00e4nkt)", business_street2: "J\u00e4gerndorfer Zeile 61", business_city: "Berlin", business_state: "Berlin", business_zip: "12209", business_country_code: "DE", vat_status: 3, daily_spend_limit: 25000, users: [{"uid":501730216,"permissions":[1,2,3,4,5,7],"role":1001}], notification_settings: {"501730216":{"1000":{"1":1},"1001":{"1":1},"1002":{"1":1,"2":60},"1003":{"1":1,"2":60},"1004":{"1":1},"1005":{"1":1},"1006":{"1":1},"1009":{"1":1},"1010":{"1":1},"1011":{"1":1},"2000":{"1":1,"2":60},"2001":{"1":1,"2":60},"2002":{"2":60},"2003":{"1":1,"2":60},"2004":{"1":1,"2":60},"2005":{"1":1,"2":60},"3000":{"1":1,"2":60},"3001":{"1":1,"2":60},"3002":{"2":60},"3003":{"1":1,"2":60},"5000":{"1":1},"6000":{"1":1},"6001":{"1":1},"9000":{"1":1,"2":60},"8000":{"1":1,"2":60}}}, capabilities: [], balance: 0, moo_default_conversion_bid: 1000, moo_default_bid: 1000> 
+=> #<Zuck::AdAccount id: "act_10150585630710217", account_id: "10150585630710217", name: "", account_status: 1, currency: "USD", timezone_id: 47, timezone_name: "Europe/Berlin", timezone_offset_hours_utc: 2, is_personal: 0, business_name: "Big Mike Alright UG (haftungsbeschr\u00e4nkt)", business_street: "Big Mike Alright UG (haftungsbeschr\u00e4nkt)", business_street2: "J\u00e4gerndorfer Zeile 61", business_city: "Berlin", business_state: "Berlin", business_zip: "12209", business_country_code: "DE", vat_status: 3, daily_spend_limit: 25000, users: [{"uid":501730216,"permissions":[1,2,3,4,5,7],"role":1001}], notification_settings: {"501730216":{"1000":{"1":1},"1001":{"1":1},"1002":{"1":1,"2":60},"1003":{"1":1,"2":60},"1004":{"1":1},"1005":{"1":1},"1006":{"1":1},"1009":{"1":1},"1010":{"1":1},"1011":{"1":1},"2000":{"1":1,"2":60},"2001":{"1":1,"2":60},"2002":{"2":60},"2003":{"1":1,"2":60},"2004":{"1":1,"2":60},"2005":{"1":1,"2":60},"3000":{"1":1,"2":60},"3001":{"1":1,"2":60},"3002":{"2":60},"3003":{"1":1,"2":60},"5000":{"1":1},"6000":{"1":1},"6001":{"1":1},"9000":{"1":1,"2":60},"8000":{"1":1,"2":60}}}, capabilities: [], balance: 0, moo_default_conversion_bid: 1000, moo_default_bid: 1000>
 
 # Aha. How do I access properties? The documented properties
 # have getters:
 my_account.currency
-=> "USD"    
-
-# But facebook also returns some non documented stuff
-my_account[:moo_default_bid]
-=> 1000
+=> "USD"
 
 # Let's fetch the campaigns for this account
 my_campaign = my_account.ad_campaigns.first
@@ -67,12 +63,12 @@ creative = '{"type":25,"action_spec":{"action.type":"like", "post":1015042041088
 o = { bid_type:  1,
       max_bid:   1,
       name:      "My first ad group",
-      targeting: '{"countries":["US"]}',
+      targeting: '{"geo_locations": {"countries":["US"]}}',
       creative:  creative}
-      
+
 # Create it in the context of my_campaign
 group = my_campaign.create_ad_group(o)
-=> #<Zuck::AdGroup adgroup_id: 6005851390151, ad_id: 6005851390151, campaign_id: 6005851032951, name: "My first ad group", adgroup_status: 4, bid_type: 1, max_bid: "1", bid_info: {"1":"1"}, ad_status: 4, account_id: "10150585630710217", id: "6005851390151", creative_ids: [6005851371551], targeting: {"countries":["US"],"friends_of_connections":[{"id":"6005851366351","name":null}]}, conversion_specs: [{"action.type":"like","post":"10150420410887685"}], start_time: null, end_time: null, updated_time: 1343916568, created_time: 1343916568>
+=> #<Zuck::AdGroup adgroup_id: 6005851390151, ad_id: 6005851390151, campaign_id: 6005851032951, name: "My first ad group", adgroup_status: 4, bid_type: 1, max_bid: "1", bid_info: {"1":"1"}, ad_status: 4, account_id: "10150585630710217", id: "6005851390151", creative_ids: [6005851371551], targeting: {"geo_locations": {"countries":["US"]},"friends_of_connections":[{"id":"6005851366351","name":null}]}, conversion_specs: [{"action.type":"like","post":"10150420410887685"}], start_time: null, end_time: null, updated_time: 1343916568, created_time: 1343916568>
 
 # Shoot, that was the wrong name
 group.name = "My serious ad group"
@@ -94,31 +90,31 @@ AdInterest convenience methods
 ```ruby
 graph = Zuck.graph
 
-# Search for keywords (to auto complete, for example) (yes, facebook sometimes returns ids as string and sometimes as numbers)
+# Search for interests (to auto complete, for example) (yes, facebook sometimes returns ids as string and sometimes as numbers)
 Zuck::AdInterest.search(graph, "Auto")
 =>  [
-      {:keyword=>"Auto", :id=>"6003156165433", :audience=>nil},
-      {:keyword=>"#Automobile", :id=>6003176678152, :audience=>97900000},
-      {:keyword=>"#Auto racing", :id=>6003146718552, :audience=>21800000},
-      {:keyword=>"#Auto mechanic", :id=>6003109384433, :audience=>14600000}
+      {:interest=>"Auto", :id=>"6003156165433", :audience=>nil},
+      {:interest=>"#Automobile", :id=>6003176678152, :audience=>97900000},
+      {:interest=>"#Auto racing", :id=>6003146718552, :audience=>21800000},
+      {:interest=>"#Auto mechanic", :id=>6003109384433, :audience=>14600000}
     ]
 
-# Quickly check if a keyword is valid
+# Quickly check if a interest is valid
 Zuck::AdInterest.validate(graph, '#Eminem')
 => {"#Eminem" => true}
 
-# Quickly check a couple of keywords
+# Quickly check a couple of interests
 Zuck::AdInterest.validate(graph, ['#Eminem', 'Wil Ferel', 'Bronson'])
 => {"#Eminem"=>true, "Bronson"=>true, "Wil Ferel"=>false}
 
-# Make a best guess on how a keyword is called on Facebook
+# Make a best guess on how a interest is called on Facebook
 Zuck::AdInterest.best_guess(graph, 'Disney')
-=> {:keyword=>"#The Walt Disney Company", :id=>6003270522085, :audience=>72500000}
+=> {:interest=>"#The Walt Disney Company", :id=>6003270522085, :audience=>72500000}
 
-# Sometimes a best guess does not return a keyword with a # prefix, and that
-# means that we don't know the audience of that keyword:
+# Sometimes a best guess does not return a interest with a # prefix, and that
+# means that we don't know the audience of that interest:
 Zuck::AdInterest.best_guess(graph, 'Moviepilot')
-=> {:keyword=>"Moviepilot", :id=>6003327847780, :audience=>nil}
+=> {:interest=>"Moviepilot", :id=>6003327847780, :audience=>nil}
 
 ```
 
@@ -137,27 +133,19 @@ Here's a support chart:
     <th style="text-align:center">.save</th>
     <th style="text-align:center">.destroy</th>
     <th style="text-align:center">parent.create_obj*</th>
-    <th style="text-align:center">Convenience methods**</th>
   </tr>
-  <tr><td style="text-align: right">Ad account</td>       <td>✔</td><td>-</td><td>✔</td><td>✔</td><td>-</td><td>-</td></tr>
-  <tr><td style="text-align: right">Ad account group</td> <td>-</td><td>-</td><td>-</td><td>-</td><td>-</td><td>-</td></tr>
-  <tr><td style="text-align: right">Ad campaign</td>      <td>✔</td><td>✔</td><td>✔</td><td>✔</td><td>✔</td><td>-</td></tr>
-  <tr><td style="text-align: right">Ad creative</td>      <td>✔</td><td>-</td><td>-</td><td>-</td><td>-</td><td>-</td></tr>
-  <tr><td style="text-align: right">Ad group</td>         <td>✔</td><td>✔</td><td>✔</td><td>✔</td><td>✔</td><td>-</td></tr>
-  <tr><td style="text-align: right">Ad image</td>         <td>●</td><td>-</td><td>-</td><td>-</td><td>-</td><td>-</td></tr>
-  <tr><td style="text-align: right">Ad user</td>          <td>-</td><td>-</td><td>-</td><td>-</td><td>-</td><td>-</td></tr>
+  <tr><td style="text-align: right">Ad account</td>       <td>✔</td><td>-</td><td>✔</td><td>✔</td><td>-</td></tr>
+  <tr><td style="text-align: right">Ad account group</td> <td>-</td><td>-</td><td>-</td><td>-</td><td>-</td></tr>
+  <tr><td style="text-align: right">Ad campaign</td>      <td>✔</td><td>✔</td><td>✔</td><td>✔</td><td>✔</td></tr>
+  <tr><td style="text-align: right">Ad creative</td>      <td>✔</td><td>-</td><td>-</td><td>-</td><td>-</td></tr>
+  <tr><td style="text-align: right">Ad group</td>         <td>✔</td><td>✔</td><td>✔</td><td>✔</td><td>✔</td></tr>
+  <tr><td style="text-align: right">Ad set</td>         <td>✔</td><td>✔</td><td>✔</td><td>✔</td><td>✔</td></tr>
+  <tr><td style="text-align: right">Ad user</td>          <td>-</td><td>-</td><td>-</td><td>-</td><td>-</td></tr>
 </table>
 
-(*) This means that you can, for example, create a new ad group by calling
+(*) This means if you can, for example, create a new ad group by calling
 `my_campaign.create_ad_group(data)` or not.
 
-(**) Right now, everything goes right to facebook, but we'll want some 
-convenience methods that tell you, for example, what
-`ad_group.ad_status == 3` actually means
-
-( ) These don't exist as their own objects in this gem but live in their 
-parents. This means you can, for now, only read them:
-
 Users don't exist as objects yet, but you can list all ad users of
 an account via `my_ad_account.users` and you will get an array of hashes.
 

data/VERSION

@@ -1 +1 @@
-1.0.0
+2.0.0

data/console

@@ -4,10 +4,11 @@ $LOAD_PATH.unshift File.expand_path(File.join(File.dirname(__FILE__), 'lib'))
 require 'bundler'
 Bundler.require
 
-require 'irb'
+require 'pry'
 require 'zuck'
 
 def reload!
+  Zuck.graph =  Koala::Facebook::API.new(File.read("test_access_token"))
   @loaded_files ||= {}
   count = 0
 
@@ -23,4 +24,9 @@ def reload!
   "reloaded #{count} files"
 end
 
-IRB.start
+def graph
+  Zuck.graph
+end
+
+Zuck.graph =  Koala::Facebook::API.new(File.read("test_access_token"))
+binding.pry

data/lib/zuck/facebook/ad_account.rb

@@ -1,9 +1,9 @@
 module Zuck
   class AdAccount < RawFbObject
+    include Zuck::Helpers
 
-    # The [fb docs](https://developers.facebook.com/docs/reference/ads-api/adaccount/)
-    # were incomplete, so I added here what the graph explorer
-    # actually returned.
+    # Known keys as per
+    # [fb docs](https://developers.facebook.com/docs/reference/ads-api/adaccount/)
     known_keys :account_groups,
                :account_id,
                :account_status,
@@ -19,25 +19,42 @@ module Zuck
                :business_street,
                :business_zip,
                :capabilities,
+               :created_time,
                :currency,
                :daily_spend_limit,
+               :end_advertiser,
+               :funding_source,
+               :funding_source_details,
                :id,
                :is_personal,
+               :media_agency,
                :name,
+               :offsite_pixels_tos_accepted,
+               :partner,
                :spend_cap,
                :timezone_id,
                :timezone_name,
                :timezone_offset_hours_utc,
                :tos_accepted,
                :users,
-               :vat_status
+               :tax_id_status
 
 
     list_path   'me/adaccounts'
-    connections :ad_campaigns
+    connections :ad_campaigns, :ad_sets, :ad_groups
 
     def self.all(graph = Zuck.graph)
       super(graph)
     end
+
+    def path
+      normalize_account_id(id)
+    end
+
+    def set_data(data)
+      super
+      self.id = normalize_account_id(id)
+    end
+
   end
 end

data/lib/zuck/facebook/ad_campaign.rb

@@ -1,23 +1,20 @@
 module Zuck
   class AdCampaign < RawFbObject
 
-    # The [fb docs](https://developers.facebook.com/docs/reference/ads-api/adaccount/)
-    # were incomplete, so I added here what the graph explorer
-    # actually returned.
-    known_keys :account_id,
-               :campaign_status,
-               :created_time,
-               :daily_imps,
-               :end_time,
-               :id,
-               :lifetime_budget,
+    # Known keys as per
+    # the [fb docs](https://developers.facebook.com/docs/reference/ads-api/adcampaign/v2.2)
+    # as well as undocumented keys returned by the Graph API
+    known_keys :id,
+               :account_id,
+               :objective,
                :name,
-               :start_time,
-               :updated_time
+               :adgroups,
+               :campaign_group_status,
+               :buying_type
 
-    parent_object :ad_account
-    list_path     :adcampaigns
-    connections   :ad_groups
+    parent_object :ad_account, as: :account_id
+    list_path     :adcampaign_groups
+    connections   :ad_groups, :ad_campaigns
 
   end
 end

data/lib/zuck/facebook/ad_creative.rb

@@ -4,25 +4,25 @@ module Zuck
     # Can't create this directly (yet)
     read_only
 
-    # The [fb docs](https://developers.facebook.com/docs/reference/ads-api/adaccount/)
-    # were incomplete, so I added here what the graph explorer
-    # actually returned.
-    known_keys :name,
-               :type,
-               :object_id,
+    # Known keys as per
+    # [fb docs](https://developers.facebook.com/docs/reference/ads-api/adaccount/)
+    known_keys :actor_id,
                :body,
+               :call_to_action_type,
+               :follow_redirect,
+               :image_crops,
+               :image_file,
                :image_hash,
                :image_url,
-               :id,
-               :title,
                :link_url,
+               :name,
+               :object_id,
+               :object_story_id,
+               :object_story_spec,
+               :object_url,
+               :title,
                :url_tags,
-               :preview_url,
-               :related_fan_page,
-               :follow_redirect,
-               :auto_update,
-               :story_id,
-               :action_spec
+               :id
 
     parent_object :ad_group
     list_path     :adcreatives

data/lib/zuck/facebook/ad_group.rb

@@ -3,20 +3,20 @@ require 'zuck/facebook/ad_creative'
 module Zuck
   class AdGroup < RawFbObject
 
-    # The [fb docs](https://developers.facebook.com/docs/reference/ads-api/adaccount/)
-    # were incomplete, so I added here what the graph explorer
-    # actually returned.
-    known_keys :account_id,
+    # Known keys as per
+    # [fb docs](https://developers.facebook.com/docs/reference/ads-api/adgroup/v2.2)
+    known_keys :id,
+               :account_id,
                :adgroup_status,
-               :bid_info,
                :bid_type,
+               :bid_info,
+               :conversion_specs,
                :campaign_id,
+               :campaign_group_id,
                :conversion_specs,
                :created_time,
                :creative_ids,
-               :id,
-               :disapprove_reason_descriptions,
-               :last_updated_by_app_id,
+               :failed_delivery_checks,
                :name,
                :targeting,
                :tracking_specs,
@@ -27,10 +27,10 @@ module Zuck
     list_path     :adgroups
     connections   :ad_creatives
 
-    def self.create(graph, data, ad_campaign)
-      path = ad_campaign.ad_account.path
-      data['campaign_id'] = ad_campaign.id
-      super(graph, data, ad_campaign, path)
+    def self.create(graph, data, ad_set)
+      path = ad_set.ad_account.path
+      data['campaign_id'] = ad_set.id
+      super(graph, data, ad_set, path)
     end
 
   end

data/lib/zuck/facebook/ad_interest.rb

@@ -9,35 +9,32 @@ module Zuck
     # popular one
     def best_guess(graph, interest)
       search(graph, interest).sort do |a,b|
-        if a[:audience].to_i > 0 || b[:audience].to_i > 0
-          a[:audience].to_i <=> b[:audience].to_i
+        if a[:audience_size].to_i > 0 || b[:audience_size].to_i > 0
+          a[:audience_size].to_i <=> b[:audience_size].to_i
         else
-          b[:interest].length <=> a[:interest].length
+          b[:name].length <=> a[:name].length
         end
       end.last
     end
 
-    # Checks the ad api to see if the given interests are valid
+    # Checks the ad api to see if the given interests are valid. You can either
+    # pass it an array of strings, or an array of hashes with `:name` and `:id` keys.
     # @return [Hash] The keys are the (lowercased) interests and the values their validity
     def validate(graph, interests)
-      interests = normalize_array(interests).map{|k| k.gsub(',', '%2C')}
-      search = graph.search(nil, type: 'adinterestvalid', interest_list: [interests].flatten)
       results = {}
-      search.each do |r|
-        results[r['name']] = r['valid']
+      normalized = normalize_array(values_from_string_or_object_interests(interests))
+      normalized.each do |interest|
+        # The interest is valid if we found at least one match that
+        # has the exactly the same name (ignoring case)
+        hits = search(graph, interest).select{|d| d['name'].downcase == interest.downcase}
+        results[interest] = hits.count > 0
       end
       results
     end
 
     # Ad interest search
     def search(graph, interest)
-      results = graph.search(interest, type: :adinterest).map do |r|
-        {
-          interest: r['name'],
-          id:   r['id'],
-          audience: r['audience_size']
-        }
-      end
+      graph.search(interest, type: :adinterest).map(&:with_indifferent_access)
     end
   end
 

data/lib/zuck/facebook/ad_set.rb

@@ -0,0 +1,30 @@
+require 'zuck/facebook/ad_creative'
+
+module Zuck
+  class AdSet < RawFbObject
+
+    # Known keys as per
+    # [fb docs](https://developers.facebook.com/docs/reference/ads-api/adset/v2.2)
+    known_keys :id,
+               :name,
+               :account_id,
+               :bid_type,
+               :bid_info,
+               :campaign_group_id,
+               :campaign_status,
+               :start_time,
+               :end_time,
+               :updated_time,
+               :created_time,
+               :daily_budget,
+               :lifetime_budget,
+               :budget_remaining,
+               :targeting,
+               :promoted_object
+
+    parent_object :ad_account, as: :account_id
+    list_path     :adcampaigns # Yes, this is correct, "for legacy reasons"
+    connections   :ad_groups, :ad_creatives
+
+  end
+end

data/lib/zuck/facebook/targeting_spec.rb

@@ -70,7 +70,7 @@ module Zuck
     def initialize(graph, ad_account, spec = nil)
       @validated_interests = {}
       @graph = graph
-      @ad_account = "act_#{ad_account}".gsub('act_act_', 'act_')
+      @ad_account = normalize_account_id(ad_account)
       self.spec = spec
     end
 
@@ -104,7 +104,7 @@ module Zuck
     # @return boolean
     def validate_interest(interest)
       if @validated_interests[interest] == nil
-        interests = normalize_array([@spec[:interests]] + [interest])
+        interests = [@spec[:interests]] + [interest]
         @validated_interests = Zuck::AdInterest.validate(@graph, interests)
       end
       @validated_interests[interest] == true
@@ -153,7 +153,7 @@ module Zuck
     private
 
     def validate_spec
-      @spec[:interests]    = normalize_array(@spec[:interests])
+      @spec[:interests] = @spec[:interests]
       @spec[:broad_age] ||= false
       validate_countries
       unless @spec[:interests].present? or @spec[:connections].present?
@@ -195,7 +195,7 @@ module Zuck
       @spec[:genders] = [2] if gender.to_s == 'female'
 
       interest = spec.delete(:interest)
-      @spec[:interests] = normalize_array([interest, @spec[:interests]])
+      @spec[:interests] = [interest, @spec[:interests]].compact.flatten
 
       country = spec.delete(:country)
       @spec[:countries] = normalize_countries([country, @spec[:countries]])