zendesk2 1.9.0 → 1.10.0

data/lib/zendesk2/get_topic_comment.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetTopicComment
   include Zendesk2::Request
 
@@ -5,14 +6,14 @@ class Zendesk2::GetTopicComment
   request_path { |r| "/topics/#{r.topic_id}/comments/#{r.topic_comment_id}.json" }
 
   def topic_id
-    params.fetch("topic_comment").fetch("topic_id")
+    params.fetch('topic_comment').fetch('topic_id')
   end
 
   def topic_comment_id
-    params.fetch("topic_comment").fetch("id")
+    params.fetch('topic_comment').fetch('id')
   end
 
   def mock
-    mock_response("topic_comment" => self.find!(:topic_comments, topic_comment_id))
+    mock_response('topic_comment' => find!(:topic_comments, topic_comment_id))
   end
 end

data/lib/zendesk2/get_topic_comments.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetTopicComments
   include Zendesk2::Request
 
@@ -7,14 +8,14 @@ class Zendesk2::GetTopicComments
   page_params!
 
   def topic_id
-    params.fetch("topic_id")
+    params.fetch('topic_id')
   end
 
   def mock
-    self.find!(:topics, topic_id)
+    find!(:topics, topic_id)
 
-    topic_comments = self.data[:topic_comments].values.select { |c| c["topic_id"] == topic_id }
+    topic_comments = data[:topic_comments].values.select { |c| c['topic_id'] == topic_id }
 
-    page(topic_comments, root: "topic_comments")
+    page(topic_comments, root: 'topic_comments')
   end
 end

data/lib/zendesk2/get_topics.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
 class Zendesk2::GetTopics
   include Zendesk2::Request
 
-  request_path { |r| "/topics.json" }
+  request_path { |_r| '/topics.json' }
 
   page_params!
 

data/lib/zendesk2/get_user.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetUser
   include Zendesk2::Request
 
@@ -5,19 +6,18 @@ class Zendesk2::GetUser
   request_path { |r| "/users/#{r.user_id}.json" }
 
   def user_id
-    params.fetch("user").fetch("id").to_i
+    params.fetch('user').fetch('id').to_i
   end
 
   def mock
-    identities = self.data[:identities].values.select { |i| i["user_id"] == user_id }
+    identities = data[:identities].values.select { |i| i['user_id'] == user_id }
     body = find!(:users, user_id).dup
-
-    if identity = identities.find { |i| i["type"] == "email" && i["primary"] } || identities.find { |i| i["type"] == "email" }
-      body.merge!("email" => identity["value"])
-    end
+    identity = identities.find { |i| i['type'] == 'email' && i['primary'] } ||
+               identities.find { |i| i['type'] == 'email' }
+    body['email'] = identity['value'] if identity
 
     # @todo what happens if no identity?
 
-    mock_response("user" => body)
+    mock_response('user' => body)
   end
 end

data/lib/zendesk2/get_user_field.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetUserField
   include Zendesk2::Request
 
@@ -5,10 +6,10 @@ class Zendesk2::GetUserField
   request_method :get
 
   def user_field_id
-    params.fetch("user_field").fetch("id")
+    params.fetch('user_field').fetch('id')
   end
 
   def mock
-    mock_response("user_field" => find!(:user_fields, user_field_id))
+    mock_response('user_field' => find!(:user_fields, user_field_id))
   end
 end

data/lib/zendesk2/get_user_fields.rb

@@ -1,12 +1,13 @@
+# frozen_string_literal: true
 class Zendesk2::GetUserFields
   include Zendesk2::Request
 
   request_method :get
-  request_path { "/user_fields.json" }
+  request_path { '/user_fields.json' }
 
   page_params!
 
-  def mock(params={})
+  def mock(_params = {})
     page(:user_fields)
   end
 end

data/lib/zendesk2/get_user_identities.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetUserIdentities
   include Zendesk2::Request
 
@@ -6,12 +7,12 @@ class Zendesk2::GetUserIdentities
   page_params!
 
   def user_id
-    params.fetch("user_id").to_i
+    params.fetch('user_id').to_i
   end
 
   def mock
-    identities = cistern.data[:identities].values.select { |a| a["user_id"] == user_id }
+    identities = cistern.data[:identities].values.select { |a| a['user_id'] == user_id }
 
-    page(identities, root: "identities")
+    page(identities, root: 'identities')
   end
 end

data/lib/zendesk2/get_user_identity.rb

@@ -1,17 +1,18 @@
+# frozen_string_literal: true
 class Zendesk2::GetUserIdentity
   include Zendesk2::Request
 
   request_path { |r| "/users/#{r.user_id}/identities/#{r.user_identity_id}.json" }
 
   def user_identity_id
-    params.fetch("user_identity").fetch("id").to_i
+    params.fetch('user_identity').fetch('id').to_i
   end
 
   def user_id
-    params.fetch("user_identity").fetch("user_id").to_i
+    params.fetch('user_identity').fetch('user_id').to_i
   end
 
   def mock
-    mock_response("identity" => find!(:identities, user_identity_id))
+    mock_response('identity' => find!(:identities, user_identity_id))
   end
 end

data/lib/zendesk2/get_user_memberships.rb

@@ -1,16 +1,17 @@
+# frozen_string_literal: true
 class Zendesk2::GetUserMemberships
   include Zendesk2::Request
 
   request_method :get
-  request_path  { |r| "/users/#{r.user_id}/organization_memberships.json" }
+  request_path { |r| "/users/#{r.user_id}/organization_memberships.json" }
 
   page_params!
 
   def user_id
-    params.fetch("membership").fetch("user_id").to_i
+    params.fetch('membership').fetch('user_id').to_i
   end
 
   def mock
-    page(self.data[:memberships].values.select { |m| m["user_id"] == user_id }, root: "organization_memberships")
+    page(data[:memberships].values.select { |m| m['user_id'] == user_id }, root: 'organization_memberships')
   end
 end

data/lib/zendesk2/get_user_organizations.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetUserOrganizations
   include Zendesk2::Request
 
@@ -7,13 +8,13 @@ class Zendesk2::GetUserOrganizations
   page_params!
 
   def user_id
-    params.fetch("user_id").to_i
+    params.fetch('user_id').to_i
   end
 
   def mock
-    memberships = self.data[:memberships].values.select { |m| m["user_id"] == user_id }
-    organizations = memberships.map { |m| self.data[:organizations].fetch(m["organization_id"]) }
+    memberships = data[:memberships].values.select { |m| m['user_id'] == user_id }
+    organizations = memberships.map { |m| data[:organizations].fetch(m['organization_id']) }
 
-    page(organizations, root: "organizations")
+    page(organizations, root: 'organizations')
   end
 end

data/lib/zendesk2/get_users.rb

@@ -1,12 +1,13 @@
+# frozen_string_literal: true
 class Zendesk2::GetUsers
   include Zendesk2::Request
 
   request_method :get
-  request_path { "/users.json" }
+  request_path { '/users.json' }
 
   page_params!
 
-  def mock(params={})
+  def mock(params = {})
     page(:users, params)
   end
 end

data/lib/zendesk2/get_view.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetView
   include Zendesk2::Request
 
@@ -5,10 +6,10 @@ class Zendesk2::GetView
   request_path { |r| "/views/#{r.view_id}.json" }
 
   def view_id
-    params.fetch("view").fetch("id")
+    params.fetch('view').fetch('id')
   end
 
   def mock
-    mock_response("view" => self.find!(:views, view_id))
+    mock_response('view' => find!(:views, view_id))
   end
 end

data/lib/zendesk2/get_view_tickets.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetViewTickets
   include Zendesk2::Request
 
@@ -7,33 +8,35 @@ class Zendesk2::GetViewTickets
   page_params!
 
   def view_id
-    params.fetch("view_id").to_i
+    params.fetch('view_id').to_i
   end
 
-  def mock(params={})
-    view = self.find!(:views, view_id)
+  def mock(_params = {})
+    view = find!(:views, view_id)
 
-    tickets = Array(view["conditions"]["all"]).map { |c|
-      operator = ("is" == c.fetch("operator")) ? :eql? : :!=
-      key      = c.fetch("field")
-      value    = c.fetch("value").to_s
+    operators = Array(view['conditions']['all']).map do |c|
+      operator = ('is' == c.fetch('operator')) ? :eql? : :!=
+      key      = c.fetch('field')
+      value    = c.fetch('value').to_s
 
       [operator, key, value]
-    }.inject(self.data[:tickets].values) { |r, (o,k,v)|
+    end
+
+    tickets = operators.inject(data[:tickets].values) do |r, (o, k, v)|
       r.select { |t| t[k].to_s.public_send(o, v) }
-    }
+    end
 
-    any_operators = Array(view["conditions"]["any"]).map { |c|
-      operator = ("is" == c.fetch("operator")) ? :eql? : :!=
-      key      = c.fetch("field")
-      value    = c.fetch("value").to_s
+    any_operators = Array(view['conditions']['any']).map do |c|
+      operator = ('is' == c.fetch('operator')) ? :eql? : :!=
+      key      = c.fetch('field')
+      value    = c.fetch('value').to_s
 
       [operator, key, value]
-    }
+    end
 
     any_operators.any? &&
-      tickets.select! { |t| any_operators.find { |(o,k,v)| t[k].to_s.public_send(o, v) } }
+      tickets.select! { |t| any_operators.find { |(o, k, v)| t[k].to_s.public_send(o, v) } }
 
-    page(tickets, root: "tickets")
+    page(tickets, root: 'tickets')
   end
 end

data/lib/zendesk2/get_views.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
 class Zendesk2::GetViews
   include Zendesk2::Request
 
   request_method :get
-  request_path { |r| "/views.json" }
+  request_path { |_r| '/views.json' }
 
   page_params!
 

data/lib/zendesk2/group.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::Group
   include Zendesk2::Model
 
@@ -21,12 +22,12 @@ class Zendesk2::Group
     data = if new_record?
              requires :name
 
-             cistern.create_group("group" => self.attributes)
+             cistern.create_group('group' => attributes)
            else
              requires :identity
 
-             cistern.update_group("group" => self.attributes)
-           end.body["group"]
+             cistern.update_group('group' => attributes)
+           end.body['group']
 
     merge_attributes(data)
   end
@@ -34,12 +35,12 @@ class Zendesk2::Group
   def destroy!
     requires :identity
 
-    cistern.destroy_group("group" => {"id" => self.identity})
+    cistern.destroy_group('group' => { 'id' => identity })
 
     self.deleted = true
   end
 
   def destroyed?
-    self.deleted
+    deleted
   end
 end

data/lib/zendesk2/groups.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::Groups
   include Zendesk2::Collection
 
@@ -7,14 +8,14 @@ class Zendesk2::Groups
   model Zendesk2::Group
 
   self.collection_method = :get_groups
-  self.collection_root   = "groups"
+  self.collection_root   = 'groups'
   self.model_method      = :get_group
-  self.model_root        = "group"
-  self.search_type       = "group"
+  self.model_root        = 'group'
+  self.search_type       = 'group'
 
   def assignable
-    data = self.cistern.get_assignable_groups.body
-    collection = self.cistern.groups.load(data["groups"])
-    collection.merge_attributes(Cistern::Hash.slice(data, "next_page", "previous_page", "count"))
+    data = cistern.get_assignable_groups.body
+    collection = cistern.groups.load(data['groups'])
+    collection.merge_attributes(Cistern::Hash.slice(data, 'next_page', 'previous_page', 'count'))
   end
 end

data/lib/zendesk2/help_center.rb

@@ -1,15 +1,20 @@
+# frozen_string_literal: true
 module Zendesk2::HelpCenter; end
 
 require 'zendesk2/help_center/translation_source'
 
 require 'zendesk2/help_center/create_help_center_article'
 require 'zendesk2/help_center/create_help_center_category'
+require 'zendesk2/help_center/create_help_center_post'
 require 'zendesk2/help_center/create_help_center_section'
+require 'zendesk2/help_center/create_help_center_topic'
 require 'zendesk2/help_center/create_help_center_translation'
 require 'zendesk2/help_center/destroy_help_center_article'
 require 'zendesk2/help_center/destroy_help_center_category'
+require 'zendesk2/help_center/destroy_help_center_post'
 require 'zendesk2/help_center/destroy_help_center_section'
 require 'zendesk2/help_center/destroy_help_center_translation'
+require 'zendesk2/help_center/destroy_help_center_topic'
 require 'zendesk2/help_center/get_help_center_access_policy'
 require 'zendesk2/help_center/get_help_center_article'
 require 'zendesk2/help_center/get_help_center_articles'
@@ -17,25 +22,35 @@ require 'zendesk2/help_center/get_help_center_categories'
 require 'zendesk2/help_center/get_help_center_categories_articles'
 require 'zendesk2/help_center/get_help_center_categories_sections'
 require 'zendesk2/help_center/get_help_center_category'
+require 'zendesk2/help_center/get_help_center_post'
+require 'zendesk2/help_center/get_help_center_posts'
 require 'zendesk2/help_center/get_help_center_section'
 require 'zendesk2/help_center/get_help_center_sections'
 require 'zendesk2/help_center/get_help_center_sections_articles'
+require 'zendesk2/help_center/get_help_center_topic'
+require 'zendesk2/help_center/get_help_center_topics'
 require 'zendesk2/help_center/get_help_center_translation'
 require 'zendesk2/help_center/get_help_center_translations'
 require 'zendesk2/help_center/search_help_center_articles'
 require 'zendesk2/help_center/update_help_center_access_policy'
 require 'zendesk2/help_center/update_help_center_article'
 require 'zendesk2/help_center/update_help_center_category'
+require 'zendesk2/help_center/update_help_center_post'
 require 'zendesk2/help_center/update_help_center_section'
+require 'zendesk2/help_center/update_help_center_topic'
 require 'zendesk2/help_center/update_help_center_translation'
 
 require 'zendesk2/help_center/access_policy'
 require 'zendesk2/help_center/article'
 require 'zendesk2/help_center/category'
+require 'zendesk2/help_center/post'
 require 'zendesk2/help_center/section'
+require 'zendesk2/help_center/topic'
 require 'zendesk2/help_center/translation'
 
 require 'zendesk2/help_center/articles'
 require 'zendesk2/help_center/categories'
+require 'zendesk2/help_center/posts'
 require 'zendesk2/help_center/sections'
+require 'zendesk2/help_center/topics'
 require 'zendesk2/help_center/translations'

data/lib/zendesk2/help_center/access_policy.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::HelpCenter::AccessPolicy
   include Zendesk2::Model
 
@@ -20,7 +21,7 @@ class Zendesk2::HelpCenter::AccessPolicy
   def save!
     requires :section_id
 
-    response = cistern.update_help_center_access_policy("access_policy" => self.attributes, "section_id" => self.section_id)
-    merge_attributes(response.body["access_policy"])
+    response = cistern.update_help_center_access_policy('access_policy' => attributes, 'section_id' => section_id)
+    merge_attributes(response.body['access_policy'])
   end
 end