zendesk2 1.9.0 → 1.10.0

data/lib/zendesk2/get_current_user.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
 class Zendesk2::GetCurrentUser
   include Zendesk2::Request
 
   request_method :get
-  request_path { |_| "/users/me.json" }
+  request_path { |_| '/users/me.json' }
 
   def mock
-    cistern.get_user("user" => {"id" => cistern.current_user.fetch("id")})
+    cistern.get_user('user' => { 'id' => cistern.current_user.fetch('id') })
   end
 end

data/lib/zendesk2/get_forum.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetForum
   include Zendesk2::Request
 
@@ -5,12 +6,12 @@ class Zendesk2::GetForum
   request_path { |r| "/forums/#{r.forum_id}.json" }
 
   def forum_id
-    params.fetch("forum").fetch("id")
+    params.fetch('forum').fetch('id')
   end
 
   def mock
     mock_response(
-      "forum" => find!(:forums, forum_id)
+      'forum' => find!(:forums, forum_id)
     )
   end
 end

data/lib/zendesk2/get_forums.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
 class Zendesk2::GetForums
   include Zendesk2::Request
 
   request_method :get
-  request_path { |_| "/forums.json" }
+  request_path { |_| '/forums.json' }
 
   page_params!
 

data/lib/zendesk2/get_group.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetGroup
   include Zendesk2::Request
 
@@ -5,10 +6,10 @@ class Zendesk2::GetGroup
   request_path { |r| "/groups/#{r.group_id}.json" }
 
   def group_id
-    @_group_id ||= params.fetch("group").fetch("id")
+    @_group_id ||= params.fetch('group').fetch('id')
   end
 
   def mock
-    mock_response("group" => find!(:groups, group_id))
+    mock_response('group' => find!(:groups, group_id))
   end
 end

data/lib/zendesk2/get_groups.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
 class Zendesk2::GetGroups
   include Zendesk2::Request
 
   request_method :get
-  request_path { |_| "/groups.json" }
+  request_path { |_| '/groups.json' }
 
   page_params!
 

data/lib/zendesk2/get_membership.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetMembership
   include Zendesk2::Request
 
@@ -5,10 +6,10 @@ class Zendesk2::GetMembership
   request_path { |r| "/organization_memberships/#{r.membership_id}.json" }
 
   def membership_id
-    params.fetch("organization_membership").fetch("id")
+    params.fetch('organization_membership').fetch('id')
   end
 
   def mock
-    mock_response("organization_membership" => find!(:memberships, membership_id))
+    mock_response('organization_membership' => find!(:memberships, membership_id))
   end
 end

data/lib/zendesk2/get_memberships.rb

@@ -1,12 +1,13 @@
+# frozen_string_literal: true
 class Zendesk2::GetMemberships
   include Zendesk2::Request
 
   request_method :get
-  request_path { |r| "/organization_memberships.json" }
+  request_path { |_r| '/organization_memberships.json' }
 
   page_params!
 
   def mock
-    page(self.data[:memberships].values, root: "organization_memberships")
+    page(data[:memberships].values, root: 'organization_memberships')
   end
 end

data/lib/zendesk2/get_organization.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetOrganization
   include Zendesk2::Request
 
@@ -5,10 +6,10 @@ class Zendesk2::GetOrganization
   request_path { |r| "/organizations/#{r.organization_id}.json" }
 
   def organization_id
-    params.fetch("organization").fetch("id").to_i
+    params.fetch('organization').fetch('id').to_i
   end
 
   def mock
-    mock_response("organization" => find!(:organizations, organization_id))
+    mock_response('organization' => find!(:organizations, organization_id))
   end
 end

data/lib/zendesk2/get_organization_by_external_id.rb

@@ -1,17 +1,20 @@
+# frozen_string_literal: true
 class Zendesk2::GetOrganizationByExternalId
   include Zendesk2::Request
 
   request_method :get
-  request_params { |r| { "external_id" => r.external_id } }
-  request_path   { |_| "/organizations/search.json" }
+  request_params { |r| { 'external_id' => r.external_id } }
+  request_path   { |_| '/organizations/search.json' }
 
   def external_id
-    params.fetch("external_id")
+    params.fetch('external_id')
   end
 
   def mock
-    results = self.data[:organizations].select { |k,v| v["external_id"].to_s.downcase == external_id.to_s.downcase }.values
+    results = data[:organizations].select do |_k, v|
+      v['external_id'].to_s.casecmp(external_id.to_s.downcase).zero?
+    end.values
 
-    mock_response("organizations" => results)
+    mock_response('organizations' => results)
   end
 end

data/lib/zendesk2/get_organization_memberships.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetOrganizationMemberships
   include Zendesk2::Request
 
@@ -7,10 +8,12 @@ class Zendesk2::GetOrganizationMemberships
   page_params!
 
   def organization_id
-    params.fetch("membership").fetch("organization_id").to_i
+    params.fetch('membership').fetch('organization_id').to_i
   end
 
   def mock
-    page(self.data[:memberships].values.select { |m| m["organization_id"] == organization_id }, root: "organization_memberships")
+    collection = data[:memberships].values.select { |m| m['organization_id'] == organization_id }
+
+    page(collection, root: 'organization_memberships')
   end
 end

data/lib/zendesk2/get_organization_tickets.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetOrganizationTickets
   include Zendesk2::Request
 
@@ -7,14 +8,15 @@ class Zendesk2::GetOrganizationTickets
   page_params!
 
   def organization_id
-    params.fetch("organization_id").to_i
+    params.fetch('organization_id').to_i
   end
 
-  def mock(params={})
-    requesters = self.data[:users].values.select { |u| u["organization_id"] == organization_id }.map { |s| s["organization_id"] }
+  def mock(_params = {})
+    organizations = data[:users].values.select { |u| u['organization_id'] == organization_id }
+    requesters = organizations.map { |s| s['organization_id'] }
 
-    tickets = self.data[:tickets].values.select { |t| requesters.include?(t["organization_id"]) }
+    tickets = data[:tickets].values.select { |t| requesters.include?(t['organization_id']) }
 
-    page(tickets, root: "tickets")
+    page(tickets, root: 'tickets')
   end
 end

data/lib/zendesk2/get_organization_users.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetOrganizationUsers
   include Zendesk2::Request
 
@@ -7,14 +8,14 @@ class Zendesk2::GetOrganizationUsers
   page_params!
 
   def organization_id
-    params.fetch("organization").fetch("id").to_i
+    params.fetch('organization').fetch('id').to_i
   end
 
   def mock
-    users = self.data[:memberships].values.
-      select { |m| m["organization_id"] == organization_id }.
-      map    { |m| self.data[:users].fetch(m["user_id"]) }
+    users = data[:memberships].values
+                              .select { |m| m['organization_id'] == organization_id }
+                              .map    { |m| data[:users].fetch(m['user_id']) }
 
-    page(users, root: "users")
+    page(users, root: 'users')
   end
 end

data/lib/zendesk2/get_organizations.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
 class Zendesk2::GetOrganizations
   include Zendesk2::Request
 
   request_method :get
-  request_path { |_| "/organizations.json" }
+  request_path { |_| '/organizations.json' }
 
   page_params!
 

data/lib/zendesk2/get_requested_tickets.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetRequestedTickets
   include Zendesk2::Request
 
@@ -7,12 +8,12 @@ class Zendesk2::GetRequestedTickets
   page_params!
 
   def requester_id
-    params.fetch("requester_id").to_i
+    params.fetch('requester_id').to_i
   end
 
-  def mock(params={})
-    tickets = self.data[:tickets].values.select { |u| u["requester_id"] == requester_id }
+  def mock(_params = {})
+    tickets = data[:tickets].values.select { |u| u['requester_id'] == requester_id }
 
-    page(tickets, root: "tickets")
+    page(tickets, root: 'tickets')
   end
 end

data/lib/zendesk2/get_ticket.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetTicket
   include Zendesk2::Request
 
@@ -5,10 +6,10 @@ class Zendesk2::GetTicket
   request_path { |r| "/tickets/#{r.ticket_id}.json" }
 
   def ticket_id
-    params.fetch("ticket").fetch("id")
+    params.fetch('ticket').fetch('id')
   end
 
   def mock
-    mock_response("ticket" => self.find!(:tickets, ticket_id))
+    mock_response('ticket' => find!(:tickets, ticket_id))
   end
 end

data/lib/zendesk2/get_ticket_audit.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetTicketAudit
   include Zendesk2::Request
 
@@ -5,14 +6,14 @@ class Zendesk2::GetTicketAudit
   request_path { |r| "/tickets/#{r.ticket_id}/audits/#{r.audit_id}.json" }
 
   def audit_id
-    params.fetch("id")
+    params.fetch('id')
   end
 
   def ticket_id
-    params.fetch("ticket_id")
+    params.fetch('ticket_id')
   end
 
-  def mock(params={})
-    mock_response("ticket_audit" => find!(:ticket_audits, audit_id))
+  def mock(_params = {})
+    mock_response('ticket_audit' => find!(:ticket_audits, audit_id))
   end
 end

data/lib/zendesk2/get_ticket_audits.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetTicketAudits
   include Zendesk2::Request
 
@@ -7,12 +8,12 @@ class Zendesk2::GetTicketAudits
   page_params!
 
   def ticket_id
-    params.fetch("ticket_id").to_i
+    params.fetch('ticket_id').to_i
   end
 
   def mock
-    audits = self.data[:ticket_audits].values.select { |a| a["ticket_id"] == ticket_id }
+    audits = data[:ticket_audits].values.select { |a| a['ticket_id'] == ticket_id }
 
-    page(audits, root: "audits")
+    page(audits, root: 'audits')
   end
 end

data/lib/zendesk2/get_ticket_comments.rb

@@ -1,16 +1,17 @@
+# frozen_string_literal: true
 class Zendesk2::GetTicketComments
   include Zendesk2::Request
 
   request_method :get
-  request_path { |r|  "/tickets/#{r.ticket_id}/comments.json" }
+  request_path { |r| "/tickets/#{r.ticket_id}/comments.json" }
 
   def ticket_id
-    params.fetch("ticket_id").to_i
+    params.fetch('ticket_id').to_i
   end
 
-  def mock(params={})
-    comments = self.data[:ticket_comments].values.select { |comment| comment["ticket_id"] == ticket_id }
+  def mock(_params = {})
+    comments = data[:ticket_comments].values.select { |comment| comment['ticket_id'] == ticket_id }
 
-    page(comments, root: "comments")
+    page(comments, root: 'comments')
   end
 end

data/lib/zendesk2/get_ticket_field.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetTicketField
   include Zendesk2::Request
 
@@ -5,10 +6,10 @@ class Zendesk2::GetTicketField
   request_path { |r| "/ticket_fields/#{r.ticket_field_id}.json" }
 
   def ticket_field_id
-    params.fetch("ticket_field").fetch("id").to_i
+    params.fetch('ticket_field').fetch('id').to_i
   end
 
   def mock
-    mock_response("ticket_field" => find!(:ticket_fields, ticket_field_id))
+    mock_response('ticket_field' => find!(:ticket_fields, ticket_field_id))
   end
 end

data/lib/zendesk2/get_ticket_fields.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
 class Zendesk2::GetTicketFields
   include Zendesk2::Request
 
   request_method :get
-  request_path { |_| "/ticket_fields.json" }
+  request_path { |_| '/ticket_fields.json' }
 
   page_params!
 

data/lib/zendesk2/get_ticket_metric.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class Zendesk2::GetTicketMetric
   include Zendesk2::Request
 
@@ -7,16 +8,16 @@ class Zendesk2::GetTicketMetric
   end
 
   def metric_id
-    params["id"]
+    params['id']
   end
 
   def ticket_id
-    params.fetch("ticket_id")
+    params.fetch('ticket_id')
   end
 
   def mock
     mock_response(
-      "ticket_metric" => find!(:ticket_metrics, metric_id)
+      'ticket_metric' => find!(:ticket_metrics, metric_id)
     )
   end
 end

data/lib/zendesk2/get_ticket_metrics.rb

@@ -1,12 +1,13 @@
+# frozen_string_literal: true
 class Zendesk2::GetTicketMetrics
   include Zendesk2::Request
 
   request_method :get
-  request_path { "/ticket_metrics.json" }
+  request_path { '/ticket_metrics.json' }
 
   page_params!
 
   def mock
-    page(:ticket_metrics, root: "metrics")
+    page(:ticket_metrics, root: 'metrics')
   end
 end

data/lib/zendesk2/get_tickets.rb

@@ -1,8 +1,9 @@
+# frozen_string_literal: true
 class Zendesk2::GetTickets
   include Zendesk2::Request
 
   request_method :get
-  request_path { |r| "/tickets.json" }
+  request_path { |_r| '/tickets.json' }
 
   page_params!
 

data/lib/zendesk2/get_topic.rb

@@ -1,13 +1,14 @@
+# frozen_string_literal: true
 class Zendesk2::GetTopic
   include Zendesk2::Request
 
   request_path { |r| "/topics/#{r.topic_id}.json" }
 
   def topic_id
-    params.fetch("topic").fetch("id")
+    params.fetch('topic').fetch('id')
   end
 
   def mock
-    mock_response("topic" => self.find!(:topics, topic_id))
+    mock_response('topic' => find!(:topics, topic_id))
   end
 end