yousty-activeadmin 1.0.4.pre → 1.0.5.pre

data/spec/unit/csv_builder_spec.rb

@@ -1,32 +1,46 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe ActiveAdmin::CSVBuilder do
 
   describe '.default_for_resource using Post' do
-    let(:csv_builder) { ActiveAdmin::CSVBuilder.default_for_resource(Post) }
+    let(:csv_builder) { ActiveAdmin::CSVBuilder.default_for_resource(Post).tap(&:exec_columns) }
 
-    it "should return a default csv_builder for Post" do
-      csv_builder.should be_a(ActiveAdmin::CSVBuilder)
+    it 'returns a default csv_builder for Post' do
+      expect(csv_builder).to be_a(ActiveAdmin::CSVBuilder)
     end
 
-    specify "the first column should be Id" do
-      csv_builder.columns.first.name.should == 'Id'
-      csv_builder.columns.first.data.should == :id
+    it 'defines Id as the first column' do
+      expect(csv_builder.columns.first.name).to eq 'Id'
+      expect(csv_builder.columns.first.data).to eq :id
     end
 
-    specify "the following columns should be content_column" do
+    it "has Post's content_columns" do
       csv_builder.columns[1..-1].each_with_index do |column, index|
-        column.name.should == Post.content_columns[index].name.titleize
-        column.data.should == Post.content_columns[index].name.to_sym
+        expect(column.name).to eq Post.content_columns[index].name.humanize
+        expect(column.data).to eq Post.content_columns[index].name.to_sym
+      end
+    end
+
+    context 'when column has a localized name' do
+      let(:localized_name) { 'Titulo' }
+
+      before do
+        allow(Post).to receive(:human_attribute_name).and_call_original
+        allow(Post).to receive(:human_attribute_name).with(:title){ localized_name }
+      end
+
+      it 'gets name from I18n' do
+        title_index = Post.content_columns.map(&:name).index('title') + 1 # First col is always id
+        expect(csv_builder.columns[title_index].name).to eq localized_name
       end
     end
   end
 
   context 'when empty' do
-    let(:builder){ ActiveAdmin::CSVBuilder.new }
+    let(:builder){ ActiveAdmin::CSVBuilder.new.tap(&:exec_columns) }
 
     it "should have no columns" do
-      builder.columns.should == []
+      expect(builder.columns).to eq []
     end
   end
 
@@ -34,22 +48,22 @@ describe ActiveAdmin::CSVBuilder do
     let(:builder) do
       ActiveAdmin::CSVBuilder.new do
         column :title
-      end
+      end.tap(&:exec_columns)
     end
 
     it "should have one column" do
-      builder.columns.size.should == 1
+      expect(builder.columns.size).to eq 1
     end
 
     describe "the column" do
       let(:column){ builder.columns.first }
 
       it "should have a name of 'Title'" do
-        column.name.should == "Title"
+        expect(column.name).to eq "Title"
       end
 
       it "should have the data :title" do
-        column.data.should == :title
+        expect(column.data).to eq :title
       end
     end
   end
@@ -60,44 +74,158 @@ describe ActiveAdmin::CSVBuilder do
         column "My title" do
           # nothing
         end
-      end
+      end.tap(&:exec_columns)
     end
 
     it "should have one column" do
-      builder.columns.size.should == 1
+      expect(builder.columns.size).to eq 1
     end
 
     describe "the column" do
       let(:column){ builder.columns.first }
 
       it "should have a name of 'My title'" do
-        column.name.should == "My title"
+        expect(column.name).to eq "My title"
       end
 
       it "should have the data :title" do
-        column.data.should be_an_instance_of(Proc)
+        expect(column.data).to be_an_instance_of(Proc)
+      end
+    end
+  end
+
+  context "with a humanize_name column option" do
+    context "with symbol column name" do
+      let(:builder) do
+        ActiveAdmin::CSVBuilder.new do
+          column :my_title, humanize_name: false
+        end.tap(&:exec_columns)
+      end
+
+      describe "the column" do
+        let(:column){ builder.columns.first }
+
+        it "should have a name of 'my_title'" do
+          expect(column.name).to eq "my_title"
+        end
+      end
+    end
+
+    context "with string column name" do
+      let(:builder) do
+        ActiveAdmin::CSVBuilder.new do
+          column "my_title", humanize_name: false
+        end.tap(&:exec_columns)
+      end
+
+      describe "the column" do
+        let(:column){ builder.columns.first }
+
+        it "should have a name of 'my_title'" do
+          expect(column.name).to eq "my_title"
+        end
       end
     end
   end
 
   context "with a separator" do
     let(:builder) do
-      ActiveAdmin::CSVBuilder.new :col_sep => ";"
+      ActiveAdmin::CSVBuilder.new(col_sep: ";").tap(&:exec_columns)
     end
 
     it "should have proper separator" do
-      builder.options.should == {:col_sep => ";"}
+      expect(builder.options).to eq({col_sep: ";"})
+    end
+  end
+
+  context "with humanize_name option" do
+    let(:builder) do
+      ActiveAdmin::CSVBuilder.new(humanize_name: false) do
+        column :my_title
+      end.tap(&:exec_columns)
+    end
+
+    describe "the column" do
+      let(:column){ builder.columns.first }
+
+      it "should have humanize_name option set" do
+        expect(column.options).to eq humanize_name: false
+      end
+
+      it "should have a name of 'my_title'" do
+        expect(column.name).to eq "my_title"
+      end
     end
   end
 
   context "with csv_options" do
     let(:builder) do
-      ActiveAdmin::CSVBuilder.new :force_quotes => true
+      ActiveAdmin::CSVBuilder.new(force_quotes: true).tap(&:exec_columns)
     end
 
     it "should have proper separator" do
-      builder.options.should == {:force_quotes => true}
+      expect(builder.options).to eq({force_quotes: true})
+    end
+  end
+
+  context "with access to the controller" do
+    let(:dummy_view_context) { double(controller: dummy_controller) }
+    let(:dummy_controller) { double(names: %w(title summary updated_at created_at))}
+    let(:builder) do
+      ActiveAdmin::CSVBuilder.new do
+        column "id"
+        controller.names.each do |name|
+          column(name)
+        end
+      end.tap{ |b| b.exec_columns(dummy_view_context) }
+    end
+
+    it "should build columns provided by the controller" do
+      expect(builder.columns.map(&:data)).to match_array([:id, :title, :summary, :updated_at, :created_at])
+    end
+  end
+
+  context "build csv using the supplied order" do
+    before do
+      @post1 = Post.create!(title: "Hello1", published_at: Date.today - 2.day )
+      @post2 = Post.create!(title: "Hello2", published_at: Date.today - 1.day )
     end
+    let(:dummy_controller) {
+      class DummyController
+        def collection
+          Post.order('published_at DESC')
+        end
+
+        def apply_decorator(resource)
+          resource
+        end
+
+        def view_context
+        end
+      end
+      DummyController.new
+    }
+    let(:builder) do
+      ActiveAdmin::CSVBuilder.new do
+        column "id"
+        column "title"
+        column "published_at"
+      end
+    end
+
+    it "should generate data with the supplied order" do
+      expect(builder).to receive(:build_row).and_return([]).once.ordered { |post| expect(post.id).to eq @post2.id }
+      expect(builder).to receive(:build_row).and_return([]).once.ordered { |post| expect(post.id).to eq @post1.id }
+      builder.build dummy_controller, []
+    end
+  end
+
+  skip '#exec_columns'
+
+  skip '#build_row' do
+    it 'renders non-strings'
+    it 'encodes values correctly'
+    it 'passes custom encoding options to String#encode!'
   end
 
 end

data/spec/unit/dependency_spec.rb

@@ -0,0 +1,135 @@
+require 'rails_helper'
+
+describe ActiveAdmin::Dependency do
+
+  k = ActiveAdmin::Dependency
+
+  describe 'method_missing' do
+    before do
+      allow(Gem).to receive(:loaded_specs)
+        .and_return 'foo' => Gem::Specification.new('foo', '1.2.3')
+    end
+
+    it 'returns a Matcher' do
+      expect(k.foo).to be_a ActiveAdmin::Dependency::Matcher
+      expect(k.foo.inspect).to eq '<ActiveAdmin::Dependency::Matcher for foo 1.2.3>'
+      expect(k.bar.inspect).to eq '<ActiveAdmin::Dependency::Matcher for (missing)>'
+    end
+
+    describe '`?`' do
+      it 'base' do
+        expect(k.foo?).to eq true
+        expect(k.bar?).to eq false
+      end
+      it '=' do
+        expect(k.foo? '= 1.2.3').to eq true
+        expect(k.foo? '= 1'    ).to eq false
+      end
+      it '>' do
+        expect(k.foo? '> 1').to eq true
+        expect(k.foo? '> 2').to eq false
+      end
+      it '<' do
+        expect(k.foo? '< 2').to eq true
+        expect(k.foo? '< 1').to eq false
+      end
+      it '>=' do
+        expect(k.foo? '>= 1.2.3').to eq true
+        expect(k.foo? '>= 1.2.2').to eq true
+        expect(k.foo? '>= 1.2.4').to eq false
+      end
+      it '<=' do
+        expect(k.foo? '<= 1.2.3').to eq true
+        expect(k.foo? '<= 1.2.4').to eq true
+        expect(k.foo? '<= 1.2.2').to eq false
+      end
+      it '~>' do
+        expect(k.foo? '~> 1.2.0').to eq true
+        expect(k.foo? '~> 1.1'  ).to eq true
+        expect(k.foo? '~> 1.2.4').to eq false
+      end
+    end
+
+    describe '`!`' do
+      it 'raises an error if requirement not met' do
+        expect{ k.foo! '5'            }.to raise_error ActiveAdmin::DependencyError,
+          'You provided foo 1.2.3 but we need: 5.'
+      end
+      it 'accepts multiple arguments' do
+        expect{ k.foo! '> 1', '< 1.2' }.to raise_error ActiveAdmin::DependencyError,
+          'You provided foo 1.2.3 but we need: > 1, < 1.2.'
+      end
+      it 'raises an error if not provided' do
+        expect{ k.bar!                }.to raise_error ActiveAdmin::DependencyError,
+          'To use bar you need to specify it in your Gemfile.'
+      end
+    end
+  end
+
+  describe '[]' do
+    before do
+      allow(Gem).to receive(:loaded_specs)
+        .and_return 'a-b' => Gem::Specification.new('a-b', '1.2.3')
+    end
+
+    it 'allows access to gems with an arbitrary name' do
+      expect(k['a-b']).to be_a ActiveAdmin::Dependency::Matcher
+      expect(k['a-b'].inspect).to eq '<ActiveAdmin::Dependency::Matcher for a-b 1.2.3>'
+      expect(k['c-d'].inspect).to eq '<ActiveAdmin::Dependency::Matcher for (missing)>'
+    end
+
+    # Note: more extensive tests for match? and match! are above.
+
+    it 'match?' do
+      expect(k['a-b'].match?        ).to eq true
+      expect(k['a-b'].match? '1.2.3').to eq true
+      expect(k['b-c'].match?        ).to eq false
+    end
+
+    it 'match!' do
+      expect(k['a-b'].match!        ).to eq nil
+      expect(k['a-b'].match! '1.2.3').to eq nil
+
+      expect{ k['a-b'].match! '2.5' }.to raise_error ActiveAdmin::DependencyError,
+        'You provided a-b 1.2.3 but we need: 2.5.'
+
+      expect{ k['b-c'].match!       }.to raise_error ActiveAdmin::DependencyError,
+        'To use b-c you need to specify it in your Gemfile.'
+    end
+
+    # Note: Ruby comparison operators are separate from the `foo? '> 1'` syntax
+
+    describe 'Ruby comparison syntax' do
+
+      it '==' do
+        expect(k['a-b'] == '1.2.3').to eq true
+        expect(k['a-b'] == '1.2'  ).to eq false
+        expect(k['a-b'] == 1      ).to eq false
+      end
+      it '>' do
+        expect(k['a-b'] > 1).to eq true
+        expect(k['a-b'] > 2).to eq false
+      end
+      it '<' do
+        expect(k['a-b'] < 2).to eq true
+        expect(k['a-b'] < 1).to eq false
+      end
+      it '>=' do
+        expect(k['a-b'] >= '1.2.3').to eq true
+        expect(k['a-b'] >= '1.2.2').to eq true
+        expect(k['a-b'] >= '1.2.4').to eq false
+      end
+      it '<=' do
+        expect(k['a-b'] <= '1.2.3').to eq true
+        expect(k['a-b'] <= '1.2.4').to eq true
+        expect(k['a-b'] <= '1.2.2').to eq false
+      end
+
+      it 'throws a custom error if the gem is missing' do
+        expect{ k['b-c'] < 23 }.to raise_error ActiveAdmin::DependencyError,
+          'To use b-c you need to specify it in your Gemfile.'
+      end
+    end
+  end
+
+end

data/spec/unit/devise_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe ActiveAdmin::Devise::Controller do
 
@@ -18,12 +18,12 @@ describe ActiveAdmin::Devise::Controller do
     before { Rails.configuration.action_controller[:relative_url_root] = '/foo' }
 
     it "should set the root path to the default namespace" do
-      controller.root_path.should == "/foo/admin"
+      expect(controller.root_path).to eq "/foo/admin"
     end
 
     it "should set the root path to '/' when no default namespace" do
-      ActiveAdmin.application.stub default_namespace: false
-      controller.root_path.should == "/foo/"
+      allow(ActiveAdmin.application).to receive(:default_namespace).and_return(false)
+      expect(controller.root_path).to eq "/foo/"
     end
 
   end
@@ -33,12 +33,12 @@ describe ActiveAdmin::Devise::Controller do
     before { Rails.configuration.action_controller[:relative_url_root] = nil }
 
     it "should set the root path to the default namespace" do
-      controller.root_path.should == "/admin"
+      expect(controller.root_path).to eq "/admin"
     end
 
     it "should set the root path to '/' when no default namespace" do
-      ActiveAdmin.application.stub default_namespace: false
-      controller.root_path.should == "/"
+      allow(ActiveAdmin.application).to receive(:default_namespace).and_return(false)
+      expect(controller.root_path).to eq "/"
     end
 
   end
@@ -54,7 +54,7 @@ describe ActiveAdmin::Devise::Controller do
 
       # Add scoped routes
       routes.draw do
-        scope :path => SCOPE do
+        scope path: SCOPE do
           ActiveAdmin.routes(self)
           devise_for :admin_users, ActiveAdmin::Devise.config
         end
@@ -67,7 +67,7 @@ describe ActiveAdmin::Devise::Controller do
     end
 
     it "should include scope path in root_path" do
-      controller.root_path.should == "#{SCOPE}/admin"
+      expect(controller.root_path).to eq "#{SCOPE}/admin"
     end
 
   end
@@ -76,38 +76,18 @@ describe ActiveAdmin::Devise::Controller do
     let(:config) { ActiveAdmin::Devise.config }
 
     describe ":sign_out_via option" do
+      it "should contain the application.logout_link_method" do
+        expect(::Devise).to receive(:sign_out_via).and_return(:delete)
+        expect(ActiveAdmin.application).to receive(:logout_link_method).and_return(:get)
 
-      subject { config[:sign_out_via] }
-
-      context "when Devise does not implement sign_out_via (version < 1.2)" do
-        before do
-          ::Devise.should_receive(:respond_to?).with(:sign_out_via).and_return(false)
-        end
-
-        it "should not contain any customization for sign_out_via" do
-          config.should_not have_key(:sign_out_via)
-        end
+        expect(config[:sign_out_via]).to include(:get)
       end
 
-      context "when Devise implements sign_out_via (version >= 1.2)" do
-        before do
-          ::Devise.should_receive(:respond_to?).with(:sign_out_via).and_return(true)
-          ::Devise.stub(:sign_out_via) { :delete }
-        end
-
-        it "should contain the application.logout_link_method" do
-            ::Devise.should_receive(:sign_out_via).and_return(:delete)
-            ActiveAdmin.application.should_receive(:logout_link_method).and_return(:get)
-
-            config[:sign_out_via].should include(:get)
-        end
+      it "should contain Devise's logout_via_method(s)" do
+        expect(::Devise).to receive(:sign_out_via).and_return([:delete, :post])
+        expect(ActiveAdmin.application).to receive(:logout_link_method).and_return(:get)
 
-        it "should contain Devise's logout_via_method(s)" do
-            ::Devise.should_receive(:sign_out_via).and_return([:delete, :post])
-            ActiveAdmin.application.should_receive(:logout_link_method).and_return(:get)
-
-            config[:sign_out_via].should == [:delete, :post, :get]
-        end
+        expect(config[:sign_out_via]).to eq [:delete, :post, :get]
       end
 
     end # describe ":sign_out_via option"