yousty-activeadmin 1.0.4.pre → 1.0.5.pre

data/spec/{integration → requests}/default_namespace_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe ActiveAdmin::Application do
+describe ActiveAdmin::Application, :type => :request do
 
   include Rails.application.routes.url_helpers
 
@@ -22,11 +22,11 @@ describe ActiveAdmin::Application do
       end
 
       it "should generate a log out path" do
-        destroy_admin_user_session_path.should == "/admin_users/logout"
+        expect(destroy_admin_user_session_path).to eq "/logout"
       end
 
       it "should generate a log in path" do
-        new_admin_user_session_path.should == "/admin_users/login"
+        expect(new_admin_user_session_path).to eq "/login"
       end
 
     end
@@ -49,11 +49,11 @@ describe ActiveAdmin::Application do
       end
 
       it "should generate a log out path" do
-        destroy_admin_user_session_path.should == "/test/logout"
+        expect(destroy_admin_user_session_path).to eq "/test/logout"
       end
 
       it "should generate a log in path" do
-        new_admin_user_session_path.should == "/test/login"
+        expect(new_admin_user_session_path).to eq "/test/login"
       end
 
     end

data/spec/{integration → requests}/javascript_spec.rb

@@ -1,14 +1,14 @@
-require 'spec_helper'
+require 'rails_helper'
 require 'jslint'
 
 %x[which java]
 if $? == 0 # Only run the JS Lint test if Java is installed
-  describe "Javascript" do
+  describe "Javascript", :type => :request do
     before do
       @lint = JSLint::Lint.new(
-        :paths => ['public/javascripts/**/*.js'],
-        :exclude_paths => ['public/javascripts/vendor/**/*.js'],
-        :config_path => 'spec/support/jslint.yml'
+        paths: ['public/javascripts/**/*.js'],
+        exclude_paths: ['public/javascripts/vendor/**/*.js'],
+        config_path: 'spec/support/jslint.yml'
       )
     end
 

data/spec/requests/memory_spec.rb

@@ -0,0 +1,23 @@
+require 'rails_helper'
+
+describe "Memory Leak", :type => :request do
+
+  def count_instances_of(klass)
+    ObjectSpace.each_object(klass) { }
+  end
+
+  [ActiveAdmin::Namespace, ActiveAdmin::Resource].each do |klass|
+    it "should not leak #{klass}" do
+      previously_disabled = GC.enable
+      GC.start
+      count = count_instances_of(klass)
+
+      load_defaults!
+
+      GC.start
+      GC.disable if previously_disabled
+      expect(count_instances_of klass).to be <= count
+    end
+  end
+
+end

data/spec/requests/stylesheets_spec.rb

@@ -0,0 +1,18 @@
+require 'rails_helper'
+
+describe "Stylesheets", :type => :request do
+
+  require "sprockets"
+
+  let(:css) do
+    assets = Rails.application.assets
+    assets.find_asset("active_admin.css")
+  end
+  it "should successfully render the scss stylesheets using sprockets" do
+    expect(css).to_not be_nil
+  end
+  it "should not have any syntax errors" do
+    expect(css.to_s).to_not include("Syntax error:")
+  end
+
+end

data/spec/spec_helper.rb

@@ -1,175 +1,17 @@
-require 'spec_helper_without_rails'
+$LOAD_PATH.unshift(File.dirname(__FILE__))
+$LOAD_PATH << File.expand_path('../support', __FILE__)
 
-module ActiveAdminIntegrationSpecHelper
-  extend self
+ENV['BUNDLE_GEMFILE'] = File.expand_path('../../Gemfile', __FILE__)
+require "bundler"
+Bundler.setup
 
-  def load_defaults!
-    ActiveAdmin.unload!
-    ActiveAdmin.load!
-    ActiveAdmin.register(Category)
-    ActiveAdmin.register(User)
-    ActiveAdmin.register(Post){ belongs_to :user, :optional => true }
-    reload_menus!
-  end
+require 'detect_rails_version'
+ENV['RAILS'] = detect_rails_version
 
-  def reload_menus!
-    ActiveAdmin.application.namespaces.values.each{|n| n.reset_menu! }
-  end
+require 'simplecov'
 
-  # Sometimes we need to reload the routes within
-  # the application to test them out
-  def reload_routes!
-    Rails.application.reload_routes!
-  end
-
-  # Helper method to load resources and ensure that Active Admin is
-  # setup with the new configurations.
-  #
-  # Eg:
-  #   load_resources do
-  #     ActiveAdmin.regiser(Post)
-  #   end
-  #
-  def load_resources
-    ActiveAdmin.unload!
-    yield
-    reload_menus!
-    reload_routes!
-  end
-
-  # Sets up a describe block where you can render controller
-  # actions. Uses the Admin::PostsController as the subject
-  # for the describe block
-  def describe_with_render(*args, &block)
-    describe *args do
-      include RSpec::Rails::ControllerExampleGroup
-      render_views
-      # metadata[:behaviour][:describes] = ActiveAdmin.namespaces[:admin].resources['Post'].controller
-      module_eval &block
-    end
-  end
-
-  def arbre(assigns = {}, helpers = mock_action_view, &block)
-    Arbre::Context.new(assigns, helpers, &block)
-  end
-
-  def render_arbre_component(assigns = {}, helpers = mock_action_view, &block)
-    arbre(assigns, helpers, &block).children.first
-  end
-
-  # Setup a describe block which uses capybara and rails integration
-  # test methods.
-  def describe_with_capybara(*args, &block)
-    describe *args do
-      include RSpec::Rails::IntegrationExampleGroup
-      module_eval &block
-    end
-  end
-
-  # Returns a fake action view instance to use with our renderers
-  def mock_action_view(assigns = {})
-    controller = ActionView::TestCase::TestController.new
-    ActionView::Base.send :include, ActionView::Helpers
-    ActionView::Base.send :include, ActiveAdmin::ViewHelpers
-    ActionView::Base.send :include, Rails.application.routes.url_helpers
-    ActionView::Base.new(ActionController::Base.view_paths, assigns, controller)
-  end
-  alias_method :action_view, :mock_action_view
-
-  # A mock resource to register
-  class MockResource
-  end
-
-end
-
-ENV['RAILS_ENV'] = 'test'
-ENV['RAILS_ROOT'] = File.expand_path("../rails/rails-#{ENV['RAILS']}", __FILE__)
-
-# Create the test app if it doesn't exists
-unless File.exists?(ENV['RAILS_ROOT'])
-  system 'rake setup'
-end
-
-# Ensure the Active Admin load path is happy
-require 'rails'
-require 'active_admin'
-ActiveAdmin.application.load_paths = [ENV['RAILS_ROOT'] + "/app/admin"]
-
-require ENV['RAILS_ROOT'] + '/config/environment'
-
-require 'rspec/rails'
-
-# Setup Some Admin stuff for us to play with
-include ActiveAdminIntegrationSpecHelper
-load_defaults!
-reload_routes!
-
-# Disabling authentication in specs so that we don't have to worry about
-# it allover the place
-ActiveAdmin.application.authentication_method = false
-ActiveAdmin.application.current_user_method = false
-
-# Don't add asset cache timestamps. Makes it easy to integration
-# test for the presence of an asset file
-ENV["RAILS_ASSET_ID"] = ''
-
-RSpec.configure do |config|
-  config.use_transactional_fixtures = true
-  config.use_instantiated_fixtures = false
-  config.include Devise::TestHelpers, :type => :controller
-  config.render_views = false
-end
-
-# All RSpec configuration needs to happen before any examples
-# or else it whines.
-require 'integration_example_group'
-RSpec.configure do |c|
-  c.include RSpec::Rails::IntegrationExampleGroup, :example_group => { :file_path => /\bspec\/integration\// }
-  c.include Devise::TestHelpers, :type => :controller
-end
-
-# Ensure this is defined for Ruby 1.8
-module MiniTest; class Assertion < Exception; end; end
-
-RSpec::Matchers.define :have_tag do |*args|
-
-  match_unless_raises Test::Unit::AssertionFailedError do |response|
-    tag = args.shift
-    content = args.first.is_a?(Hash) ? nil : args.shift
-
-    options = {
-      :tag => tag.to_s
-    }.merge(args[0] || {})
-
-    options[:content] = content if content
-
-    begin
-      begin
-        assert_tag(options)
-      rescue NoMethodError
-        # We are not in a controller, so let's do the checking ourselves
-        doc = HTML::Document.new(response, false, false)
-        tag = doc.find(options)
-        assert tag, "expected tag, but no tag found matching #{options.inspect} in:\n#{response.inspect}"
-      end
-    # In Ruby 1.9, MiniTest::Assertion get's raised, so we'll
-    # handle raising a Test::Unit::AssertionFailedError
-    rescue MiniTest::Assertion => e
-      raise Test::Unit::AssertionFailedError, e.message
-    end
-  end
-end
-
-# improve the performance of the specs suite by not logging anything
-# see http://blog.plataformatec.com.br/2011/12/three-tips-to-improve-the-performance-of-your-test-suite/
-Rails.logger.level = 4
-
-
-# Improves performance by forcing the garbage collector to run less often.
-unless ENV['DEFER_GC'] == '0' || ENV['DEFER_GC'] == 'false'
-  require 'support/deferred_garbage_collection'
-  RSpec.configure do |config|
-    config.before(:all) { DeferredGarbageCollection.start }
-    config.after(:all)  { DeferredGarbageCollection.reconsider }
-  end
+SimpleCov.start do
+  add_filter 'spec/'
+  add_filter 'features/'
+  add_filter 'bundle/' # for Travis
 end

data/spec/support/detect_rails_version.rb

@@ -1,42 +1,34 @@
 # Detects the current version of Rails that is being used
 #
 #
-unless defined? RAILS_VERSION_FILE
-  RAILS_VERSION_FILE = File.expand_path("../../../.rails-version", __FILE__)
-end
-
-unless defined? TRAVIS_CONFIG
-  require 'yaml'
-  filename = File.expand_path("../../../.travis.yml", __FILE__)
-  TRAVIS_CONFIG = YAML.load_file filename
-  TRAVIS_RAILS_VERSIONS = TRAVIS_CONFIG['env'].grep(/RAILS=(.*)/){ $1 }
-end
-
-unless defined? DEFAULT_RAILS_VERSION
-  DEFAULT_RAILS_VERSION = TRAVIS_RAILS_VERSIONS.first
-end
-
-def detect_rails_version
-  version = version_from_file || version_from_env || DEFAULT_RAILS_VERSION
-
-  puts "Detected Rails: #{version}" if ENV['DEBUG']
-
-  version
-end
-
-def version_from_file
-  if File.exists?(RAILS_VERSION_FILE)
-    version = File.read(RAILS_VERSION_FILE).chomp.strip
-    version = nil if version == ""
-
-    version
-  end
-end
-
-def version_from_env
-  ENV['RAILS']
-end
-
-def write_rails_version(version)
-  File.open(RAILS_VERSION_FILE, "w+"){|f| f << version }
-end
+# RAILS_VERSION_FILE ||= File.expand_path("../../../.rails-version", __FILE__)
+
+# unless defined? TRAVIS_CONFIG
+#   require 'yaml'
+#   filename = File.expand_path("../../../.travis.yml", __FILE__)
+#   TRAVIS_CONFIG = YAML.load_file filename
+#   TRAVIS_RAILS_VERSIONS = TRAVIS_CONFIG['env']['matrix'].grep(/RAILS=(.*)/){ $1 }
+# end
+
+# DEFAULT_RAILS_VERSION ||= TRAVIS_RAILS_VERSIONS.first
+
+# def detect_rails_version
+#   version = version_from_file || ENV['RAILS'] || DEFAULT_RAILS_VERSION
+# ensure
+#   puts "Detected Rails: #{version}" if ENV['DEBUG']
+# end
+
+# def detect_rails_version!
+#   detect_rails_version or raise "can't find a version of Rails to use!"
+# end
+
+# def version_from_file
+#   if File.exists?(RAILS_VERSION_FILE)
+#     version = File.read(RAILS_VERSION_FILE).chomp.strip
+#     version unless version == ''
+#   end
+# end
+
+# def write_rails_version(version)
+#   File.open(RAILS_VERSION_FILE, "w+"){|f| f << version }
+# end

data/spec/support/rails_template.rb

@@ -2,7 +2,6 @@
 
 run "rm Gemfile"
 run "rm -r test"
-run "rm -r spec"
 
 # Create a cucumber database and environment
 copy_file File.expand_path('../templates/cucumber.rb', __FILE__),                "config/environments/cucumber.rb"
@@ -12,35 +11,53 @@ gsub_file 'config/database.yml', /^test:.*\n/, "test: &test\n"
 gsub_file 'config/database.yml', /\z/, "\ncucumber:\n  <<: *test\n  database: db/cucumber.sqlite3"
 gsub_file 'config/database.yml', /\z/, "\ncucumber_with_reloading:\n  <<: *test\n  database: db/cucumber.sqlite3"
 
-generate :model, "post title:string body:text published_at:datetime author_id:integer category_id:integer starred:boolean"
+if File.exists? 'config/secrets.yml'
+  gsub_file 'config/secrets.yml', /\z/, "\ncucumber:\n  secret_key_base: #{'o' * 128}"
+  gsub_file 'config/secrets.yml', /\z/, "\ncucumber_with_reloading:\n  secret_key_base: #{'o' * 128}"
+end
+
+generate :model, "post title:string body:text published_at:datetime author_id:integer position:integer custom_category_id:integer starred:boolean foo_id:integer"
 inject_into_file 'app/models/post.rb', %q{
-  belongs_to :category
-  belongs_to :author, :class_name => 'User'
+  belongs_to :category, foreign_key: :custom_category_id
+  belongs_to :author, class_name: 'User'
+  has_many :taggings
   accepts_nested_attributes_for :author
-  attr_accessible :author unless Rails::VERSION::MAJOR > 3 && !defined? ProtectedAttributes
-}, :after => 'class Post < ActiveRecord::Base'
+  accepts_nested_attributes_for :taggings
+  attr_accessible :author, :position unless Rails::VERSION::MAJOR > 3 && !defined? ProtectedAttributes
+}, after: 'class Post < ActiveRecord::Base'
 copy_file File.expand_path('../templates/post_decorator.rb', __FILE__), "app/models/post_decorator.rb"
 
+generate :model, "blog/post title:string body:text published_at:datetime author_id:integer position:integer custom_category_id:integer starred:boolean foo_id:integer"
+inject_into_file 'app/models/blog/post.rb', %q{
+  belongs_to :category, foreign_key: :custom_category_id
+  belongs_to :author, class_name: 'User'
+  has_many :taggings
+  accepts_nested_attributes_for :author
+  accepts_nested_attributes_for :taggings
+  attr_accessible :author, :position unless Rails::VERSION::MAJOR > 3 && !defined? ProtectedAttributes
+}, after: 'class Blog::Post < ActiveRecord::Base'
+
+
 generate :model, "user type:string first_name:string last_name:string username:string age:integer"
 inject_into_file 'app/models/user.rb', %q{
-  has_many :posts, :foreign_key => 'author_id'
+  has_many :posts, foreign_key: 'author_id'
   def display_name
     "#{first_name} #{last_name}"
   end
-}, :after => 'class User < ActiveRecord::Base'
+}, after: 'class User < ActiveRecord::Base'
 
 generate :model, 'publisher --migration=false --parent=User'
 generate :model, 'category name:string description:text'
 inject_into_file 'app/models/category.rb', %q{
-  has_many :posts
+  has_many :posts, foreign_key: :custom_category_id
   has_many :authors, through: :posts
   accepts_nested_attributes_for :posts
-}, :after => 'class Category < ActiveRecord::Base'
+}, after: 'class Category < ActiveRecord::Base'
 generate :model, 'store name:string'
 
 # Generate a model with string ids
 generate :model, "tag name:string"
-gsub_file(Dir['db/migrate/*_create_tags.rb'][0], /\:tags\sdo\s.*/, ":tags, :id => false, :primary_key => :id do |t|\n\t\t\tt.string :id\n")
+gsub_file(Dir['db/migrate/*_create_tags.rb'][0], /\:tags\sdo\s.*/, ":tags, id: false, primary_key: :id do |t|\n\t\t\tt.string :id\n")
 inject_into_file 'app/models/tag.rb', %q{
   self.primary_key = :id
   before_create :set_id
@@ -49,13 +66,23 @@ inject_into_file 'app/models/tag.rb', %q{
   def set_id
     self.id = 8.times.inject("") { |s,e| s << (i = Kernel.rand(62); i += ((i < 10) ? 48 : ((i < 36) ? 55 : 61 ))).chr }
   end
-}, :after => 'class Tag < ActiveRecord::Base'
+}, after: 'class Tag < ActiveRecord::Base'
+
+generate :model, "tagging post_id:integer tag_id:integer"
+inject_into_file 'app/models/tagging.rb', %q{
+  belongs_to :post
+  belongs_to :tag
+}, after: 'class Tagging < ActiveRecord::Base'
 
 # Configure default_url_options in test environment
-inject_into_file "config/environments/test.rb", "  config.action_mailer.default_url_options = { :host => 'example.com' }\n", :after => "config.cache_classes = true\n"
+inject_into_file "config/environments/test.rb", "  config.action_mailer.default_url_options = { host: 'example.com' }\n", after: "config.cache_classes = true\n"
 
 # Add our local Active Admin to the load path
-inject_into_file "config/environment.rb", "\n$LOAD_PATH.unshift('#{File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'lib'))}')\nrequire \"active_admin\"\n", :after => "require File.expand_path('../application', __FILE__)"
+inject_into_file "config/environment.rb", "\n$LOAD_PATH.unshift('#{File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'lib'))}')\nrequire \"active_admin\"\n", after: "require File.expand_path('../application', __FILE__)"
+inject_into_file "config/application.rb", "\nrequire 'devise'\n", after: "require 'rails/all'"
+
+# Force strong parameters to raise exceptions
+inject_into_file 'config/application.rb', "\n\n    config.action_controller.action_on_unpermitted_parameters = :raise if Rails::VERSION::MAJOR == 4\n\n", after: 'class Application < Rails::Application'
 
 # Add some translations
 append_file "config/locales/en.yml", File.read(File.expand_path('../templates/en.yml', __FILE__))
@@ -63,27 +90,32 @@ append_file "config/locales/en.yml", File.read(File.expand_path('../templates/en
 # Add predefined admin resources
 directory File.expand_path('../templates/admin', __FILE__), "app/admin"
 
+# Add predefined policies
+directory File.expand_path('../templates/policies', __FILE__), 'app/policies'
+
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 
-generate :'active_admin:install'
+generate 'active_admin:install'
 
-rake "db:migrate"
-rake "db:test:prepare"
-run "/usr/bin/env RAILS_ENV=cucumber rake db:migrate"
+inject_into_file "config/routes.rb", "\n  root to: redirect('/admin')", after: /.*::Application.routes.draw do/
+remove_file "public/index.html" if File.exists? "public/index.html"
 
-# Setup parallel_tests
-def setup_parallel_tests_database(after, force_insert_same_content = false)
-  inject_into_file 'config/database.yml', "<%= ENV['TEST_ENV_NUMBER'] %>", :after => after, :force => force_insert_same_content
-end
+# Devise master doesn't set up its secret key on Rails 4.1
+# https://github.com/plataformatec/devise/issues/2554
+gsub_file 'config/initializers/devise.rb', /# config.secret_key =/, 'config.secret_key ='
 
-setup_parallel_tests_database "test.sqlite3"
-setup_parallel_tests_database "cucumber.sqlite3", true
+rake "db:migrate db:test:prepare"
+run "/usr/bin/env RAILS_ENV=cucumber rake db:migrate"
+
+if ENV['INSTALL_PARALLEL']
+  inject_into_file 'config/database.yml', "<%= ENV['TEST_ENV_NUMBER'] %>", after: 'test.sqlite3'
+  inject_into_file 'config/database.yml', "<%= ENV['TEST_ENV_NUMBER'] %>", after: 'cucumber.sqlite3', force: true
 
-# Note: this is hack!
-# Somehow, calling parallel_tests tasks from Rails generator using Thor does not work ...
-# RAILS_ENV variable never makes it to parallel_tests tasks.
-# We need to call these tasks in the after set up hook in order to creates cucumber DBs + run migrations on test & cucumber DBs
-create_file 'lib/tasks/parallel.rake', %q{
+  # Note: this is hack!
+  # Somehow, calling parallel_tests tasks from Rails generator using Thor does not work ...
+  # RAILS_ENV variable never makes it to parallel_tests tasks.
+  # We need to call these tasks in the after set up hook in order to creates cucumber DBs + run migrations on test & cucumber DBs
+  create_file 'lib/tasks/parallel.rake', %q{
 namespace :parallel do
   def run_in_parallel(cmd, options)
     count = "-n #{options[:count]}" if options[:count]
@@ -103,9 +135,4 @@ namespace :parallel do
   end
 end
 }
-
-# If using Devise after 3.1, this is required for the tests to pass:
-require 'devise/version'
-if Devise::VERSION.to_f >= 3.1
-  inject_into_file 'config/initializers/devise.rb', "\n  config.allow_insecure_token_lookup = true", after: 'Devise.setup do |config|'
 end