you_got_listed 0.3.3 → 0.3.4

data/lib/you_got_listed/accounts.rb

@@ -1,9 +1,9 @@
 module YouGotListed
   class Accounts < Resource
-    
+
     def search(optional_params = {})
       process_get("/accounts/search.php", optional_params)
     end
-    
+
   end
 end

data/lib/you_got_listed/agent.rb

@@ -1,24 +1,24 @@
 module YouGotListed
   class Agent < Resource
-    
+
     def find_all
       process_get("/agents/search.php")
     end
-    
+
     def find_by_id(agent_id)
       get_agent(agent_id)
     end
-    
+
     def find(agent_id)
       get_agent(agent_id, true)
     end
-    
+
     private
-    
+
     def get_agent(agent_id, raise_error = false)
       params = {:id => agent_id}
       process_get("/agents/search.php", params, raise_error)
     end
-    
+
   end
 end

data/lib/you_got_listed/client.rb

@@ -1,16 +1,16 @@
 module YouGotListed
   class Client
-    
+
     include HTTParty
     format :xml
     base_uri "https://www.yougotlistings.com/api"
-    
+
     attr_accessor :api_key
-    
+
     def initialize(api_key)
       self.class.default_params :key => api_key
     end
-    
+
     def perform_request(http_method, path, params = {})
       begin
         self.class.send(http_method, path, :query => params)
@@ -20,6 +20,6 @@ module YouGotListed
         {"YGLResponse" => {"responseCode" => "999", "Error" => "Unknown Error"}}
       end
     end
-    
+
   end
 end

data/lib/you_got_listed/complex.rb

@@ -1,8 +1,8 @@
 module YouGotListed
   class Complex
-    
+
     attr_accessor :client
-    
+
     def initialize(listing, client)
       listing.each do |key, value|
         self.instance_variable_set('@'+key, value)
@@ -10,7 +10,7 @@ module YouGotListed
       end
       self.client = client
     end
-    
+
     def properties
       return [] if self.listings.blank?
       props = []
@@ -25,11 +25,11 @@ module YouGotListed
       end
       props
     end
-    
+
     def pictures
       self.photos.photo unless self.photos.blank? || self.photos.photo.blank?
     end
-    
+
     def find_address(address_id)
       if addresses.address.is_a?(Array)
         addresses.address.find{|address| address.id == address_id}
@@ -37,6 +37,6 @@ module YouGotListed
         addresses.address
       end
     end
-    
+
   end
 end

data/lib/you_got_listed/complexes.rb

@@ -1,6 +1,6 @@
 module YouGotListed
   class Complexes < Resource
-    
+
     def search(params = {})
       params[:page_count] ||= 20
       params[:page_index] ||= 1
@@ -9,22 +9,22 @@ module YouGotListed
       params[:detail_level] ||= 2
       SearchResponse.new(self.client.perform_request(:get, '/complexes/search.php', params), self.client, params[:page_count])
     end
-    
+
     def find_by_id(complex_id)
       response = SearchResponse.new(self.client.perform_request(:get, '/complexes/search.php', {:complex_id => complex_id}), self.client, 20)
       (response.success? && response.property_complexes.size > 0) ? response.property_complexes.first : nil
     end
-    
+
     class SearchResponse < YouGotListed::Response
-      
+
       attr_accessor :limit, :paginator_cache, :client
-      
+
       def initialize(response, client, limit = 20, raise_error = false)
         super(response, raise_error)
         self.limit = limit
         self.client = client
       end
-      
+
       def property_complexes
         return [] if self.ygl_response.complexes.blank?
         props = []
@@ -37,7 +37,7 @@ module YouGotListed
         end
         props
       end
-      
+
       def paginator
         paginator_cache if paginator_cache
         self.paginator_cache = WillPaginate::Collection.create(
@@ -48,6 +48,6 @@ module YouGotListed
         end
       end
     end
-    
+
   end
 end

data/lib/you_got_listed/error.rb

@@ -1,17 +1,17 @@
 module YouGotListed
   class Error < Exception
-    
+
     attr_reader :code, :error
-    
+
     def initialize(code, error)
       @code = code
       @error = error
       super(message)
     end
-    
+
     def message
       "YouGotListed Error: #{@error} (code: #{@code})"
     end
-    
+
   end
 end

data/lib/you_got_listed/lead.rb

@@ -1,13 +1,13 @@
 module YouGotListed
   class Lead < Resource
-    
+
     def create(lead_params = {}, raise_error = false)
       process_post("/leads/insert.php", lead_params, raise_error)
     end
-    
+
     def create!(lead_params = {})
       create(lead_params, true)
     end
-    
+
   end
 end

data/lib/you_got_listed/listing.rb

@@ -1,8 +1,8 @@
 module YouGotListed
   class Listing
-    
+
     attr_accessor :client
-    
+
     def initialize(listing, client)
       listing.each do |key, value|
         self.instance_variable_set('@'+key, value)
@@ -12,22 +12,23 @@ module YouGotListed
       end
       self.client = client
     end
-    
+
     def similar_listings(limit = 6)
       min_baths = ((self.baths.to_i - 1) <= 0 ? 0 : (self.baths.to_i - 1))
       max_baths = self.baths.to_i + 1
       min_rent = (self.price.to_i * 0.9).to_i
       max_rent = (self.price.to_i * 1.1).to_i
+      min_beds = ((self.beds.to_i - 1) <= 0 ? 0 : (self.beds.to_i - 1))
+      max_beds = self.beds.to_i + 1
       search_params = {
         :limit => limit + 1,
         :min_rent => min_rent,
         :max_rent => max_rent,
-        :min_bed => ((self.beds.to_i - 1) <= 0 ? 0 : (self.beds.to_i - 1)),
-        :max_bed => self.beds.to_i + 1,
+        :min_bed => min_beds,
+        :max_bed => max_beds,
         :baths => [min_baths, self.baths, max_baths].join(','),
         :city_neighborhood => self.city_neighborhood
       }
-      
       similar = []
       listings = YouGotListed::Listings.new(self.client)
       listings.search(search_params).properties.each do |prop|
@@ -36,38 +37,38 @@ module YouGotListed
       end
       similar
     end
-    
+
     def town_neighborhood
       str = self.city
       str += " - #{neighborhood}" unless self.neighborhood.blank?
       str
     end
-    
+
     def city_neighborhood
       str = self.city
       str += ":#{neighborhood}" unless self.neighborhood.blank?
       str
     end
-    
+
     def pictures
       (self.photos.photo.is_a?(Array) ? self.photos.photo : [self.photos.photo])  unless self.photos.blank? || self.photos.photo.blank?
     end
-    
+
     def main_picture
       pictures.first if pictures
     end
-    
+
     def mls_listing?
       source && source == "MLS"
     end
-    
+
     def latitude
       @latitude.to_f unless @latitude.blank?
     end
-    
+
     def longitude
       @longitude.to_f unless @longitude.blank?
     end
-    
+
   end
 end

data/lib/you_got_listed/listings.rb

@@ -1,6 +1,6 @@
 module YouGotListed
   class Listings < Resource
-    
+
     def search(params = {})
       params[:page_count] ||= 20
       params[:page_index] ||= 1
@@ -9,7 +9,7 @@ module YouGotListed
       params[:detail_level] ||= 2
       SearchResponse.new(self.client.perform_request(:get, '/rentals/search.php', params), self.client, params[:page_count])
     end
-    
+
     def featured(params = {}, featured_tag = 'Featured Rentals')
       if params[:tags].blank?
         params[:tags] = featured_tag
@@ -18,13 +18,13 @@ module YouGotListed
       end
       search(params)
     end
-    
+
     def find_by_id(listing_id)
       params = {:listing_id => listing_id, :detail_level => 2}
       response = SearchResponse.new(self.client.perform_request(:get, '/rentals/search.php', params), self.client, 20)
       (response.success? && response.properties.size > 0) ? response.properties.first : nil
     end
-    
+
     def find_all(params = {})
       params[:page_count] ||= 20
       all_listings = []
@@ -43,7 +43,7 @@ module YouGotListed
       end
       all_listings.flatten
     end
-    
+
     def find_all_by_ids(listing_ids, include_off_market = true)
       listing_ids = listing_ids.split(',') if listing_ids.is_a?(String)
       all_listings = []
@@ -61,19 +61,19 @@ module YouGotListed
       end
       all_listings.compact.flatten
     end
-    
+
     class SearchResponse < YouGotListed::Response
-      
+
       attr_accessor :limit, :paginator_cache, :client
-      
+
       def initialize(response, client, limit = 20, raise_error = false)
         super(response, raise_error)
         self.limit = limit
         self.client = client
       end
-      
+
       def properties
-        return [] if self.ygl_response.listings.blank?
+        return [] if !self.success? || self.ygl_response.listings.blank?
         props = []
         if self.ygl_response.listings.listing.is_a?(Array)
           self.ygl_response.listings.listing.each do |listing|
@@ -84,11 +84,11 @@ module YouGotListed
         end
         props
       end
-      
+
       def mls_results?
         @has_mls_properties ||= properties.any?{|property| property.mls_listing?}
       end
-      
+
       def paginator
         paginator_cache if paginator_cache
         self.paginator_cache = WillPaginate::Collection.create(
@@ -99,6 +99,6 @@ module YouGotListed
         end
       end
     end
-    
+
   end
 end

data/lib/you_got_listed/resource.rb

@@ -1,19 +1,19 @@
 module YouGotListed
   class Resource
-    
+
     attr_accessor :client
-    
+
     def initialize(client)
       self.client = client
     end
-    
+
     def process_get(path, params = {}, raise_error = false)
       Response.new(self.client.perform_request(:get, path, params), raise_error)
     end
-    
+
     def process_post(path, params = {}, raise_error = false)
       Response.new(self.client.perform_request(:post, path, params), raise_error)
     end
-    
+
   end
 end

data/lib/you_got_listed/response.rb

@@ -1,18 +1,29 @@
 module YouGotListed
   class Response
-    
+
     attr_accessor :ygl_response
-    
+
     def initialize(response, raise_error = true)
-      rash = Hashie::Rash.new(response)
-      self.ygl_response = rash.ygl_response
-      raise Error.new(self.ygl_response.response_code, self.ygl_response.error) if !success? && raise_error
+      if !response.respond_to?(:each_pair)
+        self.ygl_response = nil
+        raise Error.new('empty_response', 'Empty Response') if raise_error
+      else
+        rash = Hashie::Rash.new(response)
+        self.ygl_response = rash.ygl_response
+        if !success? && raise_error
+          if self.ygl_response.respond_to?(:response_code)
+            raise Error.new(self.ygl_response.response_code, self.ygl_response.error)
+          else
+            raise Error.new('empty_response', 'Empty Response')
+          end
+        end
+      end
     end
-    
+
     def success?
       self.ygl_response && self.ygl_response.respond_to?(:response_code) && self.ygl_response.response_code.to_i < 300
     end
-    
+
     def method_missing(method_name, *args)
       if self.ygl_response.respond_to?(method_name)
         self.ygl_response.send(method_name)
@@ -20,6 +31,6 @@ module YouGotListed
         super
       end
     end
-    
+
   end
 end

data/lib/you_got_listed/version.rb

@@ -1,3 +1,3 @@
 module YouGotListed
-  VERSION = '0.3.3'
+  VERSION = '0.3.4'
 end

data/lib/you_got_listed.rb

@@ -1,6 +1,5 @@
 require 'rubygems'
 require 'httparty'
-require 'hashie'
 require 'rash'
 require 'will_paginate/collection'
 require 'active_support/core_ext/array/grouping'

data/spec/fixtures/responses/empty.xml

@@ -0,0 +1,2 @@
+<?xml version="1.0" standalone="yes"?> 
+<YGLResponse></YGLResponse>

data/spec/you_got_listed/accounts_spec.rb

@@ -1,26 +1,26 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe YouGotListed::Accounts do
-  
+
   before do
     @ygl = new_ygl
     @accounts = YouGotListed::Accounts.new(@ygl)
   end
-  
+
   context "search" do
     before do
       VCR.use_cassette('accounts.search') do
         @response = @accounts.search
       end
     end
-    
+
     it "should be a success" do
       @response.success?.should be_true
     end
-    
+
     it "should set accounts on the response" do
       @response.ygl_response.accounts.should be_kind_of(Hashie::Rash)
     end
   end
-  
+
 end

data/spec/you_got_listed/agent_spec.rb

@@ -1,29 +1,29 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe YouGotListed::Agent do
-  
+
   before do
     @ygl = new_ygl
     @agent = YouGotListed::Agent.new(@ygl)
   end
-  
+
   context "find_all" do
     before do
       VCR.use_cassette('agent.find_all') do
         @response = @agent.find_all
       end
     end
-    
+
     it "should be a success" do
       @response.success?.should be_true
     end
-    
+
     it "should return an array of agents" do
       @response.agents.agent.should_not be_nil
       @response.agents.agent.should be_kind_of(Array)
     end
   end
-  
+
   context "successful find" do
     before do
       VCR.use_cassette('agent.find_all') do
@@ -33,17 +33,17 @@ describe YouGotListed::Agent do
         @response = @agent.find(@valid_agent_id)
       end
     end
-    
+
     it "should be a success" do
       @response.success?.should be_true
     end
-    
+
     it "should return an array of agents" do
       @response.agents.agent.should_not be_nil
       @response.agents.agent.should be_kind_of(Hashie::Rash)
     end
   end
-  
+
   context "unsuccessful find" do
     it "should raise an exception" do
       lambda {
@@ -53,7 +53,7 @@ describe YouGotListed::Agent do
       }.should raise_exception(YouGotListed::Error, "YouGotListed Error: Invalid user id. (code: 301)")
     end
   end
-  
+
   context "successful find_by_id" do
     before do
       VCR.use_cassette('agent.find_all') do
@@ -63,17 +63,17 @@ describe YouGotListed::Agent do
         @response = @agent.find_by_id(@valid_agent_id)
       end
     end
-    
+
     it "should be a success" do
       @response.success?.should be_true
     end
-    
+
     it "should return an array of agents" do
       @response.agents.agent.should_not be_nil
       @response.agents.agent.should be_kind_of(Hashie::Rash)
     end
   end
-  
+
   context "unsuccessful find_by_id" do
     it "should raise an exception" do
       lambda {
@@ -82,7 +82,7 @@ describe YouGotListed::Agent do
         end
       }.should_not raise_exception
     end
-    
+
     it "should not be a success" do
       VCR.use_cassette('agent.find.error') do
         @response = @agent.find_by_id('AG-001-0499957')
@@ -90,5 +90,5 @@ describe YouGotListed::Agent do
       @response.success?.should be_false
     end
   end
-  
+
 end

data/spec/you_got_listed/client_spec.rb

@@ -1,17 +1,17 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe YouGotListed::Client do
-  
+
   before do
     @ygl = new_ygl
   end
-  
+
   it "should set the api_key" do
     @ygl.class.default_params.should == {:key => YGL_API_KEY}
   end
-  
+
   it "should set the base uri" do
     @ygl.class.base_uri.should == "https://www.yougotlistings.com/api"
   end
-  
+
 end

data/spec/you_got_listed/complex_spec.rb

@@ -1,20 +1,20 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe YouGotListed::Complex do
-  
+
   before do
     @ygl = new_ygl
     @complex = YouGotListed::Complex.new(valid_complex_rash, @ygl)
   end
-  
+
   it "should return photos for pictures" do
     @complex.pictures.should == @complex.photos.photo
   end
-  
+
   it "should create methods from all hash keys" do
     @complex.should respond_to("id", "name", "addresses", "public_notes", "photos", "listings")
   end
-  
+
   it "should return an array of properties" do
     @complex.properties.should be_kind_of(Array)
     @complex.properties.each do |property|
@@ -22,5 +22,5 @@ describe YouGotListed::Complex do
     end
     @complex.properties.size.should == 2
   end
-  
+
 end