you_got_listed 0.3.3 → 0.3.4

data/spec/you_got_listed/response_spec.rb

@@ -1,13 +1,13 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe YouGotListed::Response do
-  
+
   context "should not raise errors" do
     before do
       @ygl = new_ygl
       @accounts = YouGotListed::Accounts.new(@ygl)
     end
-    
+
     it "should not raise an exception" do
       lambda {
         VCR.use_cassette('accounts.search') do
@@ -16,13 +16,13 @@ describe YouGotListed::Response do
       }.should_not raise_exception
     end
   end
-  
+
   context "should return a response" do
     before do
       @ygl = new_ygl
       @accounts = YouGotListed::Accounts.new(@ygl)
     end
-    
+
     it "should not raise an exception" do
       lambda {
         VCR.use_cassette('accounts.search') do
@@ -30,7 +30,7 @@ describe YouGotListed::Response do
         end
       }.should_not raise_exception
     end
-    
+
     it "should be a success" do
       VCR.use_cassette('accounts.search') do
         @response = @accounts.search
@@ -40,7 +40,7 @@ describe YouGotListed::Response do
       @response.ygl_response.should be_kind_of(Hashie::Rash)
     end
   end
-  
+
   context "method missing" do
     before do
       @ygl = new_ygl
@@ -49,44 +49,72 @@ describe YouGotListed::Response do
         @response = @accounts.search
       end
     end
-    
+
     it "should allow response.ygl_response methods to be called on response" do
       body = stub(:total_count => 25)
       @response.ygl_response = body
       @response.total_count.should == 25
     end
-    
+
     it "should call super if ygl_response does not respond to the method" do
       lambda { @response.bad_method }.should raise_error(NoMethodError, /undefined method `bad_method'/)
     end
   end
-  
+
   context "passing raise_errors = true" do
-    before do
-      @ygl = new_ygl
-      @mocked_response = httparty_get(@ygl.class.base_uri, '/accounts/search.php', 'error.xml', @ygl.class.default_params)
+    context "with errored response" do
+      before do
+        @ygl = new_ygl
+        @mocked_response = httparty_get(@ygl.class.base_uri, '/accounts/search.php', 'error.xml', @ygl.class.default_params)
+      end
+
+      it "should raise errors when raise_errors is true" do
+        lambda {
+          YouGotListed::Response.new(@mocked_response, true)
+        }.should raise_exception(YouGotListed::Error, "YouGotListed Error: Invalid key. (code: 998)")
+      end
     end
-    
-    it "should raise errors when raise_errors is true" do
-      lambda {
-        YouGotListed::Response.new(@mocked_response, true)
-      }.should raise_exception(YouGotListed::Error, "YouGotListed Error: Invalid key. (code: 998)")
+
+    context "empty response" do
+      before do
+        @ygl = new_ygl
+        @mocked_response = httparty_get(@ygl.class.base_uri, '/accounts/search.php', 'empty.xml', @ygl.class.default_params)
+      end
+
+      it "should raise errors when raise_errors is true" do
+        lambda {
+          YouGotListed::Response.new(@mocked_response, true)
+        }.should raise_exception(YouGotListed::Error, "YouGotListed Error: Empty Response (code: empty_response)")
+      end
+    end
+
+    context "blank response" do
+      before do
+        @ygl = new_ygl
+        @mocked_response = httparty_get(@ygl.class.base_uri, '/accounts/search.php', 'blank.xml', @ygl.class.default_params)
+      end
+
+      it "should raise errors when raise_errors is true" do
+        lambda {
+          YouGotListed::Response.new(@mocked_response, true)
+        }.should raise_exception(YouGotListed::Error, "YouGotListed Error: Empty Response (code: empty_response)")
+      end
     end
   end
-  
+
   context "client timeout error" do
     before do
       @ygl = new_ygl
       YouGotListed::Client.stub!(:get).and_raise(Timeout::Error)
       @accounts = YouGotListed::Accounts.new(@ygl)
     end
-    
+
     it "should not raise errors" do
       lambda {
         @response = @accounts.search
       }.should_not raise_exception
     end
-    
+
     it "should not be a success" do
       @response = @accounts.search
       @response.success?.should be_false
@@ -94,20 +122,20 @@ describe YouGotListed::Response do
       @response.error.should == "Timeout"
     end
   end
-  
+
   context "client exception" do
     before do
       @ygl = new_ygl
       YouGotListed::Client.stub!(:get).and_raise(Exception)
       @accounts = YouGotListed::Accounts.new(@ygl)
     end
-    
+
     it "should not raise errors" do
       lambda {
         @response = @accounts.search
       }.should_not raise_exception
     end
-    
+
     it "should not be a success" do
       @response = @accounts.search
       @response.success?.should be_false
@@ -115,5 +143,5 @@ describe YouGotListed::Response do
       @response.error.should == "Unknown Error"
     end
   end
-  
+
 end

data/you_got_listed.gemspec

@@ -18,8 +18,7 @@ Gem::Specification.new do |s|
 
   s.add_dependency "activesupport", "~> 3"
   s.add_dependency "httparty", ">= 0.6.1"
-  s.add_dependency "hashie", ">= 0.4.0"
-  s.add_dependency "rash", ">= 0.2.0"
+  s.add_dependency "rash", ">= 0.3.2"
   s.add_dependency "will_paginate", ">= 3"
   s.add_development_dependency "rake", "~> 0.9.2"
   s.add_development_dependency "rspec", ">= 2.5.0"

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: you_got_listed
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 27
   prerelease: 
   segments: 
   - 0
   - 3
-  - 3
-  version: 0.3.3
+  - 4
+  version: 0.3.4
 platform: ruby
 authors: 
 - Tom Cocca
@@ -50,22 +50,6 @@ dependencies:
   prerelease: false
 - !ruby/object:Gem::Dependency 
   requirement: &id003 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 15
-        segments: 
-        - 0
-        - 4
-        - 0
-        version: 0.4.0
-  version_requirements: *id003
-  name: hashie
-  type: :runtime
-  prerelease: false
-- !ruby/object:Gem::Dependency 
-  requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -73,15 +57,15 @@ dependencies:
         hash: 23
         segments: 
         - 0
+        - 3
         - 2
-        - 0
-        version: 0.2.0
-  version_requirements: *id004
+        version: 0.3.2
+  version_requirements: *id003
   name: rash
   type: :runtime
   prerelease: false
 - !ruby/object:Gem::Dependency 
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -90,12 +74,12 @@ dependencies:
         segments: 
         - 3
         version: "3"
-  version_requirements: *id005
+  version_requirements: *id004
   name: will_paginate
   type: :runtime
   prerelease: false
 - !ruby/object:Gem::Dependency 
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -106,12 +90,12 @@ dependencies:
         - 9
         - 2
         version: 0.9.2
-  version_requirements: *id006
+  version_requirements: *id005
   name: rake
   type: :development
   prerelease: false
 - !ruby/object:Gem::Dependency 
-  requirement: &id007 !ruby/object:Gem::Requirement 
+  requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -122,12 +106,12 @@ dependencies:
         - 5
         - 0
         version: 2.5.0
-  version_requirements: *id007
+  version_requirements: *id006
   name: rspec
   type: :development
   prerelease: false
 - !ruby/object:Gem::Dependency 
-  requirement: &id008 !ruby/object:Gem::Requirement 
+  requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -138,12 +122,12 @@ dependencies:
         - 6
         - 2
         version: 1.6.2
-  version_requirements: *id008
+  version_requirements: *id007
   name: webmock
   type: :development
   prerelease: false
 - !ruby/object:Gem::Dependency 
-  requirement: &id009 !ruby/object:Gem::Requirement 
+  requirement: &id008 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -154,7 +138,7 @@ dependencies:
         - 8
         - 0
         version: 1.8.0
-  version_requirements: *id009
+  version_requirements: *id008
   name: vcr
   type: :development
   prerelease: false
@@ -186,6 +170,8 @@ files:
 - lib/you_got_listed/resource.rb
 - lib/you_got_listed/response.rb
 - lib/you_got_listed/version.rb
+- spec/fixtures/responses/blank.xml
+- spec/fixtures/responses/empty.xml
 - spec/fixtures/responses/error.xml
 - spec/spec.opts
 - spec/spec_helper.rb
@@ -240,6 +226,8 @@ signing_key:
 specification_version: 3
 summary: ruby api wrapper for you got listings
 test_files: 
+- spec/fixtures/responses/blank.xml
+- spec/fixtures/responses/empty.xml
 - spec/fixtures/responses/error.xml
 - spec/spec.opts
 - spec/spec_helper.rb