you_got_listed 0.3.3 → 0.3.4

data/spec/you_got_listed/complexes_spec.rb

@@ -1,40 +1,40 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe YouGotListed::Complexes do
-  
+
   before do
     @ygl = new_ygl
     @complexes = YouGotListed::Complexes.new(@ygl)
   end
-  
+
   context "search" do
     before do
       VCR.use_cassette('complexes.search') do
         @response = @complexes.search
       end
     end
-    
+
     it { @response.should be_kind_of(YouGotListed::Complexes::SearchResponse) }
     it { @response.success?.should be_true }
-    
+
     context "search response" do
       it { @response.should be_kind_of(YouGotListed::Response) }
       it { @response.should respond_to(:property_complexes, :paginator) }
-      
+
       it "should return an array of property_complexes" do
         @response.property_complexes.should be_kind_of(Array)
         @response.property_complexes.each do |property|
           property.should be_kind_of(YouGotListed::Complex)
         end
       end
-      
+
       it "should return a will_paginate collection" do
         @response.paginator.should be_kind_of(WillPaginate::Collection)
         @response.paginator.collect{|p| p.id}.should == @response.property_complexes.collect{|p| p.id}
       end
     end
   end
-  
+
   context "find_by_id" do
     context "valid id" do
       before do
@@ -45,20 +45,20 @@ describe YouGotListed::Complexes do
           @complex = @complexes.find_by_id(@valid_complex_id)
         end
       end
-      
+
       it { @complex.should be_kind_of(YouGotListed::Complex) }
     end
-    
+
     context "missing id" do
       before do
         VCR.use_cassette('complexes.find_by_id_missing') do
           @complex = @complexes.find_by_id('CSM-111-382')
         end
       end
-      
+
       it { @complex.should be_nil }
     end
-    
+
     context "invalid id" do
       it "should not raise an exception" do
         lambda {
@@ -67,7 +67,7 @@ describe YouGotListed::Complexes do
           end
         }.should_not raise_exception
       end
-      
+
       it "should be nil" do
         VCR.use_cassette('complexes.find_by_id_invalid') do
           @complex = @complexes.find_by_id('CAM')
@@ -76,5 +76,5 @@ describe YouGotListed::Complexes do
       end
     end
   end
-  
+
 end

data/spec/you_got_listed/error_spec.rb

@@ -1,10 +1,10 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe YouGotListed::Error do
-  
+
   it "should set a message" do
     @error = YouGotListed::Error.new(300, 'Account retrieving failed.')
     @error.message.should == "YouGotListed Error: Account retrieving failed. (code: 300)"
   end
-  
+
 end

data/spec/you_got_listed/lead_spec.rb

@@ -1,14 +1,14 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe YouGotListed::Lead do
-  
+
   before do
     @ygl = new_ygl
     @lead = YouGotListed::Lead.new(@ygl)
     @success_params = {:first_name => "You", :last_name => "GotListed", :email => "ygl@gmail.com"}
     @failed_params = {}
   end
-  
+
   context "create" do
     context "a successful creation" do
       it "should not raise an exception" do
@@ -19,7 +19,7 @@ describe YouGotListed::Lead do
         }.should_not raise_exception
       end
     end
-    
+
     context "a failed creation" do
       it "should raise an exception" do
         lambda {
@@ -30,7 +30,7 @@ describe YouGotListed::Lead do
       end
     end
   end
-  
+
   context "create!" do
     context "a successful creation" do
       it "should not raise an exception" do
@@ -41,7 +41,7 @@ describe YouGotListed::Lead do
         }.should_not raise_exception
       end
     end
-    
+
     context "a failed creation" do
       it "should raise an exception" do
         lambda {
@@ -52,5 +52,5 @@ describe YouGotListed::Lead do
       end
     end
   end
-  
+
 end

data/spec/you_got_listed/listing_spec.rb

@@ -1,12 +1,12 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe YouGotListed::Listing do
-  
+
   before do
     @ygl = new_ygl
     @listing = YouGotListed::Listing.new(valid_listing_rash, @ygl)
   end
-  
+
   it "should create methods from all hash keys" do
     @listing.should respond_to(
       "unit_level", "pet", "include_hot_water", "square_footage", "external_id", "zip", "student_policy", 
@@ -16,72 +16,134 @@ describe YouGotListed::Listing do
       "include_gas", "state", "baths", "photos"
     )
   end
-  
+
   it "should return ygl id for id" do
     @listing.id.should == "BOS-182-933"
   end
-  
+
   it "should return the city - neighborhood for town_neighborhood" do
     @listing.town_neighborhood.should == 'Boston - Fenway'
   end
-  
+
   it "should return the city_neighborhood search param for city_neighborhood" do
     @listing.city_neighborhood.should == 'Boston:Fenway'
   end
-  
+
   it "should return photos for pictures" do
     @listing.pictures.should == @listing.photos.photo
   end
-  
+
   context "default similar listings" do
     before do
       VCR.use_cassette('listing.similar_listings') do
         @similar_props = @listing.similar_listings
       end
     end
-    
+
     it "should return an array of listings" do
       @similar_props.should be_kind_of(Array)
       @similar_props.should have_at_most(6).listings
       @similar_props.collect{|x| x.id}.should_not include(@listing.id)
     end
   end
-  
+
   context "similar listings with custom limit" do
     before do
       VCR.use_cassette('listing.similar_listings') do
         @similar_props = @listing.similar_listings(4)
       end
     end
-    
+
     it "should return an array of listings" do
       @similar_props.should be_kind_of(Array)
       @similar_props.should have_at_most(4).listings
       @similar_props.collect{|x| x.id}.should_not include(@listing.id)
     end
   end
-  
+
+  context "empty response" do
+    before do
+      min_baths = ((@listing.baths.to_i - 1) <= 0 ? 0 : (@listing.baths.to_i - 1))
+      max_baths = @listing.baths.to_i + 1
+      min_rent = (@listing.price.to_i * 0.9).to_i
+      max_rent = (@listing.price.to_i * 1.1).to_i
+      min_beds = ((@listing.beds.to_i - 1) <= 0 ? 0 : (@listing.beds.to_i - 1))
+      max_beds = @listing.beds.to_i + 1
+      httparty_get(@ygl.class.base_uri, '/rentals/search.php', 'empty.xml', @ygl.class.default_params.merge({
+          :limit => 7.to_s,
+          :min_rent => min_rent.to_s,
+          :max_rent => max_rent.to_s,
+          :min_bed => min_beds.to_s,
+          :max_bed => max_beds.to_s,
+          :baths => [min_baths, @listing.baths, max_baths].join(','),
+          :city_neighborhood => @listing.city_neighborhood,
+          :page_count => 20.to_s,
+          :page_index => 1.to_s,
+          :sort_name => "rent",
+          :sort_dir => "asc",
+          :detail_level => 2.to_s
+        })
+      )
+      @similar_props = @listing.similar_listings
+    end
+
+    it "should return an empty array of listings" do
+      @similar_props.should be_empty
+    end
+  end
+
+  context "blank response" do
+    before do
+      min_baths = ((@listing.baths.to_i - 1) <= 0 ? 0 : (@listing.baths.to_i - 1))
+      max_baths = @listing.baths.to_i + 1
+      min_rent = (@listing.price.to_i * 0.9).to_i
+      max_rent = (@listing.price.to_i * 1.1).to_i
+      min_beds = ((@listing.beds.to_i - 1) <= 0 ? 0 : (@listing.beds.to_i - 1))
+      max_beds = @listing.beds.to_i + 1
+      httparty_get(@ygl.class.base_uri, '/rentals/search.php', 'blank.xml', @ygl.class.default_params.merge({
+          :limit => 7.to_s,
+          :min_rent => min_rent.to_s,
+          :max_rent => max_rent.to_s,
+          :min_bed => min_beds.to_s,
+          :max_bed => max_beds.to_s,
+          :baths => [min_baths, @listing.baths, max_baths].join(','),
+          :city_neighborhood => @listing.city_neighborhood,
+          :page_count => 20.to_s,
+          :page_index => 1.to_s,
+          :sort_name => "rent",
+          :sort_dir => "asc",
+          :detail_level => 2.to_s
+        })
+      )
+      @similar_props = @listing.similar_listings
+    end
+
+    it "should return an empty array of listings" do
+      @similar_props.should be_empty
+    end
+  end
+
   context "mls_listing" do
     before do
       @listing = YouGotListed::Listing.new(valid_listing_rash.merge(:source => 'MLS'), @ygl)
     end
-    
+
     it "should be a mls_listing" do
       @listing.mls_listing?.should be_true
     end
   end
-  
+
   context "main_picture" do
     it "should return the first photo" do
       @listing.main_picture.should == @listing.pictures.first
       @listing.main_picture.should == "http://yougotlistings.com/photos/AC-000-103/500141.jpg"
     end
-    
+
     it "should return nil if no pictures" do
       @listing.stub!(:pictures).and_return(nil)
       @listing.main_picture.should be_nil
     end
-    
+
     it "should return an array if the property has only one photo" do
       rash = valid_listing_rash
       rash[:photos].merge!(:photo => 'http://ygl-photos.s3.amazonaws.com/1236380.jpg')
@@ -90,29 +152,29 @@ describe YouGotListed::Listing do
       @listing.main_picture.should == 'http://ygl-photos.s3.amazonaws.com/1236380.jpg'
     end
   end
-  
+
   context "latitude" do
     it "should return a float" do
       @listing.latitude.should be_kind_of(Float)
       @listing.latitude.should == 42.346182
     end
-    
+
     it "should return nil if blank" do
       @listing = YouGotListed::Listing.new(valid_listing_rash.merge(:latitude => ''), @ygl)
       @listing.latitude.should be_nil
     end
   end
-  
+
   context "longitude" do
     it "should return a float" do
       @listing.longitude.should be_kind_of(Float)
       @listing.longitude.should == -71.104427
     end
-    
+
     it "should return nil if blank" do
       @listing = YouGotListed::Listing.new(valid_listing_rash.merge(:longitude => ''), @ygl)
       @listing.longitude.should be_nil
     end
   end
-  
+
 end

data/spec/you_got_listed/listings_spec.rb

@@ -1,40 +1,76 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe YouGotListed::Listings do
-  
+
   before do
     @ygl = new_ygl
     @listings = YouGotListed::Listings.new(@ygl)
   end
-  
+
   context "search" do
     before do
       VCR.use_cassette('listings.search') do
         @response = @listings.search
       end
     end
-    
+
     it { @response.should be_kind_of(YouGotListed::Listings::SearchResponse) }
     it { @response.success?.should be_true }
-    
+
     context "search response" do
       it { @response.should be_kind_of(YouGotListed::Response) }
       it { @response.should respond_to(:properties, :paginator) }
-      
+
       it "should return an array of properties" do
         @response.properties.should be_kind_of(Array)
         @response.properties.each do |property|
           property.should be_kind_of(YouGotListed::Listing)
         end
       end
-      
+
       it "should return a will_paginate collection" do
         @response.paginator.should be_kind_of(WillPaginate::Collection)
         @response.paginator.collect{|p| p.id}.should == @response.properties.collect{|p| p.id}
       end
     end
   end
-  
+
+  context "empty response" do
+    before do
+      httparty_get(@ygl.class.base_uri, '/rentals/search.php', 'empty.xml', @ygl.class.default_params.merge({
+          :page_count => 20.to_s,
+          :page_index => 1.to_s,
+          :sort_name => "rent",
+          :sort_dir => "asc",
+          :detail_level => 2.to_s
+        })
+      )
+      @response = @listings.search
+    end
+
+    it "should return an empty array of listings" do
+      @response.properties.should be_empty
+    end
+  end
+
+  context "blank response" do
+    before do
+      httparty_get(@ygl.class.base_uri, '/rentals/search.php', 'blank.xml', @ygl.class.default_params.merge({
+          :page_count => 20.to_s,
+          :page_index => 1.to_s,
+          :sort_name => "rent",
+          :sort_dir => "asc",
+          :detail_level => 2.to_s
+        })
+      )
+      @response = @listings.search
+    end
+
+    it "should return an empty array of listings" do
+      @response.properties.should be_empty
+    end
+  end
+
   context "mls_search" do
     before do
       VCR.use_cassette('listings.mls_search') do
@@ -42,24 +78,24 @@ describe YouGotListed::Listings do
         @response.properties.first.stub!(:source).and_return('MLS')
       end
     end
-    
+
     context "search response" do
       it { @response.mls_results?.should be_true }
     end
   end
-  
+
   context "featured" do
     before do 
       VCR.use_cassette('listings.featured') do
         @response = @listings.featured
       end
     end
-    
+
     it "should only return featured properties" do
       @response.properties.find_all{|p| p.tags && p.tags.tag.include?('Featured Rentals')}.size.should == @response.properties.size
     end
   end
-  
+
   context "find_by_id" do
     context "valid id" do
       before do
@@ -70,20 +106,20 @@ describe YouGotListed::Listings do
           @listing = @listings.find_by_id(@valid_listing_id)
         end
       end
-      
+
       it { @listing.should be_kind_of(YouGotListed::Listing) }
     end
-    
+
     context "missing id" do
       before do
         VCR.use_cassette('listings.find_by_id_missing') do
           @listing = @listings.find_by_id('CAM-111-3823475')
         end
       end
-      
+
       it { @listing.should be_nil }
     end
-    
+
     context "invalid id" do
       it "should not raise an exception" do
         lambda {
@@ -92,7 +128,7 @@ describe YouGotListed::Listings do
           end
         }.should_not raise_exception
       end
-      
+
       it "should be nil" do
         VCR.use_cassette('listings.find_by_id_invalid') do
           @listing = @listings.find_by_id('CAM')
@@ -101,7 +137,7 @@ describe YouGotListed::Listings do
       end
     end
   end
-  
+
   context "find_all" do
     before do
       search_params = {:max_rent => "2000"}
@@ -109,16 +145,16 @@ describe YouGotListed::Listings do
         @properties = @listings.find_all(search_params)
       end
     end
-    
+
     it { @properties.should be_kind_of(Array)}
-    
+
     it "should only return properties" do
       @properties.each do |p|
         p.should be_kind_of(YouGotListed::Listing)
       end
     end
   end
-  
+
   context "find_all_by_ids" do
     before do
       VCR.use_cassette('listings.search') do
@@ -137,44 +173,44 @@ describe YouGotListed::Listings do
       @find_ids_with_off_market = @find_ids.clone
       @find_ids_with_off_market << @off_market_id if @off_market_id
     end
-    
+
     context "passing an array of ids" do
       before do
         VCR.use_cassette('listings.find_all_by_ids.array') do
           @properties = @listings.find_all_by_ids(@find_ids)
         end
       end
-      
+
       it { @properties.should be_kind_of(Array) }
-      
+
       it "should only return properties for requested ids" do
         @properties.each do |p|
           @find_ids.should include(p.id)
         end
       end
     end
-    
+
     context "passing an string of ids" do
       before do
         VCR.use_cassette('listings.find_all_by_ids.string') do
           @properties = @listings.find_all_by_ids(@find_ids.join(','))
         end
       end
-      
+
       it { @properties.should be_kind_of(Array) }
     end
-    
+
     context "should not return off market properties if directed not to" do
       before do
         VCR.use_cassette('listings.find_all_by_ids.no_off_market') do
           @properties = @listings.find_all_by_ids(@find_ids_with_off_market, false)
         end
       end
-      
+
       it { @properties.size.should_not == @find_ids_with_off_market.size }
       it { @properties.collect{|p| p.id}.should_not include(@off_market_id) }
     end
-    
+
     context "should find all properties including the mls properties" do
       before do
         VCR.use_cassette("listings.search_with_mls") do
@@ -193,9 +229,9 @@ describe YouGotListed::Listings do
           @properties = @listings.find_all_by_ids(@find_ids_with_mls)
         end
       end
-      
+
       it { @properties.size.should == @find_ids_with_mls.size }
-      
+
       it "should only return properties for requested ids" do
         @properties.each do |p|
           @find_ids_with_mls.should include(p.id)
@@ -203,7 +239,7 @@ describe YouGotListed::Listings do
       end
     end
   end
-  
+
   def find_off_market_property(listings, page_id = 1)
     VCR.use_cassette("listings.search_with_off_market.#{page_id}") do
       response = listings.search(:include_off_market => "1", :page_index => page_id)
@@ -214,7 +250,7 @@ describe YouGotListed::Listings do
       end
     end
   end
-  
+
   def find_mls_property(listings, page_id = 1)
     VCR.use_cassette("listings.search_with_mls.#{page_id}") do
       response = listings.search(:include_mls => "1", :page_index => page_id)
@@ -225,5 +261,5 @@ describe YouGotListed::Listings do
       end
     end
   end
-  
+
 end

data/spec/you_got_listed/resource_spec.rb

@@ -1,17 +1,17 @@
 require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
 
 describe YouGotListed::Resource do
-  
+
   before do
     @ygl = new_ygl
     @resource = YouGotListed::Resource.new(@ygl)
   end
-  
+
   context "initialize" do
     it "should instantiate with a client" do
       @resource.client.should_not be_nil
       @resource.client.should be_kind_of(YouGotListed::Client)
     end
   end
-  
+
 end