wright 0.3.2 → 0.4.0

data/spec/provider/package/homebrew_spec.rb

@@ -3,13 +3,16 @@ require_relative '../../spec_helper'
 require 'wright/provider/package/homebrew'
 
 describe Wright::Provider::Package::Homebrew do
-  def brew(action, pkg_name)
-    options = action == :info ? ['info', '--json=v1'] : [action.to_s]
-    ['brew', *options, pkg_name]
+  def brew(action, pkg_name, args = {})
+    action_args = action == :info ? ['info', '--json=v1'] : [action.to_s]
+    ['brew', *action_args, *args[:options], pkg_name]
   end
 
-  def package_provider(pkg_name, pkg_version = nil)
-    pkg_resource = OpenStruct.new(name: pkg_name, version: pkg_version)
+  def package_provider(pkg_name, args = {})
+    properties = { name: pkg_name,
+                   version: args[:version],
+                   options: args[:options] }
+    pkg_resource = OpenStruct.new(properties)
     Wright::Provider::Package::Homebrew.new(pkg_resource)
   end
 
@@ -71,7 +74,7 @@ describe Wright::Provider::Package::Homebrew do
     it 'should output a warning when specifying a package version' do
       pkg_name = 'cd-discid'
       pkg_version = '1.1'
-      pkg_provider = package_provider(pkg_name, pkg_version)
+      pkg_provider = package_provider(pkg_name, version: pkg_version)
       brew_install_cmd = brew(:install, pkg_name)
       version_warning =
         "WARN: ignoring package version: '#{pkg_name} (#{pkg_version})'\n"
@@ -85,6 +88,18 @@ describe Wright::Provider::Package::Homebrew do
       end
     end
 
+    it 'should pass options to the package manager' do
+      pkg_name = 'gnu-units'
+      pkg_options = '--with-default-names'
+      pkg_provider = package_provider(pkg_name, options: pkg_options)
+      brew_install_cmd = brew(:install, pkg_name, options: pkg_options)
+
+      @fake_capture3.expect(brew_install_cmd)
+      @fake_capture3.stub do
+        pkg_provider.send(:install_package)
+      end
+    end
+
     it 'should raise exceptions for unavailable packages' do
       pkg_name = 'not-a-real-package'
       pkg_provider = package_provider(pkg_name)
@@ -111,5 +126,17 @@ describe Wright::Provider::Package::Homebrew do
         pkg_provider.send(:remove_package)
       end
     end
+
+    it 'should pass options to the package manager' do
+      pkg_name = 'lame'
+      pkg_options = ['--force']
+      pkg_provider = package_provider(pkg_name, options: pkg_options)
+      brew_uninstall_cmd = brew(:uninstall, pkg_name, options: pkg_options)
+
+      @fake_capture3.expect(brew_uninstall_cmd)
+      @fake_capture3.stub do
+        pkg_provider.send(:remove_package)
+      end
+    end
   end
 end

data/spec/provider/package/yum/rpm_-q_httpd.return

@@ -0,0 +1 @@
+1

data/spec/provider/package/yum/rpm_-q_httpd.stdout

@@ -0,0 +1 @@
+package httpd is not installed

data/spec/provider/package/yum/rpm_-q_zsh.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/yum/rpm_-q_zsh.stdout

@@ -0,0 +1 @@
+5.0.2-7.el7_1.1

data/spec/provider/package/yum/yum_install_-y_mc-4.8.7-8.el7.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/yum/yum_install_-y_mc-4.8.7-8.el7.stdout

@@ -0,0 +1,37 @@
+Loaded plugins: fastestmirror
+Loading mirror speeds from cached hostfile
+ * base: mirror.digitalnova.at
+ * extras: mirror.digitalnova.at
+ * updates: ftp.tugraz.at
+Resolving Dependencies
+--> Running transaction check
+---> Package mc.x86_64 1:4.8.7-8.el7 will be installed
+--> Finished Dependency Resolution
+
+Dependencies Resolved
+
+================================================================================
+ Package       Arch              Version                  Repository       Size
+================================================================================
+Installing:
+ mc            x86_64            1:4.8.7-8.el7            base            1.7 M
+
+Transaction Summary
+================================================================================
+Install  1 Package
+
+Total download size: 1.7 M
+Installed size: 5.6 M
+Downloading packages:
+Delta RPMs disabled because /usr/bin/applydeltarpm not installed.
+Running transaction check
+Running transaction test
+Transaction test succeeded
+Running transaction
+  Installing : 1:mc-4.8.7-8.el7.x86_64                                      1/1 
+  Verifying  : 1:mc-4.8.7-8.el7.x86_64                                      1/1 
+
+Installed:
+  mc.x86_64 1:4.8.7-8.el7                                                       
+
+Complete!

data/spec/provider/package/yum/yum_install_-y_nano.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/yum/yum_install_-y_nano.stdout

@@ -0,0 +1,36 @@
+Loaded plugins: fastestmirror
+Loading mirror speeds from cached hostfile
+ * base: mirror.digitalnova.at
+ * extras: mirror.digitalnova.at
+ * updates: ftp.tugraz.at
+Resolving Dependencies
+--> Running transaction check
+---> Package nano.x86_64 0:2.3.1-10.el7 will be installed
+--> Finished Dependency Resolution
+
+Dependencies Resolved
+
+================================================================================
+ Package        Arch             Version                   Repository      Size
+================================================================================
+Installing:
+ nano           x86_64           2.3.1-10.el7              base           440 k
+
+Transaction Summary
+================================================================================
+Install  1 Package
+
+Total download size: 440 k
+Installed size: 1.6 M
+Downloading packages:
+Running transaction check
+Running transaction test
+Transaction test succeeded
+Running transaction
+  Installing : nano-2.3.1-10.el7.x86_64                                     1/1 
+  Verifying  : nano-2.3.1-10.el7.x86_64                                     1/1 
+
+Installed:
+  nano.x86_64 0:2.3.1-10.el7                                                    
+
+Complete!

data/spec/provider/package/yum/yum_install_-y_not-a-real-package.return

@@ -0,0 +1 @@
+1

data/spec/provider/package/yum/yum_install_-y_not-a-real-package.stderr

@@ -0,0 +1 @@
+Error: Nothing to do

data/spec/provider/package/yum/yum_install_-y_not-a-real-package.stdout

@@ -0,0 +1,6 @@
+Loaded plugins: fastestmirror
+Loading mirror speeds from cached hostfile
+ * base: mirror.nextlayer.at
+ * extras: mirror.netcologne.de
+ * updates: mirror.netcologne.de
+No package not-a-real-package available.

data/spec/provider/package/yum/yum_install_with_options.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/yum/yum_install_with_options.stdout

@@ -0,0 +1,53 @@
+Loaded plugins: fastestmirror
+Loading mirror speeds from cached hostfile
+ * base: mirror.nextlayer.at
+ * centosplus: mirror.nextlayer.at
+ * extras: mirror.nextlayer.at
+ * updates: mirror.nextlayer.at
+Resolving Dependencies
+--> Running transaction check
+---> Package postfix.x86_64 2:2.10.1-6.el7 will be updated
+---> Package postfix.x86_64 2:2.10.1-6.0.1.el7.centos will be an update
+--> Processing Dependency: libpq.so.5()(64bit) for package: 2:postfix-2.10.1-6.0.1.el7.centos.x86_64
+--> Running transaction check
+---> Package postgresql-libs.x86_64 0:9.2.10-2.el7_1 will be installed
+--> Finished Dependency Resolution
+
+Dependencies Resolved
+
+================================================================================
+ Package            Arch      Version                       Repository     Size
+================================================================================
+Updating:
+ postfix            x86_64    2:2.10.1-6.0.1.el7.centos     centosplus    2.5 M
+Installing for dependencies:
+ postgresql-libs    x86_64    9.2.10-2.el7_1                updates       230 k
+
+Transaction Summary
+================================================================================
+Install             ( 1 Dependent package)
+Upgrade  1 Package
+
+Total download size: 2.7 M
+Downloading packages:
+Delta RPMs disabled because /usr/bin/applydeltarpm not installed.
+--------------------------------------------------------------------------------
+Total                                              382 kB/s | 2.7 MB  00:07     
+Running transaction check
+Running transaction test
+Transaction test succeeded
+Running transaction
+  Installing : postgresql-libs-9.2.10-2.el7_1.x86_64                        1/3 
+  Updating   : 2:postfix-2.10.1-6.0.1.el7.centos.x86_64                     2/3 
+  Cleanup    : 2:postfix-2.10.1-6.el7.x86_64                                3/3 
+  Verifying  : postgresql-libs-9.2.10-2.el7_1.x86_64                        1/3 
+  Verifying  : 2:postfix-2.10.1-6.0.1.el7.centos.x86_64                     2/3 
+  Verifying  : 2:postfix-2.10.1-6.el7.x86_64                                3/3 
+
+Dependency Installed:
+  postgresql-libs.x86_64 0:9.2.10-2.el7_1                                       
+
+Updated:
+  postfix.x86_64 2:2.10.1-6.0.1.el7.centos                                      
+
+Complete!

data/spec/provider/package/yum/yum_remove_-y_screen.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/yum/yum_remove_-y_screen.stdout

@@ -0,0 +1,31 @@
+Loaded plugins: fastestmirror
+Resolving Dependencies
+--> Running transaction check
+---> Package screen.x86_64 0:4.1.0-0.19.20120314git3c2946.el7 will be erased
+--> Finished Dependency Resolution
+
+Dependencies Resolved
+
+================================================================================
+ Package     Arch        Version                               Repository  Size
+================================================================================
+Removing:
+ screen      x86_64      4.1.0-0.19.20120314git3c2946.el7      @base      914 k
+
+Transaction Summary
+================================================================================
+Remove  1 Package
+
+Installed size: 914 k
+Downloading packages:
+Running transaction check
+Running transaction test
+Transaction test succeeded
+Running transaction
+  Erasing    : screen-4.1.0-0.19.20120314git3c2946.el7.x86_64               1/1 
+  Verifying  : screen-4.1.0-0.19.20120314git3c2946.el7.x86_64               1/1 
+
+Removed:
+  screen.x86_64 0:4.1.0-0.19.20120314git3c2946.el7                              
+
+Complete!

data/spec/provider/package/yum/yum_remove_with_options.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/yum/yum_remove_with_options.stdout

@@ -0,0 +1,30 @@
+Resolving Dependencies
+--> Running transaction check
+---> Package vim-enhanced.x86_64 2:7.4.160-1.el7 will be erased
+--> Finished Dependency Resolution
+
+Dependencies Resolved
+
+================================================================================
+ Package             Arch          Version                   Repository    Size
+================================================================================
+Removing:
+ vim-enhanced        x86_64        2:7.4.160-1.el7           @base        2.2 M
+
+Transaction Summary
+================================================================================
+Remove  1 Package
+
+Installed size: 2.2 M
+Downloading packages:
+Running transaction check
+Running transaction test
+Transaction test succeeded
+Running transaction
+  Erasing    : 2:vim-enhanced-7.4.160-1.el7.x86_64                          1/1 
+  Verifying  : 2:vim-enhanced-7.4.160-1.el7.x86_64                          1/1 
+
+Removed:
+  vim-enhanced.x86_64 2:7.4.160-1.el7                                           
+
+Complete!

data/spec/provider/package/yum_spec.rb

@@ -0,0 +1,130 @@
+require_relative '../../spec_helper'
+
+require 'wright/provider/package/yum'
+
+describe Wright::Provider::Package::Yum do
+  def rpm_q(pkg_name)
+    version_format = '%{VERSION}-%{RELEASE}'
+    %W(rpm -q #{pkg_name} --qf #{version_format})
+  end
+
+  def package_provider(pkg_name, args = {})
+    properties = { name: pkg_name,
+                   version: args[:version],
+                   options: args[:options] }
+    pkg_resource = OpenStruct.new(properties)
+    Wright::Provider::Package::Yum.new(pkg_resource)
+  end
+
+  def yum(action, pkg_name, args = {})
+    version = args[:version].nil? ? '' : "-#{args[:version]}"
+    ['yum', *args[:options], action.to_s, '-y', pkg_name + version]
+  end
+
+  before :each do
+    yum_dir = File.join(File.dirname(__FILE__), 'yum')
+    @fake_capture3 = FakeCapture3.new(yum_dir)
+  end
+
+  describe '#installed_versions' do
+    it 'should return the installed package version via brew info' do
+      pkg_name = 'zsh'
+      pkg_versions = ['5.0.2-7.el7_1.1']
+      pkg_provider = package_provider(pkg_name)
+      rpm_q_cmd = rpm_q(pkg_name)
+
+      @fake_capture3.expect(rpm_q_cmd, 'rpm_-q_zsh')
+      @fake_capture3.stub do
+        pkg_provider.installed_versions.must_equal pkg_versions
+      end
+    end
+
+    it 'should return an empty array for uninstalled packages' do
+      pkg_name = 'httpd'
+      pkg_versions = []
+      pkg_provider = package_provider(pkg_name)
+      rpm_q_cmd = rpm_q(pkg_name)
+
+      @fake_capture3.expect(rpm_q_cmd, 'rpm_-q_httpd')
+      @fake_capture3.stub do
+        pkg_provider.installed_versions.must_equal pkg_versions
+      end
+    end
+  end
+
+  describe '#install_package' do
+    it 'should install packages' do
+      pkg_name = 'nano'
+      pkg_provider = package_provider(pkg_name)
+      yum_cmd = yum(:install, pkg_name)
+
+      @fake_capture3.expect(yum_cmd)
+      @fake_capture3.stub do
+        pkg_provider.send(:install_package)
+      end
+    end
+
+    it 'should install specific package versions' do
+      pkg_name = 'mc'
+      pkg_version = '4.8.7-8.el7'
+      pkg_provider = package_provider(pkg_name, version: pkg_version)
+      yum_cmd = yum(:install, pkg_name, version: pkg_version)
+
+      @fake_capture3.expect(yum_cmd)
+      @fake_capture3.stub do
+        pkg_provider.send(:install_package)
+      end
+    end
+
+    it 'should pass options to the package manager' do
+      pkg_name = 'postfix'
+      pkg_options = '--enablerepo=centosplus'
+      pkg_provider = package_provider(pkg_name, options: pkg_options)
+      yum_cmd = yum(:install, pkg_name, options: pkg_options)
+
+      @fake_capture3.expect(yum_cmd, 'yum_install_with_options')
+      @fake_capture3.stub do
+        pkg_provider.send(:install_package)
+      end
+    end
+
+    it 'should raise exceptions for unknown packages' do
+      pkg_name = 'not-a-real-package'
+      pkg_provider = package_provider(pkg_name)
+      yum_cmd = yum(:install, pkg_name)
+
+      @fake_capture3.expect(yum_cmd)
+      @fake_capture3.stub do
+        e = -> { pkg_provider.send(:install_package) }.must_raise RuntimeError
+        wright_error = "cannot install package '#{pkg_name}'"
+        yum_error = 'Error: Nothing to do'
+        e.message.must_equal %(#{wright_error}: "#{yum_error}")
+      end
+    end
+  end
+
+  describe '#remove_package' do
+    it 'should remove packages' do
+      pkg_name = 'screen'
+      pkg_provider = package_provider(pkg_name)
+      yum_cmd = yum(:remove, pkg_name)
+
+      @fake_capture3.expect(yum_cmd)
+      @fake_capture3.stub do
+        pkg_provider.send(:remove_package)
+      end
+    end
+
+    it 'should pass options to the package manager' do
+      pkg_name = 'vim'
+      pkg_options = ['--noplugins']
+      pkg_provider = package_provider(pkg_name, options: pkg_options)
+      yum_cmd = yum(:remove, pkg_name, options: pkg_options)
+
+      @fake_capture3.expect(yum_cmd, 'yum_remove_with_options')
+      @fake_capture3.stub do
+        pkg_provider.send(:remove_package)
+      end
+    end
+  end
+end

data/spec/provider/user/darwin_directory_service_spec.rb

@@ -26,13 +26,15 @@ describe Wright::Provider::User::DarwinDirectoryService do
     FakeEtc.clear_groups
   end
 
-  describe '#add_user' do
+  describe '#create_user' do
     before(:each) do
-      Wright::Provider::User::DarwinDirectoryService.send(:public, :add_user)
+      Wright::Provider::User::DarwinDirectoryService.send(:public,
+                                                          :create_user)
     end
 
     after(:each) do
-      Wright::Provider::User::DarwinDirectoryService.send(:private, :add_user)
+      Wright::Provider::User::DarwinDirectoryService.send(:private,
+                                                          :create_user)
     end
 
     it 'should add users' do
@@ -55,7 +57,7 @@ describe Wright::Provider::User::DarwinDirectoryService do
       @fake_capture3.expect(dscl(:create, user, 'Password', '*'),
                             'dscl-new-user-password')
       @fake_capture3.stub do
-        FakeEtc { provider.add_user }
+        FakeEtc { provider.create_user }
       end
     end
 
@@ -80,7 +82,7 @@ describe Wright::Provider::User::DarwinDirectoryService do
       @fake_capture3.expect(dscl(:create, user, 'Password', '*'),
                             'dscl-new-user-password')
       @fake_capture3.stub do
-        FakeEtc { provider.add_user }
+        FakeEtc { provider.create_user }
       end
     end
 
@@ -112,7 +114,7 @@ describe Wright::Provider::User::DarwinDirectoryService do
       @fake_capture3.expect(dscl(:create, user, 'Password', '*'),
                             'dscl-new-user-password')
       @fake_capture3.stub do
-        FakeEtc { provider.add_user }
+        FakeEtc { provider.create_user }
       end
     end
   end
@@ -142,15 +144,15 @@ describe Wright::Provider::User::DarwinDirectoryService do
     end
   end
 
-  describe '#delete_user' do
+  describe '#remove_user' do
     before(:each) do
       Wright::Provider::User::DarwinDirectoryService.send(:public,
-                                                          :delete_user)
+                                                          :remove_user)
     end
 
     after(:each) do
       Wright::Provider::User::DarwinDirectoryService.send(:private,
-                                                          :delete_user)
+                                                          :remove_user)
     end
 
     it 'should delete users' do
@@ -160,7 +162,7 @@ describe Wright::Provider::User::DarwinDirectoryService do
       @fake_capture3.expect(%W(dscl . -delete /Users/#{@resource.name}),
                             'dscl-delete-user')
       @fake_capture3.stub do
-        FakeEtc { provider.delete_user }
+        FakeEtc { provider.remove_user }
       end
     end
   end

data/spec/provider/user/gnu_passwd_spec.rb

@@ -18,13 +18,13 @@ describe Wright::Provider::User::GnuPasswd do
     FakeEtc.clear_groups
   end
 
-  describe '#add_user' do
+  describe '#create_user' do
     before(:each) do
-      Wright::Provider::User::GnuPasswd.send(:public, :add_user)
+      Wright::Provider::User::GnuPasswd.send(:public, :create_user)
     end
 
     after(:each) do
-      Wright::Provider::User::GnuPasswd.send(:private, :add_user)
+      Wright::Provider::User::GnuPasswd.send(:private, :create_user)
     end
 
     it 'should add users' do
@@ -32,7 +32,7 @@ describe Wright::Provider::User::GnuPasswd do
 
       @fake_capture3.expect(%W(useradd #{@resource.name}))
       @fake_capture3.stub do
-        FakeEtc { provider.add_user }
+        FakeEtc { provider.create_user }
       end
     end
 
@@ -59,7 +59,7 @@ describe Wright::Provider::User::GnuPasswd do
       FakeEtc.add_groups('anonymous' => { gid: 123 })
       @fake_capture3.expect(['useradd', *expected_args], 'useradd_with_options')
       @fake_capture3.stub do
-        FakeEtc { provider.add_user }
+        FakeEtc { provider.create_user }
       end
     end
   end
@@ -85,13 +85,13 @@ describe Wright::Provider::User::GnuPasswd do
     end
   end
 
-  describe '#delete_user' do
+  describe '#remove_user' do
     before(:each) do
-      Wright::Provider::User::GnuPasswd.send(:public, :delete_user)
+      Wright::Provider::User::GnuPasswd.send(:public, :remove_user)
     end
 
     after(:each) do
-      Wright::Provider::User::GnuPasswd.send(:private, :delete_user)
+      Wright::Provider::User::GnuPasswd.send(:private, :remove_user)
     end
 
     it 'should delete users' do
@@ -100,7 +100,7 @@ describe Wright::Provider::User::GnuPasswd do
       FakeEtc.add_users(@resource.name => {})
       @fake_capture3.expect(%W(userdel #{@resource.name}))
       @fake_capture3.stub do
-        FakeEtc { provider.delete_user }
+        FakeEtc { provider.remove_user }
       end
     end
   end