wright 0.3.2 → 0.4.0

data/spec/provider/group_spec.rb

@@ -6,18 +6,20 @@ require 'wright/provider'
 require 'wright/provider/group'
 
 describe Wright::Provider::Group do
-  before(:each) do
-    Wright::Provider::Group.send(:public, :uptodate?)
-  end
-
-  after(:each) do
-    Wright::Provider::Group.send(:private, :uptodate?)
-  end
+  before(:each) { @resource = OpenStruct.new(name: 'foo') }
+  after(:each) { FakeEtc.clear_groups }
 
   describe '#uptodate?' do
+    before(:each) do
+      Wright::Provider::Group.send(:public, :uptodate?)
+    end
+
+    after(:each) do
+      Wright::Provider::Group.send(:private, :uptodate?)
+    end
+
     it 'should return the correct status' do
-      resource = OpenStruct.new(name: 'foo')
-      provider = Wright::Provider::Group.new(resource)
+      provider = Wright::Provider::Group.new(@resource)
 
       FakeEtc.add_groups('foo' => { gid: 42, mem: %w(user1 user2) })
       FakeEtc do
@@ -33,9 +35,8 @@ describe Wright::Provider::Group do
     end
 
     it 'should return the correct status when given a specific gid' do
-      gid = 52
-      resource = OpenStruct.new(name: 'foo', gid: gid, members: nil)
-      provider = Wright::Provider::Group.new(resource)
+      @resource.gid = 52
+      provider = Wright::Provider::Group.new(@resource)
 
       FakeEtc.add_groups('foo' => { gid: 42, mem: [] })
       FakeEtc do
@@ -44,7 +45,7 @@ describe Wright::Provider::Group do
       end
 
       FakeEtc.clear_groups
-      FakeEtc.add_groups('foo' => { gid: gid, mem: [] })
+      FakeEtc.add_groups('foo' => { gid: @resource.gid, mem: [] })
       FakeEtc do
         provider.uptodate?(:create).must_equal true
         provider.uptodate?(:remove).must_equal false
@@ -52,9 +53,8 @@ describe Wright::Provider::Group do
     end
 
     it 'should return the correct status when given a specific member list' do
-      members = %w(user1 user2)
-      resource = OpenStruct.new(name: 'foo', gid: nil, members: members)
-      provider = Wright::Provider::Group.new(resource)
+      @resource.members = %w(user1 user2)
+      provider = Wright::Provider::Group.new(@resource)
 
       FakeEtc.add_groups('foo' => { gid: 42, mem: [] })
       FakeEtc do
@@ -63,7 +63,7 @@ describe Wright::Provider::Group do
       end
 
       FakeEtc.clear_groups
-      FakeEtc.add_groups('foo' => { gid: 42, mem: members })
+      FakeEtc.add_groups('foo' => { gid: 42, mem: @resource.members })
       FakeEtc do
         provider.uptodate?(:create).must_equal true
         provider.uptodate?(:remove).must_equal false
@@ -71,17 +71,145 @@ describe Wright::Provider::Group do
     end
 
     it 'should raise exceptions for invalid actions' do
-      resource = OpenStruct.new(name: 'foo')
-      provider = Wright::Provider::Group.new(resource)
+      provider = Wright::Provider::Group.new(@resource)
       e = -> { provider.uptodate?(:foobarbaz) }.must_raise ArgumentError
       e.message.must_equal "invalid action 'foobarbaz'"
     end
   end
 
+  describe '#create' do
+    before(:each) do
+      group = @resource.name
+      @create_message = "INFO: create group: '#{group}'\n"
+      @create_message_dry = "INFO: (would) create group: '#{group}'\n"
+      @create_message_debug = "DEBUG: group already created: '#{group}'\n"
+    end
+
+    it 'should set the update status when the group is up-to-date' do
+      provider = Wright::Provider::Group.new(@resource)
+
+      FakeEtc.add_groups('foo' => {})
+      FakeEtc do
+        lambda do
+          reset_logger
+          provider.create
+          provider.updated?.must_equal false
+        end.must_output @create_message_debug
+      end
+    end
+
+    it 'should set the update status when the group has to be created' do
+      provider = Wright::Provider::Group.new(@resource)
+      mock_provider = Minitest::Mock.new
+
+      mock_provider.expect(:create_group, nil)
+      provider.stub :create_group, -> { mock_provider.create_group } do
+        FakeEtc do
+          lambda do
+            reset_logger
+            provider.create
+            provider.updated?.must_equal true
+          end.must_output @create_message
+        end
+        mock_provider.verify
+      end
+    end
+
+    it 'should set the update status when the group has to be updated' do
+      @resource.gid = 123
+      @resource.members = %w(johndoe janedoe)
+      provider = Wright::Provider::Group.new(@resource)
+      mock_provider = Minitest::Mock.new
+
+      mock_provider.expect(:set_gid, nil)
+      mock_provider.expect(:set_members, nil)
+      provider.stub :set_gid, -> { mock_provider.set_gid } do
+        provider.stub :set_members, -> { mock_provider.set_members } do
+          FakeEtc.add_groups(@resource.name => { mem: [] })
+          FakeEtc do
+            lambda do
+              reset_logger
+              provider.create
+              provider.updated?.must_equal true
+            end.must_output @create_message
+          end
+        end
+      end
+      mock_provider.verify
+    end
+
+    it 'should set the update status in dry-run mode' do
+      provider = Wright::Provider::Group.new(@resource)
+
+      Wright.dry_run do
+        FakeEtc do
+          lambda do
+            reset_logger
+            provider.create
+            provider.updated?.must_equal true
+          end.must_output @create_message_dry
+        end
+      end
+    end
+  end
+
+  describe '#remove' do
+    before(:each) do
+      group = @resource.name
+      @remove_message = "INFO: remove group: '#{group}'\n"
+      @remove_message_dry = "INFO: (would) remove group: '#{group}'\n"
+      @remove_message_debug = "DEBUG: group already removed: '#{group}'\n"
+    end
+
+    it 'should set the update status when the group is already removed' do
+      provider = Wright::Provider::Group.new(@resource)
+
+      FakeEtc do
+        lambda do
+          reset_logger
+          provider.remove
+          provider.updated?.must_equal false
+        end.must_output @remove_message_debug
+      end
+    end
+
+    it 'should set the update status when the group has to be removed' do
+      provider = Wright::Provider::Group.new(@resource)
+      mock_provider = Minitest::Mock.new
+
+      mock_provider.expect(:remove_group, nil)
+      provider.stub :remove_group, -> { mock_provider.remove_group } do
+        FakeEtc.add_groups(@resource.name => {})
+        FakeEtc do
+          lambda do
+            reset_logger
+            provider.remove
+            provider.updated?.must_equal true
+          end.must_output @remove_message
+        end
+      end
+      mock_provider.verify
+    end
+
+    it 'should set the update status in dry-run mode' do
+      provider = Wright::Provider::Group.new(@resource)
+
+      Wright.dry_run do
+        FakeEtc.add_groups(@resource.name => {})
+        FakeEtc do
+          lambda do
+            reset_logger
+            provider.remove
+            provider.updated?.must_equal true
+          end.must_output @remove_message_dry
+        end
+      end
+    end
+  end
+
   describe '#add_member' do
     it 'should raise an exception' do
-      resource = OpenStruct.new(name: 'foo')
-      provider = Wright::Provider::Group.new(resource)
+      provider = Wright::Provider::Group.new(@resource)
       lambda do
         provider.send(:add_member, 'member', 'group')
       end.must_raise NotImplementedError
@@ -90,8 +218,7 @@ describe Wright::Provider::Group do
 
   describe '#remove_member' do
     it 'should raise an exception' do
-      resource = OpenStruct.new(name: 'foo')
-      provider = Wright::Provider::Group.new(resource)
+      provider = Wright::Provider::Group.new(@resource)
       lambda do
         provider.send(:remove_member, 'member', 'group')
       end.must_raise NotImplementedError
@@ -100,12 +227,11 @@ describe Wright::Provider::Group do
 
   describe '#set_members' do
     it 'should use add_member and remove_member to update the member list' do
-      group_name = 'foo'
+      group_name = @resource.name
       current_members = %w(user1 user2 user3)
       target_members = %w(user3 user4 user5)
-      resource = OpenStruct.new(name: group_name,
-                                members: target_members)
-      provider = Wright::Provider::Group.new(resource)
+      @resource.members = target_members
+      provider = Wright::Provider::Group.new(@resource)
       Wright::Provider::Group.send(:public, :set_members)
 
       mock_provider = Minitest::Mock.new
@@ -129,4 +255,31 @@ describe Wright::Provider::Group do
       Wright::Provider::Group.send(:private, :set_members)
     end
   end
+
+  describe '#create_group' do
+    it 'should raise an exception' do
+      provider = Wright::Provider::Group.new(@resource)
+      lambda do
+        provider.send(:create_group)
+      end.must_raise NotImplementedError
+    end
+  end
+
+  describe '#remove_group' do
+    it 'should raise an exception' do
+      provider = Wright::Provider::Group.new(@resource)
+      lambda do
+        provider.send(:remove_group)
+      end.must_raise NotImplementedError
+    end
+  end
+
+  describe '#set_gid' do
+    it 'should raise an exception' do
+      provider = Wright::Provider::Group.new(@resource)
+      lambda do
+        provider.send(:set_gid)
+      end.must_raise NotImplementedError
+    end
+  end
 end

data/spec/provider/package/apt/apt-cache_policy_dmenu.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/apt/apt-cache_policy_dmenu.stdout

@@ -0,0 +1,4 @@
+dmenu:
+  Installed: (none)
+  Candidate: (none)
+  Version table:

data/spec/provider/package/apt/apt-cache_policy_htop.stdout

@@ -1,6 +1,6 @@
 htop:
   Installed: (none)
-  Candidate: 1.0.1-1
+  Candidate: 1.0.3-1
   Version table:
-     1.0.1-1 0
-        500 http://debian.inode.at/debian/ wheezy/main amd64 Packages
+     1.0.3-1 0
+        500 http://debian.inode.at/debian/ jessie/main amd64 Packages

data/spec/provider/package/apt/apt-cache_policy_linux-image-3.2.0-4-amd64.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/apt/apt-cache_policy_linux-image-3.2.0-4-amd64.stdout

@@ -0,0 +1,6 @@
+linux-image-3.2.0-4-amd64:
+  Installed: 3.2.65-1+deb7u2
+  Candidate: 3.2.65-1+deb7u2
+  Version table:
+ *** 3.2.65-1+deb7u2 0
+        100 /var/lib/dpkg/status

data/spec/provider/package/apt/apt-cache_policy_linux-image.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/apt/apt-cache_policy_linux-image.stdout

@@ -0,0 +1,4 @@
+linux-image:
+  Installed: (none)
+  Candidate: (none)
+  Version table:

data/spec/provider/package/apt/apt-cache_policy_suckless-tools.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/apt/apt-cache_policy_suckless-tools.stdout

@@ -0,0 +1,6 @@
+suckless-tools:
+  Installed: (none)
+  Candidate: 40-1
+  Version table:
+     40-1 0
+        500 http://debian.inode.at/debian/ jessie/main amd64 Packages

data/spec/provider/package/apt/apt-cache_showpkg_dmenu.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/apt/apt-cache_showpkg_dmenu.stdout

@@ -0,0 +1,9 @@
+Package: dmenu
+Versions: 
+
+Reverse Depends: 
+  xmonad,dmenu
+Dependencies: 
+Provides: 
+Reverse Provides: 
+suckless-tools 40-1

data/spec/provider/package/apt/apt-cache_showpkg_htop.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/apt/apt-cache_showpkg_htop.stdout

@@ -0,0 +1,20 @@
+Package: htop
+Versions: 
+1.0.3-1 (/var/lib/apt/lists/debian.inode.at_debian_dists_jessie_main_binary-amd64_Packages) (/var/lib/dpkg/status)
+ Description Language: 
+                 File: /var/lib/apt/lists/debian.inode.at_debian_dists_jessie_main_binary-amd64_Packages
+                  MD5: 8eb5aa19b3c92a975dc78e2165f6688d
+ Description Language: en
+                 File: /var/lib/apt/lists/debian.inode.at_debian_dists_jessie_main_i18n_Translation-en
+                  MD5: 8eb5aa19b3c92a975dc78e2165f6688d
+
+
+Reverse Depends: 
+  util-vserver,htop
+  lava-dispatcher,htop
+  education-common,htop
+Dependencies: 
+1.0.3-1 - libc6 (2 2.15) libncursesw5 (2 5.6+20070908) libtinfo5 (0 (null)) strace (0 (null)) ltrace (0 (null)) 
+Provides: 
+1.0.3-1 - 
+Reverse Provides: 

data/spec/provider/package/apt/apt-cache_showpkg_linux-image.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/apt/apt-cache_showpkg_linux-image.stdout

@@ -0,0 +1,11 @@
+Package: linux-image
+Versions: 
+
+Reverse Depends: 
+  firmware-crystalhd,linux-image
+  kernel-common,linux-image
+  dkms,linux-image
+Dependencies: 
+Provides: 
+Reverse Provides: 
+linux-image-3.2.0-4-amd64 3.2.65-1+deb7u2

data/spec/provider/package/apt/apt-cache_showpkg_not-a-real-package.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/apt/apt-cache_showpkg_not-a-real-package.stdout

@@ -0,0 +1 @@
+N: Unable to locate package not-a-real-package

data/spec/provider/package/apt/apt-cache_showpkg_suckless-tools.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/apt/apt-cache_showpkg_suckless-tools.stdout

@@ -0,0 +1,26 @@
+Package: suckless-tools
+Versions: 
+40-1 (/var/lib/apt/lists/debian.inode.at_debian_dists_jessie_main_binary-amd64_Packages)
+ Description Language: 
+                 File: /var/lib/apt/lists/debian.inode.at_debian_dists_jessie_main_binary-amd64_Packages
+                  MD5: d19175bb7582a6f06fe2a6daa5910d10
+ Description Language: en
+                 File: /var/lib/apt/lists/debian.inode.at_debian_dists_jessie_main_i18n_Translation-en
+                  MD5: d19175bb7582a6f06fe2a6daa5910d10
+
+
+Reverse Depends: 
+  wmii,suckless-tools
+  uzbl,suckless-tools
+  surf,suckless-tools
+  spectrwm,suckless-tools
+  ncurses-term,suckless-tools 39
+  ncurses-term,suckless-tools 39
+  i3,suckless-tools
+  herbstluftwm,suckless-tools
+  dwm,suckless-tools
+Dependencies: 
+40-1 - libc6 (2 2.14) libfontconfig1 (2 2.11) libfreetype6 (2 2.2.1) libx11-6 (0 (null)) libxext6 (0 (null)) libxft2 (4 2.1.1) libxinerama1 (0 (null)) libxrender1 (0 (null)) libxss1 (0 (null)) zlib1g (2 1:1.1.4) dwm (0 (null)) stterm (0 (null)) surf (0 (null)) 
+Provides: 
+40-1 - xssstate wmname tabbed swarp ssid sselp sprop slock lsx lsw dmenu 
+Reverse Provides: 

data/spec/provider/package/apt/apt-get_--purge_remove_-qy_abcde.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/apt/apt-get_--purge_remove_-qy_abcde.stdout

@@ -0,0 +1,15 @@
+Reading package lists...
+Building dependency tree...
+Reading state information...
+The following packages were automatically installed and are no longer required:
+  cd-discid cdparanoia libmusicbrainz-discid-perl
+  libwebservice-musicbrainz-perl vorbis-tools
+Use 'apt-get autoremove' to remove them.
+The following packages will be REMOVED:
+  abcde*
+0 upgraded, 0 newly installed, 1 to remove and 0 not upgraded.
+After this operation, 295 kB disk space will be freed.
+(Reading database ... 
+Removing abcde (2.6-2) ...
+Purging configuration files for abcde (2.6-2) ...
+Processing triggers for man-db (2.7.0.2-5) ...

data/spec/provider/package/apt_spec.rb

@@ -3,17 +3,21 @@ require_relative '../../spec_helper'
 require 'wright/provider/package/apt'
 
 describe Wright::Provider::Package::Apt do
-  def apt_cache(pkg_name)
-    ['apt-cache', 'policy', pkg_name]
+  def apt_cache(cmd, pkg_name)
+    ['apt-cache', cmd.to_s, pkg_name]
   end
 
-  def apt_get(action, pkg_name, pkg_version = nil)
-    version = pkg_version.nil? ? '' : "=#{pkg_version}"
-    ['apt-get', action.to_s, '-qy', pkg_name + version]
+  def apt_get(action, pkg_name, args = {})
+    version = args[:version].nil? ? '' : "=#{args[:version]}"
+    options = args[:options]
+    ['apt-get', *options, action.to_s, '-qy', pkg_name + version]
   end
 
-  def package_provider(pkg_name, pkg_version = nil)
-    pkg_resource = OpenStruct.new(name: pkg_name, version: pkg_version)
+  def package_provider(pkg_name, args = {})
+    properties = { name: pkg_name,
+                   version: args[:version],
+                   options: args[:options] }
+    pkg_resource = OpenStruct.new(properties)
     Wright::Provider::Package::Apt.new(pkg_resource)
   end
 
@@ -28,7 +32,7 @@ describe Wright::Provider::Package::Apt do
       pkg_name = 'abcde'
       pkg_versions = ['2.5.3-1']
       pkg_provider = package_provider(pkg_name)
-      apt_cache_cmd = apt_cache(pkg_name)
+      apt_cache_cmd = apt_cache(:policy, pkg_name)
 
       @fake_capture3.expect(apt_cache_cmd)
       @fake_capture3.stub do
@@ -40,9 +44,47 @@ describe Wright::Provider::Package::Apt do
       pkg_name = 'htop'
       pkg_versions = []
       pkg_provider = package_provider(pkg_name)
-      apt_cache_cmd = apt_cache(pkg_name)
+      apt_cache_policy_cmd = apt_cache(:policy, pkg_name)
+      apt_cache_showpkg_cmd = apt_cache(:showpkg, pkg_name)
 
-      @fake_capture3.expect(apt_cache_cmd)
+      @fake_capture3.expect(apt_cache_policy_cmd)
+      @fake_capture3.expect(apt_cache_showpkg_cmd)
+      @fake_capture3.stub do
+        pkg_provider.installed_versions.must_equal pkg_versions
+      end
+    end
+
+    it 'should handle virtual packages for which providers are installed' do
+      pkg_name = 'linux-image'
+      provider_name = 'linux-image-3.2.0-4-amd64'
+      pkg_versions = ['virtual']
+      pkg_provider = package_provider(pkg_name)
+      apt_cache_policy_cmd = apt_cache(:policy, pkg_name)
+      apt_cache_showpkg_cmd = apt_cache(:showpkg, pkg_name)
+      apt_cache_policy_provider_cmd = apt_cache(:policy, provider_name)
+
+      @fake_capture3.expect(apt_cache_policy_cmd)
+      @fake_capture3.expect(apt_cache_showpkg_cmd)
+      @fake_capture3.expect(apt_cache_policy_provider_cmd)
+      @fake_capture3.stub do
+        pkg_provider.installed_versions.must_equal pkg_versions
+      end
+    end
+
+    it 'should handle virtual packages for which no providers are installed' do
+      pkg_name = 'dmenu'
+      provider_name = 'suckless-tools'
+      pkg_versions = []
+      pkg_provider = package_provider(pkg_name)
+      apt_cache_policy_cmd = apt_cache(:policy, pkg_name)
+      apt_cache_showpkg_cmd = apt_cache(:showpkg, pkg_name)
+      apt_cache_policy_provider_cmd = apt_cache(:policy, provider_name)
+      apt_cache_showpkg_provider_cmd = apt_cache(:showpkg, provider_name)
+
+      @fake_capture3.expect(apt_cache_policy_cmd)
+      @fake_capture3.expect(apt_cache_showpkg_cmd)
+      @fake_capture3.expect(apt_cache_policy_provider_cmd)
+      @fake_capture3.expect(apt_cache_showpkg_provider_cmd)
       @fake_capture3.stub do
         pkg_provider.installed_versions.must_equal pkg_versions
       end
@@ -52,9 +94,11 @@ describe Wright::Provider::Package::Apt do
       pkg_name = 'not-a-real-package'
       pkg_versions = []
       pkg_provider = package_provider(pkg_name)
-      apt_cache_cmd = apt_cache(pkg_name)
+      apt_cache_policy_cmd = apt_cache(:policy, pkg_name)
+      apt_cache_showpkg_cmd = apt_cache(:showpkg, pkg_name)
 
-      @fake_capture3.expect(apt_cache_cmd)
+      @fake_capture3.expect(apt_cache_policy_cmd)
+      @fake_capture3.expect(apt_cache_showpkg_cmd)
       @fake_capture3.stub do
         pkg_provider.installed_versions.must_equal pkg_versions
       end
@@ -76,8 +120,8 @@ describe Wright::Provider::Package::Apt do
     it 'should install specific package versions' do
       pkg_name = 'abcde'
       pkg_version = '2.5.4-1'
-      pkg_provider = package_provider(pkg_name, pkg_version)
-      apt_cmd = apt_get(:install, pkg_name, pkg_version)
+      pkg_provider = package_provider(pkg_name, version: pkg_version)
+      apt_cmd = apt_get(:install, pkg_name, version: pkg_version)
 
       @fake_capture3.expect(apt_cmd)
       @fake_capture3.stub do
@@ -85,6 +129,18 @@ describe Wright::Provider::Package::Apt do
       end
     end
 
+    it 'should pass options to the package manager' do
+      pkg_name = 'htop'
+      pkg_options = ['--no-install-recommends']
+      pkg_provider = package_provider(pkg_name, options: pkg_options)
+      apt_cmd = apt_get(:install, pkg_name, options: pkg_options)
+
+      @fake_capture3.expect(apt_cmd, 'apt-get_install_-qy_htop')
+      @fake_capture3.stub do
+        pkg_provider.send(:install_package)
+      end
+    end
+
     it 'should raise exceptions for unknown packages' do
       pkg_name = 'not-a-real-package'
       pkg_provider = package_provider(pkg_name)
@@ -111,5 +167,17 @@ describe Wright::Provider::Package::Apt do
         pkg_provider.send(:remove_package)
       end
     end
+
+    it 'should pass options to the package manager' do
+      pkg_name = 'abcde'
+      pkg_options = ['--purge']
+      pkg_provider = package_provider(pkg_name, options: pkg_options)
+      apt_cmd = apt_get(:remove, pkg_name, options: pkg_options)
+
+      @fake_capture3.expect(apt_cmd)
+      @fake_capture3.stub do
+        pkg_provider.send(:remove_package)
+      end
+    end
   end
 end

data/spec/provider/package/homebrew/brew_install_--with-default-names_gnu-units.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/homebrew/brew_install_--with-default-names_gnu-units.stdout

@@ -0,0 +1,7 @@
+==> Downloading http://ftpmirror.gnu.org/units/units-2.02.tar.gz
+Already downloaded: /Library/Caches/Homebrew/gnu-units-2.02.tar.gz
+==> Patching
+patching file definitions.units
+==> ./configure --prefix=/usr/local/Cellar/gnu-units/2.02
+==> make install
+🍺  /usr/local/Cellar/gnu-units/2.02: 12 files, 624K, built in 11 seconds

data/spec/provider/package/homebrew/brew_uninstall_--force_lame.return

@@ -0,0 +1 @@
+0

data/spec/provider/package/homebrew/brew_uninstall_--force_lame.stdout

@@ -0,0 +1 @@
+Uninstalling lame... (25 files, 2.1M)