winrm 2.2.3 → 2.3.0

data/tests/matchers.rb

@@ -1,4 +1,3 @@
-# encoding: UTF-8
 require 'rspec/expectations'
 
 # rspec matchers
@@ -23,7 +22,7 @@ end
 RSpec::Matchers.define :have_no_stdout do
   match do |actual_output|
     stdout = actual_output.stdout
-    stdout == '\r\n' || stdout == ''
+    ['\r\n', ''].include?(stdout)
   end
   failure_message do |actual_output|
     "expected that '#{actual_output.stdout}' would have no stdout"
@@ -33,7 +32,7 @@ end
 RSpec::Matchers.define :have_no_stderr do
   match do |actual_output|
     stderr = actual_output.stderr
-    stderr == '\r\n' || stderr == ''
+    ['\r\n', ''].include?(stderr)
   end
   failure_message do |actual_output|
     "expected that '#{actual_output.stderr}' would have no stderr"

data/tests/spec/configuration_spec.rb

@@ -1,4 +1,3 @@
-# encoding: UTF-8
 require 'winrm/connection_opts'
 
 describe WinRM::ConnectionOpts do

data/tests/spec/connection_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm'
 require 'winrm/shells/cmd'
 require 'winrm/shells/power_shell'

data/tests/spec/exception_spec.rb

@@ -1,4 +1,3 @@
-# encoding: UTF-8
 describe 'Exceptions' do
   describe WinRM::WinRMAuthorizationError do
     let(:error) { WinRM::WinRMHTTPTransportError.new('Foo happened', 500) }

data/tests/spec/http/transport_factory_spec.rb

@@ -1,4 +1,3 @@
-# encoding: UTF-8
 require 'winrm/exceptions'
 require 'winrm/http/transport_factory'
 
@@ -6,8 +5,7 @@ module WinRM
   module HTTP
     # Remove the gssapi stuff in kerberos init for tests
     class HttpGSSAPI < HttpTransport
-      def initialize(endpoint, realm, opts, service = nil)
-      end
+      def initialize(endpoint, realm, opts, service = nil) end
     end
   end
 end

data/tests/spec/http/transport_spec.rb

@@ -1,4 +1,3 @@
-# encoding: UTF-8
 require 'rubyntlm'
 require 'winrm/http/transport'
 

data/tests/spec/output_spec.rb

@@ -1,4 +1,3 @@
-# encoding: UTF-8
 describe WinRM::Output do
   subject { WinRM::Output.new }
 
@@ -87,7 +86,8 @@ describe WinRM::Output do
     describe '#stdout' do
       it 'is equal to that line' do
         expect(subject.stdout).to eq(
-          'I can have a newline\nanywhere, or stdout or nothing! (above)')
+          'I can have a newline\nanywhere, or stdout or nothing! (above)'
+        )
       end
     end
 
@@ -101,7 +101,8 @@ describe WinRM::Output do
       it 'is equal to stdout + stderr' do
         expect(subject.output).to eq(
           'I can have a newline\nanywhere, I can also have stderror stdout ' \
-            'and stderr or nothing! (above)')
+            'and stderr or nothing! (above)'
+        )
       end
     end
   end

data/tests/spec/psrp/fragment_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/psrp/fragment'
 
 describe WinRM::PSRP::Fragment do

data/tests/spec/psrp/message_data/base_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/psrp/message_data/base'
 
 describe WinRM::PSRP::MessageData::Base do

data/tests/spec/psrp/message_data/error_record_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/psrp/message_data/base'
 require 'winrm/psrp/message_data/error_record'
 

data/tests/spec/psrp/message_data/pipeline_host_call_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/psrp/message_data/base'
 require 'winrm/psrp/message_data/pipeline_host_call'
 

data/tests/spec/psrp/message_data/pipeline_output_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/psrp/message_data/base'
 require 'winrm/psrp/message_data/pipeline_output'
 

data/tests/spec/psrp/message_data/pipeline_state_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/psrp/message_data/base'
 require 'winrm/psrp/message_data/pipeline_state'
 

data/tests/spec/psrp/message_data/runspace_pool_host_call_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/psrp/message_data/base'
 require 'winrm/psrp/message_data/runspacepool_host_call'
 

data/tests/spec/psrp/message_data/runspacepool_state_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/psrp/message_data/base'
 require 'winrm/psrp/message_data/runspacepool_state'
 

data/tests/spec/psrp/message_data/session_capability_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/psrp/message_data/base'
 require 'winrm/psrp/message_data/session_capability'
 

data/tests/spec/psrp/message_data_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/psrp/message'
 require 'winrm/psrp/message_data'
 

data/tests/spec/psrp/message_defragmenter_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/psrp/message_defragmenter'
 
 describe WinRM::PSRP::MessageDefragmenter do

data/tests/spec/psrp/message_fragmenter_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/psrp/message'
 require 'winrm/psrp/message_fragmenter'
 

data/tests/spec/psrp/powershell_output_decoder_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/psrp/powershell_output_decoder'
 
 describe WinRM::PSRP::PowershellOutputDecoder do

data/tests/spec/psrp/psrp_message_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/psrp/message'
 
 describe WinRM::PSRP::Message do
@@ -10,7 +8,8 @@ describe WinRM::PSRP::Message do
         'bc1bfbba-8215-4a04-b2df-7a3ac0310e16',
         WinRM::PSRP::Message::MESSAGE_TYPES[:pipeline_output],
         payload,
-        '4218a578-0f18-4b19-82c3-46b433319126')
+        '4218a578-0f18-4b19-82c3-46b433319126'
+      )
     end
 
     it 'sets the destination to server LE' do
@@ -21,11 +20,13 @@ describe WinRM::PSRP::Message do
     end
     it 'sets the runspace pool id' do
       expect(subject.bytes[8..23]).to eq(
-        [186, 251, 27, 188, 21, 130, 4, 74, 178, 223, 122, 58, 192, 49, 14, 22])
+        [186, 251, 27, 188, 21, 130, 4, 74, 178, 223, 122, 58, 192, 49, 14, 22]
+      )
     end
     it 'sets the pipeline id' do
       expect(subject.bytes[24..39]).to eq(
-        [120, 165, 24, 66, 24, 15, 25, 75, 130, 195, 70, 180, 51, 49, 145, 38])
+        [120, 165, 24, 66, 24, 15, 25, 75, 130, 195, 70, 180, 51, 49, 145, 38]
+      )
     end
     it 'prefixes the blob with BOM' do
       expect(subject.bytes[40..42]).to eq([239, 187, 191])
@@ -45,7 +46,8 @@ describe WinRM::PSRP::Message do
           'bc1bfbba-8215-4a04-b2df-7a3ac0310e16',
           0x00000000,
           %(<Obj RefId="0"/>),
-          '4218a578-0f18-4b19-82c3-46b433319126')
+          '4218a578-0f18-4b19-82c3-46b433319126'
+        )
       end.to raise_error(RuntimeError)
     end
   end
@@ -60,7 +62,8 @@ describe WinRM::PSRP::Message do
       WinRM::PSRP::Message.new(
         'bc1bfbba-8215-4a04-b2df-7a3ac0310e16',
         WinRM::PSRP::Message::MESSAGE_TYPES[:session_capability],
-        payload)
+        payload
+      )
     end
 
     it 'sets the pipeline id to empty' do

data/tests/spec/psrp/recieve_response_reader_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/psrp/receive_response_reader'
 
 describe WinRM::PSRP::ReceiveResponseReader do

data/tests/spec/psrp/uuid_spec.rb

@@ -1,4 +1,3 @@
-# encoding: UTF-8
 describe WinRM::PSRP::UUID do
   subject(:uuid_helper) do
     Object.new.extend(WinRM::PSRP::UUID)
@@ -22,7 +21,8 @@ describe WinRM::PSRP::UUID do
     it 'should return a Windows GUID struct compatible little endian byte array' do
       bytes = uuid_helper.uuid_to_windows_guid_bytes(uuid)
       expect(bytes).to eq(
-        [157, 225, 249, 69, 119, 139, 148, 67, 171, 12, 25, 116, 151, 102, 22, 104])
+        [157, 225, 249, 69, 119, 139, 148, 67, 171, 12, 25, 116, 151, 102, 22, 104]
+      )
     end
   end
 end

data/tests/spec/response_handler_spec.rb

@@ -1,61 +1,69 @@
-# encoding: UTF-8
-require 'winrm/http/response_handler'
-
-describe 'response handler', unit: true do
-  %w(v1 v2).each do |winrm_version|
-    context "winrm_version #{winrm_version}" do
-      let(:soap_fault) { stubbed_response("soap_fault_#{winrm_version}.xml") }
-      let(:open_shell) { stubbed_response("open_shell_#{winrm_version}.xml") }
-
-      describe "successful 200 #{winrm_version} response" do
-        it 'returns an xml doc' do
-          handler = WinRM::ResponseHandler.new(open_shell, 200)
-          xml_doc = handler.parse_to_xml
-          expect(xml_doc).to be_instance_of(REXML::Document)
-          expect(xml_doc.to_s).to eq(REXML::Document.new(open_shell).to_s)
-        end
-      end
-
-      describe "failed 500 #{winrm_version} response" do
-        it 'raises a WinRMHTTPTransportError' do
-          handler = WinRM::ResponseHandler.new('', 500)
-          expect { handler.parse_to_xml }.to raise_error(WinRM::WinRMHTTPTransportError)
-        end
-      end
-
-      describe "failed 401 #{winrm_version} response" do
-        it 'raises a WinRMAuthorizationError' do
-          handler = WinRM::ResponseHandler.new('', 401)
-          expect { handler.parse_to_xml }.to raise_error(WinRM::WinRMAuthorizationError)
-        end
-      end
-
-      describe "failed 400 #{winrm_version} response" do
-        it 'raises a WinRMWSManFault' do
-          handler = WinRM::ResponseHandler.new(soap_fault, 400)
-          begin
-            handler.parse_to_xml
-          rescue WinRM::WinRMWSManFault => e
-            expect(e.fault_code).to eq('2150858778')
-            expect(e.fault_description).to include(
-              'The specified class does not exist in the given namespace')
-          end
-        end
-      end
-    end
-  end
-
-  describe 'failed 500 WMI error response' do
-    let(:wmi_error) { stubbed_response('wmi_error_v2.xml') }
-
-    it 'raises a WinRMWMIError' do
-      handler = WinRM::ResponseHandler.new(wmi_error, 500)
-      begin
-        handler.parse_to_xml
-      rescue WinRM::WinRMWMIError => e
-        expect(e.error_code).to eq('2150859173')
-        expect(e.error).to include('The WS-Management service cannot process the request.')
-      end
-    end
-  end
-end
+require 'winrm/http/response_handler'
+
+describe 'response handler', unit: true do
+  %w[v1 v2 omi].each do |winrm_version|
+    context "winrm_version #{winrm_version}" do
+      let(:soap_fault) { stubbed_response("soap_fault_#{winrm_version}.xml") }
+      let(:open_shell) { stubbed_response("open_shell_#{winrm_version}.xml") }
+
+      describe "successful 200 #{winrm_version} response" do
+        it 'returns an xml doc' do
+          handler = WinRM::ResponseHandler.new(open_shell, 200)
+          xml_doc = handler.parse_to_xml
+          expect(xml_doc).to be_instance_of(REXML::Document)
+          expect(xml_doc.to_s).to eq(REXML::Document.new(open_shell).to_s)
+        end
+      end
+
+      describe "failed 500 #{winrm_version} response" do
+        it 'raises a WinRMHTTPTransportError' do
+          handler = WinRM::ResponseHandler.new('', 500)
+          expect { handler.parse_to_xml }.to raise_error(WinRM::WinRMHTTPTransportError)
+        end
+      end
+
+      describe "failed 401 #{winrm_version} response" do
+        it 'raises a WinRMAuthorizationError' do
+          handler = WinRM::ResponseHandler.new('', 401)
+          expect { handler.parse_to_xml }.to raise_error(WinRM::WinRMAuthorizationError)
+        end
+      end
+
+      describe "failed 400 #{winrm_version} response" do
+        it 'raises a WinRMWSManFault' do
+          handler = WinRM::ResponseHandler.new(soap_fault, 400)
+          begin
+            handler.parse_to_xml
+          # PowerShell
+          rescue WinRM::WinRMWSManFault => e
+            expect(e.fault_code).to eq('2150858778')
+            expect(e.fault_description).to include(
+              'The specified class does not exist in the given namespace'
+            )
+          # OMI
+          rescue WinRM::WinRMSoapFault => e
+            expect(e.code).to eq('SOAP-ENV:Receiver')
+            expect(e.subcode).to eq('wsman:InternalError')
+            expect(e.reason).to eq(
+              'get-instance: instance name parameter is missing'
+            )
+          end
+        end
+      end
+    end
+  end
+
+  describe 'failed 500 WMI error response' do
+    let(:wmi_error) { stubbed_response('wmi_error_v2.xml') }
+
+    it 'raises a WinRMWMIError' do
+      handler = WinRM::ResponseHandler.new(wmi_error, 500)
+      begin
+        handler.parse_to_xml
+      rescue WinRM::WinRMWMIError => e
+        expect(e.error_code).to eq('2150859173')
+        expect(e.error).to include('The WS-Management service cannot process the request.')
+      end
+    end
+  end
+end

data/tests/spec/shells/base_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/shells/base'
 
 # Dummy shell class
@@ -28,7 +26,7 @@ class DummyShell < WinRM::Shells::Base
   end
 
   def out_streams
-    %w(std)
+    %w[std]
   end
 end
 
@@ -47,7 +45,8 @@ describe DummyShell do
 
   before do
     allow(subject).to receive(:response_reader).and_return(reader)
-    allow(subject).to receive(:command_output_message).with(shell_id, command_id)
+    allow(subject).to receive(:command_output_message)
+      .with(shell_id, command_id)
       .and_return(output_message)
     allow(reader).to receive(:read_output).with(output_message).and_return(output)
     allow(transport).to receive(:send_request)
@@ -144,6 +143,7 @@ describe DummyShell do
         allow(subject).to receive(:send_command) do
           @times_called += 1
           raise WinRM::WinRMWSManFault.new('oops', fault) if @times_called == 1
+
           command_id
         end
       end
@@ -179,13 +179,15 @@ describe DummyShell do
 
       it 'retries and returns shell on success' do
         @times = 0
-        allow(subject).to receive(:command_output_message).with('shell_id 2', command_id)
+        allow(subject).to receive(:command_output_message)
+          .with('shell_id 2', command_id)
           .and_return(output_message2)
         allow(reader).to receive(:read_output)
           .with(output_message2).and_return(output)
         allow(subject).to receive(:open_shell) do
           @times += 1
           raise(Errno::ECONNREFUSED) if @times == 1
+
           "shell_id #{@times}"
         end
 

data/tests/spec/shells/cmd_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/shells/cmd'
 
 describe WinRM::Shells::Cmd do
@@ -24,9 +22,11 @@ describe WinRM::Shells::Cmd do
       .and_return(cleanup_payload)
     allow_any_instance_of(WinRM::WSMV::ReceiveResponseReader).to receive(:read_output)
       .and_return(output)
-    allow(transport).to receive(:send_request).with(create_shell_payload)
+    allow(transport).to receive(:send_request)
+      .with(create_shell_payload)
       .and_return(REXML::Document.new("<blah Name='ShellId'>#{shell_id}</blah>"))
-    allow(transport).to receive(:send_request).with(/#{command}/)
+    allow(transport).to receive(:send_request)
+      .with(/#{command}/)
       .and_return(REXML::Document.new(command_response))
   end