winrm 2.2.3 → 2.3.0

data/tests/spec/stubs/responses/get_omi_config_response.xml

@@ -0,0 +1,45 @@
+<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://www.w3.org/2003/05/soap-envelope"
+    xmlns:wsa="http://schemas.xmlsoap.org/ws/2004/08/addressing"
+    xmlns:wsen="http://schemas.xmlsoap.org/ws/2004/09/enumeration"
+    xmlns:e="http://schemas.xmlsoap.org/ws/2004/08/eventing"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xmlns:wsmb="http://schemas.dmtf.org/wbem/wsman/1/cimbinding.xsd"
+    xmlns:wsman="http://schemas.dmtf.org/wbem/wsman/1/wsman.xsd"
+    xmlns:wxf="http://schemas.xmlsoap.org/ws/2004/09/transfer"
+    xmlns:cim="http://schemas.dmtf.org/wbem/wscim/1/common"
+    xmlns:msftwinrm="http://schemas.microsoft.com/wbem/wsman/1/wsman.xsd"
+    xmlns:wsmid="http://schemas.dmtf.org/wbem/wsman/identity/1/wsmanidentity.xsd">
+    <SOAP-ENV:Header>
+        <wsa:To>
+                http://schemas.xmlsoap.org/ws/2004/08/addressing/role/anonymous
+        </wsa:To>
+        <wsa:Action>
+                http://schemas.dmtf.org/wbem/wsman/1/wsman/fault
+        </wsa:Action>
+        <wsa:MessageID>
+                uuid:5825BEA8-76AB-0005-0000-000001A80000
+        </wsa:MessageID>
+        <wsa:RelatesTo>
+                uuid:01022086-C0D6-45DA-85F2-21FA2B476FCA
+        </wsa:RelatesTo>
+    </SOAP-ENV:Header>
+    <SOAP-ENV:Body>
+        <SOAP-ENV:Fault>
+            <SOAP-ENV:Code>
+                <SOAP-ENV:Value>
+                        SOAP-ENV:Receiver
+                </SOAP-ENV:Value>
+                <SOAP-ENV:Subcode>
+                    <SOAP-ENV:Value>
+                            wsman:InternalError
+                    </SOAP-ENV:Value>
+                </SOAP-ENV:Subcode>
+            </SOAP-ENV:Code>
+            <SOAP-ENV:Reason>
+                <SOAP-ENV:Text xml:lang="en-US">
+                        get-instance: instance name parameter is missing
+                </SOAP-ENV:Text>
+            </SOAP-ENV:Reason>
+        </SOAP-ENV:Fault>
+    </SOAP-ENV:Body>
+</SOAP-ENV:Envelope>

data/tests/spec/stubs/responses/get_omi_powershell_keepalive_response.xml.erb

@@ -0,0 +1,33 @@
+<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://www.w3.org/2003/05/soap-envelope"
+    xmlns:wsa="http://schemas.xmlsoap.org/ws/2004/08/addressing"
+    xmlns:wsen="http://schemas.xmlsoap.org/ws/2004/09/enumeration"
+    xmlns:e="http://schemas.xmlsoap.org/ws/2004/08/eventing"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xmlns:wsmb="http://schemas.dmtf.org/wbem/wsman/1/cimbinding.xsd"
+    xmlns:wsman="http://schemas.dmtf.org/wbem/wsman/1/wsman.xsd"
+    xmlns:wxf="http://schemas.xmlsoap.org/ws/2004/09/transfer"
+    xmlns:cim="http://schemas.dmtf.org/wbem/wscim/1/common"
+    xmlns:msftwinrm="http://schemas.microsoft.com/wbem/wsman/1/wsman.xsd"
+    xmlns:wsmid="http://schemas.dmtf.org/wbem/wsman/identity/1/wsmanidentity.xsd">
+    <SOAP-ENV:Header>
+        <wsa:To>
+                http://schemas.xmlsoap.org/ws/2004/08/addressing/role/anonymous
+        </wsa:To>
+        <wsa:Action>
+                http://schemas.microsoft.com/wbem/wsman/1/windows/shell/ReceiveResponse
+        </wsa:Action>
+        <wsa:MessageID>
+                uuid:5825BEA8-76AB-0005-0000-000000510000
+        </wsa:MessageID>
+        <wsa:RelatesTo>
+                uuid:28C42606-83D7-4948-A06A-47B75E7575D3
+        </wsa:RelatesTo>
+    </SOAP-ENV:Header>
+    <SOAP-ENV:Body>
+        <p:ReceiveResponse xmlns:p="http://schemas.microsoft.com/wbem/wsman/1/windows/shell">
+            <p:Stream Name="stdout"><%= test_data_stdout2 %></p:Stream>
+            <p:CommandState State="http://schemas.microsoft.com/wbem/wsman/1/windows/shell/CommandState/Running">
+            </p:CommandState>
+        </p:ReceiveResponse>
+    </SOAP-ENV:Body>
+</SOAP-ENV:Envelope>

data/tests/spec/stubs/responses/open_shell_omi.xml

@@ -0,0 +1,43 @@
+<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://www.w3.org/2003/05/soap-envelope"
+    xmlns:wsa="http://schemas.xmlsoap.org/ws/2004/08/addressing"
+    xmlns:wsen="http://schemas.xmlsoap.org/ws/2004/09/enumeration"
+    xmlns:e="http://schemas.xmlsoap.org/ws/2004/08/eventing"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xmlns:wsmb="http://schemas.dmtf.org/wbem/wsman/1/cimbinding.xsd"
+    xmlns:wsman="http://schemas.dmtf.org/wbem/wsman/1/wsman.xsd"
+    xmlns:wxf="http://schemas.xmlsoap.org/ws/2004/09/transfer"
+    xmlns:cim="http://schemas.dmtf.org/wbem/wscim/1/common"
+    xmlns:msftwinrm="http://schemas.microsoft.com/wbem/wsman/1/wsman.xsd"
+    xmlns:wsmid="http://schemas.dmtf.org/wbem/wsman/identity/1/wsmanidentity.xsd">
+    <SOAP-ENV:Header>
+        <wsa:To>
+            http://schemas.xmlsoap.org/ws/2004/08/addressing/role/anonymous
+        </wsa:To>
+        <wsa:Action>
+            http://schemas.xmlsoap.org/ws/2004/09/transfer/CreateResponse
+        </wsa:Action>
+        <wsa:MessageID>
+            uuid:5825BEA8-76AB-0005-0000-000001A90000
+        </wsa:MessageID>
+        <wsa:RelatesTo>
+            uuid:C872AD16-50F1-4CD3-908B-35AED7E485B7
+        </wsa:RelatesTo>
+    </SOAP-ENV:Header>
+    <SOAP-ENV:Body>
+        <wxf:ResourceCreated>
+            <wsa:Address>
+                http://schemas.xmlsoap.org/ws/2004/08/addressing/role/anonymous
+            </wsa:Address>
+            <wsa:ReferenceParameters>
+                <wsman:ResourceURI>
+                    http://schemas.microsoft.com/powershell/Microsoft.PowerShell
+                </wsman:ResourceURI>
+                <wsman:SelectorSet>
+                    <wsman:Selector Name="ShellId">
+                        74142DC5-E14D-4FCC-86ED-63DA3EE8407E
+                    </wsman:Selector>
+                </wsman:SelectorSet>
+            </wsa:ReferenceParameters>
+        </wxf:ResourceCreated>
+    </SOAP-ENV:Body>
+</SOAP-ENV:Envelope>

data/tests/spec/stubs/responses/soap_fault_omi.xml

@@ -0,0 +1,31 @@
+<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://www.w3.org/2003/05/soap-envelope"
+    xmlns:wsa="http://schemas.xmlsoap.org/ws/2004/08/addressing"
+    xmlns:wsen="http://schemas.xmlsoap.org/ws/2004/09/enumeration"
+    xmlns:e="http://schemas.xmlsoap.org/ws/2004/08/eventing"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xmlns:wsmb="http://schemas.dmtf.org/wbem/wsman/1/cimbinding.xsd"
+    xmlns:wsman="http://schemas.dmtf.org/wbem/wsman/1/wsman.xsd"
+    xmlns:wxf="http://schemas.xmlsoap.org/ws/2004/09/transfer"
+    xmlns:cim="http://schemas.dmtf.org/wbem/wscim/1/common"
+    xmlns:msftwinrm="http://schemas.microsoft.com/wbem/wsman/1/wsman.xsd"
+    xmlns:wsmid="http://schemas.dmtf.org/wbem/wsman/identity/1/wsmanidentity.xsd">
+    <SOAP-ENV:Header>
+        <wsa:To>http://schemas.xmlsoap.org/ws/2004/08/addressing/role/anonymous</wsa:To>
+        <wsa:Action>http://schemas.dmtf.org/wbem/wsman/1/wsman/fault</wsa:Action>
+        <wsa:MessageID>uuid:F803101F-76B9-0005-0000-000000010000</wsa:MessageID>
+        <wsa:RelatesTo>uuid:AC61AF91-4AA9-428E-9294-670B4C5752A8</wsa:RelatesTo>
+    </SOAP-ENV:Header>
+    <SOAP-ENV:Body>
+        <SOAP-ENV:Fault>
+            <SOAP-ENV:Code>
+                <SOAP-ENV:Value>SOAP-ENV:Receiver</SOAP-ENV:Value>
+                <SOAP-ENV:Subcode>
+                    <SOAP-ENV:Value>wsman:InternalError</SOAP-ENV:Value>
+                </SOAP-ENV:Subcode>
+            </SOAP-ENV:Code>
+            <SOAP-ENV:Reason>
+                <SOAP-ENV:Text xml:lang="en-US">get-instance: instance name parameter is missing</SOAP-ENV:Text>
+            </SOAP-ENV:Reason>
+        </SOAP-ENV:Fault>
+    </SOAP-ENV:Body>
+</SOAP-ENV:Envelope>

data/tests/spec/wsmv/cleanup_command_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/wsmv/cleanup_command'
 
 describe WinRM::WSMV::CleanupCommand do

data/tests/spec/wsmv/close_shell_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/wsmv/close_shell'
 
 describe WinRM::WSMV::CloseShell do

data/tests/spec/wsmv/command_output_decoder_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/wsmv/command_output_decoder'
 
 describe WinRM::WSMV::CommandOutputDecoder do

data/tests/spec/wsmv/command_output_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/wsmv/command_output'
 require 'winrm/wsmv/header'
 
@@ -28,7 +26,7 @@ describe WinRM::WSMV::CommandOutput do
         shell_id: 'F4A2622B-B842-4EB8-8A78-0225C8A993DF',
         command_id: 'A2A2622B-B842-4EB8-8A78-0225C8A993DF',
         shell_uri: WinRM::WSMV::Header::RESOURCE_URI_POWERSHELL,
-        out_streams: %w(stdout)
+        out_streams: %w[stdout]
       }
     end
     subject { described_class.new(default_connection_opts, cmd_out_opts) }

data/tests/spec/wsmv/command_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/wsmv/command'
 
 describe WinRM::WSMV::Command do

data/tests/spec/wsmv/configuration_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/wsmv/configuration'
 
 describe WinRM::WSMV::Configuration do

data/tests/spec/wsmv/create_pipeline_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/wsmv/create_pipeline'
 
 describe WinRM::WSMV::CreatePipeline do
@@ -22,7 +20,8 @@ describe WinRM::WSMV::CreatePipeline do
       expect(xml).to include('<w:OperationTimeout>PT60S</w:OperationTimeout>')
       expect(xml).to include(
         '<w:SelectorSet><w:Selector Name="ShellId">' \
-        "#{shell_id}</w:Selector></w:SelectorSet>")
+        "#{shell_id}</w:Selector></w:SelectorSet>"
+      )
       expect(xml).to include("<rsp:CommandLine CommandId=\"#{command_id}\">")
       expect(xml).to include('<rsp:Command>Invoke-Expression</rsp:Command>')
       expect(xml).to include("<rsp:Arguments>#{pipeline}</rsp:Arguments>")

data/tests/spec/wsmv/create_shell_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/wsmv/create_shell'
 
 describe WinRM::WSMV::CreateShell do
@@ -12,14 +10,16 @@ describe WinRM::WSMV::CreateShell do
       expect(xml).to include('<p:DataLocale xml:lang="en-US" mustUnderstand="false"/>')
       expect(xml).to include(
         '<p:SessionId mustUnderstand="false">' \
-        'uuid:05A2622B-B842-4EB8-8A78-0225C8A993DF</p:SessionId>')
+        'uuid:05A2622B-B842-4EB8-8A78-0225C8A993DF</p:SessionId>'
+      )
       expect(xml).to include('<w:MaxEnvelopeSize mustUnderstand="true">153600</w:MaxEnvelopeSize>')
       expect(xml).to include('<a:To>http://localhost:5985/wsman</a:To>')
       expect(xml).to include('<rsp:InputStreams>stdin</rsp:InputStreams>')
       expect(xml).to include('<rsp:OutputStreams>stdout stderr</rsp:OutputStreams>')
       expect(xml).to include(
         '<w:ResourceURI mustUnderstand="true">' \
-        'http://schemas.microsoft.com/wbem/wsman/1/windows/shell/cmd</w:ResourceURI>')
+        'http://schemas.microsoft.com/wbem/wsman/1/windows/shell/cmd</w:ResourceURI>'
+      )
     end
     context 'shell options w/env vars' do
       let(:shell_opts) do
@@ -31,7 +31,8 @@ describe WinRM::WSMV::CreateShell do
       let(:xml) { subject.build }
       it 'includes environemt vars' do
         expect(xml).to include(
-          '<rsp:Environment><rsp:Variable Name="FOO">BAR</rsp:Variable></rsp:Environment>')
+          '<rsp:Environment><rsp:Variable Name="FOO">BAR</rsp:Variable></rsp:Environment>'
+        )
       end
     end
   end

data/tests/spec/wsmv/init_runspace_pool_spec.rb

@@ -1,36 +1,38 @@
-# encoding: UTF-8
-
-require 'winrm/wsmv/init_runspace_pool'
-
-describe WinRM::WSMV::InitRunspacePool do
-  context 'default session options' do
-    let(:shell_id) { SecureRandom.uuid.to_s.upcase }
-    let(:payload) { 'blah'.bytes }
-
-    subject { described_class.new(default_connection_opts, shell_id, payload) }
-
-    it 'creates a well formed message' do
-      xml = subject.build
-      expect(xml).to include('<w:OperationTimeout>PT60S</w:OperationTimeout>')
-      expect(xml).to include('<w:Locale xml:lang="en-US" mustUnderstand="false"/>')
-      expect(xml).to include('<p:DataLocale xml:lang="en-US" mustUnderstand="false"/>')
-      expect(xml).to include(
-        '<p:SessionId mustUnderstand="false">' \
-        'uuid:05A2622B-B842-4EB8-8A78-0225C8A993DF</p:SessionId>')
-      expect(xml).to include('<w:MaxEnvelopeSize mustUnderstand="true">153600</w:MaxEnvelopeSize>')
-      expect(xml).to include('<a:To>http://localhost:5985/wsman</a:To>')
-      expect(xml).to include(
-        '<w:OptionSet env:mustUnderstand="true">' \
-        '<w:Option Name="protocolversion" MustComply="true">2.3</w:Option></w:OptionSet>')
-      expect(xml).to include('<rsp:InputStreams>stdin pr</rsp:InputStreams>')
-      expect(xml).to include('<rsp:OutputStreams>stdout</rsp:OutputStreams>')
-      expect(xml).to include("<rsp:Shell ShellId=\"#{subject.shell_id}\">")
-      expect(xml).to include(
-        '<w:ResourceURI mustUnderstand="true">' \
-        'http://schemas.microsoft.com/powershell/Microsoft.PowerShell')
-      expect(xml).to include(
-        '<creationXml xmlns="http://schemas.microsoft.com/powershell">' \
-        "#{Base64.strict_encode64(payload.pack('C*'))}</creationXml>")
-    end
-  end
-end
+require 'winrm/wsmv/init_runspace_pool'
+
+describe WinRM::WSMV::InitRunspacePool do
+  context 'default session options' do
+    let(:shell_id) { SecureRandom.uuid.to_s.upcase }
+    let(:payload) { 'blah'.bytes }
+
+    subject { described_class.new(default_connection_opts, shell_id, payload) }
+
+    it 'creates a well formed message' do
+      xml = subject.build
+      expect(xml).to include('<w:OperationTimeout>PT60S</w:OperationTimeout>')
+      expect(xml).to include('<w:Locale xml:lang="en-US" mustUnderstand="false"/>')
+      expect(xml).to include('<p:DataLocale xml:lang="en-US" mustUnderstand="false"/>')
+      expect(xml).to include(
+        '<p:SessionId mustUnderstand="false">' \
+        'uuid:05A2622B-B842-4EB8-8A78-0225C8A993DF</p:SessionId>'
+      )
+      expect(xml).to include('<w:MaxEnvelopeSize mustUnderstand="true">153600</w:MaxEnvelopeSize>')
+      expect(xml).to include('<a:To>http://localhost:5985/wsman</a:To>')
+      expect(xml).to include(
+        '<w:OptionSet env:mustUnderstand="true">' \
+        '<w:Option Name="protocolversion" MustComply="true">2.3</w:Option></w:OptionSet>'
+      )
+      expect(xml).to include('<rsp:InputStreams>stdin pr</rsp:InputStreams>')
+      expect(xml).to include('<rsp:OutputStreams>stdout</rsp:OutputStreams>')
+      expect(xml).to include("<rsp:Shell ShellId=\"#{subject.shell_id}\" Name=\"Runspace\">")
+      expect(xml).to include(
+        '<w:ResourceURI mustUnderstand="true">' \
+        'http://schemas.microsoft.com/powershell/Microsoft.PowerShell'
+      )
+      expect(xml).to include(
+        '<creationXml xmlns="http://schemas.microsoft.com/powershell">' \
+        "#{Base64.strict_encode64(payload.pack('C*'))}</creationXml>"
+      )
+    end
+  end
+end

data/tests/spec/wsmv/keep_alive_spec.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8
-
 require 'winrm/wsmv/keep_alive'
 
 describe WinRM::WSMV::KeepAlive do
@@ -11,10 +9,12 @@ describe WinRM::WSMV::KeepAlive do
       expect(xml).to include('<w:OperationTimeout>PT60S</w:OperationTimeout>')
       expect(xml).to include(
         '<w:OptionSet><w:Option Name="WSMAN_CMDSHELL_OPTION_KEEPALIVE">' \
-        'TRUE</w:Option></w:OptionSet>')
+        'TRUE</w:Option></w:OptionSet>'
+      )
       expect(xml).to include(
         '<w:SelectorSet><w:Selector Name="ShellId">' \
-        "#{shell_id}</w:Selector></w:SelectorSet>")
+        "#{shell_id}</w:Selector></w:SelectorSet>"
+      )
       expect(xml).to include('<rsp:DesiredStream>stdout</rsp:DesiredStream>')
     end
   end

data/tests/spec/wsmv/receive_response_reader_spec.rb

@@ -1,123 +1,124 @@
-# encoding: UTF-8
-
-require 'winrm/wsmv/receive_response_reader'
-
-describe WinRM::WSMV::ReceiveResponseReader do
-  let(:shell_id) { 'F4A2622B-B842-4EB8-8A78-0225C8A993DF' }
-  let(:command_id) { 'A2A2622B-B842-4EB8-8A78-0225C8A993DF' }
-  let(:output_message) { double('output_message', build: 'output_message') }
-  let(:test_data_xml_template) do
-    ERB.new(stubbed_response('get_command_output_response.xml.erb'))
-  end
-  let(:test_data_xml_template_not_done) do
-    ERB.new(stubbed_response('get_command_output_response_not_done.xml.erb'))
-  end
-  let(:transport) do
-    {}
-  end
-
-  subject do
-    described_class.new(
-      transport,
-      Logging.logger['test']
-    )
-  end
-
-  describe '#read_output' do
-    context 'response doc stdout with invalid UTF-8 characters, issue 184' do
-      let(:test_data_stdout) { 'ffff' } # Base64-decodes to '}\xF7\xDF', an invalid sequence
-      let(:test_data_stderr) { '' }
-      let(:test_data_xml)    { test_data_xml_template.result(binding) }
-
-      before do
-        allow(transport).to receive(:send_request).and_return(
-          REXML::Document.new(test_data_xml)
-        )
-      end
-
-      it 'does not raise an ArgumentError: invalid byte sequence in UTF-8' do
-        begin
-          expect(
-            subject.read_output(output_message)
-          ).not_to raise_error
-        rescue RSpec::Expectations::ExpectationNotMetError => e
-          expect(e.message).not_to include 'ArgumentError'
-        end
-      end
-
-      it 'does not have an empty stdout' do
-        expect(
-          subject.read_output(output_message).stdout
-        ).not_to be_empty
-      end
-    end
-
-    context 'response doc stdout with valid UTF-8' do
-      let(:test_data_raw)    { '✓1234-äöü' }
-      let(:test_data_stdout) { Base64.encode64(test_data_raw) }
-      let(:test_data_stderr) { '' }
-      let(:test_data_xml)    { test_data_xml_template.result(binding) }
-
-      before do
-        allow(transport).to receive(:send_request).and_return(
-          REXML::Document.new(test_data_xml)
-        )
-      end
-
-      it 'decodes to match input data' do
-        expect(
-          subject.read_output(output_message).stdout
-        ).to eq(test_data_raw)
-      end
-    end
-  end
-
-  describe '#read_response' do
-    context 'do not wait for done state' do
-      let(:test_data_raw) { 'output text' }
-      let(:test_error_raw) { 'error text' }
-      let(:test_data_stdout) { Base64.encode64(test_data_raw) }
-      let(:test_data_stderr) { Base64.encode64(test_error_raw) }
-      let(:test_data_xml)    { test_data_xml_template.result(binding) }
-
-      before do
-        allow(transport).to receive(:send_request).and_return(
-          REXML::Document.new(test_data_xml)
-        ).once
-      end
-
-      it 'yields stream and document' do
-        subject.read_response(output_message) do |stream, doc|
-          expect(stream[:text]).to eq(test_data_stdout) if stream[:type] == :stdout
-          expect(stream[:text]).to eq(test_data_stderr) if stream[:type] == :stderr
-          expect(doc.to_s).to eq(REXML::Document.new(test_data_xml).to_s)
-        end
-      end
-    end
-
-    context 'wait for done state' do
-      let(:test_data_raw) { 'output text' }
-      let(:test_error_raw) { 'error text' }
-      let(:test_data_stdout) { Base64.encode64(test_data_raw) }
-      let(:test_data_stderr) { Base64.encode64(test_error_raw) }
-      let(:test_data_xml_not_done) { test_data_xml_template_not_done.result(binding) }
-      let(:test_data_xml_done) { test_data_xml_template.result(binding) }
-
-      it 'yields streams and both documents' do
-        allow(transport).to receive(:send_request).and_return(
-          REXML::Document.new(test_data_xml_not_done),
-          REXML::Document.new(test_data_xml_done)
-        )
-        times = 1
-
-        subject.read_response(output_message, true) do |stream, doc|
-          expect(stream[:text]).to eq(test_data_stdout) if stream[:type] == :stdout
-          expect(stream[:text]).to eq(test_data_stderr) if stream[:type] == :stderr
-          expect(doc.to_s).to eq(REXML::Document.new(test_data_xml_not_done).to_s) if times == 1
-          expect(doc.to_s).to eq(REXML::Document.new(test_data_xml_done).to_s) if times > 2
-          times += 1
-        end
-      end
-    end
-  end
-end
+require 'winrm/wsmv/receive_response_reader'
+
+describe WinRM::WSMV::ReceiveResponseReader do
+  let(:shell_id) { 'F4A2622B-B842-4EB8-8A78-0225C8A993DF' }
+  let(:command_id) { 'A2A2622B-B842-4EB8-8A78-0225C8A993DF' }
+  let(:output_message) { double('output_message', build: 'output_message') }
+  let(:transport) do
+    {}
+  end
+
+  subject do
+    described_class.new(
+      transport,
+      Logging.logger['test']
+    )
+  end
+
+  # Output from PowerShell endpoint and output from OMI Server endpoint
+  {
+    'get_command_output_response.xml.erb' => 'get_command_output_response_not_done.xml.erb',
+    'get_omi_command_output_response.xml.erb' => 'get_omi_command_output_response_not_done.xml.erb'
+  }.each_pair do |template, template_not_done|
+    describe "#read_output for #{template}" do
+      context 'response doc stdout with invalid UTF-8 characters, issue 184' do
+        let(:test_data_stdout) { 'ffff' } # Base64-decodes to '}\xF7\xDF', an invalid sequence
+        let(:test_data_stderr) { '' }
+        let(:test_data_xml)    { ERB.new(stubbed_response(template)).result(binding) }
+        let(:test_data)        { REXML::Document.new(test_data_xml) }
+        let(:stdout_xpath)     { "//*[local-name() = 'Stream' and @Name = 'stdout']" }
+
+        before do
+          allow(transport).to receive(:send_request).and_return(test_data)
+        end
+
+        # OMI server messages do not appear to include stdout when CommandState/Done
+        it 'does not raise an ArgumentError: invalid byte sequence in UTF-8' do
+          begin
+            expect(
+              subject.read_output(output_message)
+            ).not_to raise_error
+          rescue RSpec::Expectations::ExpectationNotMetError => e
+            expect(e.message).not_to include 'ArgumentError'
+          end
+        end
+
+        it 'does not have an empty stdout' do
+          skip('response has no stdout') if REXML::XPath.match(test_data, stdout_xpath).empty?
+          expect(
+            subject.read_output(output_message).stdout
+          ).not_to be_empty
+        end
+      end
+
+      context 'response doc stdout with valid UTF-8' do
+        let(:test_data_raw)    { '✓1234-äöü' }
+        let(:test_data_stdout) { Base64.encode64(test_data_raw) }
+        let(:test_data_stderr) { '' }
+        let(:test_data_xml)    { ERB.new(stubbed_response(template)).result(binding) }
+        let(:test_data)        { REXML::Document.new(test_data_xml) }
+        let(:stdout_xpath)     { "//*[local-name() = 'Stream' and @Name = 'stdout']" }
+
+        before do
+          allow(transport).to receive(:send_request).and_return(test_data)
+        end
+
+        it 'decodes to match input data' do
+          skip('response has no stdout') if REXML::XPath.match(test_data, stdout_xpath).empty?
+          expect(
+            subject.read_output(output_message).stdout
+          ).to eq(test_data_raw)
+        end
+      end
+    end
+
+    describe "#read_response for #{template}" do
+      context 'do not wait for done state' do
+        let(:test_data_raw) { 'output text' }
+        let(:test_error_raw) { 'error text' }
+        let(:test_data_stdout) { Base64.encode64(test_data_raw) }
+        let(:test_data_stderr) { Base64.encode64(test_error_raw) }
+        let(:test_data_xml)    { ERB.new(stubbed_response(template)).result(binding) }
+
+        before do
+          allow(transport).to receive(:send_request).and_return(
+            REXML::Document.new(test_data_xml)
+          ).once
+        end
+
+        it 'yields stream and document' do
+          subject.read_response(output_message) do |stream, doc|
+            expect(stream[:text]).to eq(test_data_stdout) if stream[:type] == :stdout
+            expect(stream[:text]).to eq(test_data_stderr) if stream[:type] == :stderr
+            expect(doc.to_s).to eq(REXML::Document.new(test_data_xml).to_s)
+          end
+        end
+      end
+
+      context 'wait for done state' do
+        let(:test_data_raw) { 'output text' }
+        let(:test_error_raw) { 'error text' }
+        let(:test_data_stdout) { Base64.encode64(test_data_raw) }
+        let(:test_data_stderr) { Base64.encode64(test_error_raw) }
+        let(:test_data_xml_notdone) { ERB.new(stubbed_response(template_not_done)).result(binding) }
+        let(:test_data_xml_done) { ERB.new(stubbed_response(template)).result(binding) }
+
+        it 'yields streams and both documents' do
+          allow(transport).to receive(:send_request).and_return(
+            REXML::Document.new(test_data_xml_notdone),
+            REXML::Document.new(test_data_xml_done)
+          )
+          times = 1
+
+          subject.read_response(output_message, true) do |stream, doc|
+            expect(stream[:text]).to eq(test_data_stdout) if stream[:type] == :stdout
+            expect(stream[:text]).to eq(test_data_stderr) if stream[:type] == :stderr
+            expect(doc.to_s).to eq(REXML::Document.new(test_data_xml_notdone).to_s) if times == 1
+            expect(doc.to_s).to eq(REXML::Document.new(test_data_xml_done).to_s) if times > 2
+            times += 1
+          end
+        end
+      end
+    end
+  end
+end