winrm 2.1.0 → 2.1.1

data/tests/spec/psrp/uuid_spec.rb

@@ -1,28 +1,28 @@
-# encoding: UTF-8
-describe WinRM::PSRP::UUID do
-  subject(:uuid_helper) do
-    Object.new.extend(WinRM::PSRP::UUID)
-  end
-  context 'uuid is nil' do
-    uuid = nil
-    it 'should return an empty byte array' do
-      bytes = uuid_helper.uuid_to_windows_guid_bytes(uuid)
-      expect(bytes).to eq([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0])
-    end
-  end
-  context 'uuid 08785e96-eb1b-4a74-a767-7b56e8f13ea9 with lower case letters' do
-    uuid = '08785e96-eb1b-4a74-a767-7b56e8f13ea9'
-    it 'should return a Windows GUID struct compatible little endian byte array' do
-      bytes = uuid_helper.uuid_to_windows_guid_bytes(uuid)
-      expect(bytes).to eq([150, 94, 120, 8, 27, 235, 116, 74, 167, 103, 123, 86, 232, 241, 62, 169])
-    end
-  end
-  context 'uuid 045F9E19D-8B77-4394-AB0C-197497661668 with upper case letters' do
-    uuid = '45F9E19D-8B77-4394-AB0C-197497661668'
-    it 'should return a Windows GUID struct compatible little endian byte array' do
-      bytes = uuid_helper.uuid_to_windows_guid_bytes(uuid)
-      expect(bytes).to eq(
-        [157, 225, 249, 69, 119, 139, 148, 67, 171, 12, 25, 116, 151, 102, 22, 104])
-    end
-  end
-end
+# encoding: UTF-8
+describe WinRM::PSRP::UUID do
+  subject(:uuid_helper) do
+    Object.new.extend(WinRM::PSRP::UUID)
+  end
+  context 'uuid is nil' do
+    uuid = nil
+    it 'should return an empty byte array' do
+      bytes = uuid_helper.uuid_to_windows_guid_bytes(uuid)
+      expect(bytes).to eq([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0])
+    end
+  end
+  context 'uuid 08785e96-eb1b-4a74-a767-7b56e8f13ea9 with lower case letters' do
+    uuid = '08785e96-eb1b-4a74-a767-7b56e8f13ea9'
+    it 'should return a Windows GUID struct compatible little endian byte array' do
+      bytes = uuid_helper.uuid_to_windows_guid_bytes(uuid)
+      expect(bytes).to eq([150, 94, 120, 8, 27, 235, 116, 74, 167, 103, 123, 86, 232, 241, 62, 169])
+    end
+  end
+  context 'uuid 045F9E19D-8B77-4394-AB0C-197497661668 with upper case letters' do
+    uuid = '45F9E19D-8B77-4394-AB0C-197497661668'
+    it 'should return a Windows GUID struct compatible little endian byte array' do
+      bytes = uuid_helper.uuid_to_windows_guid_bytes(uuid)
+      expect(bytes).to eq(
+        [157, 225, 249, 69, 119, 139, 148, 67, 171, 12, 25, 116, 151, 102, 22, 104])
+    end
+  end
+end

data/tests/spec/response_handler_spec.rb

@@ -1,61 +1,61 @@
-# encoding: UTF-8
-require 'winrm/http/response_handler'
-
-describe 'response handler', unit: true do
-  %w(v1 v2).each do |winrm_version|
-    context "winrm_version #{winrm_version}" do
-      let(:soap_fault) { stubbed_response("soap_fault_#{winrm_version}.xml") }
-      let(:open_shell) { stubbed_response("open_shell_#{winrm_version}.xml") }
-
-      describe "successful 200 #{winrm_version} response" do
-        it 'returns an xml doc' do
-          handler = WinRM::ResponseHandler.new(open_shell, 200)
-          xml_doc = handler.parse_to_xml
-          expect(xml_doc).to be_instance_of(REXML::Document)
-          expect(xml_doc.to_s).to eq(REXML::Document.new(open_shell).to_s)
-        end
-      end
-
-      describe "failed 500 #{winrm_version} response" do
-        it 'raises a WinRMHTTPTransportError' do
-          handler = WinRM::ResponseHandler.new('', 500)
-          expect { handler.parse_to_xml }.to raise_error(WinRM::WinRMHTTPTransportError)
-        end
-      end
-
-      describe "failed 401 #{winrm_version} response" do
-        it 'raises a WinRMAuthorizationError' do
-          handler = WinRM::ResponseHandler.new('', 401)
-          expect { handler.parse_to_xml }.to raise_error(WinRM::WinRMAuthorizationError)
-        end
-      end
-
-      describe "failed 400 #{winrm_version} response" do
-        it 'raises a WinRMWSManFault' do
-          handler = WinRM::ResponseHandler.new(soap_fault, 400)
-          begin
-            handler.parse_to_xml
-          rescue WinRM::WinRMWSManFault => e
-            expect(e.fault_code).to eq('2150858778')
-            expect(e.fault_description).to include(
-              'The specified class does not exist in the given namespace')
-          end
-        end
-      end
-    end
-  end
-
-  describe 'failed 500 WMI error response' do
-    let(:wmi_error) { stubbed_response('wmi_error_v2.xml') }
-
-    it 'raises a WinRMWMIError' do
-      handler = WinRM::ResponseHandler.new(wmi_error, 500)
-      begin
-        handler.parse_to_xml
-      rescue WinRM::WinRMWMIError => e
-        expect(e.error_code).to eq('2150859173')
-        expect(e.error).to include('The WS-Management service cannot process the request.')
-      end
-    end
-  end
-end
+# encoding: UTF-8
+require 'winrm/http/response_handler'
+
+describe 'response handler', unit: true do
+  %w(v1 v2).each do |winrm_version|
+    context "winrm_version #{winrm_version}" do
+      let(:soap_fault) { stubbed_response("soap_fault_#{winrm_version}.xml") }
+      let(:open_shell) { stubbed_response("open_shell_#{winrm_version}.xml") }
+
+      describe "successful 200 #{winrm_version} response" do
+        it 'returns an xml doc' do
+          handler = WinRM::ResponseHandler.new(open_shell, 200)
+          xml_doc = handler.parse_to_xml
+          expect(xml_doc).to be_instance_of(REXML::Document)
+          expect(xml_doc.to_s).to eq(REXML::Document.new(open_shell).to_s)
+        end
+      end
+
+      describe "failed 500 #{winrm_version} response" do
+        it 'raises a WinRMHTTPTransportError' do
+          handler = WinRM::ResponseHandler.new('', 500)
+          expect { handler.parse_to_xml }.to raise_error(WinRM::WinRMHTTPTransportError)
+        end
+      end
+
+      describe "failed 401 #{winrm_version} response" do
+        it 'raises a WinRMAuthorizationError' do
+          handler = WinRM::ResponseHandler.new('', 401)
+          expect { handler.parse_to_xml }.to raise_error(WinRM::WinRMAuthorizationError)
+        end
+      end
+
+      describe "failed 400 #{winrm_version} response" do
+        it 'raises a WinRMWSManFault' do
+          handler = WinRM::ResponseHandler.new(soap_fault, 400)
+          begin
+            handler.parse_to_xml
+          rescue WinRM::WinRMWSManFault => e
+            expect(e.fault_code).to eq('2150858778')
+            expect(e.fault_description).to include(
+              'The specified class does not exist in the given namespace')
+          end
+        end
+      end
+    end
+  end
+
+  describe 'failed 500 WMI error response' do
+    let(:wmi_error) { stubbed_response('wmi_error_v2.xml') }
+
+    it 'raises a WinRMWMIError' do
+      handler = WinRM::ResponseHandler.new(wmi_error, 500)
+      begin
+        handler.parse_to_xml
+      rescue WinRM::WinRMWMIError => e
+        expect(e.error_code).to eq('2150859173')
+        expect(e.error).to include('The WS-Management service cannot process the request.')
+      end
+    end
+  end
+end

data/tests/spec/shells/base_spec.rb

@@ -1,202 +1,202 @@
-# encoding: UTF-8
-
-require 'winrm/shells/base'
-
-# Dummy shell class
-class DummyShell < WinRM::Shells::Base
-  class << self
-    def finalize(connection_opts, transport, shell_id)
-      proc { DummyShell.close_shell(connection_opts, transport, shell_id) }
-    end
-
-    def close_shell(_connection_opts, _transport, _shell_id)
-      @closed = true
-    end
-
-    def closed?
-      @closed
-    end
-  end
-
-  def open_shell
-    @closed = false
-    'shell_id'
-  end
-
-  def send_command(_command, _arguments)
-    'command_id'
-  end
-
-  def out_streams
-    %w(std)
-  end
-end
-
-describe DummyShell do
-  let(:retry_limit) { 1 }
-  let(:shell_id) { 'shell_id' }
-  let(:output) { 'output' }
-  let(:command_id) { 'command_id' }
-  let(:payload) { 'message_payload' }
-  let(:command) { 'command' }
-  let(:arguments) { ['args'] }
-  let(:output_message) { double('output_message', build: 'output_message') }
-  let(:connection_options) { { max_commands: 100, retry_limit: retry_limit, retry_delay: 0 } }
-  let(:transport) { double('transport') }
-  let(:reader) { double('reader') }
-
-  before do
-    allow(subject).to receive(:response_reader).and_return(reader)
-    allow(subject).to receive(:command_output_message).with(shell_id, command_id)
-      .and_return(output_message)
-    allow(reader).to receive(:read_output).with(output_message).and_return(output)
-    allow(transport).to receive(:send_request)
-  end
-
-  subject { described_class.new(connection_options, transport, Logging.logger['test']) }
-
-  shared_examples 'retry shell command' do
-    it 'only closes the shell if there are too many' do
-      if fault == WinRM::Shells::Base::TOO_MANY_COMMANDS
-        expect(DummyShell).to receive(:close_shell)
-      else
-        expect(DummyShell).not_to receive(:close_shell)
-      end
-
-      subject.run(command, arguments)
-    end
-
-    it 'opens a new shell' do
-      expect(subject).to receive(:open).and_call_original.twice
-
-      subject.run(command, arguments)
-    end
-
-    it 'retries the command once' do
-      expect(subject).to receive(:send_command).twice
-
-      subject.run(command, arguments)
-    end
-  end
-
-  describe '#run' do
-    it 'opens a shell' do
-      subject.run(command, arguments)
-      expect(subject.shell_id).not_to be nil
-    end
-
-    it 'returns output from generated command' do
-      expect(subject.run(command, arguments)).to eq output
-    end
-
-    it 'sends cleanup message through transport' do
-      allow(SecureRandom).to receive(:uuid).and_return('uuid')
-      expect(transport).to receive(:send_request)
-        .with(
-          WinRM::WSMV::CleanupCommand.new(
-            connection_options,
-            shell_uri: nil,
-            shell_id: shell_id,
-            command_id: command_id
-          ).build
-        )
-      subject.run(command, arguments)
-    end
-
-    it 'does not error if cleanup is aborted' do
-      allow(SecureRandom).to receive(:uuid).and_return('uuid')
-      expect(transport).to receive(:send_request)
-        .with(
-          WinRM::WSMV::CleanupCommand.new(
-            connection_options,
-            shell_uri: nil,
-            shell_id: shell_id,
-            command_id: command_id
-          ).build
-        ).and_raise(WinRM::WinRMWSManFault.new('oops', '995'))
-      subject.run(command, arguments)
-    end
-
-    it 'opens a shell only once when shell is already open' do
-      expect(subject).to receive(:open_shell).and_call_original.once
-      subject.run(command, arguments)
-      subject.run(command, arguments)
-    end
-
-    describe 'connection resets' do
-      before do
-        @times_called = 0
-
-        allow(subject).to receive(:send_command) do
-          @times_called += 1
-          raise WinRM::WinRMWSManFault.new('oops', fault) if @times_called == 1
-          command_id
-        end
-      end
-
-      context 'when shell is closed on server' do
-        let(:fault) { '2150858843' }
-
-        include_examples 'retry shell command'
-      end
-
-      context 'when shell accesses a deleted registry key' do
-        let(:fault) { '2147943418' }
-
-        include_examples 'retry shell command'
-      end
-
-      context 'when maximum number of concurrent shells is exceeded' do
-        let(:fault) { '2150859174' }
-
-        include_examples 'retry shell command'
-      end
-    end
-
-    context 'open_shell fails' do
-      let(:retry_limit) { 2 }
-      let(:output_message2) { double('message') }
-
-      it 'retries and raises failure if it never succeeds' do
-        expect(subject).to receive(:open_shell)
-          .and_raise(Errno::ECONNREFUSED).exactly(retry_limit).times
-        expect { subject.run(command) }.to raise_error(Errno::ECONNREFUSED)
-      end
-
-      it 'retries and returns shell on success' do
-        @times = 0
-        allow(subject).to receive(:command_output_message).with('shell_id 2', command_id)
-          .and_return(output_message2)
-        allow(reader).to receive(:read_output)
-          .with(output_message2).and_return(output)
-        allow(subject).to receive(:open_shell) do
-          @times += 1
-          raise(Errno::ECONNREFUSED) if @times == 1
-          "shell_id #{@times}"
-        end
-
-        subject.run(command, arguments)
-        expect(subject.shell_id).to eq 'shell_id 2'
-      end
-    end
-  end
-
-  describe '#close' do
-    it 'does not close if not opened' do
-      expect(DummyShell).not_to receive(:close_shell)
-      subject.close
-    end
-
-    it 'close shell if opened' do
-      subject.run(command, arguments)
-      subject.close
-      expect(DummyShell.closed?).to be(true)
-    end
-
-    it 'nils out the shell_id' do
-      subject.run(command, arguments)
-      subject.close
-      expect(subject.shell_id).to be(nil)
-    end
-  end
-end
+# encoding: UTF-8
+
+require 'winrm/shells/base'
+
+# Dummy shell class
+class DummyShell < WinRM::Shells::Base
+  class << self
+    def finalize(connection_opts, transport, shell_id)
+      proc { DummyShell.close_shell(connection_opts, transport, shell_id) }
+    end
+
+    def close_shell(_connection_opts, _transport, _shell_id)
+      @closed = true
+    end
+
+    def closed?
+      @closed
+    end
+  end
+
+  def open_shell
+    @closed = false
+    'shell_id'
+  end
+
+  def send_command(_command, _arguments)
+    'command_id'
+  end
+
+  def out_streams
+    %w(std)
+  end
+end
+
+describe DummyShell do
+  let(:retry_limit) { 1 }
+  let(:shell_id) { 'shell_id' }
+  let(:output) { 'output' }
+  let(:command_id) { 'command_id' }
+  let(:payload) { 'message_payload' }
+  let(:command) { 'command' }
+  let(:arguments) { ['args'] }
+  let(:output_message) { double('output_message', build: 'output_message') }
+  let(:connection_options) { { max_commands: 100, retry_limit: retry_limit, retry_delay: 0 } }
+  let(:transport) { double('transport') }
+  let(:reader) { double('reader') }
+
+  before do
+    allow(subject).to receive(:response_reader).and_return(reader)
+    allow(subject).to receive(:command_output_message).with(shell_id, command_id)
+      .and_return(output_message)
+    allow(reader).to receive(:read_output).with(output_message).and_return(output)
+    allow(transport).to receive(:send_request)
+  end
+
+  subject { described_class.new(connection_options, transport, Logging.logger['test']) }
+
+  shared_examples 'retry shell command' do
+    it 'only closes the shell if there are too many' do
+      if fault == WinRM::Shells::Base::TOO_MANY_COMMANDS
+        expect(DummyShell).to receive(:close_shell)
+      else
+        expect(DummyShell).not_to receive(:close_shell)
+      end
+
+      subject.run(command, arguments)
+    end
+
+    it 'opens a new shell' do
+      expect(subject).to receive(:open).and_call_original.twice
+
+      subject.run(command, arguments)
+    end
+
+    it 'retries the command once' do
+      expect(subject).to receive(:send_command).twice
+
+      subject.run(command, arguments)
+    end
+  end
+
+  describe '#run' do
+    it 'opens a shell' do
+      subject.run(command, arguments)
+      expect(subject.shell_id).not_to be nil
+    end
+
+    it 'returns output from generated command' do
+      expect(subject.run(command, arguments)).to eq output
+    end
+
+    it 'sends cleanup message through transport' do
+      allow(SecureRandom).to receive(:uuid).and_return('uuid')
+      expect(transport).to receive(:send_request)
+        .with(
+          WinRM::WSMV::CleanupCommand.new(
+            connection_options,
+            shell_uri: nil,
+            shell_id: shell_id,
+            command_id: command_id
+          ).build
+        )
+      subject.run(command, arguments)
+    end
+
+    it 'does not error if cleanup is aborted' do
+      allow(SecureRandom).to receive(:uuid).and_return('uuid')
+      expect(transport).to receive(:send_request)
+        .with(
+          WinRM::WSMV::CleanupCommand.new(
+            connection_options,
+            shell_uri: nil,
+            shell_id: shell_id,
+            command_id: command_id
+          ).build
+        ).and_raise(WinRM::WinRMWSManFault.new('oops', '995'))
+      subject.run(command, arguments)
+    end
+
+    it 'opens a shell only once when shell is already open' do
+      expect(subject).to receive(:open_shell).and_call_original.once
+      subject.run(command, arguments)
+      subject.run(command, arguments)
+    end
+
+    describe 'connection resets' do
+      before do
+        @times_called = 0
+
+        allow(subject).to receive(:send_command) do
+          @times_called += 1
+          raise WinRM::WinRMWSManFault.new('oops', fault) if @times_called == 1
+          command_id
+        end
+      end
+
+      context 'when shell is closed on server' do
+        let(:fault) { '2150858843' }
+
+        include_examples 'retry shell command'
+      end
+
+      context 'when shell accesses a deleted registry key' do
+        let(:fault) { '2147943418' }
+
+        include_examples 'retry shell command'
+      end
+
+      context 'when maximum number of concurrent shells is exceeded' do
+        let(:fault) { '2150859174' }
+
+        include_examples 'retry shell command'
+      end
+    end
+
+    context 'open_shell fails' do
+      let(:retry_limit) { 2 }
+      let(:output_message2) { double('message') }
+
+      it 'retries and raises failure if it never succeeds' do
+        expect(subject).to receive(:open_shell)
+          .and_raise(Errno::ECONNREFUSED).exactly(retry_limit).times
+        expect { subject.run(command) }.to raise_error(Errno::ECONNREFUSED)
+      end
+
+      it 'retries and returns shell on success' do
+        @times = 0
+        allow(subject).to receive(:command_output_message).with('shell_id 2', command_id)
+          .and_return(output_message2)
+        allow(reader).to receive(:read_output)
+          .with(output_message2).and_return(output)
+        allow(subject).to receive(:open_shell) do
+          @times += 1
+          raise(Errno::ECONNREFUSED) if @times == 1
+          "shell_id #{@times}"
+        end
+
+        subject.run(command, arguments)
+        expect(subject.shell_id).to eq 'shell_id 2'
+      end
+    end
+  end
+
+  describe '#close' do
+    it 'does not close if not opened' do
+      expect(DummyShell).not_to receive(:close_shell)
+      subject.close
+    end
+
+    it 'close shell if opened' do
+      subject.run(command, arguments)
+      subject.close
+      expect(DummyShell.closed?).to be(true)
+    end
+
+    it 'nils out the shell_id' do
+      subject.run(command, arguments)
+      subject.close
+      expect(subject.shell_id).to be(nil)
+    end
+  end
+end