winrm 1.3.0.dev.3 → 1.3.0

data/spec/spec_helper.rb

@@ -1,30 +1,33 @@
+# encoding: UTF-8
 require 'rubygems'
 require 'bundler/setup'
 require 'winrm'
 require 'json'
 require_relative 'matchers'
 
+# Creates a WinRM connection for integration tests
 module ConnectionHelper
-
   def winrm_connection
     config = symbolize_keys(YAML.load(File.read(winrm_config_path)))
-    config[:options].merge!( :basic_auth_only => true ) unless config[:auth_type].eql? :kerberos
-    winrm = WinRM::WinRMWebService.new(config[:endpoint], config[:auth_type].to_sym, config[:options])
+    config[:options].merge!(basic_auth_only: true) unless config[:auth_type].eql? :kerberos
+    winrm = WinRM::WinRMWebService.new(
+      config[:endpoint], config[:auth_type].to_sym, config[:options])
     winrm
   end
 
   def winrm_config_path
     # Copy config-example.yml to config.yml and edit for your local configuration
     path = File.expand_path("#{File.dirname(__FILE__)}/config.yml")
-    if !File.exists?(path)
+    unless File.exist?(path)
       # user hasn't done this, so use sane defaults for unit tests
       path = File.expand_path("#{File.dirname(__FILE__)}/config-example.yml")
     end
     path
   end
 
+  # rubocop:disable Metrics/MethodLength
   def symbolize_keys(hash)
-    hash.inject({}){|result, (key, value)|
+    hash.each_with_object({}) do |(key, value), result|
       new_key = case key
                 when String then key.to_sym
                 else key
@@ -35,9 +38,9 @@ module ConnectionHelper
                   end
       result[new_key] = new_value
       result
-    }
+    end
   end
-
+  # rubocop:enable Metrics/MethodLength
 end
 
 RSpec.configure do |config|

data/spec/winrm_options_spec.rb

@@ -1,4 +1,5 @@
-describe 'WinRM options', :unit => true do
+# encoding: UTF-8
+describe 'WinRM options', unit: true do
   let(:subject) { WinRM::WinRMWebService.new('http://localhost:55985/wsman', :plaintext) }
 
   context 'when operations timeout is set to 60' do
@@ -32,10 +33,10 @@ describe 'WinRM options', :unit => true do
   end
 
   context 'when max_env_size is set to 614400' do
-    before(:each) { subject.max_env_size(614400) }
+    before(:each) { subject.max_env_size(614_400) }
     describe '@max_env_sz' do
       it 'is set to 614400' do
-        expect(subject.instance_variable_get('@max_env_sz')).to eq(614400)
+        expect(subject.instance_variable_get('@max_env_sz')).to eq(614_400)
       end
     end
   end
@@ -68,8 +69,8 @@ describe 'WinRM options', :unit => true do
     end
     describe '@max_env_sz' do
       it 'should be 153600' do
-        expect(subject.instance_variable_get('@max_env_sz')).to eq(153600)
+        expect(subject.instance_variable_get('@max_env_sz')).to eq(153_600)
       end
     end
-  end  
+  end
 end

data/spec/winrm_primitives_spec.rb

@@ -1,10 +1,10 @@
-describe "winrm client primitives" do
+# encoding: UTF-8
+describe 'winrm client primitives' do
   before(:all) do
     @winrm = winrm_connection
   end
 
-  describe "open and close shell", :integration => true do
-
+  describe 'open and close shell', integration: true do
     it 'should #open_shell and #close_shell' do
       sid = @winrm.open_shell
       expect(sid).to be_a_uid
@@ -14,7 +14,7 @@ describe "winrm client primitives" do
     it 'should #run_command and #cleanup_command' do
       sid = @winrm.open_shell
 
-      cmd_id = @winrm.run_command(sid, 'ipconfig', %w{/all})
+      cmd_id = @winrm.run_command(sid, 'ipconfig', %w(/all))
       expect(sid).to be_a_uid
 
       expect(@winrm.cleanup_command(sid, cmd_id)).to be true
@@ -23,23 +23,23 @@ describe "winrm client primitives" do
 
     it 'should #get_command_output' do
       sid = @winrm.open_shell
-      cmd_id = @winrm.run_command(sid, 'ipconfig', %w{/all})
+      cmd_id = @winrm.run_command(sid, 'ipconfig', %w(/all))
 
       output = @winrm.get_command_output(sid, cmd_id)
       expect(output).to have_exit_code 0
-      expect(output).to have_stdout_match /.+/
+      expect(output).to have_stdout_match(/.+/)
       expect(output).to have_no_stderr
 
       @winrm.cleanup_command(sid, cmd_id)
       @winrm.close_shell(sid)
     end
-    
+
     it 'should #get_command_output with a block' do
       sid = @winrm.open_shell
-      cmd_id = @winrm.run_command(sid, 'ipconfig', %w{/all})
+      cmd_id = @winrm.run_command(sid, 'ipconfig', %w(/all))
 
       outvar = ''
-      @winrm.get_command_output(sid, cmd_id) do |stdout, stderr|
+      @winrm.get_command_output(sid, cmd_id) do |stdout, _stderr|
         outvar << stdout
       end
       expect(outvar).to match(/Windows IP Configuration/)
@@ -48,5 +48,4 @@ describe "winrm client primitives" do
       @winrm.close_shell(sid)
     end
   end
-
 end

data/spec/wql_spec.rb

@@ -1,4 +1,5 @@
-describe "winrm client wql", :integration => true do
+# encoding: UTF-8
+describe 'winrm client wql', integration: true do
   before(:all) do
     @winrm = winrm_connection
   end

data/winrm.gemspec

@@ -1,7 +1,7 @@
-# -*- encoding: utf-8 -*-
+# encoding: UTF-8
 require 'date'
 
-version = File.read(File.expand_path("../VERSION", __FILE__)).strip
+version = File.read(File.expand_path('../VERSION', __FILE__)).strip
 
 Gem::Specification.new do |s|
   s.platform = Gem::Platform::RUBY
@@ -9,9 +9,9 @@ Gem::Specification.new do |s|
   s.version = version
   s.date		= Date.today.to_s
 
-  s.author = ['Dan Wanek','Paul Morton']
-  s.email = ['dan.wanek@gmail.com','paul@themortonsonline.com']
-  s.homepage = "http://github.com/WinRb/WinRM"
+  s.author = ['Dan Wanek', 'Paul Morton']
+  s.email = ['dan.wanek@gmail.com', 'paul@themortonsonline.com']
+  s.homepage = 'http://github.com/WinRb/WinRM'
 
   s.summary = 'Ruby library for Windows Remote Management'
   s.description	= <<-EOF
@@ -19,21 +19,22 @@ Gem::Specification.new do |s|
   EOF
 
   s.files = `git ls-files`.split(/\n/)
-  s.require_path = "lib"
+  s.require_path = 'lib'
   s.rdoc_options	= %w(-x test/ -x examples/)
   s.extra_rdoc_files = %w(README.md LICENSE)
 
-  s.bindir = "bin"
+  s.bindir = 'bin'
   s.executables   = ['rwinrm']
   s.required_ruby_version	= '>= 1.9.0'
-  s.add_runtime_dependency  'gssapi', '~> 1.2'
-  s.add_runtime_dependency  'httpclient', '~> 2.2', '>= 2.2.0.2'
-  s.add_runtime_dependency  'rubyntlm', '~> 0.4.0'
-  s.add_runtime_dependency  'uuidtools', '~> 2.1.2'
-  s.add_runtime_dependency  'logging', '~> 1.6', '>= 1.6.1'
-  s.add_runtime_dependency  'nori', '~> 2.0'
-  s.add_runtime_dependency  'gyoku', '~> 1.0'
-  s.add_runtime_dependency  'builder', '>= 2.1.2'
+  s.add_runtime_dependency 'gssapi', '~> 1.2'
+  s.add_runtime_dependency 'httpclient', '~> 2.2', '>= 2.2.0.2'
+  s.add_runtime_dependency 'rubyntlm', '~> 0.4.0'
+  s.add_runtime_dependency 'uuidtools', '~> 2.1.2'
+  s.add_runtime_dependency 'logging', '~> 1.6', '>= 1.6.1'
+  s.add_runtime_dependency 'nori', '~> 2.0'
+  s.add_runtime_dependency 'gyoku', '~> 1.0'
+  s.add_runtime_dependency 'builder', '>= 2.1.2'
   s.add_development_dependency 'rspec', '~> 3.0.0'
   s.add_development_dependency 'rake', '~> 10.3.2'
+  s.add_development_dependency 'rubocop', '~> 0.28.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: winrm
 version: !ruby/object:Gem::Version
-  version: 1.3.0.dev.3
+  version: 1.3.0
 platform: ruby
 authors:
 - Dan Wanek
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-02 00:00:00.000000000 Z
+date: 2015-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gssapi
@@ -163,6 +163,20 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 10.3.2
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.28.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.28.0
 description: |2
       Ruby library for Windows Remote Management
 email:
@@ -177,6 +191,7 @@ extra_rdoc_files:
 files:
 - .gitignore
 - .rspec
+- .rubocop.yml
 - .travis.yml
 - Gemfile
 - LICENSE
@@ -200,6 +215,7 @@ files:
 - spec/cmd_spec.rb
 - spec/config-example.yml
 - spec/exception_spec.rb
+- spec/issue_59_spec.rb
 - spec/matchers.rb
 - spec/output_spec.rb
 - spec/powershell_spec.rb
@@ -232,9 +248,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 1.9.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>'
+  - - '>='
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.0.14