winrm 1.3.0.dev.3 → 1.3.0

data/spec/auth_timeout_spec.rb

@@ -1,8 +1,9 @@
+# encoding: UTF-8
 # This test may only be meaningful with kerberos auth
 # Against server 2012, a kerberos connection will require reauth (get a 401)
 # if there are no requests for >= 15 seconds
 
-describe "Verify kerberos will reauth when necessary", :kerberos => true do
+describe 'Verify kerberos will reauth when necessary', kerberos: true do
   before(:all) do
     @winrm = winrm_connection
   end

data/spec/cmd_spec.rb

@@ -1,4 +1,5 @@
-describe 'winrm client cmd', :integration => true do
+# encoding: UTF-8
+describe 'winrm client cmd', integration: true do
   before(:all) do
     @winrm = winrm_connection
   end
@@ -13,14 +14,14 @@ describe 'winrm client cmd', :integration => true do
   describe 'ipconfig' do
     subject(:output) { @winrm.cmd('ipconfig') }
     it { should have_exit_code 0 }
-    it { should have_stdout_match /Windows IP Configuration/ }
+    it { should have_stdout_match(/Windows IP Configuration/) }
     it { should have_no_stderr }
   end
 
   describe 'echo \'hello world\' using apostrophes' do
     subject(:output) { @winrm.cmd("echo 'hello world'") }
     it { should have_exit_code 0 }
-    it { should have_stdout_match /'hello world'/ }
+    it { should have_stdout_match(/'hello world'/) }
     it { should have_no_stderr }
   end
 
@@ -32,9 +33,9 @@ describe 'winrm client cmd', :integration => true do
       # echo , world! 1>&2
       # eos
 
-      script = "echo Hello & echo , world! 1>&2"
+      script = 'echo Hello & echo , world! 1>&2'
 
-      @captured_stdout, @captured_stderr = "", ""
+      @captured_stdout, @captured_stderr = '', ''
       @winrm.cmd(script) do |stdout, stderr|
         @captured_stdout << stdout if stdout
         @captured_stderr << stderr if stderr
@@ -57,9 +58,9 @@ describe 'winrm client cmd', :integration => true do
   end
 
   describe 'ipconfig with /all argument' do
-    subject(:output) { @winrm.cmd('ipconfig', %w{/all}) }
+    subject(:output) { @winrm.cmd('ipconfig', %w(/all)) }
     it { should have_exit_code 0 }
-    it { should have_stdout_match /Windows IP Configuration/ }
+    it { should have_stdout_match(/Windows IP Configuration/) }
     it { should have_no_stderr }
   end
 
@@ -67,20 +68,20 @@ describe 'winrm client cmd', :integration => true do
     subject(:output) { @winrm.cmd('dir /z') }
     it { should have_exit_code 1 }
     it { should have_no_stdout }
-    it { should have_stderr_match /Invalid switch/ }
+    it { should have_stderr_match(/Invalid switch/) }
   end
 
   describe 'ipconfig && echo error 1>&2' do
     subject(:output) { @winrm.cmd('ipconfig && echo error 1>&2') }
     it { should have_exit_code 0 }
-    it { should have_stdout_match /Windows IP Configuration/ }
-    it { should have_stderr_match /error/ }
+    it { should have_stdout_match(/Windows IP Configuration/) }
+    it { should have_stderr_match(/error/) }
   end
 
   describe 'ipconfig with a block' do
     subject(:stdout) do
       outvar = ''
-      @winrm.cmd('ipconfig') do |stdout, stderr|
+      @winrm.cmd('ipconfig') do |stdout, _stderr |
         outvar << stdout
       end
       outvar

data/spec/exception_spec.rb

@@ -1,7 +1,7 @@
-describe "Exceptions", :unit => true do
+# encoding: UTF-8
+describe 'Exceptions', unit: true do
   describe WinRM::WinRMAuthorizationError do
-
-    let (:error) { WinRM::WinRMHTTPTransportError.new("Foo happened", 500) }
+    let(:error) { WinRM::WinRMHTTPTransportError.new('Foo happened', 500) }
 
     it 'adds the response code to the message' do
       expect(error.message).to eq('Foo happened (500).')
@@ -17,8 +17,7 @@ describe "Exceptions", :unit => true do
   end
 
   describe WinRM::WinRMWSManFault do
-
-    let (:error) { WinRM::WinRMWSManFault.new("fault text", 42) }
+    let(:error) { WinRM::WinRMWSManFault.new('fault text', 42) }
 
     it 'exposes the fault text as an attribute' do
       expect(error.fault_description).to eq('fault text')
@@ -34,15 +33,14 @@ describe "Exceptions", :unit => true do
   end
 
   describe WinRM::WinRMWMIError do
-
-    let (:error) { WinRM::WinRMWMIError.new("message text", 77777) }
+    let(:error) { WinRM::WinRMWMIError.new('message text', 77_777) }
 
     it 'exposes the error text as an attribute' do
       expect(error.error).to eq('message text')
     end
 
     it 'exposes the error code as an attribute' do
-      expect(error.error_code).to eq 77777
+      expect(error.error_code).to eq 77_777
     end
 
     it 'is a winrm error' do

data/spec/issue_59_spec.rb

@@ -0,0 +1,15 @@
+# encoding: UTF-8
+describe 'issue 59', integration: true do
+  before(:all) do
+    @winrm = winrm_connection
+  end
+
+  describe 'long running script without output' do
+    it 'should not error' do
+      output = @winrm.powershell('sleep 60; Write-Host "Hello"')
+      expect(output).to have_exit_code 0
+      expect(output).to have_stdout_match(/Hello/)
+      expect(output).to have_no_stderr
+    end
+  end
+end

data/spec/matchers.rb

@@ -1,5 +1,7 @@
+# encoding: UTF-8
 require 'rspec/expectations'
 
+# rspec matchers
 module WinRMSpecs
   def self.stdout(output)
     output[:data].collect do |i|
@@ -16,7 +18,7 @@ end
 
 RSpec::Matchers.define :have_stdout_match do |expected_stdout|
   match do |actual_output|
-    expected_stdout.match(WinRMSpecs.stdout(actual_output)) != nil
+    !expected_stdout.match(WinRMSpecs.stdout(actual_output)).nil?
   end
   failure_message do |actual_output|
     "expected that '#{WinRMSpecs.stdout(actual_output)}' would match #{expected_stdout}"
@@ -25,7 +27,7 @@ end
 
 RSpec::Matchers.define :have_stderr_match do |expected_stderr|
   match do |actual_output|
-    expected_stderr.match(WinRMSpecs.stderr(actual_output)) != nil
+    !expected_stderr.match(WinRMSpecs.stderr(actual_output)).nil?
   end
   failure_message do |actual_output|
     "expected that '#{WinRMSpecs.stderr(actual_output)}' would match #{expected_stderr}"
@@ -64,7 +66,7 @@ end
 RSpec::Matchers.define :be_a_uid do
   match do |actual|
     # WinRM1.1 returns uuid's prefixed with 'uuid:' where as later versions do not
-    actual != nil && actual.match(/^(uuid:)*\w{8}-\w{4}-\w{4}-\w{4}-\w{12}$/)
+    !actual.nil? && actual.match(/^(uuid:)*\w{8}-\w{4}-\w{4}-\w{4}-\w{12}$/)
   end
   failure_message do |actual|
     "expected a uid, but got '#{actual}'"

data/spec/output_spec.rb

@@ -1,106 +1,110 @@
-describe WinRM::Output, :unit => true do
-  subject { WinRM::Output.new() }
+# encoding: UTF-8
+describe WinRM::Output, unit: true do
+  subject { WinRM::Output.new }
 
-  context "when there is no output" do
-    describe "#stdout" do
-      it "is empty" do
+  context 'when there is no output' do
+    describe '#stdout' do
+      it 'is empty' do
         expect(subject.stdout).to be_empty
       end
     end
 
-    describe "#stderr" do
-      it "is empty" do
+    describe '#stderr' do
+      it 'is empty' do
         expect(subject.stderr).to be_empty
       end
     end
 
-    describe "#output" do
-      it "is empty" do
+    describe '#output' do
+      it 'is empty' do
         expect(subject.output).to be_empty
       end
     end
   end
 
-  context "when there is only one line" do
-    describe "#stdout" do
-      it "is equal to that line" do
-        subject[:data] << { :stdout => "foo" }
-        expect(subject.stdout).to eq("foo")
+  context 'when there is only one line' do
+    describe '#stdout' do
+      it 'is equal to that line' do
+        subject[:data] << { stdout: 'foo' }
+        expect(subject.stdout).to eq('foo')
       end
     end
 
-    describe "#stderr" do
-      it "is equal to that line" do
-        subject[:data] << { :stderr => "foo" }
-        expect(subject.stderr).to eq("foo")
+    describe '#stderr' do
+      it 'is equal to that line' do
+        subject[:data] << { stderr: 'foo' }
+        expect(subject.stderr).to eq('foo')
       end
     end
 
-    describe "#output" do
-      it "is equal to stdout" do
-        subject[:data] << { :stdout => "foo" }
-        expect(subject.output).to eq("foo")
+    describe '#output' do
+      it 'is equal to stdout' do
+        subject[:data] << { stdout: 'foo' }
+        expect(subject.output).to eq('foo')
       end
 
-      it "is equal to stderr" do
-        subject[:data] << { :stderr => "foo" }
-        expect(subject.output).to eq("foo")
+      it 'is equal to stderr' do
+        subject[:data] << { stderr: 'foo' }
+        expect(subject.output).to eq('foo')
       end
     end
   end
 
-  context "when there is one line of each type" do
+  context 'when there is one line of each type' do
     before(:each) do
-      subject[:data] << { :stdout => "foo" }
-      subject[:data] << { :stderr => "bar" }
+      subject[:data] << { stdout: 'foo' }
+      subject[:data] << { stderr: 'bar' }
     end
 
-    describe "#stdout" do
-      it "is equal to that line" do
-        expect(subject.stdout).to eq("foo")
+    describe '#stdout' do
+      it 'is equal to that line' do
+        expect(subject.stdout).to eq('foo')
       end
     end
 
-    describe "#stderr" do
-      it "is equal to that line" do
-        expect(subject.stderr).to eq("bar")
+    describe '#stderr' do
+      it 'is equal to that line' do
+        expect(subject.stderr).to eq('bar')
       end
     end
 
-    describe "#output" do
-      it "is equal to stdout + stderr" do
-        expect(subject.output).to eq("foobar")
+    describe '#output' do
+      it 'is equal to stdout + stderr' do
+        expect(subject.output).to eq('foobar')
       end
     end
   end
 
-  context "when there are multiple lines" do
+  context 'when there are multiple lines' do
     before(:each) do
-      subject[:data] << { :stdout => "I can have a newline\nanywhere, " }
-      subject[:data] << { :stderr => "I can also have stderr" }
-      subject[:data] << { :stdout => "or stdout", :stderr => " and stderr" }
-      subject[:data] << { }
-      subject[:data] << { :stdout => " or nothing! (above)" }
+      subject[:data] << { stdout: 'I can have a newline\nanywhere, ' }
+      subject[:data] << { stderr: 'I can also have stderr' }
+      subject[:data] << { stdout: 'or stdout', stderr: ' and stderr' }
+      subject[:data] << {}
+      subject[:data] << { stdout: ' or nothing! (above)' }
     end
 
-    describe "#stdout" do
-      it "is equal to that line" do
-        expect(subject.stdout).to eq("I can have a newline\nanywhere, or stdout or nothing! (above)")
+    describe '#stdout' do
+      it 'is equal to that line' do
+        expect(subject.stdout).to eq(
+          'I can have a newline\nanywhere, or stdout or nothing! (above)')
       end
     end
 
-    describe "#stderr" do
-      it "is equal to that line" do
-        expect(subject.stderr).to eq("I can also have stderr and stderr")
+    describe '#stderr' do
+      it 'is equal to that line' do
+        expect(subject.stderr).to eq('I can also have stderr and stderr')
       end
     end
 
-    describe "#output" do
-      it "is equal to stdout + stderr" do
-        expect(subject.output).to eq("I can have a newline\nanywhere, I can also have stderror stdout and stderr or nothing! (above)")
+    describe '#output' do
+      it 'is equal to stdout + stderr' do
+        expect(subject.output).to eq(
+          'I can have a newline\nanywhere, I can also have stderror stdout ' \
+            'and stderr or nothing! (above)')
       end
     end
   end
 
-  pending "parse CLIXML errors and convert to Strings and/or Exceptions"
+  pending 'parse CLIXML errors and convert to Strings and/or Exceptions'
 end

data/spec/powershell_spec.rb

@@ -1,25 +1,26 @@
-describe 'winrm client powershell', :integration => true do
+# encoding: UTF-8
+describe 'winrm client powershell', integration: true do
   before(:all) do
     @winrm = winrm_connection
   end
 
   describe 'empty string' do
     subject(:output) { @winrm.powershell('') }
-    it { should have_exit_code 4294770688 }
-    it { should have_stderr_match /Cannot process the command because of a missing parameter/ }
+    it { should have_exit_code 4_294_770_688 }
+    it { should have_stderr_match(/Cannot process the command because of a missing parameter/) }
   end
 
   describe 'ipconfig' do
     subject(:output) { @winrm.powershell('ipconfig') }
     it { should have_exit_code 0 }
-    it { should have_stdout_match /Windows IP Configuration/ }
+    it { should have_stdout_match(/Windows IP Configuration/) }
     it { should have_no_stderr }
   end
 
   describe 'echo \'hello world\' using apostrophes' do
     subject(:output) { @winrm.powershell("echo 'hello world'") }
     it { should have_exit_code 0 }
-    it { should have_stdout_match /hello world/ }
+    it { should have_stdout_match(/hello world/) }
     it { should have_no_stderr }
   end
 
@@ -27,8 +28,6 @@ describe 'winrm client powershell', :integration => true do
     subject(:output) { @winrm.powershell('dir /z') }
     it { should have_exit_code 1 }
     it { should have_no_stdout }
-    #TODO Better 
-    #it { should have_stderr_match /Invalid switch/ }
   end
 
   describe 'Math area calculation' do
@@ -41,14 +40,14 @@ describe 'winrm client powershell', :integration => true do
       )
     end
     it { should have_exit_code 0 }
-    it { should have_stdout_match /49.9648722805149/ }
+    it { should have_stdout_match(/49.9648722805149/) }
     it { should have_no_stderr }
   end
 
   describe 'ipconfig with a block' do
     subject(:stdout) do
       outvar = ''
-      @winrm.powershell('ipconfig') do |stdout, stderr|
+      @winrm.powershell('ipconfig') do |stdout, _stderr|
         outvar << stdout
       end
       outvar
@@ -63,7 +62,7 @@ describe 'winrm client powershell', :integration => true do
       $host.ui.WriteErrorLine(', world!')
       eos
 
-      @captured_stdout, @captured_stderr = "", ""
+      @captured_stdout, @captured_stderr = '', ''
       @winrm.powershell(script) do |stdout, stderr|
         @captured_stdout << stdout if stdout
         @captured_stderr << stderr if stderr
@@ -79,16 +78,19 @@ describe 'winrm client powershell', :integration => true do
       # TODO: Option to parse CLIXML
       # expect(output.output).to eq("Hello\n, world!")
       # expect(output.stderr).to eq(", world!")
-      expect(output.stderr).to eq("#< CLIXML\r\n<Objs Version=\"1.1.0.1\" xmlns=\"http://schemas.microsoft.com/powershell/2004/04\"><S S=\"Error\">, world!_x000D__x000A_</S></Objs>")
+      expect(output.stderr).to eq(
+        "#< CLIXML\r\n<Objs Version=\"1.1.0.1\" " \
+        "xmlns=\"http://schemas.microsoft.com/powershell/2004/04\">" \
+        "<S S=\"Error\">, world!_x000D__x000A_</S></Objs>")
       expect(output.stderr).to eq(@captured_stderr)
     end
 
     it 'should have output' do
       # TODO: Option to parse CLIXML
       # expect(output.output).to eq("Hello\n, world!")
-      expect(output.output).to eq("Hello\n#< CLIXML\r\n<Objs Version=\"1.1.0.1\" xmlns=\"http://schemas.microsoft.com/powershell/2004/04\"><S S=\"Error\">, world!_x000D__x000A_</S></Objs>")
+      expect(output.output).to eq("Hello\n#< CLIXML\r\n<Objs Version=\"1.1.0.1\" " \
+        "xmlns=\"http://schemas.microsoft.com/powershell/2004/04\">" \
+        "<S S=\"Error\">, world!_x000D__x000A_</S></Objs>")
     end
   end
 end
-
-

data/spec/response_handler_spec.rb

@@ -1,15 +1,15 @@
+# encoding: UTF-8
 require 'winrm/http/response_handler'
 
-describe 'response handler', :unit => true do
-
-  ['v1', 'v2'].each do |winrm_version|
+describe 'response handler', unit: true do
+  %w(v1, v2).each do |winrm_version|
     let(:soap_fault) { File.read("spec/stubs/responses/soap_fault_#{winrm_version}.xml") }
     let(:open_shell) { File.read("spec/stubs/responses/open_shell_#{winrm_version}.xml") }
 
     describe "successful 200 #{winrm_version} response" do
       it 'returns an xml doc' do
         handler = WinRM::ResponseHandler.new(open_shell, 200)
-        xml_doc = handler.parse_to_xml()
+        xml_doc = handler.parse_to_xml
         expect(xml_doc).to be_instance_of(REXML::Document)
         expect(xml_doc.to_s).to eq(REXML::Document.new(open_shell).to_s)
       end
@@ -18,14 +18,14 @@ describe 'response handler', :unit => true do
     describe "failed 500 #{winrm_version} response" do
       it 'raises a WinRMHTTPTransportError' do
         handler = WinRM::ResponseHandler.new('', 500)
-        expect { handler.parse_to_xml()}.to raise_error(WinRM::WinRMHTTPTransportError)
+        expect { handler.parse_to_xml }.to raise_error(WinRM::WinRMHTTPTransportError)
       end
     end
 
     describe "failed 401 #{winrm_version} response" do
       it 'raises a WinRMAuthorizationError' do
         handler = WinRM::ResponseHandler.new('', 401)
-        expect { handler.parse_to_xml()}.to raise_error(WinRM::WinRMAuthorizationError)
+        expect { handler.parse_to_xml }.to raise_error(WinRM::WinRMAuthorizationError)
       end
     end
 
@@ -33,22 +33,23 @@ describe 'response handler', :unit => true do
       it 'raises a WinRMWSManFault' do
         handler = WinRM::ResponseHandler.new(soap_fault, 400)
         begin
-          handler.parse_to_xml()
+          handler.parse_to_xml
         rescue WinRM::WinRMWSManFault => e
           expect(e.fault_code).to eq('2150858778')
-          expect(e.fault_description).to include('The specified class does not exist in the given namespace')
+          expect(e.fault_description).to include(
+            'The specified class does not exist in the given namespace')
         end
       end
     end
   end
 
-  describe "failed 500 WMI error response" do
-    let(:wmi_error) { File.read("spec/stubs/responses/wmi_error_v2.xml") }
+  describe 'failed 500 WMI error response' do
+    let(:wmi_error) { File.read('spec/stubs/responses/wmi_error_v2.xml') }
 
     it 'raises a WinRMWMIError' do
       handler = WinRM::ResponseHandler.new(wmi_error, 500)
       begin
-        handler.parse_to_xml()
+        handler.parse_to_xml
       rescue WinRM::WinRMWMIError => e
         expect(e.error_code).to eq('2150859173')
         expect(e.error).to include('The WS-Management service cannot process the request.')