webdrivers 3.8.1 → 3.9.0

data/spec/webdrivers/ms_webdriver_spec.rb

@@ -5,22 +5,26 @@ require 'spec_helper'
 describe Webdrivers::MSWebdriver do
   let(:mswebdriver) { described_class }
 
-  it 'downloads mswebdriver' do
-    mswebdriver.remove
-    allow(mswebdriver).to receive(:desired_version).and_return(mswebdriver.latest_version)
-    expect(File.exist?(mswebdriver.download)).to be true
-  end
+  it 'gives deprecation for using it' do
+    msg = /WARN Webdrivers Microsoft WebDriver for the Edge browser is no longer supported by Webdrivers gem/
 
-  it 'removes mswebdriver' do
-    mswebdriver.remove
-    expect(File.exist?(mswebdriver.send(:binary))).to be false
+    if Selenium::WebDriver::VERSION > '3.141.0'
+      expect { Selenium::WebDriver::Edge::Service.driver_path }.to output(msg).to_stdout_from_any_process
+    else
+      expect { Selenium::WebDriver::Edge.driver_path }.to output(msg).to_stdout_from_any_process
+    end
   end
 
-  context 'when offline' do
-    before { allow(mswebdriver).to receive(:site_available?).and_return(false) }
+  it 'does not give deprecation when set to ignore' do
+    described_class.ignore = true
 
-    it 'raises exception downloading' do
-      expect { mswebdriver.download }.to raise_error(StandardError, 'Can not reach site')
-    end
+    service = instance_double(Selenium::WebDriver::Service, host: '', start: nil, uri: '')
+    bridge = instance_double(Selenium::WebDriver::Remote::Bridge, create_session: nil, session_id: '')
+
+    allow(Selenium::WebDriver::Service).to receive(:new).and_return(service)
+    allow(Selenium::WebDriver::Remote::Bridge).to receive(:new).and_return(bridge)
+    allow(Selenium::WebDriver::Remote::W3C::Bridge).to receive(:new)
+
+    expect { Selenium::WebDriver.for :edge }.not_to output.to_stdout_from_any_process
   end
 end

data/spec/webdrivers_proxy_support_spec.rb

@@ -4,7 +4,7 @@ require 'spec_helper'
 
 class FakeDriver < Webdrivers::Common
   def self.http_object
-    http
+    Webdrivers::Network.http
   end
 end
 
@@ -48,6 +48,6 @@ describe Webdrivers do
   it 'raises an exception when net_http_ssl_fix is called.' do
     err = 'Webdrivers.net_http_ssl_fix is no longer available.' \
       ' Please see https://github.com/titusfortner/webdrivers#ssl_connect-errors.'
-    expect { described_class.net_http_ssl_fix }.to raise_error(StandardError, err)
+    expect { described_class.net_http_ssl_fix }.to raise_error(RuntimeError, err)
   end
 end

data/webdrivers.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.push File.expand_path('../lib', __dir__)
 
 Gem::Specification.new do |s|
   s.name        = 'webdrivers'
-  s.version     = '3.8.1'
+  s.version     = '3.9.0'
   s.authors     = ['Titus Fortner', 'Lakshya Kapoor']
   s.email       = %w[titusfortner@gmail.com kapoorlakshya@gmail.com]
   s.homepage    = 'https://github.com/titusfortner/webdrivers'
@@ -18,9 +18,10 @@ Gem::Specification.new do |s|
   s.require_paths = ['lib']
 
   s.add_development_dependency 'ffi', '~> 1.0' # For selenium-webdriver on Windows
-  s.add_development_dependency 'rake', '~> 10.0'
+  s.add_development_dependency 'rake', '~> 12.0'
   s.add_development_dependency 'rspec', '~> 3.0'
   s.add_development_dependency 'rubocop', '~>0.66'
+  s.add_development_dependency 'rubocop-performance'
   s.add_development_dependency 'rubocop-rspec', '~>1.32'
   s.add_development_dependency 'simplecov', '~>0.16'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webdrivers
 version: !ruby/object:Gem::Version
-  version: 3.8.1
+  version: 3.9.0
 platform: ruby
 authors:
 - Titus Fortner
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-07 00:00:00.000000000 Z
+date: 2019-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffi
@@ -31,14 +31,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -67,6 +67,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.66'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -163,7 +177,8 @@ files:
 - lib/webdrivers/iedriver.rb
 - lib/webdrivers/logger.rb
 - lib/webdrivers/mswebdriver.rb
-- lib/webdrivers/selenium.rb
+- lib/webdrivers/network.rb
+- lib/webdrivers/system.rb
 - spec/spec_helper.rb
 - spec/webdrivers/chromedriver_spec.rb
 - spec/webdrivers/geckodriver_spec.rb

data/lib/webdrivers/selenium.rb

@@ -1,40 +0,0 @@
-# frozen_string_literal: true
-
-require 'selenium-webdriver'
-
-# v3.151.59 and higher
-if ::Selenium::WebDriver::Service.respond_to? :driver_path=
-  ::Selenium::WebDriver::Chrome::Service.driver_path  = proc { ::Webdrivers::Chromedriver.update }
-  ::Selenium::WebDriver::Firefox::Service.driver_path = proc { ::Webdrivers::Geckodriver.update }
-  ::Selenium::WebDriver::Edge::Service.driver_path    = proc { ::Webdrivers::MSWebdriver.update }
-  ::Selenium::WebDriver::IE::Service.driver_path      = proc { ::Webdrivers::IEdriver.update }
-else
-  # v3.141.0 and lower
-  module Selenium
-    module WebDriver
-      module Chrome
-        def self.driver_path
-          @driver_path ||= Webdrivers::Chromedriver.update
-        end
-      end
-
-      module Firefox
-        def self.driver_path
-          @driver_path ||= Webdrivers::Geckodriver.update
-        end
-      end
-
-      module Edge
-        def self.driver_path
-          @driver_path ||= Webdrivers::MSWebdriver.update
-        end
-      end
-
-      module IE
-        def self.driver_path
-          @driver_path ||= Webdrivers::IEdriver.update
-        end
-      end
-    end
-  end
-end