webdrivers 3.8.1 → 3.9.0

data/spec/webdrivers/geckodriver_spec.rb

@@ -5,62 +5,206 @@ require 'spec_helper'
 describe Webdrivers::Geckodriver do
   let(:geckodriver) { described_class }
 
-  it 'raises exception if unable to get latest geckodriver and no geckodriver present' do
+  before do
     geckodriver.remove
-    allow(geckodriver).to receive(:desired_version).and_return(nil)
-    gd = 'Unable to find the latest version of geckodriver'
-    msg = /^#{gd}(.exe)?; try downloading manually from (.*)?and place in (.*)?\.webdrivers$/
-    expect { geckodriver.update }.to raise_exception StandardError, msg
+    geckodriver.required_version = nil
   end
 
-  it 'uses found version of geckodriver if latest release unable to be found' do
-    geckodriver.download
-    allow(geckodriver).to receive(:desired_version).and_return(nil)
-    expect(geckodriver.update).to match(%r{\.webdrivers/geckodriver})
+  describe '#update' do
+    context 'when evaluating #correct_binary?' do
+      it 'does not download when latest version and current version match' do
+        allow(geckodriver).to receive(:latest_version).and_return(Gem::Version.new('0.3.0'))
+        allow(geckodriver).to receive(:current_version).and_return(Gem::Version.new('0.3.0'))
+
+        geckodriver.update
+
+        expect(geckodriver.send(:exists?)).to be false
+      end
+
+      it 'does not download when offline, but binary exists' do
+        allow(Webdrivers::System).to receive(:call).and_return('geckodriver 0.24.0 ( 2019-01-28)')
+        allow(Net::HTTP).to receive(:get_response).and_raise(SocketError)
+        allow(geckodriver).to receive(:exists?).and_return(true)
+
+        geckodriver.update
+
+        expect(File.exist?(geckodriver.driver_path)).to be false
+      end
+
+      it 'raises ConnectionError when offline, and no binary exists' do
+        allow(Net::HTTP).to receive(:get_response).and_raise(SocketError)
+        allow(geckodriver).to receive(:exists?).and_return(false)
+
+        expect { geckodriver.update }.to raise_error(Webdrivers::ConnectionError)
+      end
+    end
+
+    context 'when correct binary is found' do
+      before { allow(geckodriver).to receive(:correct_binary?).and_return(true) }
+
+      it 'does not download' do
+        geckodriver.update
+
+        expect(geckodriver.current_version).to be_nil
+      end
+
+      it 'does not raise exception if offline' do
+        allow(Net::HTTP).to receive(:get_response).and_raise(SocketError)
+
+        geckodriver.update
+
+        expect(geckodriver.current_version).to be_nil
+      end
+    end
+
+    context 'when correct binary is not found' do
+      before { allow(geckodriver).to receive(:correct_binary?).and_return(false) }
+
+      it 'downloads binary' do
+        geckodriver.update
+
+        expect(geckodriver.current_version).not_to be_nil
+      end
+
+      it 'raises ConnectionError if offline' do
+        allow(Net::HTTP).to receive(:get_response).and_raise(SocketError)
+
+        msg = %r{Can not reach https://github.com/mozilla/geckodriver/releases}
+        expect { geckodriver.update }.to raise_error(Webdrivers::ConnectionError, msg)
+      end
+    end
+
+    it 'finds the required version from parsed downloads page' do
+      base = 'https://github.com/mozilla/geckodriver/releases/download'
+      url = %r{#{base}\/v0\.2\.0\/geckodriver-v0\.2\.0-}
+
+      allow(Webdrivers::System).to receive(:download).with(url, geckodriver.driver_path)
+
+      geckodriver.required_version = '0.2.0'
+      geckodriver.update
+
+      expect(Webdrivers::System).to have_received(:download).with(url, geckodriver.driver_path)
+    end
+
+    it 'does something when a wrong version is supplied' do
+      geckodriver.required_version = '0.2.0'
+
+      msg = /Net::HTTPServerException: 404 "Not Found"/
+      expect { geckodriver.update }.to raise_error(StandardError, msg)
+    end
+  end
+
+  describe '#current_version' do
+    it 'returns nil if binary does not exist on the system' do
+      allow(geckodriver).to receive(:driver_path).and_return('')
+
+      expect(geckodriver.current_version).to be_nil
+    end
+
+    it 'returns a Gem::Version instance if binary is on the system' do
+      allow(geckodriver).to receive(:exists?).and_return(true)
+
+      return_value = "geckodriver 0.24.0 ( 2019-01-28)
+
+The source code of this program is available from
+testing/geckodriver in https://hg.mozilla.org/mozilla-central.
+
+This program is subject to the terms of the Mozilla Public License 2.0.
+You can obtain a copy of the license at https://mozilla.org/MPL/2.0/"
+
+      allow(Webdrivers::System).to receive(:call).with("#{geckodriver.driver_path} --version").and_return return_value
+
+      expect(geckodriver.current_version).to eq Gem::Version.new('0.24.0')
+    end
   end
 
-  it 'finds latest version' do
-    old_version = Gem::Version.new('0.17')
-    future_version = Gem::Version.new('0.30')
-    desired_version = geckodriver.desired_version
+  describe '#latest_version' do
+    it 'finds the latest version directly' do
+      url = 'https://github.com/mozilla/geckodriver/releases/tag/v0.24.0'
+      allow(Webdrivers::Network).to receive(:get_url).and_return(url)
+
+      geckodriver.update
+
+      expect(geckodriver.latest_version).to eq Gem::Version.new('0.24.0')
+    end
+
+    it 'creates cached file' do
+      allow(Webdrivers::Network).to receive(:get).and_return('0.24.0')
+
+      geckodriver.latest_version
+      expect(File.exist?("#{Webdrivers::System.install_dir}/geckodriver.version")).to eq true
+    end
+
+    it 'does not make network call if cache is valid' do
+      allow(Webdrivers).to receive(:cache_time).and_return(3600)
+      Webdrivers::System.cache_version('geckodriver', '0.23.0')
+      allow(Webdrivers::Network).to receive(:get)
+
+      expect(geckodriver.latest_version).to eq Gem::Version.new('0.23.0')
 
-    expect(desired_version).to be > old_version
-    expect(desired_version).to be < future_version
+      expect(Webdrivers::Network).not_to have_received(:get)
+    end
+
+    it 'makes a network call if cache is expired' do
+      Webdrivers::System.cache_version('geckodriver', '0.23.0')
+      url = 'https://github.com/mozilla/geckodriver/releases/tag/v0.24.0'
+      allow(Webdrivers::Network).to receive(:get_url).and_return(url)
+      allow(Webdrivers::System).to receive(:valid_cache?)
+
+      expect(geckodriver.latest_version).to eq Gem::Version.new('0.24.0')
+
+      expect(Webdrivers::Network).to have_received(:get_url)
+      expect(Webdrivers::System).to have_received(:valid_cache?)
+    end
   end
 
-  it 'downloads latest version by default' do
-    geckodriver.download
-    expect(geckodriver.current_version).to eq geckodriver.desired_version
+  describe '#required_version=' do
+    it 'returns the version specified as a Float' do
+      geckodriver.required_version = 0.12
+
+      expect(geckodriver.required_version).to eq Gem::Version.new('0.12')
+    end
+
+    it 'returns the version specified as a String' do
+      geckodriver.required_version = '0.12.1'
+
+      expect(geckodriver.required_version).to eq Gem::Version.new('0.12.1')
+    end
   end
 
-  it 'downloads specified version' do
-    begin
+  describe '#remove' do
+    it 'removes existing geckodriver' do
+      geckodriver.update
+
       geckodriver.remove
-      geckodriver.version = '0.17.0'
-      geckodriver.download
-      expect(geckodriver.current_version.version).to eq '0.17.0'
-    ensure
-      geckodriver.version = nil
+      expect(geckodriver.current_version).to be_nil
     end
-  end
 
-  it 'removes geckodriver' do
-    geckodriver.remove
-    expect(geckodriver.current_version).to be_nil
+    it 'does not raise exception if no geckodriver found' do
+      expect { geckodriver.remove }.not_to raise_error
+    end
   end
 
-  context 'when offline' do
-    before do
-      geckodriver.instance_variable_set('@latest_version', nil)
-      allow(geckodriver).to receive(:site_available?).and_return(false)
+  describe '#install_dir' do
+    it 'uses ~/.webdrivers as default value' do
+      expect(Webdrivers::System.install_dir).to include('.webdriver')
     end
 
-    it 'raises exception finding latest version' do
-      expect { geckodriver.desired_version }.to raise_error(StandardError, 'Can not reach site')
+    it 'uses provided value' do
+      begin
+        install_dir = File.expand_path(File.join(ENV['HOME'], '.webdrivers2'))
+        Webdrivers.install_dir = install_dir
+
+        expect(Webdrivers::System.install_dir).to eq install_dir
+      ensure
+        Webdrivers.install_dir = nil
+      end
     end
+  end
 
-    it 'raises exception downloading' do
-      expect { geckodriver.download }.to raise_error(StandardError, 'Can not reach site')
+  describe '#driver_path' do
+    it 'returns full location of binary' do
+      expect(geckodriver.driver_path).to match("#{File.join(ENV['HOME'])}/.webdrivers/geckodriver")
     end
   end
 end

data/spec/webdrivers/i_edriver_spec.rb

@@ -5,37 +5,188 @@ require 'spec_helper'
 describe Webdrivers::IEdriver do
   let(:iedriver) { described_class }
 
-  it 'finds latest version' do
-    old_version = Gem::Version.new('3.12.0')
-    future_version = Gem::Version.new('4.0')
-    desired_version = iedriver.desired_version
+  before do
+    iedriver.remove
+    iedriver.required_version = nil
+  end
+
+  describe '#update' do
+    context 'when evaluating #correct_binary?' do
+      it 'does not download when latest version and current version match' do
+        allow(iedriver).to receive(:latest_version).and_return(Gem::Version.new('0.3.0'))
+        allow(iedriver).to receive(:current_version).and_return(Gem::Version.new('0.3.0'))
+
+        iedriver.update
+
+        expect(iedriver.send(:exists?)).to be false
+      end
+
+      it 'does not download when offline, but binary exists' do
+        allow(Webdrivers::System).to receive(:call).and_return('something IEDriverServer.exe 3.5.1 something else')
+        allow(Net::HTTP).to receive(:get_response).and_raise(SocketError)
+        allow(iedriver).to receive(:exists?).and_return(true)
+
+        iedriver.update
+
+        expect(File.exist?(iedriver.driver_path)).to be false
+      end
+
+      it 'raises ConnectionError when offline, and no binary exists' do
+        allow(Net::HTTP).to receive(:get_response).and_raise(SocketError)
+        allow(iedriver).to receive(:exists?).and_return(false)
+
+        expect { iedriver.update }.to raise_error(Webdrivers::ConnectionError)
+      end
+    end
+
+    context 'when correct binary is found' do
+      before { allow(iedriver).to receive(:correct_binary?).and_return(true) }
+
+      it 'does not download' do
+        iedriver.update
+
+        expect(iedriver.current_version).to be_nil
+      end
+
+      it 'does not raise exception if offline' do
+        allow(Net::HTTP).to receive(:get_response).and_raise(SocketError)
+
+        iedriver.update
 
-    expect(desired_version).to be > old_version
-    expect(desired_version).to be < future_version
+        expect(iedriver.current_version).to be_nil
+      end
+    end
+
+    context 'when correct binary is not found' do
+      before { allow(iedriver).to receive(:correct_binary?).and_return(false) }
+
+      it 'downloads binary' do
+        iedriver.update
+
+        expect(File.exist?(iedriver.driver_path)).to eq true
+      end
+
+      it 'raises ConnectionError if offline' do
+        allow(Net::HTTP).to receive(:get_response).and_raise(SocketError)
+
+        msg = %r{Can not reach https://selenium-release.storage.googleapis.com/}
+        expect { iedriver.update }.to raise_error(Webdrivers::ConnectionError, msg)
+      end
+    end
   end
 
-  it 'downloads iedriver' do
-    iedriver.remove
-    expect(File.exist?(iedriver.download)).to be true
+  describe '#current_version' do
+    it 'returns nil if binary does not exist on the system' do
+      allow(iedriver).to receive(:driver_path).and_return('')
+
+      expect(iedriver.current_version).to be_nil
+    end
+
+    it 'returns a Gem::Version instance if binary is on the system' do
+      allow(iedriver).to receive(:exists?).and_return(true)
+
+      return_value = 'something IEDriverServer.exe 3.5.1 something else'
+
+      allow(Webdrivers::System).to receive(:call).with("#{iedriver.driver_path} --version").and_return return_value
+
+      expect(iedriver.current_version).to eq Gem::Version.new('3.5.1')
+    end
   end
 
-  it 'removes iedriver' do
-    iedriver.remove
-    expect(iedriver.current_version).to be_nil
+  describe '#latest_version' do
+    it 'finds the latest version from parsed hash' do
+      base = 'https://selenium-release.storage.googleapis.com/'
+      hash = {Gem::Version.new('3.4.0') => "#{base}/3.4/IEDriverServer_Win32_3.4.0.zip",
+              Gem::Version.new('3.5.0') => "#{base}/3.5/IEDriverServer_Win32_3.5.0.zip",
+              Gem::Version.new('3.5.1') => "#{base}/3.5/IEDriverServer_Win32_3.5.1.zip"}
+      allow(iedriver).to receive(:downloads).and_return(hash)
+
+      expect(iedriver.latest_version).to eq Gem::Version.new('3.5.1')
+    end
+
+    it 'correctly parses the downloads page' do
+      expect(iedriver.send(:downloads)).not_to be_empty
+    end
+
+    it 'creates cached file' do
+      allow(Webdrivers::Network).to receive(:get).and_return('3.4.0')
+
+      iedriver.latest_version
+      expect(File.exist?("#{Webdrivers::System.install_dir}/IEDriverServer.version")).to eq true
+    end
+
+    it 'does not make network call if cache is valid' do
+      allow(Webdrivers).to receive(:cache_time).and_return(3600)
+      Webdrivers::System.cache_version('IEDriverServer', '3.4.0')
+      allow(Webdrivers::Network).to receive(:get)
+
+      expect(iedriver.latest_version).to eq Gem::Version.new('3.4.0')
+
+      expect(Webdrivers::Network).not_to have_received(:get)
+    end
+
+    it 'makes a network call if cache is expired' do
+      Webdrivers::System.cache_version('IEDriverServer', '3.4.0')
+      base = 'https://selenium-release.storage.googleapis.com/'
+      hash = {Gem::Version.new('3.4.0') => "#{base}/3.4/IEDriverServer_Win32_3.4.0.zip",
+              Gem::Version.new('3.5.0') => "#{base}/3.5/IEDriverServer_Win32_3.5.0.zip",
+              Gem::Version.new('3.5.1') => "#{base}/3.5/IEDriverServer_Win32_3.5.1.zip"}
+      allow(iedriver).to receive(:downloads).and_return(hash)
+      allow(Webdrivers::System).to receive(:valid_cache?)
+
+      expect(iedriver.latest_version).to eq Gem::Version.new('3.5.1')
+      expect(iedriver).to have_received(:downloads)
+      expect(Webdrivers::System).to have_received(:valid_cache?)
+    end
   end
 
-  context 'when offline' do
-    before do
-      iedriver.instance_variable_set('@latest_version', nil)
-      allow(iedriver).to receive(:site_available?).and_return(false)
+  describe '#required_version=' do
+    it 'returns the version specified as a Float' do
+      iedriver.required_version = 0.12
+
+      expect(iedriver.required_version).to eq Gem::Version.new('0.12')
+    end
+
+    it 'returns the version specified as a String' do
+      iedriver.required_version = '0.12.1'
+
+      expect(iedriver.required_version).to eq Gem::Version.new('0.12.1')
+    end
+  end
+
+  describe '#remove' do
+    it 'removes existing iedriver' do
+      iedriver.update
+
+      iedriver.remove
+      expect(iedriver.current_version).to be_nil
     end
 
-    it 'raises exception finding latest version' do
-      expect { iedriver.latest_version }.to raise_error(StandardError, 'Can not reach site')
+    it 'does not raise exception if no iedriver found' do
+      expect { iedriver.remove }.not_to raise_error
     end
+  end
+
+  describe '#install_dir' do
+    it 'uses ~/.webdrivers as default value' do
+      expect(Webdrivers::System.install_dir).to include('.webdriver')
+    end
+
+    it 'uses provided value' do
+      begin
+        install_dir = File.expand_path(File.join(ENV['HOME'], '.webdrivers2'))
+        Webdrivers.install_dir = install_dir
+
+        expect(Webdrivers::System.install_dir).to eq install_dir
+      ensure
+        Webdrivers.install_dir = nil
+      end
+    end
+  end
 
-    it 'raises exception downloading' do
-      expect { iedriver.download }.to raise_error(StandardError, 'Can not reach site')
+  describe '#driver_path' do
+    it 'returns full location of binary' do
+      expect(iedriver.driver_path).to eq("#{File.join(ENV['HOME'])}/.webdrivers/IEDriverServer.exe")
     end
   end
 end