wavefront-sdk 3.3.3 → 3.3.4

data/spec/wavefront-sdk/metric_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 

data/spec/wavefront-sdk/notificant_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/general'

data/spec/wavefront-sdk/paginator/base_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../../spec_helper'
 require_relative '../../../lib/wavefront-sdk/paginator/base'

data/spec/wavefront-sdk/paginator/post_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'json'
 require_relative '../../spec_helper'

data/spec/wavefront-sdk/proxy_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/general'

data/spec/wavefront-sdk/query_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'cgi'
 require 'date'

data/spec/wavefront-sdk/report_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative 'resources/dummy_points'

data/spec/wavefront-sdk/resources/dummy_points.rb

@@ -1,20 +1,22 @@
+# frozen_string_literal: true
+
 # Constants used in the write tests
 #
 TAGS    = { gt1: 'gv1', gt2: 'gv2' }.freeze
 
-POINT   = { path:   'test.metric',
-            value:  123_456,
-            ts:     1_469_987_572,
+POINT   = { path: 'test.metric',
+            value: 123_456,
+            ts: 1_469_987_572,
             source: 'testhost',
-            tags:   { t1: 'v1', t2: 'v2' } }.freeze
+            tags: { t1: 'v1', t2: 'v2' } }.freeze
 
 POINT_L = 'test.metric 123456 1469987572 source=testhost t1="v1" ' \
-          't2="v2"'.freeze
+          't2="v2"'
 
 POINT_A = [POINT,
            POINT.dup.update(ts: 1_469_987_588, value: 54_321)].freeze
 
-POINTS  = [POINT.dup, { path:   'test.other_metric',
-                        value:  89,
-                        ts:     1_469_987_572,
+POINTS  = [POINT.dup, { path: 'test.other_metric',
+                        value: 89,
+                        ts: 1_469_987_572,
                         source: 'otherhost' }].freeze

data/spec/wavefront-sdk/savedsearch_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/general'

data/spec/wavefront-sdk/search_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 
@@ -47,7 +48,7 @@ class WavefrontSearchTest < WavefrontTestBase
 
     assert_equal({ limit: 10,
                    offset: 0,
-                   query:  [
+                   query: [
                      { key: 'k1', value: 'v1', matchingMethod: 'EXACT' },
                      { key: 'k2', value: 'v2', matchingMethod: 'CONTAINS' }
                    ],
@@ -72,10 +73,10 @@ class WavefrontSearchTest < WavefrontTestBase
   def payload
     { limit: 10,
       offset: 0,
-      query: [{ key:            'name',
-                value:          'Wavefront',
+      query: [{ key: 'name',
+                value: 'Wavefront',
                 matchingMethod: 'CONTAINS' }],
-      sort: { field:     'string',
+      sort: { field: 'string',
               ascending: true } }
   end
 end

data/spec/wavefront-sdk/settings_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 

data/spec/wavefront-sdk/source_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/general'
@@ -41,8 +42,8 @@ class WavefrontSourceTest < WavefrontTestBase
   end
 
   def payload
-    { sourceName:  'source.name',
-      tags:        { sourceTag1: true },
+    { sourceName: 'source.name',
+      tags: { sourceTag1: true },
       description: 'Source Description' }
   end
 end

data/spec/wavefront-sdk/stdlib/array_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../../spec_helper'
 require_relative '../../../lib/wavefront-sdk/stdlib/array'

data/spec/wavefront-sdk/stdlib/hash_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../../spec_helper'
 require_relative '../../../lib/wavefront-sdk/stdlib/hash'

data/spec/wavefront-sdk/stdlib/string_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../../spec_helper'
 require_relative '../../../lib/wavefront-sdk/stdlib/string'

data/spec/wavefront-sdk/support/mixins_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../../spec_helper'
 require_relative '../../../lib/wavefront-sdk/support/mixins'

data/spec/wavefront-sdk/support/parse_time_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../../spec_helper'
 require_relative '../../../lib/wavefront-sdk/support/parse_time'
@@ -8,7 +9,6 @@ TSM = 1_517_151_869_523
 
 # Test parse_time class
 #
-# rubocop:disable Style/DateTime
 class WavefrontParseTimeTest < MiniTest::Test
   attr_reader :pts, :ptm
 
@@ -64,4 +64,3 @@ class WavefrontParseTimeTest < MiniTest::Test
     assert_kind_of(Numeric, ptm.parse!)
   end
 end
-# rubocop:enable Style/DateTime

data/spec/wavefront-sdk/user_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/general'

data/spec/wavefront-sdk/usergroup_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/general'
@@ -80,7 +81,7 @@ class WavefrontUserGroupTest < WavefrontTestBase
   end
 
   def payload
-    { name:        'test group',
+    { name: 'test group',
       permissions: %w[alerts_management dashboard_management
                       events_management] }
   end

data/spec/wavefront-sdk/validators_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'date'
 require_relative '../spec_helper'
@@ -52,14 +53,12 @@ class WavefrontValidatorsTest < MiniTest::Test
     good_and_bad('wf_value?', 'InvalidMetricValue', good, bad)
   end
 
-  # rubocop:disable Style/DateTime
   def test_wf_ts?
     good = [Time.now, Date.today, DateTime.now]
     bad  = ['2017-03-25 23:52:22 +0000', 1_490_485_946,
             '#<Date: 2017-03-25 ((2457838j,0s,0n),+0s,2299161j)>']
     good_and_bad('wf_ts?', 'InvalidTimestamp', good, bad)
   end
-  # rubocop:enable Style/DateTime
 
   def test_wf_ms_ts?
     good = [Time.now.to_i * 1000]

data/spec/wavefront-sdk/webhook_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/general'
@@ -27,12 +28,12 @@ class WavefrontWebhookTest < WavefrontTestBase
   end
 
   def payload
-    { description:       'WebHook Description',
-      template:          'POST Body -- Mustache syntax',
-      title:             'WebHook Title',
-      triggers:          %w[ALERT_OPENED],
-      recipient:         'http://example.com',
+    { description: 'WebHook Description',
+      template: 'POST Body -- Mustache syntax',
+      title: 'WebHook Title',
+      triggers: %w[ALERT_OPENED],
+      recipient: 'http://example.com',
       customHttpHeaders: {},
-      contentType:       'text/plain' }
+      contentType: 'text/plain' }
   end
 end

data/spec/wavefront-sdk/write_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../support/mocket'
@@ -108,56 +109,75 @@ class WavefrontWriteTest < MiniTest::Test
     end
   end
 
-  def test_point_array
-    p1 = POINT.dup
-    assert_equal(['test.metric', 123_456, 1_469_987_572, 'testhost',
-                  't1="v1" t2="v2"', nil], wf.point_array(p1))
+  def test_point_hash_all_values
+    point = POINT.dup
 
-    p2 = POINT.dup.tap { |p| p.delete(:point) }
-    assert_raises(StandardError) { wf.point_arrayt(p2) }
+    assert_equal({ path: 'test.metric',
+                   value: 123_456,
+                   ts: 1_469_987_572,
+                   source: 'testhost',
+                   tags: 't1="v1" t2="v2"',
+                   opttags: nil }, wf.point_hash(point))
+  end
+
+  def test_point_hash_missing_timestamp
+    point = POINT.dup.tap { |p| p.delete(:ts) }
 
-    p3 = POINT.dup.tap { |p| p.delete(:value) }
-    assert_raises(StandardError) { wf.point_arrayt(p3) }
+    assert_equal({ path: 'test.metric',
+                   value: 123_456,
+                   ts: nil,
+                   source: 'testhost',
+                   tags: 't1="v1" t2="v2"',
+                   opttags: nil }, wf.point_hash(point))
+  end
 
-    p4 = POINT.dup.tap { |p| p.delete(:ts) }
-    assert_equal(['test.metric', 123_456, nil, 'testhost',
-                  't1="v1" t2="v2"', nil], wf.point_array(p4))
+  def test_point_hash_missing_tags
+    point = POINT.dup.tap { |p| p.delete(:tags) }
 
-    p5 = POINT.dup.tap { |p| p.delete(:tags) }
-    assert_equal(['test.metric', 123_456, 1_469_987_572, 'testhost',
-                  nil, nil], wf.point_array(p5))
+    assert_equal({ path: 'test.metric',
+                   value: 123_456,
+                   ts: 1_469_987_572,
+                   source: 'testhost',
+                   tags: nil,
+                   opttags: nil }, wf.point_hash(point))
   end
 
   def test_hash_to_wf
     assert_equal(wf.hash_to_wf(POINT),
                  'test.metric 123456 1469987572 ' \
                  'source=testhost t1="v1" t2="v2"')
+  end
+
+  def test_hash_to_wf_tags_via_options
     assert_equal(wf_tags.hash_to_wf(POINT),
                  'test.metric 123456 1469987572 ' \
                  'source=testhost t1="v1" t2="v2" ' \
                  'gt1="gv1" gt2="gv2"')
+  end
 
-    p1 = POINT.dup
-    p1.delete(:ts)
-    assert_equal(wf.hash_to_wf(p1),
+  def test_hash_to_wf_missing_timestamp
+    point = POINT.dup.tap { |p| p.delete(:ts) }
+    assert_equal(wf.hash_to_wf(point),
                  'test.metric 123456 source=testhost t1="v1" t2="v2"')
+  end
 
-    p2 = POINT.dup
-    p2.delete(:tags)
-    assert_equal(wf.hash_to_wf(p2),
+  def test_hash_to_wf_missing_tags
+    point = POINT.dup.tap { |p| p.delete(:tags) }
+    assert_equal(wf.hash_to_wf(point),
                  'test.metric 123456 1469987572 source=testhost')
+  end
 
-    %i[value path].each do |k|
-      p3 = POINT.dup
-      p3.delete(k)
-
-      assert_raises(Wavefront::Exception::InvalidPoint) do
-        wf.hash_to_wf(p3)
-      end
+  def test_hash_to_wf_missing_value
+    point = POINT.dup.tap { |p| p.delete(:value) }
+    assert_raises(Wavefront::Exception::InvalidMetricValue) do
+      wf.hash_to_wf(point)
+    end
+  end
 
-      assert_raises(Wavefront::Exception::InvalidPoint) do
-        wf_tags.hash_to_wf(p3)
-      end
+  def test_hash_to_wf_missing_path
+    point = POINT.dup.tap { |p| p.delete(:path) }
+    assert_raises(Wavefront::Exception::InvalidMetricName) do
+      wf.hash_to_wf(point)
     end
   end
 end

data/spec/wavefront-sdk/writers/api_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../../spec_helper'
 require_relative '../resources/dummy_points'

data/spec/wavefront-sdk/writers/core_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'logger'
 require_relative '../../spec_helper'

data/spec/wavefront-sdk/writers/http_spec.rb

@@ -1,10 +1,11 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../../spec_helper'
 require_relative '../resources/dummy_points'
 require_relative '../../../lib/wavefront-sdk/write'
 
-BODY = 'test.metric 123456 1469987572 source=testhost t1="v1" t2="v2"'.freeze
+BODY = 'test.metric 123456 1469987572 source=testhost t1="v1" t2="v2"'
 
 # Test HTTP transport
 #

data/spec/wavefront-sdk/writers/socket_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'webmock/minitest'
 require 'spy'

data/spec/wavefront-sdk/writers/summary_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../../../lib/wavefront-sdk/writers/summary'
 require_relative '../../spec_helper'

data/wavefront-sdk.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pathname'
 require 'date'
 require_relative 'lib/wavefront-sdk/defs/version'
@@ -27,8 +29,8 @@ Gem::Specification.new do |gem|
 
   gem.add_development_dependency 'minitest', '~> 5.11'
   gem.add_development_dependency 'rake', '~> 12.3'
-  gem.add_development_dependency 'rubocop', '~> 0.54.0'
-  gem.add_development_dependency 'simplecov', '~> 0.16.0'
+  gem.add_development_dependency 'rubocop', '~> 0.74'
+  gem.add_development_dependency 'simplecov', '~> 0.16'
   gem.add_development_dependency 'spy', '~> 1.0.0'
   gem.add_development_dependency 'webmock', '~> 3.7'
   gem.add_development_dependency 'yard', '~> 0.9'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: wavefront-sdk
 version: !ruby/object:Gem::Version
-  version: 3.3.3
+  version: 3.3.4
 platform: ruby
 authors:
 - Robert Fisher
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-10 00:00:00.000000000 Z
+date: 2019-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -100,28 +100,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.54.0
+        version: '0.74'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.54.0
+        version: '0.74'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.16.0
+        version: '0.16'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.16.0
+        version: '0.16'
 - !ruby/object:Gem::Dependency
   name: spy
   requirement: !ruby/object:Gem::Requirement