wavefront-sdk 3.3.3 → 3.3.4

data/lib/wavefront-sdk/writers/summary.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Wavefront
   module Writer
     #

data/lib/wavefront-sdk/writers/unix.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'socket'
 require_relative 'core'
 
@@ -20,13 +22,7 @@ module Wavefront
         end
 
         logger.log("Connecting to #{creds[:socket]}.", :debug)
-
-        begin
-          @conn = UNIXSocket.new(creds[:socket])
-        rescue StandardError => e
-          logger.log(e, :error)
-          raise Wavefront::Exception::InvalidEndpoint
-        end
+        open_socket(creds[:socket])
       end
 
       def close
@@ -45,6 +41,13 @@ module Wavefront
 
       private
 
+      def open_socket(socket)
+        @conn = UNIXSocket.new(socket)
+      rescue StandardError => e
+        logger.log(e, :error)
+        raise Wavefront::Exception::InvalidEndpoint
+      end
+
       # @param point [String] point or points in native Wavefront
       # format.
       #

data/lib/wavefront_sdk.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 # Automatically load all SDK classes.
 #
 require 'pathname'
 
-libdir = Pathname.new(__FILE__).dirname + 'wavefront-sdk'
+libdir = Pathname.new(__dir__) + 'wavefront-sdk'
 
 libdir.children.select { |f| f.extname == '.rb' }.each do |f|
   require_relative f

data/spec/.rubocop.yml

@@ -1,17 +1,13 @@
-AllCops:
-  TargetRubyVersion: 2.2
-#
-#
-# Allow long blocks of tests
-#
-Metrics/BlockLength:
-  Max: 120
-
-Metrics/MethodLength:
-  Max: 80
-
+# Offense count: 64
 Metrics/AbcSize:
-  Max: 80
+  Max: 64
 
+# Offense count: 5
+# Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 300
+  Max: 279
+
+# Offense count: 46
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/MethodLength:
+  Max: 39

data/spec/constants.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 # rubocop:disable Style/MutableConstant
 CREDS = { endpoint: 'test.example.com',
-          token:    '0123456789-ABCDEF' }
+          token: '0123456789-ABCDEF' }
 # rubocop:enable Style/MutableConstant
 
 W_CREDS = { proxy: 'wavefront', port: 2878 }.freeze
@@ -15,16 +17,16 @@ JSON_POST_HEADERS = {
 
 DUMMY_RESPONSE = '{"status":{"result":"OK","message":"","code":200},' \
                  '"response":{"items":[{"name":"test data"}],"offset":0,' \
-                 '"limit":100,"totalItems":3,"moreItems":false}}'.freeze
+                 '"limit":100,"totalItems":3,"moreItems":false}}'
 
 RESOURCE_DIR = (Pathname.new(__FILE__).dirname +
                 'wavefront-sdk' + 'resources').freeze
 
-U_ACL_1 = 'someone@example.com'.freeze
-U_ACL_2 = 'other@elsewhere.com'.freeze
-GRP_ACL = 'f8dc0c14-91a0-4ca9-8a2a-7d47f4db4672'.freeze
+U_ACL_1 = 'someone@example.com'
+U_ACL_2 = 'other@elsewhere.com'
+GRP_ACL = 'f8dc0c14-91a0-4ca9-8a2a-7d47f4db4672'
 
-DEFAULT_HEADERS = { 'Accept':          /.*/,
+DEFAULT_HEADERS = { 'Accept': /.*/,
                     'Accept-Encoding': /.*/,
-                    'Authorization':  'Bearer 0123456789-ABCDEF',
-                    'User-Agent':     /wavefront-sdk \d+\.\d+\.\d+/ }.freeze
+                    'Authorization': 'Bearer 0123456789-ABCDEF',
+                    'User-Agent': /wavefront-sdk \d+\.\d+\.\d+/ }.freeze

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'simplecov'
 SimpleCov.start { add_filter '/spec/' }
 require 'minitest/autorun'

data/spec/support/bad_mocket.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A mock socket which says things went wrong.
 #
 class BadMocket < Mocket

data/spec/support/hash.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Extensions to stdlib
 #
 class Hash

data/spec/support/minitest_assertions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Minitest
   #
   # Some custom Minitest assertions to simplify testing

data/spec/support/mocket.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A mock socket
 #
 class Mocket

data/spec/test_mixins/acl.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module WavefrontTest
   #
   # require and include this module to get ACL tests

data/spec/test_mixins/general.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module WavefrontTest
   module List
     def test_list

data/spec/test_mixins/tag.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module WavefrontTest
   #
   # require and include this module to get tag tests

data/spec/test_mixins/update_keys.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module WavefrontTest
   #
   # include this into any class which has update keys

data/spec/wavefront-sdk/alert_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/acl'
@@ -125,19 +126,19 @@ class WavefrontAlertTest < WavefrontTestBase
   end
 
   def payload
-    { name:               'SDK test alert',
-      target:             'user@example.com',
-      condition:          'ts("app.errors") > 0',
-      displayExpression:  'ts("app.errors")',
-      minutes:             5,
+    { name: 'SDK test alert',
+      target: 'user@example.com',
+      condition: 'ts("app.errors") > 0',
+      displayExpression: 'ts("app.errors")',
+      minutes: 5,
       resolveAfterMinutes: 5,
-      severity:            'INFO' }
+      severity: 'INFO' }
   end
 
   def search_payload(value)
-    { limit:  999,
+    { limit: 999,
       offset: 0,
-      query:  [{ key: 'status', value: value, matchingMethod: 'EXACT' }],
-      sort:   { field: 'status', ascending: true } }
+      query: [{ key: 'status', value: value, matchingMethod: 'EXACT' }],
+      sort: { field: 'status', ascending: true } }
   end
 end

data/spec/wavefront-sdk/api_mixins/user_mixins_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../../spec_helper'
 require_relative '../../../lib/wavefront-sdk/api_mixins/user'

data/spec/wavefront-sdk/apitoken_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/general'

data/spec/wavefront-sdk/cloudintegration_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/general'
@@ -51,7 +52,7 @@ class WavefrontCloudIntegrationTest < WavefrontTestBase
       service: 'CLOUDWATCH',
       cloudWatch: {
         baseCredentials: {
-          roleArn:    'arn:aws:iam::<accountid>:role/<rolename>',
+          roleArn: 'arn:aws:iam::<accountid>:role/<rolename>',
           externalId: 'wave123'
         }
       },

data/spec/wavefront-sdk/core/api_caller_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../../spec_helper'
 require_relative '../../../lib/wavefront-sdk/core/api_caller'

data/spec/wavefront-sdk/core/api_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../../spec_helper'
 require_relative '../../../lib/wavefront-sdk/core/api'

data/spec/wavefront-sdk/core/logger_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'logger'
 require_relative '../../spec_helper'

data/spec/wavefront-sdk/core/response_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'json'
 require_relative '../../spec_helper'
@@ -7,13 +8,13 @@ require_relative '../../../lib/wavefront-sdk/core/response'
 
 GOOD_RESP = '{"status":{"result":"OK","message":"","code":200},' \
              '"response":{"items":[{"name":"test agent"}],"offset":0,' \
-             '"limit":100,"totalItems":3,"moreItems":false}}'.freeze
+             '"limit":100,"totalItems":3,"moreItems":false}}'
 
 BAD_RESP = "error='not_found'
 message='resource cannot be found'
-trackingId=eca22ddc-848b-4e67-876a-366145c8a759".freeze
+trackingId=eca22ddc-848b-4e67-876a-366145c8a759"
 
-ERR_RESP = { error:      'HTTP 415 Unsupported Media Type',
+ERR_RESP = { error: 'HTTP 415 Unsupported Media Type',
              trackingId: 'ce231eaf-8d0e-4138-a82d-12725376a3b0' }.to_json
 
 # Unit tests for Response class. Also indirectly tests the Status

data/spec/wavefront-sdk/credentials_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'pathname'
 require_relative '../spec_helper'

data/spec/wavefront-sdk/dashboard_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/acl'

data/spec/wavefront-sdk/derivedmetric_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/general'

data/spec/wavefront-sdk/distribution_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../../lib/wavefront-sdk/distribution'
@@ -66,10 +67,10 @@ class WavefrontDistributionTest < MiniTest::Test
 
   def distribution
     { interval: :m,
-      path:     'test.distribution',
-      value:    [[5, 11], [15, 2.533], [8, -15], [12, 1e6]],
-      ts:       1_538_865_613,
-      source:   'minitest',
-      tags:     { tag1: 'val1', tag2: 'val2' } }
+      path: 'test.distribution',
+      value: [[5, 11], [15, 2.533], [8, -15], [12, 1e6]],
+      ts: 1_538_865_613,
+      source: 'minitest',
+      tags: { tag1: 'val1', tag2: 'val2' } }
   end
 end

data/spec/wavefront-sdk/event_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/general'
@@ -57,16 +58,16 @@ class WavefrontEventTest < WavefrontTestBase
   end
 
   def payload
-    { name:        'test_event',
+    { name: 'test_event',
       annotations: {
         severity: 'info',
-        type:     'SDK test event',
-        details:  'an imaginary event to test the SDK'
+        type: 'SDK test event',
+        details: 'an imaginary event to test the SDK'
       },
-      hosts:       %w[host1 host2],
-      startTime:   1_493_385_089_000,
-      endTime:     1_493_385_345_678,
-      tags:        %w[tag1 tag2],
+      hosts: %w[host1 host2],
+      startTime: 1_493_385_089_000,
+      endTime: 1_493_385_345_678,
+      tags: %w[tag1 tag2],
       isEphemeral: false }
   end
 end

data/spec/wavefront-sdk/externallink_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/general'
@@ -23,11 +24,11 @@ class WavefrontExternalLinkTest < WavefrontTestBase
   end
 
   def payload
-    [{ name:        'test link',
-       template:    'https://example.com/link/{{value}}',
+    [{ name: 'test link',
+       template: 'https://example.com/link/{{value}}',
        description: 'an imaginary link for unit testing purposes' },
-     { name:        'test link',
-       template:    'https://example.com/link/{{value}}' }]
+     { name: 'test link',
+       template: 'https://example.com/link/{{value}}' }]
   end
 
   def api_class

data/spec/wavefront-sdk/integration_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/general'

data/spec/wavefront-sdk/maintenancewindow_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 require_relative '../test_mixins/general'
@@ -23,11 +24,11 @@ class WavefrontMaintenanceWindowTest < WavefrontTestBase
   end
 
   def payload
-    { reason:   'testing SDK',
-      title:    'test window',
-      start:    Time.now.to_i,
-      end:      Time.now.to_i + 600,
-      tags:     %w[testtag1 testtag2],
+    { reason: 'testing SDK',
+      title: 'test window',
+      start: Time.now.to_i,
+      end: Time.now.to_i + 600,
+      tags: %w[testtag1 testtag2],
       hostTags: %w[hosttag1 hosttag2] }
   end
 end

data/spec/wavefront-sdk/message_spec.rb

@@ -1,8 +1,9 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require_relative '../spec_helper'
 
-MESSAGE = 'CLUSTER::IHjNaHM9'.freeze
+MESSAGE = 'CLUSTER::IHjNaHM9'
 
 # Unit tests for Message class
 #

data/spec/wavefront-sdk/metric_helper_spec.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'minitest/autorun'
 require_relative '../spec_helper'
@@ -91,9 +92,9 @@ class WavefrontMetricHelperTest < MiniTest::Test
   end
 
   def test_counters_to_wf
-    input = { ['test.counter1', nil]     => 7,
+    input = { ['test.counter1', nil] => 7,
               ['test.counter1', WH_TAGS] => 8,
-              ['test.counter2', nil]     => 9 }
+              ['test.counter2', nil] => 9 }
 
     out = wf.counters_to_wf(input)
     assert_instance_of(Array, out)
@@ -109,7 +110,7 @@ class WavefrontMetricHelperTest < MiniTest::Test
   def test_dists_to_wf
     input = { ['test.dist1', :m, nil] => [10, 10, 11, 12],
               ['test.dist1', :m, WH_TAGS] => [123, 456, 789],
-              ['test.dist1', :h, nil]     => [6, 6, 7, 4, 6, 4, 8] }
+              ['test.dist1', :h, nil] => [6, 6, 7, 4, 6, 4, 8] }
 
     out = wfd.dists_to_wf(input)
     assert_instance_of(Array, out)
@@ -161,9 +162,9 @@ class WavefrontMetricHelperTest < MiniTest::Test
   def test_flush_counters
     assert_nil(wf.flush_counters([]))
 
-    input = { ['test.counter1', nil]     => 7,
+    input = { ['test.counter1', nil] => 7,
               ['test.counter1', WH_TAGS] => 8,
-              ['test.counter2', nil]     => 9 }
+              ['test.counter2', nil] => 9 }
 
     mocket = Mocket.new
     spy = Spy.on(wf.writer.writer, :write).and_return(mocket)
@@ -189,9 +190,9 @@ class WavefrontMetricHelperTest < MiniTest::Test
   end
 
   def test_flush_counters_fail
-    input = { ['test.counter1', nil]     => 7,
+    input = { ['test.counter1', nil] => 7,
               ['test.counter1', WH_TAGS] => 8,
-              ['test.counter2', nil]     => 9 }
+              ['test.counter2', nil] => 9 }
 
     mocket = BadMocket.new
     spy = Spy.on(wf.writer.writer, :write).and_return(mocket)
@@ -222,7 +223,7 @@ class WavefrontMetricHelperTest < MiniTest::Test
 
     input = { ['test.dist1', :m, nil] => [10, 10, 11, 12],
               ['test.dist1', :m, WH_TAGS] => [123, 456, 789],
-              ['test.dist1', :h, nil]     => [6, 6, 7, 4, 6, 4, 8] }
+              ['test.dist1', :h, nil] => [6, 6, 7, 4, 6, 4, 8] }
 
     mocket = Mocket.new
     spy = Spy.on(wfd.dist_writer.writer, :write).and_return(mocket)
@@ -251,7 +252,7 @@ class WavefrontMetricHelperTest < MiniTest::Test
   def test_flush_dists_fail
     input = { ['test.dist1', :m, nil] => [10, 10, 11, 12],
               ['test.dist1', :m, WH_TAGS] => [123, 456, 789],
-              ['test.dist1', :h, nil]     => [6, 6, 7, 4, 6, 4, 8] }
+              ['test.dist1', :h, nil] => [6, 6, 7, 4, 6, 4, 8] }
 
     mocket = BadMocket.new
     spy = Spy.on(wfd.dist_writer.writer, :write).and_return(mocket)