watir 7.0.0 → 7.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aaa0e3a2614b0cdae93ebbae36c1f1c4ae58f55fd7d79a1b333144969354346f
-  data.tar.gz: 349abd59394dcd77d9f4aaf2050ab75dd613872c7aff3de96f8acc13cd797213
+  metadata.gz: 635faa9aa111937b2d90f6ab1585a148d8eea5cf375b4a1dc4d3e164b3e24c38
+  data.tar.gz: 31bb99fbba606a62c369c4a89b8c12764e00feff89048179e5958bf4b0abca3d
 SHA512:
-  metadata.gz: 2abac0e5c8e81acf27b5edefd507c9056bca728f2ccab2aa858176287cf7e544a6961ab7bcc0edf7a01d78735038fedf77cbb70798aacdd490be4fc987f88602
-  data.tar.gz: a32076a9af54abfbcc470bb96095aa1441f812640029fa492233f7d7cbc5f9fb327de0397417103519cf674e7c03a91de85b749bf87e6cc8483cbf16bcefa3e7
+  metadata.gz: 131f2cccc8debc1afd14462f90fbafff4d5f349b4caa193247f2adf8efa6f91e03c8218ff8bec23a86d8c4c8e4de18b1c63b38f6cc5c9c878420a9bc01d816f3
+  data.tar.gz: c4f5abb5e301fcee62f25a091f299933f2c10e1b703a3378fcd6d850012d989f3e5ac2f9d8fcec170fee44f97ec4758c5894d85e7a7a62d3efaf2f609a733676

data/.github/workflows/chrome.yml

@@ -1,6 +1,7 @@
 name: Chrome Tests
 
 on:
+  - workflow_dispatch
   - push
   - pull_request
 
@@ -12,23 +13,35 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        ruby: [ 2.6, 3.0 ]
+        ruby: [ 2.7, 3.2 ]
     steps:
-      - uses: actions/checkout@v2
-      - uses: ./.github/actions/setup-linux
-        if:  matrix.os == 'ubuntu-latest'
-      - uses: ./.github/actions/install-chrome
-        if:  matrix.os == 'ubuntu-latest'
-      - run: |
-          echo "COVERAGE=true" >> $GITHUB_ENV
-        if: |
-          matrix.os == 'ubuntu-latest' ||
-          matrix.os == 'macos-latest'
-      - uses: ruby/setup-ruby@v1
+      - name: Checkout source tree
+        uses: actions/checkout@v2
+      - name: Setup Fluxbox
+        if: matrix.os == 'ubuntu-latest'
+        run: sudo apt-get -y install fluxbox
+      - name: Start XVFB
+        if: matrix.os == 'ubuntu-latest'
+        run: Xvfb :99 -screen 0 1920x1280x24 > /dev/null 2>&1 &
+      - name: Start Fluxbox
+        if: matrix.os == 'ubuntu-latest'
+        run: fluxbox -display :99 &
+      - name: Set Windows resolution
+        if: matrix.os == 'windows-latest'
+        run: Set-DisplayResolution -Width 1920 -Height 1080 -Force
+      - name: Set Mac resolution
+        if: ${{ matrix.os == 'macos-latest' }}
+        run: |
+          system_profiler SPDisplaysDataType | grep Resolution
+          "/Library/Application Support/VMware Tools/vmware-resolutionSet" 2560 1440
+          system_profiler SPDisplaysDataType | grep Resolution
+      - name: Install Ruby
+        uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
-      - run: bundle install
-      - run: |
-          bundle exec rake spec:chrome
+      - name: Install gems
+        run: bundle install
+      - name: Run tests
+        run: bundle exec rake spec:chrome
         env:
-          DISPLAY: :99
+          DISPLAY: :99.0

data/.github/workflows/edge.yml

@@ -1,6 +1,7 @@
 name: Edge Tests
 
 on:
+  - workflow_dispatch
   - push
   - pull_request
 
@@ -12,17 +13,24 @@ jobs:
       fail-fast: false
       matrix:
         os: [macos-latest, windows-latest]
-        ruby: [ 2.6, 3.0 ]
+        ruby: [ 2.7, 3.2 ]
     steps:
-      - uses: actions/checkout@v2
-      - run: |
-          echo "COVERAGE=true" >> $GITHUB_ENV
-        if: matrix.os == 'macos-latest'
-      - uses: ruby/setup-ruby@v1
+      - name: Checkout source tree
+        uses: actions/checkout@v2
+      - name: Set Windows resolution
+        if: matrix.os == 'windows-latest'
+        run: Set-DisplayResolution -Width 1920 -Height 1080 -Force
+      - name: Set Mac resolution
+        if: ${{ matrix.os == 'macos-latest' }}
+        run: |
+          system_profiler SPDisplaysDataType | grep Resolution
+          "/Library/Application Support/VMware Tools/vmware-resolutionSet" 2560 1440
+          system_profiler SPDisplaysDataType | grep Resolution
+      - name: Install Ruby
+        uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
-      - run: bundle install
-      - run: |
-          bundle exec rake spec:edge
-        env:
-          DISPLAY: :99
+      - name: Install gems
+        run: bundle install
+      - name: Run tests
+        run: bundle exec rake spec:chrome

data/.github/workflows/firefox.yml

@@ -1,6 +1,7 @@
 name: Firefox Tests
 
 on:
+  - workflow_dispatch
   - push
   - pull_request
 
@@ -12,24 +13,35 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        ruby: [ 2.6, 3.0 ]
+        ruby: [ 2.7, 3.2 ]
     steps:
-      - uses: actions/checkout@v2
-      - uses: ./.github/actions/setup-linux
-        if:  matrix.os == 'ubuntu-latest'
-      - uses: browser-actions/setup-firefox@latest
-        with:
-          firefox-version: '93.0'
-      - run: |
-          echo "COVERAGE=true" >> $GITHUB_ENV
-        if: |
-          matrix.os == 'ubuntu-latest' ||
-          matrix.os == 'macos-latest'
-      - uses: ruby/setup-ruby@v1
+      - name: Checkout source tree
+        uses: actions/checkout@v2
+      - name: Setup Fluxbox
+        if: matrix.os == 'ubuntu-latest'
+        run: sudo apt-get -y install fluxbox
+      - name: Start XVFB
+        if: matrix.os == 'ubuntu-latest'
+        run: Xvfb :99 -screen 0 1920x1280x24 > /dev/null 2>&1 &
+      - name: Start Fluxbox
+        if: matrix.os == 'ubuntu-latest'
+        run: fluxbox -display :99 &
+      - name: Set Windows resolution
+        if: matrix.os == 'windows-latest'
+        run: Set-DisplayResolution -Width 1920 -Height 1080 -Force
+      - name: Set Mac resolution
+        if: ${{ matrix.os == 'macos-latest' }}
+        run: |
+          system_profiler SPDisplaysDataType | grep Resolution
+          "/Library/Application Support/VMware Tools/vmware-resolutionSet" 2560 1440
+          system_profiler SPDisplaysDataType | grep Resolution
+      - name: Install Ruby
+        uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
-      - run: bundle install
-      - run: |
-          bundle exec rake spec:firefox
+      - name: Install gems
+        run: bundle install
+      - name: Run tests
+        run: bundle exec rake spec:chrome
         env:
           DISPLAY: :99

data/.github/workflows/ie.yml

@@ -1,6 +1,7 @@
 name: IE Tests
 
 on:
+  - workflow_dispatch
   - push
   - pull_request
 
@@ -11,14 +12,19 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [ 2.6, 3.0 ]
+        ruby: [ 2.7, 3.2 ]
     steps:
-      - uses: actions/checkout@v2
-      - uses: ruby/setup-ruby@v1
+      - name: Checkout source tree
+        uses: actions/checkout@v2
+      - name: Set Windows resolution
+        run: Set-DisplayResolution -Width 1920 -Height 1080 -Force
+      - name: Install Ruby
+        uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
-      - run: bundle install
-      - run: |
-          bundle exec rake spec:ie
+      - name: Install gems
+        run: bundle install
+      - name: Run tests
+        run: bundle exec rake spec:ie
         env:
-          DISPLAY: :99
+          GITHUB_TOKEN: ${{ github.token }}

data/.github/workflows/safari.yml

@@ -1,6 +1,7 @@
 name: Safari Tests
 
 on:
+  - workflow_dispatch
   - push
   - pull_request
 
@@ -11,17 +12,27 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [ 2.6, 3.0 ]
+        ruby: [ 2.7, 3.2 ]
     steps:
-      - uses: actions/checkout@v2
-      - uses: ./.github/actions/enable-safari
-      - run: |
-          echo "COVERAGE=true" >> $GITHUB_ENV
-      - uses: ruby/setup-ruby@v1
+      - name: Checkout source tree
+        uses: actions/checkout@v2
+      - name: Set Mac resolution
+        run: |
+          system_profiler SPDisplaysDataType | grep Resolution
+          "/Library/Application Support/VMware Tools/vmware-resolutionSet" 2560 1440
+          system_profiler SPDisplaysDataType | grep Resolution
+      - name: Install Ruby
+        uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
-      - run: bundle install
-      - run: |
-          bundle exec rake spec:safari
-        env:
-          DISPLAY: :99
+      - name: Install gems
+        run: bundle install
+      - name: Configure safaridriver
+        run: |
+          defaults write com.apple.Safari IncludeDevelopMenu YES
+          defaults write com.apple.Safari AllowRemoteAutomation 1
+          sudo safaridriver --enable
+          safaridriver --version
+          safaridriver -p 0 &
+      - name: Run tests
+        run: bundle exec rake spec:safari

data/.github/workflows/unit.yml

@@ -1,6 +1,7 @@
 name: Unit Tests
 
 on:
+  - workflow_dispatch
   - push
   - pull_request
 
@@ -9,16 +10,22 @@ jobs:
     name: Yard Doctest
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: ruby/setup-ruby@v1
+      - name: Checkout source tree
+        uses: actions/checkout@v2
+      - name: Setup Fluxbox
+        run: sudo apt-get -y install fluxbox
+      - name: Start XVFB
+        run: Xvfb :99 -screen 0 1920x1280x24 > /dev/null 2>&1 &
+      - name: Start Fluxbox
+        run: fluxbox -display :99 &
+      - name: Install Ruby
+        uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.6
-      - run: bundle install
-      - uses: ./.github/actions/install-chrome
-      - uses: ./.github/actions/setup-linux
-      - run: |
-          bundle exec rake yard:doctest
-
+          ruby-version: 2.7
+      - name: Install gems
+        run: bundle install
+      - name: Run tests
+        run: bundle exec rake yard:doctest
 
   unit-test:
     name: Unit Tests
@@ -26,27 +33,28 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ['2.6', '2.7', '3.0']
+        ruby: ['2.7', '3.0', '3.1', '3.2', 'jruby-9.4.0.0', 'truffleruby-22.3.0']
     steps:
-      - uses: actions/checkout@v2
-      - uses: ruby/setup-ruby@v1
+      - name: Checkout source tree
+        uses: actions/checkout@v2
+      - name: Install Ruby
+        uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
-      - run: bundle install
-      - uses: ./.github/actions/install-chrome
-      - uses: ./.github/actions/setup-linux
-      - run: |
-          bundle exec rake spec:unit
-        env:
-          DISPLAY: :99
+      - name: Install gems
+        run: bundle install
+      - run: bundle exec rake spec:unit
 
   linter-test:
     name: Rubocop Tests
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: ruby/setup-ruby@v1
+      - name: Checkout source tree
+        uses: actions/checkout@v2
+      - name: Install Ruby
+        uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.6
-      - run: bundle install
+          ruby-version: 2.7
+      - name: Install gems
+        run: bundle install
       - run: bundle exec rubocop

data/.rubocop.yml

@@ -1,23 +1,20 @@
 inherit_from: .rubocop_todo.yml
 
+require:
+  - rubocop-performance
+  - rubocop-rake
+  - rubocop-rspec
+
 AllCops:
-  TargetRubyVersion: 2.6.8
+  TargetRubyVersion: 2.7
   NewCops: enable
   Exclude:
     - 'lib/watir/elements/html_elements.rb'
     - 'lib/watir/elements/svg_elements.rb'
 
-Layout/LineLength:
-  Max: 120
-
 Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
 
-Lint/UnifiedInteger:
-  Exclude:
-  - 'lib/watir/locators/element/selector_builder.rb'
-
-# Default: 17
 Metrics/AbcSize:
   Max: 22
   Exclude:
@@ -28,7 +25,6 @@ Metrics/AbcSize:
 
 Metrics/BlockLength:
   Exclude:
-    - 'spec/**/*'
     - 'support/doctest_helper.rb'
     - 'watir.gemspec'
     - 'Rakefile'
@@ -46,8 +42,8 @@ Metrics/ClassLength:
     - 'lib/watir/elements/select.rb'
     - 'lib/watir/generator/base/spec_extractor.rb'
     - 'lib/watir/element_collection.rb'
+    - 'spec/**/*_spec.rb'
 
-# Default: 7
 Metrics/CyclomaticComplexity:
   Max: 9
   Exclude:
@@ -58,19 +54,42 @@ Metrics/MethodLength:
   Max: 18
   Exclude:
     - 'lib/watir/locators/element/selector_builder.rb'
-    - 'lib/watir/locators/element/selector_builder/xpath.rb'
     - 'lib/watir/locators/element/selector_builder/regexp_disassembler.rb'
 
-# Default: 8
+Metrics/ModuleLength:
+  Exclude:
+    - 'spec/**/*'
+
 Metrics/PerceivedComplexity:
   Max: 10
 
+RSpec/AnyInstance:
+  Enabled: false
+
+RSpec/BeforeAfterAll:
+  Enabled: false
+
+RSpec/ExampleLength:
+  Enabled: false
+
+RSpec/MultipleExpectations:
+  Enabled: false
+
+RSpec/MultipleMemoizedHelpers:
+  Exclude:
+    - 'spec/watirspec/capabilities_spec.rb'
+
+RSpec/NoExpectationExample:
+  Exclude:
+    - 'spec/watirspec/cookies_spec.rb'
+
 Style/BlockDelimiters:
   EnforcedStyle: braces_for_chaining
 
 Style/CommentedKeyword:
   Enabled: false
 
+# truthy is not true
 Style/DoubleNegation:
   Enabled: false
 
@@ -78,6 +97,7 @@ Style/GlobalVars:
   AllowedVariables:
     - $browser
 
+# Need to add new keys into hash during iteration
 Style/HashEachMethods:
   Enabled: false
 

data/.rubocop_todo.yml

@@ -1,36 +1,17 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-08-27 01:55:04 UTC using RuboCop version 0.89.1.
+# on 2022-12-31 19:29:43 UTC using RuboCop version 1.40.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 116
-Style/Documentation:
-  Enabled: false
-
-# Offense count: 11
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: annotated, template, unannotated
-Style/FormatStringToken:
+# Offense count: 1
+RSpec/PendingWithoutReason:
   Exclude:
-    - 'lib/watir/browser.rb'
-    - 'lib/watir/window.rb'
+    - 'spec/watirspec/browser_spec.rb'
 
-# Offense count: 229
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, always_true, never
-Style/FrozenStringLiteralComment:
+# Offense count: 114
+# Configuration parameters: AllowedConstants.
+Style/Documentation:
   Enabled: false
-
-# Remove for Watir 7
-Naming/FileName:
-  Exclude:
-    - 'lib/watir-webdriver.rb'
-
-# Fix in Watir 7
-Metrics/ParameterLists:
-  Exclude:
-    - 'lib/watir/wait.rb'

data/CHANGES.md

@@ -1,3 +1,36 @@
+### 7.2.2 (2023-01-03)
+
+* Fix bug with processing vendor name-spaced capabilities
+
+### 7.2.1 (2023-01-02)
+
+* Fix bug for building locators with JRuby
+* Fix bug for inferring internet explorer browser name from options
+
+### 7.2.0 (2022-12-24)
+
+* Implement Shadow DOM support (#953)
+* Implement existing `Scroll#by` with Selenium Actions Class instead of JavaScript
+* Implement `Scroll#from` to set origin points
+* Implement `Scroll#to(:viewport)` for elements using Selenium Actions Class
+* Fix bug for regex matching on single quotes (#957)
+* Fix bug for unexpected whitespace in classes (#956)
+* Fix bug for inferring Edge browser name from Capabilities parameter
+* Allow starting `Browser` with `Watir::Capabilities`
+* Allow starting `Browser` with just a `Hash` for generating a `Watir::Capabilities`
+* Have `Capabilities` use `:options` to generate Selenium `Options` instance
+* Deprecate allowing `:capabilities` argument in `Browser` constructor
+* Require Ruby 2.7 and Selenium 4.2
+
+### 7.1.0 (2021-11-15)
+
+* Add automatic scroll to `Element#click` with method parameters to ensure element is in viewport
+* Provide `:scroll_to` parameter for element methods implemented with `Actions` class (thanks osadasami #948, #949)
+* Allow `:scroll_to` parameter to accept `nil` argument to avoid automatic scrolling
+* Implement `Element#in_viewport?`
+* Fix bug where `Scroll#to` for `Browser` with `:center` argument did not scroll to center of page
+* Change `Element#obscured?` to only scroll when element out of viewport and then scroll to bottom instead of top
+
 ### 7.0.0 (2021-10-18)
 
 * Requires Selenium 4.0.0+

data/Gemfile

@@ -1,8 +1,13 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gem 'webidl', path: File.expand_path('../webidl') if ENV['LOCAL_WEBIDL']
 
-gem 'selenium-webdriver', path: File.expand_path('../selenium/build/rb') if ENV['LOCAL_SELENIUM']
+if ENV['LOCAL_SELENIUM']
+  ENV['RUBYOPT'] = '-I../selenium/bazel-bin/rb'
+  gem 'selenium-webdriver', path: File.expand_path('../selenium/rb')
+end
 
 gem 'ffi' if Gem.win_platform? # For selenium-webdriver on Windows
 

data/LICENSE

@@ -1,8 +1,8 @@
 (the MIT License)
 
 Copyright (c) 2009-2015 Jari Bakken
-Copyright (c) 2015-2021 Alex Rodionov, Titus Fortner
-Copyright (c) 2018-2021 Justin Ko
+Copyright (c) 2015-2023 Alex Rodionov, Titus Fortner
+Copyright (c) 2018-2023 Justin Ko
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -3,16 +3,19 @@
 Watir Powered By Selenium!
 
 [![Gem Version](https://badge.fury.io/rb/watir.svg)](http://badge.fury.io/rb/watir)
-[![All Tests](https://github.com/watir/watir/actions/workflows/tests.yml/badge.svg)](https://github.com/watir/watir/actions/workflows/tests.yml)
-[![Code Climate](https://codeclimate.com/github/watir/watir.svg)](https://codeclimate.com/github/watir/watir)
-[![Coverage Status](https://coveralls.io/repos/github/watir/watir/badge.svg?branch=main)](https://coveralls.io/github/watir/watir?branch=main)
+[![Chrome Tests](https://github.com/watir/watir/actions/workflows/chrome.yml/badge.svg)](https://github.com/watir/watir/actions/workflows/chrome.yml)
+[![Edge Tests](https://github.com/watir/watir/actions/workflows/edge.yml/badge.svg)](https://github.com/watir/watir/actions/workflows/edge.yml)
+[![Firefox Tests](https://github.com/watir/watir/actions/workflows/firefox.yml/badge.svg)](https://github.com/watir/watir/actions/workflows/firefox.yml)
+[![IE Tests](https://github.com/watir/watir/actions/workflows/ie.yml/badge.svg)](https://github.com/watir/watir/actions/workflows/ie.yml)
+[![Safari Tests](https://github.com/watir/watir/actions/workflows/safari.yml/badge.svg)](https://github.com/watir/watir/actions/workflows/safari.yml)
+[![Unit Tests](https://github.com/watir/watir/actions/workflows/unit.yml/badge.svg)](https://github.com/watir/watir/actions/workflows/unit.yml)
 
 ## Using Watir
 
 This README is for people interested in writing code for Watir or gems in the Watir ecosystem
 that leverage private-api Watir code.
 
-For our users, everything you'll need is on the [Watir website](http://watir.com): 
+For our users, everything you'll need is on the [Watir website](http://watir.com):
 examples, news, guides, additional resources, support information and more.
 
 ## Procedure for Patches/Pull Requests
@@ -30,7 +33,7 @@ examples, news, guides, additional resources, support information and more.
 
 ## Developing Extensions
 
-When developing a gem intended to be used with Watir, you can run your code with WatirSpec 
+When developing a gem intended to be used with Watir, you can run your code with WatirSpec
 to make sure that requiring your code does not break something else in Watir.
 
 First, add WatirSpec Rake tasks to your gem:
@@ -52,7 +55,7 @@ This command will walk you through how to customize your code.
 ## Automatic Element Generation
 
 The majority of element methods Watir provides is autogenerated from specifications.
-This is done by extracting the IDL parts from the spec and processing them with the 
+This is done by extracting the IDL parts from the spec and processing them with the
 [WebIDL gem](https://github.com/jarib/webidl).
 
 Generated elements are currently based on the following specifications:
@@ -61,6 +64,7 @@ Generated elements are currently based on the following specifications:
 * [SVG](https://www.w3.org/TR/2018/CR-SVG2-20180807/) (`lib/watir/elements/svg_elements.rb`)
 
 To run:
+
 ```bash
 $ bundle exec rake html:update
 $ bundle exec rake svg:update
@@ -70,7 +74,7 @@ $ bundle exec rake svg:update
 
 #### Github Actions
 
-Watir specs are run with [Github Actions](https://github.com/watir/watir/workflows).
+Watir specs are run with [Github Actions](https://github.com/watir/watir/tree/main/.github/workflows).
 
 Watir code is tested on Linux with latest versions of supported browsers and all active Ruby versions.
 
@@ -92,14 +96,14 @@ to ensure all paths in their code have tests associated with them.
 
 #### Rubocop
 
-Watir is using [Rubocop](https://github.com/rubocop-hq/rubocop) to ensure a consistent style across the
-code base. It is run with our minimum supported Ruby version (2.3) 
-We have some [established exceptions](https://github.com/watir/watir/blob/main/.rubocop.yml) 
+Watir is using [Rubocop](https://github.com/rubocop/rubocop) to ensure a consistent style across the
+code base. It is run with our minimum supported Ruby version (2.3)
+We have some established exceptions at `.rubocop.yml`
 that might need to be tweaked for new code submissions. This can be addressed in the PR as necessary.
 
 #### Statistics
 
-Element specs are run with 
+Element specs are run with
 [Selenium Statistics gem](https://github.com/titusfortner/selenium_statistics)
 to verify that changes to the code do not dramatically decrease the performance based
 on wire calls.