watir 6.14.0 → 6.15.0

data/spec/watirspec/elements/buttons_spec.rb

@@ -13,7 +13,7 @@ describe 'Buttons' do
 
   describe '#length' do
     it 'returns the number of buttons' do
-      expect(browser.buttons.length).to eq 9
+      expect(browser.buttons.length).to eq 10
     end
   end
 

data/spec/watirspec/elements/checkbox_spec.rb

@@ -11,6 +11,8 @@ describe 'CheckBox' do
     it 'returns true if the checkbox button exists' do
       expect(browser.checkbox(id: 'new_user_interests_books')).to exist
       expect(browser.checkbox(id: /new_user_interests_books/)).to exist
+      expect(browser.checkbox(label: 'Cars')).to exist
+      expect(browser.checkbox(label: /Cars/)).to exist
       expect(browser.checkbox(name: 'new_user_interests')).to exist
       expect(browser.checkbox(name: /new_user_interests/)).to exist
       expect(browser.checkbox(value: 'books')).to exist
@@ -70,21 +72,6 @@ describe 'CheckBox' do
   end
 
   # Attribute methods
-
-  describe '#class_name' do
-    it 'returns the class name if the checkbox exists and has an attribute' do
-      expect(browser.checkbox(id: 'new_user_interests_dancing').class_name).to eq 'fun'
-    end
-
-    it "returns an empty string if the checkbox exists and the attribute doesn't" do
-      expect(browser.checkbox(id: 'new_user_interests_books').class_name).to eq ''
-    end
-
-    it "raises UnknownObjectException if the checkbox doesn't exist" do
-      expect { browser.checkbox(id: 'no_such_id').class_name }.to raise_unknown_object_exception
-    end
-  end
-
   describe '#id' do
     it 'returns the id attribute if the checkbox exists and has an attribute' do
       expect(browser.checkbox(index: 0).id).to eq 'new_user_interests_books'

data/spec/watirspec/elements/date_time_field_spec.rb

@@ -15,7 +15,12 @@ describe 'DateTimeField' do
       expect(browser.date_time_field(text: '')).to exist
       expect(browser.date_time_field(text: //)).to exist
       expect(browser.date_time_field(index: 0)).to exist
-      expect(browser.date_time_field(xpath: "//input[@id='html5_datetime-local']")).to exist
+
+      # Firefox validates attribute "type" as "text" not "datetime-local"
+      not_compliant_on :firefox do
+        expect(browser.date_time_field(xpath: "//input[@id='html5_datetime-local']")).to exist
+      end
+
       expect(browser.date_time_field(label: 'HTML5 Datetime Local')).to exist
       expect(browser.date_time_field(label: /Local$/)).to exist
     end

data/spec/watirspec/elements/dd_spec.rb

@@ -28,23 +28,6 @@ describe 'Dd' do
   end
 
   # Attribute methods
-  describe '#class_name' do
-    it 'returns the class attribute if the element exists' do
-      expect(browser.dd(id: 'someone').class_name).to eq 'name'
-    end
-
-    it "returns an empty string if the element exists but the attribute doesn't" do
-      expect(browser.dd(id: 'city').class_name).to eq ''
-    end
-
-    it 'raises UnknownObjectException if the element does not exist' do
-      expect { browser.dd(id: 'no_such_id').class_name }.to raise_unknown_object_exception
-      expect { browser.dd(title: 'no_such_title').class_name }.to raise_unknown_object_exception
-      expect { browser.dd(index: 1337).class_name }.to raise_unknown_object_exception
-      expect { browser.dd(xpath: "//dd[@id='no_such_id']").class_name }.to raise_unknown_object_exception
-    end
-  end
-
   describe '#id' do
     it 'returns the id attribute if the element exists' do
       expect(browser.dd(class: 'name').id).to eq 'someone'

data/spec/watirspec/elements/del_spec.rb

@@ -39,20 +39,6 @@ describe 'Del' do
   end
 
   # Attribute methods
-  describe '#class_name' do
-    it 'returns the class attribute' do
-      expect(browser.del(index: 0).class_name).to eq 'lead'
-    end
-
-    it "returns an empty string if the element exists and the attribute doesn't" do
-      expect(browser.del(index: 2).class_name).to eq ''
-    end
-
-    it "raises UnknownObjectException if the del doesn't exist" do
-      expect { browser.del(id: 'no_such_id').class_name }.to raise_unknown_object_exception
-    end
-  end
-
   describe '#id' do
     it 'returns the id attribute' do
       expect(browser.del(index: 0).id).to eq 'lead'

data/spec/watirspec/elements/div_spec.rb

@@ -5,7 +5,6 @@ describe 'Div' do
     browser.goto(WatirSpec.url_for('non_control_elements.html'))
   end
 
-  # Exists method
   describe '#exists?' do
     it 'returns true if the element exists' do
       expect(browser.div(id: 'header')).to exist
@@ -45,23 +44,6 @@ describe 'Div' do
   end
 
   # Attribute methods
-  describe '#class_name' do
-    it 'returns the class attribute if the element exists' do
-      expect(browser.div(id: 'footer').class_name).to eq 'profile'
-    end
-
-    it "returns an empty string if the element exists but the attribute doesn't" do
-      expect(browser.div(id: 'content').class_name).to eq ''
-    end
-
-    it 'raises UnknownObjectException if the element does not exist' do
-      expect { browser.div(id: 'no_such_id').class_name }.to raise_unknown_object_exception
-      expect { browser.div(title: 'no_such_title').class_name }.to raise_unknown_object_exception
-      expect { browser.div(index: 1337).class_name }.to raise_unknown_object_exception
-      expect { browser.div(xpath: "//div[@id='no_such_id']").class_name }.to raise_unknown_object_exception
-    end
-  end
-
   describe '#id' do
     it 'returns the id attribute if the element exists' do
       expect(browser.div(index: 1).id).to eq 'outer_container'

data/spec/watirspec/elements/dl_spec.rb

@@ -28,23 +28,6 @@ describe 'Dl' do
   end
 
   # Attribute methods
-  describe '#class_name' do
-    it 'returns the class attribute if the element exists' do
-      expect(browser.dl(id: 'experience-list').class_name).to eq 'list'
-    end
-
-    it "returns an empty string if the element exists but the attribute doesn't" do
-      expect(browser.dl(id: 'noop').class_name).to eq ''
-    end
-
-    it 'raises UnknownObjectException if the element does not exist' do
-      expect { browser.dl(id: 'no_such_id').class_name }.to raise_unknown_object_exception
-      expect { browser.dl(title: 'no_such_title').class_name }.to raise_unknown_object_exception
-      expect { browser.dl(index: 1337).class_name }.to raise_unknown_object_exception
-      expect { browser.dl(xpath: "//dl[@id='no_such_id']").class_name }.to raise_unknown_object_exception
-    end
-  end
-
   describe '#id' do
     it 'returns the id attribute if the element exists' do
       expect(browser.dl(class: 'list').id).to eq 'experience-list'

data/spec/watirspec/elements/dt_spec.rb

@@ -28,23 +28,6 @@ describe 'Dt' do
   end
 
   # Attribute methods
-  describe '#class_name' do
-    it 'returns the class attribute if the element exists' do
-      expect(browser.dt(id: 'experience').class_name).to eq 'industry'
-    end
-
-    it "returns an empty string if the element exists but the attribute doesn't" do
-      expect(browser.dt(id: 'education').class_name).to eq ''
-    end
-
-    it 'raises UnknownObjectException if the element does not exist' do
-      expect { browser.dt(id: 'no_such_id').class_name }.to raise_unknown_object_exception
-      expect { browser.dt(title: 'no_such_title').class_name }.to raise_unknown_object_exception
-      expect { browser.dt(index: 1337).class_name }.to raise_unknown_object_exception
-      expect { browser.dt(xpath: "//dt[@id='no_such_id']").class_name }.to raise_unknown_object_exception
-    end
-  end
-
   describe '#id' do
     it 'returns the id attribute if the element exists' do
       expect(browser.dt(class: 'industry').id).to eq 'experience'

data/spec/watirspec/elements/element_spec.rb

@@ -87,20 +87,27 @@ describe 'Element' do
     it 'finds elements by visible text' do
       browser.goto WatirSpec.url_for('non_control_elements.html')
 
-      expect(browser.link(visible_text: 'all visible')).to exist
-      expect(browser.link(visible_text: /all visible/)).to exist
-      expect(browser.link(visible_text: 'some visible')).to exist
-      expect(browser.link(visible_text: /some visible/)).to exist
-      expect(browser.link(visible_text: 'none visible')).not_to exist
-      expect(browser.link(visible_text: /none visible/)).not_to exist
-
-      expect(browser.link(visible_text: 'Link 2', class: 'external')).to exist
-      expect(browser.link(visible_text: /Link 2/, class: 'external')).to exist
-
       expect(browser.element(visible_text: 'all visible')).to exist
       expect(browser.element(visible_text: /all visible/)).to exist
       expect(browser.element(visible_text: 'some visible')).to exist
       expect(browser.element(visible_text: /some visible/)).to exist
+      expect(browser.element(visible_text: 'none visible')).not_to exist
+      expect(browser.element(visible_text: /none visible/)).not_to exist
+
+      expect(browser.element(visible_text: 'Link 2', class: 'external')).to exist
+      expect(browser.element(visible_text: /Link 2/, class: 'external')).to exist
+    end
+
+    it 'raises exception unless value is a String or a RegExp' do
+      browser.goto WatirSpec.url_for('non_control_elements.html')
+      msg = /expected string_or_regexp, got 7\:(Fixnum|Integer)/
+      expect { browser.element(visible_text: 7).exists? }.to raise_exception(TypeError, msg)
+    end
+
+    it 'raises exception unless key is valid' do
+      browser.goto WatirSpec.url_for('non_control_elements.html')
+      msg = /Unable to build XPath using 7:(Fixnum|Integer)/
+      expect { browser.element(7 => /foo/).exists? }.to raise_exception(Watir::Exception::Error, msg)
     end
   end
 
@@ -131,7 +138,7 @@ describe 'Element' do
     end
 
     it "finds several elements from an element's subtree" do
-      expect(browser.fieldset.elements(xpath: './/label').length).to eq 22
+      expect(browser.fieldset.elements(xpath: './/label').length).to eq 23
     end
   end
 
@@ -265,7 +272,9 @@ describe 'Element' do
       browser.refresh
 
       expect(element).to be_stale
-      expect(element).to_not exist
+      expect {
+        expect(element).to_not exist
+      }.to have_deprecated_stale_exists
     end
 
     it 'returns false when tag name does not match id' do
@@ -447,23 +456,29 @@ describe 'Element' do
     end
 
     it 'raises if both :xpath and :css are given' do
-      expect { browser.div(xpath: '//div', css: 'div').exists? }.to raise_error(ArgumentError)
+      msg = ':xpath and :css cannot be combined ({:xpath=>"//div", :css=>"div"})'
+      expect { browser.div(xpath: '//div', css: 'div').exists? }
+        .to raise_exception Watir::Exception::LocatorException, msg
     end
 
     it "doesn't raise when selector has with :xpath has :index" do
       expect(browser.div(xpath: '//div', index: 1)).to exist
     end
 
-    it 'raises ArgumentError error if selector hash with :xpath has multiple entries' do
-      expect { browser.div(xpath: '//div', class: 'foo').exists? }.to raise_error(ArgumentError)
+    it 'raises LocatorException error if selector hash with :xpath has multiple entries' do
+      msg = 'xpath cannot be combined with all of these locators ({:class=>"foo", :tag_name=>"div"})'
+      expect { browser.div(xpath: '//div', class: 'foo').exists? }
+        .to raise_exception Watir::Exception::LocatorException, msg
     end
 
     it "doesn't raise when selector has with :css has :index" do
       expect(browser.div(css: 'div', index: 1)).to exist
     end
 
-    it 'raises ArgumentError error if selector hash with :css has multiple entries' do
-      expect { browser.div(css: 'div', class: 'foo').exists? }.to raise_error(ArgumentError)
+    it 'raises LocatorException error if selector hash with :css has multiple entries' do
+      msg = 'css cannot be combined with all of these locators ({:class=>"foo", :tag_name=>"div"})'
+      expect { browser.div(css: 'div', class: 'foo').exists? }
+        .to raise_exception Watir::Exception::LocatorException, msg
     end
 
     it 'finds element by Selenium name locator' do
@@ -524,6 +539,20 @@ describe 'Element' do
     end
   end
 
+  describe '#click' do
+    bug 'https://github.com/mozilla/geckodriver/issues/1375', :firefox do
+      it 'accepts modifiers' do
+        begin
+          browser.a.click(:shift)
+          expect(browser.windows.size).to eq 2
+        ensure
+          browser.windows.reject(&:current?).each(&:close)
+          expect(browser.windows.size).to eq 1
+        end
+      end
+    end
+  end
+
   describe '#flash' do
     let(:h2) { browser.h2(text: 'Add user') }
     let(:h1) { browser.h1(text: 'User administration') }
@@ -643,6 +672,15 @@ describe 'Element' do
     end
   end
 
+  describe '#select_text and #selected_text' do
+    it 'selects text and returns selected text' do
+      browser.goto WatirSpec.url_for('non_control_elements.html')
+      element = browser.element(visible_text: 'all visible')
+      element.select_text('all visible')
+      expect(element.selected_text).to eq 'all visible'
+    end
+  end
+
   not_compliant_on %i[remote firefox] do
     describe '#scroll_into_view' do
       it 'scrolls element into view' do
@@ -771,4 +809,126 @@ describe 'Element' do
       expect(element.wd).to be_a(Selenium::WebDriver::Element)
     end
   end
+
+  describe '#hash' do
+    it 'returns a hash' do
+      element = browser.text_field(id: 'new_user_email')
+      hash1 = element.hash
+      hash2 = element.locate.hash
+      expect(hash1).to be_a Integer
+      expect(hash2).to be_a Integer
+      expect(hash1).to_not eq hash2
+    end
+  end
+
+  describe 'Float Attribute' do
+    it 'returns Float value of applicable element' do
+      element = browser.text_field(id: 'number')
+      expect(element.valueasnumber).to be_a Float
+    end
+
+    it 'returns nil value for an inapplicable Element' do
+      element = browser.input
+      expect(element.valueasnumber).to be_nil
+    end
+  end
+
+  describe 'Integer Attribute' do
+    it 'returns Float value of applicable element' do
+      element = browser.form
+      expect(element.length).to be_a Integer
+    end
+
+    it 'returns -1 for an inapplicable Element' do
+      element = browser.input
+      expect(element.maxlength).to eq(-1)
+    end
+  end
+
+  describe '#class_name' do
+    it 'returns single class name' do
+      expect(browser.form(id: 'new_user').class_name).to eq 'user'
+    end
+
+    it 'returns multiple class names in a String' do
+      expect(browser.div(id: 'messages').class_name).to eq 'multiple classes here'
+    end
+
+    it 'returns an empty string if the element exists but there is no class attribute' do
+      expect(browser.div(id: 'changed_language').class_name).to eq ''
+    end
+
+    it 'raises UnknownObjectException if the element does not exist' do
+      expect { browser.div(id: 'no_such_id').class_name }.to raise_unknown_object_exception
+    end
+  end
+
+  describe '#classes' do
+    it 'returns the class attribute if the element exists' do
+      expect(browser.div(id: 'messages').classes).to eq %w[multiple classes here]
+    end
+
+    it 'returns an empty array if the element exists but there is no class attribute' do
+      expect(browser.div(id: 'changed_language').classes).to eq []
+    end
+
+    it 'raises UnknownObjectException if the element does not exist' do
+      expect { browser.div(id: 'no_such_id').classes }.to raise_unknown_object_exception
+    end
+  end
+
+  describe '#obscured?' do
+    before { browser.goto WatirSpec.url_for('obscured.html') }
+
+    it 'returns false if element\'s center is not covered' do
+      btn = browser.button(id: 'not_obscured')
+      expect(btn).not_to be_obscured
+      expect { btn.click }.not_to raise_exception
+    end
+
+    it 'returns false if element\'s center is covered by its descendant' do
+      btn = browser.button(id: 'has_descendant')
+      expect(btn).not_to be_obscured
+      expect { btn.click }.not_to raise_exception
+    end
+
+    it 'returns true if element\'s center is covered by a non-descendant' do
+      btn = browser.button(id: 'obscured')
+      expect(btn).to be_obscured
+      not_compliant_on :chrome do
+        expect { btn.click }.to raise_exception(Selenium::WebDriver::Error::ElementClickInterceptedError)
+      end
+      compliant_on :chrome do
+        expect { btn.click }.to raise_exception(Selenium::WebDriver::Error::UnknownError)
+      end
+    end
+
+    it 'returns false if element\'s center is surrounded by non-descendants' do
+      btn = browser.button(id: 'surrounded')
+      expect(btn).not_to be_obscured
+      expect { btn.click }.not_to raise_exception
+    end
+
+    it 'scrolls element into view before checking if obscured' do
+      btn = browser.button(id: 'requires_scrolling')
+      expect(btn).not_to be_obscured
+      expect { btn.click }.not_to raise_exception
+    end
+
+    it 'returns true if element cannot be scrolled into view' do
+      btn = browser.button(id: 'off_screen')
+      expect(btn).to be_obscured
+      expect { btn.click }.to raise_unknown_object_exception
+    end
+
+    it 'returns true if element is hidden' do
+      btn = browser.button(id: 'hidden')
+      expect(btn).to be_obscured
+      expect { btn.click }.to raise_unknown_object_exception
+    end
+
+    it 'raises UnknownObjectException if element does not exist' do
+      expect { browser.button(id: 'does_not_exist').obscured? }.to raise_unknown_object_exception
+    end
+  end
 end

data/spec/watirspec/elements/elements_spec.rb

@@ -36,12 +36,13 @@ describe 'Elements' do
   describe 'visible text' do
     it 'finds elements by visible text' do
       browser.goto WatirSpec.url_for('non_control_elements.html')
-      expect(browser.links(visible_text: 'all visible').count).to eq(1)
-      expect(browser.links(visible_text: /all visible/).count).to eq(1)
-      expect(browser.links(visible_text: 'some visible').count).to eq(1)
-      expect(browser.links(visible_text: /some visible/).count).to eq(1)
-      expect(browser.links(visible_text: 'none visible').count).to eq(0)
-      expect(browser.links(visible_text: /none visible/).count).to eq(0)
+      container = browser.div(id: 'visible_text')
+      expect(container.elements(visible_text: 'all visible').count).to eq(1)
+      expect(container.elements(visible_text: /all visible/).count).to eq(1)
+      expect(container.elements(visible_text: 'some visible').count).to eq(1)
+      expect(container.elements(visible_text: /some visible/).count).to eq(1)
+      expect(container.elements(visible_text: 'none visible').count).to eq(0)
+      expect(container.elements(visible_text: /none visible/).count).to eq(0)
     end
   end
 end