watir 6.14.0 → 6.15.0

data/spec/watirspec/selector_builder/row_spec.rb

@@ -0,0 +1,150 @@
+require 'watirspec_helper'
+
+describe Watir::Locators::Row::SelectorBuilder do
+  let(:attributes) { Watir::HTMLElement.attribute_list }
+  let(:selector_builder) { described_class.new(attributes, @scope_tag_name) }
+
+  describe '#build' do
+    after(:each) do |example|
+      next if example.metadata[:skip_after]
+
+      @scope_tag_name ||= @query_scope.tag_name
+
+      built = selector_builder.build(@selector)
+      expect(built).to eq [@wd_locator, (@remaining || {})]
+
+      next unless @data_locator || @tag_name
+
+      expect { @located = @query_scope.wd.first(@wd_locator) }.not_to raise_exception
+
+      if @data_locator
+        expect(@located.attribute('data-locator')).to eq(@data_locator)
+      else
+        expect {
+          expect(@located.tag_name).to eq @tag_name
+        }.not_to raise_exception
+      end
+    end
+
+    context 'with query scopes' do
+      before(:each) do
+        browser.goto(WatirSpec.url_for('tables.html'))
+      end
+
+      it 'with only table query scope' do
+        @query_scope = browser.element(id: 'outer').locate
+        @selector = {}
+        @wd_locator = {xpath: "./*[local-name()='tr'] | ./*[local-name()='tbody']/*[local-name()='tr'] | " \
+"./*[local-name()='thead']/*[local-name()='tr'] | ./*[local-name()='tfoot']/*[local-name()='tr']"}
+        @data_locator = 'first row'
+      end
+
+      it 'with tbody query scope' do
+        @query_scope = browser.element(id: 'first').locate
+        @selector = {}
+        @wd_locator = {xpath: "./*[local-name()='tr']"}
+        @data_locator = 'tbody row'
+      end
+
+      it 'with thead query scope' do
+        @query_scope = browser.element(id: 'tax_headers').locate
+        @selector = {}
+        @wd_locator = {xpath: "./*[local-name()='tr']"}
+        @data_locator = 'thead row'
+      end
+
+      it 'with tfoot query scope' do
+        @query_scope = browser.element(id: 'tax_totals').locate
+        @selector = {}
+        @wd_locator = {xpath: "./*[local-name()='tr']"}
+        @data_locator = 'tfoot row'
+      end
+    end
+
+    context 'with index' do
+      before(:each) do
+        browser.goto(WatirSpec.url_for('tables.html'))
+      end
+
+      it 'positive' do
+        @query_scope = browser.element(id: 'outer').locate
+        @selector = {index: 1}
+        @wd_locator = {xpath: "(./*[local-name()='tr'] | ./*[local-name()='tbody']/*[local-name()='tr'] | " \
+"./*[local-name()='thead']/*[local-name()='tr'] | ./*[local-name()='tfoot']/*[local-name()='tr'])[2]"}
+        @data_locator = 'middle row'
+      end
+
+      it 'negative' do
+        @query_scope = browser.element(id: 'outer').locate
+        @selector = {index: -3}
+        @wd_locator = {xpath: "(./*[local-name()='tr'] | ./*[local-name()='tbody']/*[local-name()='tr'] | " \
+"./*[local-name()='thead']/*[local-name()='tr'] | ./*[local-name()='tfoot']/*[local-name()='tr'])[last()-2]"}
+        @data_locator = 'first row'
+      end
+
+      it 'last' do
+        @query_scope = browser.element(id: 'outer').locate
+        @selector = {index: -1}
+        @wd_locator = {xpath: "(./*[local-name()='tr'] | ./*[local-name()='tbody']/*[local-name()='tr'] | " \
+"./*[local-name()='thead']/*[local-name()='tr'] | ./*[local-name()='tfoot']/*[local-name()='tr'])[last()]"}
+        @data_locator = 'last row'
+      end
+
+      it 'does not return index if it is zero' do
+        @query_scope = browser.element(id: 'outer').locate
+        @selector = {index: 0}
+        @wd_locator = {xpath: "./*[local-name()='tr'] | ./*[local-name()='tbody']/*[local-name()='tr'] | " \
+"./*[local-name()='thead']/*[local-name()='tr'] | ./*[local-name()='tfoot']/*[local-name()='tr']"}
+        @data_locator = 'first row'
+      end
+
+      it 'raises exception when index is not an Integer', skip_after: true do
+        @query_scope = browser.element(id: 'outer').locate
+        selector = {index: 'foo'}
+        msg = 'expected Integer, got "foo":String'
+        expect { selector_builder.build(selector) }.to raise_exception TypeError, msg
+      end
+    end
+
+    context 'with multiple locators' do
+      before(:each) do
+        browser.goto(WatirSpec.url_for('tables.html'))
+        @query_scope = browser.table.locate
+      end
+
+      it 'attribute and class' do
+        @selector = {id: 'gregory', class: /brick/}
+        @wd_locator = {xpath: "./*[local-name()='tr'][contains(@class, 'brick')][@id='gregory'] | " \
+"./*[local-name()='tbody']/*[local-name()='tr'][contains(@class, 'brick')][@id='gregory'] | " \
+"./*[local-name()='thead']/*[local-name()='tr'][contains(@class, 'brick')][@id='gregory'] | " \
+"./*[local-name()='tfoot']/*[local-name()='tr'][contains(@class, 'brick')][@id='gregory']"}
+        @data_locator = 'House row'
+      end
+    end
+
+    context 'returns locators that can not be directly translated' do
+      before(:each) do
+        browser.goto(WatirSpec.url_for('tables.html'))
+        @query_scope = browser.table(id: 'outer').locate
+      end
+
+      it 'any text value' do
+        @selector = {text: 'Gregory'}
+        @wd_locator = {xpath: "./*[local-name()='tr'] | ./*[local-name()='tbody']/*[local-name()='tr'] | " \
+"./*[local-name()='thead']/*[local-name()='tr'] | ./*[local-name()='tfoot']/*[local-name()='tr']"}
+        @remaining = {text: 'Gregory'}
+      end
+    end
+
+    it 'delegates adjacent to Element SelectorBuilder' do
+      browser.goto(WatirSpec.url_for('tables.html'))
+
+      @scope_tag_name = 'table'
+      @query_scope = browser.element(id: 'gregory').locate
+
+      @selector = {adjacent: :ancestor, index: 1}
+      @wd_locator = {xpath: './ancestor::*[2]'}
+      @data_locator = 'top table'
+    end
+  end
+end

data/spec/watirspec/selector_builder/text_spec.rb

@@ -0,0 +1,170 @@
+require 'watirspec_helper'
+
+describe Watir::Locators::TextField::SelectorBuilder do
+  let(:attributes) { Watir::HTMLElement.attribute_list }
+  let(:scope_tag_name) { nil }
+  let(:selector_builder) { described_class.new(attributes) }
+  let(:uppercase) { 'ABCDEFGHIJKLMNOPQRSTUVWXYZÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝÞŸŽŠŒ' }
+  let(:lowercase) { 'abcdefghijklmnopqrstuvwxyzàáâãäåæçèéêëìíîïðñòóôõöøùúûüýþÿžšœ' }
+  let(:negative_types) do
+    "translate(@type,'#{uppercase}','#{lowercase}')!='file' and "\
+"translate(@type,'#{uppercase}','#{lowercase}')!='radio' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='checkbox' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='submit' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='reset' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='image' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='button' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='hidden' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='range' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='color' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='date' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='datetime-local'"
+  end
+
+  describe '#build' do
+    after(:each) do |example|
+      next if example.metadata[:skip_after]
+
+      @query_scope ||= browser
+
+      built = selector_builder.build(@selector)
+      expect(built).to eq [@wd_locator, (@remaining || {})]
+
+      next unless @data_locator || @tag_name
+
+      expect { @located = @query_scope.wd.first(@wd_locator) }.not_to raise_exception
+
+      if @data_locator
+        expect(@located.attribute('data-locator')).to eq(@data_locator)
+      else
+        expect {
+          expect(@located.tag_name).to eq @tag_name
+        }.not_to raise_exception
+      end
+    end
+
+    it 'without any arguments' do
+      browser.goto(WatirSpec.url_for('forms_with_input_elements.html'))
+      @selector = {}
+      @wd_locator = {xpath: ".//*[local-name()='input'][not(@type) or (#{negative_types})]"}
+      @data_locator = 'input name'
+    end
+
+    context 'with type' do
+      before(:each) { browser.goto(WatirSpec.url_for('forms_with_input_elements.html')) }
+
+      it 'specified text field type that is text' do
+        @selector = {type: 'text'}
+        @wd_locator = {xpath: ".//*[local-name()='input']" \
+"[translate(@type,'#{uppercase}','#{lowercase}')='text']"}
+        @data_locator = 'first text'
+      end
+
+      it 'specified text field type that is not text' do
+        @selector = {type: 'number'}
+        @wd_locator = {xpath: ".//*[local-name()='input']" \
+"[translate(@type,'#{uppercase}','#{lowercase}')='number']"}
+        @data_locator = '42'
+      end
+
+      it 'true locates text field with a type specified' do
+        @selector = {type: true}
+        @wd_locator = {xpath: ".//*[local-name()='input'][#{negative_types}]"}
+        @data_locator = 'input name'
+      end
+
+      it 'false locates text field without type specified' do
+        @selector = {type: false}
+        @wd_locator = {xpath: ".//*[local-name()='input'][not(@type)]"}
+        @data_locator = 'input name'
+      end
+
+      it 'raises exception when a non-text field type input is specified', skip_after: true do
+        selector = {type: 'checkbox'}
+        msg = 'TextField Elements can not be located by type: checkbox'
+        expect { selector_builder.build(selector) }
+          .to raise_exception Watir::Exception::LocatorException, msg
+      end
+    end
+
+    context 'with index' do
+      before(:each) do
+        browser.goto(WatirSpec.url_for('forms_with_input_elements.html'))
+      end
+
+      it 'positive' do
+        @selector = {index: 4}
+        @wd_locator = {xpath: "(.//*[local-name()='input'][not(@type) or (#{negative_types})])[5]"}
+        @data_locator = 'dev'
+      end
+
+      it 'negative' do
+        @selector = {index: -3}
+        @wd_locator = {xpath: "(.//*[local-name()='input'][not(@type) or (#{negative_types})])[last()-2]"}
+        @data_locator = '42'
+      end
+
+      it 'last' do
+        @selector = {index: -1}
+        @wd_locator = {xpath: "(.//*[local-name()='input'][not(@type) or (#{negative_types})])[last()]"}
+        @data_locator = 'last text'
+      end
+
+      it 'does not return index if it is zero' do
+        @selector = {index: 0}
+        @wd_locator = {xpath: ".//*[local-name()='input'][not(@type) or (#{negative_types})]"}
+        @data_locator = 'input name'
+      end
+
+      it 'raises exception when index is not an Integer', skip_after: true do
+        selector = {index: 'foo'}
+        msg = 'expected Integer, got "foo":String'
+        expect { selector_builder.build(selector) }.to raise_exception TypeError, msg
+      end
+    end
+
+    context 'with text' do
+      before(:each) { browser.goto(WatirSpec.url_for('forms_with_input_elements.html')) }
+
+      it 'String for value' do
+        @selector = {text: 'Developer'}
+        @wd_locator = {xpath: ".//*[local-name()='input'][not(@type) or (#{negative_types})]"}
+        @remaining = {text: 'Developer'}
+      end
+
+      it 'Simple Regexp for value' do
+        @selector = {text: /Dev/}
+        @wd_locator = {xpath: ".//*[local-name()='input'][not(@type) or (#{negative_types})]"}
+        @remaining = {text: /Dev/}
+      end
+
+      it 'returns complicated Regexp to the locator as a value' do
+        @selector = {text: /^foo$/}
+        @wd_locator = {xpath: ".//*[local-name()='input'][not(@type) or (#{negative_types})]"}
+        @remaining = {text: /^foo$/}
+      end
+    end
+
+    context 'with multiple locators' do
+      before(:each) do
+        browser.goto(WatirSpec.url_for('forms_with_input_elements.html'))
+      end
+
+      it 'locates using tag name, class, attributes and text' do
+        @selector = {text: 'Developer', class: /c/, id: true}
+        @wd_locator = {xpath: ".//*[local-name()='input'][contains(@class, 'c')]" \
+"[not(@type) or (#{negative_types})][@id]"}
+        @remaining = {text: 'Developer'}
+      end
+
+      it 'delegates adjacent to Element SelectorBuilder' do
+        browser.goto(WatirSpec.url_for('forms_with_input_elements.html'))
+        @query_scope = browser.element(id: 'new_user_email').locate
+
+        @selector = {adjacent: :ancestor, index: 1}
+        @wd_locator = {xpath: './ancestor::*[2]'}
+        @data_locator = 'form'
+      end
+    end
+  end
+end

data/spec/watirspec/support/rspec_matchers.rb

@@ -1,12 +1,17 @@
 if defined?(RSpec)
   DEPRECATION_WARNINGS = %i[selector_parameters
+                            ready_state
                             class_array
                             use_capabilities
                             visible_text
+                            link_text
                             text_regexp
+                            stale_exists
                             stale_visible
                             stale_present
-                            select_by].freeze
+                            select_by
+                            wait_until_present
+                            wait_while_present].freeze
 
   DEPRECATION_WARNINGS.each do |deprecation|
     RSpec::Matchers.define "have_deprecated_#{deprecation}" do

data/spec/watirspec/user_editable_spec.rb

@@ -128,6 +128,10 @@ describe Watir::UserEditable do
     it "raises UnknownObjectException if the text field doesn't exist" do
       expect { browser.text_field(id: 'no_such_id').set('secret') }.to raise_unknown_object_exception
     end
+
+    it 'raises ObjectReadOnlyException if the object is read only' do
+      expect { browser.text_field(id: 'new_user_code').set('Foo') }.to raise_object_read_only_exception
+    end
   end
 
   describe '#set!' do

data/spec/watirspec/wait_spec.rb

@@ -107,48 +107,63 @@ describe Watir::Element do
   describe '#wait_until_present' do
     it 'waits until the element appears' do
       browser.a(id: 'show_bar').click
-      expect { browser.div(id: 'bar').wait_until_present(timeout: 5) }.to_not raise_exception
+      expect {
+        expect { browser.div(id: 'bar').wait_until_present(timeout: 5) }.to_not raise_exception
+      }.to have_deprecated_wait_until_present
     end
 
     it 'waits until the element re-appears' do
       browser.link(id: 'readd_bar').click
-      expect { browser.div(id: 'bar').wait_until_present }.to_not raise_exception
+      expect {
+        expect { browser.div(id: 'bar').wait_until_present }.to_not raise_exception
+      }.to have_deprecated_wait_until_present
     end
 
     it "times out if the element doesn't appear" do
       inspected = '#<Watir::Div: located: true; {:id=>"bar", :tag_name=>"div"}>'
       error = Watir::Wait::TimeoutError
-      message = "timed out after 1 seconds, waiting for element #{inspected} to become present"
+      message = "timed out after 1 seconds, waiting for #{inspected} to become present"
 
-      expect { browser.div(id: 'bar').wait_until_present(timeout: 1) }.to raise_error(error, message)
+      expect {
+        expect { browser.div(id: 'bar').wait_until_present(timeout: 1) }.to raise_error(error, message)
+      }.to have_deprecated_wait_until_present
     end
 
     it 'uses provided interval' do
       element = browser.div(id: 'bar')
       expect(element).to receive(:present?).twice
 
-      expect { element.wait_until_present(timeout: 0.4, interval: 0.2) }.to raise_timeout_exception
+      expect {
+        expect { element.wait_until_present(timeout: 0.4, interval: 0.2) }.to raise_timeout_exception
+      }.to have_deprecated_wait_until_present
     end
   end
 
   describe '#wait_while_present' do
     it 'waits until the element disappears' do
       browser.a(id: 'hide_foo').click
-      expect { browser.div(id: 'foo').wait_while_present(timeout: 2) }.to_not raise_exception
+      expect {
+        expect { browser.div(id: 'foo').wait_while_present(timeout: 2) }.to_not raise_exception
+      }.to have_deprecated_wait_while_present
     end
 
     it "times out if the element doesn't disappear" do
       error = Watir::Wait::TimeoutError
       inspected = '#<Watir::Div: located: true; {:id=>"foo", :tag_name=>"div"}>'
-      message = "timed out after 1 seconds, waiting for element #{inspected} not to be present"
-      expect { browser.div(id: 'foo').wait_while_present(timeout: 1) }.to raise_error(error, message)
+      message = "timed out after 1 seconds, waiting for #{inspected} not to be present"
+      expect {
+        expect { browser.div(id: 'foo').wait_while_present(timeout: 1) }.to raise_error(error, message)
+      }.to have_deprecated_wait_while_present
     end
 
     it 'uses provided interval' do
+      error = Watir::Wait::TimeoutError
       element = browser.div(id: 'foo')
-      expect(element).to receive(:present?).twice
+      expect(element).to receive(:present?).and_return(true).twice
 
-      expect { element.wait_until_present(timeout: 0.4, interval: 0.2) }.to raise_timeout_exception
+      expect {
+        expect { element.wait_while_present(timeout: 0.4, interval: 0.2) }.to raise_error(error)
+      }.to have_deprecated_wait_while_present
     end
 
     it 'does not error when element goes stale' do
@@ -157,13 +172,17 @@ describe Watir::Element do
       allow(element).to receive(:stale?).and_return(false, true)
 
       browser.a(id: 'hide_foo').click
-      expect { element.wait_while_present(timeout: 1) }.to_not raise_exception
+      expect {
+        expect { element.wait_while_present(timeout: 1) }.to_not raise_exception
+      }.to have_deprecated_wait_while_present
     end
 
     it 'waits until the selector no longer matches' do
       element = browser.link(name: 'add_select').wait_until(&:exists?)
       browser.link(id: 'change_select').click
-      expect { element.wait_while_present }.not_to raise_error
+      expect {
+        expect { element.wait_while_present }.not_to raise_error
+      }.to have_deprecated_wait_while_present
     end
   end
 
@@ -303,6 +322,34 @@ describe Watir::Element do
         expect { element.wait_while(custom: '') }.to_not raise_exception
       end
 
+      it 'accepts keywords and block' do
+        element = browser.div(id: 'foo')
+        browser.a(id: 'hide_foo').click
+        expect { element.wait_while(custom: '', &:present?) }.to_not raise_exception
+      end
+
+      it 'browser accepts keywords' do
+        expect { browser.wait_until(title: 'wait test') }.to_not raise_exception
+        expect { browser.wait_until(title: 'wrong') }.to raise_timeout_exception
+      end
+
+      it 'alert accepts keywords' do
+        browser.goto WatirSpec.url_for('alerts.html')
+
+        begin
+          browser.button(id: 'alert').click
+          expect { browser.alert.wait_until(text: 'ok') }.to_not raise_exception
+          expect { browser.alert.wait_until(text: 'not ok') }.to raise_timeout_exception
+        ensure
+          browser.alert.ok
+        end
+      end
+
+      it 'window accepts keywords' do
+        expect { browser.window.wait_until(title: 'wait test') }.to_not raise_exception
+        expect { browser.window.wait_until(title: 'wrong') }.to raise_timeout_exception
+      end
+
       it 'times out when single keyword not met' do
         element = browser.div(id: 'foo')
         expect { element.wait_while(id: 'foo') }.to raise_timeout_exception
@@ -338,11 +385,15 @@ describe Watir do
       end
 
       it 'is used by Element#wait_until_present' do
-        expect { browser.div(id: 'bar').wait_until_present }.to wait_and_raise_timeout_exception(timeout: 1)
+        expect {
+          expect { browser.div(id: 'bar').wait_until_present }.to wait_and_raise_timeout_exception(timeout: 1)
+        }.to have_deprecated_wait_until_present
       end
 
       it 'is used by Element#wait_while_present' do
-        expect { browser.div(id: 'foo').wait_while_present }.to wait_and_raise_timeout_exception(timeout: 1)
+        expect {
+          expect { browser.div(id: 'foo').wait_while_present }.to wait_and_raise_timeout_exception(timeout: 1)
+        }.to have_deprecated_wait_while_present
       end
     end
   end