volt 0.9.1 → 0.9.2

data/spec/models/validators/shared_examples_for_validators.rb

@@ -72,7 +72,7 @@ shared_examples_for 'a format validator' do
   end
 
   context 'when there is both regex and block criteria' do
-    let(:options) { [ regex_opts, proc_opts ] }
+    let(:options) { [regex_opts, proc_opts] }
 
     before { validate }
 

data/spec/models/validators/unique_validator_spec.rb

@@ -5,7 +5,6 @@ unless RUBY_PLATFORM == 'opal'
     validate :name, unique: true
   end
 
-
   describe 'unique spec' do
     it 'should reject save if there are records with existing attributes already' do
       store._fridges << { name: 'swift' }
@@ -23,4 +22,4 @@ unless RUBY_PLATFORM == 'opal'
       expect(store._fridges.count).to eq(1)
     end
   end
-end
+end

data/spec/page/bindings/content_binding_spec.rb

@@ -15,7 +15,7 @@ describe Volt::ContentBinding do
 
   it 'should render with a template' do
     context = { name: 'jimmy' }
-    binding = lambda { |page, target, context, id| Volt::ContentBinding.new(page, target, context, id, proc { self[:name] }) }
+    binding = ->(page, target, context, id) { Volt::ContentBinding.new(page, target, context, id, proc { self[:name] }) }
 
     templates = {
       'main/main' => {

data/spec/page/bindings/template_binding/view_lookup_for_path_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 require 'volt/page/bindings/view_binding'
 
-
 describe Volt::ViewBinding do
   before do
     @page = double('volt/page')

data/spec/page/path_string_renderer_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 require 'volt/page/path_string_renderer'
 
-
 unless RUBY_PLATFORM == 'opal'
   describe Volt::PathStringRenderer do
     before do
@@ -16,8 +15,8 @@ unless RUBY_PLATFORM == 'opal'
     end
 
     it 'should render a section with a variable' do
-      html = Volt::PathStringRenderer.new('main/mailers/welcome/html', {:name => 'Jimmy'}, @page).html
+      html = Volt::PathStringRenderer.new('main/mailers/welcome/html', { name: 'Jimmy' }, @page).html
       expect(html).to eq("\n  <h1>Welcome Jimmy</h1>\n\n  <p>Glad you signed up!</p>\n\n")
     end
   end
-end
+end

data/spec/reactive/class_eventable_spec.rb

@@ -34,4 +34,4 @@ describe Volt::ClassEventable do
 
     expect(test_ev.run_count).to eq(2)
   end
-end
+end

data/spec/reactive/computation_spec.rb

@@ -44,7 +44,7 @@ describe Volt::Computation do
     a[:b] = 5
 
     count = 0
-    -> do
+    lambda do
       a[:b]
     end.watch_until!(10) do
       count += 1
@@ -74,7 +74,7 @@ describe Volt::Computation do
     a = Volt::Dependency.new
 
     count = 0
-    -> { count += 1 ; a.depend }.watch!
+    -> { count += 1; a.depend }.watch!
 
     expect(count).to eq(1)
 
@@ -93,10 +93,10 @@ describe Volt::Computation do
     a = Volt::ReactiveHash.new
 
     values = []
-    -> do
+    lambda do
       values << a[0]
 
-      -> do
+      lambda do
         values << a[1]
       end.watch!
     end.watch!
@@ -112,7 +112,7 @@ describe Volt::Computation do
     expect(values).to eq([nil, nil, 'inner', 'outer', 'inner'])
   end
 
-  describe "watch_and_resolve!" do
+  describe 'watch_and_resolve!' do
     it 'should resolve any returnted promises' do
       promise = Promise.new.resolve('resolved')
       count = 0
@@ -130,45 +130,44 @@ describe Volt::Computation do
   # https://github.com/opal/opal/issues/677
   unless RUBY_PLATFORM == 'opal'
     describe '#invalidate!' do
+      let(:computation) { Volt::Computation.new -> {} }
 
-    let(:computation) { Volt::Computation.new ->{} }
-
-    before(:each) do
-      Volt::Computation.class_variable_set :@@flush_queue, []
-    end
+      before(:each) do
+        Volt::Computation.class_variable_set :@@flush_queue, []
+      end
 
-    describe 'when stopped' do
-      before(:each) { computation.instance_variable_set :@stopped, true }
+      describe 'when stopped' do
+        before(:each) { computation.instance_variable_set :@stopped, true }
 
-      it "doesn't add self to flush queue" do
-        computation.invalidate!
+        it "doesn't add self to flush queue" do
+          computation.invalidate!
 
-        expect(Volt::Computation.class_variable_get :@@flush_queue).to be_empty
+          expect(Volt::Computation.class_variable_get :@@flush_queue).to be_empty
+        end
       end
-    end
 
-    describe 'when computing' do
-      before(:each) { computation.instance_variable_set :@computing, true }
+      describe 'when computing' do
+        before(:each) { computation.instance_variable_set :@computing, true }
 
-      it "should still add itself to flush queue" do
-        computation.invalidate!
+        it 'should still add itself to flush queue' do
+          computation.invalidate!
 
-        expect(Volt::Computation.class_variable_get :@@flush_queue).not_to be_empty
+          expect(Volt::Computation.class_variable_get :@@flush_queue).not_to be_empty
+        end
       end
-    end
 
-    describe 'when not stopped and not computing' do
-      before(:each) do
-        computation.instance_variable_set :@stopped,   false
-        computation.instance_variable_set :@computing, false
-      end
+      describe 'when not stopped and not computing' do
+        before(:each) do
+          computation.instance_variable_set :@stopped,   false
+          computation.instance_variable_set :@computing, false
+        end
 
-      it 'adds self to flush queue' do
-        computation.invalidate!
+        it 'adds self to flush queue' do
+          computation.invalidate!
 
-        expect(Volt::Computation.class_variable_get :@@flush_queue).to match_array([computation])
+          expect(Volt::Computation.class_variable_get :@@flush_queue).to match_array([computation])
+        end
       end
     end
   end
-  end
 end

data/spec/reactive/reactive_hash_spec.rb

@@ -9,4 +9,4 @@ describe Volt::ReactiveHash do
     a.clear
     expect(a[:name]).to eq(nil)
   end
-end
+end

data/spec/router/routes_spec.rb

@@ -33,22 +33,22 @@ describe Volt::Routes do
         '*' => {
           'edit' => {
             nil => { view: 'blog/edit', id: 1 }
-            },
-            nil => { view: 'blog/show', id: 1 }
-          }
+          },
+          nil => { view: 'blog/show', id: 1 }
         }
-        )
+      }
+    )
 
     expect(indirect_routes[:get]).to eq(
       'comments' => {
         '*' => {
           'edit' => {
             nil => { controller: 'comments', action: 'edit', id: 1 }
-            },
-            nil => { controller: 'comments', action: 'show', id: 1 }
-          }
+          },
+          nil => { controller: 'comments', action: 'show', id: 1 }
         }
-        )
+      }
+    )
   end
 
   it 'should setup param matchers' do
@@ -69,15 +69,14 @@ describe Volt::Routes do
       { view: 'blog/edit', id: nil },
       { view: 'blog/tag', tag: nil },
       { view: 'login', action: 'user', name: nil, id: nil }
-      ])
+    ])
 
     expect(param_matches[:get].map { |v| v[0] }).to eq([
       { controller: 'articles', action: 'index' },
-      { controller: 'articles', action: 'show', id: nil },
-      ])
+      { controller: 'articles', action: 'show', id: nil }
+    ])
   end
 
-
   it 'should match routes' do
     routes do
       client '/blog', view: 'blog'
@@ -93,7 +92,6 @@ describe Volt::Routes do
       put '/people', controller: 'people', action: 'update'
       patch '/people/1', controller: 'people', action: 'update'
       delete '/people/2', controller: 'people', action: 'destroy'
-
     end
 
     params = @routes.url_to_params('/blog')
@@ -174,7 +172,7 @@ describe Volt::Routes do
 
     url, params = @routes.params_to_url(controller: 'articles', action: 'update', method: :put, id: 99, other: 'xyz')
     expect(url).to eq('/articles/99')
-    expect(params).to eq({other: 'xyz'})
+    expect(params).to eq(other: 'xyz')
 
     url, params = @routes.params_to_url({})
     expect(url).to eq(nil)
@@ -213,13 +211,13 @@ describe Volt::Routes do
 
   it 'should not match params that have no matches at all' do
     routes = Volt::Routes.new
-    match, params = routes.send(:check_params_match, { view: '', id: false }, bleep: {volt: 'rocks'} )
+    match, params = routes.send(:check_params_match, { view: '', id: false }, bleep: { volt: 'rocks' })
     expect(match).to eq(false)
   end
 
   it 'should not match params that have a nil value' do
     routes = Volt::Routes.new
-    match, params = routes.send(:check_params_match, { view: 'blog', id: false }, bleep: nil )
+    match, params = routes.send(:check_params_match, { view: 'blog', id: false }, bleep: nil)
     expect(match).to eq(false)
   end
 

data/spec/server/html_parser/view_handler_spec.rb

@@ -8,7 +8,7 @@ else
 
     it 'handles tags' do
       handler.comment('Yowza!')
-      handler.start_tag('a', {href: 'yahoo.com'}, false)
+      handler.start_tag('a', { href: 'yahoo.com' }, false)
       handler.text('Cool in 1996')
       handler.end_tag('a')
 

data/spec/server/html_parser/view_parser_spec.rb

@@ -185,7 +185,6 @@ describe Volt::ViewParser do
     END
 
     view = Volt::ViewParser.new(html, 'main/main/main/body')
-
   end
   it 'should setup a href single attribute binding correctly' do
     html = <<-END

data/spec/server/rack/quite_common_logger_spec.rb

@@ -24,7 +24,7 @@ unless RUBY_PLATFORM == 'opal'
       end
 
       describe 'when request path has no file extension and request run over web socket' do
-        let(:env) { {'PATH_INFO' => '/file'} }
+        let(:env) { { 'PATH_INFO' => '/file' } }
 
         it "calls 'log' method" do
           expect(subject).to receive(:log)
@@ -33,7 +33,7 @@ unless RUBY_PLATFORM == 'opal'
       end
 
       describe 'when request path has file extension' do
-        let(:env) { {'PATH_INFO' => '/file.ext'} }
+        let(:env) { { 'PATH_INFO' => '/file.ext' } }
 
         it "doesn't call 'log' method" do
           expect(subject).not_to receive(:log)
@@ -42,7 +42,7 @@ unless RUBY_PLATFORM == 'opal'
       end
 
       describe 'when request run over web socket' do
-        let(:env) { {'PATH_INFO' => '/channel'} }
+        let(:env) { { 'PATH_INFO' => '/channel' } }
 
         it "doesn't call 'log' method" do
           expect(subject).not_to receive(:log)

data/spec/tasks/dispatcher_spec.rb

@@ -1,7 +1,7 @@
 if RUBY_PLATFORM != 'opal'
   class TestTask < Volt::Task
     def allowed_method(arg1, arg2)
-      return 'yes' + arg1 + arg2
+      'yes' + arg1 + arg2
     end
   end
 

data/spec/tasks/query_tracker_spec.rb

@@ -33,12 +33,11 @@ if RUBY_PLATFORM != 'opal'
       end
 
       def notify_changed(id, data, skip_channel)
-        item = @items.find{ |item| item['_id'] == id }
+        item = @items.find { |item| item['_id'] == id }
         idx  = @items.index(item)
         @items.delete(item)
         @items.insert(idx, data)
       end
-
     end
 
     before do
@@ -141,7 +140,6 @@ if RUBY_PLATFORM != 'opal'
       expect(@live_query.items).to_not eq(@items)
       @query_tracker.run
       expect(@live_query.items).to eq(@items)
-
     end
   end
 end

data/spec/utils/task_argument_filtererer_spec.rb

@@ -3,15 +3,15 @@ require 'spec_helper'
 if RUBY_PLATFORM != 'opal'
   describe TaskArgumentFilterer do
     it 'should filter arguments' do
-      filtered_args = TaskArgumentFilterer.new({login: 'jim@jim.com', password: 'some password no one should see'}).run
+      filtered_args = TaskArgumentFilterer.new(login: 'jim@jim.com', password: 'some password no one should see').run
 
-      expect(filtered_args).to eq({:login=>"jim@jim.com", :password=>"[FILTERED]"})
+      expect(filtered_args).to eq(login: 'jim@jim.com', password: '[FILTERED]')
     end
 
     it 'should filter in nested args' do
-      filtered_args = TaskArgumentFilterer.new([:login, {login: 'jim@jim.com', password: 'some password'}]).run
+      filtered_args = TaskArgumentFilterer.new([:login, { login: 'jim@jim.com', password: 'some password' }]).run
 
-      expect(filtered_args).to eq([:login, {:login=>"jim@jim.com", :password=>"[FILTERED]"}])
+      expect(filtered_args).to eq([:login, { login: 'jim@jim.com', password: '[FILTERED]' }])
     end
   end
-end
+end

data/templates/project/app/main/controllers/main_controller.rb

@@ -24,4 +24,4 @@ module Main
       url.path.split('/')[1] == attrs.href.split('/')[1]
     end
   end
-end
+end

data/templates/project/spec/app/main/models/sample_model_spec.rb

@@ -1,5 +1,5 @@
 require 'spec_helper'
 
-describe "sample model" do
+describe 'sample model' do
   # Specs here
-end
+end

data/templates/project/spec/app/main/tasks/sample_task_spec.rb

@@ -1,5 +1,5 @@
 require 'spec_helper'
 
-describe "sample task", type: :task do
+describe 'sample task', type: :task do
   # Specs here
-end
+end

data/volt.gemspec

@@ -10,10 +10,7 @@ Gem::Specification.new do |spec|
   spec.authors       = ['Ryan Stout']
   spec.email         = ['ryan@agileproductions.com']
   spec.summary       = 'A reactive Ruby web framework.'
-  spec.description   =  <<-EOF
-    A reactive Ruby web framework where your Ruby code runs on both the server
-    and the client (via Opal).
-  EOF
+  spec.description   = 'A reactive Ruby web framework where your Ruby code runs on both the server and the client (via Opal).'
   spec.homepage      = 'http://voltframework.com'
   spec.license       = 'MIT'
 
@@ -47,7 +44,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'selenium-webdriver', '~> 2.43.0'
   spec.add_development_dependency 'chromedriver2-helper', '~> 0.0.8'
   spec.add_development_dependency 'poltergeist', '~> 1.5.0'
-  # spec.add_development_dependency 'puma', '~> 2.11.2'
   spec.add_development_dependency 'thin', '~> 1.6.3'
   spec.add_development_dependency 'coveralls', '~> 0.8.1'
 
@@ -63,4 +59,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'sauce', '~> 3.5.3'
   spec.add_development_dependency 'sauce-connect', '~> 3.5.0'
   spec.add_development_dependency 'pry-byebug', '~> 2.0.0'
+
+  spec.add_development_dependency 'rubocop', '~> 0.31.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: volt
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.9.2
 platform: ruby
 authors:
 - Ryan Stout
@@ -458,9 +458,22 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 2.0.0
-description: |2
-      A reactive Ruby web framework where your Ruby code runs on both the server
-      and the client (via Opal).
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.31.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.31.0
+description: A reactive Ruby web framework where your Ruby code runs on both the server
+  and the client (via Opal).
 email:
 - ryan@agileproductions.com
 executables:
@@ -725,6 +738,7 @@ files:
 - spec/integration/missing_spec.rb
 - spec/integration/raw_html_binding.rb
 - spec/integration/templates_spec.rb
+- spec/integration/todos_spec.rb
 - spec/integration/url_spec.rb
 - spec/integration/user_spec.rb
 - spec/integration/yield_spec.rb
@@ -943,6 +957,7 @@ test_files:
 - spec/integration/missing_spec.rb
 - spec/integration/raw_html_binding.rb
 - spec/integration/templates_spec.rb
+- spec/integration/todos_spec.rb
 - spec/integration/url_spec.rb
 - spec/integration/user_spec.rb
 - spec/integration/yield_spec.rb