volt 0.9.1 → 0.9.2

data/lib/volt/utils/tilt_patch.rb

@@ -6,4 +6,4 @@ class Tilt::Template
   def warn(*args)
     # Kernel.warn(*args)
   end
-end
+end

data/lib/volt/utils/timers.rb

@@ -1,5 +1,4 @@
 module Volt
-
   # The timers class provides useful methods for working in an asynchronus environment.
   class Timers
     # next tick (same as setImmediate) calls the block of code after any currently
@@ -7,7 +6,7 @@ module Volt
     def self.next_tick(&block)
       if Volt.in_browser?
         `setImmediate(function() {`
-          yield
+        yield
         `})`
       else
         tick_timers = (Thread.current['tick_timers'] ||= [])
@@ -23,11 +22,8 @@ module Volt
       if tick_timers
         # clear
         Thread.current['tick_timers'] = nil
-        tick_timers.each do |timer|
-          # Run the timer
-          timer.call
-        end
+        tick_timers.each(&:call)
       end
     end
   end
-end
+end

data/lib/volt/utils/volt_user_error.rb

@@ -1,4 +1,4 @@
 # VoltUserError is a base class for Volt errors that you don't need backtraces on.
 # These are errors that you simply need to communicate something to developer with.
 class VoltUserError < RuntimeError
-end
+end

data/lib/volt/version.rb

@@ -1,5 +1,5 @@
 module Volt
   module Version
-    STRING = '0.9.1'
+    STRING = '0.9.2'
   end
-end
+end

data/lib/volt/volt/app.rb

@@ -17,9 +17,7 @@ module Volt
       end
 
       # Require in app and initializers
-      unless RUBY_PLATFORM == 'opal'
-        Volt.run_app_and_initializers
-      end
+      Volt.run_app_and_initializers unless RUBY_PLATFORM == 'opal'
 
       # Load component paths
       @component_paths = ComponentPaths.new(app_path)
@@ -45,12 +43,12 @@ module Volt
         @component_paths.app_folders do |app_folder|
           # Sort so we get consistent load order across platforms
           Dir["#{app_folder}/*/controllers/server/*.rb"].each do |ruby_file|
-            #path = ruby_file.gsub(/^#{app_folder}\//, '')[0..-4]
-            #require(path)
+            # path = ruby_file.gsub(/^#{app_folder}\//, '')[0..-4]
+            # require(path)
             require(ruby_file)
           end
         end
       end
     end
   end
-end
+end

data/lib/volt/volt/users.rb

@@ -64,7 +64,7 @@ module Volt
 
     # Put in a deprecation placeholder
     def user
-      Volt.logger.warn("deprication: Volt.user has been renamed to Volt.current_user (to be more clear about what it returns).  Volt.user will be deprecated in the future.")
+      Volt.logger.warn('deprication: Volt.user has been renamed to Volt.current_user (to be more clear about what it returns).  Volt.user will be deprecated in the future.')
       current_user
     end
 
@@ -80,7 +80,7 @@ module Volt
 
     # Login the user, return a promise for success
     def login(username, password)
-      UserTasks.login({login: username, password: password}).then do |result|
+      UserTasks.login(login: username, password: password).then do |result|
         # Assign the user_id cookie for the user
         $page.cookies._user_id = result
 
@@ -112,9 +112,10 @@ module Volt
     end
 
     private
+
     # Returns a query for the current user_id or nil if there is no user_id
     def user_query
-      user_id = self.current_user_id
+      user_id = current_user_id
       if user_id
         $page.store._users.where(_id: user_id)
       else

data/spec/apps/kitchen_sink/app/main/controllers/main_controller.rb

@@ -59,4 +59,4 @@ module Main
       url.path.split('/')[1] == attrs.href.split('/')[1]
     end
   end
-end
+end

data/spec/apps/kitchen_sink/app/main/controllers/server/simple_http_controller.rb

@@ -14,4 +14,4 @@ module Main
       render text: 'Thanks for uploading'
     end
   end
-end
+end

data/spec/apps/kitchen_sink/app/main/controllers/todos_controller.rb

@@ -1,18 +1,18 @@
 module Main
   class TodosController < Volt::ModelController
-    model :page
+    model :store
 
     def add_todo
-      _todos << { name: _new_todo }
-      self._new_todo = ''
+      _todos << { name: page._new_todo }
+      page._new_todo = ''
     end
 
     def remove_todo(todo)
-      _todos.delete(todo)
+      todo.destroy
     end
 
     def completed
       _todos.count(&:_completed)
     end
   end
-end
+end

data/spec/apps/kitchen_sink/app/main/controllers/upload_controller.rb

@@ -21,4 +21,4 @@ module Main
       });`
     end
   end
-end
+end

data/spec/apps/kitchen_sink/app/main/controllers/yield_component_controller.rb

@@ -4,4 +4,4 @@ module Main
       'wrong'
     end
   end
-end
+end

data/spec/controllers/actions_spec.rb

@@ -93,13 +93,12 @@ describe Volt::Actions do
 
     expect(test_class.ran_one).to eq(true)
     expect(test_class.ran_two).to eq(true)
-
   end
 
   it 'should raise an exception if no symbol or block is provided' do
     expect do
       TestActions2.before_action
-    end.to raise_error(RuntimeError, "No callback symbol or block provided")
+    end.to raise_error(RuntimeError, 'No callback symbol or block provided')
   end
 
   it 'should support multiple symbols passed an action helper' do
@@ -116,15 +115,15 @@ describe Volt::Actions do
   end
 
   it 'should stop the chain when #stop_chain is called and return false from #run_actions' do
-   test_class = TestStopCallbacks.new
+    test_class = TestStopCallbacks.new
 
-   result = test_class.run_actions(:before, :index)
-   expect(result).to eq(true)
+    result = test_class.run_actions(:before, :index)
+    expect(result).to eq(true)
 
-   expect(test_class.ran_one).to eq(true)
-   expect(test_class.ran_two).to eq(true)
-   expect(test_class.ran_end_of_two).to eq(nil)
-   expect(test_class.ran_three).to eq(nil)
+    expect(test_class.ran_one).to eq(true)
+    expect(test_class.ran_two).to eq(true)
+    expect(test_class.ran_end_of_two).to eq(nil)
+    expect(test_class.ran_three).to eq(nil)
   end
 
   it 'should call without any callbacks' do
@@ -145,4 +144,4 @@ describe Volt::Actions do
     expect(test_only.ran_one).to eq(true)
     expect(test_only.ran_two).to eq(true)
   end
-end
+end

data/spec/controllers/model_controller_spec.rb

@@ -28,4 +28,4 @@ if RUBY_PLATFORM != 'opal'
       expect(controller.loaded?).to eq(true)
     end
   end
-end
+end

data/spec/extra_core/blank_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "blank" do
+describe 'blank' do
   it 'should report blank when blank' do
     expect('  '.blank?).to eq(true)
   end
@@ -8,4 +8,4 @@ describe "blank" do
   it 'should report not blank when not blank' do
     expect('  text '.blank?).to eq(false)
   end
-end
+end

data/spec/extra_core/logger_spec.rb

@@ -8,17 +8,15 @@ if RUBY_PLATFORM != 'opal'
     let(:logger) { Volt::VoltLogger.new }
 
     let(:logger_with_opts) do
-      Volt::VoltLogger.new({
-        args: args,
-        class_name: class_name,
-        method_name: method_name,
-        run_time: run_time
-      })
+      Volt::VoltLogger.new(args: args,
+                           class_name: class_name,
+                           method_name: method_name,
+                           run_time: run_time)
     end
 
     it 'should log only severity and message wrapped in line breaks' do
       expect(STDOUT).to receive(:write).with("\n\n[INFO] message\n")
-      logger.log(Logger::INFO, "message")
+      logger.log(Logger::INFO, 'message')
     end
 
     it 'should convert an array of arguments into a string' do
@@ -27,7 +25,7 @@ if RUBY_PLATFORM != 'opal'
 
     describe 'when STDOUT is a TTY' do
       before { allow(STDOUT).to receive(:tty?).and_return(true) }
-      
+
       it 'should return a blue class name' do
         expect(logger_with_opts.class_name).to eq("\e[1;34m#{class_name}\e[0;37m")
       end

data/spec/extra_core/string_transformations_spec.rb

@@ -47,7 +47,7 @@ describe '#camelize' do
 end
 
 describe '#headerize' do
-  it "headerizes" do
+  it 'headerizes' do
     expect('test_case'.headerize).to eq('Test-Case')
   end
 
@@ -55,5 +55,5 @@ describe '#headerize' do
     it 'underscores' do
       expect(underscored.headerize).to eq(headerized)
     end
-  end  
-end
+  end
+end

data/spec/integration/bindings_spec.rb

@@ -32,9 +32,7 @@ describe 'bindings test', type: :feature, sauce: true do
 
       # phantom does not support the html5 history api
       # TODO: We could probably polyfill this in phantom
-      if ENV['BROWSER'] != 'phantom'
-        expect(current_path).to eq('/bindings')
-      end
+      expect(current_path).to eq('/bindings') if ENV['BROWSER'] != 'phantom'
 
       # Fill in one field and see if it updates the rest
       fill_in('paramsName1', with: 'Params bindings')
@@ -59,9 +57,7 @@ describe 'bindings test', type: :feature, sauce: true do
 
       # phantom does not support the html5 history api
       # TODO: We could probably polyfill this in phantom
-      if ENV['BROWSER'] != 'phantom'
-        expect(current_path).to eq('/bindings')
-      end
+      expect(current_path).to eq('/bindings') if ENV['BROWSER'] != 'phantom'
 
       # Fill in one field and see if it updates the rest
       fill_in('routesName1', with: 'Routes bindings')
@@ -166,9 +162,7 @@ describe 'bindings test', type: :feature, sauce: true do
 
       click_link 'Bindings'
 
-      if ENV['BROWSER'] != 'phantom'
-        expect(current_path).to eq('/bindings')
-      end
+      expect(current_path).to eq('/bindings') if ENV['BROWSER'] != 'phantom'
 
       expect(find('#paramsCheck3')).to have_content('')
       # Fill in one field and see if it updates the rest

data/spec/integration/first_last_spec.rb

@@ -11,4 +11,4 @@ describe 'first, last', type: :feature, sauce: true do
   #
   #   visit '/first_last'
   # end
-end
+end

data/spec/integration/missing_spec.rb

@@ -6,6 +6,5 @@ describe "missing tags and view's", type: :feature do
 
     expect(page).to have_content('view or tag at "some/wrong/path"')
     expect(page).to have_content('view or tag at "not/a/component"')
-
   end
-end
+end

data/spec/integration/raw_html_binding.rb

@@ -1,9 +1,9 @@
 require 'spec_helper'
 
-describe "HTML safe/raw", type: :feature do
+describe 'HTML safe/raw', type: :feature do
   it 'should render html with the raw helper' do
     visit '/html_safe'
 
     expect(page).to have_selector('button[id="examplebutton"]')
   end
-end
+end

data/spec/integration/todos_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe 'todos app', type: :feature, sauce: true do
+  it 'should add a todo and remove it' do
+    visit '/todos'
+
+    fill_in 'newtodo', :with => 'Todo 1'
+    find('#newtodo').native.send_keys(:return)
+
+    expect(page).to have_content('Todo 1')
+
+    expect(find('#newtodo').value).to eq('')
+
+    click_button 'X'
+
+    expect(page).to_not have_content('Todo 1')
+
+    # Make sure it deleted
+    page.driver.browser.navigate.refresh
+    expect(page).to_not have_content('Todo 1')
+  end
+end

data/spec/integration/yield_spec.rb

@@ -6,8 +6,8 @@ describe 'yield binding', type: :feature, sauce: true do
   end
 
   it 'should render the yielded content multiple times' do
-    expect(page).to have_content("My yielded content 1")
-    expect(page).to have_content("My yielded content 2")
+    expect(page).to have_content('My yielded content 1')
+    expect(page).to have_content('My yielded content 2')
   end
 
   it 'should render the content from the tag\'s controller when yielding' do

data/spec/models/associations_spec.rb

@@ -11,10 +11,10 @@ end
 describe Volt::Associations do
   if RUBY_PLATFORM != 'opal'
     before do
-      store._people! << {name: 'Jimmy'}
+      store._people! << { name: 'Jimmy' }
       @person = store._people[0]
-      @person._addresses! << {city: 'Bozeman'}
-      @person._addresses << {city: 'Portland'}
+      @person._addresses! << { city: 'Bozeman' }
+      @person._addresses << { city: 'Portland' }
     end
 
     it 'should associate via belongs_to' do
@@ -31,4 +31,4 @@ describe Volt::Associations do
       expect(addresses[0]._city).to eq('Bozeman')
     end
   end
-end
+end

data/spec/models/buffer_spec.rb

@@ -37,7 +37,7 @@ describe Volt::Buffer do
       expect(then_count).to eq(0)
       expect(fail_count).to eq(1)
       expect(error.class).to eq(Volt::Errors)
-      expect(error).to eq({:name=>["must be at least 5 characters"]})
+      expect(error).to eq(name: ['must be at least 5 characters'])
     end
   end
-end
+end

data/spec/models/dirty_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "Volt::Dirty" do
+describe 'Volt::Dirty' do
   let(:model) do
     model = Volt::Model.new
 
@@ -30,7 +30,7 @@ describe "Volt::Dirty" do
     expect(model.name_was).to eq(nil)
     expect(model.name_changes).to eq([nil, 'Bob', 'Jimmy', 'Martin', nil])
 
-    expect(model.changed_attributes).to eq({:name=>[nil, "Bob", "Jimmy", "Martin", nil]})
+    expect(model.changed_attributes).to eq(name: [nil, 'Bob', 'Jimmy', 'Martin', nil])
   end
 
   it 'should say models are changed' do
@@ -46,9 +46,8 @@ describe "Volt::Dirty" do
     expect(model.changed?(:name)).to eq(false)
 
     expect(model.changed?).to eq(false)
-    model._some_other_attr = "Wow!"
+    model._some_other_attr = 'Wow!'
     expect(model.changed?).to eq(true)
-
   end
 
   it 'should reset changes' do
@@ -81,26 +80,26 @@ describe "Volt::Dirty" do
 
   it 'should revert changes' do
     expect(model.attributes).to eq({})
-    model.attributes = {first: 'Bob', last: 'Smith'}
-    expect(model.attributes).to eq({first: 'Bob', last: 'Smith'})
+    model.attributes = { first: 'Bob', last: 'Smith' }
+    expect(model.attributes).to eq(first: 'Bob', last: 'Smith')
 
     model.revert_changes!
-    expect(model.attributes).to eq({first: nil, last: nil})
+    expect(model.attributes).to eq(first: nil, last: nil)
   end
 
   it 'should revert changes after a clear_tracked_changed!' do
     expect(model.attributes).to eq({})
-    model.attributes = {first: 'Bob', last: 'Smith'}
-    expect(model.attributes).to eq({first: 'Bob', last: 'Smith'})
+    model.attributes = { first: 'Bob', last: 'Smith' }
+    expect(model.attributes).to eq(first: 'Bob', last: 'Smith')
 
     model.clear_tracked_changes!
     expect(model.changed_attributes).to eq({})
 
     model._first = 'Jimmy'
     model._last = 'Dean'
-    expect(model.attributes).to eq({first: 'Jimmy', last: 'Dean'})
+    expect(model.attributes).to eq(first: 'Jimmy', last: 'Dean')
 
     model.revert_changes!
-    expect(model.attributes).to eq({first: 'Bob', last: 'Smith'})
+    expect(model.attributes).to eq(first: 'Bob', last: 'Smith')
   end
 end