virtualbox 0.4.3 → 0.5.0

data/test/virtualbox/image_test.rb

@@ -34,11 +34,6 @@ class ImageTest < Test::Unit::TestCase
         assert result.empty_drive?
       end
 
-      should "return nil if uuid is nil and medium isn't empty" do
-        result = VirtualBox::Image.populate_relationship(@model, {})
-        assert result.nil?
-      end
-
       should "result a matching image from subclasses if uuid" do
         uuid = "foo'"
 

data/test/virtualbox/nic_test.rb

@@ -2,25 +2,13 @@ require File.join(File.dirname(__FILE__), '..', 'test_helper')
 
 class NicTest < Test::Unit::TestCase
   setup do
-    @data = {
-      :nic1 => "bridged",
-      :nic2 => "foo",
-      :nic3 => "bar"
-    }
-
     @caller = mock("caller")
     @caller.stubs(:name).returns("foo")
-
-    VirtualBox::VM.stubs(:human_info).returns(<<-raw)
-NIC 1:           MAC: 08002745B49F, Attachment: Bridged Interface 'en0: Ethernet', Cable connected: on, Trace: off (file: none), Type: Am79C973, Reported speed: 0 Mbps
-NIC 2:           MAC: 08002745B49F, Attachment: Bridged Interface 'en0: Ethernet', Cable connected: on, Trace: off (file: none), Type: Am79C973, Reported speed: 0 Mbps
-NIC 3:           MAC: 08002745B49F, Attachment: Bridged Interface 'en0: Ethernet', Cable connected: on, Trace: off (file: none), Type: Am79C973, Reported speed: 0 Mbps
-raw
   end
 
   context "saving" do
     setup do
-      @nic = VirtualBox::Nic.populate_relationship(@caller, @data)
+      @nic = VirtualBox::Nic.populate_relationship(@caller, mock_xml_doc)
       @vmname = "myvm"
     end
 
@@ -62,68 +50,27 @@ raw
 
   context "populating relationships" do
     setup do
-      @value = VirtualBox::Nic.populate_relationship(@caller, @data)
+      @value = VirtualBox::Nic.populate_relationship(@caller, mock_xml_doc)
     end
 
     should "create the correct amount of objects" do
-      assert_equal 3, @value.length
-    end
-
-    should "parse the type" do
-      assert_equal "Am79C973", @value[0].nictype
+      assert_equal 8, @value.length
     end
-  end
 
-  context "parsing nic data from human readable output" do
-    setup do
-      @raw = "NIC 1:           MAC: 08002745B49F, Attachment: Bridged Interface 'en0: Ethernet', Cable connected: on, Trace: off (file: none), Type: Am79C973, Reported speed: 0 Mbps"
-
-      @multiline_raw = <<-raw
-Storage Controller Port Count (0):      2
-Storage Controller Name (1):            Floppy Controller
-Storage Controller Type (1):            I82078
-Storage Controller Instance Number (1): 0
-Storage Controller Max Port Count (1):  1
-Storage Controller Port Count (1):      1
-IDE Controller (0, 0): /Users/mitchellh/Library/VirtualBox/HardDisks/HoboBase.vmdk (UUID: fb0256a9-5685-4bc2-98ff-5b7503586bf3)
-IDE Controller (1, 0): Empty
-Floppy Controller (0, 0): Empty
-NIC 1:           MAC: 08002745B49F, Attachment: Bridged Interface 'en0: Ethernet', Cable connected: on, Trace: off (file: none), Type: Am79C973, Reported speed: 0 Mbps
-NIC 2:           disabled
-raw
+    should "not be dirty initially" do
+      assert !@value[0].changed?
     end
 
-    should "only return valid objects in hash" do
-      VirtualBox::VM.expects(:human_info).returns(@multiline_raw)
-      result = VirtualBox::Nic.nic_data("foo")
-      assert result.is_a?(Hash)
-      assert_equal 1, result.length
+    should "be an existing record" do
+      assert !@value[0].new_record?
     end
 
-    should "return nil if its an invalid string" do
-      assert_nil VirtualBox::Nic.parse_nic("FOO")
-    end
-
-    should "return proper data for valid string" do
-      @name = :nic1
-      @expected = {
-        :mac => "08002745B49F",
-        :attachment => "Bridged Interface 'en0: Ethernet'",
-        :trace => "off (file: none)",
-        :type => "Am79C973"
-      }
-
-      name, result = VirtualBox::Nic.parse_nic(@raw)
-      assert_equal @name, name
-      assert result.is_a?(Hash)
-
-      @expected.each do |k,v|
-        assert_equal v, result[k]
-      end
+    should "parse the type" do
+      assert_equal "Am79C973", @value[0].nictype
     end
 
-    should "ignore nics that are disabled" do
-      assert_nil VirtualBox::Nic.parse_nic("NIC 1:    disabled")
+    should "correctly turn adapters which aren't enabled into 'none'" do
+      assert_equal "none", @value[2].nic
     end
   end
 end

data/test/virtualbox/shared_folder_test.rb

@@ -45,7 +45,7 @@ class SharedFolderTest < Test::Unit::TestCase
 
   context "saving an existing shared folder" do
     setup do
-      @value = VirtualBox::SharedFolder.populate_relationship(@caller, @data)
+      @value = VirtualBox::SharedFolder.populate_relationship(@caller, mock_xml_doc)
       @value = @value[0]
       @value.name = "different"
       assert @value.changed?
@@ -170,7 +170,7 @@ class SharedFolderTest < Test::Unit::TestCase
 
   context "destroying" do
     setup do
-      @value = VirtualBox::SharedFolder.populate_relationship(@caller, @data)
+      @value = VirtualBox::SharedFolder.populate_relationship(@caller, mock_xml_doc)
       @value = @value[0]
     end
 
@@ -200,7 +200,7 @@ class SharedFolderTest < Test::Unit::TestCase
 
   context "populating relationships" do
     setup do
-      @value = VirtualBox::SharedFolder.populate_relationship(@caller, @data)
+      @value = VirtualBox::SharedFolder.populate_relationship(@caller, mock_xml_doc)
     end
 
     should "be a 'collection'" do
@@ -213,11 +213,11 @@ class SharedFolderTest < Test::Unit::TestCase
 
     should "parse the proper data" do
       value = @value[0]
-      assert_equal "foofolder", value.name
+      assert_equal "foo", value.name
       assert_equal "/foo", value.hostpath
 
       value = @value[1]
-      assert_equal "barfolder", value.name
+      assert_equal "bar", value.name
       assert_equal "/bar", value.hostpath
     end
   end

data/test/virtualbox/storage_controller_test.rb

@@ -17,7 +17,7 @@ class StorageControllerTest < Test::Unit::TestCase
 
   context "saving" do
     setup do
-      @value = VirtualBox::StorageController.populate_relationship(@caller, @data)
+      @value = VirtualBox::StorageController.populate_relationship(@caller, mock_xml_doc)
       @value = @value[0]
     end
 
@@ -29,7 +29,7 @@ class StorageControllerTest < Test::Unit::TestCase
 
   context "destroying" do
     setup do
-      @value = VirtualBox::StorageController.populate_relationship(@caller, @data)
+      @value = VirtualBox::StorageController.populate_relationship(@caller, mock_xml_doc)
       @value = @value[0]
     end
 
@@ -52,40 +52,25 @@ class StorageControllerTest < Test::Unit::TestCase
   end
 
   context "populating relationships" do
-    should "create the correct amount of objects" do
-      value = VirtualBox::StorageController.populate_relationship(@caller, @data)
-      assert_equal 2, value.length
-    end
-
-    should "use populate keys when extracting keys" do
-      value = VirtualBox::StorageController.new(0, @caller, @data)
-      assert_equal "foo", value.name
-      assert_equal 7, value.max_ports
+    setup do
+      @sc = mock_xml_doc.css("StorageControllers StorageController").first
     end
 
-    should "call populate attributes with the merged populate data" do
-      VirtualBox::StorageController.any_instance.expects(:extract_devices).returns({ :name => "BAR" })
-      value = VirtualBox::StorageController.new(0, @caller, @data)
-      assert_equal "BAR", value.name
+    should "create a collection proxy" do
+      value = VirtualBox::StorageController.populate_relationship(@caller, mock_xml_doc)
+      assert value.is_a?(VirtualBox::Proxies::Collection)
     end
-  end
 
-  context "extracting related device info" do
-    setup do
-      @controller = VirtualBox::StorageController.new(0, @caller, @data)
+    should "create the correct amount of objects" do
+      value = VirtualBox::StorageController.populate_relationship(@caller, mock_xml_doc)
+      assert_equal 1, value.length
     end
 
-    should "extract only those keys related to current controller name" do
-      data = @controller.extract_devices(0, @data)
-      assert data
-      assert data.has_key?(:"foo-0-0")
-      assert data.has_key?(:"foo-1-0")
-      assert !data.has_key?(:"bar-0-0")
-
-      data = @controller.extract_devices(1, @data)
-      assert data
-      assert !data.has_key?(:"foo-0-0")
-      assert data.has_key?(:"bar-0-0")
+    should "use populate keys when extracting keys" do
+      value = VirtualBox::StorageController.new(0, @caller, @sc)
+      assert_equal "foo", value.name
+      assert_equal "2", value.ports
+      assert_equal "PIIX4", value.type
     end
   end
 end

data/test/virtualbox/system_property_test.rb

@@ -0,0 +1,71 @@
+require File.join(File.dirname(__FILE__), '..', 'test_helper')
+
+class SystemPropertyTest < Test::Unit::TestCase
+  setup do
+    @raw = <<-raw
+VirtualBox Command Line Management Interface Version 3.1.2
+(C) 2005-2009 Sun Microsystems, Inc.
+All rights reserved.
+
+Minimum guest RAM size:          4 Megabytes
+Maximum guest RAM size:          3584 Megabytes
+Minimum video RAM size:          1 Megabytes
+Maximum video RAM size:          128 Megabytes
+Minimum guest CPU count:         1
+Maximum guest CPU count:         32
+Maximum VDI size:                2097151 Megabytes
+Maximum Network Adapter count:   8
+Maximum Serial Port count:       2
+Maximum Parallel Port count:     2
+Maximum Boot Position:           4
+Maximum IDE Controllers:         1
+Maximum IDE Port count:          2
+Maximum Devices per IDE Port:    2
+Maximum SATA Controllers:        1
+Maximum SATA Port count:         30
+Maximum Devices per SATA Port:   1
+Maximum SCSI Controllers:        1
+Maximum SCSI Port count:         16
+Maximum Devices per SCSI Port:   1
+Maximum Floppy Controllers:      1
+Maximum Floppy Port count:       1
+Maximum Devices per Floppy Port: 2
+Default machine folder:          /Users/mitchellh/Library/VirtualBox/Machines
+Default hard disk folder:        /Users/mitchellh/Library/VirtualBox/HardDisks
+VRDP authentication library:     VRDPAuth
+Webservice auth. library:        VRDPAuth
+Log history count:               3
+raw
+  end
+
+  context "getting all system properties" do
+    setup do
+      VirtualBox::Command.stubs(:vboxmanage).returns(@raw)
+    end
+
+    should "return a new SystemProperty object" do
+      result = VirtualBox::SystemProperty.all
+      assert result.is_a?(VirtualBox::SystemProperty)
+    end
+
+    should "run the vboxmanage command and parse its output" do
+      raw = mock("raw")
+      VirtualBox::Command.expects(:vboxmanage).with("list", "systemproperties").returns(raw)
+      VirtualBox::SystemProperty.expects(:parse_raw).with(raw).returns("foo")
+      VirtualBox::SystemProperty.all
+    end
+  end
+
+  context "parsing the raw output" do
+    should "return a hash with the proper number of values" do
+      result = VirtualBox::SystemProperty.parse_raw(@raw)
+      assert result.is_a?(Hash)
+      assert_equal 28, result.length
+    end
+
+    should "lowercase and convert each key to a symbol" do
+      result = VirtualBox::SystemProperty.parse_raw(@raw)
+      assert_equal "30", result[:maximum_sata_port_count]
+    end
+  end
+end

data/test/virtualbox/usb_test.rb

@@ -0,0 +1,35 @@
+require File.join(File.dirname(__FILE__), '..', 'test_helper')
+
+class UsbTest < Test::Unit::TestCase
+  setup do
+    @caller = mock("caller")
+    @caller.stubs(:name).returns("foo")
+  end
+
+  context "populating relationships" do
+    setup do
+      @value = VirtualBox::USB.populate_relationship(@caller, mock_xml_doc)
+    end
+
+    should "create the correct amount of objects" do
+      assert_equal 2, @value.length
+    end
+
+    should "not be dirty initially" do
+      assert !@value[0].changed?
+    end
+
+    should "be an existing record" do
+      assert !@value[0].new_record?
+    end
+
+    should "parse attributes correctly" do
+      assert_equal 'true', @value[0].active
+      assert_equal 'Apple, Inc', @value[0].manufacturer
+      assert_equal 'Apple, Inc Apple Keyboard [0069]', @value[0].name
+      assert_equal @caller, @value[0].parent
+      assert_equal 'Apple Keyboard', @value[0].product
+      assert_equal 'no', @value[0].remote
+    end
+  end
+end

data/test/virtualbox/vm_test.rb

@@ -2,77 +2,8 @@ require File.join(File.dirname(__FILE__), '..', 'test_helper')
 
 class VMTest < Test::Unit::TestCase
   setup do
-    @raw = <<-showvminfo
-name="foo"
-ostype="Ubuntu"
-UUID="8710d3db-d96a-46ed-9004-59fa891fda90"
-CfgFile="/Users/mitchellh/Library/VirtualBox/Machines/foo/foo.xml"
-hardwareuuid="8710d3db-d96a-46ed-9004-59fa891fda90"
-memory=360
-vram=12
-cpus=1
-synthcpu="off"
-bootmenu="messageandmenu"
-boot1="floppy"
-boot2="dvd"
-boot3="disk"
-boot4="none"
-acpi="on"
-ioapic="off"
-pae="on"
-biossystemtimeoffset=0
-hwvirtex="on"
-hwvirtexexcl="off"
-nestedpaging="off"
-vtxvpid="off"
-VMState="poweroff"
-VMStateChangeTime="2010-01-22T22:02:47.672000000"
-monitorcount=1
-accelerate3d="off"
-accelerate2dvideo="off"
-teleporterenabled="off"
-teleporterport=0
-teleporteraddress="<NULL>"
-teleporterpassword="<NULL>"
-storagecontrollername0="IDE Controller"
-storagecontrollertype0="PIIX4"
-storagecontrollerinstance0="0"
-storagecontrollermaxportcount0="2"
-storagecontrollerportcount0="2"
-storagecontrollername1="Floppy Controller"
-storagecontrollertype1="I82078"
-storagecontrollerinstance1="0"
-storagecontrollermaxportcount1="1"
-storagecontrollerportcount1="1"
-"IDE Controller-0-0"="/Users/mitchellh/Library/VirtualBox/HardDisks/HoboBase.vmdk"
-"IDE Controller-ImageUUID-0-0"="5e090af6-7d71-4f40-8b03-33aa665f9ecf"
-"IDE Controller-0-1"="none"
-"IDE Controller-1-0"="emptydrive"
-"IDE Controller-1-1"="none"
-"Floppy Controller-0-0"="emptydrive"
-"Floppy Controller-0-1"="none"
-bridgeadapter1="en1: AirPort"
-macaddress1="08002771F257"
-cableconnected1="on"
-nic1="bridged"
-nic2="none"
-nic3="none"
-nic4="none"
-nic5="none"
-nic6="none"
-nic7="none"
-nic8="none"
-uart1="off"
-uart2="off"
-audio="none"
-clipboard="bidirectional"
-vrdp="off"
-usb="off"
-SharedFolderNameMachineMapping1="mysharedfolder"
-SharedFolderPathMachineMapping1="/virtualbox"
-SharedFolderNameMachineMapping2="otherfolder"
-SharedFolderPathMachineMapping2="/virtualbox/lib"
-showvminfo
+    @raw_xml = mock_xml
+    @raw_xml_doc = mock_xml_doc
 
     @name = "foo"
 
@@ -81,30 +12,20 @@ showvminfo
   end
 
   def create_vm
-    VirtualBox::Command.expects(:vboxmanage).with("showvminfo", @name, "--machinereadable").returns(@raw)
-    VirtualBox::Command.expects(:vboxmanage).with("showvminfo", @name).returns("")
-    VirtualBox::Command.expects(:vboxmanage).with("list", "hdds").returns("")
-    VirtualBox::Command.expects(:vboxmanage).with("list", "dvds").returns("")
-    VirtualBox::Command.expects(:vboxmanage).with("getextradata", @name, "enumerate").returns("")
-    vm = VirtualBox::VM.find(@name)
+    VirtualBox::Command.expects(:parse_xml).returns(@raw_xml_doc)
+    vm = VirtualBox::VM.load_from_xml(@name)
     assert vm
     vm
   end
 
-  context "human readable info" do
-    should "not pass --machinereadable into the showvminfo command" do
-      VirtualBox::Command.expects(:vboxmanage).with("showvminfo", @name).once
-      VirtualBox::VM.human_info(@name)
-    end
-  end
-
   context "reading the VM state" do
     setup do
       @vm = create_vm
     end
 
-    should "read the initial state when loading the VM" do
-      assert_equal "poweroff", @vm.state
+    should "lazy load the state" do
+      @vm.expects(:load_attribute).with(:state).once
+      @vm.state
     end
 
     should "reload the state if true is passed as a parameter" do
@@ -269,24 +190,39 @@ showvminfo
       VirtualBox::Command.expects(:vboxmanage).with("unregistervm", @name, "--delete").in_sequence(destroy_seq)
       @vm.destroy
     end
+
+    should "mark global for reloading" do
+      VirtualBox::Global.expects(:reload!)
+      @vm.destroy
+    end
   end
 
   context "finding all VMs" do
     setup do
-      @raw = <<-raw
-"foo" {abcdefg}
-"bar"  {zefaldf}
-raw
+      VirtualBox::VM.reloaded!
+
+      @global = mock("global")
+      @global.stubs(:vms)
     end
 
     should "list VMs then parse them" do
-      all_seq = sequence("all")
-      VirtualBox::Command.expects(:vboxmanage).with("list", "vms").returns(@raw).in_sequence(all_seq)
-      VirtualBox::VM.expects(:parse_vm_list).with(@raw).in_sequence(all_seq)
+      VirtualBox::Global.expects(:global).with(false).returns(@global)
       VirtualBox::VM.all
     end
 
+    should "reload the VMs list if given the reload argument" do
+      VirtualBox::Global.expects(:global).with(true).returns(@global)
+      VirtualBox::VM.all(true)
+    end
+
     context "parser" do
+      setup do
+      @raw = <<-raw
+"foo" {abcdefg}
+"bar"  {zefaldf}
+raw
+      end
+
       should "ignore non-matching lines" do
         assert VirtualBox::VM.parse_vm_list("HEY YOU").empty?
       end
@@ -344,6 +280,15 @@ raw
       VirtualBox::AttachedDevice.any_instance.stubs(:save)
     end
 
+    teardown do
+      VirtualBox::Global.reloaded!
+    end
+
+    should "force a reload on the global class" do
+      VirtualBox::Global.expects(:reload!).once
+      assert @vm.save
+    end
+
     should "return false if saving fails" do
       VirtualBox::Command.stubs(:vboxmanage).raises(VirtualBox::Exceptions::CommandFailedException)
 
@@ -388,50 +333,46 @@ raw
     end
   end
 
+  context "loading a VM from XML" do
+    should "parse the XML then initializing the class" do
+      VirtualBox::Command.expects(:parse_xml).with("foo").returns(@raw_xml_doc)
+      VirtualBox::VM.expects(:new).with(@raw_xml_doc).once
+      VirtualBox::VM.load_from_xml("foo")
+    end
+
+    should "initialize the attributes when called with an XML document" do
+      VirtualBox::VM.any_instance.expects(:initialize_attributes).once.with(@raw_xml_doc)
+      VirtualBox::VM.new(@raw_xml_doc)
+    end
+  end
+
+  context "initializing attributes" do
+    # TODO: This needs to be tested
+  end
+
   context "finding a VM by name" do
     setup do
-
       @expected = {
         :name   => "foo",
         :ostype => "Ubuntu",
         :uuid   => "8710d3db-d96a-46ed-9004-59fa891fda90"
       }
-
-      command_seq = sequence("command_seq)")
-      VirtualBox::Command.expects(:vboxmanage).with("showvminfo", @name, "--machinereadable").returns(@raw).in_sequence(command_seq)
-      VirtualBox::Command.expects(:vboxmanage).returns("").at_least(0).in_sequence(command_seq)
-      @vm = VirtualBox::VM.find(@name)
-      assert @vm
     end
 
-    should "return a VM object with proper attributes" do
+    should "use the global 'all' array to find the VM" do
+      VirtualBox::VM.expects(:all).with(true).returns([create_vm])
+      vm = VirtualBox::VM.find(@name)
+      assert vm
+
       @expected.each do |k,v|
-        assert_equal v, @vm.read_attribute(k)
+        assert_equal v, vm.read_attribute(k)
       end
     end
 
     should "return nil if the VM doesn't exist" do
-      VirtualBox::Command.expects(:vboxmanage).raises(VirtualBox::Exceptions::CommandFailedException)
+      VirtualBox::VM.expects(:all).returns([])
       assert_nil VirtualBox::VM.find("dont exist")
     end
-
-    should "properly load nic relationship" do
-      assert @vm.nics
-      assert @vm.nics.is_a?(Array)
-      assert_equal 8, @vm.nics.length
-    end
-
-    should "properly load storage controller relationship" do
-      assert @vm.storage_controllers
-      assert @vm.storage_controllers.is_a?(Array)
-      assert_equal 2, @vm.storage_controllers.length
-    end
-
-    should "properly load shared folder relationship" do
-      assert @vm.shared_folders
-      assert @vm.shared_folders.is_a?(Array)
-      assert_equal 2, @vm.shared_folders.length
-    end
   end
 
   context "parsing the showvminfo output" do